730 Commits

Author	SHA1	Message	Date
freemo	b96154d612	fix(session): session export checksum stored with sha256 prefix per spec #1450 (#1481) ... Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me> Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>	2026-04-02 19:29:50 +00:00
freemo	48cff5cfe0	refactor(cli): rename plan lifecycle-list and lifecycle-apply to match specification ... Renames `plan lifecycle-list` to `plan list` and `plan lifecycle-apply` to `plan apply` to align with the specification's canonical command names. Removes legacy V2 plan commands that occupied those names. - Renamed CLI command registrations from lifecycle-list/lifecycle-apply to list/apply - Removed legacy V2 apply and list commands (~200 lines) - Updated apply shortcut in main.py to delegate to v3 lifecycle - Added defensive null check for plan existence in apply command - Updated 63+ test, doc, and benchmark files for consistency Closes #881 Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me> Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>	2026-04-02 19:09:04 +00:00
freemo	d0ef563175	feat(mcp): implement lazy start/auto-stop and sandbox path rewriting for MCP tools ... Add lifecycle management and sandbox support for MCP tools: - McpClient: lazy start, configurable idle timeout with auto-stop, health monitoring with automatic restart - McpRegistry: namespace-isolated tracking of multiple MCP servers - SandboxPathRewriter: bi-directional file path rewriting between host and sandbox workspaces - MCPCapabilityMetadata: structured exposure of full MCP server capabilities - 26 BDD scenarios covering lifecycle, sandbox rewriting, and edge cases ISSUES CLOSED: #938	2026-04-02 18:18:40 +00:00
freemo	2a266929fd	Merge pull request 'bug(cli): automation_profile._get_service() bypasses DI container' (#1181) from bugfix/m4-automation-profile-di-bypass into master	2026-04-02 17:54:14 +00:00
freemo	7e4301066c	Merge pull request 'refactor(cli): move context commands to actor context subgroup' (#1194) from feature/m4-actor-context-hierarchy into master	2026-04-02 17:53:42 +00:00
freemo	bcf54d08c9	Merge pull request 'feat(plugin): register spec-defined extension points in PluginManager' (#1217) from feature/plugin-extension-points into master	2026-04-02 17:40:18 +00:00
freemo	085f71a69d	feat(ci): add Helm chart lint and template validation to CI ... Add kubeconform manifest validation to the existing helm CI job. The helm job already had helm lint and helm template steps (added in #1085). This commit completes the optional acceptance criterion from #1089 by adding kubeconform v0.7.0 to validate rendered manifests against the Kubernetes 1.29.0 schema in strict mode. Closes #1089	2026-04-02 17:40:00 +00:00
freemo	6c94ad9552	Merge pull request 'fix: add --required/--informational flags to validation add CLI' (#1222) from bugfix/m5-validation-required-flag into master	2026-04-02 17:39:19 +00:00
freemo	f035e2efbd	Merge pull request 'feat(tui): implement first-run experience with actor selection overlay' (#1391) from feature/m8-tui-first-run into master	2026-04-02 17:33:44 +00:00
freemo	d0515ff1ac	feat(tui): implement session export/import (JSON + Markdown) ... Add Markdown export format for sessions alongside the existing JSON export. Implement TUI slash command routing for /session:export and /session:import. - Add Session.as_export_markdown() domain method producing a human-readable Markdown transcript (lossy, not importable — for sharing/documentation) - Extend CLI 'agents session export' with --format flag (json|md) - Extend TuiCommandRouter._session_command() to handle 'export' and 'import' subcommands, delegating to the session service via the DI container - Add 16 Behave scenarios covering domain model, CLI, and TUI command paths Closes #1004	2026-04-02 17:30:37 +00:00
freemo	2e24483947	feat(tui): implement session export/import (JSON + Markdown) ... Add Markdown export format for sessions alongside the existing JSON export. Implement TUI slash command routing for /session:export and /session:import. - Add Session.as_export_markdown() domain method producing a human-readable Markdown transcript (lossy, not importable — for sharing/documentation) - Extend CLI 'agents session export' with --format flag (json|md) - Extend TuiCommandRouter._session_command() to handle 'export' and 'import' subcommands, delegating to the session service via the DI container - Add 16 Behave scenarios covering domain model, CLI, and TUI command paths Closes #1004	2026-04-02 17:16:59 +00:00
freemo	2863b5d1e1	feat(tui): implement first-run experience with actor selection overlay ... Implements the first-run experience for the TUI as specified in the specification's 'First-Run Experience' section (§ TUI Architecture). On first launch (no personas configured), a centered ActorSelectionOverlay widget is displayed guiding the user to select an actor. The overlay supports keyboard navigation (j/k), fuzzy search (/), and confirmation (enter). Selecting an actor creates a default persona and dismisses the overlay. Changes: - Add src/cleveragents/tui/first_run.py: is_first_run() detection helper and create_default_persona_for_actor() setup helper - Add src/cleveragents/tui/widgets/actor_selection_overlay.py: ActorSelectionOverlay widget with show/hide/navigate/search/confirm API and render_actor_selection() pure rendering function - Update src/cleveragents/tui/app.py: integrate first-run check in on_mount(), yield ActorSelectionOverlay in compose(), add _complete_first_run() method - Update src/cleveragents/tui/widgets/__init__.py: export ActorSelectionOverlay - Add features/tui_first_run.feature + features/steps/tui_first_run_steps.py: comprehensive Behave BDD tests covering all public API paths ISSUES CLOSED: #1007	2026-04-02 17:12:54 +00:00
freemo	0787f42e2f	feat(acms): operationalize UKO runtime with provenance and temporal versioning ... Operationalizes the Universal Knowledge Ontology (UKO) runtime per issue #891, implementing provenance tracking, temporal versioning, ACMS context strategy integration, four-layer ontology population, implicit relationship inference, and graph persistence. New services: - UKOQueryInterface: typed interface for ACMS context strategies to query UKO classification data - UKOInferenceEngine: semantic analysis producing implicit triples with confidence 0.7 - UKOGraphPersistence: serialises/restores UKO graph state via JSON or in-memory backends Modified: uko_indexer_internals.py index_graph() now runs inference and populates uko:layer triples for all four ontology layers. 47 BDD scenarios covering all acceptance criteria. Closes #891 Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me> Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>	2026-04-02 17:09:15 +00:00
freemo	ee980ee117	feat(resource): implement DevcontainerHandler missing protocol methods (#1286) ... Implements the four missing protocol methods on DevcontainerHandler required by Epic #825 (ResourceHandler Protocol Completion): - delete(): uses 'devcontainer exec rm -rf' to delete files/dirs inside the container; returns DeleteResult(success=False) for missing/stopped containers rather than raising. - list_children(): uses 'devcontainer exec ls -1' to enumerate workspace entries; returns an empty list on container failure. - diff(): compares content hashes between the devcontainer workspace and another filesystem location; uses EMPTY_CONTENT_HASH sentinel to treat both-absent as no-change. - create_sandbox(): delegates to BaseResourceHandler.create_sandbox with lazy activation (same DETECTED/STOPPED/FAILED guard as resolve()). All methods raise ValueError for resources with no location. Adds 18 Behave BDD scenarios covering success paths, failure/stopped-container paths, empty-path edge cases, and ValueError guards. ISSUES CLOSED: #1242 Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me> Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>	2026-04-02 17:08:52 +00:00
freemo	c2097ee2ed	feat(events): enrich PLAN_APPLIED event with changeset statistics from PlanApplyService ... Enriches the PLAN_APPLIED domain event with SEC7 audit-logging statistics per docs/specification.md §Audit Logging (issue #716). Changes: - PlanLifecycleService.complete_apply() now accepts optional keyword arguments: files_changed, lines_added, lines_removed, resources_modified, apply_duration_seconds (all default to 0). These are included in the PLAN_APPLIED event details dict alongside the existing action_name, phase, and project_names fields. - PlanApplyService.apply_with_validation_gate() computes changeset statistics from SpecChangeSet.summary() and measures apply duration, then passes all statistics to complete_apply(). - New BDD feature features/plan_applied_event_enrichment.feature with 13 scenarios. Closes #716 Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me> Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>	2026-04-02 17:08:38 +00:00
freemo	4a18a15ca5	feat(tui): implement PermissionsScreen with diff view ... Implement PermissionsScreen with diff view for tool permission requests. - 3 diff display modes (unified, side-by-side, context) - Allow/reject keyboard bindings - Permission decision persistence - 62 BDD scenarios covering all components ISSUES CLOSED: #996 Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me> Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>	2026-04-02 17:08:13 +00:00
freemo	ec52acffb7	feat(resource): implement DatabaseResourceHandler CRUD and checkpoint methods ... Implements all missing CRUD and checkpoint methods on DatabaseResourceHandler per issue #1241 (Epic #825 ResourceHandler Protocol Completion): - read(): SQLite queries sqlite_master for schema; remote returns connection-info - write(): SQLite executes SQL statements; remote returns not-supported result - delete(): SQLite executes DROP TABLE IF EXISTS; remote returns not-supported - list_children(): SQLite lists tables/views from sqlite_master; remote returns [] - diff(): compares schemas via content_hash on both sides - create_checkpoint(): SQLite creates SAVEPOINT on open connection; remote uses content-hash fallback - rollback_to(): SQLite executes ROLLBACK TO SAVEPOINT; remote returns not-supported All methods handle errors gracefully (no unhandled exceptions). Adds comprehensive Behave BDD tests covering all methods for both SQLite and remote database types. ISSUES CLOSED: #1241 Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me> Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>	2026-04-02 17:08:05 +00:00
freemo	0989f58dc8	feat(estimation): wire actor.default.estimation config fallback and Strategize-to-Estimate lifecycle hook (#1310) ... Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me> Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>	2026-04-02 17:07:48 +00:00
freemo	cfc9e04a90	feat(tui): implement actor thought block rendering ... Implement ThoughtBlock domain model with configurable max_lines (default 10), expanded state, and helper methods for rendering truncated/full content. Implement ThoughtBlockWidget TUI widget with muted styling, collapsed/expanded state, and expand/collapse toggle. Add 23 Behave BDD scenarios covering domain model and widget behaviour. Closes #1001 ISSUES CLOSED: #1001 Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me> Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>	2026-04-02 17:07:47 +00:00
freemo	65aa7a7842	feat(events): enrich PLAN_CANCELLED event with progress and resource cleanup context (#1301) ... Enriches the PLAN_CANCELLED domain event emitted by PlanLifecycleService.cancel_plan() with additional context fields to improve audit trail quality (SEC7 Audit Logging). Progress context fields: cancelled_phase, cancelled_processing_state, last_completed_step, subplan_count Resource cleanup context fields: sandbox_refs, changeset_id, resources_pending_cleanup Existing fields (reason, project_names) preserved for backward compatibility. 15 BDD scenarios added covering all new fields, accuracy, and backward compatibility. Closes #717 Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me> Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>	2026-04-02 17:07:41 +00:00
freemo	1d36449a98	fix(cli): remove extra --mode flag from validation attach ... Remove the --mode/-m CLI flag from the validation attach command to align with the specification, which defines validation mode as an inherent property of the validation definition set at registration time via validation add, not as a per-attachment override. The service layer (ToolRegistryService.attach_validation) no longer accepts mode as a parameter; instead it reads the mode from the validation's registered definition. The ToolRegistryRepository _to_legacy_domain now exposes the mode field so the service can access it. All tests that passed --mode to the CLI or service have been updated or removed. The invalid-mode validation scenarios were removed since the mode is no longer caller-supplied. Coverage remains at 98.7%. ISSUES CLOSED: #913 Co-authored-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com> Co-committed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com>	2026-04-02 17:07:26 +00:00
freemo	f0a40afecc	refactor(audit): implement async audit recording to unblock event pipeline (#1279) ... Implements a write-behind queue with a background daemon thread in AuditService so that record() returns immediately without blocking the calling domain operation on a synchronous SQLite INSERT + COMMIT. Changes: - AuditService: add _writer_loop(), _write_payload(), flush() methods and a write-behind queue with a background thread - record() enqueues the payload and returns a placeholder entry with id=-1 in async mode - close() calls flush() to drain the queue before closing the session - Settings: add audit_async (default True) and audit_queue_maxsize (default 10000) fields - 20 BDD scenarios covering non-blocking record(), flush/close lifecycle, ordering, sync fallback, and settings Closes #718 Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me> Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>	2026-04-02 17:00:53 +00:00
freemo	c63f397b6c	fix(cli): add -f short form to project delete --force (#1263) ... Resolve the -f short flag conflict on `project delete` where --format claimed -f despite the specification reserving it for --force. Changes: - Add -f short alias to --force on the delete command, aligning with the spec: `agents project delete [--force|-f] [--yes|-y] <NAME>` - Remove -f short alias from --format on delete (keep --format long form only); the spec does not define --format on this command - Update module docstring to reflect spec-aligned flag signatures - Add BDD scenario exercising -f via CliRunner to validate the Typer argument parser maps -f to --force (not --format) ISSUES CLOSED: #911 Reviewed-by: reviewer-pool-1 Closes #911 Co-authored-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com> Co-committed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com>	2026-04-02 16:59:48 +00:00
freemo	dd3770f930	refactor(correction): eliminate redundant fields in CorrectionDryRunReport (#1278) ... Remove three top-level fields from CorrectionDryRunReport that duplicated data already present in the embedded CorrectionImpact object: - excluded_decisions → now accessed via report.impact.excluded_decisions - rollback_tier_depth → now accessed via report.impact.rollback_tier_depth - child_plans_to_rollback → now accessed via report.impact.affected_child_plans The redundant fields created a divergence risk: both models are frozen=True Pydantic models, so post-construction mutation is impossible, but nothing prevented constructing an instance where the top-level copies disagreed with the impact sub-object. Approach: Option B (nest-only) — remove the duplicated top-level fields and update all consumers to use the impact object's fields instead. Closes #1087 Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me> Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>	2026-04-02 16:59:40 +00:00
freemo	4537bf25e3	test(e2e): validate M6 acceptance criteria for v3.5.0 milestone closure (#1277) ... Add dedicated m6_autonomy_acceptance.feature BDD test file that validates all v3.5.0 milestone acceptance criteria: - AC-1: A2A facade session and plan lifecycle operations - AC-2: Event queue publish/subscribe operational - AC-3: Guard enforcement (denylist, budget caps, tool call limits) - AC-4: Automation profile resolution precedence (plan > action > global) - A2A transport stub, version negotiation, model validation coverage Closes #497 Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me> Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>	2026-04-02 16:59:36 +00:00
freemo	e5398e3cc7	feat(server): implement serve CLI subcommand and align Dockerfile entrypoint ... The `cleveragents server serve` CLI subcommand already exists in server.py and Dockerfile.server already uses `python -m cleveragents` as its ENTRYPOINT with `server serve` as the CMD. Add BDD scenarios to k8s_helm_chart.feature that explicitly verify: - Dockerfile.server ENTRYPOINT uses `python -m cleveragents` - Dockerfile.server CMD includes the `server serve` subcommand tokens Add corresponding step definitions to k8s_helm_chart_steps.py. Closes #1088 Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me> Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>	2026-04-02 16:59:14 +00:00
brent.edwards	e3d3c7926d	feat(events): add user_identity field to DomainEvent and propagate through event pipeline (#1257) ... Co-authored-by: Brent Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent Edwards <brent.edwards@cleverthis.com>	2026-04-02 16:59:07 +00:00
brent.edwards	5437c73420	perf(test): replace per-instance _database_initialized flag with process-global cache (#1264) ... Add a process-global `_INITIALIZED_DBS: set[str]` to `features/environment.py` that caches database URLs after `_fast_init_or_upgrade` has processed them. On subsequent calls with the same URL, the function returns immediately — skipping all URL parsing, path extraction, prefix matching, and `stat()` syscalls that previously executed on every new `UnitOfWork` instance. The cache is cleared at the start of each scenario in `before_scenario` to prevent cross-scenario state leaks, since each scenario receives fresh temp-DB paths via `tempfile.mktemp()`. Four new Behave scenarios validate cache hits on repeated calls, cache clearing between scenarios, and non-caching of non-matching-prefix URLs. Estimated savings: ~65,000 unnecessary function-body executions eliminated per full test run (~7 UnitOfWork instantiations × ~10,700 scenarios). ISSUES CLOSED: #735 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com> Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-04-02 16:58:39 +00:00
brent.edwards	f4432c2759	refactor(cleanup): remove or implement empty stub packages ... Remove four empty stub packages that contained only __init__.py with __all__ = [] and no functional code, violating CONTRIBUTING.md §Commit Completeness. All four were audited against docs/specification.md: - src/cleveragents/runtime/ — Spec defines four layers (Domain, Application, Infrastructure, Presentation) with no Runtime Layer. Runtime concepts (LSP Runtime, actor runtime) belong in Infrastructure. - src/cleveragents/domain/repositories/ — Spec mentions repository interfaces in Domain but mandates no separate subpackage. Empty with no protocols defined; existing models cover the domain. - src/cleveragents/domain/plans/ — Plan domain models already exist in domain/models/planconfig, planfiles, and plansettings. Empty duplicate. - src/cleveragents/application/workflows/ — Application logic already served by application/services/. Empty stub added no value. Updated test references in features/steps/module_coverage_steps.py, features/steps/coverage_extras_steps.py, features/architecture.feature, and robot/architecture.robot to remove the deleted packages from import verification and architecture validation lists. ISSUES CLOSED: #948 Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-04-02 16:58:36 +00:00
freemo	be69a49eff	fix(cli): add -u short form to lsp add --update ... Add the missing `-u` short-form alias for the `--update` option on the `lsp add` command, aligning the implementation with the specification (spec line 8645: `agents lsp add [--update|-u] (--config|-c) <FILE>`). The Typer option declaration in `lsp.py` now includes `"-u"` alongside `"--update"`. A new Behave scenario ("Add LSP server with -u short form overwrites existing") and its step definition verify the short form works end-to-end through the CLI runner. No conflicts exist — `-u` was not claimed by any other option on `lsp add` (existing short forms: `-c` for `--config`, `-f` for `--format`). ISSUES CLOSED: #912 Co-authored-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com> Co-committed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com>	2026-04-02 16:58:32 +00:00
CoreRasurae	1e987a2009	feat(events): wire all 38 domain event emissions into services (#1215) ... Co-authored-by: Luis Mendes <luis.mendes@cleverthis.com> Co-committed-by: Luis Mendes <luis.mendes@cleverthis.com>	2026-04-02 16:53:03 +00:00
hamza.khyari	c200fe0f86	feat(lsp): implement get_hover and get_definitions for LSP runtime (#1240) ... Add hover and definition support to LspClient and LspRuntime. - LspClient.get_hover(): sends textDocument/hover, returns Hover dict or None - LspClient.get_definitions(): sends textDocument/definition, handles Location, Location[], and LocationLink[] responses - LspRuntime wrappers: input validation, file reading, language detection, 1-based to 0-based line/column conversion - try/finally for did_close() safety on both new methods - Tool adapter: HOVER and DEFINITIONS dispatch to runtime instead of raising LspNotAvailableError - Updated lsp_tool_adapter_coverage test (HOVER -> REFERENCES) - 21 Behave BDD scenarios with full path coverage Closes #1243 Co-authored-by: Hamza Khyari <hamza.khyari@cleverthis.com> Co-committed-by: Hamza Khyari <hamza.khyari@cleverthis.com>	2026-04-02 16:52:33 +00:00
brent.edwards	a0c6ecd3ad	fix(di): get_container() permanently caches failed audit subscriber in Singleton provider ... Introduced a module-level flag _audit_subscriber_initialized to track whether audit_event_subscriber() has been successfully called. When get_container() is invoked and the flag is False, the subscriber initialization is reattempted regardless of whether _container already exists. On success the flag is set to True so no further attempts are made; on failure the warning is logged and the flag remains False so the next get_container() call retries. Previously, a failed audit subscriber init during the first get_container() call was permanently cached: _container was set but the subscriber was never retried. In CLI mode this is masked because each invocation is a new process, but in long-lived server processes the audit subscriber would remain unregistered for the process lifetime. Also brings in the TDD regression test from issue #1096 (branch tdd/m6-di-audit-cache-failure) with the @tdd_expected_fail tag removed, converting it to a normal passing regression guard. Added an ASV benchmark measuring retry-path performance. ISSUES CLOSED: #992 Reviewed-by: reviewer-pool-1 Closes #992 Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-04-02 16:51:29 +00:00
brent.edwards	f324575a3b	fix(test): remove lingering @tdd_expected_fail tags for closed bugs #821 and #932 (#1229) ... The @tdd_expected_fail tag was already absent from the tag lines of both features/tdd_context_tier_runtime.feature (bug #821) and features/tdd_plan_apply_yes_flag.feature (bug #932). However, the feature description and step-definition docstring for bug #821 still referenced the @tdd_expected_fail tag and described the bug as unfixed. Updated the feature description in tdd_context_tier_runtime.feature and the module docstring in tdd_context_tier_runtime_steps.py to reflect that bug #821 has been fixed and these tests now serve as permanent regression guards. No changes were needed for bug #932 as its files had no stale references. Permanent tags @tdd_issue / @tdd_issue_821 and @tdd_issue / @tdd_issue_932 remain in place per the CONTRIBUTING.md TDD Issue Test Tags convention. ISSUES CLOSED: #1206 Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-04-02 16:51:15 +00:00
brent.edwards	7e9a45044b	fix(session): session create does not persist session for subsequent list ... The CLI `session create` command created the session via SessionService.create() (which commits via auto_commit=True), then called _facade_dispatch("session.create") for A2A protocol bookkeeping. The facade handler unconditionally called svc.create() on a second PersistentSessionService instance (a new Factory resolution from the DI container with its own engine), creating a duplicate session in the database. The fix makes A2aLocalFacade._handle_session_create() idempotent: when a session_id is already present in the params, it acknowledges the existing session without creating a new one. The CLI dispatch params were also fixed to use the correct key name (actor_name instead of actor). Changes: - src/cleveragents/a2a/facade.py: Early return in _handle_session_create when session_id is already supplied, preventing duplicate session creation. - src/cleveragents/cli/commands/session.py: Fixed param key from "actor" to "actor_name" for consistency with the facade handler. - features/a2a_facade_wiring.feature: Added idempotency scenario verifying that session.create with an existing session_id does not call svc.create(). - features/steps/a2a_facade_wiring_steps.py: Added step asserting mock SessionService.create was not called. - features/tdd_session_create_persist.feature: Removed @tdd_expected_fail tag now that the bug is fixed. - robot/e2e/e2e_session_create_persist.robot: Removed tdd_expected_fail tag, updated documentation. - .semgrep.yml: Excluded wrapping.py from no-exec/no-compile-exec rules (pre-existing sandboxed exec usage for tool transforms). ISSUES CLOSED: #1141 Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-04-02 16:51:04 +00:00
brent.edwards	d59fa47fd0	feat(cli): implement plan prompt command ... Add the missing plan prompt CLI command and wire it through the local A2A facade into PlanLifecycleService so operator guidance can be injected into active execute-phase plans per the specification. The lifecycle flow now validates active state, records user-intervention decisions, and returns structured queue/decision metadata for rich and machine-readable output envelopes across all supported formats. Also stabilize flaky quality gates discovered while implementing #885 by hardening integration helper timeouts, relaxing an overly strict CLI-core timing assertion, defaulting test worker concurrency to serial for determinism, switching ASV to spawn launch mode for runner stability, and documenting the controlled transform sandbox exec/compile path for static security hooks. ISSUES CLOSED: #885 Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-04-02 16:50:55 +00:00
brent.edwards	f002bad4ec	test: add TDD bug-capture test for #1152 — budget eviction deletes instead of demotes ... Add Behave BDD scenarios and Robot Framework integration tests that capture bug #1152: _enforce_hot_budget() permanently deletes hot-tier fragments via del self._hot[oldest_id] instead of demoting them to the warm tier. Similarly, evict_lru() permanently deletes via del store[fid]. The specification (§Plan Lifecycle ACMS Actions) describes a downward lifecycle ("Hot context archived to warm") that requires demotion, not destruction. Two Behave scenarios tagged @tdd_expected_fail @tdd_issue @tdd_issue_1152: - Budget-evicted fragment should be demoted to warm, not deleted - evict_lru-evicted fragment should be demoted to warm, not deleted Two Robot Framework tests mirror the Behave scenarios with a Python helper script for subprocess isolation. ISSUES CLOSED: #1183 Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-04-02 16:50:50 +00:00
freemo	9a3c4265a0	fix(cli): add missing resource command flags per specification (#1192) ... Adds missing CLI flags to `resource add`, `resource list`, `resource tree`, `resource type list`, and `lsp list` per specification. Changes: - Added --update, --clone-into to resource_add; expanded --mount for devcontainer-instance - Added --all to resource_list; changed --depth default to 3 - Added [REGEX] positional to type_list and lsp list - Added include_auto_discovered parameter to resource registry ops - 12 new BDD scenarios with step definitions - Fixed critical bug: clone-into URL parsing used split() instead of rsplit(), causing HTTPS URLs to be stored with incorrect data Closes #904 Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me> Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>	2026-04-02 08:31:27 +00:00
freemo	4e3b4180fc	feat(ci): add Helm chart lint and template validation to CI ... Add kubeconform manifest validation to the existing helm CI job. The helm job already had helm lint and helm template steps (added in #1085). This commit completes the optional acceptance criterion from #1089 by adding kubeconform v0.7.0 to validate rendered manifests against the Kubernetes 1.29.0 schema in strict mode. Changes: - Install kubeconform v0.7.0 in the helm CI job - Add 'Validate rendered manifests with kubeconform' step after helm template smoke render (strict mode, ignore-missing-schemas, kubernetes-version 1.29.0) - Add 5 BDD scenarios to ci_workflow_validation.feature covering: - helm job existence - helm lint step - helm template step - kubeconform validation step - status-check dependency on helm job ISSUES CLOSED: #1089	2026-04-02 07:47:09 +00:00
brent.edwards	601f408860	bug(cli): automation_profile._get_service() bypasses DI container ... Route automation profile CLI service resolution through the DI container by using container.automation_profile_service() and wiring a dedicated automation_profile_service provider in the application container. This removes ad-hoc repository/session construction from the CLI path so dependency lifecycle and configuration stay centralized and consistent with specification DI rules. Add integration-style, non-mocked Behave proof that _get_service() resolves through real container/provider wiring, while keeping focused delegation assertions in the existing coverage feature. Remove the unrelated robot/resource_dag.robot changes from this PR and clean up duplicate _get_service test overlap by dropping the extra TDD-only feature file pair. ISSUES CLOSED: #990	2026-04-02 06:21:49 +00:00
CoreRasurae	b21e0fedea	test(bdd): add direct test for _fast_init_or_upgrade early-return behavior ... Add 8 BDD scenarios in features/fast_init_upgrade.feature that directly exercise the _fast_init_or_upgrade closure installed by _install_template_db_patch in features/environment.py. Scenarios cover all code paths: - Non-empty DB with matching prefix → early return (original NOT invoked) - Non-existent DB with matching prefix → template copied (original NOT invoked) - Existing empty DB with matching prefix → template copied (original NOT invoked) - Non-matching prefix → delegates to original init_or_upgrade - In-memory SQLite → delegates to original init_or_upgrade - Non-SQLite URL → delegates to original init_or_upgrade - Bare sqlite:// URL → delegates to original init_or_upgrade - Delegation forwards runner instance and keyword arguments correctly Test infrastructure: - features/mocks/fast_init_test_helpers.py provides a context manager (patch_original_init_or_upgrade) that replaces the _original_init_or_upgrade reference inside the closure via cell_contents manipulation, enabling precise call-tracking without recreating the function under test. - All scenarios tagged @mock_only to skip unnecessary DB setup. - Cleanup registered via context._cleanup_handlers for temp file removal. - Works in both sequential and parallel execution modes. Review fix round: - Added bare sqlite:// URL scenario covering the second branch of the in-memory disjunction (L1). - Added scenario verifying runner instance and keyword argument forwarding through the delegation path (L2, L3). - Replaced hardcoded test credentials with clearly synthetic pattern (I4). - Fixed CHANGELOG wording that incorrectly claimed mktemp replacement (L5). ISSUES CLOSED: #733	2026-04-01 23:52:20 +01:00
brent.edwards	0ae733d01f	feat(tui): implement help panel (F1) with context-sensitive help ... Add a dedicated TUI help overlay toggled by F1 and resolve its content from the current prompt mode for main-screen, slash-command, reference, and shell contexts. Extend Behave and Robot coverage for the new help-panel widget, app wiring, context switching, and toggle behavior. ISSUES CLOSED: #1013	2026-04-01 21:51:14 +00:00
hamza.khyari	18b9d61e35	feat(resource): implement ResourceHandler content_hash method ... Add content_hash(resource, *, algorithm='sha256') -> str to the ResourceHandler protocol and all handler implementations: - Protocol: new content_hash method on ResourceHandler (protocol.py) - BaseResourceHandler: default impl hashes file content or directory entry names; returns EMPTY_CONTENT_HASH sentinel for missing resources - GitCheckoutHandler: hashes git rev-parse HEAD through the requested algorithm for consistent digest format - FsDirectoryHandler: recursive walk hashing sorted relative paths and file contents (content-only, ignores metadata) - DevcontainerHandler: hashes devcontainer.json config file - DatabaseResourceHandler: hashes connection string; for SQLite file-based DBs, hashes the database file content - _DefaultHandler: delegates to BaseResourceHandler EMPTY_CONTENT_HASH sentinel is the SHA-256 of empty input (e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855). Hash algorithm is configurable via the algorithm parameter (default sha256, accepts any hashlib.new()-compatible name). Behave tests (10 scenarios): sentinel for missing/nonexistent, determinism, different content produces different hash, fs-directory recursive hash with change detection, git-checkout hash, configurable algorithm (sha256 vs sha512), protocol compliance for all 4 handlers. ISSUES CLOSED: #837	2026-04-01 13:02:24 +00:00
brent.edwards	dc1359fc07	feat(tui): enumerate full slash command set (60+ commands, 14 groups) ... Add a specification-aligned slash command catalog and wire it into TUI overlay initialization so command discovery reflects the complete command surface. Cover command and group cardinality plus representative command presence in Behave tests. ISSUES CLOSED: #1002	2026-04-01 09:23:21 +00:00
aditya	137d040c4d	feat(acms): implement DepthReductionCompressor for skeleton compression ... Add a production skeleton compressor that re-renders inherited fragments to overview depths via the UKO detail-level map chain, fits the result within the configured skeleton budget, and wires the pipeline default to the new compressor. Address prior review feedback by extracting the render visitors into a dedicated module, restoring projected metadata to native runtime types, constraining builtin component resolution with an allowlist, and keeping child-context inheritance compatible with CRP context fragments for the Robot integration path. Reproduced the Forgejo lint job in a clean python:3.13-slim container with the CI commands All checks passed! and 1740 files already formatted; both passed, so the earlier lint failure appears to have been transient runner behavior rather than a source-level defect. ISSUES CLOSED: #919	2026-04-01 06:16:41 +00:00
brent.edwards	34dcf5226f	feat(autonomy): automation profile resolution precedence correct (#1196) ... ## Summary - Fix automation profile resolution precedence at plan-creation time to follow plan > action > project > global. - Narrow exception handling in `_resolve_plan_profile_ref` to catch only `(KeyError, ValueError, OSError)` with warning-level structured logging, replacing bare `except Exception:` per CONTRIBUTING.md §Exception Propagation. - Fix TDD feature file tag/title inconsistency: align to `@tdd_bug @tdd_bug_1076` / "TDD Bug #1076" referencing the original bug ticket. - Add BDD scenarios for plan-level profile override and config service error fallback. - Harden lifecycle and Robot/Behave test paths for auto-progression and parallel CI stability (including pre-seeded DB initialization for `tdd_plan_explain_plan_id` helper). - Update Robot helper timing/session patterns to reduce false negatives in long-running integration/E2E validations. ## Approach The automation profile resolution is implemented in `PlanLifecycleService._resolve_plan_profile_ref`, which evaluates the four-level precedence chain (plan > action > project > global) at `use_action()` time. The resolved profile is stored as an `AutomationProfileRef` on the Plan with provenance tracking. The `ConfigService` is used for project-scoped and global config lookups, with narrowed exception handling that logs warnings on failure and falls back to the settings default. ## Validation - `nox -s lint` ✅ - `nox -s typecheck` ✅ - `nox -s unit_tests` ✅ - `nox -s coverage_report` ✅ (97%) ## Review Fix Round (Review #2963) 1. **Bare `except Exception:` → narrowed to `(KeyError, ValueError, OSError)` with warning logging** — addresses CONTRIBUTING.md §Exception Propagation violation 2. **Tag inconsistency fixed** — `@tdd_bug @tdd_bug_1076` with title "TDD Bug #1076" 3. **Added 2 new BDD scenarios** — plan-level override and config error fallback 4. **Rebased onto latest master** (532ea100) Closes #854 Reviewed-on: #1196 Co-authored-by: Brent Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent Edwards <brent.edwards@cleverthis.com>	2026-04-01 04:27:09 +00:00
brent.edwards	81c141716b	test(integration): workflow example 2 — automated test generation for a module (trusted profile) (#1176) ... ## Summary - Refactors WF02 integration helper into focused modules to satisfy maintainability guidelines and keep command responsibilities isolated. - Moves WF02 artifact assertions onto lifecycle-produced change artifacts and verifies user-facing `plan artifacts` flow with mocked providers. - Reworks WF02 coverage-gate assertions to run through validation registration/attachment/execution lifecycle and apply-gate outcomes. ## What changed in this fix round (cycle-6) - **CI must-fix — trusted profile lifecycle integration failure:** - Fixed failing integration test `WF02 Trusted Profile Auto Runs Strategize And Execute` caused by legacy AutomationProfile fields that no longer exist. - Updated WF02 trusted-profile assertions from removed legacy fields (`auto_strategize`, `auto_execute`, `auto_apply`) to current spec-aligned fields (`decompose_task`, `create_tool`, `select_tool`). - Key module: `robot/wf02_test_generation_commands.py` (`wf02_trusted_lifecycle`). ## Prior fix rounds retained - **P1 must-fix — validation payload assertions strengthened:** - Added explicit assertions for validation payload correctness in both failing and passing branches. - Assertions now verify: - validation identity (`local/auth-coverage` on `local/api-service-repo`) - required-mode semantics (`mode=required`, required pass/fail counters, `all_required_passed`) - `passed` boolean for each branch - measured-vs-target semantics (`measured_coverage` compared against `target`). - Key module: `robot/wf02_test_generation_validation.py`. - **P2 should-fix — artifact membership assertions tightened:** - Artifact assertions now enforce exact expected membership and count instead of permissive subset checks. - Persisted changeset assertions were aligned to the same strict set/count checks. - Key module: `robot/wf02_test_generation_artifacts.py`. - **P2 should-fix — removed unused helper:** - Deleted unused `_bind_changeset_to_plan` helper to eliminate dead code. - Key module: `robot/wf02_test_generation_artifacts.py`. - **P2 should-fix — concrete typing:** - Replaced `_setup_validation_db` return type from `tuple[Any, Any]` to concrete typed return (`Callable[[], _NoCloseSession]`, `Session`). - Key module: `robot/wf02_test_generation_validation.py`. ## Quality gates - `nox -e lint` ✅ - `nox -e typecheck` ✅ - `nox -e unit_tests` ✅ - `nox -e integration_tests` ✅ - `nox -e e2e_tests` ✅ - `nox -e coverage_report` ✅ (coverage: **98.74%**) ## Scope / limitations - No deferred items identified in cycle-6. Closes #766 Reviewed-on: #1176 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com> Co-authored-by: Brent Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent Edwards <brent.edwards@cleverthis.com>	2026-04-01 03:30:00 +00:00
brent.edwards	a8d91b94a7	feat(autonomy): guard enforcement works (denylist, budget caps, tool call limits) (#1204) ... ## Summary - Enforced autonomy guard behavior for denylist/allowlist checks, budget caps, tool-call limits, and write/apply approval gates. - Added scope-aware guard evaluation (plan vs subplan) using `GuardScope(StrEnum)` for type-safe scope handling. - Extracted remediation guidance strings as module-level constants (`REMEDIATION_DENYLIST`, `REMEDIATION_ALLOWLIST`, etc.) for consistency and testability. - Added Behave coverage to validate guard remediation messaging and subplan-scoped tool-call limit behavior. ## Review Fix Round (v2) Addressed review #2910 by @freemo: 1. **Reverted `resource_dag.robot`** — Unrelated Robot SQLite/cycle-detection changes removed from this commit; will be submitted as a separate PR. 2. **`scope` parameter → `GuardScope` enum** — Created `GuardScope(StrEnum)` in `automation_guard.py` with `PLAN` and `SUBPLAN` members. Updated `check_guard()` signature and all call sites. 3. **Removed redundant `scope_label`** — Now uses `scope.value` directly. 4. **Extracted remediation constants** — Guidance strings moved to module-level constants in `automation_guard.py`. ## Validation - `nox -s lint` — passed - `nox -s typecheck` — passed (0 errors, 0 warnings) - `nox -s unit_tests` — passed (508 features, 12989 scenarios, 0 failures) - `nox -s coverage_report` — passed (97% coverage) - Rebased onto latest `master` (532ea100) Closes #853 Reviewed-on: #1204 Co-authored-by: Brent Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent Edwards <brent.edwards@cleverthis.com>	2026-04-01 01:46:37 +00:00
brent.edwards	91cc0b1446	test: add TDD bug-capture test for #1025 — plan correct auto-resolve (#1172) ... ## Summary - add Behave `@tdd_expected_fail` bug-capture scenarios for `plan correct` auto-resolve without `--plan` - add shared mock fixtures and Robot integration coverage for isolated-container divergence reproducing bug #1025 - add ASV benchmark coverage for active-plan filtering and document the new TDD capture in changelog ## Testing - nox -s unit_tests -- features/tdd_plan_correct_auto_resolve.feature - nox -s integration_tests -- --include tdd_bug_1025 - nox -s lint - nox -s typecheck - nox -s coverage_report - nox Closes #1035 Reviewed-on: #1172 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com> Co-authored-by: Brent Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent Edwards <brent.edwards@cleverthis.com>	2026-04-01 00:40:46 +00:00
brent.edwards	01b6eb1804	feat(autonomy): parallel execution scales to 10+ concurrent subplans (#1201) ... ## Summary Add M6 parallel-scaling coverage for 10+ concurrent subplans: - **15-subplan parallel scenario** with explicit peak-concurrency bound checks (`max_parallel=10`) and thread-safe concurrency tracking via `_build_executor()`. - **Deep hierarchical decomposition** coverage (4+ levels) with adjusted leaf condition that only stops early when hitting `max_depth` or when the workset is trivially small (`min_files_per_subplan`). - **Non-progress guard** in `_build_hierarchy` to prevent pathological recursion when clustering cannot meaningfully split the file set. - **Small-project regression test** (< 50 files) verifying decomposition depth does not increase unexpectedly with the relaxed leaf condition. - **ASV benchmark** for 15-subplan parallel execution with `max_parallel=10` to track scaling behavior. ### Removed from this PR The `_build_hierarchy` child-linkage correctness fix (returning `node_id` from recursive calls instead of using `nodes[-1].node_id`) has been **removed** per review feedback — it is a separate bug fix and will be submitted as an independent issue/PR per CONTRIBUTING.md §Atomic Commits. ## Approach - **Concurrency tracking:** The `_build_executor()` closure in step definitions detects `context.concurrency_counter` / `context.concurrency_lock` and performs thread-safe peak tracking in a try/finally block. - **Leaf condition:** Replaced the `max_files_per_subplan` / `max_tokens_per_subplan` leaf check with a `min_files_per_subplan` check to allow deeper decomposition for large projects. Added a non-progress guard so clustering that cannot split the file set terminates immediately rather than recursing to `max_depth`. - **Deterministic IDs:** `_ids_for_count()` preserves legacy fixed IDs for the first 5 subplans and generates additional deterministic IDs for scale scenarios. ## Validation ### Passing - `nox -s lint` — all checks passed - `nox -s typecheck` — 0 errors, 0 warnings - `nox -s unit_tests` — 12,988 scenarios passed, 0 failed - `nox -s coverage_report` — 97% (passes `--fail-under=97`) Closes #855 Reviewed-on: #1201 Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-03-31 23:57:39 +00:00