cleveragents/cleveragents-core

Fork 3

feat(events): enrich PLAN_CANCELLED event with progress and resource cleanup context #717

New issue

Closed

opened 2026-03-12 01:55:41 +00:00 by CoreRasurae · 2 comments

CoreRasurae commented

2026-03-12 01:55:41 +00:00

Member

Metadata

Field	Value
Commit Message	`feat(events): enrich PLAN_CANCELLED event with progress and resource cleanup context`
Branch	`feature/enrich-plan-cancelled-event`

Summary

The PLAN_CANCELLED event emitted by PlanLifecycleService.cancel_plan() only includes reason and project_names. Richer context (plan progress at cancellation, resources released) would improve the audit trail.

Spec Reference

Section: Security > SEC7 Audit Logging
Related: Issue #581 (AuditService wiring), Finding M5 from #678

Current State

PLAN_CANCELLED event emitted at PlanLifecycleService.cancel_plan() (around line 1252)
Only includes reason and project_names
Resource cleanup and sandbox teardown happen in separate services after cancellation

Description

Downstream services (sandbox manager, resource cleanup) could emit their own events, or a cancellation orchestrator could aggregate results into a richer audit entry. The lifecycle service does not orchestrate or observe downstream effects at the point of cancellation.

Acceptance Criteria

PLAN_CANCELLED event (or supplementary events) include progress context
Details include: plan progress at cancellation, resources released/pending
Audit log entries for cancellation contain actionable context
Unit and integration tests verify enriched event payload

Parent: #678 (Specification issues from #581)
Related: #581 (AuditService wiring)

Subtasks

Code: Enrich plan cancelled event with progress and resource context
Behave tests: Add BDD scenarios for enriched cancellation payload
Robot tests: Integration test for enriched audit entry
Quality: coverage >=97%: Verify via nox -s coverage_report
Quality: nox full suite: Run nox (all default sessions), fix any errors

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

## Metadata | Field | Value | |-------|-------| | **Commit Message** | `feat(events): enrich PLAN_CANCELLED event with progress and resource cleanup context` | | **Branch** | `feature/enrich-plan-cancelled-event` | ## Summary The `PLAN_CANCELLED` event emitted by `PlanLifecycleService.cancel_plan()` only includes `reason` and `project_names`. Richer context (plan progress at cancellation, resources released) would improve the audit trail. ## Spec Reference **Section**: Security > SEC7 Audit Logging **Related**: Issue #581 (AuditService wiring), Finding M5 from #678 ## Current State - `PLAN_CANCELLED` event emitted at `PlanLifecycleService.cancel_plan()` (around line 1252) - Only includes `reason` and `project_names` - Resource cleanup and sandbox teardown happen in separate services after cancellation ## Description Downstream services (sandbox manager, resource cleanup) could emit their own events, or a cancellation orchestrator could aggregate results into a richer audit entry. The lifecycle service does not orchestrate or observe downstream effects at the point of cancellation. ## Acceptance Criteria - [ ] `PLAN_CANCELLED` event (or supplementary events) include progress context - [ ] Details include: plan progress at cancellation, resources released/pending - [ ] Audit log entries for cancellation contain actionable context - [ ] Unit and integration tests verify enriched event payload ## Related Issues - Parent: #678 (Specification issues from #581) - Related: #581 (AuditService wiring) ## Subtasks - [ ] **Code**: Enrich plan cancelled event with progress and resource context - [ ] **Behave tests**: Add BDD scenarios for enriched cancellation payload - [ ] **Robot tests**: Integration test for enriched audit entry - [ ] **Quality: coverage >=97%**: Verify via `nox -s coverage_report` - [ ] **Quality: nox full suite**: Run `nox` (all default sessions), fix any errors ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

CoreRasurae referenced this issue

2026-03-12 01:56:19 +00:00

Specification issues during the development of issue #581 #678

freemo added the

labels

2026-03-12 20:21:57 +00:00

CoreRasurae was assigned by freemo

2026-03-12 20:21:58 +00:00

freemo added this to the v3.5.0 milestone

2026-03-12 20:21:58 +00:00

CoreRasurae was unassigned by freemo

2026-04-02 06:13:57 +00:00

freemo self-assigned this

2026-04-02 06:13:57 +00:00

freemo referenced this issue from a commit

2026-04-02 09:27:06 +00:00

feat(events): enrich PLAN_CANCELLED event with progress and resource cleanup context

freemo referenced this issue from a pull request that will close it,

2026-04-02 09:27:14 +00:00

feat(events): enrich PLAN_CANCELLED event with progress and resource cleanup context #1301

freemo commented

2026-04-02 09:27:23 +00:00

Owner

PR #1301 created on branch feature/m6-plan-cancelled-enrichment. PR review and merge handled by continuous review stream.

Implementation summary:

The PLAN_CANCELLED domain event emitted by PlanLifecycleService.cancel_plan() has been enriched with:

Progress context (captured before state mutation):

cancelled_phase — plan phase at cancellation
cancelled_processing_state — processing state at cancellation
last_completed_step — last successfully completed step index
subplan_count — number of spawned subplans

Resource cleanup context:

sandbox_refs — active sandbox reference IDs requiring cleanup
changeset_id — in-progress changeset ID (if any)
resources_pending_cleanup — count of sandbox refs pending cleanup

15 BDD scenarios added covering all new fields, value accuracy, and backward compatibility. All quality gates pass (lint, typecheck, unit_tests).

PR #1301 created on branch `feature/m6-plan-cancelled-enrichment`. PR review and merge handled by continuous review stream. **Implementation summary:** The `PLAN_CANCELLED` domain event emitted by `PlanLifecycleService.cancel_plan()` has been enriched with: **Progress context** (captured before state mutation): - `cancelled_phase` — plan phase at cancellation - `cancelled_processing_state` — processing state at cancellation - `last_completed_step` — last successfully completed step index - `subplan_count` — number of spawned subplans **Resource cleanup context**: - `sandbox_refs` — active sandbox reference IDs requiring cleanup - `changeset_id` — in-progress changeset ID (if any) - `resources_pending_cleanup` — count of sandbox refs pending cleanup 15 BDD scenarios added covering all new fields, value accuracy, and backward compatibility. All quality gates pass (lint, typecheck, unit_tests).

brent.edwards added

and removed

labels

2026-04-02 11:30:21 +00:00

freemo referenced this issue from a commit

2026-04-02 17:07:42 +00:00

feat(events): enrich PLAN_CANCELLED event with progress and resource cleanup context (#1301)

freemo closed this issue

2026-04-02 17:07:42 +00:00

freemo commented

2026-04-02 17:07:50 +00:00

Owner

PR #1301 reviewed, approved, and merged.

The PLAN_CANCELLED domain event is now enriched with progress context (cancelled_phase, cancelled_processing_state, last_completed_step, subplan_count) and resource cleanup context (sandbox_refs, changeset_id, resources_pending_cleanup). 15 BDD scenarios verify the enriched payload.

PR #1301 reviewed, approved, and merged. The `PLAN_CANCELLED` domain event is now enriched with progress context (`cancelled_phase`, `cancelled_processing_state`, `last_completed_step`, `subplan_count`) and resource cleanup context (`sandbox_refs`, `changeset_id`, `resources_pending_cleanup`). 15 BDD scenarios verify the enriched payload.

freemo added

and removed

labels

2026-04-02 17:08:54 +00:00