test(integration): workflow example 2 — automated test generation for a module (trusted profile) #1176

Merged

brent.edwards merged 2 commits from test/int-wf02-test-generation into master 2026-04-01 03:30:01 +00:00

Conversation 4 Commits 2 Files changed 10 +1553

brent.edwards commented 2026-03-28 13:27:57 +00:00

Member

Copy link

Summary

• Refactors WF02 integration helper into focused modules to satisfy maintainability guidelines and keep command responsibilities isolated.
• Moves WF02 artifact assertions onto lifecycle-produced change artifacts and verifies user-facing plan artifacts flow with mocked providers.
• Reworks WF02 coverage-gate assertions to run through validation registration/attachment/execution lifecycle and apply-gate outcomes.

What changed in this fix round (cycle-6)

• CI must-fix — trusted profile lifecycle integration failure:
  • Fixed failing integration test WF02 Trusted Profile Auto Runs Strategize And Execute caused by legacy AutomationProfile fields that no longer exist.
  • Updated WF02 trusted-profile assertions from removed legacy fields (auto_strategize, auto_execute, auto_apply) to current spec-aligned fields (decompose_task, create_tool, select_tool).
  • Key module: robot/wf02_test_generation_commands.py (wf02_trusted_lifecycle).

Prior fix rounds retained

• P1 must-fix — validation payload assertions strengthened:

  • Added explicit assertions for validation payload correctness in both failing and passing branches.
  • Assertions now verify:
    • validation identity (local/auth-coverage on local/api-service-repo)
    • required-mode semantics (mode=required, required pass/fail counters, all_required_passed)
    • passed boolean for each branch
    • measured-vs-target semantics (measured_coverage compared against target).
  • Key module: robot/wf02_test_generation_validation.py.

• P2 should-fix — artifact membership assertions tightened:

  • Artifact assertions now enforce exact expected membership and count instead of permissive subset checks.
  • Persisted changeset assertions were aligned to the same strict set/count checks.
  • Key module: robot/wf02_test_generation_artifacts.py.

• P2 should-fix — removed unused helper:

  • Deleted unused _bind_changeset_to_plan helper to eliminate dead code.
  • Key module: robot/wf02_test_generation_artifacts.py.

• P2 should-fix — concrete typing:

  • Replaced _setup_validation_db return type from tuple[Any, Any] to concrete typed return (Callable[[], _NoCloseSession], Session).
  • Key module: robot/wf02_test_generation_validation.py.

Quality gates

• nox -e lint ✅
• nox -e typecheck ✅
• nox -e unit_tests ✅
• nox -e integration_tests ✅
• nox -e e2e_tests ✅
• nox -e coverage_report ✅ (coverage: 98.74%)

Scope / limitations

• No deferred items identified in cycle-6.

Closes #766

## Summary - Refactors WF02 integration helper into focused modules to satisfy maintainability guidelines and keep command responsibilities isolated. - Moves WF02 artifact assertions onto lifecycle-produced change artifacts and verifies user-facing `plan artifacts` flow with mocked providers. - Reworks WF02 coverage-gate assertions to run through validation registration/attachment/execution lifecycle and apply-gate outcomes. ## What changed in this fix round (cycle-6) - **CI must-fix — trusted profile lifecycle integration failure:** - Fixed failing integration test `WF02 Trusted Profile Auto Runs Strategize And Execute` caused by legacy AutomationProfile fields that no longer exist. - Updated WF02 trusted-profile assertions from removed legacy fields (`auto_strategize`, `auto_execute`, `auto_apply`) to current spec-aligned fields (`decompose_task`, `create_tool`, `select_tool`). - Key module: `robot/wf02_test_generation_commands.py` (`wf02_trusted_lifecycle`). ## Prior fix rounds retained - **P1 must-fix — validation payload assertions strengthened:** - Added explicit assertions for validation payload correctness in both failing and passing branches. - Assertions now verify: - validation identity (`local/auth-coverage` on `local/api-service-repo`) - required-mode semantics (`mode=required`, required pass/fail counters, `all_required_passed`) - `passed` boolean for each branch - measured-vs-target semantics (`measured_coverage` compared against `target`). - Key module: `robot/wf02_test_generation_validation.py`. - **P2 should-fix — artifact membership assertions tightened:** - Artifact assertions now enforce exact expected membership and count instead of permissive subset checks. - Persisted changeset assertions were aligned to the same strict set/count checks. - Key module: `robot/wf02_test_generation_artifacts.py`. - **P2 should-fix — removed unused helper:** - Deleted unused `_bind_changeset_to_plan` helper to eliminate dead code. - Key module: `robot/wf02_test_generation_artifacts.py`. - **P2 should-fix — concrete typing:** - Replaced `_setup_validation_db` return type from `tuple[Any, Any]` to concrete typed return (`Callable[[], _NoCloseSession]`, `Session`). - Key module: `robot/wf02_test_generation_validation.py`. ## Quality gates - `nox -e lint` ✅ - `nox -e typecheck` ✅ - `nox -e unit_tests` ✅ - `nox -e integration_tests` ✅ - `nox -e e2e_tests` ✅ - `nox -e coverage_report` ✅ (coverage: **98.74%**) ## Scope / limitations - No deferred items identified in cycle-6. Closes #766

brent.edwards added this to the v3.2.0 milestone 2026-03-28 13:28:11 +00:00

brent.edwards added the

Type

Testing

label 2026-03-28 13:28:16 +00:00

brent.edwards added a new dependency 2026-03-28 13:28:24 +00:00

#766 test(integration): workflow example 2 — automated test generation for a module (trusted profile)

freemo requested reviews from CoreRasurae, hamza.khyari 2026-03-28 21:28:09 +00:00

freemo commented 2026-03-28 23:26:52 +00:00

Owner

Copy link

Day 48 Planning — M3 Merge Priority

This is the closest-to-merge PR targeting v3.2.0. Status:

• Mergeable: YES
• Labels: Correct (Type/Testing)
• Closes #766
• 0 unresolved comments

Blocking: Needs 2 approving reviews. @CoreRasurae and @hamza.khyari — please prioritize reviewing this PR for M3 closure.

Minor: Branch has a merge commit — consider squash-merge to maintain clean history.

**Day 48 Planning — M3 Merge Priority** This is the closest-to-merge PR targeting v3.2.0. Status: - Mergeable: YES - Labels: Correct (Type/Testing) - Closes #766 - 0 unresolved comments **Blocking**: Needs 2 approving reviews. @CoreRasurae and @hamza.khyari — please prioritize reviewing this PR for M3 closure. **Minor**: Branch has a merge commit — consider squash-merge to maintain clean history.

brent.edwards force-pushed test/int-wf02-test-generation from 5ae19cf36f to 855dcde932 2026-03-29 04:26:36 +00:00 Compare

brent.edwards force-pushed test/int-wf02-test-generation from 855dcde932 to 2f749589e1 2026-03-29 06:42:41 +00:00 Compare

brent.edwards force-pushed test/int-wf02-test-generation from 2f749589e1 to 55ff4269d8 2026-03-29 08:54:32 +00:00 Compare

brent.edwards force-pushed test/int-wf02-test-generation from 55ff4269d8 to 1cedef5577 2026-03-29 12:28:57 +00:00 Compare

brent.edwards force-pushed test/int-wf02-test-generation from 1cedef5577 to 8376c2d4f2 2026-03-29 14:20:10 +00:00 Compare

brent.edwards force-pushed test/int-wf02-test-generation from 8376c2d4f2 to f2d0d4a621 2026-03-29 15:00:16 +00:00 Compare

freemo approved these changes 2026-03-30 04:21:21 +00:00

Dismissed

freemo left a comment

Copy link

Review: APPROVED with Comments

Comprehensive Robot integration test suite for WF02 automated test generation.

Notes

1. Missing BDD unit-level accompaniment: CONTRIBUTING.md requires BDD for unit-level tests. This PR only adds Robot integration tests. Consider adding Behave scenarios for the unit-level behavior.
2. _NoCloseSession wrapper uses object.__setattr__ / object.__getattribute__ magic — clever but opaque. A comment explaining why it exists would help.
3. Private method access: lifecycle._commit_plan(plan) bypasses the public API.
4. Good: Well-organized helper modules (lifecycle, artifacts, validation, commands, common).
5. Good: Changelog updated with #766 reference.

## Review: APPROVED with Comments Comprehensive Robot integration test suite for WF02 automated test generation. ### Notes 1. **Missing BDD unit-level accompaniment**: CONTRIBUTING.md requires BDD for unit-level tests. This PR only adds Robot integration tests. Consider adding Behave scenarios for the unit-level behavior. 2. **`_NoCloseSession` wrapper** uses `object.__setattr__` / `object.__getattribute__` magic — clever but opaque. A comment explaining why it exists would help. 3. **Private method access**: `lifecycle._commit_plan(plan)` bypasses the public API. 4. **Good**: Well-organized helper modules (`lifecycle`, `artifacts`, `validation`, `commands`, `common`). 5. **Good**: Changelog updated with #766 reference.

freemo commented 2026-03-30 05:15:10 +00:00

Owner

Copy link

Day 50 Planning — Merge priority assessment.

This is the closest-to-merge PR for v3.2.0 as @freemo noted on Day 48. It addresses issue #766 (workflow example 2 — automated test generation) and is labeled correctly.

Action needed: Reviewers @CoreRasurae and @hamza.khyari have been assigned. Please prioritize this review — it is one of 7 items blocking v3.2.0 closure (which is already 33+ days overdue).

Consider squash-merge for clean history as @freemo suggested.

Day 50 Planning — **Merge priority assessment.** This is the closest-to-merge PR for v3.2.0 as @freemo noted on Day 48. It addresses issue #766 (workflow example 2 — automated test generation) and is labeled correctly. **Action needed:** Reviewers @CoreRasurae and @hamza.khyari have been assigned. Please prioritize this review — it is one of 7 items blocking v3.2.0 closure (which is already 33+ days overdue). Consider squash-merge for clean history as @freemo suggested.

brent.edwards force-pushed test/int-wf02-test-generation from f2d0d4a621 to 063c271a4c 2026-03-31 22:42:16 +00:00 Compare

brent.edwards dismissed freemo's review 2026-03-31 22:42:16 +00:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

brent.edwards referenced this pull request 2026-04-01 01:14:54 +00:00

test(integration): workflow example 2 — automated test generation for a module (trusted profile) #766

brent.edwards force-pushed test/int-wf02-test-generation from 063c271a4c to 6b9bfaccf3 2026-04-01 01:15:15 +00:00 Compare

brent.edwards commented 2026-04-01 01:15:42 +00:00

Author

Member

Copy link

Addressed follow-up from review feedback and CI:

1. BDD unit-level accompaniment added

   • Added Behave feature + steps for WF02 behavior.
   • Files: features/wf02_test_generation.feature, features/steps/wf02_test_generation_steps.py.

2. _NoCloseSession clarity improved

   • Added explicit explanatory docstring/comment describing the proxy purpose and why it prevents fixture-managed session close side effects.
   • File: robot/wf02_test_generation_validation.py.

3. Removed private lifecycle API usage

   • Replaced private lifecycle._commit_plan(...) use with public lifecycle API (save_plan(...)) in WF02 helpers.
   • Files: robot/wf02_test_generation_validation.py, robot/wf02_test_generation_common.py, robot/wf02_test_generation_artifacts.py.

4. CI fix from latest failure

   • Fixed failing trusted-profile WF02 integration path caused by legacy AutomationProfile field names by switching to current fields (decompose_task, create_tool, select_tool).
   • File: robot/wf02_test_generation_commands.py.

Also rebased branch onto latest master, reran full quality gates, and force-pushed updated head (6b9bfacc).

Addressed follow-up from review feedback and CI: 1. **BDD unit-level accompaniment added** - Added Behave feature + steps for WF02 behavior. - Files: `features/wf02_test_generation.feature`, `features/steps/wf02_test_generation_steps.py`. 2. **`_NoCloseSession` clarity improved** - Added explicit explanatory docstring/comment describing the proxy purpose and why it prevents fixture-managed session close side effects. - File: `robot/wf02_test_generation_validation.py`. 3. **Removed private lifecycle API usage** - Replaced private `lifecycle._commit_plan(...)` use with public lifecycle API (`save_plan(...)`) in WF02 helpers. - Files: `robot/wf02_test_generation_validation.py`, `robot/wf02_test_generation_common.py`, `robot/wf02_test_generation_artifacts.py`. 4. **CI fix from latest failure** - Fixed failing trusted-profile WF02 integration path caused by legacy AutomationProfile field names by switching to current fields (`decompose_task`, `create_tool`, `select_tool`). - File: `robot/wf02_test_generation_commands.py`. Also rebased branch onto latest `master`, reran full quality gates, and force-pushed updated head (`6b9bfacc`).

brent.edwards force-pushed test/int-wf02-test-generation from 6b9bfaccf3 to 183fe363bf 2026-04-01 01:19:10 +00:00 Compare

brent.edwards added 1 commit 2026-04-01 02:14:21 +00:00

Merge branch 'master' into test/int-wf02-test-generation d82c8359b1

brent.edwards removed a dependency 2026-04-01 02:14:48 +00:00

#766 test(integration): workflow example 2 — automated test generation for a module (trusted profile)

brent.edwards scheduled this pull request to auto merge when all checks succeed 2026-04-01 02:15:03 +00:00

brent.edwards merged commit 81c141716b into master 2026-04-01 03:30:01 +00:00

brent.edwards deleted branch test/int-wf02-test-generation 2026-04-01 03:30:01 +00:00

brent.edwards referenced this pull request from a commit 2026-04-01 03:30:02 +00:00

test(integration): workflow example 2 — automated test generation for a module (trusted profile) (#1176)

Sign in to join this conversation.

Reviewers

No reviewers

CoreRasurae

hamza.khyari

Labels

Clear labels   

auto/needs-reevaluation

Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  

controller-managed

Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  

auto/claimed-implementer

Currently being processed by an implementer worker.

  

auto/claimed-merge

Currently being processed by the merge driver.

  

auto/claimed-reviewer

Currently being processed by a reviewer worker.

  

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

  

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

  

auto/needs-implementer

Failing CI needs implementer attention.

  

auto/postmortem

Documenting a driver incident or rollback.

  

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

  

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

  

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

  

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  

Points

1

1 man-hours worth of work for an expert with no learning curve.

  

Points

13

13 man-hours worth of work for an expert with no learning curve.

  

Points

2

2 man-hours worth of work for an expert with no learning curve.

  

Points

21

21 man-hours worth of work for an expert with no learning curve.

  

Points

3

3 man-hours worth of work for an expert with no learning curve.

  

Points

34

34 man-hours worth of work for an expert with no learning curve.

  

Points

5

5 man-hours worth of work for an expert with no learning curve.

  

Points

55

55 man-hours worth of work for an expert with no learning curve.

  

Points

8

8 man-hours worth of work for an expert with no learning curve.

  

Points

88

88 man-hours worth of work for an expert with no learning curve.

  

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

  

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  

State

Duplicate

A ticket that represents the same content as an existing ticket.

  

State

In Progress

A ticket that is actively being developed.

  

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  

Type

Automation

Any edits or discussion about the AI automated coding system.

  

Type

Bug

Something that doesnt work as intended.

  

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  

Type

Documentation

An error or improvement needed in the documentation.

  

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  

Type

Feature

Some new functionality not present.

  

Type

Legendary

A type of Epic which will contain other Epics.

  

Type

Refactor

A code change that restructures existing code without changing its external behavior.

  

Type

Support

Someone needs help using the project.

  

Type

Task

A generic task that doesnt fit into the other type categories.

  

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No labels

auto/needs-reevaluation

controller-managed

auto/blocked-by-deps

auto/ci-timeout

auto/claimed-implementer

auto/claimed-merge

auto/claimed-reviewer

auto/driver-down

auto/invariant-violation

auto/last-attempt-tier-0

auto/last-attempt-tier-1

auto/last-attempt-tier-2

auto/last-attempt-tier-min

Automation Tracking

auto/needs-conflict-resolution

auto/needs-implementer

auto/postmortem

auto/ready-to-merge

auto/restart-throttled

auto/revert

auto/sentinel

auto/stale-inactivity

auto/unstable

Blocked

Bounty

$100

Bounty

$1000

Bounty

$10000

Bounty

$20

Bounty

$2000

Bounty

$250

Bounty

$50

Bounty

$500

Bounty

$5000

Bounty

$750

MoSCoW

Could have

MoSCoW

Must have

MoSCoW

Should have

Needs Feedback

Points

1

Points

13

Points

2

Points

21

Points

3

Points

34

Points

5

Points

55

Points

8

Points

88

Priority

Backlog

Priority

CI Blocker

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Signed-off: Owner

Signed-off: Scrum Master

Signed-off: Tech Lead

Spike

State

Completed

State

Duplicate

State

In Progress

State

In Review

State

Paused

State

Unverified

State

Verified

State

Wont Do

Type

Automation

Type

Bug

Type

Discussion

Type

Documentation

Type

Epic

Type

Feature

Type

Legendary

Type

Refactor

Type

Support

Type

Task

Type

Testing

Milestone

Clear milestone

No items

No milestone

v3.2.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cleveragents/cleveragents-core!1176

No description provided.