feat(events): enrich PLAN_APPLIED event with changeset statistics from PlanApplyService #716

New issue

Closed

opened 2026-03-12 01:55:33 +00:00 by CoreRasurae · 3 comments

CoreRasurae commented

2026-03-12 01:55:33 +00:00

Member

Metadata

Field	Value
Commit Message	`feat(events): enrich PLAN_APPLIED event with changeset statistics from PlanApplyService`
Branch	`feature/enrich-plan-applied-event`

Summary

The PLAN_APPLIED event emitted by PlanLifecycleService._apply_plan() only includes action_name, phase, and project_names in its details. The specification's SEC7 audit logging section suggests richer detail (changeset statistics, number of files affected). This data is computed later by PlanApplyService.

Spec Reference

Section: Security > SEC7 Audit Logging
Related: Issue #581 (AuditService wiring), Finding M4 from #678

Current State

PLAN_APPLIED event emitted at PlanLifecycleService._apply_plan() (around line 1160)
Only includes action_name, phase, project_names
Changeset data, diff statistics, file counts are computed later by PlanApplyService

Description

Either:

Emit a supplementary PLAN_APPLY_COMPLETED event from PlanApplyService after changeset application with full statistics, OR
Restructure the pipeline so the lifecycle service receives apply results before emitting

Acceptance Criteria

PLAN_APPLIED (or supplementary event) includes changeset statistics
Details include: number of files affected, diff size, changeset summary
Audit log entries for plan application contain rich context
Unit and integration tests verify enriched event payload

Parent: #678 (Specification issues from #581)
Related: #581 (AuditService wiring)

Subtasks

Code: Enrich plan applied event with changeset statistics
Behave tests: Add BDD scenarios for enriched event payload
Robot tests: Integration test for enriched audit entry
Quality: coverage >=97%: Verify via nox -s coverage_report
Quality: nox full suite: Run nox (all default sessions), fix any errors

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

## Metadata | Field | Value | |-------|-------| | **Commit Message** | `feat(events): enrich PLAN_APPLIED event with changeset statistics from PlanApplyService` | | **Branch** | `feature/enrich-plan-applied-event` | ## Summary The `PLAN_APPLIED` event emitted by `PlanLifecycleService._apply_plan()` only includes `action_name`, `phase`, and `project_names` in its details. The specification's SEC7 audit logging section suggests richer detail (changeset statistics, number of files affected). This data is computed later by `PlanApplyService`. ## Spec Reference **Section**: Security > SEC7 Audit Logging **Related**: Issue #581 (AuditService wiring), Finding M4 from #678 ## Current State - `PLAN_APPLIED` event emitted at `PlanLifecycleService._apply_plan()` (around line 1160) - Only includes `action_name`, `phase`, `project_names` - Changeset data, diff statistics, file counts are computed later by `PlanApplyService` ## Description Either: 1. Emit a supplementary `PLAN_APPLY_COMPLETED` event from `PlanApplyService` after changeset application with full statistics, OR 2. Restructure the pipeline so the lifecycle service receives apply results before emitting ## Acceptance Criteria - [ ] `PLAN_APPLIED` (or supplementary event) includes changeset statistics - [ ] Details include: number of files affected, diff size, changeset summary - [ ] Audit log entries for plan application contain rich context - [ ] Unit and integration tests verify enriched event payload ## Related Issues - Parent: #678 (Specification issues from #581) - Related: #581 (AuditService wiring) ## Subtasks - [ ] **Code**: Enrich plan applied event with changeset statistics - [ ] **Behave tests**: Add BDD scenarios for enriched event payload - [ ] **Robot tests**: Integration test for enriched audit entry - [ ] **Quality: coverage >=97%**: Verify via `nox -s coverage_report` - [ ] **Quality: nox full suite**: Run `nox` (all default sessions), fix any errors ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

CoreRasurae referenced this issue

2026-03-12 01:56:19 +00:00

Specification issues during the development of issue #581 #678