feat(autonomy): automation profile resolution precedence correct #1196
No reviewers
Labels
No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
cleveragents/cleveragents-core!1196
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feature/m6-automation-profiles"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
_resolve_plan_profile_refto catch only(KeyError, ValueError, OSError)with warning-level structured logging, replacing bareexcept Exception:per CONTRIBUTING.md §Exception Propagation.@tdd_bug @tdd_bug_1076/ "TDD Bug #1076" referencing the original bug ticket.tdd_plan_explain_plan_idhelper).Approach
The automation profile resolution is implemented in
PlanLifecycleService._resolve_plan_profile_ref, which evaluates the four-level precedence chain (plan > action > project > global) atuse_action()time. The resolved profile is stored as anAutomationProfileRefon the Plan with provenance tracking. TheConfigServiceis used for project-scoped and global config lookups, with narrowed exception handling that logs warnings on failure and falls back to the settings default.Validation
nox -s lint✅nox -s typecheck✅nox -s unit_tests✅nox -s coverage_report✅ (97%)Review Fix Round (Review #2963)
except Exception:-> narrowed to(KeyError, ValueError, OSError)with warning logging - addresses CONTRIBUTING.md §Exception Propagation violation@tdd_bug @tdd_bug_1076with title "TDD Bug #1076"532ea100)Integration CI Follow-up
integration_testsfailure in workflow-05 helper logic caused by fixed-step lifecycle assumptions under auto-progression.phase+processing_state) before invoking each transition, covering both manual and auto-progressed paths.nox -s integration_tests✅nox -s lint✅nox -s typecheck✅nox -s unit_tests✅nox -s e2e_tests✅nox -s coverage_report✅Closes #854
Review: APPROVED with Comments
Small, well-focused change implementing 4-level automation profile precedence.
Notes
Consider adding BDD scenarios specifically testing each precedence level (plan > action > project > global) individually. Currently only the TDD bug-capture test is updated.
The duplicate validation (CLI validates profile name, service also validates) is acceptable as defense-in-depth.
Good: Clean precedence chain logic with structured logging at each resolution level.
Good:
ConfigServiceproperly injected with a sensible default.Updated Review (Deep Pass): REQUEST CHANGES
My initial review approved this PR. The deep review reveals a blocking issue.
New Finding: Bare
except Exception:in_resolve_plan_profile_refAt line ~905 of
plan_lifecycle_service.py, the config resolution is wrapped in:This catches all exceptions — including config corruption, permission errors, import failures,
AttributeError, etc. — and silently falls back to the default profile. Per CONTRIBUTING.md §Exception Propagation: "Do not suppress errors. Let exceptions propagate."Action required: Either narrow to specific expected exceptions (e.g.,
KeyError,FileNotFoundError) or at minimum log the caught exception atwarninglevel so issues are traceable.New Finding: Tag inconsistency
The feature file tag was changed from
@tdd_issue_1076to@tdd_issue_854, but the feature title still says "TDD Issue #1076". If #854 is correct, update the title. If #1076 is correct, revert the tag.Previous findings still apply:
ConfigServiceproperly injected with sensible default859b74a5cbd35280ff18Review Response — Addressing Review #2963 (REQUEST_CHANGES by @freemo)
1. Bare
except Exception:in_resolve_plan_profile_ref✅ FixedNarrowed the exception handler to
except (KeyError, ValueError, OSError) as exc:and added warning-level structured logging that records:This covers the three exception categories that
ConfigService.resolve()can legitimately raise (dict key errors, unregistered keys / TOML parse errors, file I/O issues). Any unexpected exception type (programming errors) will now propagate as required by CONTRIBUTING.md §Exception Propagation.Added a new BDD scenario ("Plan falls back to settings default when config service raises an error") that exercises this handler via a
_BrokenConfigServicetest double.2. Tag inconsistency ✅ Fixed
Updated
features/tdd_use_action_automation_profile.feature:@tdd_issue @tdd_issue_854→@tdd_bug @tdd_bug_1076The TDD test was correctly associated with bug #1076 (use_action() doesn't propagate automation_profile). Aligned tag convention to
@tdd_bugper project standards.3. Previous approved comments (informational) — Acknowledged
Quality Gates (all pass)
nox -s lint✅nox -s typecheck✅nox -s unit_tests✅nox -s coverage_report✅ (97.0%)Rebase
Branch rebased onto latest
origin/master(532ea100). Resolved one conflict inrobot/resource_dag.robot(shared session variable naming — took master's convention).8111a98847915e791a05Implementation note: addressing CI
integration_testsinstability found on this PR head.complete_strategizewhen auto-progression advances the plan state earlier than the helper expected.robot/helper_int_wf05_db_migration.pyassumed a fixed linear transition sequence (complete_strategize -> execute_plan -> start_execute -> complete_execute). With auto-progression enabled, the plan can already be inEXECUTE/QUEUED(or later), so unconditional calls can become invalid and fail nondeterministically._review_profile_behavior()and_plan_lifecycle_review_profile()to read the current(phase, processing_state)after each transition and only invoke the next operation when valid for that state.Key code location:
robot/helper_int_wf05_db_migration.py(_review_profile_behavior,_plan_lifecycle_review_profile)