feat(autonomy): automation profile resolution precedence correct #1196
Merged
brent.edwards
merged 4 commits from 2026-04-01 04:27:09 +00:00
feature/m6-automation-profiles into master
Dismiss Review
Are you sure you want to dismiss this review?
Labels
Clear labels
auto/needs-reevaluation
controller-managed
overdue
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Needs Feedback
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
Currently being processed by an implementer worker.
Currently being processed by the merge driver.
Currently being processed by a reviewer worker.
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
Tracking issues used by the AI Automation system for agents to communicate and report.
Rebase conflict needs LLM conflict-resolver.
Failing CI needs implementer attention.
Documenting a driver incident or rollback.
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Type
Feature
Projects
Clear projects
No project
Assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cleveragents/cleveragents-core#1196
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "feature/m6-automation-profiles"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
_resolve_plan_profile_refto catch only(KeyError, ValueError, OSError)with warning-level structured logging, replacing bareexcept Exception:per CONTRIBUTING.md §Exception Propagation.@tdd_bug @tdd_bug_1076/ "TDD Bug #1076" referencing the original bug ticket.tdd_plan_explain_plan_idhelper).Approach
The automation profile resolution is implemented in
PlanLifecycleService._resolve_plan_profile_ref, which evaluates the four-level precedence chain (plan > action > project > global) atuse_action()time. The resolved profile is stored as anAutomationProfileRefon the Plan with provenance tracking. TheConfigServiceis used for project-scoped and global config lookups, with narrowed exception handling that logs warnings on failure and falls back to the settings default.Validation
nox -s lint✅nox -s typecheck✅nox -s unit_tests✅nox -s coverage_report✅ (97%)Review Fix Round (Review #2963)
except Exception:-> narrowed to(KeyError, ValueError, OSError)with warning logging - addresses CONTRIBUTING.md §Exception Propagation violation@tdd_bug @tdd_bug_1076with title "TDD Bug #1076"532ea100)Integration CI Follow-up
integration_testsfailure in workflow-05 helper logic caused by fixed-step lifecycle assumptions under auto-progression.phase+processing_state) before invoking each transition, covering both manual and auto-progressed paths.nox -s integration_tests✅nox -s lint✅nox -s typecheck✅nox -s unit_tests✅nox -s e2e_tests✅nox -s coverage_report✅Closes #854
Review: APPROVED with Comments
Small, well-focused change implementing 4-level automation profile precedence.
Notes
Consider adding BDD scenarios specifically testing each precedence level (plan > action > project > global) individually. Currently only the TDD bug-capture test is updated.
The duplicate validation (CLI validates profile name, service also validates) is acceptable as defense-in-depth.
Good: Clean precedence chain logic with structured logging at each resolution level.
Good:
ConfigServiceproperly injected with a sensible default.Updated Review (Deep Pass): REQUEST CHANGES
My initial review approved this PR. The deep review reveals a blocking issue.
New Finding: Bare
except Exception:in_resolve_plan_profile_refAt line ~905 of
plan_lifecycle_service.py, the config resolution is wrapped in:This catches all exceptions — including config corruption, permission errors, import failures,
AttributeError, etc. — and silently falls back to the default profile. Per CONTRIBUTING.md §Exception Propagation: "Do not suppress errors. Let exceptions propagate."Action required: Either narrow to specific expected exceptions (e.g.,
KeyError,FileNotFoundError) or at minimum log the caught exception atwarninglevel so issues are traceable.New Finding: Tag inconsistency
The feature file tag was changed from
@tdd_issue_1076to@tdd_issue_854, but the feature title still says "TDD Issue #1076". If #854 is correct, update the title. If #1076 is correct, revert the tag.Previous findings still apply:
ConfigServiceproperly injected with sensible default859b74a5cbtod35280ff18Review Response — Addressing Review #2963 (REQUEST_CHANGES by @freemo)
1. Bare
except Exception:in_resolve_plan_profile_ref✅ FixedNarrowed the exception handler to
except (KeyError, ValueError, OSError) as exc:and added warning-level structured logging that records:This covers the three exception categories that
ConfigService.resolve()can legitimately raise (dict key errors, unregistered keys / TOML parse errors, file I/O issues). Any unexpected exception type (programming errors) will now propagate as required by CONTRIBUTING.md §Exception Propagation.Added a new BDD scenario ("Plan falls back to settings default when config service raises an error") that exercises this handler via a
_BrokenConfigServicetest double.2. Tag inconsistency ✅ Fixed
Updated
features/tdd_use_action_automation_profile.feature:@tdd_issue @tdd_issue_854→@tdd_bug @tdd_bug_1076The TDD test was correctly associated with bug #1076 (use_action() doesn't propagate automation_profile). Aligned tag convention to
@tdd_bugper project standards.3. Previous approved comments (informational) — Acknowledged
Quality Gates (all pass)
nox -s lint✅nox -s typecheck✅nox -s unit_tests✅nox -s coverage_report✅ (97.0%)Rebase
Branch rebased onto latest
origin/master(532ea100). Resolved one conflict inrobot/resource_dag.robot(shared session variable naming — took master's convention).8111a98847to915e791a05Implementation note: addressing CI
integration_testsinstability found on this PR head.complete_strategizewhen auto-progression advances the plan state earlier than the helper expected.robot/helper_int_wf05_db_migration.pyassumed a fixed linear transition sequence (complete_strategize -> execute_plan -> start_execute -> complete_execute). With auto-progression enabled, the plan can already be inEXECUTE/QUEUED(or later), so unconditional calls can become invalid and fail nondeterministically._review_profile_behavior()and_plan_lifecycle_review_profile()to read the current(phase, processing_state)after each transition and only invoke the next operation when valid for that state.Key code location:
robot/helper_int_wf05_db_migration.py(_review_profile_behavior,_plan_lifecycle_review_profile)