fix(cli): resolve --force/-f short form conflict on project delete #1263
No reviewers
Labels
No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Blocks
#911 fix(cli): resolve
--force/-f short form conflict on project delete
cleveragents/cleveragents-core
Reference
cleveragents/cleveragents-core!1263
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/project-delete-force-short-form"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Resolves a conflict between the
--forceand--formatflags on theproject deletecommand. The specification definesproject deletewith--force/-f, but the implementation had assigned-fto--formatinstead. This fix reassigns-fto--force(per spec) and removes the short alias from--formaton this command.Changes
-fas a short alias for--forceonproject delete, aligning with the specification (docs/specification.mdline 3418)-fshort alias from--formatonproject deleteto resolve the conflict (the spec does not define--format/-fon this command)-f/--forceforms are now interchangeableTesting
-fand--forcepathways verified to trigger force-delete behavior--format(long form only) continues to work as expectedCloses #911
--force/-fshort form conflict onproject deleteb7874cf7118c312307c58c312307c5b4ba22cbdfIndependent Code Review — APPROVED ✅
Summary
Reviewed the complete diff (3 files, 1 commit) against the specification and project conventions. This is a clean, well-scoped bug fix that correctly resolves the
-fshort flag conflict onproject delete.Specification Alignment ✅
agents project delete [--force|-f] [--yes|-y] <NAME>— the implementation now matches exactly.--formatonproject deletecorrectly loses its-fshort alias (the spec does not define--format/-fon this command).create,list,show,link-resource, andunlink-resourceretain--format/-f(no conflict since they lack--force), andinitalready had--force/-fcorrectly.Code Quality ✅
project.py(docstring + twotyper.Optiondeclarations).ISSUES CLOSED: #911footer.Test Quality ✅
--force), then invokes delete with-f, proving-fmaps to--force.CliRunner(not direct Python function call) to exercise Typer's actual argument parser — this is the right approach for testing CLI flag binding.Quality Gates ✅
nox -e lint: PASSEDnox -e typecheck: PASSED (0 errors, 0 warnings)nox -e unit_tests: PASSED (38 scenarios, 0 failed)Minor Observations (non-blocking)
project.pyexceeds the 500-line guideline, but this is a pre-existing condition not introduced by this PR.--format(long form) onproject delete, but the existing "delete command with json format" scenario covers the format parameter via direct invocation, and removing a short alias doesn't affect the long form.No issues found. Proceeding with merge.
--force/-fshort form conflict onproject delete#911🔒 Claimed by pr-reviewer-2. Starting independent code review.
Independent Code Review — APPROVED ✅
Summary
Reviewed the complete diff (3 files, 1 commit) against the specification and project conventions. This is a clean, well-scoped bug fix that correctly resolves the
-fshort flag conflict onproject delete.Specification Alignment ✅
agents project delete [--force|-f] [--yes|-y] <NAME>— the implementation now matches exactly.--formatonproject deletecorrectly loses its-fshort alias (the spec does not define--format/-fon this command).create,list,show,link-resource, andunlink-resourceretain--format/-f(no conflict since they lack--force), andinitalready had--force/-fcorrectly.Code Quality ✅
project.py(docstring + twotyper.Optiondeclarations).ISSUES CLOSED: #911footer.Test Quality ✅
--force), then invokes delete with-f, proving-fmaps to--force.CliRunner(not direct Python function call) to exercise Typer's actual argument parser — this is the right approach for testing CLI flag binding.Quality Gates
Previous reviewer confirmed all gates pass:
nox -e lint: PASSEDnox -e typecheck: PASSED (0 errors, 0 warnings)nox -e unit_tests: PASSED (38 scenarios, 0 failed)Minor Observations (non-blocking)
project.pyexceeds the 500-line guideline, but this is a pre-existing condition not introduced by this PR.# type: ignore[import-untyped]on behave import in the step file is pre-existing, not introduced here.No issues found. Proceeding with merge.
--force/-fshort form conflict onproject delete#911Review claimed by reviewer pool instance reviewer-pool-1. Dispatching independent code review.
Independent Code Review — APPROVED ✅
Summary
Reviewed the complete diff (3 files, 1 commit) against the specification and project conventions. This is a clean, well-scoped bug fix that correctly resolves the
-fshort flag conflict onproject delete.Specification Alignment ✅
agents project delete [--force|-f] [--yes|-y] <NAME>— the implementation now matches exactly.--formatonproject deletecorrectly loses its-fshort alias (the spec does not define--format/-fon this command).create,list,show,link-resource, andunlink-resourceretain--format/-f(no conflict since they lack--force), andinitalready had--force/-fcorrectly.Code Changes Verified ✅
Three precise changes in
project.py:[--force] [--yes]→[--force|-f] [--yes|-y]deletecommandforceparam: Added-fshort alias totyper.Option("--force", "-f", ...)deletecommandoutput_formatparam: Removed-ffromtyper.Option("--format", ...)(long-form only)Test Quality ✅
--force), then invokes delete with-fviaCliRunner, proving-fmaps to--force.CliRunner(not direct Python function call) to exercise Typer's actual argument parser — this is the right approach for testing CLI flag binding.try/finallycleanup of monkey-patches in the new step.Commit Quality ✅
fix(cli): add -f short form to project delete --forceISSUES CLOSED: #911footer.fix/project-delete-force-short-formfollows conventions.PR Metadata ✅
Type/Tasklabel presentCloses #911in PR bodyMinor Observations (non-blocking)
project.pyexceeds the 500-line guideline — pre-existing, not introduced by this PR.# type: ignore[import-untyped]on behave import in step file — pre-existing.No issues found. Proceeding with merge.
--force/-fshort form conflict onproject delete#911