test(bdd): add direct test for _fast_init_or_upgrade early-return behavior #733

New issue

Closed

opened 2026-03-12 13:19:18 +00:00 by CoreRasurae · 2 comments

CoreRasurae commented

2026-03-12 13:19:18 +00:00

Member

Metadata

Commit Message: test(bdd): add direct test for _fast_init_or_upgrade early-return behavior
Branch: test/m3-fast-init-early-return

Summary

The behavioral change introduced in PR #727 (skip Alembic migration for existing non-empty test databases) has no direct test verifying the early-return logic. The 15 scenarios in core_cli_commands.feature pass because of the change (no more hangs), but none explicitly verify that _original_init_or_upgrade is NOT invoked when a non-empty DB exists.

Background and Context

Identified during the code review of PR #727 (Finding #2 in the APPROVED review by @hurui200320). The reviewer recommended a follow-up ticket to add explicit test coverage for this behavior.

Current Behavior

A search for _fast_init_or_upgrade across all .feature files returns zero matches. The early-return logic is implicitly tested (scenarios pass because they no longer hang), but there is no explicit assertion that the original migration runner is skipped.

Expected Behavior

A dedicated test should:

Create a non-empty test database file (matching _SCENARIO_DB_PREFIXES)
Call _fast_init_or_upgrade on it
Assert that _original_init_or_upgrade is NOT invoked (e.g., via mock/patch verification)
Verify the function returns immediately

Acceptance Criteria

A test exists that directly exercises _fast_init_or_upgrade with a non-empty DB
The test asserts _original_init_or_upgrade is not called
The test also verifies the template-copy path works for non-existent DBs
Test passes under both sequential and parallel execution

Supporting Information

Identified in: PR #727 Code Review, Finding #2 (APPROVED review)
Review URL: #727
Reviewer: @hurui200320
Related PR: #727 (the change being tested)
Related Issue: #726

Subtasks

Create a unit test or BDD scenario that sets up a non-empty DB file with a matching prefix
Mock/patch _original_init_or_upgrade and assert it is not called
Add a complementary test for the template-copy path (DB doesn't exist yet)
Add a test for the fallback path (non-matching prefix still delegates to original)
Run nox -s unit_tests to verify all tests pass

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

## Metadata - **Commit Message**: `test(bdd): add direct test for _fast_init_or_upgrade early-return behavior` - **Branch**: `test/m3-fast-init-early-return` ## Summary The behavioral change introduced in PR #727 (skip Alembic migration for existing non-empty test databases) has no direct test verifying the early-return logic. The 15 scenarios in `core_cli_commands.feature` pass because of the change (no more hangs), but none explicitly verify that `_original_init_or_upgrade` is NOT invoked when a non-empty DB exists. ## Background and Context Identified during the code review of PR #727 (Finding #2 in the APPROVED review by @hurui200320). The reviewer recommended a follow-up ticket to add explicit test coverage for this behavior. ## Current Behavior A search for `_fast_init_or_upgrade` across all `.feature` files returns zero matches. The early-return logic is implicitly tested (scenarios pass because they no longer hang), but there is no explicit assertion that the original migration runner is skipped. ## Expected Behavior A dedicated test should: 1. Create a non-empty test database file (matching `_SCENARIO_DB_PREFIXES`) 2. Call `_fast_init_or_upgrade` on it 3. Assert that `_original_init_or_upgrade` is NOT invoked (e.g., via mock/patch verification) 4. Verify the function returns immediately ## Acceptance Criteria - [ ] A test exists that directly exercises `_fast_init_or_upgrade` with a non-empty DB - [ ] The test asserts `_original_init_or_upgrade` is not called - [ ] The test also verifies the template-copy path works for non-existent DBs - [ ] Test passes under both sequential and parallel execution ## Supporting Information - Identified in: PR #727 Code Review, Finding #2 (APPROVED review) - Review URL: https://git.cleverthis.com/cleveragents/cleveragents-core/pulls/727 - Reviewer: @hurui200320 - Related PR: #727 (the change being tested) - Related Issue: #726 ## Subtasks - [ ] Create a unit test or BDD scenario that sets up a non-empty DB file with a matching prefix - [ ] Mock/patch `_original_init_or_upgrade` and assert it is not called - [ ] Add a complementary test for the template-copy path (DB doesn't exist yet) - [ ] Add a test for the fallback path (non-matching prefix still delegates to original) - [ ] Run `nox -s unit_tests` to verify all tests pass ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

CoreRasurae added the

Gate	Result
`nox -s lint`	PASS
`nox -s typecheck`	PASS (0 errors)
`nox -s unit_tests`	PASS (12,426 scenarios)
`nox -s integration_tests`	PASS (1,727 tests)
`nox -s coverage_report`	PASS (98% >= 97%)

Rows
Columns