fix(cli): remove extra `--mode/-m` flag from `validation attach` #913

New issue

Closed

opened 2026-03-13 23:59:08 +00:00 by freemo · 4 comments

freemo commented

2026-03-13 23:59:08 +00:00

Owner

Background

The validation attach command in the current implementation (src/cleveragents/cli/commands/validation.py:268) includes a --mode/-m flag:

mode: Annotated[
    str,
    typer.Option("--mode", "-m", help="Validation mode: required or informational"),
] = "required",

The specification (spec lines 9535-9549) defines validation attach as:

agents validation attach [--project <PROJECT>|--plan <PLAN_ID>]
                         <RESOURCE> <VALIDATION> [<ARGS>...]

The spec does not include --mode on validation attach. The validation mode is an inherent property of the validation definition itself, set at registration time via validation add, not an override at attachment time.

The spec's example output does show Mode: required in the response, but this reflects the validation's own mode property — not a per-attachment override.

Acceptance Criteria

The --mode/-m flag is removed from validation attach
If the mode needs to be displayed in output, it is read from the validation's registered definition
CLI --help output for validation attach matches the specification signature
Existing tests pass; any tests relying on --mode on validation attach are updated

Metadata

Suggested commit message: fix(cli): remove extra --mode flag from validation attach
Suggested branch name: fix/validation-attach-remove-mode-flag

Definition of Done

Code merged to main, validation attach no longer accepts --mode, validation mode is determined by the validation definition.

## Background The `validation attach` command in the current implementation (`src/cleveragents/cli/commands/validation.py:268`) includes a `--mode/-m` flag: ```python mode: Annotated[ str, typer.Option("--mode", "-m", help="Validation mode: required or informational"), ] = "required", ``` The specification ([spec lines 9535-9549](../docs/specification.md)) defines `validation attach` as: ``` agents validation attach [--project <PROJECT>|--plan <PLAN_ID>] <RESOURCE> <VALIDATION> [<ARGS>...] ``` The spec does **not** include `--mode` on `validation attach`. The validation mode is an inherent property of the validation definition itself, set at registration time via `validation add`, not an override at attachment time. The spec's example output does show `Mode: required` in the response, but this reflects the validation's own mode property — not a per-attachment override. ## Acceptance Criteria - [x] The `--mode/-m` flag is removed from `validation attach` - [x] If the mode needs to be displayed in output, it is read from the validation's registered definition - [x] CLI `--help` output for `validation attach` matches the specification signature - [x] Existing tests pass; any tests relying on `--mode` on `validation attach` are updated ## Metadata - **Suggested commit message:** `fix(cli): remove extra --mode flag from validation attach` - **Suggested branch name:** `fix/validation-attach-remove-mode-flag` ## Definition of Done Code merged to `main`, `validation attach` no longer accepts `--mode`, validation mode is determined by the validation definition.

freemo added the

MoSCoW

Rows
Columns

fix(cli): remove extra --mode/-m flag from validation attach #913

Background

Acceptance Criteria

Metadata

Definition of Done

Implementation Notes

Design Decisions

Test Updates

Quality Gate Results

fix(cli): remove extra `--mode/-m` flag from `validation attach` #913