feat(plugin): register spec-defined extension points in PluginManager #1217

Merged

freemo merged 1 commits from feature/plugin-extension-points into master 2026-04-02 17:40:19 +00:00

Conversation 8 Commits 1 Files Changed 7

+1738 -1

CoreRasurae commented 2026-03-31 03:59:54 +00:00

Member

Copy Link

Copy Source

Summary

Registers all 30 spec-defined extension points in the ExtensionPointRegistry with typed Protocol interfaces, completing the plugin extension infrastructure. Plugins can now discover and register implementations for all system hooks defined in the specification.

Changes

• Created extension_protocols.py with 21 @runtime_checkable Protocol classes covering all extension point categories
• Created extension_catalog.py with declarative extension point definitions and register_all_extension_points() bootstrap function
• Wired extension point registration into get_container() during app startup
• Added context subsystem integration: ACMSPipeline now accepts a PluginManager and can discover context.* extension point implementations
• Added 38 Behave test scenarios covering registration, lookup, protocol conformance, and entry point discovery

Extension Point Categories (30 total)

Category	Count	Extension Points
Context	12	strategy, 10 pipeline components, storage_backend
Output	3	renderer, materializer, format
Validation	2	runner, rule_provider
Tools	2	provider, middleware
Skills	2	provider, template
Resources	2	resolver, type_handler
A2A	2	transport, extension_method
Events	2	handler, filter
Config	2	source, validator
Safety	1	guardrail

Quality Gates

• lint: Passed
• typecheck: Passed (0 errors)
• unit_tests: Passed (13,023 scenarios)
• coverage: 97.0% — OK

Closes #939

## Summary Registers all 30 spec-defined extension points in the `ExtensionPointRegistry` with typed Protocol interfaces, completing the plugin extension infrastructure. Plugins can now discover and register implementations for all system hooks defined in the specification. ### Changes - Created `extension_protocols.py` with 21 `@runtime_checkable` Protocol classes covering all extension point categories - Created `extension_catalog.py` with declarative extension point definitions and `register_all_extension_points()` bootstrap function - Wired extension point registration into `get_container()` during app startup - Added context subsystem integration: `ACMSPipeline` now accepts a `PluginManager` and can discover context.* extension point implementations - Added 38 Behave test scenarios covering registration, lookup, protocol conformance, and entry point discovery ### Extension Point Categories (30 total) | Category | Count | Extension Points | |----------|-------|-----------------| | Context | 12 | strategy, 10 pipeline components, storage_backend | | Output | 3 | renderer, materializer, format | | Validation | 2 | runner, rule_provider | | Tools | 2 | provider, middleware | | Skills | 2 | provider, template | | Resources | 2 | resolver, type_handler | | A2A | 2 | transport, extension_method | | Events | 2 | handler, filter | | Config | 2 | source, validator | | Safety | 1 | guardrail | ### Quality Gates - lint: Passed - typecheck: Passed (0 errors) - unit_tests: Passed (13,023 scenarios) - coverage: 97.0% — OK Closes #939

CoreRasurae added 1 commit 2026-03-31 03:59:54 +00:00

feat(plugin): register spec-defined extension points in PluginManager ... 3f5ca4e869

Registered all 30 spec-defined extension points in the ExtensionPointRegistry
with typed Protocol interfaces for each category: context strategies (12),
output renderers (3), validation runners (2), tool providers (2),
skill providers (2), resource handlers (2), A2A transports (2),
event handlers (2), config sources (2), and safety guardrails (1).

Added extension_protocols.py with Protocol definitions and
extension_catalog.py with the registration catalog. Wired context
subsystem to query context.* extension points at initialization.

ISSUES CLOSED: #939

CoreRasurae added this to the v3.6.0 milestone 2026-03-31 04:00:01 +00:00

CoreRasurae added the

Type

Feature

label 2026-03-31 04:00:01 +00:00

freemo self-assigned this 2026-04-02 06:15:14 +00:00

freemo commented 2026-04-02 08:03:15 +00:00

Owner

Copy Link

Copy Source

🔒 Claimed by pr-reviewer-3. Starting independent code review.

🔒 Claimed by pr-reviewer-3. Starting independent code review.

freemo approved these changes 2026-04-02 08:12:28 +00:00

Dismissed

freemo left a comment

Owner

Copy Link

Copy Source

Code Review — PR #1217: feat(plugin): register spec-defined extension points in PluginManager

✅ APPROVED

Reviewed: Full diff (7 files, 1738 additions), linked issue #939, specification alignment, test coverage, code quality.

---

Specification Alignment ✅

All 30 spec-defined extension points are registered with correct names, categories, and counts:

• Context (12): strategy, 10 pipeline components, storage_backend
• Output (3), Validation (2), Tools (2), Skills (2), Resources (2), A2A (2), Events (2), Config (2), Safety (1)

The extension point names, Protocol interfaces, and category groupings match the specification's Extension Points Summary.

Architecture & Design ✅

• ExtensionPointRegistrar protocol in extension_catalog.py — good use of structural typing to decouple the catalog from PluginManager.
• Lazy wiring in container.py — extension points registered after container creation, before lazy providers are resolved. Correct ordering.
• ACMSPipeline integration — clean optional plugin_manager parameter with discovery-only behavior (no auto-activation). Follows the spec's "wired on demand" pattern.
• Idempotent registration — register_extension_point uses dict keyed by name, so re-registration is safe.

Protocol Design ✅

• All 21 @runtime_checkable Protocol classes use collections.abc.Mapping/Sequence for parameter types — good for structural typing compatibility.
• Each protocol has a descriptive name property and meaningful method signatures.
• ALL_EXTENSION_PROTOCOLS dict provides programmatic access for introspection.

Test Quality ✅

• 38 Behave scenarios covering: registration, lookup by name, lookup by category, protocol type correctness, entry point discovery, ACMSPipeline wiring, runtime-checkable verification, idempotency, registry_key consistency, and protocol conformance for all 21 protocol types.
• Tests verify both positive and negative cases (non-existent lookup returns None, no plugins by default).
• Stub implementations exercise actual protocol methods, not just isinstance checks.

Minor Observations (non-blocking)

1. Step file size: plugin_extension_points_steps.py is 787 lines (project guideline: <500). The 21 stub classes account for ~350 lines. Consider extracting stubs to features/mocks/plugin_extension_stubs.py in a follow-up.
2. # noqa: E501: Two line-length suppressions in extension_protocols.py (lines 156, 257). These are long Protocol method signatures that could be wrapped.
3. TOTAL_EXTENSION_POINTS constant: Hardcoded as 30 rather than derived from len(_EXTENSION_POINT_DEFS). Tests will catch drift, but deriving it would be more robust.

These are housekeeping items that don't affect correctness or spec alignment. They can be addressed in a follow-up cleanup ticket.

## Code Review — PR #1217: feat(plugin): register spec-defined extension points in PluginManager ### ✅ APPROVED **Reviewed**: Full diff (7 files, 1738 additions), linked issue #939, specification alignment, test coverage, code quality. --- ### Specification Alignment ✅ All 30 spec-defined extension points are registered with correct names, categories, and counts: - Context (12): strategy, 10 pipeline components, storage_backend - Output (3), Validation (2), Tools (2), Skills (2), Resources (2), A2A (2), Events (2), Config (2), Safety (1) The extension point names, Protocol interfaces, and category groupings match the specification's Extension Points Summary. ### Architecture & Design ✅ - **`ExtensionPointRegistrar` protocol** in `extension_catalog.py` — good use of structural typing to decouple the catalog from `PluginManager`. - **Lazy wiring** in `container.py` — extension points registered after container creation, before lazy providers are resolved. Correct ordering. - **ACMSPipeline integration** — clean optional `plugin_manager` parameter with discovery-only behavior (no auto-activation). Follows the spec's "wired on demand" pattern. - **Idempotent registration** — `register_extension_point` uses dict keyed by name, so re-registration is safe. ### Protocol Design ✅ - All 21 `@runtime_checkable` Protocol classes use `collections.abc.Mapping`/`Sequence` for parameter types — good for structural typing compatibility. - Each protocol has a descriptive name property and meaningful method signatures. - `ALL_EXTENSION_PROTOCOLS` dict provides programmatic access for introspection. ### Test Quality ✅ - 38 Behave scenarios covering: registration, lookup by name, lookup by category, protocol type correctness, entry point discovery, ACMSPipeline wiring, runtime-checkable verification, idempotency, registry_key consistency, and protocol conformance for all 21 protocol types. - Tests verify both positive and negative cases (non-existent lookup returns None, no plugins by default). - Stub implementations exercise actual protocol methods, not just isinstance checks. ### Minor Observations (non-blocking) 1. **Step file size**: `plugin_extension_points_steps.py` is 787 lines (project guideline: <500). The 21 stub classes account for ~350 lines. Consider extracting stubs to `features/mocks/plugin_extension_stubs.py` in a follow-up. 2. **`# noqa: E501`**: Two line-length suppressions in `extension_protocols.py` (lines 156, 257). These are long Protocol method signatures that could be wrapped. 3. **`TOTAL_EXTENSION_POINTS` constant**: Hardcoded as `30` rather than derived from `len(_EXTENSION_POINT_DEFS)`. Tests will catch drift, but deriving it would be more robust. These are housekeeping items that don't affect correctness or spec alignment. They can be addressed in a follow-up cleanup ticket.

freemo referenced this pull request 2026-04-02 08:13:07 +00:00

feat(plugin): register spec-defined extension points in PluginManager #939

freemo commented 2026-04-02 16:47:55 +00:00

Owner

Copy Link

Copy Source

Review claimed by reviewer pool instance reviewer-pool-1. Dispatching independent code review.

Review claimed by reviewer pool instance reviewer-pool-1. Dispatching independent code review.

freemo approved these changes 2026-04-02 16:51:05 +00:00

Dismissed

freemo left a comment

Owner

Copy Link

Copy Source

Independent Code Review — PR #1217: feat(plugin): register spec-defined extension points in PluginManager

✅ APPROVED (Second Independent Review)

Reviewed: Full diff (7 files, 1738 additions), linked issue #939, specification alignment, type safety, test quality, correctness, API consistency.

---

Specification Alignment ✅

All 30 spec-defined extension points are correctly registered with proper names, categories, and Protocol interfaces:

• Context (12): strategy, 10 pipeline components, storage_backend
• Output (3): renderer, materializer, format
• Validation (2): runner, rule_provider
• Tools (2): provider, middleware
• Skills (2): provider, template
• Resources (2): resolver, type_handler
• A2A (2): transport, extension_method
• Events (2): handler, filter
• Config (2): source, validator
• Safety (1): guardrail

Extension point names and category groupings match the specification's Extension Points Summary.

Architecture & Design ✅

• ExtensionPointRegistrar Protocol in extension_catalog.py — structural typing decouples the catalog from PluginManager. Good design.
• _ExtensionPointDef internal descriptor with __slots__ — efficient and clean.
• _category_from_name() helper — simple, correct, well-documented with doctest examples.
• Lazy wiring in container.py — extension points registered after container creation with graceful degradation (try/except with warning log). Correct ordering.
• ACMSPipeline integration — clean optional plugin_manager parameter with discovery-only behavior (no auto-activation). Follows the spec's "wired on demand" pattern.
• TYPE_CHECKING import for PluginManager in acms_service.py — correctly avoids circular imports.

Type Safety ✅

• All 21 @runtime_checkable Protocol classes use collections.abc.Mapping/Sequence for parameter types — good structural typing.
• All functions have explicit type annotations (parameters and return types).
• No # type: ignore suppressions anywhere.
• ExtensionPoint Pydantic model uses ConfigDict(frozen=True, arbitrary_types_allowed=True) — correct for storing type references.

Test Quality ✅

• 38 Behave scenarios covering: registration, lookup by name, lookup by category, protocol type correctness, entry point discovery, ACMSPipeline wiring, runtime-checkable verification, idempotency, registry_key consistency, and protocol conformance for all 21 protocol types.
• Tests verify both positive and negative cases (non-existent lookup returns None, no plugins by default).
• Stub implementations exercise actual protocol methods, not just isinstance checks.
• Feature file is well-structured with clear section headers.

Correctness ✅

• register_all_extension_points() returns count and iterates all 30 definitions — correct.
• get_extension_points_by_category() uses setdefault pattern — correct.
• context_extension_points property filters by startswith("context.") — correct.
• Idempotent registration works because _extension_points is a dict keyed by name.

Commit Message ✅

• Follows Conventional Changelog format: feat(plugin): register spec-defined extension points in PluginManager
• Has ISSUES CLOSED: #939 footer
• Descriptive body explaining all changes

PR Metadata ✅

• Type/Feature label ✅
• Milestone v3.6.0 ✅
• Closes #939 in body ✅
• Single commit on branch ✅

Observations (non-blocking, follow-up items)

1. Step file size: plugin_extension_points_steps.py is 787 lines (project guideline: <500). The 21 stub classes account for ~350 lines. Recommend extracting stubs to features/mocks/plugin_extension_stubs.py in a follow-up ticket.
2. TOTAL_EXTENSION_POINTS constant: Hardcoded as 30 rather than derived from len(_EXTENSION_POINT_DEFS). Tests will catch drift, but deriving it would be more robust.
3. Two # noqa: E501 in extension_protocols.py: These are linting suppressions for long Protocol method signatures, not type suppressions. Acceptable per project rules.

These are housekeeping items that don't affect correctness, spec alignment, or type safety.

## Independent Code Review — PR #1217: feat(plugin): register spec-defined extension points in PluginManager ### ✅ APPROVED (Second Independent Review) **Reviewed**: Full diff (7 files, 1738 additions), linked issue #939, specification alignment, type safety, test quality, correctness, API consistency. --- ### Specification Alignment ✅ All 30 spec-defined extension points are correctly registered with proper names, categories, and Protocol interfaces: - Context (12): strategy, 10 pipeline components, storage_backend - Output (3): renderer, materializer, format - Validation (2): runner, rule_provider - Tools (2): provider, middleware - Skills (2): provider, template - Resources (2): resolver, type_handler - A2A (2): transport, extension_method - Events (2): handler, filter - Config (2): source, validator - Safety (1): guardrail Extension point names and category groupings match the specification's Extension Points Summary. ### Architecture & Design ✅ - **`ExtensionPointRegistrar` Protocol** in `extension_catalog.py` — structural typing decouples the catalog from `PluginManager`. Good design. - **`_ExtensionPointDef`** internal descriptor with `__slots__` — efficient and clean. - **`_category_from_name()`** helper — simple, correct, well-documented with doctest examples. - **Lazy wiring** in `container.py` — extension points registered after container creation with graceful degradation (try/except with warning log). Correct ordering. - **ACMSPipeline integration** — clean optional `plugin_manager` parameter with discovery-only behavior (no auto-activation). Follows the spec's "wired on demand" pattern. - **TYPE_CHECKING import** for `PluginManager` in `acms_service.py` — correctly avoids circular imports. ### Type Safety ✅ - All 21 `@runtime_checkable` Protocol classes use `collections.abc.Mapping`/`Sequence` for parameter types — good structural typing. - All functions have explicit type annotations (parameters and return types). - No `# type: ignore` suppressions anywhere. - `ExtensionPoint` Pydantic model uses `ConfigDict(frozen=True, arbitrary_types_allowed=True)` — correct for storing type references. ### Test Quality ✅ - 38 Behave scenarios covering: registration, lookup by name, lookup by category, protocol type correctness, entry point discovery, ACMSPipeline wiring, runtime-checkable verification, idempotency, registry_key consistency, and protocol conformance for all 21 protocol types. - Tests verify both positive and negative cases (non-existent lookup returns None, no plugins by default). - Stub implementations exercise actual protocol methods, not just isinstance checks. - Feature file is well-structured with clear section headers. ### Correctness ✅ - `register_all_extension_points()` returns count and iterates all 30 definitions — correct. - `get_extension_points_by_category()` uses `setdefault` pattern — correct. - `context_extension_points` property filters by `startswith("context.")` — correct. - Idempotent registration works because `_extension_points` is a dict keyed by name. ### Commit Message ✅ - Follows Conventional Changelog format: `feat(plugin): register spec-defined extension points in PluginManager` - Has `ISSUES CLOSED: #939` footer - Descriptive body explaining all changes ### PR Metadata ✅ - `Type/Feature` label ✅ - Milestone v3.6.0 ✅ - `Closes #939` in body ✅ - Single commit on branch ✅ ### Observations (non-blocking, follow-up items) 1. **Step file size**: `plugin_extension_points_steps.py` is 787 lines (project guideline: <500). The 21 stub classes account for ~350 lines. Recommend extracting stubs to `features/mocks/plugin_extension_stubs.py` in a follow-up ticket. 2. **`TOTAL_EXTENSION_POINTS` constant**: Hardcoded as `30` rather than derived from `len(_EXTENSION_POINT_DEFS)`. Tests will catch drift, but deriving it would be more robust. 3. **Two `# noqa: E501`** in `extension_protocols.py`: These are linting suppressions for long Protocol method signatures, not type suppressions. Acceptable per project rules. These are housekeeping items that don't affect correctness, spec alignment, or type safety.

freemo scheduled this pull request to auto merge when all checks succeed 2026-04-02 16:51:13 +00:00

freemo referenced this pull request 2026-04-02 16:51:26 +00:00

feat(plugin): register spec-defined extension points in PluginManager #939

freemo referenced this pull request 2026-04-02 17:11:30 +00:00

[Automated] Product Build Session State #1314

freemo commented 2026-04-02 17:34:24 +00:00

Owner

Copy Link

Copy Source

Review claimed by reviewer pool instance reviewer-pool-2. Dispatching independent code review.

Review claimed by reviewer pool instance reviewer-pool-2. Dispatching independent code review.

freemo commented 2026-04-02 17:37:43 +00:00

Owner

Copy Link

Copy Source

Review claimed by reviewer pool instance reviewer-pool-1. Dispatching independent code review.

Review claimed by reviewer pool instance reviewer-pool-1. Dispatching independent code review.

freemo approved these changes 2026-04-02 17:39:58 +00:00

Dismissed

freemo left a comment

Owner

Copy Link

Copy Source

Independent Code Review — PR #1217: feat(plugin): register spec-defined extension points in PluginManager

✅ APPROVED (Third Independent Review)

Reviewed: Full diff (7 files, 1738 additions), linked issue #939, specification alignment, type safety, test quality, correctness, API consistency, security.

---

Specification Alignment ✅

All 30 spec-defined extension points are correctly registered with proper names, categories, and Protocol interfaces matching the specification's Extension Points Summary:

• Context (12): strategy, 10 pipeline components, storage_backend
• Output (3): renderer, materializer, format
• Validation (2): runner, rule_provider
• Tools (2): provider, middleware
• Skills (2): provider, template
• Resources (2): resolver, type_handler
• A2A (2): transport, extension_method
• Events (2): handler, filter
• Config (2): source, validator
• Safety (1): guardrail

Architecture & Design ✅

• ExtensionPointRegistrar Protocol — structural typing decouples the catalog from PluginManager. Clean design.
• _ExtensionPointDef with __slots__ — efficient internal descriptor.
• _category_from_name() — simple, correct, well-documented.
• Lazy wiring in container.py — graceful degradation with try/except and warning log. Correct ordering.
• ACMSPipeline integration — optional plugin_manager parameter with discovery-only behavior (no auto-activation). Follows spec's "wired on demand" pattern.
• TYPE_CHECKING import for PluginManager in acms_service.py — correctly avoids circular imports.

Type Safety ✅

• All 21 @runtime_checkable Protocol classes use collections.abc.Mapping/Sequence for parameter types.
• All functions have explicit type annotations (parameters and return types).
• No # type: ignore suppressions anywhere.
• Two # noqa: E501 are linting suppressions for long Protocol method signatures, not type suppressions — acceptable.

Test Quality ✅

• 38 Behave scenarios covering: registration, lookup by name, lookup by category, protocol type correctness, entry point discovery, ACMSPipeline wiring, runtime-checkable verification, idempotency, registry_key consistency, and protocol conformance for all 21 protocol types.
• Both positive and negative cases tested (non-existent lookup returns None, no plugins by default).
• Stub implementations exercise actual protocol methods, not just isinstance checks.
• Feature file is well-structured with clear section headers.

Correctness ✅

• register_all_extension_points() iterates all 30 definitions and returns count — correct.
• get_extension_points_by_category() uses setdefault pattern — correct.
• context_extension_points property filters by startswith("context.") — correct.
• Idempotent registration works because _extension_points is a dict keyed by name.
• Container wiring has graceful degradation with structured logging.

Commit Message & PR Metadata ✅

• Conventional Changelog format: feat(plugin): register spec-defined extension points in PluginManager
• ISSUES CLOSED: #939 footer
• Type/Feature label, Milestone v3.6.0, Closes #939 in body
• Single commit on branch

Security ✅

• No secrets or credentials in code.
• No user input handling or injection surfaces.

Non-blocking Observations (follow-up items)

1. Step file size: plugin_extension_points_steps.py is 787 lines (guideline: <500). The 21 stub classes account for ~350 lines. Recommend extracting stubs to features/mocks/plugin_extension_stubs.py in a follow-up.
2. TOTAL_EXTENSION_POINTS: Hardcoded as 30 rather than derived from len(_EXTENSION_POINT_DEFS). Tests catch drift, but deriving would be more robust.

These are housekeeping items that don't affect correctness, spec alignment, or type safety.

## Independent Code Review — PR #1217: feat(plugin): register spec-defined extension points in PluginManager ### ✅ APPROVED (Third Independent Review) **Reviewed**: Full diff (7 files, 1738 additions), linked issue #939, specification alignment, type safety, test quality, correctness, API consistency, security. --- ### Specification Alignment ✅ All 30 spec-defined extension points are correctly registered with proper names, categories, and Protocol interfaces matching the specification's Extension Points Summary: - Context (12): strategy, 10 pipeline components, storage_backend - Output (3): renderer, materializer, format - Validation (2): runner, rule_provider - Tools (2): provider, middleware - Skills (2): provider, template - Resources (2): resolver, type_handler - A2A (2): transport, extension_method - Events (2): handler, filter - Config (2): source, validator - Safety (1): guardrail ### Architecture & Design ✅ - **`ExtensionPointRegistrar` Protocol** — structural typing decouples the catalog from `PluginManager`. Clean design. - **`_ExtensionPointDef`** with `__slots__` — efficient internal descriptor. - **`_category_from_name()`** — simple, correct, well-documented. - **Lazy wiring** in `container.py` — graceful degradation with try/except and warning log. Correct ordering. - **ACMSPipeline integration** — optional `plugin_manager` parameter with discovery-only behavior (no auto-activation). Follows spec's "wired on demand" pattern. - **`TYPE_CHECKING` import** for `PluginManager` in `acms_service.py` — correctly avoids circular imports. ### Type Safety ✅ - All 21 `@runtime_checkable` Protocol classes use `collections.abc.Mapping`/`Sequence` for parameter types. - All functions have explicit type annotations (parameters and return types). - No `# type: ignore` suppressions anywhere. - Two `# noqa: E501` are linting suppressions for long Protocol method signatures, not type suppressions — acceptable. ### Test Quality ✅ - 38 Behave scenarios covering: registration, lookup by name, lookup by category, protocol type correctness, entry point discovery, ACMSPipeline wiring, runtime-checkable verification, idempotency, registry_key consistency, and protocol conformance for all 21 protocol types. - Both positive and negative cases tested (non-existent lookup returns None, no plugins by default). - Stub implementations exercise actual protocol methods, not just isinstance checks. - Feature file is well-structured with clear section headers. ### Correctness ✅ - `register_all_extension_points()` iterates all 30 definitions and returns count — correct. - `get_extension_points_by_category()` uses `setdefault` pattern — correct. - `context_extension_points` property filters by `startswith("context.")` — correct. - Idempotent registration works because `_extension_points` is a dict keyed by name. - Container wiring has graceful degradation with structured logging. ### Commit Message & PR Metadata ✅ - Conventional Changelog format: `feat(plugin): register spec-defined extension points in PluginManager` - `ISSUES CLOSED: #939` footer - `Type/Feature` label, Milestone v3.6.0, `Closes #939` in body - Single commit on branch ### Security ✅ - No secrets or credentials in code. - No user input handling or injection surfaces. ### Non-blocking Observations (follow-up items) 1. **Step file size**: `plugin_extension_points_steps.py` is 787 lines (guideline: <500). The 21 stub classes account for ~350 lines. Recommend extracting stubs to `features/mocks/plugin_extension_stubs.py` in a follow-up. 2. **`TOTAL_EXTENSION_POINTS`**: Hardcoded as `30` rather than derived from `len(_EXTENSION_POINT_DEFS)`. Tests catch drift, but deriving would be more robust. These are housekeeping items that don't affect correctness, spec alignment, or type safety.

freemo merged commit bcf54d08c9 into master 2026-04-02 17:40:19 +00:00

freemo deleted branch feature/plugin-extension-points 2026-04-02 17:40:19 +00:00

freemo referenced this issue from a commit 2026-04-02 17:40:20 +00:00

Merge pull request 'feat(plugin): register spec-defined extension points in PluginManager' (#1217) from feature/plugin-extension-points into master

freemo referenced this pull request 2026-04-02 17:40:38 +00:00

feat(plugin): register spec-defined extension points in PluginManager #939

freemo approved these changes 2026-04-02 17:44:37 +00:00

freemo left a comment

Owner

Copy Link

Copy Source

Independent Code Review — PR #1217: feat(plugin): register spec-defined extension points in PluginManager

✅ APPROVED (Fourth Independent Review)

Reviewed: Full diff (7 files, ~1738 additions), linked issue #939, specification alignment, type safety, test quality, correctness, API consistency, security.

---

Specification Alignment ✅

All 30 spec-defined extension points are correctly registered with proper names, categories, and Protocol interfaces matching the specification's Extension Points Summary:

• Context (12): strategy, 10 pipeline components, storage_backend
• Output (3): renderer, materializer, format
• Validation (2): runner, rule_provider
• Tools (2): provider, middleware
• Skills (2): provider, template
• Resources (2): resolver, type_handler
• A2A (2): transport, extension_method
• Events (2): handler, filter
• Config (2): source, validator
• Safety (1): guardrail

Architecture & Design ✅

• ExtensionPointRegistrar Protocol in extension_catalog.py — structural typing decouples the catalog from PluginManager. Clean, SOLID-compliant design.
• _ExtensionPointDef with __slots__ — efficient internal descriptor, not exposed in public API.
• _category_from_name() — simple, correct, well-documented with doctest examples.
• Lazy wiring in container — graceful degradation with try/except and warning log. Correct ordering.
• ACMSPipeline integration — optional plugin_manager parameter with discovery-only behavior (no auto-activation). Follows spec's "wired on demand" pattern.
• TYPE_CHECKING import for PluginManager in acms_service.py — correctly avoids circular imports.

Type Safety ✅

• All 21 @runtime_checkable Protocol classes use collections.abc.Mapping/Sequence for parameter types — good structural typing.
• All functions have explicit type annotations (parameters and return types).
• No # type: ignore suppressions introduced by this PR. (Pre-existing # type: ignore[dict-item] on BUILTIN_STRATEGIES is not part of this change.)
• Two # noqa: E501 are linting suppressions for long Protocol method signatures, not type suppressions — acceptable per project rules.

Test Quality ✅

• 38 Behave scenarios covering: registration, lookup by name, lookup by category, protocol type correctness, entry point discovery, ACMSPipeline wiring, runtime-checkable verification, idempotency, registry_key consistency, and protocol conformance for all 21 protocol types.
• Both positive and negative cases tested (non-existent lookup returns None, no plugins by default).
• Stub implementations exercise actual protocol methods, not just isinstance checks.
• Feature file is well-structured with clear section headers.

Correctness ✅

• register_all_extension_points() iterates all 30 definitions and returns count — correct.
• get_extension_points_by_category() uses setdefault pattern — correct.
• context_extension_points property filters by startswith("context.") — correct.
• Idempotent registration works because _extension_points is a dict keyed by name.
• Container wiring has graceful degradation with structured logging.

Commit Message & PR Metadata ✅

• Conventional Changelog format: feat(plugin): register spec-defined extension points in PluginManager
• ISSUES CLOSED: #939 footer
• Type/Feature label, Milestone v3.6.0, Closes #939 in body
• Single commit on branch

Security ✅

• No secrets or credentials in code.
• No user input handling or injection surfaces.

Non-blocking Observations (follow-up items)

1. Step file size: plugin_extension_points_steps.py is ~787 lines (guideline: <500). The 21 stub classes account for ~350 lines. Recommend extracting stubs to features/mocks/plugin_extension_stubs.py in a follow-up ticket.
2. TOTAL_EXTENSION_POINTS: Hardcoded as 30 rather than derived from len(_EXTENSION_POINT_DEFS). Tests catch drift, but deriving would be more robust.

These are housekeeping items that don't affect correctness, spec alignment, or type safety.

## Independent Code Review — PR #1217: feat(plugin): register spec-defined extension points in PluginManager ### ✅ APPROVED (Fourth Independent Review) **Reviewed**: Full diff (7 files, ~1738 additions), linked issue #939, specification alignment, type safety, test quality, correctness, API consistency, security. --- ### Specification Alignment ✅ All 30 spec-defined extension points are correctly registered with proper names, categories, and Protocol interfaces matching the specification's Extension Points Summary: - Context (12): strategy, 10 pipeline components, storage_backend - Output (3): renderer, materializer, format - Validation (2): runner, rule_provider - Tools (2): provider, middleware - Skills (2): provider, template - Resources (2): resolver, type_handler - A2A (2): transport, extension_method - Events (2): handler, filter - Config (2): source, validator - Safety (1): guardrail ### Architecture & Design ✅ - **`ExtensionPointRegistrar` Protocol** in `extension_catalog.py` — structural typing decouples the catalog from `PluginManager`. Clean, SOLID-compliant design. - **`_ExtensionPointDef`** with `__slots__` — efficient internal descriptor, not exposed in public API. - **`_category_from_name()`** — simple, correct, well-documented with doctest examples. - **Lazy wiring** in container — graceful degradation with try/except and warning log. Correct ordering. - **ACMSPipeline integration** — optional `plugin_manager` parameter with discovery-only behavior (no auto-activation). Follows spec's "wired on demand" pattern. - **`TYPE_CHECKING` import** for `PluginManager` in `acms_service.py` — correctly avoids circular imports. ### Type Safety ✅ - All 21 `@runtime_checkable` Protocol classes use `collections.abc.Mapping`/`Sequence` for parameter types — good structural typing. - All functions have explicit type annotations (parameters and return types). - No `# type: ignore` suppressions introduced by this PR. (Pre-existing `# type: ignore[dict-item]` on `BUILTIN_STRATEGIES` is not part of this change.) - Two `# noqa: E501` are linting suppressions for long Protocol method signatures, not type suppressions — acceptable per project rules. ### Test Quality ✅ - 38 Behave scenarios covering: registration, lookup by name, lookup by category, protocol type correctness, entry point discovery, ACMSPipeline wiring, runtime-checkable verification, idempotency, registry_key consistency, and protocol conformance for all 21 protocol types. - Both positive and negative cases tested (non-existent lookup returns None, no plugins by default). - Stub implementations exercise actual protocol methods, not just isinstance checks. - Feature file is well-structured with clear section headers. ### Correctness ✅ - `register_all_extension_points()` iterates all 30 definitions and returns count — correct. - `get_extension_points_by_category()` uses `setdefault` pattern — correct. - `context_extension_points` property filters by `startswith("context.")` — correct. - Idempotent registration works because `_extension_points` is a dict keyed by name. - Container wiring has graceful degradation with structured logging. ### Commit Message & PR Metadata ✅ - Conventional Changelog format: `feat(plugin): register spec-defined extension points in PluginManager` - `ISSUES CLOSED: #939` footer - `Type/Feature` label, Milestone v3.6.0, `Closes #939` in body - Single commit on branch ### Security ✅ - No secrets or credentials in code. - No user input handling or injection surfaces. ### Non-blocking Observations (follow-up items) 1. **Step file size**: `plugin_extension_points_steps.py` is ~787 lines (guideline: <500). The 21 stub classes account for ~350 lines. Recommend extracting stubs to `features/mocks/plugin_extension_stubs.py` in a follow-up ticket. 2. **`TOTAL_EXTENSION_POINTS`**: Hardcoded as `30` rather than derived from `len(_EXTENSION_POINT_DEFS)`. Tests catch drift, but deriving would be more robust. These are housekeeping items that don't affect correctness, spec alignment, or type safety.

freemo referenced this pull request 2026-04-02 17:45:12 +00:00

feat(plugin): register spec-defined extension points in PluginManager #939

Sign in to join this conversation.

Reviewers

No Reviewers

freemo

Labels

Clear labels

auto/needs-reevaluation

Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

controller-managed

Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

overdue

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

auto/claimed-implementer

Currently being processed by an implementer worker.

auto/claimed-merge

Currently being processed by the merge driver.

auto/claimed-reviewer

Currently being processed by a reviewer worker.

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

auto/needs-implementer

Failing CI needs implementer attention.

auto/postmortem

Documenting a driver incident or rollback.

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

Points

1

1 man-hours worth of work for an expert with no learning curve.

Points

13

13 man-hours worth of work for an expert with no learning curve.

Points

2

2 man-hours worth of work for an expert with no learning curve.

Points

21

21 man-hours worth of work for an expert with no learning curve.

Points

3

3 man-hours worth of work for an expert with no learning curve.

Points

34

34 man-hours worth of work for an expert with no learning curve.

Points

5

5 man-hours worth of work for an expert with no learning curve.

Points

55

55 man-hours worth of work for an expert with no learning curve.

Points

8

8 man-hours worth of work for an expert with no learning curve.

Points

88

88 man-hours worth of work for an expert with no learning curve.

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

Priority

Critical

The priority is critical

Priority

High

The priority is high

Priority

Low

The priority is low

Priority

Medium

The priority is medium

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

State

Duplicate

A ticket that represents the same content as an existing ticket.

State

In Progress

A ticket that is actively being developed.

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

Type

Automation

Any edits or discussion about the AI automated coding system.

Type

Bug

Something that doesnt work as intended.

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

Type

Documentation

An error or improvement needed in the documentation.

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

Type

Feature

Some new functionality not present.

Type

Legendary

A type of Epic which will contain other Epics.

Type

Refactor

A code change that restructures existing code without changing its external behavior.

Type

Support

Someone needs help using the project.

Type

Task

A generic task that doesnt fit into the other type categories.

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No Label

Type

Feature

Milestone

No items

No Milestone v3.6.0

Projects

Clear projects

No project

Assignees

Clear assignees

aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents

No Assignees freemo

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: cleveragents/cleveragents-core#1217