Files
cleveragents-core/robot
HAL9000 19dc9c231f fix(invariant): neutralise legacy m3_001 migration + drop stale model fixtures
Commit f2626d66e removed the legacy ``InvariantModel`` (id/description/
is_active) and rewired ``InvariantModel`` onto the new ``id/text/scope/
source_name/active/non_overridable`` schema owned by
``m11_001_standalone_invariants``.  Two pieces of the previous design
remained behind and were breaking CI:

1. ``m3_001_invariants_table`` still issued ``op.create_table('invariants',
   ...)`` for the obsolete column set.  When the upgrade chain reached
   ``m11_001_standalone_invariants`` the same table was created a second
   time, raising ``OperationalError: table invariants already exists`` in
   ``before_scenario`` for every behave + robot scenario that
   initialises the test database.  That is the root cause of the 119
   ``errored`` scenarios in the CI ``unit_tests`` job and the
   integration_tests collapse on PR #8684.

   Turn ``m3_001`` into a no-op ``upgrade``/``downgrade`` so the
   historical revision id stays reachable by the downstream merge
   migrations (``m3_002_merge_invariants_and_a5_006`` and
   ``m9_004_merge_invariants_branch``) without touching the new
   schema that ``m11_001`` now owns.

2. ``robot/invariant_model.robot`` + ``robot/helper_invariant_model.py``
   and ``features/invariant_model.feature`` +
   ``features/steps/invariant_model_steps.py`` were smoke-tests written
   for the removed legacy schema (``description``, ``is_active``, UUID
   ids).  They instantiate ``InvariantModel(description=..., is_active=...)``
   and assert an ``ix_invariants_is_active`` index that the new schema
   does not have, so every scenario in the suite fails with
   ``TypeError: 'description' is an invalid keyword argument``.  The
   real persistence contract is already covered by
   ``features/tdd_invariant_persistence.feature``,
   ``robot/tdd_invariant_persistence.robot`` and
   ``robot/invariant_cli.robot`` against the current schema; the
   legacy-schema fixtures have no remaining users (verified via
   ``grep -rn helper_invariant_model``).  Delete them.

Also runs ``ruff format`` on ``models.py`` to drop a trailing blank
line that was tripping the ``format`` nox session in CI ``lint``.

Verified locally:

* ``ruff format --check .`` -> 2298 files already formatted.
* ``ruff check src/ scripts/ examples/ features/ robot/ .opencode/``
  -> All checks passed.
* ``nox -s unit_tests-3.13 -- features/tdd_invariant_persistence.feature``
  -> 4 scenarios passed, 0 failed, 0 errored.
* ``nox -s integration_tests-3.13 -- robot/tdd_invariant_persistence.robot
  robot/invariant_cli.robot robot/`` -> only the 8 deleted
  ``Suites.Robot.Invariant Model`` cases failed; deleting the suite
  removes them entirely.

ISSUES CLOSED: #8573
2026-06-18 11:36:35 -04:00
..
2026-06-17 23:15:50 -04:00