test(acms): TDD failing tests for context tier runtime logic (bug #821) #1058

Merged

brent.edwards merged 2 commits from tdd/m5-context-tier-runtime into master

2026-03-19 22:24:42 +00:00

brent.edwards commented

2026-03-18 20:18:01 +00:00

Member

Summary

TDD expected-fail tests proving bug #821 exists: ContextTierService has data models for hot/warm/cold tiers but no runtime logic for automatic promotion, demotion, or eviction.

Promotion on access: Accessing a cold-tier fragment repeatedly via get() does NOT auto-promote it — get() updates access_count/last_accessed but never calls promote()
Demotion on staleness: No staleness enforcement method exists — tried enforce_staleness(), apply_tier_policy(), tick(), etc. — none are implemented
Eviction on budget overflow: store() does NOT enforce TierBudget.max_tokens_hot — the hot tier grows without bound

Files Added

File	Purpose
`features/tdd_context_tier_runtime.feature`	3 Behave scenarios tagged `@tdd_expected_fail @tdd_bug @tdd_bug_821 @mock_only`
`features/steps/tdd_context_tier_runtime_steps.py`	Type-annotated step definitions exercising real `ContextTierService`
`robot/tdd_context_tier_runtime.robot`	3 Robot Framework integration tests tagged `tdd_expected_fail`
`robot/helper_tdd_context_tier_runtime.py`	Helper script for Robot tests with 3 subcommands

Verification

nox -s lint — passed
nox -s typecheck — passed (0 errors)
nox -s unit_tests -- features/tdd_context_tier_runtime.feature — 3 scenarios passed (all assertions fail as expected, @tdd_expected_fail inverts to CI pass)

ISSUES CLOSED: #840

## Summary TDD expected-fail tests proving bug #821 exists: `ContextTierService` has data models for hot/warm/cold tiers but **no runtime logic** for automatic promotion, demotion, or eviction. - **Promotion on access**: Accessing a cold-tier fragment repeatedly via `get()` does NOT auto-promote it — `get()` updates `access_count`/`last_accessed` but never calls `promote()` - **Demotion on staleness**: No staleness enforcement method exists — tried `enforce_staleness()`, `apply_tier_policy()`, `tick()`, etc. — none are implemented - **Eviction on budget overflow**: `store()` does NOT enforce `TierBudget.max_tokens_hot` — the hot tier grows without bound ### Files Added | File | Purpose | |------|---------| | `features/tdd_context_tier_runtime.feature` | 3 Behave scenarios tagged `@tdd_expected_fail @tdd_bug @tdd_bug_821 @mock_only` | | `features/steps/tdd_context_tier_runtime_steps.py` | Type-annotated step definitions exercising real `ContextTierService` | | `robot/tdd_context_tier_runtime.robot` | 3 Robot Framework integration tests tagged `tdd_expected_fail` | | `robot/helper_tdd_context_tier_runtime.py` | Helper script for Robot tests with 3 subcommands | ### Verification - `nox -s lint` — passed - `nox -s typecheck` — passed (0 errors) - `nox -s unit_tests -- features/tdd_context_tier_runtime.feature` — **3 scenarios passed** (all assertions fail as expected, `@tdd_expected_fail` inverts to CI pass) ISSUES CLOSED: #840

brent.edwards referenced this pull request

2026-03-18 20:18:50 +00:00

TDD: context tier service has no runtime promotion/demotion/eviction logic (bug #821) #840

freemo approved these changes

2026-03-19 04:56:00 +00:00

freemo left a comment

Code Review — PR #1058 `test(acms): TDD failing tests for context tier runtime logic (bug #821)`

Clean TDD test PR following the project's bug fix workflow correctly. Three scenarios (promotion on access, demotion on staleness, eviction on budget overflow) effectively prove bug #821 exists. TDD tags @tdd_expected_fail @tdd_bug @tdd_bug_821 are correctly applied.

The step definitions are thorough — the staleness scenario probes for multiple method names (enforce_staleness(), apply_tier_policy(), tick(), etc.) which clearly demonstrates the absence of any runtime enforcement method. Robot integration tests mirror the Behave scenarios for full coverage.

Approved. No issues found.

## Code Review — PR #1058 `test(acms): TDD failing tests for context tier runtime logic (bug #821)` Clean TDD test PR following the project's bug fix workflow correctly. Three scenarios (promotion on access, demotion on staleness, eviction on budget overflow) effectively prove bug #821 exists. TDD tags `@tdd_expected_fail @tdd_bug @tdd_bug_821` are correctly applied. The step definitions are thorough — the staleness scenario probes for multiple method names (`enforce_staleness()`, `apply_tier_policy()`, `tick()`, etc.) which clearly demonstrates the absence of any runtime enforcement method. Robot integration tests mirror the Behave scenarios for full coverage. **Approved.** No issues found.

Rows
Columns

test(acms): TDD failing tests for context tier runtime logic (bug #821) #1058

Summary

Files Added

Verification

Code Review — PR #1058 test(acms): TDD failing tests for context tier runtime logic (bug #821)

Code Review — PR #1058 `test(acms): TDD failing tests for context tier runtime logic (bug #821)`