fix(container): remove devcontainer-file from CONTAINER_RESOURCE_TYPES
CI / lint (push) Waiting to run
CI / typecheck (push) Waiting to run
CI / security (push) Waiting to run
CI / quality (push) Waiting to run
CI / unit_tests (push) Waiting to run
CI / integration_tests (push) Waiting to run
CI / e2e_tests (push) Waiting to run
CI / coverage (push) Blocked by required conditions
CI / build (push) Waiting to run
CI / docker (push) Blocked by required conditions
CI / helm (push) Waiting to run
CI / push-validation (push) Waiting to run
CI / status-check (push) Blocked by required conditions
CI / benchmark-publish (push) Waiting to run

devcontainer-file is a read-only config file resource, not a running
container. Including it in CONTAINER_RESOURCE_TYPES causes
validate_container_available() to return True when only a config file
is linked, even though no actual container is available.

Closes #10598
This commit was merged in pull request #10598.
This commit is contained in:
2026-04-30 05:32:56 +00:00
committed by Forgejo
parent 9632ea55dd
commit 9b9bb80e05
3 changed files with 2 additions and 3 deletions
+1 -1
View File
@@ -131,7 +131,7 @@ Feature: Execution environment routing
Given I import CONTAINER_RESOURCE_TYPES
Then it should contain "container-instance"
And it should contain "devcontainer-instance"
And it should contain "devcontainer-file"
And it should not contain "devcontainer-file"
And it should not contain "git-checkout"
# ── ContainerUnavailableError ───────────────────────────────────────
+1 -1
View File
@@ -81,7 +81,7 @@ def _run_resource_types() -> None:
"""Verify container resource types."""
assert "container-instance" in CONTAINER_RESOURCE_TYPES
assert "devcontainer-instance" in CONTAINER_RESOURCE_TYPES
assert "devcontainer-file" in CONTAINER_RESOURCE_TYPES
assert "devcontainer-file" not in CONTAINER_RESOURCE_TYPES
assert "git-checkout" not in CONTAINER_RESOURCE_TYPES
print("resource-types-ok")
@@ -55,7 +55,6 @@ CONTAINER_RESOURCE_TYPES: frozenset[str] = frozenset(
{
"container-instance",
"devcontainer-instance",
"devcontainer-file",
}
)