cleveragents/cleveragents-core

Fork 3

test(integration): workflow example 8 — cloud infrastructure management (supervised profile) #1231

Merged

freemo merged 1 commit from test/int-wf08-cloud-infra into master

2026-04-02 16:51:47 +00:00

brent.edwards commented

2026-03-31 15:08:45 +00:00

Member

Summary

Integration test for Specification Workflow Example 8: Cloud Infrastructure Management with the supervised automation profile.

Closes #772

Changes

New Files

robot/wf08_cloud_infra_supervised.robot — Robot Framework test suite (6 test cases)
robot/helper_wf08_cloud_infra_supervised.py — Python helper with 6 subcommands
robot/fixtures/wf08/terraform-state.yaml — Custom resource type definition
robot/fixtures/wf08/terraform.tfstate.json — Mock Terraform state (3 AWS resources)
robot/fixtures/wf08/cloud-metrics.json — Mock CloudWatch metrics
robot/fixtures/wf08/main.tf — Sample Terraform HCL configuration

Test Cases

Register Terraform Resource Type — Registers local/terraform-state via YAML fixture with copy_on_write sandbox strategy, validates CLI args and resource instance creation
Register Terraform Skill With Tool Composition — Creates local/terraform-ops with 3 anonymous tools and includes: [local/file-ops] skill composition
Supervised Profile Gating Behavior — Verifies create_tool=1.0 and select_tool=1.0 gate both phase transitions via should_auto_progress()
Create Infra Optimize Action With Invariants — Action with supervised profile, typed args (STRING + FLOAT), invariants propagated to plan
Infrastructure Analysis Produces Optimization Recommendations — Mocked Terraform/CloudWatch analysis produces right-sizing recommendations, skips critical resources
Invariant Enforcement Blocks Critical Resource Deletion — Invariants block modifications to critical: true resources while allowing non-critical changes

Approach

Follows established integration test patterns from wf07_cicd_integration.robot and int_wf05_db_migration.robot:

Robot → Python helper subcommand dispatch
Real service layer (PlanLifecycleService, ResourceRegistryService, SkillService, AutomationProfileService) with in-memory SQLite
Mock AI via CLEVERAGENTS_TESTING_USE_MOCK_AI environment variable
Deterministic mock Terraform operations returning fixture data

Quality Gates

All 11 nox sessions pass:

✅ lint, format, typecheck, security_scan, dead_code
✅ unit_tests (509 features, 12989 scenarios)
✅ integration_tests (1862 tests, 0 failed)
✅ e2e_tests
✅ docs, build, benchmark
✅ coverage_report (97.0% ≥ 97% threshold)

## Summary Integration test for Specification Workflow Example 8: Cloud Infrastructure Management with the **supervised** automation profile. Closes #772 ## Changes ### New Files - `robot/wf08_cloud_infra_supervised.robot` — Robot Framework test suite (6 test cases) - `robot/helper_wf08_cloud_infra_supervised.py` — Python helper with 6 subcommands - `robot/fixtures/wf08/terraform-state.yaml` — Custom resource type definition - `robot/fixtures/wf08/terraform.tfstate.json` — Mock Terraform state (3 AWS resources) - `robot/fixtures/wf08/cloud-metrics.json` — Mock CloudWatch metrics - `robot/fixtures/wf08/main.tf` — Sample Terraform HCL configuration ### Test Cases 1. **Register Terraform Resource Type** — Registers `local/terraform-state` via YAML fixture with `copy_on_write` sandbox strategy, validates CLI args and resource instance creation 2. **Register Terraform Skill With Tool Composition** — Creates `local/terraform-ops` with 3 anonymous tools and `includes: [local/file-ops]` skill composition 3. **Supervised Profile Gating Behavior** — Verifies `create_tool=1.0` and `select_tool=1.0` gate both phase transitions via `should_auto_progress()` 4. **Create Infra Optimize Action With Invariants** — Action with supervised profile, typed args (STRING + FLOAT), invariants propagated to plan 5. **Infrastructure Analysis Produces Optimization Recommendations** — Mocked Terraform/CloudWatch analysis produces right-sizing recommendations, skips critical resources 6. **Invariant Enforcement Blocks Critical Resource Deletion** — Invariants block modifications to `critical: true` resources while allowing non-critical changes ## Approach Follows established integration test patterns from `wf07_cicd_integration.robot` and `int_wf05_db_migration.robot`: - Robot → Python helper subcommand dispatch - Real service layer (PlanLifecycleService, ResourceRegistryService, SkillService, AutomationProfileService) with in-memory SQLite - Mock AI via `CLEVERAGENTS_TESTING_USE_MOCK_AI` environment variable - Deterministic mock Terraform operations returning fixture data ## Quality Gates All 11 nox sessions pass: - ✅ lint, format, typecheck, security_scan, dead_code - ✅ unit_tests (509 features, 12989 scenarios) - ✅ integration_tests (1862 tests, 0 failed) - ✅ e2e_tests - ✅ docs, build, benchmark - ✅ coverage_report (97.0% ≥ 97% threshold)

brent.edwards added 1 commit

2026-03-31 15:08:45 +00:00

test(integration): workflow example 8 — cloud infrastructure management (supervised profile)

CI / benchmark-publish (pull_request) Has been skipped

Details

CI / build (pull_request) Successful in 21s

Details

CI / helm (pull_request) Successful in 23s

Details

CI / lint (pull_request) Successful in 3m19s

Details

CI / quality (pull_request) Successful in 3m42s

Details

CI / typecheck (pull_request) Successful in 3m56s

Details

CI / security (pull_request) Successful in 4m5s

Details

CI / integration_tests (pull_request) Successful in 7m3s

Details

CI / unit_tests (pull_request) Successful in 7m5s

Details

CI / docker (pull_request) Successful in 1m44s

Details

CI / coverage (pull_request) Successful in 11m50s

Details

CI / e2e_tests (pull_request) Successful in 20m39s

Details

CI / status-check (pull_request) Successful in 1s

Details

CI / benchmark-regression (pull_request) Successful in 55m7s

Details

c3cdb7d9e1

Robot Framework integration test for Specification Workflow Example 8:
Cloud Infrastructure Management with the supervised automation profile.

Test suite exercises:
- Custom resource type registration (local/terraform-state) via YAML
  fixture with copy_on_write sandbox strategy and CLI args validation
- Custom skill creation (local/terraform-ops) with 3 anonymous tools
  (terraform_plan, terraform_show, cloud_metrics) and skill composition
  via includes (local/file-ops)
- Supervised profile gating: verifies both strategize-to-execute
  (create_tool=1.0) and execute-to-apply (select_tool=1.0) transitions
  require explicit human approval via should_auto_progress()
- Action creation with supervised profile, typed arguments (STRING,
  FLOAT), and invariant propagation to plans via InvariantSource.ACTION
- Mocked infrastructure analysis producing right-sizing recommendations
  for over-provisioned resources while skipping critical instances
- Invariant enforcement blocking modifications to resources tagged
  critical:true while allowing non-critical changes

Fixture files provide deterministic mock Terraform state (3 AWS
resources), CloudWatch metrics (CPU at 12% avg on m5.2xlarge), and
sample HCL configuration.

ISSUES CLOSED: #772

brent.edwards added this to the v3.6.0 milestone

2026-03-31 15:08:51 +00:00

brent.edwards added the

Type

Testing

label

2026-03-31 15:08:56 +00:00

freemo approved these changes

2026-04-02 04:21:36 +00:00

Dismissed

freemo left a comment

Review: APPROVED ✅

PR #1231 — test(integration): workflow example 8 — cloud infrastructure management (supervised profile)

What was reviewed

robot/wf08_cloud_infra_supervised.robot — 6 Robot Framework test cases
robot/helper_wf08_cloud_infra_supervised.py — Python helper with 6 subcommands (672 lines)
robot/fixtures/wf08/terraform-state.yaml — Custom resource type definition
robot/fixtures/wf08/terraform.tfstate.json — Mock Terraform state (3 AWS resources)
robot/fixtures/wf08/cloud-metrics.json — Mock CloudWatch metrics
robot/fixtures/wf08/main.tf — Sample Terraform HCL configuration

Assessment

Spec alignment: ✅ Tests map to Specification Workflow Example 8 (cloud infrastructure management)
Test quality: ✅ Comprehensive
- Custom resource type registration (local/terraform-state) with YAML fixture
- Skill registration with tool composition (3 anonymous tools + includes)
- Supervised profile gating at both transitions (strategize→execute AND execute→apply)
- Action with typed args (STRING + FLOAT) and invariant propagation
- Mocked infrastructure analysis with deterministic Terraform/CloudWatch fixtures
- Invariant enforcement: critical resources blocked, non-critical allowed
Code quality: ✅
- Follows established integration test patterns
- Deterministic mock operations using fixture files
- Proper typing throughout
- No # type: ignore suppressions
- Command dispatch consistent with other helpers
Fixtures: ✅ Well-structured JSON/YAML with realistic data
Quality gates: All 11 nox sessions pass (97% coverage)

Thorough integration test suite with excellent fixture design for deterministic testing.

## Review: APPROVED ✅ **PR #1231 — test(integration): workflow example 8 — cloud infrastructure management (supervised profile)** ### What was reviewed - `robot/wf08_cloud_infra_supervised.robot` — 6 Robot Framework test cases - `robot/helper_wf08_cloud_infra_supervised.py` — Python helper with 6 subcommands (672 lines) - `robot/fixtures/wf08/terraform-state.yaml` — Custom resource type definition - `robot/fixtures/wf08/terraform.tfstate.json` — Mock Terraform state (3 AWS resources) - `robot/fixtures/wf08/cloud-metrics.json` — Mock CloudWatch metrics - `robot/fixtures/wf08/main.tf` — Sample Terraform HCL configuration ### Assessment - **Spec alignment**: ✅ Tests map to Specification Workflow Example 8 (cloud infrastructure management) - **Test quality**: ✅ Comprehensive - Custom resource type registration (local/terraform-state) with YAML fixture - Skill registration with tool composition (3 anonymous tools + includes) - Supervised profile gating at both transitions (strategize→execute AND execute→apply) - Action with typed args (STRING + FLOAT) and invariant propagation - Mocked infrastructure analysis with deterministic Terraform/CloudWatch fixtures - Invariant enforcement: critical resources blocked, non-critical allowed - **Code quality**: ✅ - Follows established integration test patterns - Deterministic mock operations using fixture files - Proper typing throughout - No `# type: ignore` suppressions - Command dispatch consistent with other helpers - **Fixtures**: ✅ Well-structured JSON/YAML with realistic data - **Quality gates**: All 11 nox sessions pass (97% coverage) Thorough integration test suite with excellent fixture design for deterministic testing.

freemo referenced this pull request

2026-04-02 04:22:07 +00:00

test(integration): workflow example 8 — cloud infrastructure management (supervised profile) #772

freemo referenced this pull request

2026-04-02 04:25:14 +00:00

[Automated] Product Build Session State #1259

freemo self-assigned this

2026-04-02 06:15:12 +00:00

freemo commented

2026-04-02 08:03:12 +00:00

Owner

🔒 Claimed by pr-reviewer-3. Starting independent code review.

freemo approved these changes

2026-04-02 08:16:13 +00:00

Dismissed

freemo left a comment

✅ Code Review — APPROVED

Review Summary

Independent review of integration test for Workflow Example 8: Cloud Infrastructure Management (supervised profile).

What Was Reviewed

6 new files (951 lines):

robot/wf08_cloud_infra_supervised.robot — Robot Framework test suite (6 test cases)
robot/helper_wf08_cloud_infra_supervised.py — Python helper with 6 subcommands
robot/fixtures/wf08/terraform-state.yaml — Custom resource type definition
robot/fixtures/wf08/terraform.tfstate.json — Mock Terraform state (3 AWS resources)
robot/fixtures/wf08/cloud-metrics.json — Mock CloudWatch metrics
robot/fixtures/wf08/main.tf — Sample Terraform HCL configuration

Criteria Assessment

Criteria	Status	Notes
Spec alignment	✅	Tests custom resource types, skill composition, supervised profile, invariants — all per spec Example 8
Test quality	✅	6 meaningful test cases covering resource registration, skill composition, profile gating, action creation, analysis, and invariant enforcement
Correctness	✅	Assertions are thorough with descriptive messages; both positive and negative cases tested
Code quality	✅	Clean structure, proper type hints, descriptive docstrings, follows established wf05/wf07 patterns
API consistency	✅	Uses same Robot→Python helper dispatch pattern as existing workflow tests
Security	✅	No secrets, no credentials, fixture data is clearly mock/test data
Commit format	✅	Single atomic commit, Conventional Changelog format, ISSUES CLOSED footer
PR metadata	✅	Closes #772, Type/Testing label, v3.6.0 milestone

Key Observations

PlanLifecycleService is correctly used without unit_of_work, falling back to in-memory storage — no database isolation needed (consistent with int_wf05_db_migration.robot pattern).
Supervised profile gating is properly verified: create_tool=1.0 and select_tool=1.0 both gate should_auto_progress() to False.
Invariant enforcement test correctly verifies both that critical resources are blocked and non-critical resources are allowed.
Fixture files are well-structured and realistic (Terraform state v4 format, CloudWatch-style metrics).
Helper file is 672 lines — within established norms (existing helpers range up to 769 lines).

No blocking issues found.

## ✅ Code Review — APPROVED ### Review Summary Independent review of integration test for Workflow Example 8: Cloud Infrastructure Management (supervised profile). ### What Was Reviewed **6 new files (951 lines):** - `robot/wf08_cloud_infra_supervised.robot` — Robot Framework test suite (6 test cases) - `robot/helper_wf08_cloud_infra_supervised.py` — Python helper with 6 subcommands - `robot/fixtures/wf08/terraform-state.yaml` — Custom resource type definition - `robot/fixtures/wf08/terraform.tfstate.json` — Mock Terraform state (3 AWS resources) - `robot/fixtures/wf08/cloud-metrics.json` — Mock CloudWatch metrics - `robot/fixtures/wf08/main.tf` — Sample Terraform HCL configuration ### Criteria Assessment | Criteria | Status | Notes | |----------|--------|-------| | Spec alignment | ✅ | Tests custom resource types, skill composition, supervised profile, invariants — all per spec Example 8 | | Test quality | ✅ | 6 meaningful test cases covering resource registration, skill composition, profile gating, action creation, analysis, and invariant enforcement | | Correctness | ✅ | Assertions are thorough with descriptive messages; both positive and negative cases tested | | Code quality | ✅ | Clean structure, proper type hints, descriptive docstrings, follows established wf05/wf07 patterns | | API consistency | ✅ | Uses same Robot→Python helper dispatch pattern as existing workflow tests | | Security | ✅ | No secrets, no credentials, fixture data is clearly mock/test data | | Commit format | ✅ | Single atomic commit, Conventional Changelog format, ISSUES CLOSED footer | | PR metadata | ✅ | Closes #772, Type/Testing label, v3.6.0 milestone | ### Key Observations 1. **PlanLifecycleService** is correctly used without `unit_of_work`, falling back to in-memory storage — no database isolation needed (consistent with `int_wf05_db_migration.robot` pattern). 2. **Supervised profile gating** is properly verified: `create_tool=1.0` and `select_tool=1.0` both gate `should_auto_progress()` to `False`. 3. **Invariant enforcement** test correctly verifies both that critical resources are blocked and non-critical resources are allowed. 4. **Fixture files** are well-structured and realistic (Terraform state v4 format, CloudWatch-style metrics). 5. Helper file is 672 lines — within established norms (existing helpers range up to 769 lines). No blocking issues found.

freemo referenced this pull request

2026-04-02 08:16:42 +00:00

test(integration): workflow example 8 — cloud infrastructure management (supervised profile) #772

freemo commented

2026-04-02 16:48:03 +00:00

Owner

Review claimed by reviewer pool instance reviewer-pool-1. Dispatching independent code review.

freemo approved these changes

2026-04-02 16:51:32 +00:00

freemo left a comment

✅ Independent Code Review — APPROVED

Reviewer: reviewer-pool-1 (independent review)

Scope of Review

All 6 new files (~951 lines total):

robot/wf08_cloud_infra_supervised.robot — 6 Robot Framework test cases
robot/helper_wf08_cloud_infra_supervised.py — Python helper with 6 subcommands
robot/fixtures/wf08/terraform-state.yaml — Custom resource type definition
robot/fixtures/wf08/terraform.tfstate.json — Mock Terraform state (3 AWS resources)
robot/fixtures/wf08/cloud-metrics.json — Mock CloudWatch metrics
robot/fixtures/wf08/main.tf — Sample Terraform HCL configuration

Assessment

Criteria	Status	Notes
Spec alignment	✅	Tests map to Specification Workflow Example 8 — custom resource types (`local/terraform-state`), skill composition (`local/terraform-ops` with 3 tools + includes), supervised profile gating, invariant propagation and enforcement
Test quality	✅	6 meaningful test cases with thorough assertions and descriptive error messages. Both positive paths (non-critical allowed) and negative paths (critical blocked) tested. Deterministic fixture-based mocking.
Correctness	✅	Supervised profile correctly verified at both transitions (strategize→execute via `create_tool=1.0`, execute→apply via `select_tool=1.0`). Invariant propagation verified via `InvariantSource.ACTION`. Full plan lifecycle exercised through terminal APPLIED state.
Code quality	✅	Clean structure following established wf05/wf07 patterns. Proper type annotations throughout. No `# type: ignore` suppressions. Descriptive docstrings. Standard command dispatch pattern.
API consistency	✅	Robot→Python helper dispatch pattern matches existing workflow tests. Service layer usage (PlanLifecycleService, ResourceRegistryService, SkillService, AutomationProfileService) consistent with codebase.
Type safety	✅	All function signatures fully typed. Return types explicit. Dict type annotations present (`dict[str, Any]`, `list[dict[str, str]]`).
Security	✅	No secrets, credentials, or sensitive data. Fixture data is clearly mock/test data.
Commit format	✅	Single atomic commit, Conventional Changelog format, `ISSUES CLOSED: #772` footer.
PR metadata	✅	Closes #772, `Type/Testing` label, v3.6.0 milestone.

Key Observations

_NoClose wrapper in _setup_db() correctly keeps in-memory SQLite alive across session.close() calls — consistent with established integration test pattern.
Fixture files are well-structured: Terraform state v4 format, CloudWatch-style metrics with realistic values (CPU 12.3% avg / 28.7% peak on m5.2xlarge → right-sizing recommendation to m5.large).
Supervised profile gating properly verified: should_auto_progress() returns False at both phase transitions, requiring explicit execute_plan() and apply_plan() calls.
Invariant enforcement test correctly verifies both directions: critical resources (aws_instance.api, critical: "true") are blocked, non-critical resources (aws_instance.web, critical: "false") are allowed.
Helper file at 672 lines — within established norms for integration test helpers (existing helpers range up to 769 lines).

Minor Note (Non-blocking)

The helper file exceeds the general 500-line guideline, but this is consistent with the established pattern for integration test helpers in this codebase and is not a blocking concern.

No blocking issues found. Approving for merge.

## ✅ Independent Code Review — APPROVED **Reviewer**: reviewer-pool-1 (independent review) ### Scope of Review All 6 new files (~951 lines total): - `robot/wf08_cloud_infra_supervised.robot` — 6 Robot Framework test cases - `robot/helper_wf08_cloud_infra_supervised.py` — Python helper with 6 subcommands - `robot/fixtures/wf08/terraform-state.yaml` — Custom resource type definition - `robot/fixtures/wf08/terraform.tfstate.json` — Mock Terraform state (3 AWS resources) - `robot/fixtures/wf08/cloud-metrics.json` — Mock CloudWatch metrics - `robot/fixtures/wf08/main.tf` — Sample Terraform HCL configuration ### Assessment | Criteria | Status | Notes | |----------|--------|-------| | **Spec alignment** | ✅ | Tests map to Specification Workflow Example 8 — custom resource types (`local/terraform-state`), skill composition (`local/terraform-ops` with 3 tools + includes), supervised profile gating, invariant propagation and enforcement | | **Test quality** | ✅ | 6 meaningful test cases with thorough assertions and descriptive error messages. Both positive paths (non-critical allowed) and negative paths (critical blocked) tested. Deterministic fixture-based mocking. | | **Correctness** | ✅ | Supervised profile correctly verified at both transitions (strategize→execute via `create_tool=1.0`, execute→apply via `select_tool=1.0`). Invariant propagation verified via `InvariantSource.ACTION`. Full plan lifecycle exercised through terminal APPLIED state. | | **Code quality** | ✅ | Clean structure following established wf05/wf07 patterns. Proper type annotations throughout. No `# type: ignore` suppressions. Descriptive docstrings. Standard command dispatch pattern. | | **API consistency** | ✅ | Robot→Python helper dispatch pattern matches existing workflow tests. Service layer usage (PlanLifecycleService, ResourceRegistryService, SkillService, AutomationProfileService) consistent with codebase. | | **Type safety** | ✅ | All function signatures fully typed. Return types explicit. Dict type annotations present (`dict[str, Any]`, `list[dict[str, str]]`). | | **Security** | ✅ | No secrets, credentials, or sensitive data. Fixture data is clearly mock/test data. | | **Commit format** | ✅ | Single atomic commit, Conventional Changelog format, `ISSUES CLOSED: #772` footer. | | **PR metadata** | ✅ | Closes #772, `Type/Testing` label, v3.6.0 milestone. | ### Key Observations 1. **`_NoClose` wrapper** in `_setup_db()` correctly keeps in-memory SQLite alive across `session.close()` calls — consistent with established integration test pattern. 2. **Fixture files** are well-structured: Terraform state v4 format, CloudWatch-style metrics with realistic values (CPU 12.3% avg / 28.7% peak on m5.2xlarge → right-sizing recommendation to m5.large). 3. **Supervised profile gating** properly verified: `should_auto_progress()` returns `False` at both phase transitions, requiring explicit `execute_plan()` and `apply_plan()` calls. 4. **Invariant enforcement** test correctly verifies both directions: critical resources (`aws_instance.api`, `critical: "true"`) are blocked, non-critical resources (`aws_instance.web`, `critical: "false"`) are allowed. 5. **Helper file at 672 lines** — within established norms for integration test helpers (existing helpers range up to 769 lines). ### Minor Note (Non-blocking) The helper file exceeds the general 500-line guideline, but this is consistent with the established pattern for integration test helpers in this codebase and is not a blocking concern. No blocking issues found. Approving for merge.

freemo merged commit 85f8970d00 into master

2026-04-02 16:51:47 +00:00

freemo referenced this pull request from a commit

2026-04-02 16:51:48 +00:00

test(integration): workflow example 8 — cloud infrastructure management (supervised profile) (#1231)

freemo deleted branch test/int-wf08-cloud-infra

2026-04-02 16:51:48 +00:00

freemo referenced this pull request

2026-04-02 16:51:55 +00:00

test(integration): workflow example 8 — cloud infrastructure management (supervised profile) #772

freemo referenced this pull request

2026-04-02 17:11:30 +00:00