fix(cli): pass decision tree and influence edges to CorrectionService in plan correct handler #639

Merged

freemo merged 2 commits from fix/plan-correct-tree-wiring into master

2026-03-08 23:28:05 +00:00

freemo commented

2026-03-08 02:12:55 +00:00

Owner

Summary

Fixes the plan correct CLI handler which never passes the decision tree or influence edges to CorrectionService, producing single-node impact analysis regardless of the plan's actual decision structure.

Closes #606

Root Cause

The correct_decision() handler in plan.py created a bare CorrectionService() and called analyze_impact() and execute_correction() without passing decision_tree or influence_edges. Both parameters default to None -> empty dicts, causing _compute_affected_subtree() BFS to return only the single target decision, ignoring all descendants and influence-DAG dependents.

Changes

Production Fix (`src/cleveragents/cli/commands/plan.py`)

Resolve DecisionService via get_container() (following the pattern used by plan explain and plan tree)
Build structural tree adjacency list from decision_svc.list_decisions(plan_id) using parent_decision_id relationships
Fetch influence edges from decision_svc.get_influence_edges(plan_id)
Pass both decision_tree and influence_edges to svc.analyze_impact() and svc.execute_correction()

Existing Test Fixups

Updated 4 step definition files that mock CorrectionService to also mock the new DecisionService resolution path

New Tests

Behave BDD: 3 scenarios verifying tree/edge forwarding (dry-run subtree, execution subtree, leaf node)
Robot Framework: 3 integration smoke tests
ASV Benchmark: Tree building and analyze_impact overhead benchmarks

Quality Gates

nox -s lint — PASSED
nox -s typecheck — 0 errors
nox -s unit_tests — 9,109 scenarios, 0 failures
nox -s coverage_report — 97%

ISSUES CLOSED: #606

## Summary Fixes the `plan correct` CLI handler which never passes the decision tree or influence edges to `CorrectionService`, producing single-node impact analysis regardless of the plan's actual decision structure. Closes #606 ## Root Cause The `correct_decision()` handler in `plan.py` created a bare `CorrectionService()` and called `analyze_impact()` and `execute_correction()` without passing `decision_tree` or `influence_edges`. Both parameters default to `None` -> empty dicts, causing `_compute_affected_subtree()` BFS to return only the single target decision, ignoring all descendants and influence-DAG dependents. ## Changes ### Production Fix (`src/cleveragents/cli/commands/plan.py`) - Resolve `DecisionService` via `get_container()` (following the pattern used by `plan explain` and `plan tree`) - Build structural tree adjacency list from `decision_svc.list_decisions(plan_id)` using `parent_decision_id` relationships - Fetch influence edges from `decision_svc.get_influence_edges(plan_id)` - Pass both `decision_tree` and `influence_edges` to `svc.analyze_impact()` and `svc.execute_correction()` ### Existing Test Fixups - Updated 4 step definition files that mock `CorrectionService` to also mock the new `DecisionService` resolution path ### New Tests - **Behave BDD**: 3 scenarios verifying tree/edge forwarding (dry-run subtree, execution subtree, leaf node) - **Robot Framework**: 3 integration smoke tests - **ASV Benchmark**: Tree building and analyze_impact overhead benchmarks ## Quality Gates - `nox -s lint` — PASSED - `nox -s typecheck` — 0 errors - `nox -s unit_tests` — 9,109 scenarios, 0 failures - `nox -s coverage_report` — 97% ISSUES CLOSED: #606

Rows
Columns