cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

test(cli): TDD failing tests for init --yes non-interactive (bug #783) #1049

Merged
hurui200320 merged 2 commits from tdd/m3-init-yes-no-input into master 2026-03-19 06:31:20 +00:00
Conversation 1 Commits 2 Files Changed 4
+529
hurui200320 commented 2026-03-18 08:26:13 +00:00
Member
Copy Link
Copy Source

Summary

Adds TDD bug-capture tests proving that agents init --yes fails to bypass the
migration approval prompt in a TTY environment (bug #783). These tests follow the
mandatory TDD bug-fix workflow defined in CONTRIBUTING.md §Bug Fix Workflow.

Changes

  • Behave feature (features/tdd_init_yes_no_input.feature): Two scenarios
    tagged @tdd_expected_fail @tdd_bug @tdd_bug_783 that invoke agents init --yes
    in a fresh environment with the migration prompt simulated as declining (TTY with
    no input). The tests verify the command exits successfully and does not display the
    "Apply migrations now?" prompt.

  • Behave steps (features/steps/tdd_init_yes_no_input_steps.py): Step definitions
    that create an isolated temp directory, clear auto-apply and database-URL environment
    variables, patch sys.stdin on the real sys module (correct mock target per project
    convention), and replace MigrationRunner._default_prompt_for_migration with a
    function that returns False (simulating a TTY prompt where the user declines).
    Temp directory and env var cleanup is registered via context.add_cleanup().

  • Robot Framework test (robot/tdd_init_yes_no_input.robot): Two integration test
    cases tagged tdd_bug, tdd_bug_783, tdd_expected_fail matching the Behave scenarios.

  • Robot helper (robot/helper_tdd_init_yes_no_input.py): Helper script that exercises
    the same code path using the same mock strategy as the Behave steps.

Bug Reproduction Mechanism

The core challenge is that CliRunner replaces sys.stdin during invoke(), making
direct isatty() patching ineffective for controlling the prompt path. The mock strategy
addresses this with a two-pronged approach:

  1. patch.object(sys, "stdin", mock_stdin) — Patches sys.stdin directly on the
    real sys module (correct mock target per the project's established pattern in
    features/steps/migration_runner_steps.py). Documents the intent of simulating a TTY.

  2. patch.object(MigrationRunner, "_default_prompt_for_migration", ...) — Replaces
    the prompt function with one that returns False (simulating a TTY user declining
    migration). This is the mechanism that actually exercises the bug path, since
    CliRunner's stdin replacement bypasses the isatty() check.

  3. CLEVERAGENTS_DATABASE_URL with non-template filename — Sets the database URL
    to a path whose filename does not match the before_scenario template-DB prefixes,
    forcing the real Alembic migration path instead of the test fast-path.

With bug #783 present, require_confirmation=True is hardcoded in
UnitOfWork._ensure_database_initialized(), so the prompt fires, returns False,
causing MigrationNotApprovedError and a non-zero exit code. After the fix, --yes
should bypass the prompt entirely.

Root Cause (for the bug fix developer)

init_command() in cleveragents.cli.commands.project receives the --yes flag but
only uses it to control output format. It does not forward yes to the migration runner.
The migration runner's init_or_upgrade() is called via
unit_of_work._ensure_database_initialized() with require_confirmation=True hardcoded.

Scenario 2 Limitation

While the bug is present, Scenario 2's first assertion (exit code 0) fails and Behave
skips subsequent steps. The "contains Initialized" assertion is only evaluated after the
bug is fixed, providing distinct post-fix regression value.

Quality Gate Results

  • nox -s lint — ✅ passed
  • nox -s typecheck — ✅ passed (0 errors)
  • nox -s unit_tests — ✅ passed (387 features, 11121 scenarios, 0 failed)
  • nox -s integration_tests — ✅ passed (1561 tests, 0 failed)
  • nox -s e2e_tests — ✅ passed (16 tests, 0 failed)
  • nox -s coverage_report — ✅ passed (97% coverage)

Closes #842

## Summary Adds TDD bug-capture tests proving that `agents init --yes` fails to bypass the migration approval prompt in a TTY environment (bug #783). These tests follow the mandatory TDD bug-fix workflow defined in CONTRIBUTING.md §Bug Fix Workflow. ### Changes - **Behave feature** (`features/tdd_init_yes_no_input.feature`): Two scenarios tagged `@tdd_expected_fail @tdd_bug @tdd_bug_783` that invoke `agents init --yes` in a fresh environment with the migration prompt simulated as declining (TTY with no input). The tests verify the command exits successfully and does not display the "Apply migrations now?" prompt. - **Behave steps** (`features/steps/tdd_init_yes_no_input_steps.py`): Step definitions that create an isolated temp directory, clear auto-apply and database-URL environment variables, patch `sys.stdin` on the real `sys` module (correct mock target per project convention), and replace `MigrationRunner._default_prompt_for_migration` with a function that returns `False` (simulating a TTY prompt where the user declines). Temp directory and env var cleanup is registered via `context.add_cleanup()`. - **Robot Framework test** (`robot/tdd_init_yes_no_input.robot`): Two integration test cases tagged `tdd_bug`, `tdd_bug_783`, `tdd_expected_fail` matching the Behave scenarios. - **Robot helper** (`robot/helper_tdd_init_yes_no_input.py`): Helper script that exercises the same code path using the same mock strategy as the Behave steps. ### Bug Reproduction Mechanism The core challenge is that `CliRunner` replaces `sys.stdin` during `invoke()`, making direct `isatty()` patching ineffective for controlling the prompt path. The mock strategy addresses this with a two-pronged approach: 1. **`patch.object(sys, "stdin", mock_stdin)`** — Patches `sys.stdin` directly on the real `sys` module (correct mock target per the project's established pattern in `features/steps/migration_runner_steps.py`). Documents the intent of simulating a TTY. 2. **`patch.object(MigrationRunner, "_default_prompt_for_migration", ...)`** — Replaces the prompt function with one that returns `False` (simulating a TTY user declining migration). This is the mechanism that actually exercises the bug path, since CliRunner's stdin replacement bypasses the `isatty()` check. 3. **`CLEVERAGENTS_DATABASE_URL` with non-template filename** — Sets the database URL to a path whose filename does not match the `before_scenario` template-DB prefixes, forcing the real Alembic migration path instead of the test fast-path. With bug #783 present, `require_confirmation=True` is hardcoded in `UnitOfWork._ensure_database_initialized()`, so the prompt fires, returns `False`, causing `MigrationNotApprovedError` and a non-zero exit code. After the fix, `--yes` should bypass the prompt entirely. ### Root Cause (for the bug fix developer) `init_command()` in `cleveragents.cli.commands.project` receives the `--yes` flag but only uses it to control output format. It does not forward `yes` to the migration runner. The migration runner's `init_or_upgrade()` is called via `unit_of_work._ensure_database_initialized()` with `require_confirmation=True` hardcoded. ### Scenario 2 Limitation While the bug is present, Scenario 2's first assertion (exit code 0) fails and Behave skips subsequent steps. The "contains Initialized" assertion is only evaluated after the bug is fixed, providing distinct post-fix regression value. ### Quality Gate Results - `nox -s lint` — ✅ passed - `nox -s typecheck` — ✅ passed (0 errors) - `nox -s unit_tests` — ✅ passed (387 features, 11121 scenarios, 0 failed) - `nox -s integration_tests` — ✅ passed (1561 tests, 0 failed) - `nox -s e2e_tests` — ✅ passed (16 tests, 0 failed) - `nox -s coverage_report` — ✅ passed (97% coverage) Closes #842
hurui200320 added this to the v3.2.0 milestone 2026-03-18 08:26:24 +00:00
hurui200320 added the
Type
Testing
 label 2026-03-18 08:26:25 +00:00
hurui200320 force-pushed tdd/m3-init-yes-no-input from 5f3158cf39 to c35e372a9c 2026-03-18 10:17:19 +00:00 Compare
freemo approved these changes 2026-03-19 04:54:38 +00:00
freemo left a comment
Owner
Copy Link
Copy Source

Code Review — PR #1049 test(cli): TDD failing tests for init --yes non-interactive (bug #783)

Clean TDD test PR. Well-structured with 2 Behave scenarios + 2 Robot tests. The mock strategy is well-documented (patching MigrationRunner._default_prompt_for_migration since CliRunner replaces sys.stdin). TDD tags @tdd_expected_fail @tdd_bug @tdd_bug_783 are correctly applied. Cleanup properly registered via context.add_cleanup().

Approved. One very minor note: sibling PRs #1050-#1052 include CHANGELOG entries while this one does not. This is a minor inconsistency but not a blocker.

## Code Review — PR #1049 `test(cli): TDD failing tests for init --yes non-interactive (bug #783)` Clean TDD test PR. Well-structured with 2 Behave scenarios + 2 Robot tests. The mock strategy is well-documented (patching `MigrationRunner._default_prompt_for_migration` since CliRunner replaces `sys.stdin`). TDD tags `@tdd_expected_fail @tdd_bug @tdd_bug_783` are correctly applied. Cleanup properly registered via `context.add_cleanup()`. **Approved.** One very minor note: sibling PRs #1050-#1052 include CHANGELOG entries while this one does not. This is a minor inconsistency but not a blocker.
freemo requested review from brent.edwards 2026-03-19 05:16:38 +00:00
freemo requested review from freemo 2026-03-19 05:16:38 +00:00
hurui200320 added 1 commit 2026-03-19 06:23:28 +00:00
Merge branch 'master' into tdd/m3-init-yes-no-input
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 17s
Details
CI / build (pull_request) Successful in 17s
Details
CI / quality (pull_request) Successful in 29s
Details
CI / security (pull_request) Successful in 57s
Details
CI / typecheck (pull_request) Successful in 1m2s
Details
CI / unit_tests (pull_request) Successful in 3m33s
Details
CI / integration_tests (pull_request) Successful in 3m40s
Details
CI / e2e_tests (pull_request) Successful in 3m47s
Details
CI / docker (pull_request) Successful in 1m8s
Details
CI / coverage (pull_request) Successful in 6m47s
Details
CI / benchmark-regression (pull_request) Successful in 39m55s
Details
fcfbb6a096
hurui200320 scheduled this pull request to auto merge when all checks succeed 2026-03-19 06:24:04 +00:00
hurui200320 merged commit 747d8d3c9a into master 2026-03-19 06:31:20 +00:00
hurui200320 deleted branch tdd/m3-init-yes-no-input 2026-03-19 06:31:20 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
freemo
brent.edwards
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Type
Testing
Milestone
No items
No Milestone v3.2.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Blocks
#842 TDD: `agents init --yes` should not require user input (bug #783)
cleveragents/cleveragents-core
Reference: cleveragents/cleveragents-core#1049
Delete Branch "tdd/m3-init-yes-no-input"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?