1295 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
freemo	4eddbcf489	fix(cli): add --depth-gradient flag to project context set ... Add the missing --depth-gradient repeatable flag to `project context set` per specification. The flag accepts HOP:INT_OR_NAME format to control context detail depth degradation with graph distance. Parsing validates hop as integer and value as integer or recognized detail level name. ISSUES CLOSED: #889	2026-03-30 17:12:20 +00:00
hamza.khyari	cbcb873e17	Merge pull request 'fix(cli): implement --execution-env-priority on project context set' (#1135) from bugfix/m8-project-exec-env-priority into master ... Reviewed-on: #1135	2026-03-30 14:53:55 +00:00
hamza.khyari	49015c6bee	fix(cli): implement --execution-env-priority on project context set ... Add --execution-env-priority flag to 'project context set' command, enabling project-level execution environment priority per spec WF17. - Add execution_env_priority field to ContextConfig domain model - Validate flag value against ExecutionEnvPriority enum (fallback/override) - Persist in context_policy_json, preserving existing execution_environment - Display in 'project context show' Execution Environment section - Merge with existing blob to avoid overwriting previously set fields Tests: 9 Behave scenarios, 26 steps. ISSUES CLOSED: #1079	2026-03-30 14:33:28 +00:00
hamza.khyari	40e0cb9860	Merge pull request 'feat(resource): add container infrastructure resource types' (#1045) from feature/container-resource-types into master ... Reviewed-on: #1045	2026-03-30 14:06:24 +00:00
hamza.khyari	2370e19da8	feat(resource): add container infrastructure resource types ... Add 7 container infrastructure resource types per ADR-039: container-runtime, container-image, container-mount, container-exec-env, container-port, container-volume, container-network. - YAML configs under examples/resource-types/ - Bootstrap registration via _resource_registry_container.py - Updated container-instance parent_types (container-runtime, container-image) and child_types (container-mount, container-exec-env, container-port) - container-runtime is top-level with auto-discovery rules (scan_depth: 1) - container-mount/exec-env/port inherit snapshot sandbox from instance - container-volume is user-addable with snapshot sandbox - container-network is read-only, no sandbox - Handler references are forward declarations (ADR-039) - 33 Behave BDD scenarios, 4 Robot integration tests - Updated BUILTIN_NAMES, service docstring, CHANGELOG ISSUES CLOSED: #831	2026-03-30 13:44:54 +00:00
aditya	f03e510a11	Merge pull request 'feat(acms): integrate FAISS into ACMS vector backend protocol' (#1165) from feature/m6-faiss-acms-backend into master ... Reviewed-on: #1165 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com>	2026-03-30 13:40:25 +00:00
aditya	eff446f5e8	feat(acms): integrate FAISS into ACMS vector backend protocol ... Add FAISS-backed ACMS read and write adapters on top of the shared VectorStoreService, wire them through the DI container, and cover indexing, scoped search, removal, and benchmark behavior with Behave and ASV. Address review feedback by keeping the commit scoped to the FAISS backend work and replacing the loose vector-store cache typing with explicit FAISS store protocols instead of Any. ISSUES CLOSED: #871	2026-03-30 13:19:08 +00:00
CoreRasurae	007af498b8	refactor(autonomy): rename automation profile task flags to spec names ... Renamed all 11 task-type confidence threshold fields in AutomationProfile from phase-transition semantics to spec-defined task-type semantics. Updated all 8 built-in profiles, CLI formatting, YAML schema, services, and all Behave/Robot tests referencing the old field names. Post-review fixes: - Fixed 24 stale old field names in M6 fixture files (automation_profiles.json, autonomy_guardrails.json) - Added model_validator(mode='before') to detect legacy field names and raise actionable ValueError with rename mapping - Added semantic bridge comments in PlanLifecycleService mapping task-type thresholds to phase-transition gates - Added threshold_field to structured log messages for observability - Restored categorised CLI automation-profile show output to match spec (Phase Transitions / Decision Automation / Self-Repair / Execution Controls) instead of flat list - Added missing access_network field to spec show output examples (Rich, Plain, JSON, YAML variants) - Aligned ADR-017 profile fields table to all 11 fields with descriptions matching spec Automatable Tasks table - Aligned automation_profiles.md threshold descriptions with spec - Added spec section references in phase_reversion.md, error_recovery.md, and plan_execute.md for field naming context - Extended repository roundtrip test to assert all 11 threshold fields - Fixed benchmark _make_profile() passing safety fields as top-level kwargs instead of via SafetyProfile sub-model (incompatible with extra="forbid") - Aligned CLI JSON/YAML output structure for automation-profile show with the specification grouped format (phase_transitions, decision_automation, self_repair, execution_controls) - Moved safety boolean fields into the Execution Controls section of Rich output per spec examples - Reverted auto profile description to "Fully automatic except apply" per specification (line 16703, line 28406) - Improved bridge comments in test steps with semantic context for threshold-to-gate mappings ISSUES CLOSED: #902	2026-03-30 13:18:07 +01:00
hamza.khyari	452a2f35b0	Merge pull request 'feat(lsp): add missing LspServerConfig model fields' (#1064) from feature/lsp-config-fields into master ... Reviewed-on: #1064 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com>	2026-03-30 12:07:28 +00:00
hamza.khyari	c97ec273a9	feat(lsp): add missing LspServerConfig model fields ... Add specification-required fields to LspServerConfig: - description: str (max_length=1000, default='') - transport: LspTransport enum (stdio/tcp/pipe, default=stdio) - initialization: dict[str, Any] (LSP initializationOptions, default={}) - workspace_settings: dict[str, Any] (workspace/didChangeConfiguration, default={}) All fields have defaults for backward compatibility with existing configs. LspTransport enum exported from lsp package. Tests: 17 Behave scenarios, 5 Robot integration tests. Existing LSP tests: 250/250 pass unchanged. ISSUES CLOSED: #835	2026-03-30 11:51:27 +00:00
freemo	9cace15d6e	test(e2e): workflow example 18 — container with remote repo clone (trusted profile) ... E2E test for Specification Workflow Example 18: Container with Remote Repo Clone using the trusted automation profile. Exercises the full container-instance workflow per the spec: - Registers a container-instance resource with --clone-into flag (new CLI flag added to resource add for REPO_URL:CONTAINER_PATH). - Two-step project creation: project create + project link-resource. - Dynamic LLM actor selection (Anthropic/OpenAI) matching available API keys. - Plan use with --execution-environment container, --execution-env-priority fallback, and --automation-profile trusted. - Full plan lifecycle: strategize, execute, diff, apply, status. - Positive assertions: non-empty output, plan ID presence, terminal state verification, container/clone evidence logging. - Negative assertions: Traceback and INTERNAL error checks. - ULID regex uses Crockford base32 character set. - Unique suffix for resource/project names (parallel CI safe). - Skip If No LLM Keys guard for graceful degradation. - CHANGELOG.md updated. ISSUES CLOSED: #764	2026-03-30 19:17:41 +08:00
hurui200320	b6c3169634	test(e2e): workflow example 16 — devcontainer-driven development (supervised profile) ... Implements E2E test for devcontainer-driven development workflow. Tests project setup with .devcontainer config, resource registration, and full plan lifecycle with supervised automation profile. Changes from Cycle 5 review: 1. Replaced custom WF16_ALLOW_XFAIL_SKIP escape hatch with the project standard tdd_expected_fail tag system. Test is now tagged [Tags] tdd_expected_fail tdd_bug tdd_bug_762 and the listener inverts failures in CI until devcontainer features are fully wired. 2. Added diagnostic WF16 Test Teardown keyword that captures plan status JSON on failure, mirroring the WF05 teardown pattern. 3. Added stderr checks to all Traceback/INTERNAL guard assertions so tracebacks appearing only in stderr are also detected. 4. Rebased branch onto latest master (e4c01492). 5. Documented timeout budget: added comment explaining theoretical worst-case (~46min) vs realistic execution under the 35min limit. 6. Added fail-fast warning in AC-3 check noting that AC-4, AC-5, and AC-6 are dependent on AC-3 and are likely to also fail. 7. Reordered plan apply arguments to --yes --format json <plan_id> for spec consistency. 8. Decomposed long ready_for_apply Evaluate expression into three intermediate booleans (is_apply_phase, is_execute_complete, is_already_applied) for readability. 9. Added shared_session.close() calls in resource_dag.robot before each final print() to ensure explicit session cleanup. 10. Cleaned up stale xfail/skip classification references in log messages. Changes from earlier cycles (3-4) retained in this commit: - Terminal state validation, AC output combination, JSON format flags, suite-level init, Force Tags, automation profile fallback, ULID regex IGNORECASE, AC-5 Evaluate decomposition, defensive re-check pattern. ISSUES CLOSED: #762	2026-03-30 18:45:10 +08:00
aditya	099cd0f563	Merge pull request 'feat(acms): projects with 10,000+ files index without timeout' (#1158) from feature/m5-large-project-indexing into master ... Reviewed-on: #1158 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com>	2026-03-30 10:44:22 +00:00
aditya	4e64544aae	feat(acms): projects with 10,000+ files index without timeout ... Add explicit indexing timeout bounds and propagate timeout_seconds through the repo indexing service, utility walker, and CLI entrypoint so large repositories fail predictably instead of hanging. Add 10K-scale Behave/Robot verification and a dedicated benchmark path to validate that large-project indexing completes, persists status correctly, and remains measurable for regressions. Address review feedback by splitting oversized Behave and Robot support files into focused modules, trimming repo_indexing_service.py back under the 500-line limit, and rebasing the branch onto current master. ISSUES CLOSED: #851 # Conflicts: # CHANGELOG.md # robot/helper_m5_e2e_verification.py	2026-03-30 10:18:19 +00:00
aditya	a2546b06b1	Merge pull request 'feat(acms): plan execution leverages ACMS context for LLM calls' (#1163) from feature/m5-acms-llm-integration into master ... Reviewed-on: #1163	2026-03-30 10:12:05 +00:00
aditya	f0442e835d	feat(acms): plan execution leverages ACMS context for LLM calls ... Integrate ACMS execute-phase context assembly into LLMExecuteActor and inject assembled context into execute prompts with resilient fallback when assembly fails or returns empty output. Wire the plan CLI executor to use an ACMS-backed execute context assembler, add Behave coverage for context injection/fallback/empty context, and extend Robot M5 verification helpers to assert execute-phase ACMS context usage. ISSUES CLOSED: #850	2026-03-30 09:21:51 +00:00
aditya	abf7b47de1	Merge pull request 'feat(acms): context analysis produces meaningful summaries' (#1159) from feature/m5-context-analysis into master ... Reviewed-on: #1159 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com>	2026-03-30 09:06:27 +00:00
aditya	ef8f9640fa	feat(acms): context analysis produces meaningful summaries ... Add phase-wise context analysis summaries for strategize, execute, and apply, and integrate them into `agents project context inspect` and `agents project context simulate` with per-phase resource counts, size and token utilization, and narrowing diagnostics.\n\nAdd Behave and Robot coverage for empty, single-resource, multi-resource, and budget-constrained context analysis, and tighten the M5 smoke coverage after review feedback with exact summary assertions and a missing-path regression scenario for `agents context add`.\n\nISSUES CLOSED: #849	2026-03-30 08:42:48 +00:00
hurui200320	5ddc04bcc7	test(e2e): workflow example 17 — explicit container with directory mount (trusted profile) ... Implements E2E test for Specification WF17: Explicit Container with Directory Mount. The test exercises the full workflow from the spec: - Registers git-checkout resource and container-instance resource (with --image flag; --mount not yet available on CLI) - Creates project, links both resources via project link-resource - Sets execution environment to container via project context set - Uses --execution-env-priority override on plan use (per ADR-043) - Creates action with dynamically selected actor (Anthropic or OpenAI) - Runs full plan lifecycle: use → strategize → execute → diff → apply → status - Uses trusted automation profile for auto-execution of tool invocations Quality improvements over initial implementation: - Custom suite setup with workspace init (agents init --force --yes) - UUID-based unique suffix for resource/project names (CI parallelism) - Dynamic actor selection matching available API keys (M6 pattern) - Skip If No LLM Keys guard for graceful degradation - Crockford Base32 ULID regex ([0-9A-HJ-NP-Z]{26}) - Checked return codes on all git subprocess calls - INTERNAL error checks alongside Traceback checks - --format json on all CLI commands for deterministic output - Domain-specific assertions for plan output verification - Diff output non-empty assertion - Security note documenting trusted profile auto-execution decision - CHANGELOG entry added ISSUES CLOSED: #763	2026-03-30 08:05:41 +00:00
hurui200320	d24959e961	test(e2e): workflow example 12 — large-scale hierarchical feature implementation (supervised profile) ... Implements E2E test for Workflow Example 12: large-scale hierarchical feature implementation with the supervised automation profile. Key test behaviors: - Sets up 4 projects (protos, api, worker, frontend) with per-project invariants, matching the specification. - Creates action YAML with spec-required fields: estimation_actor, invariant_actor, automation_profile: cautious, and action-level invariants. - Passes all 4 projects to plan use (spec Step 3). - Dynamically selects actor based on available API key (Anthropic or OpenAI) for flexible CI/local execution. - Uses Skip If No LLM Keys for graceful degradation in keyless CI. - Verifies hierarchical decomposition via plan tree (decision_id count, children field check). - Selects a non-root decision for plan correct --mode append to exercise targeted correction rather than root invalidation. - Verifies correction acknowledgment via output content assertions. - Verifies phased lifecycle-apply with --yes flag and phase field parsing. - Final status uses --format json with Safe Parse Json Field to verify terminal state (phase and processing_state populated). - UUID-suffixed names prevent UNIQUE constraint collisions in parallel CI. - Crockford Base32 ULID regex (excludes I, L, O, U) consistent with m1_acceptance.robot. - All commands check for Traceback and INTERNAL error markers. - Force Tags E2E in Settings (m6 convention). - Timeout set to 35 minutes for real LLM execution headroom. Note: plan prompt (spec Step 4 — supervised-profile user intervention) is not yet implemented as a CLI command. A documentation note in the test indicates this should be added once the command is available. ISSUES CLOSED: #758	2026-03-30 13:46:21 +08:00
hurui200320	2651e15854	fix(cli): replace non-existent Container.resolve() with named provider calls ... The three plan.py call sites (tree, explain, correct) that originally used container.resolve(DecisionService) were already fixed in master. This commit completes the fix by aligning the Robot Framework test mocks to match the corrected production code: - robot/helper_m3_decision_validation_smoke.py: mock_container.resolve → mock_container.decision_service (plan correct dry-run path) - robot/helper_m4_correction_subplan_smoke.py: container.resolve → container.decision_service (correction subplan path) Both helpers previously passed silently because MagicMock auto-creates any attribute, masking the mismatch between mock setup and actual code. Added spec=Container to both mock containers so that accessing non-existent attributes raises AttributeError, matching real container behavior. Updated comment wording in features/container_resolve_crash.feature to clarify that the bug is fixed and the scenarios serve as permanent regression guards. The @tdd_expected_fail tag was already removed by the TDD branch before this fix branch was created; the permanent @tdd_issue and @tdd_issue_647 tags remain per TDD tag lifecycle rules. Added CHANGELOG.md entry describing the fix. ISSUES CLOSED: #647	2026-03-30 04:45:56 +00:00
freemo	845cf61b47	test(e2e): workflow example 4 — multi-project dependency update (supervised profile) ... Implement WF04 E2E test coverage for multi-project dependency update using the supervised automation profile. A parent plan targets four projects (common-lib + 3 services), spawns child subplans per project, executes in dependency order, validates per project, and applies in dependency order. Key components: - Robot test (robot/e2e/wf04_multi_project.robot): full supervised workflow exercising plan use, strategize, execute, validate, apply, and final status. JSON output parsing via raw_decode for resilience. Test-level guard skips the entire test (visible SKIPPED in CI) when the LLM produces zero subplans, preventing silent AC-4/5/6/7 bypass. Count Decision Nodes keyword delegates to the Python helper to avoid duplicating recursive tree-walking logic. - Snapshot helper (robot/e2e/wf04_snapshot_helper.py): collects deterministic parent/subplan metadata from the lifecycle service. Timestamps normalised to UTC. Depth-guarded count_decision_nodes() function (max_depth=50) for safe reuse from Robot keywords. sys.path.append (not insert) to avoid shadowing the standard library. - Behave unit tests (features/wf04_snapshot_helper.feature + steps): 17 scenarios covering _iso(), _enum_value(), count_decision_nodes(), and _build_snapshot() with mocked lifecycle service. Includes tests for no-subplans (verifies plan_id, project_scopes, validation_summary), with-subplans (verifies concrete mapped project names and subplan_count), child-plan-is-None (verifies empty-string defaults), unmapped resources, and exact-match aware-datetime UTC normalisation. ISSUES CLOSED: #750	2026-03-30 11:47:37 +08:00
Luis Mendes	7f078f75a5	fix(sandbox): make commit_all atomic per specification ... Changed SandboxManager.commit_all() from partial-commit semantics to all-or-nothing atomic operation per specification requirement. On partial failure, already-committed sandboxes are rolled back. Error reporting indicates which sandbox failed and what was rolled back. Added Behave scenarios verifying atomicity guarantee. Hardened atomicity guarantees after code review: - commit_all and _rollback_committed catch Exception (not just SandboxError) so unexpected errors cannot bypass rollback. Non-SandboxError exceptions are wrapped in a new AtomicCommitError (chaining the original as __cause__) that carries rolled_back_ids and failed_rollback_ids attributes so callers can programmatically determine rollback outcomes. - _rollback_committed returns both rolled_back_ids and failed_rollback_ids; the error result metadata now carries both "rolled_back" and "rollback_failed" keys. - _rollback_committed iterates in reverse (LIFO) order following the standard transaction-log undo pattern. Clarified in docstring that this is distinct from the specification DAG-based "top-down" rollback ordering (line 24632). - TransactionSandbox.rollback() from COMMITTED now raises SandboxRollbackError (database commits are irreversible) instead of silently transitioning to ROLLED_BACK. - TransactionSandbox is now classified as non-rollbackable in commit_all alongside NoSandbox and committed last in the batch, since database COMMIT is irreversible. Docstring corrected to match the raising behavior. - CopyOnWriteSandbox and OverlaySandbox rollback-from-COMMITTED uses rename-based safe_restore() to prevent data loss when the copytree step fails after the original was removed. - CopyOnWriteSandbox and OverlaySandbox rollback() now catches Exception (not just OSError), matching the broader catch used in _rollback_committed, so non-OSError exceptions from safe_restore set the status to ERRORED correctly. - Extracted shared _fs_utils module (backup_directory, safe_restore, compute_diff) with symlink, permission, and timestamp preservation (including directory timestamps), replacing duplicated per-class _backup_directory and _compute_diff methods. - backup_directory defers directory permissions and timestamps to a bottom-up post-walk pass, fixing incorrect mtime preservation (POSIX file creation inside a directory overwrites its mtime) and preventing restrictive source permissions from blocking backup writes. - backup_directory skips non-regular files (FIFOs, sockets, device files) with a warning to prevent hangs on special files. - CopyOnWriteSandbox and OverlaySandbox commit() now attempts to restore the original from the pre-commit backup when the file-copy phase fails midway, preventing partial corruption. If the restore itself fails the backup is preserved for manual recovery (cleanup() still removes it). - CopyOnWriteSandbox and OverlaySandbox commit() error handler now catches Exception (not just OSError) so that unexpected errors during the file-copy phase also trigger pre-commit backup restoration, preventing partial corruption of the original directory. - Pre-commit backup exception handler catches Exception (not just OSError) preventing temp directory leaks on non-OSError failures from backup_directory. - Fixed _pre_commit_backup assignment timing: the backup reference is now assigned only AFTER backup_directory() succeeds, preventing safe_restore() from corrupting an intact original with a partial backup when backup_directory() fails (e.g. disk full). - Rollback from COMMITTED with no pre-commit backup (no changes were applied) is now a no-op instead of raising SandboxRollbackError, preventing false rollback-failure reports in commit_all error metadata. - commit_all logs a warning when NoSandbox or TransactionSandbox instances are present in the batch since their changes cannot be rolled back, which breaks the atomicity guarantee. - Pre-commit backup is skipped when compute_diff returns no changes, avoiding a full directory copy for no-op commits. - GitWorktreeSandbox clears _pre_merge_commit on commit failure so the stale value cannot be used by future code. - commit_all docstring documents Raises clause for AtomicCommitError exception wrapping behavior. - GitWorktreeSandbox.rollback() docstring warns about multi-worktree safety when rolling back from COMMITTED. - Updated SandboxStatus transition diagram in protocol.py to clearly show the COMMITTED -> ROLLED_BACK path. - Added spec-contradiction note (line 45938 vs 19193) in commit_all docstring. - OverlaySandbox rollback from COMMITTED now properly remounts OverlayFS for real overlay (unmount, clean upper/work dirs, remount) and uses dirs_exist_ok=True for userspace fallback to prevent FileExistsError if rmtree silently fails. The merged directory is reset from the restored original, preventing stale pre-rollback data from being exposed on re-activation via get_path() (which allows ROLLED_BACK status). - OverlaySandbox rollback from COMMITTED now raises SandboxRollbackError if the OverlayFS unmount fails, preventing a double-mount attempt that would leave the sandbox in an inconsistent state. - OverlaySandbox rollback from ACTIVE now uses dirs_exist_ok=True for userspace fallback to prevent FileExistsError when rmtree with ignore_errors=True silently fails. - CopyOnWriteSandbox rollback from ACTIVE now uses dirs_exist_ok=True in copytree to prevent FileExistsError when rmtree with ignore_errors=True silently fails, matching the fix already applied to OverlaySandbox. - Non-rollbackable sandboxes (NoSandbox, TransactionSandbox) are committed last in the batch so that all rollbackable sandboxes commit first; if any rollbackable sandbox fails, none of the non-rollbackable sandboxes will have committed yet. - Moved NoSandbox and TransactionSandbox imports to module level in manager.py (no circular dependency exists). - Pre-commit backups are now created on the same filesystem as the original directory (using dir= argument to mkdtemp), avoiding cross-device copy overhead and ensuring os.rename compatibility. - safe_restore now renames the target into the mkdtemp directory instead of removing the mkdtemp dir first, eliminating the residual TOCTOU window between rmdir and rename. - safe_restore catches BaseException (not just OSError) to ensure the original directory is always renamed back on unexpected errors, preventing the original from being left in the renamed-aside state. - Added AtomicCommitError exception class to protocol.py carrying rolled_back_ids and failed_rollback_ids attributes. - Exported AtomicCommitError from sandbox package __init__.py so callers can import it from the public API. - Added BDD scenarios: LIFO rollback order, AtomicCommitError wrapping with RuntimeError cause and rollback metadata, _fs_utils backup/restore coverage, no-change commit rollback success, directory timestamp preservation, OverlaySandbox merged dir reset after COMMITTED rollback, CopyOnWriteSandbox rollback from COMMITTED restores original, GitWorktreeSandbox rollback from COMMITTED undoes merge, TransactionSandbox rollback from COMMITTED raises SandboxRollbackError about irreversible commit. ISSUES CLOSED: #925 Post-review hardening (PR #1146 review findings): - OverlaySandbox rollback from COMMITTED with no backup (no-op) now skips the merged directory reset entirely, preventing unnecessary unmount/remount or re-copy that could fail and turn a harmless no-op rollback into a SandboxRollbackError during commit_all atomic recovery. - OverlaySandbox rollback no longer double-wraps SandboxRollbackError: the outer except Exception handler now has a preceding except SandboxRollbackError clause that re-raises directly, avoiding a confusing double-wrapped error chain. - CopyOnWriteSandbox.get_path() now accepts ROLLED_BACK status for consistency with OverlaySandbox and the protocol status transition table (ROLLED_BACK -> ACTIVE). - CopyOnWriteSandbox rollback from COMMITTED now resets the sandbox copy from the restored original via rmtree+copytree, preventing stale pre-rollback modifications from being exposed on re-activation. - rollback_all now catches Exception (not just SandboxError) so that unexpected rollback errors do not prevent remaining sandboxes from being rolled back, consistent with the pattern already used in _rollback_committed. - commit_all docstring now documents a thread-safety warning: the method is not safe for concurrent calls on the same plan_id since sandbox commit/rollback runs outside the lock. - Fixed CHANGELOG.md whitespace inconsistencies (double leading spaces on two lines). Post-review hardening round 2 (PR #1146 automated review): - safe_restore now uses os.rename (O(1) atomic rename) instead of shutil.copytree (O(n) recursive copy) for the main restore path, since backup and target are always on the same filesystem. This eliminates the ENOTEMPTY bug where a partial copytree failure left target_path partially populated, causing the recovery os.rename to fail and strand the original in the stale temp directory. - OverlaySandbox.get_path() now transitions ROLLED_BACK to ACTIVE, matching CopyOnWriteSandbox and the protocol transition table (ROLLED_BACK -> ACTIVE). - GitWorktreeSandbox.get_path() now accepts ROLLED_BACK status for consistency with all other sandbox implementations and the protocol transition table (ROLLED_BACK -> ACTIVE). - rollback_all now also handles sandboxes in COMMITTED status (not just ACTIVE), consistent with the state machine allowing COMMITTED -> ROLLED_BACK. - cleanup_all now catches Exception (not just SandboxError) so a single unexpected error does not abort cleanup of remaining sandboxes, consistent with _rollback_committed and rollback_all. - Restructured CHANGELOG entry from a single ~90-line paragraph into structured sub-bullets for readability. - Added BDD scenarios: no-op rollback from COMMITTED for CopyOnWriteSandbox and OverlaySandbox (zero-change commit), commit ordering verification (rollbackable before non-rollbackable). Post-review hardening round 3 (PR #1146 deep automated review): - cleanup_abandoned now catches Exception (not just SandboxError) so that unexpected errors (e.g. raw OSError, PermissionError) do not crash the loop and prevent remaining abandoned sandboxes from being cleaned up, consistent with cleanup_all, rollback_all, and _rollback_committed. - OverlaySandbox._mount_overlay() now catches subprocess.TimeoutExpired (in addition to CalledProcessError and OSError), preventing create() from leaving the sandbox in PENDING status when mount hangs beyond the timeout. - OverlaySandbox._unmount_overlay() now catches subprocess.TimeoutExpired (in addition to CalledProcessError and OSError), preventing cleanup() from leaving the sandbox in a zombie state when umount hangs beyond the timeout. - OverlaySandbox._mount_overlay() validates that overlay paths do not contain commas, which would corrupt the OverlayFS mount options string (comma is the mount option delimiter). - GitWorktreeSandbox.commit() now checks git diff return code so that a failed diff command raises CalledProcessError instead of silently concluding there are no changes and skipping the merge. - safe_restore cleanup of the temporary rollback container now runs in a finally block, preventing a temp directory leak when the rename fails and the exception is re-raised. - Fixed misleading BDD step name: "backup path that will cause copytree to fail" renamed to "backup path that will cause rename to fail" since safe_restore now uses os.rename.	2026-03-29 18:57:15 +01:00
Luis Mendes	f678d611bb	feat(db): add correction_attempts table per specification DDL ... Added CorrectionAttemptModel SQLAlchemy model with all spec-defined columns (correction_attempt_id, plan_id, original_decision_id, new_decision_id, mode, guidance, archived_artifacts_path, state, created_at, completed_at). Added FK constraints to v3_plans and decisions tables. Created Alembic migration and idx_corrections_plan index. Added repository layer for CRUD operations. Addressed code review feedback (rounds 1-12): - Replaced Any type annotations with typed CorrectionAttemptRecord signatures using TYPE_CHECKING imports. - Replaced fragile time.sleep with deterministic timestamps. - Added cascade deletion test with PRAGMA foreign_keys=ON. - Changed update_state() to accept typed enum and datetime params. - Added guidance non-empty validator with max_length=10_000. - Added spec-aligned server_default for created_at column. - Fixed timezone handling in to_domain() and from_domain(). - Added spec-defined lifecycle state transition validation via validate_correction_state_transition() domain function. - Improved FK-violation error messages in create() and update_state(). - Normalised timestamp to millisecond precision matching SQLite server_default strftime('%f') output. - Added auto-set completed_at on terminal transitions. - Added CorrectionAttemptRecord field validators (strip, non-empty). - Changed original_decision_id FK from CASCADE to RESTRICT matching spec DDL default, preserving correction audit trail. - Added input validation in update_state() for new_decision_id and archived_artifacts_path (empty/whitespace rejection). - Fixed dirty-session bug by moving validation before ORM mutations. - Extracted _SQLITE_TIMESTAMP_MS_LEN constant for timestamp truncation. Addressed thirteenth code review feedback: - Changed InvalidCorrectionStateTransitionError base class from DatabaseError to BusinessRuleViolation per CONTRIBUTING.md exception semantics (state transition is a business rule, not a database error; prevents incorrect retries by @database_retry decorator). - Changed new_decision_id FK from SET NULL to RESTRICT matching the spec DDL default (no ON DELETE clause) and consistent with the RESTRICT approach used for original_decision_id. - Changed update_state() input validation for new_decision_id and archived_artifacts_path from DatabaseError to ValueError per CONTRIBUTING.md argument validation guidelines. - Defensive to_domain() coercion now defaults corrupted state to 'failed' (terminal) instead of 'pending', preventing re-execution of completed/failed corrections with corrupted DB values. - Extracted format_sqlite_timestamp() helper and SQLITE_TIMESTAMP_MS_LEN public constant, removing duplicated timestamp formatting logic between from_domain() and update_state(). - Added code comment explaining CASCADE on plan_id FK as a codebase convention deviation from spec DDL default. - Added BDD scenario verifying RESTRICT FK on original_decision_id blocks decision deletion. - Replaced weak cross-plan isolation test with stronger two-plan scenario verifying list_by_plan returns only each plan's attempts. - Fixed hardcoded assertion in step_check_archived_path to use context variable. - 45 BDD scenarios and 5 Robot integration tests. Addressed fourteenth code review feedback: - Added ORM-level relationship(cascade="all, delete-orphan") on LifecyclePlanModel for CorrectionAttemptModel, consistent with all other v3_plans child tables, ensuring ORM-level cascade deletes work even when SQLite FK enforcement is disabled. - Added defensive to_domain() coercion for corrupted guidance column (defaults to "[corrupted]" with warning log), consistent with existing mode/state coercion pattern. - Added ValueError guard in format_sqlite_timestamp() rejecting naive datetimes per CONTRIBUTING.md fail-fast argument validation. - Fixed stale spec DDL line reference in CorrectionAttemptModel docstring. - Fixed duplicated docstring on SQLITE_TIMESTAMP_MS_LEN constant. Addressed fifteenth code review feedback: - Fixed update_state() to defensively handle corrupted DB state values via try/except ValueError coercion to FAILED terminal state with warning log, consistent with to_domain() defensive coercion pattern. - Strengthened RESTRICT FK BDD assertion to verify exception type (IntegrityError/DatabaseError) instead of only checking presence. - Split multi-When/Then cross-plan isolation BDD scenario into idiomatic single-When/Then scenarios per Gherkin best practice. - 53 BDD scenarios (was 45) and 5 Robot integration tests. ISSUES CLOSED: #920	2026-03-29 16:23:04 +01:00
brent.edwards	3abf25f17f	test: add TDD bug-capture test for #1038 — validation add --required flag (#1133) ... ## Summary Adds TDD bug-capture tests for bug #1038 — the `agents validation add` command is missing `--required`/`--informational` flags that the specification describes at line 22334 and in numerous walkthrough examples. ### Behave BDD Tests Four Behave BDD scenarios verify the correct expected behavior: 1. **`--required` flag is accepted** — invokes `validation add --config <file> --required` and asserts exit code 0 and mode `"required"` in output. 2. **`--informational` flag is accepted** — same pattern with `--informational`. 3. **`--required` overrides YAML config mode** — creates a YAML config with `mode: informational`, invokes with `--required`, and asserts the CLI output and service layer both reflect `mode: "required"`. 4. **`--informational` overrides YAML config mode** — creates a YAML config with `mode: required`, invokes with `--informational`, and asserts the CLI output and service layer both reflect `mode: "informational"`. ### Robot Framework Integration Tests Four Robot Framework integration tests exercise the same CLI paths as the Behave scenarios via a subprocess helper script: 1. **TDD Validation Add Required Flag Accepted** — verifies `--required` is recognised by the CLI. 2. **TDD Validation Add Informational Flag Accepted** — verifies `--informational` is recognised. 3. **TDD Validation Add Required Flag Overrides YAML Config** — verifies `--required` overrides a YAML config with `mode: informational`. 4. **TDD Validation Add Informational Flag Overrides YAML Config** — verifies `--informational` overrides a YAML config with `mode: required`. The helper script (`robot/helper_tdd_validation_required_flag.py`) uses `typer.testing.CliRunner` with mocked services, following the same pattern as other TDD Robot helpers (e.g., `helper_tdd_plan_apply_yes_flag.py`). ### Tags All scenarios (Behave and Robot) are tagged `@tdd_bug @tdd_bug_1038 @tdd_expected_fail`. Because the bug is still present, the underlying assertions fail (proving the bug exists) and the `@tdd_expected_fail` tag inverts the result so CI passes. Once bug #1038 is fixed, the tag must be removed. ### Spec Contradiction Note Rui Hu's investigation (issue #1038 comment #70755) found that the formal CLI reference (specification.md lines 9279–9290) does NOT include `--required`/`--informational` flags — they appear only in walkthrough examples and specification.md line 22334. Additionally, specification.md line 30761 states: "For entity registration commands (`actor add`, `skill add`, `tool add`, `validation add`, …), the YAML configuration file is the sole source of truth — the `--config` file fully defines the entity and no CLI override flags are accepted." The resolution may be to add the flags to the CLI OR to clean up the spec. This is documented in both the feature file header and step definition module docstring. ### Key Design Decisions - **YAML configs use flat `mode` key** — matches what `Validation.from_config()` actually reads (`config.get("mode", "required")`). The specification's Validation Configuration schema (specification.md line 34109) nests mode under a `validation` key, but the current `from_config()` reads a flat top-level `mode` key. A comment in the step definitions documents this discrepancy. - **Mock uses `side_effect = lambda v: v`** — the `register_tool` mock returns the actual Validation object passed by the CLI, so the CLI output reflects real CLI processing rather than hard-coded mock configuration. This prevents false positives where the mock masks an incomplete fix. - **False-positive guard** — the Then step verifying mode checks both CLI output (via `f"mode: {expected_mode}"` prefix match) AND `register_tool` call args to prevent the mock from masking an incomplete fix. - **Robot helper follows established pattern** — uses `typer.testing.CliRunner` with mocked `_get_tool_registry_service`, matching the pattern from `helper_tdd_plan_apply_yes_flag.py`. Reports real outcome (exit 0 + sentinel on bug fixed, exit 1 on bug present) and relies on `tdd_expected_fail_listener` for result inversion. - **Symmetric override scenarios** — both directions are tested: `--required` overriding informational YAML config, and `--informational` overriding required YAML config. - **Positional NAME omitted** — the bug report includes a positional NAME argument, but that is a separate spec inconsistency not under test here. - **Mutual exclusivity deferred** — testing what happens when both `--required` and `--informational` are passed simultaneously is deferred to the bug-fix PR for #1038. Closes #1102 Reviewed-on: #1133 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com> Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-03-28 18:09:27 +00:00
brent.edwards	bc6a41deb6	tdd(cli): prevent actor list from triggering database updates (#1151) ... ## Summary - Fix bug #797: `agents actor list` no longer triggers database writes (`upsert_actor`, `set_default_actor`) by removing `ensure_built_in_actors()` from `ActorRegistry.list()` and `ActorRegistry.list_actors()` - Include TDD regression tests from #841 with `@tdd_expected_fail` removed per Bug Fix Workflow - Update three existing test suites that relied on the old behavior to call `ensure_built_in_actors()` explicitly ## Root Cause `ActorRegistry.list_actors()` and `ActorRegistry.list()` both unconditionally called `self.ensure_built_in_actors()` before delegating to the actor service. `ensure_built_in_actors()` iterates all configured providers and calls `_actor_service.upsert_actor()` for each — a database WRITE operation. It may also call `_actor_service.set_default_actor()` if no default exists — another WRITE. This means every read-only `agents actor list` command triggered database writes and could prompt for pending migrations on fresh checkouts. ## Changes ### Bug Fix - **`src/cleveragents/actor/registry.py`** — Removed `self.ensure_built_in_actors()` from `list()` and `list_actors()`. Both methods now delegate directly to the service layer without triggering writes. All write-heavy methods (`add`, `upsert_actor`, `get`, `get_actor`, `remove`, `remove_actor`, `set_default_actor`, `get_default_actor`) still call `ensure_built_in_actors()`. ### TDD Tests (from #841, `@tdd_expected_fail` removed) - **`features/tdd_actor_list_no_db_update.feature`** — 2 Behave scenarios verifying `upsert_actor` and `set_default_actor` are not called during `actor list` - **`features/steps/tdd_actor_list_no_db_update_steps.py`** — Step definitions - **`robot/tdd_actor_list_no_db_update.robot`** — 2 Robot Framework integration tests - **`robot/helper_tdd_actor_list_no_db_update.py`** — Robot helper script ### Test Adjustments Three existing test suites relied on the old (buggy) behavior where `list_actors()` called `ensure_built_in_actors()`: 1. **`features/consolidated_actor.feature`** — Scenario updated to explicitly call `ensure_built_in_actors()` before `list_actors()` 2. **`features/steps/tdd_actor_list_validation_steps.py`** + **`robot/helper_tdd_actor_list_validation.py`** (bug #592) — Updated to call `ensure_built_in_actors()` explicitly before CLI invocation 3. **`features/steps/actor_list_empty_steps.py`** (bug #592) — Updated with explicit `ensure_built_in_actors()` call and capturing upsert pattern ## Quality Gates | Gate | Result | |------|--------| | `nox -e lint` | ✅ Pass | | `nox -e typecheck` | ✅ Pass (0 errors) | | `nox -e unit_tests` | ✅ Pass (468 features, 12367 scenarios, 0 failures) | | `nox -e integration_tests` | ⚠️ 6 pre-existing failures (timeouts/OOM) | | `nox -e coverage_report` | ✅ 98% (>= 97% threshold) | The 6 integration test failures are pre-existing infrastructure issues (SIGTERM/SIGKILL timeouts) unrelated to this change: Container Resolve Crash (3), M3 E2E Verification (2), Resource CLI (1). Closes #797 Reviewed-on: #1151 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com> Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-03-28 05:27:14 +00:00
brent.edwards	b59100cc6c	test: add TDD bug-capture test for #1141 — session create persistence (#1144) ... ## Summary Adds TDD bug-capture coverage for bug #1141 (`session create` -> `session list` lifecycle) on metadata branch `tdd/m3-session-create-persist`. ### What changed - Added Behave bug-capture feature: `features/tdd_session_create_persist.feature` - Required tags: `@tdd_bug @tdd_bug_1141 @tdd_expected_fail` - Scenario path: `init --force --yes` -> `session list --format json` -> `session create` -> `session list --format json` - Added Behave step definitions: `features/steps/tdd_session_create_persist_steps.py` - Uses root CLI app (`cleveragents.cli.main:app`) for realistic command routing - Asserts expected list totals; underlying assertion intentionally fails while bug is present - Added Robot E2E bug-capture test: `robot/e2e/e2e_session_create_persist.robot` - Required tags: `E2E`, `tdd_expected_fail`, `tdd_bug`, `tdd_bug_1141` - Includes explicit in-file note to remove `tdd_expected_fail` when #1141 is fixed - Updated changelog (`CHANGELOG.md`, Unreleased) ### Notes - The issue subtask referenced `robot/e2e/e2e_session_lifecycle.robot`, which is not present on current `master`; equivalent E2E coverage is implemented in `robot/e2e/e2e_session_create_persist.robot`. - The branch was force-updated to remove stale merge-based history and keep an atomic, rebase-clean commit for this issue. ## Quality gates | Gate | Result | |---|---| | `nox -s lint` | ✅ pass | | `nox -s typecheck` | ✅ pass | | `nox -s unit_tests -- features/tdd_session_create_persist.feature` | ✅ pass (TDD inversion active; underlying assert fails) | | `nox -s integration_tests -- robot/e2e/e2e_session_create_persist.robot` | ✅ pass | | `nox -s e2e_tests` | ✅ pass | | `nox -s coverage_report` | ✅ pass (97.66173849218832%) | | `nox` (full default suite) | ✅ pass | ## Related issue Closes #1142 Reviewed-on: #1144 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com> Co-authored-by: Brent Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent Edwards <brent.edwards@cleverthis.com>	2026-03-28 04:34:47 +00:00
brent.edwards	10df485401	test: add TDD bug-capture test for #1039 — missing validation YAML (#1132) ... ## Summary This PR adds a Behave TDD bug-capture test that proves bug #1039 exists: the specification references `validations/unit-tests.yaml` as an example validation configuration file (Workflow Examples, Example 1, Step 1) but the file does not exist in the project's `examples/validations/` directory. ## Changes - **New feature file:** `features/tdd_missing_validation_unit_tests_yaml.feature` — four scenarios tagged `@tdd_expected_fail @tdd_bug @tdd_bug_1039` that verify: 1. The file `examples/validations/unit-tests.yaml` exists 2. The YAML config contains `name: local/unit-tests` 3. The validation mode is `required` 4. The description field is non-empty - **New step file:** `features/steps/tdd_missing_validation_unit_tests_yaml_steps.py` — step implementations that locate the project root and check file existence/content All four scenarios currently fail with `AssertionError` (the file doesn't exist, proving the bug exists). The `@tdd_expected_fail` tag inverts the results so the test suite passes CI. ## Robot Integration Test N/A — this bug is purely about a missing example file referenced by the specification. There is no integration-level behavior to test. ## Quality Gate Results | Gate | Result | |------|--------| | `nox -s lint` | passed | | `nox -s typecheck` | passed (0 errors) | | `nox -s unit_tests` | 462 features, 12234 scenarios, 0 failures | | `nox -s integration_tests` | 1672 tests, 0 failures | | `nox -s e2e_tests` | 37 tests, 0 failures | | `nox -s coverage_report` | 98% (>= 97% threshold) | Closes #1103 Reviewed-on: #1132 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com> Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-03-28 04:15:49 +00:00
brent.edwards	26632f79e9	test: add TDD bug-capture test for #1079 — project context set missing flag (#1130) ... ## Summary This PR adds TDD bug-capture tests for bug #1079 (`project context set` missing `--execution-env-priority` flag). Per the Bug Fix Workflow in CONTRIBUTING.md, the first step in fixing any bug is to write a test that proves the bug exists. ### What was done - **Behave unit tests** (6 scenarios in `features/project_context_set_exec_env_priority.feature`): - `project context set --execution-env-priority override` with `--execution-environment` should succeed and persist - `project context set --execution-env-priority fallback` with `--execution-environment` should succeed and persist - `--execution-env-priority` without `--execution-environment` should be rejected - Default to `fallback` when only `--execution-environment` is specified - Invalid `--execution-env-priority` value should be rejected - `project context show` should reflect persisted `execution_env_priority` in JSON output - **Robot integration tests** (3 test cases in `robot/project_context_set_exec_env_priority.robot`): - Override acceptance with persistence verification - Fallback acceptance with persistence verification - Full round-trip persistence check All tests are tagged `@tdd_bug @tdd_bug_1079 @tdd_expected_fail`. The underlying assertions fail (confirming the bug exists — `--execution-env-priority` is "No such option"), and the `@tdd_expected_fail` tag inverts the result so CI passes. ### Bug confirmed The `context_set()` function in `cleveragents.cli.commands.project_context` does not accept `execution_env_priority` as a parameter. The specification (§Execution Environment Routing, precedence table) requires this flag at precedence level 2 for project-level execution environment priority control. ### Quality gates | Gate | Result | |------|--------| | `nox -s lint` | PASS | | `nox -s typecheck` | PASS (0 errors) | | `nox -s unit_tests` | PASS (12236 scenarios, 0 failed) | | `nox -s integration_tests` | My 3 tests pass (13 pre-existing failures) | | `nox -s coverage_report` | PASS (98%, threshold 97%) | Closes #1100 Reviewed-on: #1130 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com> Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-03-28 02:14:55 +00:00
brent.edwards	b46a0e6102	feat(plan): implement real revert-mode re-execution from decision point (#1153) ... ## Summary Implements the full revert-mode re-execution pipeline from the specification (§ Correction Flow, Revert Mode), enabling `agents plan correct --mode=revert` to truly re-execute from the targeted decision point rather than only logically marking decisions as superseded. ### Changes - **Resource rollback**: `CorrectionService.execute_revert` now delegates to `CheckpointService.rollback_to_checkpoint` when a decision-aligned checkpoint exists, performing real `git reset --hard` in the sandbox. Gracefully degrades when checkpointing is unavailable. - **Reasoning rollback**: Extracts `actor_state_ref` from the target decision's `ContextSnapshot` for downstream LangGraph actor restoration. - **Guidance injection**: Generates a `user_intervention` decision ID for callers to record correction guidance in the decision tree. - **Phase transition**: Signals that the plan should re-enter Strategize via `phase_transition_target="strategize"` on the result. - **Model extension**: Added `checkpoint_restored`, `actor_state_ref`, `user_intervention_decision_id`, and `phase_transition_target` fields to `CorrectionResult` with backward-compatible defaults. - **Dispatch update**: `execute_correction` now accepts and forwards a `decisions` parameter. ### Design Approach Uses a signal-based architecture: rather than having `CorrectionService` directly manipulate plan state or LangGraph actors, the enhanced `execute_revert` returns signal fields on `CorrectionResult` that downstream consumers use for the full pipeline. This preserves separation of concerns. ### Tests - **Behave**: 16 new BDD scenarios in `features/revert_re_execution.feature` - **Robot**: 7 integration tests in `robot/revert_re_execution.robot` - **Coverage**: 98% (above 97% threshold) ### Quality Gates | Gate | Status | |------|--------| | `nox -s lint` | Pass | | `nox -s typecheck` | Pass (0 errors) | | `nox -s unit_tests` | Pass (12376 scenarios, 0 failed) | | `nox -s integration_tests` | Pass (1631 passed, 3 pre-existing failures #647) | | `nox -s e2e_tests` | Pass (37 passed) | | `nox -s coverage_report` | Pass (98%) | Closes #844 Reviewed-on: #1153 Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-03-28 00:57:51 +00:00
brent.edwards	efacfd61c3	test: add TDD bug-capture test for #1023 — implicit init requirement (#1113) ... ## Summary Adds TDD bug-capture tests proving that CLI commands (`resource add`, `project create`) fail in a fresh environment without explicit `agents init`, even when `CLEVERAGENTS_AUTO_APPLY_MIGRATIONS=true` is set. Bug #1023 reports that `CLEVERAGENTS_AUTO_APPLY_MIGRATIONS=true` triggers schema migrations on an existing database but does NOT create the database file or its parent directory structure, causing `sqlite3.OperationalError: unable to open database file`. ## Changes ### Behave Tests - `features/tdd_e2e_implicit_init.feature` — Two scenarios tagged `@tdd_expected_fail @tdd_bug @tdd_bug_1023`: - `resource add` in a fresh environment without prior init - `project create` in a fresh environment without prior init - Both scenarios include output content assertions - `features/steps/tdd_e2e_implicit_init_steps.py` — Step definitions using Typer's CliRunner with real CLI invocation in a pristine temp directory. - Env isolation: saves/removes `CLEVERAGENTS_AUTO_APPLY_MIGRATIONS`, `CLEVERAGENTS_DATABASE_URL`, `CLEVERAGENTS_TEST_DATABASE_URL`, `CLEVERAGENTS_HOME`, `BEHAVE_TESTING`, `CLEVERAGENTS_TEMPLATE_DB`, `CLEVERAGENTS_TESTING_USE_MOCK_AI` - CliRunner invoked without `catch_exceptions=False` to ensure proper `@tdd_expected_fail` inversion ### Robot Tests - `robot/tdd_e2e_implicit_init.robot` — Two test cases tagged `tdd_bug tdd_bug_1023 tdd_expected_fail` (listener inverts results while bug is unfixed). - `robot/helper_tdd_e2e_implicit_init.py` — Helper script exercising CLI in a fresh environment. - Env isolation includes `ROBOT_TESTING`, `CLEVERAGENTS_TEMPLATE_DB`, `CLEVERAGENTS_TESTING_USE_MOCK_AI` - Env restoration in `finally` block ensures cleanup even on exceptions - CliRunner invoked without `catch_exceptions=False` for correct inversion ### Changelog - Updated `CHANGELOG.md` with entry for this TDD test addition. ## Quality Gates | Gate | Result | |------|--------| | `nox -s lint` | PASS | | `nox -s typecheck` | PASS (0 errors) | | `nox -s unit_tests` | PASS (462 features, 12232 scenarios, 0 failed) | | `nox -s integration_tests` | PASS (pre-existing failures only; our suite correct) | | `nox -s e2e_tests` | N/A (TDD test only, no E2E suite changes) | | `nox -s coverage_report` | PASS (98% coverage, threshold 97%) | Closes #1033 Reviewed-on: #1113 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com> Co-authored-by: Brent Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent Edwards <brent.edwards@cleverthis.com>	2026-03-28 00:30:26 +00:00
brent.edwards	b51df2ee0f	feat(server): add Kubernetes Helm chart for server deployment (#1085) ... ## Summary This PR adds Kubernetes Helm deployment support for the CleverAgents server. Closes #928 ### What this PR includes - Helm chart under `k8s/` with Deployment, Service, optional Ingress, ConfigMap, ServiceAccount, Secrets, NOTES, and optional Redis subchart configuration. - Multi-stage `Dockerfile.server` for server runtime deployment. - Deployment-focused docs in `k8s/README.md`. - Behave + Robot + benchmark coverage for chart/deployment wiring. ### Review fixes applied (cycle 11 — hurui200320 review #2687) **Critical fix:** 1. **CI SHA256 checksum verification fixed** — All 3 Helm install blocks (`unit_tests`, `integration_tests`, `helm` jobs) now save the tarball using its original filename (`helm-v3.16.4-linux-amd64.tar.gz`) instead of `helm.tgz`, so the `.sha256sum` file can correctly locate and verify it. This was causing all 3 CI Helm jobs to fail with "No such file or directory". **Major fixes (test coverage gaps):** 2. **405 Allow header now tested** — The existing "POST to known path returns method not allowed" scenario now asserts that the `Allow: GET` header is present. Added a second 405 scenario testing `POST /live` for broader `_KNOWN_PATHS` coverage (review item #11). 3. **Security-hardening headers now tested** — New scenario "HTTP responses include security-hardening headers" verifies `content-length`, `x-content-type-options: nosniff`, and `cache-control: no-store` headers are present on HTTP responses. 4. **Lifespan warning logging now tested** — New scenario "Unrecognised lifespan message type logs warning and continues" queues `lifespan.startup` → `lifespan.bogus` → `lifespan.shutdown` and verifies: (a) the app completes the lifespan cycle cleanly, (b) a warning is logged mentioning the unrecognised type. ### Review fixes applied (cycle 10) **Critical/Major fixes (from hurui200320's prior REQUEST_CHANGES):** 1. **Rebased branch onto master** — Removed merge commit per CONTRIBUTING.md rebase-only policy. Clean linear history restored. 2. **Fixed commit message body** — Replaced literal `\n` sequences with actual newlines. `ISSUES CLOSED: #928` footer is now on its own line after a blank separator. 3. **Moved uvicorn import to module top level** — `from uvicorn import run as uvicorn_run` is now at the top of `src/cleveragents/cli/commands/server.py` per Import Guidelines. Updated test mock target from `uvicorn.run` to `cleveragents.cli.commands.server.uvicorn_run`. 4. **Added SHA256 checksum verification** — All three Helm CLI install blocks in `.forgejo/workflows/ci.yml` now download and verify `helm.sha256sum` before extracting the binary. **Minor fixes:** 5. **Added `Dockerfile.server` build to CI** — New "Build Docker image (Server)" step in the `docker` job validates the server Dockerfile. 6. **ASGI 405 Method Not Allowed** — Known paths (`/`, `/live`, `/ready`, `/health`) now return 405 with `Allow: GET` header for non-GET methods, per RFC 9110 §15.5.6. Added `_KNOWN_PATHS` frozenset. 7. **WebSocket close protocol fix** — App now calls `await receive()` to consume the `websocket.connect` event before closing. Changed close code from 1000 (Normal Closure) to 1008 (Policy Violation). 8. **Lifespan handler logging** — Unrecognised lifespan message types are now logged as warnings instead of silently consumed. 9. **Security-hardening headers** — `_send_response` now includes `content-length`, `x-content-type-options: nosniff`, and `cache-control: no-store` on all HTTP responses. 10. **`.dockerignore` credential patterns** — Added `*.pem`, `*.key`, `*.p12`, `*.pfx`, `credentials*.json`. 11. **`--log-level` validation** — Constrained to `click.Choice(["critical", "error", "warning", "info", "debug", "trace"])` for clean CLI validation errors. 12. **Reverted unrelated semgrep pre-commit change** — `pass_filenames` and `entry` restored to original values per atomic commit hygiene. 13. **Removed unused `ReceiveCallable` type alias** and `Callable`/`Awaitable` imports from `asgi_app_steps.py`. 14. **Fixed redundant `shutil.which("helm")` check** — `_skip_if_helm_missing` now returns `bool` to eliminate the duplicate check in `_render_chart`. 15. **Improved test deque error handling** — Lifespan test receive mock now raises descriptive `AssertionError` instead of opaque `IndexError`. 16. **Scope type dispatch** — Changed `if/if/if` to `if/elif/elif` for mutually exclusive ASGI scope types. 17. **Dockerfile.server base image** — Standardised to `python:3.13-slim` (floating minor) consistent with CLI Dockerfile. 18. **Dockerfile layer caching** — Split `uv pip install build` and `python -m build` into separate `RUN` instructions. 19. **Removed extraneous double blank line** in Dockerfile.server. ### Deferred items (acknowledged, not in scope) - PodDisruptionBudget, HorizontalPodAutoscaler, NetworkPolicy — Follow-up for production hardening. - `appVersion: "1.0.0"` placeholder — Needs tracking issue for release versioning alignment. - Readiness probe with downstream dependency checks — Documented limitation. - Cross-system test for probe paths matching ASGI routes — Test enhancement. - Improved benchmarks (helm template timing vs PyYAML parsing) — Benchmark quality improvement. - CI DRY violation (Helm install 3×) — Code quality improvement, consider composite action. - File length limits exceeded (`k8s_helm_chart_steps.py` 551 lines, `helper_k8s_helm_chart.py` 678 lines) — Non-blocking, can be split in follow-up. - `runAsGroup: 1000` in pod security context — Defense-in-depth improvement. - HEAD method support on known paths — RFC compliance, does not affect K8s probes. - `click.Choice` log-level validation via CLI runner test — Test gap. ### Scope note: status-check CI gate The `status-check` job now includes `integration_tests`, `e2e_tests`, and `helm` in its `needs` list. The `helm` job is new in this PR. The `integration_tests` and `e2e_tests` additions fix previously-missing gate checks — included here since this PR modifies both of those jobs to install Helm. ### Quality gates - `nox -e lint` ✅ - `nox -e typecheck` ✅ - `nox -e unit_tests` ✅ (12,321 scenarios passed, 4 skipped) - `nox -e integration_tests` — 3 pre-existing failures in unrelated areas (plan correction, resource types) - `nox -e e2e_tests` — pre-existing failures (LLM API keys not available in local env) - `nox -e coverage_report` ✅ (**97.7%**) Reviewed-on: #1085 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com> Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-03-27 23:53:22 +00:00
brent.edwards	3fa07fb772	test: align #1080 expected-fail tags with TDD schema ... Add @tdd_issue and @tdd_issue_1080 so the expected-fail scenario passes the global tag validator during unit_tests.	2026-03-27 22:53:33 +00:00
brent.edwards	5ac1e4eeb3	test: add TDD bug-capture test for #1080 — execution env resolution precedence ... Write a Behave feature (features/tdd_exec_env_resolution_precedence.feature) with three scenarios that capture bug #1080: the ExecutionEnvironmentResolver does not honour the 6-level execution environment precedence chain defined in the spec (§Execution Environment Routing). The critical scenario ("Project-level override beats plan-level fallback") demonstrates the bug by calling resolve() with plan_env="host" and project_env="container", where the project has priority "override" and the plan has priority "fallback". Per the spec, project override (level 2) should beat plan fallback (level 4), but the current flat resolver chain returns "host" (plan always wins). The @tdd_expected_fail tag inverts this assertion failure to a CI pass. Two regression-guard scenarios (without @tdd_expected_fail) verify: (1) Plan-level override still beats project-level override (level 1 vs 2). (2) Project-level override beats host default (level 2 vs 6). Both pass both competing environments to the resolver to ensure the resolver sees the full context and must choose correctly. Files added: - features/tdd_exec_env_resolution_precedence.feature — tagged with @tdd_bug @tdd_bug_1080 @mock_only and one @tdd_expected_fail scenario - features/steps/tdd_exec_env_resolution_precedence_steps.py — step definitions with priority validation, TODO markers for #1080 cleanup, and module-level imports Robot test: N/A — ExecutionEnvironmentResolver is a pure domain service with no I/O or integration boundaries. ISSUES CLOSED: #1101	2026-03-27 22:53:33 +00:00
brent.edwards	69e2d1f179	test(tdd): add required issue tags for expected-fail session leak test ... Use @tdd_issue and @tdd_issue_987 so the TDD tag validation hook accepts this expected-fail bug-capture feature and unit tests can execute normally.	2026-03-27 22:01:03 +00:00
brent.edwards	a5888a08b7	test: add TDD bug-capture test for #987 — AutomationProfileRepository session leak ... Add a Behave feature with four scenarios that capture the session leak bug in AutomationProfileRepository. The upsert() and delete() methods commit when auto_commit is True but never call session.close() in a finally block, leaking database sessions. SessionRepository correctly uses finally: if self._auto_commit: db_session.close() in every method — AutomationProfileRepository does not. The test uses a _TrackingSession subclass of sqlalchemy.orm.Session that records whether close() was called, providing direct assertion of the bug. Four scenarios cover: (1) upsert success path, (2) delete success path, (3) upsert error path, (4) delete error path. All scenarios are tagged @tdd_expected_fail @tdd_bug @tdd_bug_987 so CI passes while the bug remains unfixed. Fixes from review: - M1: Added 4th scenario for delete() error path - M2: Registered engine.dispose() in _cleanup_handlers for all scenarios - M3: Registered session.close() in _cleanup_handlers; explicitly close setup session in step_given_persisted_profile - M4: Replaced type: ignore annotations with proper subclass pattern (_TrackingSession uses **kwargs: Any; _FailingFlushTrackingSession overrides flush() instead of monkey-patching) - M5: Moved OperationalError import from function body to module level Robot integration tests are N/A — this is purely a unit-level session lifecycle bug within a single repository class. ISSUES CLOSED: #1092	2026-03-27 22:01:03 +00:00
brent.edwards	8b8942817c	feat(wf03): add plan prompt test coverage and confidence-threshold pausing verification	2026-03-27 13:35:17 -07:00
brent.edwards	3c6b6b54b2	Merge remote-tracking branch 'origin/master' into tdd/m5-container-mount-flag	2026-03-27 20:16:41 +00:00
hamza.khyari	c5324e5fee	Merge pull request 'test(integration): workflow example 4 — multi-project dependency update (supervised profile)' (#1043) from test/int-wf04-multi-project into master ... Reviewed-on: #1043	2026-03-27 15:07:47 +00:00
hamza.khyari	0569aaa51c	test(integration): workflow example 4 — multi-project dependency update (supervised profile) ... Robot Framework integration test suite for Specification Workflow Example 4: Multi-Project Dependency Update. Exercises the supervised automation profile with 4 projects (common-lib + 3 microservices), child plan spawning, dependency-ordered execution, and coordinated apply. - 8 test cases covering: project registration, action creation, plan use with supervised profile, strategize with DEPENDENCY_ORDERED config, child plan spawning (4 children), dependency-ordered execution (common-lib first), coordinated apply, and full end-to-end lifecycle - Multi-project scope initialization, changeset recording, and cross-project validation via MultiProjectService - Shared validation (local/pytest-mypy) registered and attached to all 4 projects per spec §Workflow Example 4 - Uses mocked LLM providers (CLEVERAGENTS_TESTING_USE_MOCK_AI=true) - All Run Process calls have timeout=60s on_timeout=kill (120s for full lifecycle) - _NoClose wrapper calls rollback() to match established _SafeSession pattern; child IDs generated via ULID() instead of hardcoded ISSUES CLOSED: #768	2026-03-27 14:50:11 +00:00
hamza.khyari	dc1481a44e	Merge pull request 'fix(cli): implement --mount flag on resource add container-instance' (#1134) from bugfix/m8-container-mount-flag into master ... Reviewed-on: #1134 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com>	2026-03-27 13:26:27 +00:00
hamza.khyari	ebafe8cddd	fix(cli): implement --mount flag on resource add container-instance ... Add --mount flag to 'resource add container-instance' supporting both resource-reference mounts (--mount local/api-repo:/workspace) and host-path mounts (--mount /var/config:/config:ro). - _parse_mount_spec() parses SOURCE:TARGET and SOURCE:TARGET:MODE formats - Resource-reference mounts (containing /) get type='resource', mode='rw' - Host-path mounts support explicit rw/ro mode - Mounts stored as JSON string in resource properties['mounts'] - _format_properties() renders mounts in human-readable format for 'resource show' - Added mount to container-instance cli_args metadata - 6 Behave scenarios testing single mount, dual mount, persistence, and error paths - Updated CHANGELOG ISSUES CLOSED: #1078	2026-03-27 12:57:03 +00:00
hamza.khyari	0762815e84	Merge pull request 'feat(lsp): add missing LspCapability enum values' (#1063) from feature/lsp-capability-enum into master ... Reviewed-on: #1063 Reviewed-by: Rui Hu <rui.hu@cleverthis.com>	2026-03-27 12:12:07 +00:00
hamza.khyari	6a8f724299	feat(lsp): add missing LspCapability enum values ... Align LspCapability enum with the spec's 11-capability set (docs/specification.md lines 20705-20717): Renamed: TYPE_INFO -> HOVER, SYMBOLS -> DOCUMENT_SYMBOLS, FORMAT -> FORMATTING Added: DEFINITIONS, SIGNATURE_HELP, WORKSPACE_SYMBOLS Updated LspToolAdapter._CAPABILITY_TOOL_MAP (11 entries): - code_actions suffix -> code-actions (hyphen per spec) - RENAME gets dedicated schema with new_name parameter - workspace_symbols gets query-based schema Updated _input_schema_for() with 4 schema categories extracted to module-level constants: file-only, position-based, rename (with new_name), and query-based. Added defensive ValueError for unmapped capabilities. Added additionalProperties: false. Extended LspClient.initialize() to advertise all 11 capabilities in the initialize request (hover, definition, references, rename, codeAction, formatting, signatureHelp, documentSymbol, workspace symbol). Fixed _make_runtime_handler() to handle workspace_symbols as query-only input (no file_path required), resolving the schema/handler contract mismatch. Fixed stale references: type_info -> hover, symbols -> document_symbols in test fixtures, feature files, CLI docstring. Updated docs/reference/lsp.md and CHANGELOG.md. Behave tests (38 scenarios): enum completeness, tool spec generation with structural validation, input schema per category, all 11 stubbed provider keys, negative tests for invalid capability and defensive ValueError branch. ISSUES CLOSED: #834	2026-03-27 11:10:56 +00:00
hamza.khyari	83f671f9ec	Merge pull request 'feat(resource): implement ResourceHandler sandbox and checkpoint methods' (#1067) from feature/resource-handler-sandbox into master ... Reviewed-on: #1067 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com>	2026-03-27 11:08:53 +00:00
hamza.khyari	7bb77aee5c	feat(resource): implement ResourceHandler sandbox and checkpoint methods ... Extend the ResourceHandler protocol with four sandbox/lifecycle methods: create_sandbox (idempotent), create_checkpoint, rollback_to, project_access. Fixes from self-review: - Instance-level checkpoint dict instead of ClassVar (no shared state) - Git rollback uses 'git reset --hard' + 'git clean -fd' (not just checkout) - FsDirectory rollback skips .git to preserve git metadata - project_access separates ImportError (local mode) from ValueError (reject) - Added discard_checkpoints() cleanup method - Git rollback test verifies file content restored ISSUES CLOSED: #836	2026-03-27 10:50:15 +00:00
hurui200320	1878998b7a	refactor(testing): rename tdd_bug/tdd_bug_N tags to tdd_issue/tdd_issue_N ... Rename the TDD tag system from tdd_bug/tdd_bug_<N> to tdd_issue/tdd_issue_<N> across the entire codebase. The tdd_expected_fail tag is unchanged. The TDD expected-failure workflow is not limited to bug fixes — it applies equally to any issue type (features, tasks, refactors). The _bug suffix was misleading and narrowed the perceived scope. The new _issue suffix accurately reflects that the TDD tagging system applies to any Forgejo issue. Changes span 92 files: - features/environment.py: validate_tdd_tags(), should_invert_result(), and apply_tdd_inversion() updated — regex, variables, error messages - robot/tdd_expected_fail_listener.py: _validate_tdd_tags(), _should_invert_result(), start_test(), end_test() updated consistently - 33 Behave .feature files: all @tdd_bug/@tdd_bug_<N> tags renamed - 29 Robot .robot files: all tdd_bug/tdd_bug_<N> tags renamed - 3 Robot fixture files renamed (tdd_bug_alone, tdd_missing_tdd_bug, tdd_expected_fail_missing_bug_n) with content and references updated - Tag validation tests and helpers updated (function names, command dispatch keys, output strings, fixture references) - CONTRIBUTING.md: section renamed from 'TDD Bug Test Tags' to 'TDD Issue Test Tags', all tag references and examples updated - noxfile.py: comment references updated - Step definition files, mock helpers, and benchmark files: docstring references updated ISSUES CLOSED: #965	2026-03-27 05:58:35 +00:00
Luis Mendes	d196e90779	test(integration): workflow example 14 — server mode team collaboration (supervised profile) ... Implemented Robot Framework integration test suite validating the server mode team collaboration workflow (Specification Example 14) with mocked LLM providers and in-memory domain services. Tests cover server mode configuration, config-registry diagnostics, namespace management, action publishing to team namespaces with namespaced actor references, shared action consumption via use_action(), and namespace-filtered plan monitoring across namespaces. Uses standard integration test infrastructure with mock AI. Post-review fixes applied: - F1: plan_namespace() now creates actions, calls use_action() to instantiate plans, and verifies namespace-filtered listing with non-empty results - F2: Renamed actor_namespace() to action_actor_refs() with accurate docstring (tests action actor field references, not ActorService) - F3: Added use_shared_action() subcommand covering spec Step 3 (use a shared action to create a plan and verify namespace inheritance) - F5: Updated diagnostics() docstring to accurately describe scope (config registry verification, not full diagnostic operations) - F7: Fixed _COMMANDS type from dict[str, object] to dict[str, Callable] removing type: ignore suppression - F9: Extracted _make_config_service() factory to remove duplicated tempdir creation pattern - F10: Added [Tags] to all Robot test cases for filtering support - F11: Added automation_profile="supervised" to all create_action() calls for spec consistency - M1: Fixed CHANGELOG wording from "mocked server backend" to "in-memory domain services" to accurately describe the test approach - M5: Added symmetric phase and action_name assertions for beta plan in plan_namespace() to match alpha plan verification depth - M6: Added strategy_actor and review_actor assertions after get_action() in action_actor_refs() for complete actor field persistence verification - M8: Added core.namespace default value verification ("local") in diagnostics() subcommand - L2: Added total unfiltered action count verification in shared_actions() - L3: Added distinguishing tags (publish/shared) to disambiguate Robot test cases with previously identical tag sets - L4: Added ActionState.AVAILABLE assertion for all actions in shared_actions() for consistency with action_namespace() ISSUES CLOSED: #778	2026-03-26 22:33:19 +00:00
CoreRasurae	80f1664a0d	test(integration): workflow example 7 — CI/CD integration, automated PR review and fix (ci profile) ... Implemented Robot Framework integration test suite validating the CI/CD workflow (Specification Example 7). Tests cover ci-profile configuration (automation-profile, format, log level), idempotent resource and project registration with duplicate-detection assertions, three validation tools (ci-lint, ci-typecheck, ci-tests) registration and resource attachment via ToolRegistryService, action creation with typed arguments and invariants per spec Step 2, plan lifecycle with phase-by-phase completion through all phases (strategize, execute, apply) until terminal applied state, and JSON output structure verification including plan_id, phase, state, action, projects, and arguments fields. Post-review fixes applied (round 1): - H1: Fix truncated invariant #2 text to match spec line 39051 - H2: Fix definition_of_done to match spec's 5-bullet-point format - M1: Register all 3 spec validations (ci-lint, ci-typecheck, ci-tests) - M3: Add branch property to resource registration per spec Step 3 - M4: Replace phantom resource_id with real registered resource - M5: Add projects and arguments field assertions to JSON output test - M7: Replace 'polling-based' with 'phase-by-phase' in docs/comments - L1: Use timezone-aware datetime (timezone.utc) - L2: Use tempfile for resource path instead of hardcoded /tmp - L3: Clarify json_output() docstring to reflect as_cli_dict() scope - L4: Tighten attachment count assertion from >= 1 to == 1 (now == 3) Post-review fixes applied (round 2): - M2: Use Setup Test Environment With Database Isolation for pabot safety - L1: Replace remaining hardcoded /tmp paths with tempfile (validation_attach, resource_idempotent duplicate registration) - L2: Fix stale 'Polling-based' comment missed in round 1 - L5: Align action description with spec line 39027 - M1/L3/L6: Document automation_profile propagation gap in use_action() with TODO for when production code wires the field onto Plan - L4: Add comment explaining local actor name deviation from spec Includes CHANGELOG update describing the integration test scope. ISSUES CLOSED: #771	2026-03-26 21:42:37 +00:00
CoreRasurae	8ad156f5e1	build(nox): Expose ENV var to build pre-migrated database template	2026-03-26 19:35:54 +00:00