fix(cli): implement --mount flag on resource add container-instance #1134

Merged

hamza.khyari merged 1 commit from bugfix/m8-container-mount-flag into master 2026-03-27 13:26:27 +00:00

Conversation 2 Commits 1 Files changed 5 +322 -12

hamza.khyari commented 2026-03-23 13:17:02 +00:00

Member

Copy link

Summary

Implements --mount flag on resource add container-instance per spec WF17.

Mount Formats

• Resource-reference: --mount local/api-repo:/workspace (type=resource, mode=rw)
• Host-path: --mount /var/config:/config:ro (type=bind, mode=rw|ro)
• Multiple --mount flags supported on a single command

Changes

• _parse_mount_spec() parses both formats with validation
• Mounts stored as JSON string in properties["mounts"]
• _format_properties() renders mounts in human-readable format for resource show
• Added mount to container-instance cli_args metadata
• 6 Behave BDD scenarios
• Updated CHANGELOG

Example

agents resource add container-instance local/ctr --image node:18 \
    --mount local/api-repo:/workspace \
    --mount /var/shared/config:/config:ro

ISSUES CLOSED: #1078

## Summary Implements `--mount` flag on `resource add container-instance` per spec WF17. ## Mount Formats - Resource-reference: `--mount local/api-repo:/workspace` (type=resource, mode=rw) - Host-path: `--mount /var/config:/config:ro` (type=bind, mode=rw|ro) - Multiple `--mount` flags supported on a single command ## Changes - `_parse_mount_spec()` parses both formats with validation - Mounts stored as JSON string in `properties["mounts"]` - `_format_properties()` renders mounts in human-readable format for `resource show` - Added `mount` to container-instance `cli_args` metadata - 6 Behave BDD scenarios - Updated CHANGELOG ## Example ```bash agents resource add container-instance local/ctr --image node:18 \ --mount local/api-repo:/workspace \ --mount /var/shared/config:/config:ro ``` ISSUES CLOSED: #1078

hamza.khyari added the

State

In Review

Type

Bug

labels 2026-03-23 13:34:39 +00:00

hamza.khyari self-assigned this 2026-03-23 13:37:01 +00:00

freemo approved these changes 2026-03-24 15:25:20 +00:00

Dismissed

freemo left a comment

Copy link

Review: APPROVED with Comments

Well-structured PR with clean implementation of mount parsing, good error handling via typer.BadParameter, and 6 BDD scenarios. The code follows existing project patterns. Approving, but please address the following items (some are important).

Issues to Address

1. Logic bug in _parse_mount_spec() — / heuristic for type inference. At the 2-part parsing branch, the code uses "/" in parts[0] to determine type: "resource" vs type: "bind". This means --mount /data:/app (a valid 2-part absolute host-path) will be misclassified as type: "resource" because /data contains /. A resource name like local/api-repo also contains /, so the heuristic is ambiguous. Consider: parts[0].startswith("/") → bind; else → resource. Or require 3-part format for host paths.

2. No milestone assigned. The branch is prefixed bugfix/m8-*, strongly suggesting it belongs to Milestone 8. Per CONTRIBUTING.md requirement #11, a milestone is mandatory. Please assign before merge.

3. Merge conflicts. mergeable: false — needs a rebase against master.

4. Metadata mismatch. _resource_registry_data.py adds a single mount field (singular, type string) in cli_args, but the CLI stores mounts (plural) as a JSON array in properties. The metadata key and the actual property key are inconsistent.

Minor Notes

5. No test for the / heuristic ambiguity — e.g., --mount /data:/app (2-part host path) is never tested, so the misclassification goes undetected. Adding this test case would catch the bug in item #1.

6. _NoClose wrapper in test steps is clever but opaque. A docstring comment explaining why session.close() is suppressed (to keep in-memory SQLite alive) would help future readers.

7. Mounts stored as a JSON string inside a dict value is a serialization-within-serialization pattern. If properties is itself JSON-serialized to the DB, this results in double-encoded JSON. Worth considering a cleaner schema in a future iteration.

## Review: APPROVED with Comments Well-structured PR with clean implementation of mount parsing, good error handling via `typer.BadParameter`, and 6 BDD scenarios. The code follows existing project patterns. Approving, but please address the following items (some are important). ### Issues to Address 1. **Logic bug in `_parse_mount_spec()` — `/` heuristic for type inference.** At the 2-part parsing branch, the code uses `"/" in parts[0]` to determine `type: "resource"` vs `type: "bind"`. This means `--mount /data:/app` (a valid 2-part absolute host-path) will be misclassified as `type: "resource"` because `/data` contains `/`. A resource name like `local/api-repo` also contains `/`, so the heuristic is ambiguous. Consider: `parts[0].startswith("/")` → bind; else → resource. Or require 3-part format for host paths. 2. **No milestone assigned.** The branch is prefixed `bugfix/m8-*`, strongly suggesting it belongs to Milestone 8. Per CONTRIBUTING.md requirement #11, a milestone is mandatory. Please assign before merge. 3. **Merge conflicts.** `mergeable: false` — needs a rebase against master. 4. **Metadata mismatch.** `_resource_registry_data.py` adds a single `mount` field (singular, type `string`) in `cli_args`, but the CLI stores `mounts` (plural) as a JSON array in properties. The metadata key and the actual property key are inconsistent. ### Minor Notes 5. No test for the `/` heuristic ambiguity — e.g., `--mount /data:/app` (2-part host path) is never tested, so the misclassification goes undetected. Adding this test case would catch the bug in item #1. 6. `_NoClose` wrapper in test steps is clever but opaque. A docstring comment explaining *why* `session.close()` is suppressed (to keep in-memory SQLite alive) would help future readers. 7. Mounts stored as a JSON string inside a dict value is a serialization-within-serialization pattern. If `properties` is itself JSON-serialized to the DB, this results in double-encoded JSON. Worth considering a cleaner schema in a future iteration.

hamza.khyari force-pushed bugfix/m8-container-mount-flag from 1afb374e76 to 3a58763750 2026-03-27 11:31:14 +00:00 Compare

hamza.khyari dismissed freemo's review 2026-03-27 11:31:14 +00:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

hamza.khyari added this to the v3.5.0 milestone 2026-03-27 11:32:29 +00:00

hamza.khyari force-pushed bugfix/m8-container-mount-flag from 3a58763750 to f5b4032854 2026-03-27 11:42:05 +00:00 Compare

hamza.khyari commented 2026-03-27 11:42:37 +00:00

Author

Member

Copy link

Response to @freemo Review

All 7 findings addressed in f5b40328. 8 scenarios passing (was 6).

#	Finding	Fix
1	/ heuristic misclassifies /data:/app as resource type	Changed to parts[0].startswith("/") — absolute paths are bind mounts, everything else is resource-reference
2	--mount accepted on all types	Added type_name != "container-instance" guard with typer.Abort()
3	Metadata key mismatch (mount vs mounts)	Renamed cli_args from mount to mounts with description explaining JSON array format
4	No test for /data:/app	Added scenario: "Absolute host path 2-part mount is bind type" — verifies type: bind, mode: rw
5	No test for type validation	Added scenario: "Mount rejected on non-container type"
6	_NoClose lacks docstring	Added docstring explaining in-memory SQLite session keepalive
7	Double-encoded JSON	Acknowledged — matches existing properties serialization pattern. Cleaner schema tracked for future iteration.

Process: Milestone v3.5.0 assigned. Rebased onto master (Mergeable: true).

## Response to @freemo Review All 7 findings addressed in `f5b40328`. 8 scenarios passing (was 6). | # | Finding | Fix | |---|---------|-----| | **1** | `/` heuristic misclassifies `/data:/app` as resource type | Changed to `parts[0].startswith("/")` — absolute paths are bind mounts, everything else is resource-reference | | **2** | `--mount` accepted on all types | Added `type_name != "container-instance"` guard with `typer.Abort()` | | **3** | Metadata key mismatch (`mount` vs `mounts`) | Renamed cli_args from `mount` to `mounts` with description explaining JSON array format | | **4** | No test for `/data:/app` | Added scenario: "Absolute host path 2-part mount is bind type" — verifies `type: bind`, `mode: rw` | | **5** | No test for type validation | Added scenario: "Mount rejected on non-container type" | | **6** | `_NoClose` lacks docstring | Added docstring explaining in-memory SQLite session keepalive | | **7** | Double-encoded JSON | Acknowledged — matches existing `properties` serialization pattern. Cleaner schema tracked for future iteration. | **Process:** Milestone v3.5.0 assigned. Rebased onto master (`Mergeable: true`).

hamza.khyari force-pushed bugfix/m8-container-mount-flag from f5b4032854 to ebafe8cddd 2026-03-27 12:57:06 +00:00 Compare

hamza.khyari scheduled this pull request to auto merge when all checks succeed 2026-03-27 12:58:08 +00:00

hamza.khyari merged commit dc1481a44e into master 2026-03-27 13:26:27 +00:00

hamza.khyari deleted branch bugfix/m8-container-mount-flag 2026-03-27 13:30:34 +00:00

hamza.khyari referenced this pull request from a commit 2026-03-27 13:59:11 +00:00

Merge pull request 'fix(cli): implement --mount flag on resource add container-instance' (#1134) from bugfix/m8-container-mount-flag into master

freemo referenced this pull request 2026-04-02 08:30:46 +00:00

bug(cli): resource add container-instance missing --mount flag for dual mount support #1078

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

auto/needs-reevaluation

Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  

controller-managed

Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  

auto/claimed-implementer

Currently being processed by an implementer worker.

  

auto/claimed-merge

Currently being processed by the merge driver.

  

auto/claimed-reviewer

Currently being processed by a reviewer worker.

  

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

  

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

  

auto/needs-implementer

Failing CI needs implementer attention.

  

auto/postmortem

Documenting a driver incident or rollback.

  

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

  

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

  

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

  

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  

Points

1

1 man-hours worth of work for an expert with no learning curve.

  

Points

13

13 man-hours worth of work for an expert with no learning curve.

  

Points

2

2 man-hours worth of work for an expert with no learning curve.

  

Points

21

21 man-hours worth of work for an expert with no learning curve.

  

Points

3

3 man-hours worth of work for an expert with no learning curve.

  

Points

34

34 man-hours worth of work for an expert with no learning curve.

  

Points

5

5 man-hours worth of work for an expert with no learning curve.

  

Points

55

55 man-hours worth of work for an expert with no learning curve.

  

Points

8

8 man-hours worth of work for an expert with no learning curve.

  

Points

88

88 man-hours worth of work for an expert with no learning curve.

  

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

  

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  

State

Duplicate

A ticket that represents the same content as an existing ticket.

  

State

In Progress

A ticket that is actively being developed.

  

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  

Type

Automation

Any edits or discussion about the AI automated coding system.

  

Type

Bug

Something that doesnt work as intended.

  

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  

Type

Documentation

An error or improvement needed in the documentation.

  

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  

Type

Feature

Some new functionality not present.

  

Type

Legendary

A type of Epic which will contain other Epics.

  

Type

Refactor

A code change that restructures existing code without changing its external behavior.

  

Type

Support

Someone needs help using the project.

  

Type

Task

A generic task that doesnt fit into the other type categories.

  

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No labels

auto/needs-reevaluation

controller-managed

auto/blocked-by-deps

auto/ci-timeout

auto/claimed-implementer

auto/claimed-merge

auto/claimed-reviewer

auto/driver-down

auto/invariant-violation

auto/last-attempt-tier-0

auto/last-attempt-tier-1

auto/last-attempt-tier-2

auto/last-attempt-tier-min

Automation Tracking

auto/needs-conflict-resolution

auto/needs-implementer

auto/postmortem

auto/ready-to-merge

auto/restart-throttled

auto/revert

auto/sentinel

auto/stale-inactivity

auto/unstable

Blocked

Bounty

$100

Bounty

$1000

Bounty

$10000

Bounty

$20

Bounty

$2000

Bounty

$250

Bounty

$50

Bounty

$500

Bounty

$5000

Bounty

$750

MoSCoW

Could have

MoSCoW

Must have

MoSCoW

Should have

Needs Feedback

Points

1

Points

13

Points

2

Points

21

Points

3

Points

34

Points

5

Points

55

Points

8

Points

88

Priority

Backlog

Priority

CI Blocker

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Signed-off: Owner

Signed-off: Scrum Master

Signed-off: Tech Lead

Spike

State

Completed

State

Duplicate

State

In Progress

State

In Review

State

Paused

State

Unverified

State

Verified

State

Wont Do

Type

Automation

Type

Bug

Type

Discussion

Type

Documentation

Type

Epic

Type

Feature

Type

Legendary

Type

Refactor

Type

Support

Type

Task

Type

Testing

Milestone

Clear milestone

No items

No milestone

v3.5.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

hamza.khyari

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cleveragents/cleveragents-core!1134

No description provided.