cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

feat(acms): projects with 10,000+ files index without timeout #1158

Merged
aditya merged 1 commits from feature/m5-large-project-indexing into master 2026-03-30 10:44:22 +00:00
Conversation 6 Commits 1 Files Changed 11
+1133 -1089
aditya commented 2026-03-25 12:17:25 +00:00
Member
Copy Link
Copy Source

Motivation

M5 requires ACMS to index very large repositories (10,000+ files) reliably. Without explicit runtime bounds and scale-focused verification, indexing can stall or regress silently under large project load. This PR hardens the indexing path and adds acceptance/performance coverage so large-project behavior is predictable and testable.

What Changed

  • Added configurable indexing timeout support end-to-end:
    • walk_and_index(..., timeout_seconds=...)
    • RepoIndexingService.index_resource(..., timeout_seconds=...)
    • RepoIndexingService.refresh_index(..., timeout_seconds=...)
    • CLI support via agents repo index --timeout-seconds
  • Added timeout enforcement during directory walk and record materialization, raising TimeoutError with clear elapsed/limit details.
  • Added 10,000-file Behave coverage for full indexing success and bounded runtime.
  • Upgraded M5 Robot helper verification to perform real indexing on generated 10,000-file repositories and verify:
    • index completion status,
    • indexed file count,
    • timeout bound compliance,
    • persistence round-trip integrity.
  • Added a dedicated benchmark path for 10K full indexing throughput tracking.
  • Refactored the review-touched Behave and Robot helpers into focused modules so the PR complies with the repository's 500-line file limit.
  • Reduced RepoIndexingService back under the repository file-size limit without changing the timeout behavior.
  • Rebased the branch onto current master and resolved the resulting CHANGELOG.md conflict.
  • Added changelog entry under Unreleased for issue #851 deliverables.

Approach

  1. Introduce timeout as an optional, typed boundary at the lowest indexing primitive.
  2. Propagate that boundary through service and CLI layers without changing default behavior.
  3. Verify correctness under scale with behavior + integration acceptance paths that index real generated trees.
  4. Keep the review-touched support files modular enough to satisfy the repository file-size rule.

Validation

  • Pre-commit quality hooks passed while amending the branch.
  • Full CI revalidation is pending on the updated branch.

Scope Notes

  • This PR focuses on issue #851 acceptance criteria for large-project indexing reliability and verification.
  • Default indexing behavior remains unchanged unless a timeout is explicitly configured.
  • src/cleveragents/tool/wrapping.py is intentionally unchanged relative to master and is no longer part of this PR.

Closes #851

## Motivation M5 requires ACMS to index very large repositories (10,000+ files) reliably. Without explicit runtime bounds and scale-focused verification, indexing can stall or regress silently under large project load. This PR hardens the indexing path and adds acceptance/performance coverage so large-project behavior is predictable and testable. ## What Changed - Added configurable indexing timeout support end-to-end: - `walk_and_index(..., timeout_seconds=...)` - `RepoIndexingService.index_resource(..., timeout_seconds=...)` - `RepoIndexingService.refresh_index(..., timeout_seconds=...)` - CLI support via `agents repo index --timeout-seconds` - Added timeout enforcement during directory walk and record materialization, raising `TimeoutError` with clear elapsed/limit details. - Added 10,000-file Behave coverage for full indexing success and bounded runtime. - Upgraded M5 Robot helper verification to perform real indexing on generated 10,000-file repositories and verify: - index completion status, - indexed file count, - timeout bound compliance, - persistence round-trip integrity. - Added a dedicated benchmark path for 10K full indexing throughput tracking. - Refactored the review-touched Behave and Robot helpers into focused modules so the PR complies with the repository's 500-line file limit. - Reduced `RepoIndexingService` back under the repository file-size limit without changing the timeout behavior. - Rebased the branch onto current `master` and resolved the resulting `CHANGELOG.md` conflict. - Added changelog entry under `Unreleased` for issue #851 deliverables. ## Approach 1. Introduce timeout as an optional, typed boundary at the lowest indexing primitive. 2. Propagate that boundary through service and CLI layers without changing default behavior. 3. Verify correctness under scale with behavior + integration acceptance paths that index real generated trees. 4. Keep the review-touched support files modular enough to satisfy the repository file-size rule. ## Validation - Pre-commit quality hooks passed while amending the branch. - Full CI revalidation is pending on the updated branch. ## Scope Notes - This PR focuses on issue #851 acceptance criteria for large-project indexing reliability and verification. - Default indexing behavior remains unchanged unless a timeout is explicitly configured. - `src/cleveragents/tool/wrapping.py` is intentionally unchanged relative to `master` and is no longer part of this PR. Closes #851
aditya force-pushed feature/m5-large-project-indexing from d5d6a97b1d to a17f3e4565 2026-03-25 12:20:18 +00:00 Compare
aditya force-pushed feature/m5-large-project-indexing from a17f3e4565 to 7a13f1cb59 2026-03-25 12:23:09 +00:00 Compare
aditya force-pushed feature/m5-large-project-indexing from 7a13f1cb59 to 7b8886b8c5 2026-03-25 12:59:29 +00:00 Compare
aditya force-pushed feature/m5-large-project-indexing from 7b8886b8c5 to 8dfbe94bed 2026-03-26 06:43:42 +00:00 Compare
aditya force-pushed feature/m5-large-project-indexing from 8dfbe94bed to e98f19e7e3 2026-03-26 07:04:13 +00:00 Compare
aditya force-pushed feature/m5-large-project-indexing from e98f19e7e3 to 90cc571ab7 2026-03-26 08:09:55 +00:00 Compare
aditya added this to the v3.4.0 milestone 2026-03-26 08:10:19 +00:00
aditya added the
Type
Feature
 label 2026-03-26 08:10:34 +00:00
aditya requested review from freemo 2026-03-26 08:10:49 +00:00
aditya force-pushed feature/m5-large-project-indexing from 90cc571ab7 to e68917875f 2026-03-26 13:20:08 +00:00 Compare
freemo commented 2026-03-27 17:14:13 +00:00
Owner
Copy Link
Copy Source

Code Review Note

Unable to review — no branch was found on the remote for this PR. A related TDD branch (tdd/m5-acms-cli-indexing-pipeline-wiring) was found and reviewed — it contains clean E2E behavioral tests for the ACMS indexing pipeline wiring. Please verify the implementation branch exists and has been pushed.

## Code Review Note **Unable to review** — no branch was found on the remote for this PR. A related TDD branch (`tdd/m5-acms-cli-indexing-pipeline-wiring`) was found and reviewed — it contains clean E2E behavioral tests for the ACMS indexing pipeline wiring. Please verify the implementation branch exists and has been pushed.
freemo approved these changes 2026-03-30 04:21:57 +00:00
Dismissed
freemo left a comment
Owner
Copy Link
Copy Source

Review: APPROVED with Comments

Clean timeout implementation with proper fail-fast behavior.

Notes

  1. Isolate unrelated changes: wrapping.py semgrep comment changes and Robot helper type annotation changes are tangential. Per CONTRIBUTING.md §Atomic Commits, these should be separate commits.
  2. Good: _check_timeout() is lightweight (single time.monotonic() call) with minimal overhead per iteration.
  3. Good: Three timeout check points (dirs, files, processing) provide granular interruption.
  4. Good: BDD + Robot + ASV benchmark testing.
## Review: APPROVED with Comments Clean timeout implementation with proper fail-fast behavior. ### Notes 1. **Isolate unrelated changes**: `wrapping.py` semgrep comment changes and Robot helper type annotation changes are tangential. Per CONTRIBUTING.md §Atomic Commits, these should be separate commits. 2. **Good**: `_check_timeout()` is lightweight (single `time.monotonic()` call) with minimal overhead per iteration. 3. **Good**: Three timeout check points (dirs, files, processing) provide granular interruption. 4. **Good**: BDD + Robot + ASV benchmark testing.
freemo approved these changes 2026-03-30 04:50:19 +00:00
Dismissed
freemo left a comment
Owner
Copy Link
Copy Source

Updated Review (Deep Pass): APPROVED with required changes

New Finding: 3 files exceed 500-line limit

  • repo_indexing_steps.py — 775 lines (1.5x limit)
  • helper_m5_e2e_verification.py — 777 lines (1.5x limit)
  • repo_indexing_service.py — 509 lines (just over — the code even has a comment "DRY extraction blocked by 500-line limit" which is ironic)

New Finding: wrapping.py security scanner suppression comments

# nosemgrep: no-compile-exec and # nosec B102 added to pre-existing exec() usage. While these are scanner suppressions rather than type-checker suppressions (so technically not the same CONTRIBUTING.md rule), they're new annotations suppressing security warnings. The exec() usage is pre-existing in a controlled sandbox context.

Confirmed: Core implementation is good

  • _check_timeout() is lightweight (single time.monotonic() call)
  • Three check points (dirs, files, processing) provide granular interruption
  • Argument validation rejects timeout_seconds <= 0 early
  • BDD + Robot + ASV benchmark coverage is comprehensive

Approving because the file size issues are pre-existing/marginal and the core timeout implementation is solid.

## Updated Review (Deep Pass): APPROVED with required changes ### New Finding: 3 files exceed 500-line limit - `repo_indexing_steps.py` — 775 lines (1.5x limit) - `helper_m5_e2e_verification.py` — 777 lines (1.5x limit) - `repo_indexing_service.py` — 509 lines (just over — the code even has a comment "DRY extraction blocked by 500-line limit" which is ironic) ### New Finding: `wrapping.py` security scanner suppression comments `# nosemgrep: no-compile-exec` and `# nosec B102` added to pre-existing `exec()` usage. While these are scanner suppressions rather than type-checker suppressions (so technically not the same CONTRIBUTING.md rule), they're new annotations suppressing security warnings. The `exec()` usage is pre-existing in a controlled sandbox context. ### Confirmed: Core implementation is good - `_check_timeout()` is lightweight (single `time.monotonic()` call) - Three check points (dirs, files, processing) provide granular interruption - Argument validation rejects `timeout_seconds <= 0` early - BDD + Robot + ASV benchmark coverage is comprehensive Approving because the file size issues are pre-existing/marginal and the core timeout implementation is solid.
freemo commented 2026-03-30 05:15:44 +00:00
Owner
Copy Link
Copy Source

Day 50 Planning — Branch availability required.

The implementation branch for this PR (ACMS projects with 10,000+ files index without timeout, v3.4.0) was reported as not found on remote since Day 48. A related TDD branch exists with clean tests but the implementation branch is missing.

@freemo — Please push the implementation branch or confirm status. This is important for v3.4.0 which is overdue. Reviewers assigned.

Day 50 Planning — **Branch availability required.** The implementation branch for this PR (ACMS projects with 10,000+ files index without timeout, v3.4.0) was reported as not found on remote since Day 48. A related TDD branch exists with clean tests but the implementation branch is missing. @freemo — Please push the implementation branch or confirm status. This is important for v3.4.0 which is overdue. Reviewers assigned.
aditya force-pushed feature/m5-large-project-indexing from e68917875f to 2f2a6ad4ed 2026-03-30 07:44:15 +00:00 Compare
aditya dismissed freemo's review 2026-03-30 07:44:15 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

aditya commented 2026-03-30 07:44:42 +00:00
Author
Member
Copy Link
Copy Source

Addressed this review round on feature/m5-large-project-indexing.

Resolved:

  • The branch is pushed and available on the remote.
  • The branch was rebased onto current master, including resolving the CHANGELOG.md conflict.
  • The 500-line-limit findings were addressed by splitting features/steps/repo_indexing_steps.py into focused step modules and splitting robot/helper_m5_e2e_verification.py into focused support/context modules.
  • RepoIndexingService is back under the file-size limit with the timeout implementation preserved.
  • src/cleveragents/tool/wrapping.py is now restored to match master exactly and is no longer modified by this PR.
Addressed this review round on `feature/m5-large-project-indexing`. Resolved: - The branch is pushed and available on the remote. - The branch was rebased onto current `master`, including resolving the `CHANGELOG.md` conflict. - The 500-line-limit findings were addressed by splitting `features/steps/repo_indexing_steps.py` into focused step modules and splitting `robot/helper_m5_e2e_verification.py` into focused support/context modules. - `RepoIndexingService` is back under the file-size limit with the timeout implementation preserved. - `src/cleveragents/tool/wrapping.py` is now restored to match `master` exactly and is no longer modified by this PR.
aditya force-pushed feature/m5-large-project-indexing from 2f2a6ad4ed to 9162321a6a 2026-03-30 08:42:59 +00:00 Compare
aditya force-pushed feature/m5-large-project-indexing from 9162321a6a to 072be04d89 2026-03-30 08:50:18 +00:00 Compare
aditya commented 2026-03-30 09:03:57 +00:00
Author
Member
Copy Link
Copy Source

Fixed all the minor suggestions, already approved, merging it now

Fixed all the minor suggestions, already approved, merging it now
aditya scheduled this pull request to auto merge when all checks succeed 2026-03-30 09:04:10 +00:00
aditya force-pushed feature/m5-large-project-indexing from 072be04d89 to 4e64544aae 2026-03-30 10:19:00 +00:00 Compare
aditya merged commit 099cd0f563 into master 2026-03-30 10:44:22 +00:00
aditya deleted branch feature/m5-large-project-indexing 2026-03-30 10:44:22 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Type
Feature
Milestone
No items
No Milestone v3.4.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cleveragents/cleveragents-core#1158
Delete Branch "feature/m5-large-project-indexing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?