test(integration): workflow example 4 — multi-project dependency update (supervised profile) #1043

Merged
hamza.khyari merged 1 commit from test/int-wf04-multi-project into master 2026-03-27 15:07:47 +00:00
Member

Summary

Integration test for Specification Workflow Example 4: Multi-Project Dependency Update.

  • 8 Robot Framework test cases + Python helper script
  • Exercises supervised automation profile with 4 projects
  • Tests child plan spawning, dependency-ordered execution, coordinated apply
  • Uses MultiProjectService for scope init, changeset recording, cross-project validation
  • Mocked LLM providers via env var

Test Cases

  1. Register 4 Project Links
  2. Create Coordinated Update Action
  3. Use Action Across 4 Projects With Supervised Profile
  4. Strategize With Dependency Ordered Config
  5. Spawn 4 Child Plans
  6. Execute Children In Dependency Order (common-lib first)
  7. Apply In Dependency Order (coordinated)
  8. Full Multi-Project Lifecycle End To End

ISSUES CLOSED: #768

## Summary Integration test for Specification Workflow Example 4: Multi-Project Dependency Update. - 8 Robot Framework test cases + Python helper script - Exercises supervised automation profile with 4 projects - Tests child plan spawning, dependency-ordered execution, coordinated apply - Uses MultiProjectService for scope init, changeset recording, cross-project validation - Mocked LLM providers via env var ## Test Cases 1. Register 4 Project Links 2. Create Coordinated Update Action 3. Use Action Across 4 Projects With Supervised Profile 4. Strategize With Dependency Ordered Config 5. Spawn 4 Child Plans 6. Execute Children In Dependency Order (common-lib first) 7. Apply In Dependency Order (coordinated) 8. Full Multi-Project Lifecycle End To End ISSUES CLOSED: #768
hamza.khyari added this to the v3.3.0 milestone 2026-03-18 11:41:39 +00:00
freemo approved these changes 2026-03-19 04:53:40 +00:00
Dismissed
freemo left a comment

Code Review — PR #1043 test(integration): workflow example 4 — multi-project dependency update

Well-structured integration test. The 8 Robot test cases provide good coverage of multi-project dependency orchestration with supervised automation profiles. Good timeouts (60s standard, 120s for full lifecycle).

Approved with minor notes:

  1. Non-standard issue closing syntax — The PR body uses ISSUES CLOSED: #768. Forgejo recognizes keywords like Closes #768 or Fixes #768 for auto-closing. ISSUES CLOSED: may not trigger auto-close on merge. Consider changing to Closes #768.

  2. sys.path manipulation — The helper explicitly inserts src/ into sys.path, while the sibling PR #1042's helper does not. This inconsistency could be confusing — consider standardizing the approach across integration test helpers.

## Code Review — PR #1043 `test(integration): workflow example 4 — multi-project dependency update` Well-structured integration test. The 8 Robot test cases provide good coverage of multi-project dependency orchestration with supervised automation profiles. Good timeouts (60s standard, 120s for full lifecycle). **Approved** with minor notes: 1. **Non-standard issue closing syntax** — The PR body uses `ISSUES CLOSED: #768`. Forgejo recognizes keywords like `Closes #768` or `Fixes #768` for auto-closing. `ISSUES CLOSED:` may not trigger auto-close on merge. Consider changing to `Closes #768`. 2. **`sys.path` manipulation** — The helper explicitly inserts `src/` into `sys.path`, while the sibling PR #1042's helper does not. This inconsistency could be confusing — consider standardizing the approach across integration test helpers.
hamza.khyari force-pushed test/int-wf04-multi-project from bba97c4eb2
All checks were successful
CI / lint (pull_request) Successful in 17s
CI / benchmark-publish (pull_request) Has been skipped
CI / quality (pull_request) Successful in 28s
CI / typecheck (pull_request) Successful in 41s
CI / build (pull_request) Successful in 21s
CI / security (pull_request) Successful in 58s
CI / unit_tests (pull_request) Successful in 3m4s
CI / integration_tests (pull_request) Successful in 3m38s
CI / docker (pull_request) Successful in 1m5s
CI / e2e_tests (pull_request) Successful in 4m8s
CI / coverage (pull_request) Successful in 6m14s
CI / benchmark-regression (pull_request) Successful in 38m28s
to f3a356dec8
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 19s
CI / build (pull_request) Successful in 22s
CI / quality (pull_request) Successful in 28s
CI / typecheck (pull_request) Successful in 40s
CI / security (pull_request) Successful in 53s
CI / integration_tests (pull_request) Successful in 3m40s
CI / unit_tests (pull_request) Successful in 3m53s
CI / docker (pull_request) Successful in 9s
CI / e2e_tests (pull_request) Successful in 5m30s
CI / coverage (pull_request) Successful in 7m3s
CI / benchmark-regression (pull_request) Has been cancelled
2026-03-19 13:09:26 +00:00
Compare
hamza.khyari dismissed freemo's review 2026-03-19 13:09:26 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

hamza.khyari force-pushed test/int-wf04-multi-project from f3a356dec8
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 19s
CI / build (pull_request) Successful in 22s
CI / quality (pull_request) Successful in 28s
CI / typecheck (pull_request) Successful in 40s
CI / security (pull_request) Successful in 53s
CI / integration_tests (pull_request) Successful in 3m40s
CI / unit_tests (pull_request) Successful in 3m53s
CI / docker (pull_request) Successful in 9s
CI / e2e_tests (pull_request) Successful in 5m30s
CI / coverage (pull_request) Successful in 7m3s
CI / benchmark-regression (pull_request) Has been cancelled
to 40e67dd2df
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 16s
CI / build (pull_request) Successful in 17s
CI / quality (pull_request) Successful in 28s
CI / typecheck (pull_request) Successful in 1m1s
CI / security (pull_request) Successful in 1m2s
CI / unit_tests (pull_request) Successful in 3m17s
CI / docker (pull_request) Successful in 9s
CI / integration_tests (pull_request) Successful in 3m53s
CI / e2e_tests (pull_request) Successful in 6m39s
CI / coverage (pull_request) Successful in 8m17s
CI / benchmark-regression (pull_request) Successful in 38m30s
2026-03-19 13:23:45 +00:00
Compare
hamza.khyari force-pushed test/int-wf04-multi-project from be671a7c66
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 20s
CI / quality (pull_request) Successful in 37s
CI / build (pull_request) Successful in 23s
CI / typecheck (pull_request) Successful in 42s
CI / security (pull_request) Successful in 50s
CI / unit_tests (pull_request) Has been cancelled
CI / e2e_tests (pull_request) Has been cancelled
CI / integration_tests (pull_request) Has been cancelled
CI / coverage (pull_request) Has been cancelled
CI / benchmark-regression (pull_request) Has been cancelled
CI / docker (pull_request) Has been cancelled
to 5310d87eeb
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
CI / build (pull_request) Successful in 16s
CI / quality (pull_request) Successful in 51s
CI / lint (pull_request) Successful in 3m18s
CI / typecheck (pull_request) Successful in 4m3s
CI / security (pull_request) Successful in 4m14s
CI / integration_tests (pull_request) Successful in 7m8s
CI / e2e_tests (pull_request) Successful in 9m45s
CI / unit_tests (pull_request) Successful in 4m9s
CI / docker (pull_request) Successful in 1m18s
CI / benchmark-regression (pull_request) Has been cancelled
CI / coverage (pull_request) Has been cancelled
CI / status-check (pull_request) Has been cancelled
2026-03-27 13:59:10 +00:00
Compare
hamza.khyari force-pushed test/int-wf04-multi-project from 5310d87eeb
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
CI / build (pull_request) Successful in 16s
CI / quality (pull_request) Successful in 51s
CI / lint (pull_request) Successful in 3m18s
CI / typecheck (pull_request) Successful in 4m3s
CI / security (pull_request) Successful in 4m14s
CI / integration_tests (pull_request) Successful in 7m8s
CI / e2e_tests (pull_request) Successful in 9m45s
CI / unit_tests (pull_request) Successful in 4m9s
CI / docker (pull_request) Successful in 1m18s
CI / benchmark-regression (pull_request) Has been cancelled
CI / coverage (pull_request) Has been cancelled
CI / status-check (pull_request) Has been cancelled
to 8463ddaf9e
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
CI / build (pull_request) Successful in 23s
CI / lint (pull_request) Successful in 3m19s
CI / quality (pull_request) Successful in 3m47s
CI / typecheck (pull_request) Successful in 4m1s
CI / security (pull_request) Successful in 4m7s
CI / unit_tests (pull_request) Successful in 4m10s
CI / integration_tests (pull_request) Successful in 3m47s
CI / docker (pull_request) Successful in 1m19s
CI / e2e_tests (pull_request) Has been cancelled
CI / coverage (pull_request) Has been cancelled
CI / benchmark-regression (pull_request) Has been cancelled
CI / status-check (pull_request) Has been cancelled
2026-03-27 14:24:51 +00:00
Compare
hamza.khyari force-pushed test/int-wf04-multi-project from 8463ddaf9e
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
CI / build (pull_request) Successful in 23s
CI / lint (pull_request) Successful in 3m19s
CI / quality (pull_request) Successful in 3m47s
CI / typecheck (pull_request) Successful in 4m1s
CI / security (pull_request) Successful in 4m7s
CI / unit_tests (pull_request) Successful in 4m10s
CI / integration_tests (pull_request) Successful in 3m47s
CI / docker (pull_request) Successful in 1m19s
CI / e2e_tests (pull_request) Has been cancelled
CI / coverage (pull_request) Has been cancelled
CI / benchmark-regression (pull_request) Has been cancelled
CI / status-check (pull_request) Has been cancelled
to afe48e6af7
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
CI / build (pull_request) Successful in 28s
CI / lint (pull_request) Failing after 49s
CI / typecheck (pull_request) Successful in 4m19s
CI / coverage (pull_request) Has been skipped
CI / quality (pull_request) Successful in 4m20s
CI / security (pull_request) Successful in 4m25s
CI / benchmark-regression (pull_request) Has been skipped
CI / integration_tests (pull_request) Successful in 9m22s
CI / unit_tests (pull_request) Successful in 9m40s
CI / docker (pull_request) Has been skipped
CI / status-check (pull_request) Failing after 1s
CI / e2e_tests (pull_request) Successful in 12m1s
2026-03-27 14:34:26 +00:00
Compare
hamza.khyari force-pushed test/int-wf04-multi-project from afe48e6af7
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
CI / build (pull_request) Successful in 28s
CI / lint (pull_request) Failing after 49s
CI / typecheck (pull_request) Successful in 4m19s
CI / coverage (pull_request) Has been skipped
CI / quality (pull_request) Successful in 4m20s
CI / security (pull_request) Successful in 4m25s
CI / benchmark-regression (pull_request) Has been skipped
CI / integration_tests (pull_request) Successful in 9m22s
CI / unit_tests (pull_request) Successful in 9m40s
CI / docker (pull_request) Has been skipped
CI / status-check (pull_request) Failing after 1s
CI / e2e_tests (pull_request) Successful in 12m1s
to 0569aaa51c
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
CI / build (pull_request) Successful in 17s
CI / lint (pull_request) Successful in 3m18s
CI / typecheck (pull_request) Successful in 3m55s
CI / quality (pull_request) Successful in 4m2s
CI / security (pull_request) Successful in 4m16s
CI / integration_tests (pull_request) Successful in 9m11s
CI / unit_tests (pull_request) Successful in 9m30s
CI / docker (pull_request) Successful in 1m23s
CI / e2e_tests (pull_request) Successful in 13m30s
CI / coverage (pull_request) Successful in 11m29s
CI / status-check (pull_request) Successful in 1s
CI / benchmark-regression (pull_request) Successful in 53m38s
2026-03-27 14:50:20 +00:00
Compare
hamza.khyari deleted branch test/int-wf04-multi-project 2026-03-27 15:07:53 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!1043
No description provided.