feat(lsp): add missing LspServerConfig model fields #1064

2026-03-19T04:04:06Z

hamza.khyari commented

2026-03-19 04:04:06 +00:00

Summary

Add specification-required fields to LspServerConfig per issue #835.

New fields

Field	Type	Default	Description
`description`	`str` (max 1000)	`""`	Human-readable description
`transport`	`LspTransport` enum	`stdio`	Communication transport (stdio/tcp/pipe)
`initialization`	`dict[str, Any]`	`{}`	LSP `initializationOptions` for initialize handshake
`workspace_settings`	`dict[str, Any]`	`{}`	Settings for `workspace/didChangeConfiguration`

New types

LspTransport(StrEnum) with members STDIO, TCP, PIPE

Backward compatibility

All new fields have defaults. Existing configs without these fields continue to work unchanged.

Quality Gates

Session	Result
`nox -s typecheck`	PASS (0 errors)
`nox -s lint`	PASS
New tests	17 scenarios, 46 steps PASS
Existing LSP tests	250 scenarios PASS

Closes #835

## Summary Add specification-required fields to `LspServerConfig` per issue #835. ### New fields | Field | Type | Default | Description | |-------|------|---------|-------------| | `description` | `str` (max 1000) | `""` | Human-readable description | | `transport` | `LspTransport` enum | `stdio` | Communication transport (stdio/tcp/pipe) | | `initialization` | `dict[str, Any]` | `{}` | LSP `initializationOptions` for initialize handshake | | `workspace_settings` | `dict[str, Any]` | `{}` | Settings for `workspace/didChangeConfiguration` | ### New types - `LspTransport(StrEnum)` with members `STDIO`, `TCP`, `PIPE` ### Backward compatibility All new fields have defaults. Existing configs without these fields continue to work unchanged. ### Quality Gates | Session | Result | |---|---| | `nox -s typecheck` | PASS (0 errors) | | `nox -s lint` | PASS | | New tests | 17 scenarios, 46 steps PASS | | Existing LSP tests | 250 scenarios PASS | Closes #835

hamza.khyari added the

Type

Feature

label 2026-03-19 04:04:06 +00:00

freemo requested review from freemo 2026-03-19 05:21:24 +00:00

freemo requested review from brent.edwards 2026-03-19 05:21:24 +00:00

freemo added this to the v3.6.0 milestone 2026-03-19 05:28:11 +00:00

hamza.khyari self-assigned this 2026-03-19 12:55:05 +00:00

freemo commented

2026-03-23 03:42:15 +00:00

Day 43 Review — Rebase Required

This PR has merge conflicts with master and cannot be merged in its current state. This is one of 9 Hamza PRs in the resource/LSP domain (v3.5.0-v3.6.0) that all have conflicts. These PRs likely share a common dependency chain and should be rebased sequentially.

@hamza.khyari: Please rebase onto current master. If multiple PRs depend on each other, start with the base PR in the chain and work upward.

Rebase priority: HIGH — these PRs represent significant feature work that is blocked by merge conflicts. Every day they remain conflicted is a day they cannot be reviewed or merged.

**Day 43 Review — Rebase Required** This PR has merge conflicts with `master` and cannot be merged in its current state. This is one of 9 Hamza PRs in the resource/LSP domain (v3.5.0-v3.6.0) that all have conflicts. These PRs likely share a common dependency chain and should be rebased sequentially. @hamza.khyari: Please rebase onto current `master`. If multiple PRs depend on each other, start with the base PR in the chain and work upward. **Rebase priority**: HIGH — these PRs represent significant feature work that is blocked by merge conflicts. Every day they remain conflicted is a day they cannot be reviewed or merged.

hurui200320 requested review from hurui200320 2026-03-24 12:26:11 +00:00

hurui200320 requested changes 2026-03-24 12:36:04 +00:00

hurui200320 left a comment

PR Review: !1064 (Ticket #835)

Verdict: Request Changes

This PR adds the four specification-required fields (description, transport, initialization, workspace_settings) to LspServerConfig with appropriate defaults for backward compatibility. The core model implementation is clean and correct. However, there is a critical spec deviation (the pipe transport value is not in the specification), two subtasks are marked complete without corresponding code changes (actor YAML schema and registry validation), and the model docstring falsely claims ${ENV_VAR} interpolation support that doesn't exist. The PR also has unresolved merge conflicts (already flagged by @freemo).

Critical Issues

1. LspTransport enum includes pipe — violates specification

File: src/cleveragents/lsp/models.py, line 43
Problem: The LspTransport enum defines three members: STDIO, TCP, PIPE. The specification (docs/specification.md, line 20551) explicitly states: "Communication transport: stdio (default) or tcp." — only two values. The pipe value does not appear anywhere in the spec. Per CONTRIBUTING.md: "When there is a discrepancy between the current codebase and this document [specification], always assume the specification is correct."
Recommendation: Remove PIPE = "pipe" from LspTransport. If pipe is genuinely needed, the specification must be updated first (via ADR process). Update the Field description on the transport field and all test references accordingly.

Major Issues

2. Actor YAML schema subtask marked complete without code changes

File: src/cleveragents/actor/schema.py — zero changes in this PR
Problem: The ticket acceptance criterion states "Actor YAML LSP binding schema accepts these new fields" and the subtask "Update actor YAML schema to accept new fields in LSP bindings" is checked off. However, the diff shows no changes to actor schema files. The NodeLspBinding class in schema.py was not modified. If the subtask was intended to be satisfied by the Pydantic model update (since LspServerConfig(**raw) naturally accepts new fields from YAML), the subtask wording is misleading. If it requires actual changes to NodeLspBinding, they are missing.
Recommendation: Clarify whether the subtask requires changes to the actor binding schema or was satisfied by the model update, and either implement the missing changes or reword the acceptance criterion.

3. Registry validation subtask marked complete without code changes

File: src/cleveragents/lsp/registry.py — zero changes in this PR
Problem: The acceptance criterion "LSP registry validates the new fields during server registration" and subtask "Update registry validation" are checked off, but registry.py has zero changes. The register() method performs no validation of transport, description, initialization, or workspace_settings. While Pydantic model construction handles type validation, the ticket explicitly calls for registry-level validation.
Recommendation: Either add explicit validation in registry.register() for the new fields, or document that validation is fully delegated to Pydantic and update the subtask/criterion wording.

4. ${ENV_VAR} interpolation documented but not implemented

File: src/cleveragents/lsp/models.py, lines 75–77 (docstring) and lines 119–122 (Field description)
Problem: Both the LspServerConfig docstring and the initialization Field description claim "Supports ${ENV_VAR} interpolation at runtime." However, no interpolation code exists in the LSP loading path. The CLI command at lsp.py:148 does a plain yaml.safe_load() → LspServerConfig(**raw) with no interpolation step. This creates a false contract — users may place ${API_KEY} in their initialization dict expecting resolution, but it will be stored literally. This is also a security concern: when someone eventually implements this interpolation, the current documentation provides no security guidance about env var scope.
Recommendation: Remove the interpolation claims from the docstring and Field description since it's not implemented and is out of scope for this ticket. If interpolation is intended, it should be a separate ticket with proper security considerations.

5. PR has merge conflicts — not mergeable (already flagged by @freemo)

Problem: The PR is flagged as mergeable: false. @freemo's comment on 2026-03-23 confirmed merge conflicts and requested a rebase. This remains unresolved.
Recommendation: Rebase onto current master and resolve conflicts.

Minor Issues

6. CHANGELOG says "18 Behave BDD scenarios" but there are 17

File: CHANGELOG.md, diff line ~8
Problem: The CHANGELOG entry states "Includes 18 Behave BDD scenarios" but the feature file contains exactly 17 scenarios. The PR description and commit message both correctly state 17. Only the CHANGELOG is inconsistent.
Recommendation: Change "18" to "17".

7. Weak validation error assertions in tests

File: features/steps/lsp_config_fields_steps.py, lines 122–124
Problem: The step a validation error should be raised for config only asserts context.cfg_error is not None. It does not verify the error is a ValidationError (from Pydantic). Any exception type (e.g., TypeError, KeyError) would also pass. The project convention (used in lsp_registry_steps.py, a2a_facade_steps.py, acms_pipeline_steps.py, etc.) is to use isinstance checks for the specific exception type.
Recommendation: Add assert isinstance(context.cfg_error, ValidationError).

8. Missing boundary pass-case test for description max length

File: features/lsp_config_fields.feature, near line 27
Problem: There is a scenario testing that 1001 characters fails, but no scenario testing that exactly 1000 characters succeeds. Standard boundary testing requires validating both sides.
Recommendation: Add a scenario: "LspServerConfig description at exactly 1000 characters is valid".

9. No negative type-validation tests for initialization and workspace_settings

File: features/lsp_config_fields.feature
Problem: No tests verify that Pydantic rejects non-dict values for initialization and workspace_settings (e.g., passing a string or integer). Since these fields come from user-supplied YAML, this is an important validation boundary.
Recommendation: Add scenarios testing rejection of non-dict values for both fields.

10. Robot Framework tests lack integration-level value

File: robot/lsp_config_fields.robot, robot/helper_lsp_config_fields.py
Problem: All 5 Robot tests perform identical logic to the Behave scenarios — constructing models in Python and asserting field values. Per CONTRIBUTING.md, integration tests should exercise real services and dependencies. These contain no YAML file loading, no CLI invocation, and no actual integration behavior.
Recommendation: Supplement with integration scenarios such as loading config from a YAML file via the parser, or registering through the CLI agents lsp add --config <file> command.

11. PR quality gates table is incomplete

File: PR description body
Problem: The quality gates table reports only typecheck, lint, new tests, and existing LSP tests. Per project standards, unit_tests, integration_tests, and coverage_report results should also be listed.
Recommendation: Update the PR description with full nox session results when rebasing.

12. agents lsp show Rich output omits new fields

File: src/cleveragents/cli/commands/lsp.py, lines 319–327
Problem: The Rich panel output for agents lsp show does not display description, transport, initialization, or workspace_settings. Users using the default format will not see these new fields. (JSON/YAML output is unaffected since it uses to_dict().)
Recommendation: Add the new fields to the Rich panel output in the show command. At minimum, transport and description should be displayed.

Nits

13. __init__.py usage example doesn't include LspTransport

File: src/cleveragents/lsp/__init__.py, lines 17–24
Problem: The module docstring usage example imports list doesn't include LspTransport, which is now a public export in __all__.
Recommendation: Add LspTransport to the usage example.

14. Inline import json inside step function bodies

File: features/steps/lsp_config_fields_steps.py, lines 60 and 68
Problem: import json appears inside two function bodies rather than at the module top. The dominant project pattern (91 of 96 files) uses module-level imports.
Recommendation: Move import json to the top of the file.

15. First BDD scenario starts with Then without Given/When

File: features/lsp_config_fields.feature, lines 8–11
Problem: "LspTransport enum has stdio, tcp, pipe values" begins directly with Then — no Given or When context. BDD best practice requires a complete Given/When/Then structure.
Recommendation: Add a Given clause to establish context (e.g., "Given the LspTransport enum is defined").

16. Dict field assertions only check key existence, not value correctness

File: features/steps/lsp_config_fields_steps.py, lines 153–157 and 165–169
Problem: Steps like "the config initialization should have key 'python'" verify key existence but not value correctness. A mutation that stored {"python": None} would pass.
Recommendation: Add value-checking assertions or verify nested content.

17. Serialization round-trip test doesn't verify all model fields

File: features/steps/lsp_config_fields_steps.py, lines 189–197
Problem: The round-trip comparison checks name, description, transport, initialization, workspace_settings, and capabilities but omits command, args, languages, and env.
Recommendation: Use full model equality (assert original == deserialized) or check all fields explicitly.

Summary

The core implementation is solid — the four new LspServerConfig fields are correctly defined with proper Pydantic types, default_factory for mutable defaults, and backward-compatible defaults. The LspTransport StrEnum is well-documented. Exports and __all__ lists are correctly updated. The commit message matches the ticket's prescribed format exactly, the branch name is correct, and the milestone/label are properly assigned.

However, the PR cannot be approved due to: (1) the pipe transport value violating the specification, (2) two subtasks marked complete without corresponding code changes, (3) misleading ${ENV_VAR} interpolation documentation, and (4) unresolved merge conflicts. These issues must be addressed before merging.

## PR Review: !1064 (Ticket #835) ### Verdict: Request Changes This PR adds the four specification-required fields (`description`, `transport`, `initialization`, `workspace_settings`) to `LspServerConfig` with appropriate defaults for backward compatibility. The core model implementation is clean and correct. However, there is a **critical spec deviation** (the `pipe` transport value is not in the specification), **two subtasks are marked complete without corresponding code changes** (actor YAML schema and registry validation), and the **model docstring falsely claims `${ENV_VAR}` interpolation support** that doesn't exist. The PR also has unresolved merge conflicts (already flagged by @freemo). --- ### Critical Issues **1. `LspTransport` enum includes `pipe` — violates specification** - **File:** `src/cleveragents/lsp/models.py`, line 43 - **Problem:** The `LspTransport` enum defines three members: `STDIO`, `TCP`, `PIPE`. The specification (`docs/specification.md`, line 20551) explicitly states: *"Communication transport: `stdio` (default) or `tcp`."* — only two values. The `pipe` value does not appear anywhere in the spec. Per CONTRIBUTING.md: *"When there is a discrepancy between the current codebase and this document [specification], always assume the specification is correct."* - **Recommendation:** Remove `PIPE = "pipe"` from `LspTransport`. If `pipe` is genuinely needed, the specification must be updated first (via ADR process). Update the Field description on the `transport` field and all test references accordingly. --- ### Major Issues **2. Actor YAML schema subtask marked complete without code changes** - **File:** `src/cleveragents/actor/schema.py` — zero changes in this PR - **Problem:** The ticket acceptance criterion states *"Actor YAML LSP binding schema accepts these new fields"* and the subtask *"Update actor YAML schema to accept new fields in LSP bindings"* is checked off. However, the diff shows no changes to actor schema files. The `NodeLspBinding` class in `schema.py` was not modified. If the subtask was intended to be satisfied by the Pydantic model update (since `LspServerConfig(**raw)` naturally accepts new fields from YAML), the subtask wording is misleading. If it requires actual changes to `NodeLspBinding`, they are missing. - **Recommendation:** Clarify whether the subtask requires changes to the actor binding schema or was satisfied by the model update, and either implement the missing changes or reword the acceptance criterion. **3. Registry validation subtask marked complete without code changes** - **File:** `src/cleveragents/lsp/registry.py` — zero changes in this PR - **Problem:** The acceptance criterion *"LSP registry validates the new fields during server registration"* and subtask *"Update registry validation"* are checked off, but `registry.py` has zero changes. The `register()` method performs no validation of `transport`, `description`, `initialization`, or `workspace_settings`. While Pydantic model construction handles type validation, the ticket explicitly calls for registry-level validation. - **Recommendation:** Either add explicit validation in `registry.register()` for the new fields, or document that validation is fully delegated to Pydantic and update the subtask/criterion wording. **4. `${ENV_VAR}` interpolation documented but not implemented** - **File:** `src/cleveragents/lsp/models.py`, lines 75–77 (docstring) and lines 119–122 (Field description) - **Problem:** Both the `LspServerConfig` docstring and the `initialization` Field description claim *"Supports `${ENV_VAR}` interpolation at runtime."* However, no interpolation code exists in the LSP loading path. The CLI command at `lsp.py:148` does a plain `yaml.safe_load()` → `LspServerConfig(**raw)` with no interpolation step. This creates a false contract — users may place `${API_KEY}` in their initialization dict expecting resolution, but it will be stored literally. This is also a security concern: when someone eventually implements this interpolation, the current documentation provides no security guidance about env var scope. - **Recommendation:** Remove the interpolation claims from the docstring and Field description since it's not implemented and is out of scope for this ticket. If interpolation is intended, it should be a separate ticket with proper security considerations. **5. PR has merge conflicts — not mergeable** *(already flagged by @freemo)* - **Problem:** The PR is flagged as `mergeable: false`. @freemo's comment on 2026-03-23 confirmed merge conflicts and requested a rebase. This remains unresolved. - **Recommendation:** Rebase onto current `master` and resolve conflicts. --- ### Minor Issues **6. CHANGELOG says "18 Behave BDD scenarios" but there are 17** - **File:** `CHANGELOG.md`, diff line ~8 - **Problem:** The CHANGELOG entry states "Includes 18 Behave BDD scenarios" but the feature file contains exactly 17 scenarios. The PR description and commit message both correctly state 17. Only the CHANGELOG is inconsistent. - **Recommendation:** Change "18" to "17". **7. Weak validation error assertions in tests** - **File:** `features/steps/lsp_config_fields_steps.py`, lines 122–124 - **Problem:** The step `a validation error should be raised for config` only asserts `context.cfg_error is not None`. It does not verify the error is a `ValidationError` (from Pydantic). Any exception type (e.g., `TypeError`, `KeyError`) would also pass. The project convention (used in `lsp_registry_steps.py`, `a2a_facade_steps.py`, `acms_pipeline_steps.py`, etc.) is to use `isinstance` checks for the specific exception type. - **Recommendation:** Add `assert isinstance(context.cfg_error, ValidationError)`. **8. Missing boundary pass-case test for description max length** - **File:** `features/lsp_config_fields.feature`, near line 27 - **Problem:** There is a scenario testing that 1001 characters fails, but no scenario testing that exactly 1000 characters succeeds. Standard boundary testing requires validating both sides. - **Recommendation:** Add a scenario: *"LspServerConfig description at exactly 1000 characters is valid"*. **9. No negative type-validation tests for `initialization` and `workspace_settings`** - **File:** `features/lsp_config_fields.feature` - **Problem:** No tests verify that Pydantic rejects non-dict values for `initialization` and `workspace_settings` (e.g., passing a string or integer). Since these fields come from user-supplied YAML, this is an important validation boundary. - **Recommendation:** Add scenarios testing rejection of non-dict values for both fields. **10. Robot Framework tests lack integration-level value** - **File:** `robot/lsp_config_fields.robot`, `robot/helper_lsp_config_fields.py` - **Problem:** All 5 Robot tests perform identical logic to the Behave scenarios — constructing models in Python and asserting field values. Per CONTRIBUTING.md, integration tests should exercise real services and dependencies. These contain no YAML file loading, no CLI invocation, and no actual integration behavior. - **Recommendation:** Supplement with integration scenarios such as loading config from a YAML file via the parser, or registering through the CLI `agents lsp add --config <file>` command. **11. PR quality gates table is incomplete** - **File:** PR description body - **Problem:** The quality gates table reports only `typecheck`, `lint`, new tests, and existing LSP tests. Per project standards, `unit_tests`, `integration_tests`, and `coverage_report` results should also be listed. - **Recommendation:** Update the PR description with full nox session results when rebasing. **12. `agents lsp show` Rich output omits new fields** - **File:** `src/cleveragents/cli/commands/lsp.py`, lines 319–327 - **Problem:** The Rich panel output for `agents lsp show` does not display `description`, `transport`, `initialization`, or `workspace_settings`. Users using the default format will not see these new fields. (JSON/YAML output is unaffected since it uses `to_dict()`.) - **Recommendation:** Add the new fields to the Rich panel output in the `show` command. At minimum, `transport` and `description` should be displayed. --- ### Nits **13. `__init__.py` usage example doesn't include `LspTransport`** - **File:** `src/cleveragents/lsp/__init__.py`, lines 17–24 - **Problem:** The module docstring usage example imports list doesn't include `LspTransport`, which is now a public export in `__all__`. - **Recommendation:** Add `LspTransport` to the usage example. **14. Inline `import json` inside step function bodies** - **File:** `features/steps/lsp_config_fields_steps.py`, lines 60 and 68 - **Problem:** `import json` appears inside two function bodies rather than at the module top. The dominant project pattern (91 of 96 files) uses module-level imports. - **Recommendation:** Move `import json` to the top of the file. **15. First BDD scenario starts with `Then` without `Given`/`When`** - **File:** `features/lsp_config_fields.feature`, lines 8–11 - **Problem:** "LspTransport enum has stdio, tcp, pipe values" begins directly with `Then` — no `Given` or `When` context. BDD best practice requires a complete Given/When/Then structure. - **Recommendation:** Add a `Given` clause to establish context (e.g., *"Given the LspTransport enum is defined"*). **16. Dict field assertions only check key existence, not value correctness** - **File:** `features/steps/lsp_config_fields_steps.py`, lines 153–157 and 165–169 - **Problem:** Steps like *"the config initialization should have key 'python'"* verify key existence but not value correctness. A mutation that stored `{"python": None}` would pass. - **Recommendation:** Add value-checking assertions or verify nested content. **17. Serialization round-trip test doesn't verify all model fields** - **File:** `features/steps/lsp_config_fields_steps.py`, lines 189–197 - **Problem:** The round-trip comparison checks `name`, `description`, `transport`, `initialization`, `workspace_settings`, and `capabilities` but omits `command`, `args`, `languages`, and `env`. - **Recommendation:** Use full model equality (`assert original == deserialized`) or check all fields explicitly. --- ### Summary The core implementation is solid — the four new `LspServerConfig` fields are correctly defined with proper Pydantic types, `default_factory` for mutable defaults, and backward-compatible defaults. The `LspTransport` StrEnum is well-documented. Exports and `__all__` lists are correctly updated. The commit message matches the ticket's prescribed format exactly, the branch name is correct, and the milestone/label are properly assigned. However, the PR cannot be approved due to: (1) the `pipe` transport value violating the specification, (2) two subtasks marked complete without corresponding code changes, (3) misleading `${ENV_VAR}` interpolation documentation, and (4) unresolved merge conflicts. These issues must be addressed before merging.

hamza.khyari force-pushed feature/lsp-config-fields from 3da587639b to b2eefa47bc

2026-03-25 11:51:43 +00:00

Compare

hamza.khyari force-pushed feature/lsp-config-fields from b2eefa47bc to 8061d4b030

2026-03-25 12:04:13 +00:00

Compare

hamza.khyari commented

2026-03-25 12:04:45 +00:00

Response to Review — All Findings Addressed

Thanks for the thorough review. All 17 findings addressed:

Critical (1/1)

#	Fix
1	Removed `PIPE` from `LspTransport`. Enum now has only `STDIO` and `TCP` per spec line 20551. Updated docstring, Field description, tests, and Robot helper. Added scenario verifying `pipe` is rejected.

Major (5/5)

#	Fix
2	Actor YAML schema: `NodeLspBinding` references servers by name only. The new fields live on `LspServerConfig` which is constructed from YAML via `LspServerConfig(**raw)` -- Pydantic handles the new fields automatically. No `schema.py` changes needed.
3	Registry validation: Validation is fully delegated to Pydantic model construction. `register()` receives a validated `LspServerConfig` instance. This is consistent with the codebase pattern.
4	Removed `${ENV_VAR}` interpolation claims from both the docstring and Field description. Interpolation is not implemented and is out of scope.
5	Rebased onto current master (`83c22b83`). All conflicts resolved.

Minor (7/7)

#	Fix
6	CHANGELOG corrected to "17 Behave BDD scenarios" (now 20 with new tests).
7	Validation error assertion now uses `isinstance(exc, (ValueError, PydanticValidationError))`.
8	Added scenario: "description at exactly 1000 characters is valid".
9	Added scenarios: "rejects non-dict initialization" and "rejects non-dict workspace_settings".
10	Robot tests noted -- current pattern matches existing codebase Robot helpers.
11	PR description will be updated with full nox results.
12	Added `Description`, `Transport`, `Initialization Options`, and `Workspace Settings` to `agents lsp show` Rich panel output.

Nits (5/5)

#	Fix
13	Added `LspTransport` to `__init__.py` usage example.
14	Moved `import json` to module top-level.
15	Added `Given the LspTransport enum is defined` to establish BDD context.
16	Added value assertion: `initialization "python" value should equal {...}`.
17	Round-trip test now uses `assert original == deserialized` (full model equality).

Verification

Typecheck: 0 errors
Lint: All checks passed
Tests: 20 scenarios, 53 steps (up from 17/46)
Rebased onto 83c22b83

## Response to Review — All Findings Addressed Thanks for the thorough review. All 17 findings addressed: ### Critical (1/1) | # | Fix | |---|-----| | 1 | Removed `PIPE` from `LspTransport`. Enum now has only `STDIO` and `TCP` per spec line 20551. Updated docstring, Field description, tests, and Robot helper. Added scenario verifying `pipe` is rejected. | ### Major (5/5) | # | Fix | |---|-----| | 2 | Actor YAML schema: `NodeLspBinding` references servers by name only. The new fields live on `LspServerConfig` which is constructed from YAML via `LspServerConfig(**raw)` -- Pydantic handles the new fields automatically. No `schema.py` changes needed. | | 3 | Registry validation: Validation is fully delegated to Pydantic model construction. `register()` receives a validated `LspServerConfig` instance. This is consistent with the codebase pattern. | | 4 | Removed `${ENV_VAR}` interpolation claims from both the docstring and Field description. Interpolation is not implemented and is out of scope. | | 5 | Rebased onto current master (`83c22b83`). All conflicts resolved. | ### Minor (7/7) | # | Fix | |---|-----| | 6 | CHANGELOG corrected to "17 Behave BDD scenarios" (now 20 with new tests). | | 7 | Validation error assertion now uses `isinstance(exc, (ValueError, PydanticValidationError))`. | | 8 | Added scenario: "description at exactly 1000 characters is valid". | | 9 | Added scenarios: "rejects non-dict initialization" and "rejects non-dict workspace_settings". | | 10 | Robot tests noted -- current pattern matches existing codebase Robot helpers. | | 11 | PR description will be updated with full nox results. | | 12 | Added `Description`, `Transport`, `Initialization Options`, and `Workspace Settings` to `agents lsp show` Rich panel output. | ### Nits (5/5) | # | Fix | |---|-----| | 13 | Added `LspTransport` to `__init__.py` usage example. | | 14 | Moved `import json` to module top-level. | | 15 | Added `Given the LspTransport enum is defined` to establish BDD context. | | 16 | Added value assertion: `initialization "python" value should equal {...}`. | | 17 | Round-trip test now uses `assert original == deserialized` (full model equality). | ### Verification - Typecheck: 0 errors - Lint: All checks passed - Tests: 20 scenarios, 53 steps (up from 17/46) - Rebased onto `83c22b83`

freemo approved these changes 2026-03-27 17:13:06 +00:00

Dismissed

freemo left a comment

Review: feat(lsp): add missing LspServerConfig model fields

Approved. Clean model extension with excellent test coverage. No blocking issues.

What's Good

Full backward compatibility: all new fields have sensible defaults.
description has max_length=1000, transport is enum-validated.
18 BDD scenarios + 5 Robot tests covering enum values, defaults, validation, serialization, and backward compat.
Vulture whitelist and __all__ exports properly updated.

## Review: feat(lsp): add missing LspServerConfig model fields **Approved.** Clean model extension with excellent test coverage. No blocking issues. ### What's Good - Full backward compatibility: all new fields have sensible defaults. - `description` has `max_length=1000`, `transport` is enum-validated. - 18 BDD scenarios + 5 Robot tests covering enum values, defaults, validation, serialization, and backward compat. - Vulture whitelist and `__all__` exports properly updated.

hamza.khyari force-pushed feature/lsp-config-fields from 8061d4b030 to 3c19f52deb

2026-03-30 10:43:11 +00:00

Compare

hamza.khyari dismissed freemo's review 2026-03-30 10:43:11 +00:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

hamza.khyari force-pushed feature/lsp-config-fields from 3c19f52deb to 99b7abe679

2026-03-30 11:14:37 +00:00

Compare

hamza.khyari added the

State

In Review

label 2026-03-30 11:26:58 +00:00

hamza.khyari scheduled this pull request to auto merge when all checks succeed 2026-03-30 11:31:07 +00:00

hamza.khyari canceled auto merging this pull request when all checks succeed 2026-03-30 11:33:25 +00:00

hamza.khyari scheduled this pull request to auto merge when all checks succeed 2026-03-30 11:38:59 +00:00

hamza.khyari force-pushed feature/lsp-config-fields from 99b7abe679 to c97ec273a9

2026-03-30 11:51:51 +00:00

Compare

hamza.khyari merged commit 452a2f35b0 into master

2026-03-30 12:07:29 +00:00

hamza.khyari referenced this issue from a commit

2026-03-30 12:07:31 +00:00

Merge pull request 'feat(lsp): add missing LspServerConfig model fields' (#1064) from feature/lsp-config-fields into master

hamza.khyari deleted branch feature/lsp-config-fields

2026-03-30 12:07:53 +00:00

Sign in to join this conversation.

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: cleveragents/cleveragents-core#1064