test: add TDD bug-capture test for #1141 — session create persistence #1144

Merged

brent.edwards merged 3 commits from tdd/m3-session-create-persist into master 2026-03-28 04:34:48 +00:00

Conversation 2 Commits 3 Files changed 4 +140

brent.edwards commented 2026-03-24 02:21:20 +00:00

Member

Copy link

Summary

Adds TDD bug-capture coverage for bug #1141 (session create -> session list lifecycle) on metadata branch tdd/m3-session-create-persist.

What changed

• Added Behave bug-capture feature: features/tdd_session_create_persist.feature
  • Required tags: @tdd_bug @tdd_bug_1141 @tdd_expected_fail
  • Scenario path: init --force --yes -> session list --format json -> session create -> session list --format json
• Added Behave step definitions: features/steps/tdd_session_create_persist_steps.py
  • Uses root CLI app (cleveragents.cli.main:app) for realistic command routing
  • Asserts expected list totals; underlying assertion intentionally fails while bug is present
• Added Robot E2E bug-capture test: robot/e2e/e2e_session_create_persist.robot
  • Required tags: E2E, tdd_expected_fail, tdd_bug, tdd_bug_1141
  • Includes explicit in-file note to remove tdd_expected_fail when #1141 is fixed
• Updated changelog (CHANGELOG.md, Unreleased)

Notes

• The issue subtask referenced robot/e2e/e2e_session_lifecycle.robot, which is not present on current master; equivalent E2E coverage is implemented in robot/e2e/e2e_session_create_persist.robot.
• The branch was force-updated to remove stale merge-based history and keep an atomic, rebase-clean commit for this issue.

Quality gates

Gate	Result
nox -s lint	✅ pass
nox -s typecheck	✅ pass
nox -s unit_tests -- features/tdd_session_create_persist.feature	✅ pass (TDD inversion active; underlying assert fails)
nox -s integration_tests -- robot/e2e/e2e_session_create_persist.robot	✅ pass
nox -s e2e_tests	✅ pass
nox -s coverage_report	✅ pass (97.66173849218832%)
nox (full default suite)	✅ pass

Related issue

Closes #1142

## Summary Adds TDD bug-capture coverage for bug #1141 (`session create` -> `session list` lifecycle) on metadata branch `tdd/m3-session-create-persist`. ### What changed - Added Behave bug-capture feature: `features/tdd_session_create_persist.feature` - Required tags: `@tdd_bug @tdd_bug_1141 @tdd_expected_fail` - Scenario path: `init --force --yes` -> `session list --format json` -> `session create` -> `session list --format json` - Added Behave step definitions: `features/steps/tdd_session_create_persist_steps.py` - Uses root CLI app (`cleveragents.cli.main:app`) for realistic command routing - Asserts expected list totals; underlying assertion intentionally fails while bug is present - Added Robot E2E bug-capture test: `robot/e2e/e2e_session_create_persist.robot` - Required tags: `E2E`, `tdd_expected_fail`, `tdd_bug`, `tdd_bug_1141` - Includes explicit in-file note to remove `tdd_expected_fail` when #1141 is fixed - Updated changelog (`CHANGELOG.md`, Unreleased) ### Notes - The issue subtask referenced `robot/e2e/e2e_session_lifecycle.robot`, which is not present on current `master`; equivalent E2E coverage is implemented in `robot/e2e/e2e_session_create_persist.robot`. - The branch was force-updated to remove stale merge-based history and keep an atomic, rebase-clean commit for this issue. ## Quality gates | Gate | Result | |---|---| | `nox -s lint` | ✅ pass | | `nox -s typecheck` | ✅ pass | | `nox -s unit_tests -- features/tdd_session_create_persist.feature` | ✅ pass (TDD inversion active; underlying assert fails) | | `nox -s integration_tests -- robot/e2e/e2e_session_create_persist.robot` | ✅ pass | | `nox -s e2e_tests` | ✅ pass | | `nox -s coverage_report` | ✅ pass (97.66173849218832%) | | `nox` (full default suite) | ✅ pass | ## Related issue Closes #1142

brent.edwards added this to the v3.2.0 milestone 2026-03-24 02:21:20 +00:00

brent.edwards added the

Type

Testing

label 2026-03-24 02:21:20 +00:00

brent.edwards added a new dependency 2026-03-24 02:49:25 +00:00

#1142 TDD: Write failing test for #1141 — session create does not persist

brent.edwards changed title from tdd/m3-session-create-persist to test - show that agents session create doesn't show up in the list. 2026-03-24 02:53:27 +00:00

brent.edwards changed title from test - show that agents session create doesn't show up in the list. to test: add TDD bug-capture test for #1141 — session create persistence 2026-03-24 02:55:50 +00:00

brent.edwards force-pushed tdd/m3-session-create-persist from b3baa5da60 to 905c1f050c 2026-03-24 02:56:03 +00:00 Compare

brent.edwards force-pushed tdd/m3-session-create-persist from 905c1f050c to 3549da4913 2026-03-24 03:03:26 +00:00 Compare

brent.edwards force-pushed tdd/m3-session-create-persist from 3549da4913 to 2c56e89415 2026-03-24 03:07:17 +00:00 Compare

freemo approved these changes 2026-03-24 15:27:56 +00:00

Dismissed

freemo left a comment

Copy link

Review: APPROVED

Clean TDD bug-capture test for session create persistence (#1141). Tags correct (@tdd_expected_fail @tdd_bug @tdd_bug_1141). Both Behave and Robot (E2E) tests present. Step definitions fully implemented — invokes session create and session list --format json, parses JSON output, asserts total == 1. CHANGELOG entry included.

## Review: APPROVED Clean TDD bug-capture test for session create persistence (#1141). Tags correct (`@tdd_expected_fail @tdd_bug @tdd_bug_1141`). Both Behave and Robot (E2E) tests present. Step definitions fully implemented — invokes `session create` and `session list --format json`, parses JSON output, asserts `total == 1`. CHANGELOG entry included.

brent.edwards dismissed freemo's review 2026-03-25 20:45:21 +00:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

brent.edwards referenced this pull request 2026-03-26 05:35:09 +00:00

TDD: Write failing test for #1141 — session create does not persist #1142

brent.edwards force-pushed tdd/m3-session-create-persist from 2a369b37bb to dc2912dd5e 2026-03-26 05:35:32 +00:00 Compare

brent.edwards referenced this pull request 2026-03-26 05:36:13 +00:00

TDD: Write failing test for #1141 — session create does not persist #1142

brent.edwards force-pushed tdd/m3-session-create-persist from 66716feb30 to 19f25eec55 2026-03-26 06:06:50 +00:00 Compare

brent.edwards force-pushed tdd/m3-session-create-persist from 4f25082bc4 to fd9508029f 2026-03-26 20:03:34 +00:00 Compare

freemo approved these changes 2026-03-27 17:12:34 +00:00

Dismissed

freemo left a comment

Copy link

Review: test: add TDD bug-capture test for #1141 — session create persistence

Approved. Clean, well-structured TDD bug-capture test. Proper tags, good cleanup patterns, complete BDD + Robot coverage.

## Review: test: add TDD bug-capture test for #1141 — session create persistence **Approved.** Clean, well-structured TDD bug-capture test. Proper tags, good cleanup patterns, complete BDD + Robot coverage.

brent.edwards force-pushed tdd/m3-session-create-persist from fd9508029f to e4fb386be3 2026-03-28 02:45:40 +00:00 Compare

brent.edwards dismissed freemo's review 2026-03-28 02:45:40 +00:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

brent.edwards added 1 commit 2026-03-28 03:20:47 +00:00

test(tdd): align #1141 expected-fail tags with validator ... 80fefe2f00

Replace legacy tdd_bug tags with required tdd_issue tags so tdd_expected_fail scenarios pass TDD tag validation in both unit and E2E suites.

brent.edwards added 1 commit 2026-03-28 04:16:48 +00:00

Merge branch 'master' into tdd/m3-session-create-persist c901d4d721

brent.edwards removed a dependency 2026-03-28 04:20:50 +00:00

#1142 TDD: Write failing test for #1141 — session create does not persist

brent.edwards scheduled this pull request to auto merge when all checks succeed 2026-03-28 04:21:04 +00:00

brent.edwards merged commit b59100cc6c into master 2026-03-28 04:34:48 +00:00

brent.edwards deleted branch tdd/m3-session-create-persist 2026-03-28 04:34:50 +00:00

brent.edwards referenced this pull request from a commit 2026-03-28 04:34:50 +00:00

test: add TDD bug-capture test for #1141 — session create persistence (#1144)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

auto/needs-reevaluation

Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  

controller-managed

Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  

auto/claimed-implementer

Currently being processed by an implementer worker.

  

auto/claimed-merge

Currently being processed by the merge driver.

  

auto/claimed-reviewer

Currently being processed by a reviewer worker.

  

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

  

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

  

auto/needs-implementer

Failing CI needs implementer attention.

  

auto/postmortem

Documenting a driver incident or rollback.

  

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

  

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

  

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

  

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  

Points

1

1 man-hours worth of work for an expert with no learning curve.

  

Points

13

13 man-hours worth of work for an expert with no learning curve.

  

Points

2

2 man-hours worth of work for an expert with no learning curve.

  

Points

21

21 man-hours worth of work for an expert with no learning curve.

  

Points

3

3 man-hours worth of work for an expert with no learning curve.

  

Points

34

34 man-hours worth of work for an expert with no learning curve.

  

Points

5

5 man-hours worth of work for an expert with no learning curve.

  

Points

55

55 man-hours worth of work for an expert with no learning curve.

  

Points

8

8 man-hours worth of work for an expert with no learning curve.

  

Points

88

88 man-hours worth of work for an expert with no learning curve.

  

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

  

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  

State

Duplicate

A ticket that represents the same content as an existing ticket.

  

State

In Progress

A ticket that is actively being developed.

  

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  

Type

Automation

Any edits or discussion about the AI automated coding system.

  

Type

Bug

Something that doesnt work as intended.

  

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  

Type

Documentation

An error or improvement needed in the documentation.

  

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  

Type

Feature

Some new functionality not present.

  

Type

Legendary

A type of Epic which will contain other Epics.

  

Type

Refactor

A code change that restructures existing code without changing its external behavior.

  

Type

Support

Someone needs help using the project.

  

Type

Task

A generic task that doesnt fit into the other type categories.

  

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No labels

auto/needs-reevaluation

controller-managed

auto/blocked-by-deps

auto/ci-timeout

auto/claimed-implementer

auto/claimed-merge

auto/claimed-reviewer

auto/driver-down

auto/invariant-violation

auto/last-attempt-tier-0

auto/last-attempt-tier-1

auto/last-attempt-tier-2

auto/last-attempt-tier-min

Automation Tracking

auto/needs-conflict-resolution

auto/needs-implementer

auto/postmortem

auto/ready-to-merge

auto/restart-throttled

auto/revert

auto/sentinel

auto/stale-inactivity

auto/unstable

Blocked

Bounty

$100

Bounty

$1000

Bounty

$10000

Bounty

$20

Bounty

$2000

Bounty

$250

Bounty

$50

Bounty

$500

Bounty

$5000

Bounty

$750

MoSCoW

Could have

MoSCoW

Must have

MoSCoW

Should have

Needs Feedback

Points

1

Points

13

Points

2

Points

21

Points

3

Points

34

Points

5

Points

55

Points

8

Points

88

Priority

Backlog

Priority

CI Blocker

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Signed-off: Owner

Signed-off: Scrum Master

Signed-off: Tech Lead

Spike

State

Completed

State

Duplicate

State

In Progress

State

In Review

State

Paused

State

Unverified

State

Verified

State

Wont Do

Type

Automation

Type

Bug

Type

Discussion

Type

Documentation

Type

Epic

Type

Feature

Type

Legendary

Type

Refactor

Type

Support

Type

Task

Type

Testing

Milestone

Clear milestone

No items

No milestone

v3.2.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cleveragents/cleveragents-core!1144

No description provided.