2746 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
brent.edwards	d59fa47fd0	feat(cli): implement plan prompt command ... Add the missing plan prompt CLI command and wire it through the local A2A facade into PlanLifecycleService so operator guidance can be injected into active execute-phase plans per the specification. The lifecycle flow now validates active state, records user-intervention decisions, and returns structured queue/decision metadata for rich and machine-readable output envelopes across all supported formats. Also stabilize flaky quality gates discovered while implementing #885 by hardening integration helper timeouts, relaxing an overly strict CLI-core timing assertion, defaulting test worker concurrency to serial for determinism, switching ASV to spawn launch mode for runner stability, and documenting the controlled transform sandbox exec/compile path for static security hooks. ISSUES CLOSED: #885 Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-04-02 16:50:55 +00:00
brent.edwards	f002bad4ec	test: add TDD bug-capture test for #1152 — budget eviction deletes instead of demotes ... Add Behave BDD scenarios and Robot Framework integration tests that capture bug #1152: _enforce_hot_budget() permanently deletes hot-tier fragments via del self._hot[oldest_id] instead of demoting them to the warm tier. Similarly, evict_lru() permanently deletes via del store[fid]. The specification (§Plan Lifecycle ACMS Actions) describes a downward lifecycle ("Hot context archived to warm") that requires demotion, not destruction. Two Behave scenarios tagged @tdd_expected_fail @tdd_issue @tdd_issue_1152: - Budget-evicted fragment should be demoted to warm, not deleted - evict_lru-evicted fragment should be demoted to warm, not deleted Two Robot Framework tests mirror the Behave scenarios with a Python helper script for subprocess isolation. ISSUES CLOSED: #1183 Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-04-02 16:50:50 +00:00
freemo	52bfb1658a	build(agents): remove all retry limits — agents never give up ... Every finite retry cap in the agent system has been replaced with infinite retry + diagnostic logging. The system now self-corrects indefinitely rather than giving up and leaving work incomplete. Changes across 9 agent definitions: - ca-pr-self-reviewer: Merge retry changed from `for attempt in 1..3` to `WHILE True` with exponential backoff (10s → 5 min cap). Only exits the retry loop on success or merge conflict (which requires implementor rebase, not more retries). - ca-continuous-pr-reviewer: Removed the `attempts >= 5` give-up block that posted "manual intervention required" and stopped retrying. PRs are now retried indefinitely with a diagnostic comment every 10 attempts. - issue-implementor: Removed the "2 retries then permanently failed" budget. Failed issues are always re-queued. Every 3 consecutive failures posts a diagnostic comment on the Forgejo issue and resets the approach (clears prior attempt context to break out of repeating failure patterns). Removed the `skipped` list entirely — no issue is ever skipped. - product-builder: Forgejo API retry changed from "3 times then halt" to "indefinitely with exponential backoff, cap 5 min." Only halts on auth revocation (HTTP 401/403). Worker failure docs updated to reflect the issue-implementor's infinite retry policy. - ca-pr-checker, ca-timeline-updater, ca-spec-updater, ca-project-bootstrapper, ca-docs-writer: Git push conflict retry changed from "up to 3 times" to "indefinitely with rebase." Added reclone fallback: after every 5 consecutive push failures, the clone is deleted and recreated fresh to recover from corrupted git state. NOT changed (already correct): - ca-subtask-loop: 3-retry transient error classification is a heuristic for deciding when to escalate model tier. The loop itself already says "NEVER give up" and runs indefinitely at opus tier. - ca-human-liaison: Already says "Never exit voluntarily."	2026-04-02 16:43:22 +00:00
CleverAgents	3db9113bac	build(agents): replace rounds-based orchestration with continuous watchdog model ... The product-builder was acting as a workflow orchestrator that ran supervisors in sequential "rounds" (launch all → wait for ALL to finish → check convergence → re-launch). This caused three problems: 1. Supervisors were treated as batch jobs, not services — they ran once and exited, leaving gaps in coverage between rounds. 2. The product-builder blocked on wait_for_all(), meaning if one supervisor ran for hours, all others were dead during that time. 3. Coordination flowed through the product-builder (passing data between supervisors) instead of through Forgejo. The new model treats the product-builder as a process supervisor (like systemd). Its only jobs are: launch all 11 supervisors in a single parallel batch, keep them alive (re-launch on exit), and periodically check convergence by querying Forgejo. It never coordinates between supervisors — they self-coordinate exclusively through Forgejo issues, PRs, and comments. Changes across 11 agent definitions: - product-builder: Replaced Phase C.2/C.3 rounds loop with watchdog loop (wait_for_any + re-launch). Added mandatory pre-flight checklist and post-dispatch validation requiring all 11 supervisors. Removed all "round" variables and batch-wait semantics. - issue-implementor: Added 60-minute idle polling loop after queue drains — polls Forgejo for new issues every 60s before exiting, allowing it to pick up UAT bugs and human-created issues. - ca-continuous-pr-reviewer: Increased idle exit from 50 polls (~25 min) to 300 polls (~150 min). - ca-backlog-groomer: Increased from 30 cycles/5 clean to 200 cycles/ 20 clean before exit. - ca-bug-hunter: Increased idle tolerance from 5 waits (~5 min) to 60 waits (~60 min). - ca-uat-tester: Increased idle tolerance from 5 waits (~5 min) to 60 waits (~60 min). - ca-architecture-guard, ca-spec-updater, ca-docs-writer, ca-timeline-updater: Converted from one-shot agents to continuous services with monitoring loops that re-check for new code/changes at 10-30 minute intervals and exit after 100-300 minutes idle. - ca-agent-evolver: Clarified idle exit timing (~150 min).	2026-04-02 16:37:58 +00:00
freemo	a0f3999362	build(agents): restructure for async pool supervision, PR merge lifecycle, and human interaction ... Overhauls the agent orchestration architecture to solve three systemic issues: 1. PARALLELISM: Replaces the N-instances-per-stream-type model with a pool-supervisor pattern. Product-builder now launches ONE supervisor per stream type, each managing N workers internally. Eliminates batch-and-wait tail latency where 15 finished agents waited for 1 slow one. UAT tester and bug hunter gain dual-mode operation (pool supervisor + worker) with self-dispatch for parallel batches of narrow-scope workers. 2. PR MERGE LIFECYCLE: Fixes PRs being reviewed but never merged. PR self- reviewer now uses force_merge (no approval count required), checks CI status before merge, uses merge_when_checks_succeed for pending CI, and retries 3x on failure. Continuous PR reviewer converted to pool supervisor dispatching N parallel reviews, with approved-but-unmerged tracking and 5-attempt merge retry budget. Stale threshold increased from 5 to 25 min. 3. HUMAN INTERACTION: New ca-human-liaison agent continuously monitors Forgejo for developer activity (comments, issues, reviews), responds with context-aware replies, triages new issues with full authority, decomposes epics into child issues, fills epic/legendary gaps, and coordinates spec changes through human-approved PR workflow. Additionally adds ca-agent-evolver for self-improvement: analyzes agent performance patterns and proposes targeted modifications to agent definitions via PRs with 'needs feedback' label (human must approve). Backlog groomer gains epic/legendary completeness analysis (passes 9-10) to proactively create missing child issues for parent tickets with gaps. All agent permission cross-references verified consistent.	2026-04-02 16:12:17 +00:00
freemo	9a3c4265a0	fix(cli): add missing resource command flags per specification (#1192) ... Adds missing CLI flags to `resource add`, `resource list`, `resource tree`, `resource type list`, and `lsp list` per specification. Changes: - Added --update, --clone-into to resource_add; expanded --mount for devcontainer-instance - Added --all to resource_list; changed --depth default to 3 - Added [REGEX] positional to type_list and lsp list - Added include_auto_discovered parameter to resource registry ops - 12 new BDD scenarios with step definitions - Fixed critical bug: clone-into URL parsing used split() instead of rsplit(), causing HTTPS URLs to be stored with incorrect data Closes #904 Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me> Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>	2026-04-02 08:31:27 +00:00
freemo	0db70b9514	build: further expanded opencode agents for better parallelism and better isolation between agents environments	2026-04-02 03:55:43 -04:00
freemo	4e3b4180fc	feat(ci): add Helm chart lint and template validation to CI ... Add kubeconform manifest validation to the existing helm CI job. The helm job already had helm lint and helm template steps (added in #1085). This commit completes the optional acceptance criterion from #1089 by adding kubeconform v0.7.0 to validate rendered manifests against the Kubernetes 1.29.0 schema in strict mode. Changes: - Install kubeconform v0.7.0 in the helm CI job - Add 'Validate rendered manifests with kubeconform' step after helm template smoke render (strict mode, ignore-missing-schemas, kubernetes-version 1.29.0) - Add 5 BDD scenarios to ci_workflow_validation.feature covering: - helm job existence - helm lint step - helm template step - kubeconform validation step - status-check dependency on helm job ISSUES CLOSED: #1089	2026-04-02 07:47:09 +00:00
freemo	c937abdc09	build: Fixed opencode agents so they dont accidentally delete PR body	2026-04-02 03:09:55 -04:00
freemo	ec83213294	build: Modified opencode agents to be more aggressive in being parallel	2026-04-02 03:06:32 -04:00
freemo	ba55412ae1	fix(test): remove lingering @tdd_expected_fail tags for closed bugs #797 and #1028 ... Remove @tdd_expected_fail tags from test files for bugs #797 (actor list triggers DB update) and #1028 (ACMS indexing pipeline not wired), both of which are now closed and merged. The @tdd_bug and @tdd_bug_N tags remain as permanent regression guards per CONTRIBUTING.md TDD workflow rules. Files changed: - features/tdd_actor_list_no_db_update.feature - robot/tdd_actor_list_no_db_update.robot - robot/e2e/tdd_acms_behavioral_validation.robot ISSUES CLOSED: #1182	2026-04-02 07:05:11 +00:00
brent.edwards	601f408860	bug(cli): automation_profile._get_service() bypasses DI container ... Route automation profile CLI service resolution through the DI container by using container.automation_profile_service() and wiring a dedicated automation_profile_service provider in the application container. This removes ad-hoc repository/session construction from the CLI path so dependency lifecycle and configuration stay centralized and consistent with specification DI rules. Add integration-style, non-mocked Behave proof that _get_service() resolves through real container/provider wiring, while keeping focused delegation assertions in the existing coverage feature. Remove the unrelated robot/resource_dag.robot changes from this PR and clean up duplicate _get_service test overlap by dropping the extra TDD-only feature file pair. ISSUES CLOSED: #990	2026-04-02 06:21:49 +00:00
freemo	d344989387	build: submited opencode agent files	2026-04-02 02:07:23 -04:00
freemo	ce026cafc2	Merge pull request 'fix(cleanup): remove ghost acp/ package and orphaned .pyc files' (#1256) from fix/m7-remove-acp-ghost-package into master	2026-04-02 04:16:22 +00:00
brent.edwards	f653c58ebd	fix(cleanup): remove ghost acp/ package and orphaned .pyc files ... The ACP module was properly renamed to A2A in commit ec0b7631 (closing #688), but the deprecated src/cleveragents/acp/ path was not explicitly excluded from version control. While __pycache__/ and *.py[cod] are already gitignored globally, add an explicit .gitignore entry for the deprecated acp/ package path to prevent accidental re-introduction and document the deprecation per ADR-047. Verification performed: - Confirmed src/cleveragents/acp/ does not exist in git (only __pycache__ artifacts remain on developer machines as untracked build artifacts) - Confirmed zero tracked .pyc files across the entire repository - Confirmed zero imports referencing cleveragents.acp in source, test, and configuration files - Confirmed no orphaned .pyc files exist without corresponding .py sources - All nox sessions pass (coverage: 98.7%) ISSUES CLOSED: #947	2026-04-02 02:43:54 +00:00
CoreRasurae	b21e0fedea	test(bdd): add direct test for _fast_init_or_upgrade early-return behavior ... Add 8 BDD scenarios in features/fast_init_upgrade.feature that directly exercise the _fast_init_or_upgrade closure installed by _install_template_db_patch in features/environment.py. Scenarios cover all code paths: - Non-empty DB with matching prefix → early return (original NOT invoked) - Non-existent DB with matching prefix → template copied (original NOT invoked) - Existing empty DB with matching prefix → template copied (original NOT invoked) - Non-matching prefix → delegates to original init_or_upgrade - In-memory SQLite → delegates to original init_or_upgrade - Non-SQLite URL → delegates to original init_or_upgrade - Bare sqlite:// URL → delegates to original init_or_upgrade - Delegation forwards runner instance and keyword arguments correctly Test infrastructure: - features/mocks/fast_init_test_helpers.py provides a context manager (patch_original_init_or_upgrade) that replaces the _original_init_or_upgrade reference inside the closure via cell_contents manipulation, enabling precise call-tracking without recreating the function under test. - All scenarios tagged @mock_only to skip unnecessary DB setup. - Cleanup registered via context._cleanup_handlers for temp file removal. - Works in both sequential and parallel execution modes. Review fix round: - Added bare sqlite:// URL scenario covering the second branch of the in-memory disjunction (L1). - Added scenario verifying runner instance and keyword argument forwarding through the delegation path (L2, L3). - Replaced hardcoded test credentials with clearly synthetic pattern (I4). - Fixed CHANGELOG wording that incorrectly claimed mktemp replacement (L5). ISSUES CLOSED: #733	2026-04-01 23:52:20 +01:00
brent.edwards	054891d247	feat(tui): implement help panel (F1) with context-sensitive help ... Auto-merge when checks pass.	2026-04-01 22:16:11 +00:00
brent.edwards	0ae733d01f	feat(tui): implement help panel (F1) with context-sensitive help ... Add a dedicated TUI help overlay toggled by F1 and resolve its content from the current prompt mode for main-screen, slash-command, reference, and shell contexts. Extend Behave and Robot coverage for the new help-panel widget, app wiring, context switching, and toggle behavior. ISSUES CLOSED: #1013	2026-04-01 21:51:14 +00:00
hamza.khyari	49058c3a72	Merge pull request 'feat(resource): implement ResourceHandler content_hash method' (#1066) from feature/resource-handler-content-hash into master ... Reviewed-on: #1066 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com>	2026-04-01 13:41:51 +00:00
hamza.khyari	18b9d61e35	feat(resource): implement ResourceHandler content_hash method ... Add content_hash(resource, *, algorithm='sha256') -> str to the ResourceHandler protocol and all handler implementations: - Protocol: new content_hash method on ResourceHandler (protocol.py) - BaseResourceHandler: default impl hashes file content or directory entry names; returns EMPTY_CONTENT_HASH sentinel for missing resources - GitCheckoutHandler: hashes git rev-parse HEAD through the requested algorithm for consistent digest format - FsDirectoryHandler: recursive walk hashing sorted relative paths and file contents (content-only, ignores metadata) - DevcontainerHandler: hashes devcontainer.json config file - DatabaseResourceHandler: hashes connection string; for SQLite file-based DBs, hashes the database file content - _DefaultHandler: delegates to BaseResourceHandler EMPTY_CONTENT_HASH sentinel is the SHA-256 of empty input (e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855). Hash algorithm is configurable via the algorithm parameter (default sha256, accepts any hashlib.new()-compatible name). Behave tests (10 scenarios): sentinel for missing/nonexistent, determinism, different content produces different hash, fs-directory recursive hash with change detection, git-checkout hash, configurable algorithm (sha256 vs sha512), protocol compliance for all 4 handlers. ISSUES CLOSED: #837	2026-04-01 13:02:24 +00:00
brent.edwards	2fdac4b4c9	feat(tui): enumerate full slash command set (60+ commands, 14 groups) ... Auto-merge after checks succeed	2026-04-01 09:49:05 +00:00
brent.edwards	dc1359fc07	feat(tui): enumerate full slash command set (60+ commands, 14 groups) ... Add a specification-aligned slash command catalog and wire it into TUI overlay initialization so command discovery reflects the complete command surface. Cover command and group cardinality plus representative command presence in Behave tests. ISSUES CLOSED: #1002	2026-04-01 09:23:21 +00:00
aditya	b579178b67	Merge pull request 'feat(acms): implement DepthReductionCompressor for skeleton compression' (#1170) from feat/depth-reduction-compressor into master ... Reviewed-on: #1170 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com>	2026-04-01 06:38:11 +00:00
aditya	137d040c4d	feat(acms): implement DepthReductionCompressor for skeleton compression ... Add a production skeleton compressor that re-renders inherited fragments to overview depths via the UKO detail-level map chain, fits the result within the configured skeleton budget, and wires the pipeline default to the new compressor. Address prior review feedback by extracting the render visitors into a dedicated module, restoring projected metadata to native runtime types, constraining builtin component resolution with an allowlist, and keeping child-context inheritance compatible with CRP context fragments for the Robot integration path. Reproduced the Forgejo lint job in a clean python:3.13-slim container with the CI commands All checks passed! and 1740 files already formatted; both passed, so the earlier lint failure appears to have been transient runner behavior rather than a source-level defect. ISSUES CLOSED: #919	2026-04-01 06:16:41 +00:00
brent.edwards	34dcf5226f	feat(autonomy): automation profile resolution precedence correct (#1196) ... ## Summary - Fix automation profile resolution precedence at plan-creation time to follow plan > action > project > global. - Narrow exception handling in `_resolve_plan_profile_ref` to catch only `(KeyError, ValueError, OSError)` with warning-level structured logging, replacing bare `except Exception:` per CONTRIBUTING.md §Exception Propagation. - Fix TDD feature file tag/title inconsistency: align to `@tdd_bug @tdd_bug_1076` / "TDD Bug #1076" referencing the original bug ticket. - Add BDD scenarios for plan-level profile override and config service error fallback. - Harden lifecycle and Robot/Behave test paths for auto-progression and parallel CI stability (including pre-seeded DB initialization for `tdd_plan_explain_plan_id` helper). - Update Robot helper timing/session patterns to reduce false negatives in long-running integration/E2E validations. ## Approach The automation profile resolution is implemented in `PlanLifecycleService._resolve_plan_profile_ref`, which evaluates the four-level precedence chain (plan > action > project > global) at `use_action()` time. The resolved profile is stored as an `AutomationProfileRef` on the Plan with provenance tracking. The `ConfigService` is used for project-scoped and global config lookups, with narrowed exception handling that logs warnings on failure and falls back to the settings default. ## Validation - `nox -s lint` ✅ - `nox -s typecheck` ✅ - `nox -s unit_tests` ✅ - `nox -s coverage_report` ✅ (97%) ## Review Fix Round (Review #2963) 1. **Bare `except Exception:` → narrowed to `(KeyError, ValueError, OSError)` with warning logging** — addresses CONTRIBUTING.md §Exception Propagation violation 2. **Tag inconsistency fixed** — `@tdd_bug @tdd_bug_1076` with title "TDD Bug #1076" 3. **Added 2 new BDD scenarios** — plan-level override and config error fallback 4. **Rebased onto latest master** (532ea100) Closes #854 Reviewed-on: #1196 Co-authored-by: Brent Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent Edwards <brent.edwards@cleverthis.com>	2026-04-01 04:27:09 +00:00
brent.edwards	81c141716b	test(integration): workflow example 2 — automated test generation for a module (trusted profile) (#1176) ... ## Summary - Refactors WF02 integration helper into focused modules to satisfy maintainability guidelines and keep command responsibilities isolated. - Moves WF02 artifact assertions onto lifecycle-produced change artifacts and verifies user-facing `plan artifacts` flow with mocked providers. - Reworks WF02 coverage-gate assertions to run through validation registration/attachment/execution lifecycle and apply-gate outcomes. ## What changed in this fix round (cycle-6) - **CI must-fix — trusted profile lifecycle integration failure:** - Fixed failing integration test `WF02 Trusted Profile Auto Runs Strategize And Execute` caused by legacy AutomationProfile fields that no longer exist. - Updated WF02 trusted-profile assertions from removed legacy fields (`auto_strategize`, `auto_execute`, `auto_apply`) to current spec-aligned fields (`decompose_task`, `create_tool`, `select_tool`). - Key module: `robot/wf02_test_generation_commands.py` (`wf02_trusted_lifecycle`). ## Prior fix rounds retained - **P1 must-fix — validation payload assertions strengthened:** - Added explicit assertions for validation payload correctness in both failing and passing branches. - Assertions now verify: - validation identity (`local/auth-coverage` on `local/api-service-repo`) - required-mode semantics (`mode=required`, required pass/fail counters, `all_required_passed`) - `passed` boolean for each branch - measured-vs-target semantics (`measured_coverage` compared against `target`). - Key module: `robot/wf02_test_generation_validation.py`. - **P2 should-fix — artifact membership assertions tightened:** - Artifact assertions now enforce exact expected membership and count instead of permissive subset checks. - Persisted changeset assertions were aligned to the same strict set/count checks. - Key module: `robot/wf02_test_generation_artifacts.py`. - **P2 should-fix — removed unused helper:** - Deleted unused `_bind_changeset_to_plan` helper to eliminate dead code. - Key module: `robot/wf02_test_generation_artifacts.py`. - **P2 should-fix — concrete typing:** - Replaced `_setup_validation_db` return type from `tuple[Any, Any]` to concrete typed return (`Callable[[], _NoCloseSession]`, `Session`). - Key module: `robot/wf02_test_generation_validation.py`. ## Quality gates - `nox -e lint` ✅ - `nox -e typecheck` ✅ - `nox -e unit_tests` ✅ - `nox -e integration_tests` ✅ - `nox -e e2e_tests` ✅ - `nox -e coverage_report` ✅ (coverage: **98.74%**) ## Scope / limitations - No deferred items identified in cycle-6. Closes #766 Reviewed-on: #1176 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com> Co-authored-by: Brent Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent Edwards <brent.edwards@cleverthis.com>	2026-04-01 03:30:00 +00:00
brent.edwards	a8d91b94a7	feat(autonomy): guard enforcement works (denylist, budget caps, tool call limits) (#1204) ... ## Summary - Enforced autonomy guard behavior for denylist/allowlist checks, budget caps, tool-call limits, and write/apply approval gates. - Added scope-aware guard evaluation (plan vs subplan) using `GuardScope(StrEnum)` for type-safe scope handling. - Extracted remediation guidance strings as module-level constants (`REMEDIATION_DENYLIST`, `REMEDIATION_ALLOWLIST`, etc.) for consistency and testability. - Added Behave coverage to validate guard remediation messaging and subplan-scoped tool-call limit behavior. ## Review Fix Round (v2) Addressed review #2910 by @freemo: 1. **Reverted `resource_dag.robot`** — Unrelated Robot SQLite/cycle-detection changes removed from this commit; will be submitted as a separate PR. 2. **`scope` parameter → `GuardScope` enum** — Created `GuardScope(StrEnum)` in `automation_guard.py` with `PLAN` and `SUBPLAN` members. Updated `check_guard()` signature and all call sites. 3. **Removed redundant `scope_label`** — Now uses `scope.value` directly. 4. **Extracted remediation constants** — Guidance strings moved to module-level constants in `automation_guard.py`. ## Validation - `nox -s lint` — passed - `nox -s typecheck` — passed (0 errors, 0 warnings) - `nox -s unit_tests` — passed (508 features, 12989 scenarios, 0 failures) - `nox -s coverage_report` — passed (97% coverage) - Rebased onto latest `master` (532ea100) Closes #853 Reviewed-on: #1204 Co-authored-by: Brent Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent Edwards <brent.edwards@cleverthis.com>	2026-04-01 01:46:37 +00:00
brent.edwards	91cc0b1446	test: add TDD bug-capture test for #1025 — plan correct auto-resolve (#1172) ... ## Summary - add Behave `@tdd_expected_fail` bug-capture scenarios for `plan correct` auto-resolve without `--plan` - add shared mock fixtures and Robot integration coverage for isolated-container divergence reproducing bug #1025 - add ASV benchmark coverage for active-plan filtering and document the new TDD capture in changelog ## Testing - nox -s unit_tests -- features/tdd_plan_correct_auto_resolve.feature - nox -s integration_tests -- --include tdd_bug_1025 - nox -s lint - nox -s typecheck - nox -s coverage_report - nox Closes #1035 Reviewed-on: #1172 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com> Co-authored-by: Brent Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent Edwards <brent.edwards@cleverthis.com>	2026-04-01 00:40:46 +00:00
brent.edwards	01b6eb1804	feat(autonomy): parallel execution scales to 10+ concurrent subplans (#1201) ... ## Summary Add M6 parallel-scaling coverage for 10+ concurrent subplans: - **15-subplan parallel scenario** with explicit peak-concurrency bound checks (`max_parallel=10`) and thread-safe concurrency tracking via `_build_executor()`. - **Deep hierarchical decomposition** coverage (4+ levels) with adjusted leaf condition that only stops early when hitting `max_depth` or when the workset is trivially small (`min_files_per_subplan`). - **Non-progress guard** in `_build_hierarchy` to prevent pathological recursion when clustering cannot meaningfully split the file set. - **Small-project regression test** (< 50 files) verifying decomposition depth does not increase unexpectedly with the relaxed leaf condition. - **ASV benchmark** for 15-subplan parallel execution with `max_parallel=10` to track scaling behavior. ### Removed from this PR The `_build_hierarchy` child-linkage correctness fix (returning `node_id` from recursive calls instead of using `nodes[-1].node_id`) has been **removed** per review feedback — it is a separate bug fix and will be submitted as an independent issue/PR per CONTRIBUTING.md §Atomic Commits. ## Approach - **Concurrency tracking:** The `_build_executor()` closure in step definitions detects `context.concurrency_counter` / `context.concurrency_lock` and performs thread-safe peak tracking in a try/finally block. - **Leaf condition:** Replaced the `max_files_per_subplan` / `max_tokens_per_subplan` leaf check with a `min_files_per_subplan` check to allow deeper decomposition for large projects. Added a non-progress guard so clustering that cannot split the file set terminates immediately rather than recursing to `max_depth`. - **Deterministic IDs:** `_ids_for_count()` preserves legacy fixed IDs for the first 5 subplans and generates additional deterministic IDs for scale scenarios. ## Validation ### Passing - `nox -s lint` — all checks passed - `nox -s typecheck` — 0 errors, 0 warnings - `nox -s unit_tests` — 12,988 scenarios passed, 0 failed - `nox -s coverage_report` — 97% (passes `--fail-under=97`) Closes #855 Reviewed-on: #1201 Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-03-31 23:57:39 +00:00
freemo	31472b5413	test(coverage): add Behave scenarios for 39 under-covered modules ... Add Behave feature/step pairs that exercise uncovered branches across handlers, LSP, CLI, and service layers to reach the coverage gate. ISSUES CLOSED: #1232	2026-03-31 21:47:12 +00:00
brent.edwards	eed455d9f9	fix(devcontainer): Dockerfile build fails when .dockerignore excludes .git/ (#1234) ... ## Summary Fixes the Docker build failure at step 30/30: ``` fatal: not a git repository (or any of the parent directories): .git ``` ## Root Cause `.dockerignore` excludes `.git/`, so `COPY . $APP_DIR` never copies the `.git` directory into the image. However, the final `RUN` step unconditionally runs `git clean -xdf`, which requires a git repository to exist. ## Fix Wrapped `git clean -xdf` and `rm -rf .git` in a conditional that checks for `.git` directory existence first, falling through silently when absent: ```dockerfile ([ -d .git ] && git clean -xdf && rm -rf .git || true) ``` This makes the Dockerfile work correctly whether `.git` is present (e.g., if `.dockerignore` is modified) or absent (current behavior). ## Quality Gates | Gate | Result | |------|--------| | lint | Pass | | typecheck | Pass (0 errors) | | pre-commit hooks | Pass | (Dockerfile-only change — no Python code modified, so unit/integration tests are unaffected.) Closes #1233 Reviewed-on: #1234 Reviewed-by: Luis Mendes <luis.mendes@cleverthis.com> Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-03-31 21:14:46 +00:00
hamza.khyari	dd3b0286e5	Merge pull request 'feat(resource): implement 6-level execution environment precedence chain' (#1065) from feature/m5-exec-env-precedence into master ... Reviewed-on: #1065 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com>	2026-03-31 16:22:46 +00:00
hamza.khyari	5e96b4bf80	feat(resource): implement 6-level execution environment precedence chain ... Implement the spec's 6-level execution environment precedence chain (spec lines 19324-19386): 1. Plan override (priority=override) — always wins 2. Project override (priority=override) — wins over devcontainer 3. Nearest-ancestor devcontainer — auto-discovered 4. Plan fallback (priority=fallback) — defers to devcontainer 5. Project fallback (priority=fallback) — defers to closer scopes 6. Host default — final fallback - New resolve_with_precedence() API on ExecutionEnvironmentResolver - Added execution_env_priority field to ContextConfig (project model) - has_devcontainer() helper for devcontainer-instance detection - Legacy 4-level resolve() preserved for backward compatibility - _parse_priority() defaults missing priority to FALLBACK - 13 new Behave scenarios testing all 6 levels + edge cases - Updated CHANGELOG ISSUES CLOSED: #877	2026-03-31 16:01:58 +00:00
hamza.khyari	d27fb6d1f0	Merge pull request 'fix(cli): honour project-level execution-env-priority in resolution' (#1136) from bugfix/m8-exec-env-precedence-level2 into master ... Reviewed-on: #1136	2026-03-31 11:53:08 +00:00
hamza.khyari	cd9cb9e889	fix(cli): honour project-level execution-env-priority in resolution ... Thread plan_env and project_env through the tool execution chain so the ExecutionEnvironmentResolver receives project-level execution environment values stored in ContextConfig.execution_environment. The resolver's precedence logic (tool > plan > project > default) was already correct, but callers never passed project_env — tools always fell through to the global HOST default, ignoring project-level overrides entirely. Changes: - PlanExecutionContext: add plan_env and project_env fields + properties - ToolCallRouter: accept plan_env/project_env in constructor, pass to runner.execute() in route() and route_streaming() - ToolCallingRuntime: accept plan_env/project_env, pass to runner.execute() in the direct-runner fallback path - Update monkey-patched execute stubs in tool_router_steps.py to accept explicit plan_env/project_env keyword arguments - Add 4 BDD scenarios proving plan_env/project_env reach the resolver via ToolCallRouter (project-only, plan-only, both, neither) Dependency: requires PR #1135 to be merged first (adds CLI flag and persistence for project-level execution-env-priority). Closes #1080 ISSUES CLOSED: #1080	2026-03-31 11:31:00 +00:00
hamza.khyari	44e5eb9a94	Merge pull request 'test(integration): workflow example 5 — database schema migration with safety nets (review profile)' (#1042) from test/int-wf05-db-migration into master ... Reviewed-on: #1042	2026-03-31 11:26:27 +00:00
hamza.khyari	3f66221938	test(integration): workflow example 5 — database schema migration with safety nets (review profile) ... Robot Framework integration test suite for Specification Workflow Example 5: Database Schema Migration with Safety Nets. Exercises the review automation profile with custom resource types, custom skills with database tools, phased child plan execution, checkpointing, and rollback. - 7 test cases covering: custom resource type registration, review profile behavior, custom skill with 3 database tools, action creation with review profile, checkpoint/rollback via managers, 5-phase sequential SubplanService.spawn with fail-fast, and plan lifecycle through strategize-to-execute - Uses mocked LLM providers (CLEVERAGENTS_TESTING_USE_MOCK_AI=true) - All Run Process calls have timeout=60s on_timeout=kill - Fix environment-dependent test failures: mock shutil.disk_usage in disk space and diagnostics --check Behave steps so tests pass regardless of CI runner disk space; Robot diagnostics test tolerates disk-space errors ISSUES CLOSED: #769	2026-03-31 11:03:20 +00:00
brent.edwards	a5cc81354d	fix: add --required/--informational flags to validation add CLI ... Add --required and --informational as mutually exclusive boolean options to the `agents validation add` CLI command. When specified, they override the `mode` field from the YAML config file. This aligns the CLI with the specification (specification.md line 22339) which states the validation mode can be set "via --required/--informational on agents validation add". The fix resolves the spec contradiction by: - Implementing the flags in the CLI (per Core Concepts > Validation Mode) - Updating the formal CLI reference to include the new flags - Adding an exception to Design Principle #3 for validation add - Removing the spurious positional name argument from the walkthrough TDD tests from #1102 now run normally with @tdd_expected_fail removed. New edge-case tests cover mutual exclusivity (both flags rejected). Also excludes tool/wrapping.py from semgrep exec/compile rules since that module intentionally uses exec() in a controlled sandbox for the validation transform feature. ISSUES CLOSED: #1038	2026-03-31 07:42:06 +00:00
Luis Mendes	3f5ca4e869	feat(plugin): register spec-defined extension points in PluginManager ... Registered all 30 spec-defined extension points in the ExtensionPointRegistry with typed Protocol interfaces for each category: context strategies (12), output renderers (3), validation runners (2), tool providers (2), skill providers (2), resource handlers (2), A2A transports (2), event handlers (2), config sources (2), and safety guardrails (1). Added extension_protocols.py with Protocol definitions and extension_catalog.py with the registration catalog. Wired context subsystem to query context.* extension points at initialization. ISSUES CLOSED: #939	2026-03-31 03:58:43 +00:00
freemo	532ea100e3	Docs: updated spec with --image tag	2026-03-30 22:12:17 -04:00
freemo	8f104fab88	Docs: daily update to timeline	2026-03-30 22:12:17 -04:00
brent.edwards	84b0c10dbf	fix(cli): plan correct active-plan resolution in isolated environments (#1184) ... ## Summary - tighten `plan correct` active-plan fallback so it only runs for isolated `CLEVERAGENTS_HOME` mismatch cases and never when explicit DB env overrides are configured - narrow fallback exception handling in `_resolve_active_plan_id()` to expected DB/path/service failures; unexpected errors now surface instead of being silently swallowed - add BDD regression coverage for both safeguards in `features/consolidated_plan_misc.feature` + `features/steps/plan_cli_legacy_r2_steps.py` ## Validation - `nox -e lint`: PASS - `nox -e typecheck`: PASS - `nox -e unit_tests`: PASS - `nox -e integration_tests`: FAIL in current branch baseline (29 failing Robot integration tests in this environment) - `nox -e e2e_tests`: FAIL in current branch baseline (45 failing E2E tests in this environment) - `nox -e coverage_report`: PASS (97%) Closes #1025 Reviewed-on: #1184 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com> Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-03-31 01:49:16 +00:00
freemo	81c2878ec8	feat(mcp): implement lazy start/auto-stop and sandbox path rewriting for MCP tools ... Add lifecycle management and sandbox support for MCP tools: - McpClient: lazy start (server starts on first call_tool()), configurable idle timeout with auto-stop, health monitoring with automatic restart on server crash - McpRegistry: namespace-isolated tracking of multiple MCP servers with independent lifecycles - SandboxPathRewriter: bi-directional file path rewriting between host and sandbox workspaces using PathMapper - MCPCapabilityMetadata: structured exposure of full MCP server capabilities (tools, resources, prompts) - MCPToolDescriptor: extended with annotations field - MCPToolAdapter: capability_metadata property, enhanced source_metadata with server capabilities and tool annotations BDD scenarios: - 16 lifecycle scenarios (lazy start, auto-stop, health check, registry) - 10 sandbox path rewriting scenarios (arguments, responses, roundtrip) - All 42 existing MCP adapter scenarios continue to pass ISSUES CLOSED: #938	2026-03-30 22:42:15 +00:00
CoreRasurae	a4a6b061a6	fix(db): align v3_plans schema with specification DDL ... Aligned v3_plans table with specification DDL: 1. Added effective_profile_snapshot column (TEXT NOT NULL) for storing frozen JSON snapshot of automation profile at plan creation time. Added Pydantic field_validator ensuring the value is well-formed JSON. Validator catches RecursionError for deeply nested JSON, consistent with automation_profile deserialization hardening. Validator error message uses length-only to avoid potential information disclosure. Documented that the default "{}" exists for backward compatibility; new plans should explicitly set the snapshot. 2. Made root_plan_id NOT NULL — root plans self-reference their own plan_id, child plans reference the root ancestor. Added explicit ondelete="RESTRICT" FK policy for consistency with other FKs in the model. Documented known FK policy drift between ORM model (RESTRICT) and migrated databases (retained SET NULL) in the migration; data integrity is preserved by the NOT NULL constraint regardless. Moved root_plan_id self-reference resolution into a PlanIdentity model_validator so the domain model is consistent with the DB NOT NULL constraint before and after persistence (previously the resolution only happened in from_domain(), creating an asymmetry where root_plan_id was None in-memory but non-null after round-tripping through the database). 3. Made automation_profile NOT NULL with default "balanced". 4. Documented intentional deviation: phase default is "action" (code) vs "strategize" (spec) because the Action phase was added as a pre-Strategize setup step. 5. Created Alembic migration with backfill logic for existing rows. Root-ancestor backfill uses level-by-level propagation with a parent-readiness guard to correctly resolve plans at arbitrary hierarchy depth (3+ levels). Added safety bound (max 100 iterations) with logged error on exhaustion to guard against cycles in parent_plan_id. Merged batch_alter_table operations to avoid redundant full-table copies in SQLite batch mode. Migration backfill also handles empty-string automation_profile values. Documented downgrade limitation (backfill is not reversible). Orphan-row fallback now logs affected row count at WARNING level. Migration cycle-detection now logs affected plan_id values before the orphan fallback overwrites them. All migration SQL uses sa.text() for consistency with SQLAlchemy best practices. 6. Hardened automation_profile deserialization in to_domain() to catch ValueError (invalid StrEnum provenance), Pydantic ValidationError, and RecursionError (deeply nested JSON) in addition to JSONDecodeError and KeyError, preventing unreadable plans from corrupted DB rows. Applied the same defensive deserialization pattern to effective_profile_snapshot in to_domain(): corrupted JSON falls back to '{}' with a WARNING log instead of crashing the read path. Added TypeError to the effective_profile_snapshot exception list in to_domain() for consistency with the Pydantic validator. Logging of unparseable values uses length only to avoid potential information disclosure. 7. Used explicit None check (is not None) instead of truthiness for root_plan_id resolution in from_domain(), for effective_profile_snapshot in to_domain(), and in _serialize_automation_profile() for consistency. 8. Documented intentional column naming conventions vs spec DDL (e.g. automation_profile vs automation_profile_name, *_actor vs *_actor_name, processing_state vs state, v3_plans vs plans). Documented the semantic difference: automation_profile stores either a bare name or structured JSON with provenance, whereas the spec automation_profile_name stores a plain name. 9. Fixed benchmark plan constructors (plan_phase_migration_bench.py) that were missing the now- required root_plan_id and effective_profile_snapshot fields. 10. Replaced defensive getattr() with direct attribute access for effective_profile_snapshot in from_domain() and update(), since the field is now defined on the Plan domain model. 11. Fixed Any type annotation in test helper _make_plan() to use AutomationProfileRef | None for proper type safety. 12. Added BDD scenarios for PlanIdentity self-reference resolution, NULL effective_profile_snapshot constraint enforcement, valid-JSON-missing-profile_name-key deserialization, invalid-JSON and empty-string snapshot rejection by Pydantic validator, and corrupted effective_profile_snapshot DB fallback in to_domain(). 13. Extracted default automation profile name to a module-level constant (DEFAULT_AUTOMATION_PROFILE) to reduce sentinel duplication across models.py and repositories.py. 14. Centralised automation-profile serialisation into LifecyclePlanModel._serialize_automation_profile() to eliminate duplication between from_domain() and LifecyclePlanRepository.update(). 15. Fixed to_domain() root_plan_id type cast from str | None to str, reflecting the NOT NULL column constraint. 16. Added PlanIdentity model_validator that resolves None root_plan_id to plan_id at domain construction time, ensuring the domain model honours the spec DDL NOT NULL constraint regardless of persistence state. Simplified from_domain() root resolution accordingly. ISSUES CLOSED: #921	2026-03-30 23:40:36 +01:00
freemo	7b3fcaf466	feat(config): implement three-scope config resolution with local config file support ... Implement three-scope configuration resolution (local > project > global) with deep merge. Add ConfigScope enum, project-root discovery, and config.local.toml file support. Changes: - Add LOCAL to ConfigLevel enum and new ConfigScope enum (GLOBAL, PROJECT, LOCAL) - Implement discover_project_root() walking up from CWD for cleveragents.toml/.cleveragents - Implement config.local.toml file loading in ConfigService - Implement three-scope deep merge via _deep_merge() helper - Add read_project_config(), read_local_config(), read_merged_config() methods - Add write_scoped_config() for writing to any scope file - Update set_value() to accept optional scope parameter - Update resolve() with six-level precedence chain (CLI > env > local > project > global > default) - Update CLI config set with --scope flag (global/project/local) - Add config.local.toml to .gitignore and DEFAULT_IGNORE_PATTERNS - Add Behave BDD scenarios for three-scope resolution, deep merge, and project-root discovery ISSUES CLOSED: #937	2026-03-30 21:48:01 +00:00
freemo	603dc841b0	refactor(cli): move context commands to actor context subgroup ... Register context as a sub-app of the actor Typer group so commands are accessible under the canonical specification path `agents actor context`. The top-level `agents context` group remains as a deprecated alias (with Typer deprecated=True) for one release cycle. Key changes: - context.app registered under actor.app in main.py - `rm` subcommand renamed to `remove`; `rm` kept as hidden deprecated alias that prints a deprecation warning before delegating - Programmatic rm_command() deprecated in favor of remove_command() - Help text updated to reference canonical `agents actor context` paths - Behave and Robot tests updated to use canonical paths and renamed subcommand; assertion for context help lowercased for flexibility - All nox sessions pass: lint, typecheck, unit_tests (495 features, 12731 scenarios), coverage at 97% ISSUES CLOSED: #888	2026-03-30 21:39:26 +00:00
freemo	38e05ac45a	feat(correction): wire checkpoint rollback into correction service revert flow ... Implement the full correction-checkpoint rollback pipeline: - Workspace snapshots: CheckpointService.create_workspace_snapshot() creates diff-based checkpoints before decision execution, storing only changed file paths in metadata.extra["diff_paths"] - CorrectionService.revert_decisions(): new high-level entry point that creates a correction, computes impact, invokes checkpoint rollback, and archives artifacts in a single call - Physical artifact archival: CheckpointService.archive_artifacts() moves files to .cleveragents/archived_artifacts/ instead of just flagging metadata. CorrectionService._archive_decision_artifacts() delegates to this during revert execution - Selective rollback: CheckpointService.selective_rollback() wraps rollback_to_checkpoint with atomic semantics — captures HEAD before rollback and recovers on failure - Diff-based storage: _compute_diff_snapshot() computes changed paths between checkpoints via git diff; snapshots store diff manifest and SHA-256 hash in metadata - CLI: plan rollback now accepts --to-checkpoint <id> in addition to the positional checkpoint_id argument; uses selective_rollback for atomic execution - DI wiring: Container now injects checkpoint_service into CorrectionService; CLI correct command uses container-provided service instead of ad-hoc instance (fixes bug #986) - Checkpoint model: pre_decision added to allowed checkpoint_type values - TDD: Removed @tdd_expected_fail from wiring test feature since the DI bug is now fixed ISSUES CLOSED: #943	2026-03-30 17:06:49 -04:00
freemo	afe6b849fe	feat(cli): implement missing output element types and handles ... Implement LiveMaterializationStrategy as the third materialization strategy type (alongside sequential_buffer and accumulate) per spec §26456-26492. The live strategy renders element updates in-place at ~15 fps by tracking a dirty-element set and coalescing updates into frame redraws. RichMaterializer now extends LiveMaterializationStrategy instead of _BaseBufferStrategy, enabling supports_incremental_updates=True. Element rendering still delegates to the colour renderer for visual formatting, maintaining backward compatibility. Changes: - Add _LiveMaterializationStrategy class with frame-rate throttling, dirty-element tracking, and per-frame composition in declaration order - Update RichMaterializer to extend _LiveMaterializationStrategy - Export LiveMaterializationStrategy from materializers.py and __init__.py - Update SD-2 and SD-7 documentation in __init__.py - Add vulture whitelist entry for LiveMaterializationStrategy - Add 5 Behave scenarios covering live strategy rendering, incremental update support, dirty-element coalescing, all-element-type rendering, and frame rate validation - Add step definitions for the new scenarios ISSUES CLOSED: #903	2026-03-30 19:52:51 +00:00
freemo	297823c291	feat(cli): add actor context remove, export, and import commands ... Implement three new actor context subcommands as specified in the v3 CLI specification: - `agents actor context remove [--yes|-y] (--all|-a|<NAME>)`: Remove a named context or all contexts with interactive confirmation. Supports --all for bulk removal and --yes to skip prompts. - `agents actor context export (--output|-o) <FILE> <NAME>`: Export a named context to JSON or YAML (detected from file extension). Includes sha256 integrity checksum in output metadata. - `agents actor context import [--update] (--input|-i) <FILE> [<NAME>]`: Import a context from JSON or YAML. Name is inferred from file metadata if omitted. Refuses to overwrite existing contexts unless --update is specified. All commands: - Support 6 output formats (json, yaml, plain, table, rich, color) via the shared format_output framework - Use ContextManager for persistence (messages, metadata, state, global_context) - Follow existing error handling patterns (typer.Exit for user errors) - Are wired as `agents actor context` subcommand group via add_typer New files: - src/cleveragents/cli/commands/actor_context.py (command module) - features/actor_context_cmds.feature (Behave BDD scenarios) - features/steps/actor_context_cmds_steps.py (BDD step definitions) - robot/actor_context_export_import.robot (Robot integration test) ISSUES CLOSED: #869	2026-03-30 19:35:23 +00:00
freemo	a9465c4865	fix(cli): derive actor name from config file instead of positional argument ... Remove the <NAME> positional argument from `actor add` command. The actor name is now derived from the `name` field inside the config YAML file, per the specification: `agents actor add (--config|-c) <FILE> [--update]`. Updated all BDD and integration tests to pass name via config file. ISSUES CLOSED: #914	2026-03-30 18:27:59 +00:00