cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

feat(resource): implement ResourceHandler content_hash method #1066

Merged
hamza.khyari merged 1 commits from feature/resource-handler-content-hash into master 2026-04-01 13:41:52 +00:00
Conversation 2 Commits 1 Files Changed 12
+1496 -5
hamza.khyari commented 2026-03-19 04:14:29 +00:00
Member
Copy Link
Copy Source

Summary

Implements content_hash(resource, *, algorithm='sha256') -> str on the ResourceHandler protocol and all 4 concrete handlers plus the _DefaultHandler fallback.

Closes #837

Changes

Protocol (protocol.py)

New content_hash method added to ResourceHandler protocol.

Implementations

Handler Strategy Hash Source
BaseResourceHandler Default File content or directory entry names
GitCheckoutHandler git rev-parse HEAD Commit SHA re-hashed through algorithm
FsDirectoryHandler Recursive walk Sorted relative paths + file contents
DevcontainerHandler Config file .devcontainer/devcontainer.json
DatabaseResourceHandler Connection identity SQLite: file content; Remote: connection string
_DefaultHandler Delegates Uses BaseResourceHandler logic

Sentinel Value

EMPTY_CONTENT_HASH = SHA-256 of empty input. Returned for missing, empty, or inaccessible resources.

Algorithm Support

Configurable via algorithm parameter (default sha256). Accepts any hashlib.new()-compatible name.

Tests

10 Behave scenarios: sentinel hash, determinism, change detection, fs-directory recursive hash, git-checkout hash, configurable algorithm, protocol compliance.

Design Decisions

  • Content-only: Timestamps, permissions, and other metadata do not affect the hash
  • Deterministic: Same content always produces the same hash regardless of platform
  • Git handler: Uses commit SHA (not tree hash) because it captures the full state including history
  • Sentinel: SHA-256 of empty input is a natural choice (idempotent, well-known)
## Summary Implements `content_hash(resource, *, algorithm='sha256') -> str` on the `ResourceHandler` protocol and all 4 concrete handlers plus the `_DefaultHandler` fallback. Closes #837 ## Changes ### Protocol (`protocol.py`) New `content_hash` method added to `ResourceHandler` protocol. ### Implementations | Handler | Strategy | Hash Source | |---------|----------|-------------| | `BaseResourceHandler` | Default | File content or directory entry names | | `GitCheckoutHandler` | git rev-parse HEAD | Commit SHA re-hashed through algorithm | | `FsDirectoryHandler` | Recursive walk | Sorted relative paths + file contents | | `DevcontainerHandler` | Config file | `.devcontainer/devcontainer.json` | | `DatabaseResourceHandler` | Connection identity | SQLite: file content; Remote: connection string | | `_DefaultHandler` | Delegates | Uses BaseResourceHandler logic | ### Sentinel Value `EMPTY_CONTENT_HASH` = SHA-256 of empty input. Returned for missing, empty, or inaccessible resources. ### Algorithm Support Configurable via `algorithm` parameter (default `sha256`). Accepts any `hashlib.new()`-compatible name. ## Tests 10 Behave scenarios: sentinel hash, determinism, change detection, fs-directory recursive hash, git-checkout hash, configurable algorithm, protocol compliance. ## Design Decisions - **Content-only**: Timestamps, permissions, and other metadata do not affect the hash - **Deterministic**: Same content always produces the same hash regardless of platform - **Git handler**: Uses commit SHA (not tree hash) because it captures the full state including history - **Sentinel**: SHA-256 of empty input is a natural choice (idempotent, well-known)
freemo requested review from freemo 2026-03-19 05:21:34 +00:00
freemo requested review from brent.edwards 2026-03-19 05:21:34 +00:00
freemo added this to the v3.6.0 milestone 2026-03-19 05:28:02 +00:00
hamza.khyari self-assigned this 2026-03-19 12:55:01 +00:00
freemo commented 2026-03-22 16:35:52 +00:00
Owner
Copy Link
Copy Source

Planning review (Day 42):

  • Incorrect label: This PR is labeled bug but the title and body describe a new feature implementation (content_hash method). Should be Type/Feature per CONTRIBUTING.md conventions.

Otherwise looks good: milestone set (v3.6.0), closes #837, 2 reviewers assigned (freemo + brent.edwards).

**Planning review (Day 42):** - **Incorrect label**: This PR is labeled `bug` but the title and body describe a new feature implementation (`content_hash` method). Should be `Type/Feature` per CONTRIBUTING.md conventions. Otherwise looks good: milestone set (v3.6.0), closes #837, 2 reviewers assigned (freemo + brent.edwards).
freemo added the
Priority
Medium
State
In Review
Type
Feature
 labels 2026-03-23 03:33:51 +00:00
freemo approved these changes 2026-03-27 17:12:56 +00:00
Dismissed
freemo left a comment
Owner
Copy Link
Copy Source

Review: feat(resource): implement ResourceHandler content_hash method

Approved. Solid implementation with good test coverage.

Minor Suggestions

  • Base handler shallow dir hash: BaseResourceHandler.content_hash() only hashes sorted(os.listdir(path)) entry names, not content. All concrete handlers override this, but consider a more prominent warning in the docstring.
  • Private attribute mutation: _DefaultHandler.content_hash() creates a BaseResourceHandler() and mutates _default_strategy and _type_label — consider a factory method instead.
  • .gitignore exclusion: FsDirectoryHandler recursive walk hashes everything including .git/ directories. Consider excluding .git/ by default.

What's Good

  • Deterministic hashing per handler type: file content for fs, git rev-parse HEAD for git, devcontainer.json for devcontainer, connection-string for database.
  • Well-known sentinel EMPTY_CONTENT_HASH.
  • Chunked 64KB reads avoiding memory blowouts.
  • Configurable algorithm parameter.
  • 12 BDD scenarios covering sentinels, determinism, change detection, algorithm variation, and protocol compliance.
## Review: feat(resource): implement ResourceHandler content_hash method **Approved.** Solid implementation with good test coverage. ### Minor Suggestions - **Base handler shallow dir hash**: `BaseResourceHandler.content_hash()` only hashes `sorted(os.listdir(path))` entry names, not content. All concrete handlers override this, but consider a more prominent warning in the docstring. - **Private attribute mutation**: `_DefaultHandler.content_hash()` creates a `BaseResourceHandler()` and mutates `_default_strategy` and `_type_label` — consider a factory method instead. - **`.gitignore` exclusion**: `FsDirectoryHandler` recursive walk hashes everything including `.git/` directories. Consider excluding `.git/` by default. ### What's Good - Deterministic hashing per handler type: file content for fs, `git rev-parse HEAD` for git, devcontainer.json for devcontainer, connection-string for database. - Well-known sentinel `EMPTY_CONTENT_HASH`. - Chunked 64KB reads avoiding memory blowouts. - Configurable `algorithm` parameter. - 12 BDD scenarios covering sentinels, determinism, change detection, algorithm variation, and protocol compliance.
hamza.khyari force-pushed feature/resource-handler-content-hash from faba9a3ff3 to bb73838d93 2026-03-31 11:27:48 +00:00 Compare
hamza.khyari dismissed freemo's review 2026-03-31 11:27:48 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

hamza.khyari force-pushed feature/resource-handler-content-hash from bb73838d93 to 88334bfd33 2026-03-31 11:49:54 +00:00 Compare
hamza.khyari force-pushed feature/resource-handler-content-hash from 88334bfd33 to 3d7d32f671 2026-03-31 12:01:28 +00:00 Compare
hamza.khyari force-pushed feature/resource-handler-content-hash from 3d7d32f671 to ec249298fd 2026-03-31 12:19:03 +00:00 Compare
hamza.khyari force-pushed feature/resource-handler-content-hash from ec249298fd to f2bf356fbc 2026-03-31 14:12:59 +00:00 Compare
hamza.khyari force-pushed feature/resource-handler-content-hash from f2bf356fbc to a7e0c4094a 2026-03-31 14:19:04 +00:00 Compare
hamza.khyari force-pushed feature/resource-handler-content-hash from a7e0c4094a to fc8b943db7 2026-03-31 14:49:15 +00:00 Compare
hamza.khyari force-pushed feature/resource-handler-content-hash from fc8b943db7 to 027cee36ad 2026-03-31 15:22:21 +00:00 Compare
hamza.khyari force-pushed feature/resource-handler-content-hash from 027cee36ad to f57851c0ff 2026-03-31 15:42:28 +00:00 Compare
hamza.khyari force-pushed feature/resource-handler-content-hash from f57851c0ff to 56382af264 2026-04-01 12:34:34 +00:00 Compare
hamza.khyari force-pushed feature/resource-handler-content-hash from 56382af264 to 9e108eda1d 2026-04-01 13:01:19 +00:00 Compare
hamza.khyari force-pushed feature/resource-handler-content-hash from 9e108eda1d to 18b9d61e35 2026-04-01 13:02:48 +00:00 Compare
hamza.khyari scheduled this pull request to auto merge when all checks succeed 2026-04-01 13:40:02 +00:00
hamza.khyari merged commit 49058c3a72 into master 2026-04-01 13:41:52 +00:00
hamza.khyari deleted branch feature/resource-handler-content-hash 2026-04-01 13:41:59 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
brent.edwards
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Priority
Medium
State
In Review
Type
Feature
Milestone
No items
No Milestone v3.6.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees hamza.khyari
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cleveragents/cleveragents-core#1066
Delete Branch "feature/resource-handler-content-hash"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?