cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

feat(acms): implement DepthReductionCompressor for skeleton compression #1170

Merged
aditya merged 1 commits from feat/depth-reduction-compressor into master 2026-04-01 06:38:11 +00:00
Conversation 4 Commits 1 Files Changed 15
+1098 -20
aditya commented 2026-03-27 10:29:08 +00:00
Member
Copy Link
Copy Source

Summary

This PR closes the last missing production component in the ACMS context assembly pipeline by implementing DepthReductionCompressor for the skeleton-compression stage.

The change:

  • adds a production DepthReductionCompressor that re-renders inherited parent fragments to overview depths 0-1
  • resolves reduced detail levels through the UKO DetailLevelMap inheritance chain for code, language-specialized, document, data, infrastructure, and generic fragments
  • exports the compressor through cleveragents.application.services and makes ContextAssemblyPipeline default to it instead of the no-op skeleton compressor
  • adds BDD coverage for compressor behavior and for default pipeline wiring
  • updates CHANGELOG.md with the user-facing change entry required by the contribution guidelines

Motivation

Issue #919 identifies the skeleton-compression stage as the only remaining ACMS pipeline component that still lacked a production implementation. The repository already referenced builtin:DepthReductionCompressor in configuration, but no matching implementation existed. This PR brings the runtime behavior in line with the specification and closes that pipeline gap.

Validation

Completed locally:

  • nox -e lint
  • nox -e typecheck
  • nox -e unit_tests
  • nox -e integration_tests
  • nox -e coverage_report (97.47%)

Environment note:

  • nox -e e2e_tests is blocked locally because the real-provider E2E acceptance suites require external LLM credentials in this environment. The code changes for #919 do not touch those flows.

Closes #919

## Summary This PR closes the last missing production component in the ACMS context assembly pipeline by implementing `DepthReductionCompressor` for the skeleton-compression stage. The change: - adds a production `DepthReductionCompressor` that re-renders inherited parent fragments to overview depths 0-1 - resolves reduced detail levels through the UKO `DetailLevelMap` inheritance chain for code, language-specialized, document, data, infrastructure, and generic fragments - exports the compressor through `cleveragents.application.services` and makes `ContextAssemblyPipeline` default to it instead of the no-op skeleton compressor - adds BDD coverage for compressor behavior and for default pipeline wiring - updates `CHANGELOG.md` with the user-facing change entry required by the contribution guidelines ## Motivation Issue #919 identifies the skeleton-compression stage as the only remaining ACMS pipeline component that still lacked a production implementation. The repository already referenced `builtin:DepthReductionCompressor` in configuration, but no matching implementation existed. This PR brings the runtime behavior in line with the specification and closes that pipeline gap. ## Validation Completed locally: - `nox -e lint` - `nox -e typecheck` - `nox -e unit_tests` - `nox -e integration_tests` - `nox -e coverage_report` (`97.47%`) Environment note: - `nox -e e2e_tests` is blocked locally because the real-provider E2E acceptance suites require external LLM credentials in this environment. The code changes for #919 do not touch those flows. Closes #919
aditya added the
Type
Feature
 label 2026-03-27 10:29:36 +00:00
aditya added this to the v3.5.0 milestone 2026-03-27 10:29:36 +00:00
aditya force-pushed feat/depth-reduction-compressor from 262abdf7c8 to 292f38e4ae 2026-03-27 12:25:11 +00:00 Compare
aditya force-pushed feat/depth-reduction-compressor from 292f38e4ae to 01167602a9 2026-03-27 12:40:32 +00:00 Compare
freemo commented 2026-03-27 17:13:57 +00:00
Owner
Copy Link
Copy Source

Code Review Note

Unable to review — the branch feat/depth-reduction-compressor was not found on the remote. The branch may not have been pushed or may have a different name. Please verify the branch exists and update the PR if needed.

## Code Review Note **Unable to review** — the branch `feat/depth-reduction-compressor` was not found on the remote. The branch may not have been pushed or may have a different name. Please verify the branch exists and update the PR if needed.
freemo requested review from freemo 2026-03-28 21:28:09 +00:00
freemo requested review from CoreRasurae 2026-03-28 21:28:09 +00:00
freemo approved these changes 2026-03-30 04:21:31 +00:00
Dismissed
freemo left a comment
Owner
Copy Link
Copy Source

Review: APPROVED with Comments

Strong feature implementation with good BDD coverage.

Notes

  1. acms_skeleton_compressor.py at 579 lines slightly exceeds the 500-line guideline. The 5 render visitor classes could be extracted to a separate module.
  2. Breaking metadata type change: DepthBreadthProjector metadata values changed from int/bool to str. The step assertion was loosened to match. This could break downstream consumers — ensure nothing depends on the numeric types.
  3. Mixed concerns: The metadata type changes and import refactoring in depth_breadth_projection.py are separate from the compressor feature. Ideally separate commits.
  4. builtin: import path: getattr(builtin_services, class_name) without validation could import any public name. Consider an explicit allowlist.
## Review: APPROVED with Comments Strong feature implementation with good BDD coverage. ### Notes 1. **`acms_skeleton_compressor.py` at 579 lines** slightly exceeds the 500-line guideline. The 5 render visitor classes could be extracted to a separate module. 2. **Breaking metadata type change**: `DepthBreadthProjector` metadata values changed from `int`/`bool` to `str`. The step assertion was loosened to match. This could break downstream consumers — ensure nothing depends on the numeric types. 3. **Mixed concerns**: The metadata type changes and import refactoring in `depth_breadth_projection.py` are separate from the compressor feature. Ideally separate commits. 4. **`builtin:` import path**: `getattr(builtin_services, class_name)` without validation could import any public name. Consider an explicit allowlist.
freemo commented 2026-03-30 05:15:36 +00:00
Owner
Copy Link
Copy Source

Day 50 Planning — Branch availability required.

The branch feat/depth-reduction-compressor was reported as not found on remote since Day 48 (2026-03-27). This PR implements DepthReductionCompressor for ACMS skeleton compression (v3.5.0).

@freemo — Please push the branch or confirm status. This feature is part of the ACMS pipeline critical path. Without the branch, no review can proceed.

Reviewers have been assigned: @CoreRasurae and @brent.edwards.

Day 50 Planning — **Branch availability required.** The branch `feat/depth-reduction-compressor` was reported as not found on remote since Day 48 (2026-03-27). This PR implements DepthReductionCompressor for ACMS skeleton compression (v3.5.0). @freemo — Please push the branch or confirm status. This feature is part of the ACMS pipeline critical path. Without the branch, no review can proceed. Reviewers have been assigned: @CoreRasurae and @brent.edwards.
aditya force-pushed feat/depth-reduction-compressor from 01167602a9 to 92135ec0d6 2026-03-30 10:43:20 +00:00 Compare
aditya dismissed freemo's review 2026-03-30 10:43:20 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

aditya commented 2026-03-30 10:43:40 +00:00
Author
Member
Copy Link
Copy Source

@freemo addressed the review notes and force-pushed feat/depth-reduction-compressor on top of the latest master.

Updates from your comments:

  • extracted the skeleton render visitors into src/cleveragents/application/services/acms_skeleton_renderers.py so acms_skeleton_compressor.py stays under the size guideline
  • restored DepthBreadthProjector projected metadata values to native int/bool types so downstream consumers do not see the string coercion change
  • kept the depth_breadth_projection.py changes scoped to the compressor integration and child-focus prioritization, without the earlier metadata/import refactor drift
  • added an explicit builtin allowlist in ComponentResolver and covered the rejection path with the new features/component_resolver.feature scenario for builtin:ConfigService
@freemo addressed the review notes and force-pushed `feat/depth-reduction-compressor` on top of the latest `master`. Updates from your comments: - extracted the skeleton render visitors into `src/cleveragents/application/services/acms_skeleton_renderers.py` so `acms_skeleton_compressor.py` stays under the size guideline - restored `DepthBreadthProjector` projected metadata values to native `int`/`bool` types so downstream consumers do not see the string coercion change - kept the `depth_breadth_projection.py` changes scoped to the compressor integration and child-focus prioritization, without the earlier metadata/import refactor drift - added an explicit builtin allowlist in `ComponentResolver` and covered the rejection path with the new `features/component_resolver.feature` scenario for `builtin:ConfigService`
aditya force-pushed feat/depth-reduction-compressor from 92135ec0d6 to 87ef5a4bba 2026-03-30 14:20:49 +00:00 Compare
aditya force-pushed feat/depth-reduction-compressor from 87ef5a4bba to 4b973c56c5 2026-03-30 14:21:23 +00:00 Compare
aditya scheduled this pull request to auto merge when all checks succeed 2026-03-30 14:21:36 +00:00
aditya force-pushed feat/depth-reduction-compressor from 4b973c56c5 to 1923496c14 2026-03-31 06:35:05 +00:00 Compare
aditya force-pushed feat/depth-reduction-compressor from 1923496c14 to 151bc1bf99 2026-03-31 07:59:08 +00:00 Compare
aditya force-pushed feat/depth-reduction-compressor from 151bc1bf99 to cf4bee72d5 2026-03-31 08:34:27 +00:00 Compare
aditya force-pushed feat/depth-reduction-compressor from cf4bee72d5 to b30461e5be 2026-03-31 08:43:44 +00:00 Compare
aditya force-pushed feat/depth-reduction-compressor from b30461e5be to 8c5016389e 2026-03-31 11:36:29 +00:00 Compare
aditya force-pushed feat/depth-reduction-compressor from 8c5016389e to d4a5d2ebdc 2026-03-31 13:53:58 +00:00 Compare
aditya force-pushed feat/depth-reduction-compressor from d4a5d2ebdc to b0d5204567 2026-03-31 14:03:16 +00:00 Compare
aditya force-pushed feat/depth-reduction-compressor from b0d5204567 to 137d040c4d 2026-04-01 06:16:43 +00:00 Compare
aditya merged commit b579178b67 into master 2026-04-01 06:38:11 +00:00
aditya deleted branch feat/depth-reduction-compressor 2026-04-01 06:38:11 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
CoreRasurae
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Type
Feature
Milestone
No items
No Milestone v3.5.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cleveragents/cleveragents-core#1170
Delete Branch "feat/depth-reduction-compressor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?