730 Commits

Author	SHA1	Message	Date
freemo	4221582368	feat(acms): implement pipeline Phase 3 components ... Implemented the remaining ACMS pipeline components and advanced context strategies: Pipeline Phase 3: - FragmentOrdererProtocol + RelevanceCoherenceOrderer: orders fragments by relevance while maintaining narrative coherence via UKO node prefix grouping. Groups related fragments together, sorts groups by max relevance, and within groups orders by relevance desc / depth asc. - PreambleGeneratorProtocol + ProvenancePreambleGenerator: generates provenance preamble with strategy contributions (fragment counts and token percentages), confidence indicators (avg/min/max), tier and depth distribution, UKO node coverage, and coverage gap detection. Advanced Strategies: - ArceStrategy (quality 0.95): adaptive recursive context expansion with iterative multi-backend refinement and configurable iteration limit (default 5) to prevent unbounded refinement. Uses composite scoring (relevance + depth + diversity) with contextual boosting for fragments related to the current top-ranked anchor set. - TemporalArchaeologyStrategy (quality 0.5): historical context retrieval from graph+cold backends. Prioritises cold-tier fragments using a temporal scoring model (tier bonus + relevance + depth). - PlanDecisionContextStrategy (quality 0.7): decision history retrieval from warm/cold backends. Prioritises warm then cold tier fragments for correction and retry scenarios. All strategies registered in strategy registry with correct quality scores and backend requirements. All components implement their respective Protocol interfaces and can be injected into the ContextAssemblyPipeline via constructor dependency injection. Tests: - 33 BDD scenarios in features/acms_pipeline_phase3.feature - Robot Framework integration tests in robot/acms_pipeline_phase3.robot - ASV performance benchmarks in benchmarks/acms_pipeline_phase3_bench.py ISSUES CLOSED: #545	2026-03-07 14:53:18 +00:00
brent.edwards	775d72dcf4	Merge remote-tracking branch 'https-origin/master' into HEAD ... # Conflicts: # CHANGELOG.md # behave.ini	2026-03-07 02:46:14 +00:00
brent.edwards	50228dfe4e	fix(test): use in-memory SQLite for Robot git-checkout resource add test ... The "Resource Add Git Checkout Should Not Fail With Type Not Found" Robot test was calling the CLI process directly, which hits the real database file that does not exist in CI — causing sqlite3.OperationalError. Rewrite the test to use an in-memory SQLite database with register_resource(), matching the pattern used by the fs-directory Robot tests. Also fix common.resource path to use ${CURDIR}/common.resource. Refs: #524	2026-03-07 02:43:49 +00:00
brent.edwards	ee59f8c2ab	Merge branch 'master' into HEAD ... # Conflicts: # CHANGELOG.md	2026-03-07 02:25:07 +00:00
brent.edwards	8c7497ddb3	Merge branch 'master' into HEAD ... # Conflicts: # CHANGELOG.md	2026-03-07 02:09:56 +00:00
hamza.khyari	04f24b39c0	feat(acms): implement UKO Layer 1 Domain Ontologies (uko-code, uko-doc, uko-data, uko-infra) ... Implement the four Layer 1 domain-specific OWL/Turtle ontology vocabularies that specialize Layer 0 universal concepts for specific knowledge domains. Ontology (docs/ontology/uko.ttl): - Added uko-doc: namespace with 17 classes (Document, Part, Chapter, Section, Subsection, Paragraph, Sentence, CodeBlock, Citation, Figure, Table, Footnote, Annotation, Bookmark, CrossReference, PageBreak, SectionBreak), 5 properties, and 4 relationships - Added uko-data: namespace with 13 classes (Schema, Table, Column, View, StoredProcedure, Constraint, Index, ForeignKey, Trigger, Annotation, Bookmark, PartitionBoundary, ShardBoundary), 6 properties, and 5 relationships - Added uko-infra: namespace with 7 classes (Service, Network, Endpoint, ConfigKey, Volume, FirewallRule, SubnetBoundary) and 2 relationships - All classes use rdfs:subClassOf from Layer 0 base classes Domain registry (ontology_registry.py): - DomainDescriptor dataclass with namespace IRI, prefix, layer, classes, superclass mappings, and DetailLevelMap - Registry functions: get_domain(), list_domains(), get_layer1_domains() - DetailLevelMap chain builder for hierarchical depth resolution - Turtle validation with TurtleValidationError (no rdflib dependency) - All DetailLevelMap data inlined to maintain DIP compliance (domain layer does not import from application layer) DetailLevelMap presets (depth_breadth_projection.py): - code_detail_map: 10 spec-complete levels (depths 0-9) - docs_detail_map: 11 spec-complete levels (depths 0-10) - database_detail_map: 12 spec-complete levels (depths 0-11) - infra_detail_map: 9 spec-complete levels (depths 0-8) Tests: - 31 BDD scenarios in uko_ontology_registry.feature covering domain lookup, all DetailLevelMap levels, inheritance chains, Turtle validation, Universal View Guarantee, and negative/edge cases - 6 Robot Framework integration tests - Updated existing tests: depth_breadth_projection.feature (TABLE_LISTING depth 0->1, added SCHEMA_LISTING), uko_ontology.feature (Layer 1 node count 8->67) Spec reference: docs/specification.md §41830-42332 ISSUES CLOSED: #574	2026-03-06 23:14:30 +00:00
brent.edwards	dc1ecaab47	test(resource): add failing tests for built-in fs-directory type bootstrap ... Add TDD-style Behave BDD tests for the built-in fs-directory resource type bootstrap (bug #523). Three Gherkin scenarios: one failing TDD test reproducing the bug (no bootstrap called during init, tagged @wip), and two regression tests verifying bootstrap_builtin_types() seeds correct data and resource add fs-directory succeeds after bootstrap. Includes Robot Framework regression tests. Review feedback addressed: - Removed all 21 unnecessary # type: ignore comments (hurui200320 M1) - Fixed is not True to is False for clarity (Aditya F2) - Fixed Robot common.resource path to ${CURDIR}/common.resource (hurui200320 L1) - Squashed all commits into one and rebased onto master (C1, C2) - Added CHANGELOG entry with correct scenario count Closes #537	2026-03-06 20:44:36 +00:00
brent.edwards	4e3bf7d3ad	test(cli): add failing tests for agents init --yes missing option ... Add TDD-style Behave BDD tests for the missing agents init --yes flag (bug #522). Five Gherkin scenarios cover: exit code validation, prompt suppression, -y alias, output summary fields, and interactive-mode regression guard. Includes Robot Framework smoke tests (tagged @wip) and ASV benchmarks. Configure behave.ini to exclude @wip scenarios globally and noxfile.py to exclude wip-tagged Robot suites, so TDD-failing tests do not break CI. Review feedback addressed: - Remove unnecessary # type: ignore from benchmark (outside Pyright scope) - Fix Then...Then to Then...And in Gherkin (L1) - Fix CHANGELOG 'three scenarios' to 'five scenarios' (L2) - Add behave.ini documentation for @wip workaround (Aditya F1) - Rename Scenario 2 title to 'suppresses interactive prompts' (Aditya F2) Closes #536	2026-03-06 20:28:37 +00:00
hamza.khyari	77db78d768	feat(acms): add PostgreSQL and Docker Compose domain analyzers (#588) ... Add Phase 2 domain-specific analyzers for the ACMS UKO indexing pipeline: - PostgreSQLAnalyzer: regex-based DDL parser extracting uko-data:Table, Column, ForeignKey, View, and Schema triples with column metadata (data type, nullability, primary key constraints). - DockerComposeAnalyzer: YAML-based parser extracting uko-infra: DeploymentUnit, Service, Port, EnvironmentVariable, and connectsTo triples. Validates Compose format via services/version key detection. Both satisfy AnalyzerProtocol and register in AnalyzerRegistry by file extension (.sql/.ddl and .yml/.yaml respectively). Includes 34 Behave BDD scenarios (protocol conformance, registry ops, triple extraction for all 4 analyzers, error handling, cross-analyzer URI scheme and confidence checks), 6 Robot Framework integration smoke tests, updated __init__.py exports, vulture whitelist, and CHANGELOG.	2026-03-06 19:56:21 +00:00
CoreRasurae	23803f14ec	feat(lsp): add LSP server stub ... Added minimal LSP server entrypoint supporting initialize/shutdown/exit handshake over JSON-RPC stdin/stdout transport with Content-Length framing. Unsupported methods return MethodNotFound error with descriptive message. Wired LSP requests through ACP facade in local mode. Added agents lsp serve CLI command with --log-level flag, PID output, and startup banner. Created reference documentation for the stub server. Includes Behave BDD tests for protocol handshake, Robot smoke test, and ASV startup latency benchmark. ISSUES CLOSED: #203	2026-03-06 18:16:47 +00:00
aditya	3d2b138379	Merge branch 'master' into feature/m6plus-event-bus	2026-03-06 12:44:37 +00:00
hurui200320	09d92ac67b	test(e2e): validate M4 acceptance criteria for v3.3.0 milestone closure (#560) ... ## Summary Validates all M4 acceptance criteria for v3.3.0 milestone closure. Adds CLI-exercising integration tests for the three subplan commands that lacked actual CLI invocation, fixes a pre-existing unit test failure, and corrects CONTRIBUTORS.md ordering. ## Changes ### New CLI Integration Tests (Robot Framework) Three new test cases in `robot/m4_e2e_verification.robot` with helper functions in `robot/helper_m4_e2e_verification.py`: | Test | CLI Command | Mocking Approach | |------|-------------|-----------------| | `CLI Plan Use Creates Plan With Subplan Config` | `plan use local/refactor-action local/monorepo` | Patches `_get_lifecycle_service`; mocks `get_action_by_name` + `use_action` | | `CLI Plan Execute Transitions With Subplans` | `plan execute <plan_id>` | Patches `_get_lifecycle_service`; mocks `get_plan` + `execute_plan` | | `CLI Plan Tree Displays Subplan Hierarchy` | `plan tree <plan_id> --format json` | Patches `get_container`; real `Decision` objects with `SUBPLAN_SPAWN`/`SUBPLAN_PARALLEL_SPAWN` types | All three follow the same pattern as the existing `plan-diff` test: Typer `CliRunner.invoke()` with mocked services. ### Pre-existing Unit Test Fix **File:** `features/steps/repositories_uncovered_branches_steps.py` **Scenario:** `repo branch cov upsert profile with schema version mismatch` (line 110) **Root cause:** Plain `sessionmaker` returns a new session per call. The `Given` step inserted via session A and committed session B (different session), so the `When` step's session C couldn't see the uncommitted data. **Fix:** Changed to `scoped_session(sessionmaker(...))` so all factory calls return the same thread-local session. ### Other Fixes - **CONTRIBUTORS.md**: Moved "Rui Hu" to correct alphabetical position (between Freeman and Khyari) - **CHANGELOG.md**: Updated #495 entry to document CLI test additions ## M4 Acceptance Criteria Verification All 7 criteria exercised by 10 E2E tests (7 existing + 3 new) + 8 smoke tests: | # | Criterion | Test(s) | Status | |---|-----------|---------|--------| | 1 | Subplans spawned during Execute via SubplanConfig | `spawn-subplans`, **`cli-plan-use`**, **`cli-plan-execute`** | PASS | | 2 | Parallel execution with max_parallel bounds | `parallel-exec` | PASS | | 3 | Three-way merge combines non-conflicting changes | `merge-clean` | PASS | | 4 | Merge conflicts surfaced with git markers | `merge-conflict` | PASS | | 5 | Parent plan tracks subplan statuses | `parent-tracking` | PASS | | 6 | Plan tree displays subplan hierarchy | `plan-tree`, **`cli-plan-tree`** | PASS | | 7 | Plan diff shows merged results | `plan-diff` (already uses CLI) | PASS | ## Quality Gates | Stage | Result | |-------|--------| | lint | pass | | format | pass (1074 files unchanged) | | typecheck | pass (0 errors) | | unit_tests | 8524 scenarios, 0 failures | | integration_tests | 1110/1118 pass (8 pre-existing failures in `cli_plan_context_commands.robot`, identical on master) | | coverage_report | 97% (threshold: 97%) | | security_scan | pass | | dead_code | pass | | docs | pass | | build | pass | | benchmark | pass | ## Files Changed - `CHANGELOG.md` — Updated #495 entry - `CONTRIBUTORS.md` — Fixed alphabetical ordering - `features/steps/repositories_uncovered_branches_steps.py` — `scoped_session` fix - `robot/helper_m4_e2e_verification.py` — 3 new helper functions + imports - `robot/m4_e2e_verification.robot` — 3 new test cases ISSUES CLOSED: #495 Reviewed-on: #560 Reviewed-by: Luis Mendes <luis.mendes@cleverthis.com> Co-authored-by: Rui Hu <rui.hu@cleverthis.com> Co-committed-by: Rui Hu <rui.hu@cleverthis.com>	2026-03-06 03:22:45 +00:00
hamza.khyari	b028c80cab	feat(acms): add scoped backend view filtering ... Add project-resource isolation to the ACMS context tier system via ScopedBackendView, ResourceScope, alias resolution, DAG expansion, and enforcement hooks. Core types (scoped_view.py): ResourceScope, ScopeViolationError, ScopedBackendView, ScopedBackendSet, create_scoped_backend_set. Scope resolution (scope_resolution.py): ResourceAliasResolver, validate_project_scope, validate_resource_scope, resolve_resource_scope with registry_lookup callback for DAG expansion. Tier integration (scoped_tiers.py): ScopedTierMixin with get_scoped, get_scoped_by_resource, validate_fragment_scope, store_with_scope_check, get_scoped_metrics mixed into ContextTierService. Backward compat: tiers.py re-exports ScopedBackendView. Tests: 74 Behave scenarios (235 steps), 8 Robot Framework cases, 7 ASV benchmark suites. Lint and typecheck clean. ISSUES CLOSED: #193	2026-03-06 00:49:33 +00:00
khyari hamza	1521c4ae8c	feat(acms): add context strategy registry ... Implement the ACMS context strategy registry per spec §25162-25233, §28682-28708, §42628-42653, and §43167-43199. - Define ContextStrategy protocol, StrategyCapabilities, BackendSet, PlanContext, StrategyConfig, ContextStrategyResult models - Add 6 built-in stub strategies (simple-keyword, semantic-embedding, breadth-depth-navigator, arce, temporal-archaeology, plan-decision-context) with spec quality scores and feature flags - Add StrategyRegistry with register, register_from_module (plugin discovery), enable/disable, per-strategy config, and validation - Add ContextStrategyResult with deterministic fragment ordering (-relevance_score, uko_node) - Add configuration-driven enabled list with per-project overrides - Add per-strategy timeout, max-fragment, circuit-breaker config - Add registry validation for resource types and backend capabilities - Fix update_config to sync _enabled_order when toggling enabled flag - Fix register_from_module to honour the name parameter as registry key - Fix update_config to re-run Pydantic validators via model_validate - Add docs/reference/context_strategies.md - Add 55 BDD scenarios (Behave), 4 Robot integration tests, ASV benchmarks ISSUES CLOSED: #191	2026-03-05 22:00:15 +00:00
brent.edwards	0dfcdc641f	Merge branch 'master' into feature/m3-test-resource-bootstrap-git	2026-03-05 21:54:22 +00:00
freemo	fae438a7a7	refactor(acms): unify ContextFragment model hierarchies by extending CRP base types ... Core domain types (FragmentProvenance, ContextFragment, ContextBudget, ContextPayload) now extend their CRP counterparts via Pydantic v2 inheritance, ensuring isinstance compatibility across the model hierarchy. Key changes: - CRP base types made frozen=True (no consumer mutates them) - CRP AssembledContext fields changed from list to tuple (frozen consistency) - Core types extend CRP bases: FragmentProvenance(CRPFragmentProvenance), ContextFragment(CRPContextFragment), ContextBudget(CRPContextBudget), ContextPayload(CRPAssembledContext) - Removed duplicate ContextFragment dataclass from skeleton_compressor - Updated project_context.py to pass tuples to frozen AssembledContext - Added Behave tests (10 scenarios), Robot integration tests (3 cases), and ASV benchmarks for the unified hierarchy - Updated Known Limitations table in docs/reference/acms.md ISSUES CLOSED: #569	2026-03-05 21:38:55 +00:00
brent.edwards	7b3743f9bf	Merge branch 'master-latest' into feature/m3-test-resource-bootstrap-git ... # Conflicts: # CHANGELOG.md	2026-03-05 20:46:01 +00:00
brent.edwards	63764d68eb	fix(test): address hamza.khyari review #1986 findings on git-checkout bootstrap tests ... - SPEC-1: Added genuine TDD failing Scenario 1 (@wip) that creates registry WITHOUT bootstrap and asserts git-checkout exists — reproduces bug #524. Existing scenarios retained as regression tests (no @wip since they pass). Added NOTE FOR FIX AUTHOR comment documenting fix-path expectations. - BUG-1: Removed colliding @when('I run "agents resource add..."') step. Replaced with uniquely-prefixed bootstrap-git step pattern that invokes resource_add() directly with mocked DI, avoiding AmbiguousStep collision with wildcard @when('I run "{command}"') in cli_plan_context_commands_steps. - BUG-2: Removed duplicate @then('the CLI exit code should be {code:d}'). Replaced with prefixed bootstrap-git assertion steps. - BUG-3: Removed duplicate @then('the CLI output should not contain..."). Replaced with prefixed bootstrap-git assertion steps. - TEST-1: Replaced bare MagicMock() with direct service patching via _PATCH_SERVICE, consistent with PR #567 pattern. - TEST-2: Updated Robot docs from 'expected to FAIL' to 'regression tests' since both Robot tests call bootstrap explicitly and pass. - CODE-1: Simplified hasattr guards on enum fields — removed redundant hasattr checks, using .value directly since ResourceKind and SandboxStrategy are always enums. - TEST-3: Added assertion on bootstrap_builtin_types() return value via new Then step 'the bootstrap-git registered types should include'. - Updated CHANGELOG from 'Two scenarios' to 'Three scenarios'. Refs: #553	2026-03-05 20:36:05 +00:00
freemo	d990fc1b41	feat(uko): add analyzer plugin framework and initial domain analyzers ... Implemented the analyzer plugin framework with AnalyzerProtocol, AnalyzerRegistry for registration/discovery by file extension, PythonAnalyzer (AST-based extraction of modules, classes, functions, imports, docstrings), and MarkdownAnalyzer (section, code block, and link extraction). Both analyzers produce well-formed UKO triples with proper URI schemes. ISSUES CLOSED: #551	2026-03-05 19:20:39 +00:00
freemo	1d15eca866	feat(acms): implement depth/breadth projection system ... Add the Depth/Breadth Projection System and Skeleton Context Propagation as specified in docs/specification.md §25265-25340 and §43057-43128: - ProjectionSpec: frozen Pydantic model capturing a projection request (focus, breadth, depth, gradient, domain) - ProjectedNode: frozen model for materialized graph nodes with resolved depth and distance - DepthBreadthProjector: stateless BFS projector over UKO graph adjacency with depth gradient (linear reduction by distance) - PlanContextInheritance: service computing child plan context from parent assembled context with skeleton injection - ChildContextResult: frozen result model with request and skeleton - InheritanceConfig: frozen config for skeleton_ratio (default 0.2) - Built-in DetailLevelMap presets for code, docs, and database Includes 27 Behave BDD scenarios, 9 Robot Framework integration tests, and ASV benchmarks for all components. ISSUES CLOSED: #544	2026-03-05 15:42:20 +00:00
freemo	fe7381c45b	feat(acms): implement pipeline Phase 2 components ... Add production-grade Phase 2 (Fragment Fusion) components for the ACMS context assembly pipeline, replacing the no-op defaults: - ContentHashDeduplicator: Groups fragments by UKO node URI, hashes content to detect duplicates, retains highest relevance_score. - MaxDepthResolver: Resolves depth conflicts by keeping the highest detail depth per UKO node, with relevance tiebreaking. - WeightedCompositeScorer: Computes composite score from configurable weighted factors (relevance=0.4, hierarchy=0.3, quality=0.2, recency=0.1). Stores component breakdown in metadata. - GreedyKnapsackPacker: Greedy knapsack selection with depth fallback (tries depths [9,4,2,0] for oversized fragments) and minimum fragment token threshold (10). Also adds: - ScoredFragment frozen Pydantic model (spec §42825) with composite_score, score_components, and fragment reference - score_detailed() method on WeightedCompositeScorer returning ScoredFragment objects for callers needing full breakdowns - All components implement v1 Protocol signatures from acms_service.py and can be DI-injected into ACMSPipeline constructor Testing: - 31 Behave BDD scenarios in acms_pipeline_phase2.feature covering deduplication, depth resolution, scoring, packing, depth fallback, budget constraints, pipeline integration, and ScoredFragment model - 6 Robot Framework integration smoke tests - ASV benchmark suites for all 4 components and ScoredFragment Quality gates: lint, typecheck (0 errors), unit_tests (8555 scenarios), coverage (97.0%), dead_code — all passing. ISSUES CLOSED: #540	2026-03-05 10:27:36 -05:00
freemo	34f9a587cf	feat(acms): implement pipeline orchestrator and Phase 1 components ... Add production-quality Phase 1 pipeline components for the ACMS Context Assembly Pipeline: - ConfidenceWeightedSelector: strategy selection with preference boosting and confidence-based ranking - ProportionalBudgetAllocator: proportional token budget distribution with min_useful_budget enforcement and largest-remainder rounding - ParallelStrategyExecutor: concurrent strategy execution via ThreadPoolExecutor with per-strategy timeouts and circuit breaking - CircuitBreaker: per-strategy failure tracking with configurable threshold and explicit reset - ContextAssemblyPipeline: extends ACMSPipeline with Phase 1 production components and per-stage timing (StageTimings) Includes 28 Behave BDD scenarios, 9 Robot Framework integration tests, and ASV benchmarks for all components. ISSUES CLOSED: #539	2026-03-05 15:13:19 +00:00
hurui200320	cb1403c24d	test(e2e): validate M3 acceptance criteria for v3.2.0 milestone closure (#559) ... ## Summary Validates all 10 M3 (v3.2.0) acceptance criteria via the E2E verification suite. This is the final gate before closing milestone v3.2.0. ### Single Commit (Squashed per CONTRIBUTING.md) Branch history was squashed from 2 commits into 1 (`e1665c6e`) to comply with the one-commit-per-issue rule. The single commit includes: 1. **Original work**: Suite-level Force Tags, per-test acceptance criteria tags, enhanced documentation with milestone cross-references, CHANGELOG and CONTRIBUTORS entries. 2. **Review feedback fixes** (addressing Luis's CRITICAL/HIGH findings): Replaced fixture-self-assertion patterns with real CLI-path validation for all 10 acceptance criteria, added persistence-backed decision tree checks, robust JSON output parsing, explicit Robot process timeouts, and clearer correction tags. 3. **Rebase onto current master** (`fff6bb38`): Clean rebase resolving CHANGELOG conflict, as requested by PM (freemo). 4. **Bug fix — `async_enabled` attribute**: `PlanLifecycleService.execute_plan()` accesses `self.settings.async_enabled` (`plan_lifecycle_service.py:283`). The test helper's `_make_settings()` used `create_autospec(Settings)` but didn't set this attribute, causing `plan execute` CLI tests to fail with `AttributeError`. Fixed by adding `settings.async_enabled = False`. 5. **Timeout fixes for parallel execution**: When `pabot` runs 16 parallel Robot processes, cold-start import times + Alembic migrations cause 30s timeouts to be insufficient. Increased timeouts from 30s to 120s in 3 robot files: `actor_context_management.robot`, `decision_di_wiring_smoke.robot`, `changeset_persistence.robot`. ### Files Changed (7) | File | Change | |------|--------| | `robot/helper_m3_e2e_verification.py` | Rewritten for real CLI-path validation; `_make_settings()` fixed with `async_enabled = False` | | `robot/m3_e2e_verification.robot` | Force Tags, per-test tags, timeouts, enhanced docs | | `robot/actor_context_management.robot` | Timeout 30s → 120s (line 92) | | `robot/decision_di_wiring_smoke.robot` | Timeout 30s → 120s (lines 14, 21) | | `robot/changeset_persistence.robot` | `${TIMEOUT}` 30s → 120s (line 12) | | `CHANGELOG.md` | Entry for #494 | | `CONTRIBUTORS.md` | Added Rui Hu | ### Acceptance Criteria Verified (10/10) **Success Criteria:** - `plan use` + `plan execute` generates decisions during Strategize - `plan tree` displays decision tree correctly (via CLI invocation) - `plan explain` shows full decision context (via CLI invocation) - `invariant add --project` / `invariant list --project` work with project scope - `plan correct --dry-run` performs impact analysis (via CLI invocation) - `plan correct --mode=revert` executes live correction (via CLI invocation) **Technical Criteria:** - Decisions recorded with full context snapshot - Decision tree persists to database and renders correctly - Correction in revert mode re-executes from decision point - Invariants enforced during strategize ### Quality Gates (Full Nox Suite) | Session | Result | Details | |---------|--------|---------| | `lint` | PASS | ruff clean | | `format` | PASS | ruff format clean | | `typecheck` | PASS | pyright 0 errors, 0 warnings | | `security_scan` | PASS | bandit clean | | `dead_code` | PASS | vulture clean | | `unit_tests` | PASS | 8500 BDD scenarios, 0 failures | | `integration_tests` | PASS | 1194/1194 tests, 0 failures | | `docs` | PASS | mkdocs build clean | | `build` | PASS | wheel built | | `benchmark` | PASS | performance benchmarks pass | | `coverage_report` | PASS | 96.96% → rounds to 97% (meets `--fail-under=97`) | Closes #494 Reviewed-on: #559 Reviewed-by: Luis Mendes <luis.mendes@cleverthis.com> Co-authored-by: Rui Hu <rui.hu@cleverthis.com> Co-committed-by: Rui Hu <rui.hu@cleverthis.com>	2026-03-05 15:09:19 +00:00
freemo	10abf8985e	feat(acms): add ContextFragment and ScoredFragment data models ... Created ScoredFragment frozen model wrapping ContextFragment with composite_score, score_breakdown, and rank fields. Added pipeline- specific fragment models in domain/contexts/ with proper equality based on uko_uri + detail_depth for deduplication support. ISSUES CLOSED: #538	2026-03-05 14:11:23 +00:00
freemo	487e16a9f0	feat(acms): implement context strategies batch 1 ... Implement the first three built-in context strategies for the ACMS v1 context assembly pipeline: 1. SimpleKeywordStrategy (quality 0.3) - Keyword matching on fragment content with word-density fallback. Universal fallback strategy. 2. SemanticEmbeddingStrategy (quality 0.6) - Jaccard word-overlap similarity scoring between query and fragment content. 3. BreadthDepthNavigatorStrategy (quality 0.85) - UKO node hierarchy navigation prioritising fragments near focus nodes with higher detail depths. Primary strategy for code projects. All strategies implement the v1 ContextStrategy Protocol from acms_service.py and can be registered with ACMSPipeline via register_strategy(). Includes: - 28 Behave BDD scenarios covering ranking, budget, capabilities, can_handle confidence, explain, empty input, and pipeline registration - 9 Robot Framework integration tests - ASV benchmarks at 10/100/1000 fragment scales for all 3 strategies - Vulture whitelist entries for public API symbols - 100% coverage on context_strategies.py ISSUES CLOSED: #541	2026-03-05 12:58:57 +00:00
aditya	7ab5d8661a	Merge branch 'master' into feature/m5-subplan-actor	2026-03-05 06:35:45 +00:00
khyari hamza	febea8950f	feat(acms): add ACMS v1 context pipeline ... Implement the 10-component pluggable ACMS context assembly pipeline with three built-in strategies (relevance, recency, tiered), DI-based component injection, ULID-validated plan_id, largest-remainder budget allocation, and frozen Pydantic v2 domain models. Closes #188	2026-03-05 01:28:50 +00:00
brent.edwards	6b59c2f58c	Merge branch 'master' into feature/m3-test-resource-bootstrap-git	2026-03-04 23:52:38 +00:00
CoreRasurae	837ff4217b	feat(async): add async command execution and workers ... - Add AsyncJob domain model with status state machine and Pydantic validation - Add AsyncWorker service with configurable concurrency and job store - Add CancellationToken, WorkerHealthReport, InMemoryJobStore - Add AsyncJobModel SQLAlchemy model and Alembic migration (m6_003) - Add 5 async config keys to Settings (worker_id, concurrency, poll_interval, max_retries, timeout) - Add _check_async_worker_health diagnostic check in system.py - Add comprehensive Behave BDD tests (~60 scenarios) with full step definitions - Add Robot Framework integration tests (6 smoke tests) - Add ASV benchmark suite for async execution - Add architecture documentation - Update vulture_whitelist with new public API symbols - All quality gates pass: lint, typecheck, unit_tests, integration_tests, coverage_report (97%) 1. Wire async job creation into PlanLifecycleService: - Add optional job_store parameter to __init__ - Add _maybe_enqueue_async_job() helper that checks settings.async_enabled and job store presence before creating and enqueuing an AsyncJob - Call helper from execute_plan() (phase="execute") and apply_plan() (phase="apply") after phase transitions - When async is disabled or no job store is configured, behaviour is unchanged (silent no-op) 2. Redact secrets in failed job error messages: - Apply shared.redaction.redact_value() to the error string before persisting to AsyncJob.error_message, preventing accidental secret leakage (e.g. API keys in exception text) into the audit trail Documentation: - S1: Added specification reconciliation note (ADR-style) to async_architecture.md addressing tension between "No Plan Queuing" clause and the async subsystem authorised by issue #312 ISSUES CLOSED: #312	2026-03-04 23:47:20 +00:00
brent.edwards	7b86008cfc	Merge branch 'master' into feature/m3-test-resource-bootstrap-git	2026-03-04 22:48:56 +00:00
khyari hamza	ad53a659de	feat(uko): add UKO ontology scaffolding ... Add UKO Layer 0-3 ontology skeleton (RDF/TTL) with base URI, version IRI, and prefix conventions. Python loaders handle URI parsing, inheritance resolution, versioning metadata, and validation of undefined prefixes and missing rdf:type. Includes Behave BDD scenarios, Robot Framework integration tests, ASV benchmarks, and reference documentation. - Resolve rdfs:domain and rdfs:range values to full URIs in parser - Fix type: ignore in Robot helper with proper Callable typing - Export UKO models from core/__init__.py - Add parent-URI existence validation in validate() - Rename scenario to clarify parser-skips vs validation-rejects - Add scenario testing validation with injected typeless node - Add Scenario Outline for multi-layer node count assertions - TTL: Layer 0 classes (InformationUnit, Container, Atom, Annotation, Boundary) with contains/references/dependsOn properties. Layer 1 uko-code: classes (Module, Callable, TypeDefinition, TestCase, Import) with hasReturnType/hasParameters/testsCallable. Layer 2 uko-oo: classes (Class, Interface, Method, Attribute) with inheritsFrom/implements and rdfs:subPropertyOf. New URI scheme cleveragents.ai/ontology/uko#. - TTL: uko-oo:Class has dual rdfs:subClassOf (TypeDefinition + Container), uko-oo:Interface has dual rdfs:subClassOf (TypeDefinition + Boundary). - Model: UKONode.parent_uri replaced with parent_uris: tuple[str, ...] to support multi-parent rdfs:subClassOf. - Loader: prefix regex supports hyphenated names (uko-code, uko-oo). Semantic domain prefix maps (_LAYER_PREFIXES, _LAYER_IRI_PREFIXES). Comma-separated rdfs:subClassOf parsing. rdfs:domain/range/subPropertyOf URI resolution. BFS DAG traversal with DFS cycle detection for resolve_inheritance. HTTP URI skip in validation (D-1 fix). Duplicate error guard (B-1 fix). Consistent quoting (M-1 fix). - Services __init__: export UKOLoader and UKOValidationError. - Tests: 24 Behave scenarios (multi-parent, domain/range resolution, non-existent parent validation). 4 Robot smoke tests. Consolidated context attributes (T-3 fix). - Docs: uko.md written for spec-aligned structure. - Namespace prefix match in parent-URI validation includes a delimiter guard (# or /) preventing false positives on URIs that share the UKO prefix string (e.g. ukobogus:, ukoo:). ISSUES CLOSED: #189	2026-03-04 22:40:34 +00:00
freemo	4ca4874c4d	feat(correction): implement cross-plan correction cascading with child plan state handling ... Add CrossPlanCorrectionService that implements the four child-plan-state- dependent behaviours from the specification when a correction's affected subtree includes child plans: - Not yet started → cancel the child plan - In progress → cancel + rollback sandbox to pre-child-plan state - Completed but not applied → cancel + rollback sandbox - Already applied → reject the correction (CorrectionRejection) Key additions: - ChildPlanState enum classifying child plans into 4 states - CorrectionRejection result type with reason and affected applied plan IDs - CascadeAction/CascadeResult models for cascade operation tracking - CorrectionStatus.REJECTED for rejected corrections - Atomic cascade-or-rollback: all child plan actions succeed or the entire cascade is rolled back - Protocol-based dependency injection (ChildPlanLookup, ChildPlanCanceller, SandboxRollbacker) for testability - execute_correction_with_cascade() integrates with CorrectionService flow Testing: - 24 Behave BDD scenarios in cross_plan_correction.feature - 8 Robot Framework end-to-end smoke tests - ASV benchmarks for cascade performance with varying child plan counts ISSUES CLOSED: #547	2026-03-04 21:20:47 +00:00
freemo	abd4c6de49	feat(actor): implement built-in invariant reconciliation actor ... Add InvariantReconciliationActor that runs at the start of the Strategize phase to reconcile invariants from four scopes (global, project, action, plan). The actor detects conflicts, resolves them using specificity-based precedence (plan > action > project > global), honours non_overridable global invariants, records invariant_enforced decisions, and produces a reconciled InvariantSet. Changes: - New: src/cleveragents/actor/reconciliation.py - InvariantReconciliationActor class with collect_invariants() and run() - reconcile_invariants() pure function - ScopeInvariants, ConflictRecord, ReconciliationResult dataclasses - Modified: src/cleveragents/domain/models/core/invariant.py - Added non_overridable: bool field to Invariant model - New: features/invariant_reconciliation_actor.feature (26 BDD scenarios) - New: features/steps/invariant_reconciliation_actor_steps.py - New: robot/invariant_reconciliation_actor.robot - New: robot/helper_invariant_reconciliation.py - New: benchmarks/invariant_reconciliation_bench.py Closes #549	2026-03-04 20:26:42 +00:00
brent.edwards	34a65ee9d0	test(resource): add failing tests for built-in git-checkout type bootstrap ... Add TDD-style failing tests that verify the built-in git-checkout resource type is available after initialization. Tests assert the correct expected behavior: after agents init, the git-checkout type should exist in the registry and 'agents resource add git-checkout' should succeed. Tests are expected to fail until bug #524 is fixed, because bootstrap_builtin_types() is never called during initialization. The fix branch should be based on this branch so the fix commit inherits these tests. Files added: - features/resource_type_bootstrap_git.feature (2 Behave scenarios) - features/steps/resource_type_bootstrap_git_steps.py (step definitions) - robot/resource_type_bootstrap_git.robot (Robot Framework smoke test) ISSUES CLOSED: #553	2026-03-04 20:13:36 +00:00
freemo	93e3893d69	feat(validation): implement tool wrapping runtime (wraps + transform delegation) ... Implement the runtime execution engine for validation tool wrapping, as specified in docs/specification.md § Tool Wrapping. WrappedToolExecutor resolves wraps references and delegates execution to wrapped tools, supporting composable wrapping chains with cycle detection and depth limiting (max 10 levels). ArgumentMapper translates arguments between wrapper and wrapped tool schemas using the argument_mapping configuration. Supports both forwarded parameter names and literal fixed values. TransformExecutor runs user-supplied transform functions in a sandboxed Python environment with restricted builtins (no imports, no filesystem, no network access). Validates that transforms return proper validation-format dicts with a passed boolean. Wired into the tool package public API via tool/__init__.py exports. All new error types (WrappedToolNotFoundError, WrappingCycleError, WrappingDepthExceededError, TransformExecutionError) provide clear diagnostic messages. Tests: 20 Behave scenarios covering argument mapping, transform execution, simple/chained delegation, error handling, and sandbox restrictions. 8 Robot Framework integration smoke tests. ASV benchmarks for delegation overhead measurement. ISSUES CLOSED: #543	2026-03-04 18:21:19 +00:00
freemo	db5e5c974f	feat(autonomy): implement semantic escalation with confidence scoring and threshold comparison	2026-03-04 12:18:51 -05:00
freemo	5935940276	feat(sandbox): implement sandbox boundary algebra and domain computation ... Implement sandbox_boundary(r) function that walks up containment edges in the resource DAG to the nearest sandboxable ancestor, enabling resources sharing a boundary to share one sandbox instance. Changes: - Add boundary.py: is_sandbox_boundary(), sandbox_boundary(), compute_sandbox_domains(), BoundaryCache (thread-safe, per-execution) - Update SandboxManager: resolve_sandbox_key() and get_or_create_sandbox_for_resource() key by (plan_id, boundary_id) instead of (plan_id, resource_id); boundary cache lifecycle methods - Define "sandboxable" via ResourceCapabilities.sandboxable + non-none sandbox_strategy as per specification section 24659-24674 - Export new symbols from sandbox __init__.py - Add vulture whitelist entries for new public API Tests: - 26 Behave BDD scenarios (features/sandbox_boundary_algebra.feature) - 5 Robot Framework integration tests (robot/sandbox_boundary_algebra.robot) - ASV benchmarks for boundary walk, domain grouping, and cache performance ISSUES CLOSED: #548	2026-03-04 15:59:15 +00:00
freemo	8e6642e8c9	feat(decision): implement influence DAG traversal in correction affected subtree computation ... Extended _compute_affected_subtree() to BFS over both the structural tree (parent-child plan relationships) and decision_dependencies edges (influence DAG). The algorithm performs a single O(V+E) BFS pass that unions neighbors from both edge sources, using a visited set for cycle detection to guard against data corruption. Decision creation now supports dependency_decision_ids parameter in record_decision() which populates the in-memory influence DAG store. get_influence_edges() returns the adjacency list format consumed by CorrectionService. All public CorrectionService methods (analyze_impact, execute_revert, execute_correction, generate_dry_run_report) accept an optional influence_edges parameter while remaining backward-compatible (defaults to None, preserving structural-only traversal when not provided). Key design decisions: - Single BFS pass over union of structural + influence edges rather than separate traversals, ensuring O(V+E) complexity and consistent visit order - Cycle detection via visited set with warning log (not an error) since cycles indicate data corruption, not a programming error - Influence edge logging: traversal emits count of influence edges processed for observability - Backward-compatible API: existing callers that only pass decision_tree continue to work identically ISSUES CLOSED: #542	2026-03-04 15:36:34 +00:00
Luis Mendes	ff42d59d6d	feat(cli): wire project context CLI stubs to ACMS pipeline ... Wire all four project context CLI commands (inspect, simulate, set, show) to live ACMS pipeline services via ContextTierService and CRP models. - context inspect: queries ContextTierService for tier metrics and per-project fragments with filtering by strategy/focus/breadth/depth - context simulate: dry-run context assembly using CRP models with configurable token budget and assembly strategies - context set: 12 new ACMS pipeline options (hot_max_tokens, warm_max_decisions, cold_max_decisions, summary_max_tokens, temporal_scope, auto_refresh, focus_area, breadth, depth, assembly_strategy, retrieval_strategy, summary_strategy) - context show: displays ACMS pipeline configuration alongside policy - `context inspect` displayed global tier fragment counts (hot/warm/cold) across all projects instead of counts for the target project only. Add `ContextTierService.get_scoped_metrics(project_names)` which uses `ScopedBackendView` to filter fragment counts to the specified projects while keeping hit/miss counters as global service-level cache metrics. Update `context_inspect()` to call `get_scoped_metrics([project])` instead of `get_metrics()`. - `context simulate --focus` accepted focus URIs and passed them to the `ContextRequest` model but never used them to filter the fragment list, making the `--focus` flag a no-op. Add focus URI filtering in `_simulate_context_assembly()` after `get_scoped_view()` — filters `project_fragments` by matching each fragment's `resource_id` against the supplied focus URIs. Also fixes redaction false positives for hot_max_tokens and summary_max_tokens keys, and Rich Console line-wrapping in test output that caused JSON parse failures. Includes 28 new Behave BDD scenarios for wiring coverage, updated Robot Framework integration tests, and reference documentation. ISSUES CLOSED: #499	2026-03-03 23:36:15 +00:00
Luis Mendes	b4b96d213c	feat(security): add safety profile enforcement ... Implement safety profile resolution and enforcement in the tool execution pipeline, replacing the NotImplementedError stub with working precedence logic and runtime safety checks. Core changes: - resolve_safety_profile() now resolves plan > action > project > global precedence, returning the highest-priority non-None profile (or DEFAULT_SAFETY_PROFILE with GLOBAL provenance when all None) - ToolExecutionContext gains an optional safety_profile field - ToolRuntime._enforce_capabilities() extended with three new checks: * Unsafe tool gating: blocks tools with unsafe=True when profile has allow_unsafe_tools=False (ToolSafetyViolationError) * Skill category allow-list: blocks tools whose skill category is not in allowed_skill_categories (ToolSafetyViolationError) * Checkpoint requirement: OR-combines ctx.require_checkpoints with safety_profile.require_checkpoints - New ToolSafetyViolationError in tool error hierarchy Test coverage: - 30 updated BDD scenarios in safety_profile.feature (resolve precedence replaces NotImplementedError stub test) - 24 new BDD scenarios in safety_profile_enforcement.feature - 9 Robot Framework integration smoke tests - 4 ASV benchmark suites (construction, serialization, resolution, provenance enum) All nox sessions pass (typecheck 0 errors, unit_tests 7735 scenarios 0 failures, coverage 97%, integration_tests 9/9 passed, benchmarks complete). ISSUES CLOSED: #345	2026-03-03 22:21:14 +00:00
freemo	3f14cbbf7e	feat(observability): add LLMTrace model and operational metrics ... Add LLMTrace Pydantic v2 domain model with all required fields (trace_id, plan_id, decision_id, actor, provider, model, prompt_tokens, completion_tokens, cost_usd, latency_ms, tool_calls, context_hash, streaming, retry_count, error). Define 14 OperationalMetricKey values (PLAN_DURATION_MS, PLAN_TOTAL_COST_USD, PLAN_DECISION_COUNT, ACTOR_INVOCATION_COUNT, ACTOR_LATENCY_MS, TOOL_INVOCATION_COUNT, TOOL_ERROR_RATE, CONTEXT_BUILD_TIME_MS, CONTEXT_TOKEN_COUNT, LLM_CALL_COUNT, LLM_TOTAL_TOKENS, LLM_TOTAL_COST_USD, LLM_AVG_LATENCY_MS, SUBPLAN_COUNT) with MetricEntry model and MetricCollector. Add llm_traces database table (LLMTraceModel) with LLMTraceRepository for persistence. TraceService provides recording, querying, metric computation, plan lifecycle hooks, and optional LangSmith forwarding when LANGCHAIN_TRACING_V2=true. Wired into DI container as trace_service. Includes 28 Behave BDD scenarios, 6 Robot Framework smoke tests, 3 ASV benchmark suites, and reference documentation. Fix pre-existing cli_core server_mode test flake by mocking resolve_server_mode in test steps to avoid stale config file interference. Closes #500	2026-03-03 17:04:17 -05:00
freemo	4232907ab9	feat(plan): add large-project decomposition and dependency closure ... Add hierarchical decomposition with 4+ levels and bounded context per subplan. Implement decomposition heuristics (max_files_per_subplan, max_tokens_per_subplan, language/dir clustering). Add dependency closure computation for large graphs and DAG execution ordering. Add bounded dependency closure with cutoff thresholds and memoization for 10K+ files. Record decomposition decisions in DecisionService (strategy_choice + subplan_spawn entries). New modules: - decomposition_models.py: DecompositionConfig, DecompositionNode, DecompositionResult, DependencyEdge, DependencyGraph - decomposition_clustering.py: ClusteringStrategy with directory, language, and size clustering plus deterministic sort - decomposition_graph.py: DependencyClosureComputer with bounded closure, topological sort, cycle detection, and memoization - decomposition_service.py: DecompositionService orchestrating hierarchy building and decision recording Settings: planner_max_depth, planner_max_files_per_subplan, planner_max_tokens_per_subplan, planner_min_files_per_subplan Closes #205	2026-03-03 21:44:20 +00:00
freemo	738c3b5eda	feat(plan): add multi-project subplan support ... Add domain models, application service, CLI integration, and full test coverage for multi-project subplan orchestration. New components: - MultiProjectMetadata, ProjectScope, ProjectDependency domain models - MultiProjectService for creating/managing multi-project plans - CLI display of multi-project metadata in plan commands - Behave BDD tests (20 scenarios), Robot Framework integration tests, ASV benchmarks, and reference documentation Also fixes pre-existing test flakiness in cli_core, core_cli_commands, cli_plan_context_commands, and helper_server_stubs caused by environment leakage and path-with-spaces issues. ISSUES CLOSED: #199	2026-03-03 14:55:58 -05:00
freemo	ad5f737721	feat(execution): add execution environment routing ... Add ExecutionEnvironment enum (host/container) to domain models, implement execution environment resolution with priority chain (tool > plan > project > default), wire the tool runner to check execution_environment before execution, and add CLI flags to plan use/execute and project context set. When container is selected but no container resource is available, a clear ContainerUnavailableError is raised with an actionable message. Closes #512	2026-03-03 14:48:55 -05:00
freemo	6519f140a9	feat(context): add hot/warm/cold tiers and actor views ... Implement hot/warm/cold context tiers with ContextTier, ActorRole, TieredFragment, TierBudget, ActorContextView, TierMetrics, and ScopedBackendView models. ContextTierService provides store/get, promotion/demotion with cold-tier summarisation hook, LRU eviction, per-actor filtered views (strategist/executor/reviewer), and project-scoped isolation via ScopedBackendView. Settings: context_max_tokens_hot, context_max_decisions_warm, context_max_decisions_cold. DI-wired as singleton context_tier_service. Includes Behave BDD scenarios (30), Robot Framework integration tests (7), ASV benchmarks (5 suites), and docs/reference/context_tiers.md. Closes #208	2026-03-03 17:01:57 +00:00
aditya	7348ca1911	fix(events): update tests for DecisionService.record_decision API change ... - Update event_bus_steps.py to call record_decision() with individual parameters (plan_id, decision_type, question, chosen_option, rationale) instead of passing a Decision object, matching the master branch API - Remove ctx.test_decision construction from DecisionService setup steps as it is no longer needed with the new signature - Update robot/helper_event_bus.py decision_service_emits_event() to use the new record_decision() parameter signature - All 9 Robot Framework event bus tests passing - Behave scenarios at lines 125 and 131 now passing Fixes event bus test failures after master merge.	2026-03-03 15:42:53 +00:00
aditya	5bd7a507b8	Merge branch 'master' into feature/m6plus-event-bus	2026-03-03 15:20:19 +00:00
aditya	89bc776381	refactor(events): address PR-509 review comments ... - Fix CHANGELOG EventType count from 40 to 38 and add missing domains (invariant, context) for accurate documentation - Document correlation_id field as spec extension for request traceability in DomainEvent model - Add thread safety documentation to ReactiveEventBus and LoggingEventBus noting single-threaded design and external sync requirements - Document _persist_audit deferral in ReactiveEventBus.emit() explaining audit logging via handler subscription or LoggingEventBus following single-responsibility principle - Replace bare MagicMock() with create_autospec(Settings, instance=True) at 5 locations for type-safe test mocking - Replace nested bare MagicMock for UnitOfWork with create_autospec at 3 locations to prevent silent breakage on API changes All changes maintain backward compatibility. No linter errors.	2026-03-03 15:15:55 +00:00
aditya	5f0bc97d46	Merge branch 'master' into feature/m5-subplan-actor ... # Conflicts: # CHANGELOG.md	2026-03-03 14:55:28 +00:00
khyari hamza	0e36755db9	fix(service): address review findings for decision service ... - Rehydrate sequence counter from DB on restart (BUG-1) - Add uniqueness guard raising SequenceConflictError (BUG-2) - Fix delete_decision consistency between persisted/in-memory (BUG-3) - Validate new_decision_id exists in mark_superseded (BUG-4) - Include orphaned subtrees in get_tree output (BUG-5) - Remove dead _decision_seq/_next_seq from plan_lifecycle (BUG-7) - Export SequenceConflictError from services __init__ (SPEC-2) - Replace list[Any] with list[ArtifactRef] typing (SPEC-4) - Add actor_reasoning max_length validation (SEC-1) - Use SELECT COUNT(*) in count_decisions (PERF-1) - Replace MagicMock with create_autospec(Settings) (TEST-3) - Eliminate UnitOfWork.__new__() anti-pattern (TEST-4) - Use exact assertion counts in DI tests (TEST-5) - Add restart rehydration, BFS order, invalid type, and confidence boundary test scenarios (TEST-1/2/6/7) - Fix decision_service_coverage.feature to match actual API ISSUES CLOSED: #172	2026-03-03 12:53:28 +00:00