cleveragents/cleveragents-core

Fork 3

feat(correction): implement cross-plan correction cascading with child plan state handling #547

New issue

Closed

opened 2026-03-04 01:02:08 +00:00 by freemo · 1 comment

freemo commented

2026-03-04 01:02:08 +00:00

Owner

Metadata

Field	Value
Type	Feature
Priority	High
MoSCoW	Should Have
Points	8
Milestone	v3.5.0
Assignee	freemo
Parent Epic	#394 (Epic: Decision Framework)
Depends On	#542 (influence DAG traversal)

Background

The specification (§ Correction > Cross-Plan Correction Cascading, lines 28393-28413) defines 4 child-plan-state-dependent behaviors when a correction's affected subtree includes child plans:

Child Plan State	Action
Not yet started	Cancel the child plan
In progress	Cancel + rollback sandbox to pre-child-plan state
Completed but not applied	Cancel + rollback sandbox
Already applied	Reject the correction (cannot undo applied changes)

Current state: The CorrectionService handles corrections within a single plan but has NO cross-plan logic. No grep results for cross_plan_correction or correction_cascad in the codebase. When a correction's affected subtree touches a child plan, the behavior is undefined.

Acceptance Criteria

When a correction's affected subtree (from #542) includes child plan nodes, the correction engine checks each child plan's state.
Child plans not yet started are cancelled.
Child plans in progress are cancelled and their sandboxes rolled back.
Child plans completed but not applied are cancelled and rolled back.
If any child plan is already applied, the correction is rejected with a clear explanation.
Rejection returns an CorrectionRejection result with reason and affected applied child plan IDs.
All cascading actions are atomic: either all succeed or the correction is fully rolled back.

Subtasks

1. Design

Define child plan state detection logic
Design atomic cascade-or-rollback transaction
Design CorrectionRejection result type

2. Implementation

Add child plan state inspection to CorrectionService
Implement cancel logic for not-started child plans
Implement cancel + sandbox rollback for in-progress and completed-unapplied child plans
Implement rejection logic for already-applied child plans
Ensure atomicity (transaction boundary around cascade)

3. Testing

Unit test: correction cascades to not-started child plan → cancel
Unit test: correction cascades to in-progress child plan → cancel + rollback
Unit test: correction cascades to applied child plan → rejection
Unit test: mixed child plan states → reject if any applied
Integration test: end-to-end cross-plan correction

4. Documentation

Update CorrectionService docstrings
Document rejection scenarios

5. Integration

Wire into existing correction workflow
Verify sandbox rollback compatibility

6. Observability

Log cascade decisions per child plan
Log rejection reasons

7. Security

Ensure cascade cannot bypass plan isolation boundaries

Definition of Done

All acceptance criteria met
All subtask checkboxes checked
Tests pass in CI
Code reviewed and approved

## Metadata | Field | Value | |-------|-------| | **Type** | Feature | | **Priority** | High | | **MoSCoW** | Should Have | | **Points** | 8 | | **Milestone** | v3.5.0 | | **Assignee** | freemo | | **Parent Epic** | #394 (Epic: Decision Framework) | | **Depends On** | #542 (influence DAG traversal) | ## Background The specification (§ Correction > Cross-Plan Correction Cascading, lines 28393-28413) defines 4 child-plan-state-dependent behaviors when a correction's affected subtree includes child plans: | Child Plan State | Action | |-----------------|--------| | Not yet started | Cancel the child plan | | In progress | Cancel + rollback sandbox to pre-child-plan state | | Completed but not applied | Cancel + rollback sandbox | | Already applied | **Reject the correction** (cannot undo applied changes) | **Current state:** The `CorrectionService` handles corrections within a single plan but has NO cross-plan logic. No grep results for `cross_plan_correction` or `correction_cascad` in the codebase. When a correction's affected subtree touches a child plan, the behavior is undefined. ## Acceptance Criteria 1. When a correction's affected subtree (from #542) includes child plan nodes, the correction engine checks each child plan's state. 2. Child plans not yet started are cancelled. 3. Child plans in progress are cancelled and their sandboxes rolled back. 4. Child plans completed but not applied are cancelled and rolled back. 5. If any child plan is already applied, the correction is rejected with a clear explanation. 6. Rejection returns an `CorrectionRejection` result with reason and affected applied child plan IDs. 7. All cascading actions are atomic: either all succeed or the correction is fully rolled back. ## Subtasks ### 1. Design - [ ] Define child plan state detection logic - [ ] Design atomic cascade-or-rollback transaction - [ ] Design CorrectionRejection result type ### 2. Implementation - [ ] Add child plan state inspection to CorrectionService - [ ] Implement cancel logic for not-started child plans - [ ] Implement cancel + sandbox rollback for in-progress and completed-unapplied child plans - [ ] Implement rejection logic for already-applied child plans - [ ] Ensure atomicity (transaction boundary around cascade) ### 3. Testing - [ ] Unit test: correction cascades to not-started child plan → cancel - [ ] Unit test: correction cascades to in-progress child plan → cancel + rollback - [ ] Unit test: correction cascades to applied child plan → rejection - [ ] Unit test: mixed child plan states → reject if any applied - [ ] Integration test: end-to-end cross-plan correction ### 4. Documentation - [ ] Update CorrectionService docstrings - [ ] Document rejection scenarios ### 5. Integration - [ ] Wire into existing correction workflow - [ ] Verify sandbox rollback compatibility ### 6. Observability - [ ] Log cascade decisions per child plan - [ ] Log rejection reasons ### 7. Security - [ ] Ensure cascade cannot bypass plan isolation boundaries ## Definition of Done - [ ] All acceptance criteria met - [ ] All subtask checkboxes checked - [ ] Tests pass in CI - [ ] Code reviewed and approved

freemo added the

Child Plan State	Action
Not yet started	Cancel the child plan
In progress (Strategize/Execute)	Cancel + rollback sandbox
Completed but not applied	Cancel + rollback sandbox
Already applied	Reject — `CorrectionRejection` returned

Rows
Columns