cleveragents/cleveragents-core

Fork 3

test(cli): add failing tests for `agents init --yes` missing option (#522) #536

New issue

Closed

opened 2026-03-04 00:41:13 +00:00 by freemo · 1 comment

freemo commented

2026-03-04 00:41:13 +00:00

Owner

Metadata

Commit Message: test(cli): add failing tests for agents init --yes missing option
Branch: feature/m3-test-init-yes-flag

Background and Context

Bug #522 reports that agents init --yes raises NoSuchOption: --yes instead of performing a non-interactive initialization as documented in the specification (Workflow Examples, Example 1, Step 1). The --yes flag is not implemented in the CLI init command.

Before fixing the bug, we need failing tests that reproduce the problem. These tests will fail until the fix in #522 is applied, and pass once the fix is merged.

Expected Behavior

A set of Behave BDD unit tests exist that exercise the agents init --yes code path and currently fail because the --yes option does not exist. Once the bug fix is applied, these tests pass.

Acceptance Criteria

At least one Behave unit test scenario verifies that agents init --yes completes without error.
At least one scenario verifies that --yes skips interactive prompts and uses defaults.
At least one scenario verifies that agents init --yes produces the expected output (data dir, config, database, directories).
Tests are written as Gherkin .feature files under features/ with corresponding step definitions.
Tests currently fail because the --yes flag is not implemented (this is expected).
Tests are structured so they will pass once the fix in #522 is merged.

Definition of Done

This issue is complete when:

All subtasks below are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

Subtasks

Code [brent.edwards]: Add features/cli_init_yes_flag.feature with at least 3 Gherkin scenarios: (1) agents init --yes completes without error, (2) --yes skips interactive prompts and applies defaults, (3) output includes expected initialization summary (data dir, config, database, directories).
Code [brent.edwards]: Add corresponding step definitions in features/steps/cli_init_yes_flag_steps.py that invoke the CLI init command with --yes and assert expected behavior.
Docs [brent.edwards]: Add a brief note in the feature file header explaining these tests target bug #522 and are expected to fail until the fix is applied.
Tests (Behave) [brent.edwards]: The scenarios above are the Behave tests. Verify they run (and fail as expected) via nox -s unit_tests.
Tests (Robot) [brent.edwards]: Add robot/cli_init_yes_flag.robot smoke test that runs agents init --yes and checks exit code.
Tests (ASV) [brent.edwards]: Add benchmarks/cli_init_yes_bench.py benchmarking agents init --yes invocation time.
Quality [brent.edwards]: Verify coverage >=97% via nox -s coverage_report. If coverage is <97% then review the current unit test coverage report at build/coverage.xml and use it to write new Behave based unit tests to improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun nox -s coverage_report to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality [brent.edwards]: Run nox (all default sessions, including benchmark), fix any errors if needed ensuring nox passes across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Parent: #401

## Metadata - **Commit Message**: `test(cli): add failing tests for agents init --yes missing option` - **Branch**: `feature/m3-test-init-yes-flag` ## Background and Context Bug #522 reports that `agents init --yes` raises `NoSuchOption: --yes` instead of performing a non-interactive initialization as documented in the specification (Workflow Examples, Example 1, Step 1). The `--yes` flag is not implemented in the CLI init command. Before fixing the bug, we need failing tests that reproduce the problem. These tests will fail until the fix in #522 is applied, and pass once the fix is merged. ## Expected Behavior A set of Behave BDD unit tests exist that exercise the `agents init --yes` code path and currently fail because the `--yes` option does not exist. Once the bug fix is applied, these tests pass. ## Acceptance Criteria - [x] At least one Behave unit test scenario verifies that `agents init --yes` completes without error. - [x] At least one scenario verifies that `--yes` skips interactive prompts and uses defaults. - [x] At least one scenario verifies that `agents init --yes` produces the expected output (data dir, config, database, directories). - [x] Tests are written as Gherkin `.feature` files under `features/` with corresponding step definitions. - [x] Tests currently **fail** because the `--yes` flag is not implemented (this is expected). - [x] Tests are structured so they will **pass** once the fix in #522 is merged. ## Definition of Done This issue is complete when: - All subtasks below are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done. ## Subtasks - [x] Code [brent.edwards]: Add `features/cli_init_yes_flag.feature` with at least 3 Gherkin scenarios: (1) `agents init --yes` completes without error, (2) `--yes` skips interactive prompts and applies defaults, (3) output includes expected initialization summary (data dir, config, database, directories). - [x] Code [brent.edwards]: Add corresponding step definitions in `features/steps/cli_init_yes_flag_steps.py` that invoke the CLI init command with `--yes` and assert expected behavior. - [x] Docs [brent.edwards]: Add a brief note in the feature file header explaining these tests target bug #522 and are expected to fail until the fix is applied. - [x] Tests (Behave) [brent.edwards]: The scenarios above **are** the Behave tests. Verify they run (and fail as expected) via `nox -s unit_tests`. - [x] Tests (Robot) [brent.edwards]: Add `robot/cli_init_yes_flag.robot` smoke test that runs `agents init --yes` and checks exit code. - [x] Tests (ASV) [brent.edwards]: Add `benchmarks/cli_init_yes_bench.py` benchmarking `agents init --yes` invocation time. - [ ] Quality [brent.edwards]: Verify coverage >=97% via `nox -s coverage_report`. If coverage is <97% then review the current unit test coverage report at `build/coverage.xml` and use it to write new Behave based unit tests to improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `nox -s coverage_report` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality [brent.edwards]: Run `nox` (all default sessions, including benchmark), fix any errors if needed ensuring nox passes across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. Parent: #401

freemo added the

labels

2026-03-04 00:41:42 +00:00

freemo added this to the v3.2.0 milestone

2026-03-04 00:41:46 +00:00

freemo referenced this issue

2026-03-04 00:42:05 +00:00

agents init --yes does not exist. #522

brent.edwards was assigned by freemo

2026-03-04 01:38:07 +00:00

brent.edwards added

and removed

labels

2026-03-04 20:09:43 +00:00

brent.edwards referenced this issue from a commit

2026-03-04 20:12:29 +00:00

test(cli): add failing tests for agents init --yes missing option

~~brent.edwards referenced this issue 2026-03-04 20:12:52 +00:00~~

test(cli): add failing tests for agents init --yes missing option (#536) #566

~~brent.edwards referenced this issue 2026-03-04 20:16:34 +00:00~~

test(cli): add failing tests for agents init --yes missing option (#536) #566

~~brent.edwards referenced this issue 2026-03-04 20:17:01 +00:00~~

test(cli): add failing tests for agents init --yes missing option (#536) #566

brent.edwards referenced this issue from a commit

2026-03-04 20:17:52 +00:00

docs(changelog): add entry for init --yes test scaffolding

brent.edwards referenced this issue from a commit

2026-03-04 20:18:41 +00:00

docs(changelog): add entry for init --yes test scaffolding

brent.edwards added reference feature/m3-test-init-yes-flag

2026-03-04 20:21:21 +00:00

brent.edwards commented

2026-03-04 20:22:38 +00:00

Member

Implementation Summary

PR: #566

Branch: feature/m3-test-init-yes-flag

Files Added

File	Purpose
`features/cli_init_yes_flag.feature`	3 Gherkin scenarios exercising `agents init --yes`
`features/steps/cli_init_yes_flag_steps.py`	Behave step definitions using `typer.testing.CliRunner` with mocked container
`robot/cli_init_yes_flag.robot`	Robot Framework integration smoke test
`benchmarks/cli_init_yes_bench.py`	ASV benchmark for `init --yes` invocation time
`CHANGELOG.md`	Entry added under Unreleased > Testing

Design Decisions

Test approach: Uses CliRunner.invoke() with ["init", "--yes"] args, matching the existing pattern in features/steps/project_commands_coverage_steps.py. The --yes flag does not exist yet, so tests fail with NoSuchOption — this is intentional per the TDD workflow.
Mock strategy: Mocks cleveragents.application.container.get_container to provide a test container with a fresh temp-dir SQLite database, consistent with the project's existing mock approach in features/mocks/.
Scenarios cover: (a) basic --yes completes without error, (b) --yes skips interactive prompts and applies defaults, (c) output includes expected initialization artifacts (data dir, config, database, directories).
Quality gates left unchecked: The two Quality subtasks (coverage >=97% and full nox run) are intentionally unchecked because these are TDD failing tests — they will pass once the bug-fix author implements the --yes flag in #522.

Verification

nox -s lint — passed
nox -s typecheck — passed (Pyright clean)
Tests are expected to fail until #522 is fixed

## Implementation Summary ### PR: #566 **Branch:** `feature/m3-test-init-yes-flag` ### Files Added | File | Purpose | |------|---------| | `features/cli_init_yes_flag.feature` | 3 Gherkin scenarios exercising `agents init --yes` | | `features/steps/cli_init_yes_flag_steps.py` | Behave step definitions using `typer.testing.CliRunner` with mocked container | | `robot/cli_init_yes_flag.robot` | Robot Framework integration smoke test | | `benchmarks/cli_init_yes_bench.py` | ASV benchmark for `init --yes` invocation time | | `CHANGELOG.md` | Entry added under Unreleased > Testing | ### Design Decisions 1. **Test approach:** Uses `CliRunner.invoke()` with `["init", "--yes"]` args, matching the existing pattern in `features/steps/project_commands_coverage_steps.py`. The `--yes` flag does not exist yet, so tests fail with `NoSuchOption` — this is intentional per the TDD workflow. 2. **Mock strategy:** Mocks `cleveragents.application.container.get_container` to provide a test container with a fresh temp-dir SQLite database, consistent with the project's existing mock approach in `features/mocks/`. 3. **Scenarios cover:** (a) basic `--yes` completes without error, (b) `--yes` skips interactive prompts and applies defaults, (c) output includes expected initialization artifacts (data dir, config, database, directories). 4. **Quality gates left unchecked:** The two Quality subtasks (coverage >=97% and full `nox` run) are intentionally unchecked because these are TDD failing tests — they will pass once the bug-fix author implements the `--yes` flag in #522. ### Verification - `nox -s lint` — passed - `nox -s typecheck` — passed (Pyright clean) - Tests are expected to **fail** until #522 is fixed

brent.edwards added

and removed

labels

2026-03-04 20:23:00 +00:00