730 Commits

Author	SHA1	Message	Date
aditya	a0f56228e2	Merge branch 'master' into feature/m3-mcp-adapter	2026-02-27 06:40:15 +00:00
freemo	120274da99	feat(di): wire decision services ... Create DecisionService application-layer service that wraps DecisionRepository with structured logging and UnitOfWork transaction management. Wire DecisionService and PlanLifecycleService into the DI container as Factory providers. Inject DecisionService into PlanLifecycleService so that phase transitions automatically record decisions: start_strategize records a strategy_choice decision and start_execute records an implementation_choice decision. Decision recording is optional and never blocks lifecycle transitions. Add Behave feature (5 scenarios), Robot Framework smoke tests (2 test cases), ASV benchmarks (3 benchmark classes), and DI reference documentation. ISSUES CLOSED: #173	2026-02-27 02:33:42 +00:00
brent.edwards	f7b8186b3f	Merge branch 'master' into test/m6-e2e-verification	2026-02-26 21:26:00 +00:00
brent.edwards	8771b195f5	Merge branch 'master' into test/m5-e2e-verification	2026-02-26 21:25:47 +00:00
brent.edwards	8c5fa8ace7	Merge branch 'master' into test/m5-e2e-verification	2026-02-26 20:58:38 +00:00
khyari hamza	2b09568cfa	feat(security): enforce read-only actions ... Tighten ToolRuntime._enforce_capabilities() to block ANY tool with writes=True when plan_read_only is set, removing the not-cap.read_only loophole that allowed certain write tools through. Tool name is now always included in the ToolAccessDeniedError message. Add read_only flag to ChangeSetCapture with ReadOnlyViolationError raised when write-capable tools are wrapped on a read-only plan. Add CLI fail-fast guards on plan execute and plan apply commands that abort before calling the service layer if plan.read_only is True. SkillContext.enforce_write_guard() already included tool name correctly and required no changes. Includes 18 Behave scenarios (90 steps), Robot integration tests, ASV benchmarks, and docs/reference/read_only_actions.md. ISSUES CLOSED: #322	2026-02-26 20:33:20 +00:00
brent.edwards	1ec2200e34	test(e2e): verify M6 success criteria — Firefox-scale autonomous porting ... Robot Framework E2E test suite exercising the complete M6 success criteria verification sequence: - Porting action creation from YAML config via CLI - Plan use + execute via CLI with mocked lifecycle service - Hierarchical decomposition: 4+ levels (root + L1-L4 = 21+ plans) - Decision correction recomputes only affected subtree (CorrectionImpact) - Parallel execution scales to 15 concurrent subplans (10+ required) - Realistic porting task: full ACTION → STRATEGIZE → EXECUTE → APPLY lifecycle with 10 subplans completing autonomously - Plan apply transitions to APPLIED terminal state - SubplanFailureHandler retry/stop-others logic verification - SubplanConfig supports all execution modes and merge strategies - Decision tree structure: PROMPT_DEFINITION root with SUBPLAN_PARALLEL_SPAWN children and superseded_by flow Ten subcommands in the Python helper, each printing a sentinel string on success. All subcommands verified passing locally. Closes #407	2026-02-26 19:27:53 +00:00
brent.edwards	fd1612c38f	test(e2e): verify M5 success criteria — ACMS and large-project context ... Robot Framework E2E test suite exercising the complete M5 success criteria verification sequence: - Large project creation with 10,000+ simulated files - Resource registration and linking to a project - Indexing verification (resource linked, project shows correctly) - Context tier management (hot/warm/cold) via ContextConfig - ACMS v1 context policy set/show with persistence round-trip - Phase view inheritance (default → strategize → execute → apply) - Scoped context output per ACMS phase with narrowing size limits - Policy clear and inheritance fallback - ContextView validation rules (size limits, VALID_PHASES) Nine subcommands in the Python helper, each printing a sentinel string on success. All subcommands verified passing locally. Closes #406	2026-02-26 16:32:01 +00:00
brent.edwards	ffdd2f2b19	Merge branch 'master' into develop-brent-5	2026-02-26 16:14:07 +00:00
brent.edwards	32b81793a2	refactor(test): rename decision persistence files to avoid conflict with master ... Rename our serialization-focused decision persistence suites to *_serialization to avoid add/add conflicts with the repository-based decision persistence suites that landed on master independently: - decision_persistence.feature -> decision_persistence_serialization.feature - decision_persistence_steps.py -> decision_persistence_serialization_steps.py - decision_persistence_bench.py -> decision_persistence_serialization_bench.py - decision_persistence.robot -> decision_persistence_serialization.robot - helper_decision_persistence.py -> helper_decision_persistence_serialization.py Updated robot helper path, step docstring, and testing.md references.	2026-02-26 16:13:44 +00:00
aditya	76db58414a	Merge branch 'master' into feature/m3-agent-skills-loader	2026-02-26 14:51:41 +00:00
aditya	f8bc02869a	Merge branch 'master' into feature/m3-agent-skills-loader	2026-02-26 14:43:52 +00:00
khyari hamza	5d5d3fde2c	fix(security): close async resources and leaks ... Add AsyncResourceTracker (core/async_cleanup.py) providing a central registry for async resources with timeout-bounded close_all(), async context manager support, and a __del__ finalizer that logs leaked resources by name. Enhance LangGraphBridge with cleanup_tasks_async() that awaits in-flight tasks with a deadline instead of fire-and-forget cancel(). Add cancellation_reasons dict to trace why tasks were cancelled. Add StateManager.close() to properly release checkpoint file handles and complete the RxPY BehaviorSubject. Add AcpEventQueue.close() to dispose all subscriptions. Includes 14 Behave scenarios (67 steps), Robot integration tests, ASV benchmarks, and docs/reference/async_safety.md. ISSUES CLOSED: #321	2026-02-26 14:30:43 +00:00
khyari hamza	27bef69ddd	feat(decision): add decision persistence ... Add decision persistence layer with DecisionRepository, DecisionModel, and Alembic migration. Includes tree queries (BFS traversal via deque, path-to-root), superseded lookup, ordered decision path retrieval, concrete Decision type annotations (via TYPE_CHECKING), and comprehensive test coverage (Behave BDD, Robot Framework, ASV benchmarks). Updated database_schema.md, CHANGELOG.md, and CONTRIBUTORS.md. ISSUES CLOSED: #171	2026-02-26 13:40:07 +00:00
aditya	595cfd172f	Merge branch 'master' into feature/m3-mcp-adapter	2026-02-26 13:30:29 +00:00
aditya	b25a886df8	feat(skill): add MCP refresh hooks ... Implement SkillRegistry.refresh(name) and refresh_all() to recompute flattened tool sets on demand. Wire MCPToolAdapter.dispatch_notification() to MCPRefreshHook, which debounces rapid notifications/tools/list_changed bursts into a single refresh_all() call (default 0.5 s window). Add safeguard that skips tool-ref validation when no ToolRegistry is configured, emitting a single WARNING with recovery steps. Introduce immutable SkillRefreshResult (refreshed/failed/skipped counts) with to_summary() and merge() for CLI and log output. New files: - src/cleveragents/skills/refresh.py (SkillRefreshResult) - src/cleveragents/mcp/refresh_hook.py (MCPRefreshHook) - features/skill_refresh.feature (19 Behave scenarios) - features/steps/skill_refresh_steps.py - robot/skill_refresh.robot (10 Robot tests) - robot/helper_skill_refresh.py - benchmarks/skill_refresh_bench.py (ASV benchmarks) - docs/reference/skill_refresh.md Modified: - src/cleveragents/skills/registry.py (refresh, refresh_all) - src/cleveragents/mcp/adapter.py (notification listener API) - src/cleveragents/skills/__init__.py (export SkillRefreshResult) - src/cleveragents/mcp/__init__.py (export MCPRefreshHook) - CHANGELOG.md ISSUES CLOSED #168	2026-02-26 12:29:49 +00:00
aditya	c40ea014dc	feat(cli): add skill tools and refresh commands ... Implemented agents skill refresh command to recompute tool flattening and sync MCP-backed skills. Enhanced skill list/show/tools outputs with capability summary fields. - agents skill refresh <name>|--all to recompute flattening - Enhanced skill list/show/tools with capability summary and tool counts - Added --format json/yaml schemas for refresh output - CLI errors for nonexistent skills and MCP sync failures - Behave tests (skill_cli.feature), Robot tests (skill_cli.robot) - ASV benchmarks (skill_cli_bench.py) for CLI overhead baseline - Updated docs/reference/skill_cli.md with refresh command examples - Documented refresh side effects and caching behavior ISSUES CLOSED: #167	2026-02-26 10:57:07 +00:00
aditya	cb82fc51df	feat(skill): add agent skills loader ... Implemented AgentSkillSpec loader that parses SKILL.md frontmatter and progressive disclosure sections (discover/activate/deactivate) into structured SkillStep objects with stable 1-based ordering. Mapped Agent Skills to AgentSkillToolDescriptor with namespaced naming (namespace/short_name), source="agent_skill", read-only defaults, and AgentSkillResourceSlot bindings for scripts/, references/, and assets/ directories. All resource slots are unconditionally read_only. Added explicit validation for missing frontmatter fields (name, description) and invalid namespace format with actionable error messages. Added docs/reference/agent_skills.md covering folder layout, SKILL.md parsing rules, progressive disclosure model, and tool mapping. Added Behave scenarios covering valid/invalid SKILL.md parsing, namespaced naming, step ordering, missing frontmatter errors, progressive disclosure lifecycle, tool mapping, and resource binding slots. Added Robot Framework integration tests using the deploy-to-staging example skill folder (robot/agent_skills_loader.robot). Added ASV benchmarks for parsing throughput, folder load, progressive disclosure lifecycle, and resource listing (benchmarks/agent_skills_loader_bench.py). ISSUES CLOSED: #160	2026-02-26 09:10:35 +00:00
aditya	519e26fb02	Merge branch 'master' into feature/m3-mcp-adapter	2026-02-26 06:44:38 +00:00
aditya	b8d7c4c893	Merge branch 'master' into feature/m2-actor-yaml	2026-02-26 06:21:39 +00:00
freemo	e3fcce413b	feat(changeset): persist changesets and diff artifacts ... Add SQLite persistence for ChangeSet entries and ToolInvocation records via new changeset_repository module implementing the ChangeSetStore protocol. - Alembic migration d0_001 creates changeset_entries and tool_invocations tables - SqliteChangeSetStore, ChangeSetEntryRepository, ToolInvocationRepository - PlanApplyService.cleanup_changeset() for cancel/failure cleanup - Behave tests (17 scenarios), Robot tests (5 cases), ASV benchmarks - Reference documentation in docs/reference/changeset.md Closes #163	2026-02-26 02:47:14 +00:00
brent.edwards	2e2ae3b9b8	Merge test/m3-e2e-verification into develop-brent-5	2026-02-26 02:15:14 +00:00
brent.edwards	3d3c8fda33	Merge feature/m4-decision-tests into develop-brent-5	2026-02-26 02:15:01 +00:00
brent.edwards	b3f126b147	Merge feature/m3-decision-validation-smoke into develop-brent-5	2026-02-26 02:14:14 +00:00
brent.edwards	4f079c20ea	fix(test): route M3 E2E subcommands through CLI rendering path ... - decision-tree-view, decision-explain, and decision-tree-persistence now invoke 'plan status --format plain' via mocked lifecycle service so regressions in CLI rendering/serialization are caught - plan-generates-decisions now asserts use_action was called by the CLI and verifies plan status renders the strategize phase after creation - Updated robot test case documentation to reflect CLI integration	2026-02-26 01:26:02 +00:00
brent.edwards	b99510d016	fix(test): derive decision type count from enum instead of hard-coding 11 ... Replace hard-coded '11 decision types' with dynamic len(DecisionType) in the assertion and remove the literal from scenario names, step patterns, docstrings, and docs so the tests stay correct when new DecisionType values are added.	2026-02-26 01:19:28 +00:00
brent.edwards	93730067a2	fix(test): address review findings in M3 smoke tests ... - Replace dead after_scenario() hook with context.add_cleanup() calls so patchers are properly stopped (Behave only runs hooks from environment.py) - Fix invalid ULID constants: pad DECISION/CORRECTION to 26 chars, replace invalid 'I' with 'J' in INVARIANT_ULID - Add temp file cleanup for NamedTemporaryFile(delete=False) via context.add_cleanup() in behave steps and try/finally in robot helper - Remove decision-persistence doc sections from testing.md that belong in PR #438, not this PR	2026-02-26 01:13:16 +00:00
brent.edwards	c80cda2590	Merge feature/m4-correction-subplan-smoke into develop-brent-5	2026-02-25 22:11:33 +00:00
brent.edwards	a2b0611722	Merge branch 'test/m4-e2e-verification' into develop-brent-5	2026-02-25 22:10:46 +00:00
brent.edwards	49f097472a	Merge branch 'test/m3-e2e-verification' into develop-brent-5	2026-02-25 22:10:42 +00:00
brent.edwards	5a212481e1	Merge branch 'feature/m4-decision-tests' into develop-brent-5	2026-02-25 22:10:38 +00:00
brent.edwards	55df1915f1	fix(test): correct patch targets and ULID validation in M4 smoke helper ... - Patch CorrectionService at its definition site instead of the lazy import location in plan.py (same fix as M3 helper) - Replace hardcoded fake subplan/correction IDs with real ULIDs generated via ulid.ULID() to satisfy Pydantic pattern validation - Add missing --guidance flag to correction dry-run CLI invocation - Fix subplan-status-sequential assertion to check for plan_id (subplan_count is not part of the status JSON output)	2026-02-25 22:06:45 +00:00
brent.edwards	2e53caaef1	fix(test): correct patch target for CorrectionService in M3 e2e helper ... The CorrectionService import in plan.py is a lazy import inside the correct() function body, so it does not exist as a module-level attribute. Patch the class at its definition site instead: cleveragents.application.services.correction_service.CorrectionService Fixes CI integration_tests failure for PR #439.	2026-02-25 22:00:39 +00:00
brent.edwards	917c2bc546	test(e2e): add M4 correction + subplan suites	2026-02-25 21:51:26 +00:00
brent.edwards	cfc319ad27	test(e2e): verify M4 success criteria — subplans and parallel execution	2026-02-25 21:46:58 +00:00
brent.edwards	ace7311de4	test(e2e): add M3 decision + validation suites	2026-02-25 21:26:19 +00:00
brent.edwards	f4c4884d03	test(persistence): add decision persistence suites ... Add comprehensive persistence test suites for the Decision domain model covering serialization round-trips (model_dump/model_validate, JSON), context-snapshot persistence, correction-chain reconstruction, and decision-tree reconstruction from serialized data. Deliverables: - Behave: 21 scenarios in features/decision_persistence.feature - Robot Framework: 7 integration tests in robot/decision_persistence.robot - ASV benchmarks: 4 suites (17 benchmarks) in benchmarks/decision_persistence_bench.py - Documentation: Updated docs/development/testing.md ISSUES CLOSED: #180	2026-02-25 21:19:57 +00:00
brent.edwards	aeb5cc5110	test(e2e): verify M3 success criteria — decision tree and correction ... Robot Framework E2E test suite for M3 milestone verification covering: - Plan execution generating decisions during Strategize phase - Decision tree viewing with parent-child relationships and BFS traversal - Decision explanation with full context snapshot verification - Invariant add/list via CLI and InvariantService with scope filtering - Dry-run correction via CorrectionService with impact analysis - Live revert correction execution with decision re-creation - Context snapshot round-trip serialisation assertions - Decision tree persistence via model_dump/model_validate - Correction revert re-execution from decision point - Invariant enforcement during strategize with merge precedence ISSUES CLOSED: #404	2026-02-25 21:15:29 +00:00
brent.edwards	d055b59d7c	Merge branch 'master' into develop-brent-4	2026-02-25 20:05:18 +00:00
brent.edwards	583ff60bf3	fix(test): lower jitter spread threshold to prevent flaky CI failure ... The 'Test Concurrent Retries With Jitter' test asserted that 5 concurrent retry timestamps spread across >10ms. On busy CI runners thread scheduling can compress wakeups into a narrower window, causing spurious failures. Lowered the threshold from 10ms to 1ms — still validates that jitter produces non-identical delays while tolerating CI scheduling variance.	2026-02-25 20:04:36 +00:00
brent.edwards	3b58432ecc	docs(merge): merge new docs into branch	2026-02-25 19:41:56 +00:00
freemo	c4f71e930d	feat(concurrency): add plan resume ... Implement step-level progress persistence and plan resume with graceful shutdown handling. - Add ResumeCheckpoint, ResumeMetadata, ResumeEligibility, ResumeSummary domain models (resume.py) - Add PlanResumeService with validate_eligibility(), build_resume_summary(), resume_plan(dry_run), record_step_checkpoint(), record_shutdown() - Add last_completed_step and last_checkpoint_id fields to Plan model - Add 'plan resume' CLI command with --dry-run flag - Update plan lifecycle docs (ADR-006) with resume behavior section - Add Behave tests (24 scenarios in plan_resume.feature) - Add Robot Framework integration tests (10 tests) - Add ASV benchmarks for resume overhead Closes #328	2026-02-25 14:00:04 -05:00
freemo	134dce896a	feat(provider): add cost controls and fallback ... Add token/cost tracking, budget enforcement (per-plan and per-day), provider fallback selection with capability filtering, and cost metadata for plan models. New modules: - providers/cost_table.py: CostEntry + ProviderCostTable with default pricing for OpenAI, Anthropic, Google, Groq, Together, Cohere, Mock - providers/cost_tracker.py: BudgetStatus enum, BudgetCheckResult, CostTracker with warn-at-90%/block-at-100% enforcement - providers/fallback_selector.py: FallbackSelector with capability filtering (tool_calls, streaming, vision, json_mode) and budget - domain/models/core/cost_metadata.py: CostMetadata + BudgetExhaustionEvent Modified: - config/settings.py: budget_per_plan, budget_per_day, fallback_providers - domain/models/core/plan.py: cost_metadata field + CLI dict surfacing - providers/__init__.py: public exports for new classes Testing: - 71 Behave scenarios in features/cost_controls.feature (all pass) - 6 Robot Framework integration tests (all pass) - ASV benchmarks in benchmarks/cost_controls_bench.py - nox lint, typecheck, format, docs, build, dead_code, security_scan pass Closes #324	2026-02-25 12:08:01 -05:00
freemo	7a298ede6e	feat(concurrency): add plan and project locks ... Implemented plan-level and project-level locking with configurable timeouts. Added locks table via Alembic migration storing owner_id, resource_type, resource_id, acquired_at, and expires_at. Locks enforced in PlanLifecycleService transitions. Support for re-entrant acquisition, lock renewal, graceful shutdown release, and startup cleanup of expired locks. Added diagnostics check for stale lock reporting. ISSUES CLOSED: #327	2026-02-25 10:48:05 -05:00
aditya	2f9707cfdf	refactor(mcp): fix mock placement, type annotation, and constructor validation ... - Extract MockMCPTransport to features/mocks/mock_mcp_transport.py - Use ToolRegistry type with TYPE_CHECKING in register_tools() - Move transport config validation into __init__ via _validate_config()	2026-02-25 14:17:34 +00:00
aditya	ee82d6101e	feat(skill): add MCP adapter for external tools ... Implement MCPToolAdapter to connect to external MCP servers, enumerate tools, and register them in ToolRegistry with source="mcp". Includes connect/reconnect/disconnect lifecycle with timeout enforcement, input validation on invoke, capability inference, Behave/Robot/ASV tests, and docs/reference/mcp_adapter.md. ISSUES CLOSED: #159	2026-02-25 13:17:26 +00:00
aditya	913fd31e07	Merge branch 'master' into feature/m2-actor-yaml	2026-02-25 10:31:07 +00:00
aditya	e476d2de0e	feat(actor): extend hierarchical actor YAML schema and loader ... Extend actor YAML schema to support hierarchical graphs with explicit node types (agent, tool, conditional, subgraph), per-node LSP bindings (lsp_binding with server, languages, auto, capabilities), and tool-source references (skills, mcp_servers, agent_skills). Add schema validation for namespaced actor references, duplicate node IDs, edge target existence, and graph reachability — all nodes must be reachable from entry_node via explicit edges or conditional node routing targets. Update loader to report YAML parse errors with precise line/column positions and schema validation errors with dotted field paths and remediation hints pointing to docs/reference/actor_config.md. Add docs/reference/actor_config.md as the practical configuration reference covering hierarchical graph examples, node type table, topology rules, and common error cases with fix guidance. Refresh examples/actors/graph_workflow.yaml to replace deprecated actor_path with actor_ref. Add benchmarks/actor_yaml_bench.py for schema load overhead. Tests: 95 Behave scenarios, 10 Robot smoke tests (including hierarchical loader smoke test), security scan clean, coverage 99% (threshold 97%). ISSUES CLOSED: #157	2026-02-25 10:30:42 +00:00
CoreRasurae	55cee9b711	test(robot): fix failing integration tests related to security_secrets	2026-02-25 10:07:02 +00:00
CoreRasurae	a7dc917021	fix(security): harden template rendering ... ISSUES CLOSED: #319	2026-02-25 10:06:27 +00:00