239 Commits

Author	SHA1	Message	Date
HAL9000	1e543e8fa3	docs(development): add developer setup guide ... Add comprehensive developer setup guide covering prerequisites, development workflow, testing, linting, type checking, commit guidelines, devcontainer setup, and troubleshooting. Refs: #9123	2026-04-14 08:12:26 +00:00
HAL9000	b1f7b51a80	fix(concurrency): fix lock owner identity to prevent re-entrant acquisition ... The original implementation used plan_id as the owner_id when acquiring the advisory lock. Because LockService treats owner_id as the caller identity and allows re-entrant acquisition for the same owner, concurrent sessions attempting to lock the same plan would all present the same owner_id and thus silently renew the lock instead of raising LockConflictError. This fix generates a unique UUID for each invocation as the owner_id, ensuring that concurrent sessions present different owners and thus trigger LockConflictError when attempting to acquire the same plan lock. The lock is still acquired before the phase transition and released in a finally block to ensure cleanup even on error. ISSUES CLOSED: #8067	2026-04-14 03:58:16 +00:00
HAL9000	c11b05b773	docs(changelog): add v3.3.0 changelog entry for #7582 fail_fast fix	2026-04-14 02:51:16 +00:00
HAL9000	c0d631b6cc	fix: custom automation profiles silently fall back to manual ... _resolve_profile_for_plan in PlanLifecycleService now raises a clear ValidationError when a plan's automation profile name is not a known built-in profile, instead of silently falling back to 'manual'. Users who configured custom automation profiles (e.g. 'semi-auto', 'acme/strict') will now receive an actionable error message listing available built-in profiles. The resolved profile name is also logged at debug level for observability. Added BDD regression tests (8 scenarios) covering: - Built-in profiles resolve correctly - Plans with no profile set resolve to 'manual' - Custom/unknown profile names raise ValidationError - Error message mentions the unknown profile name - Error message lists available built-in profiles - Debug log records the resolved profile name ISSUES CLOSED: #8232	2026-04-13 21:16:55 +00:00
hurui200320	2005b8ef82	feat(tests): replace all @skip tags with proper @tdd_expected_fail tags or remove them across the entire codebase (#7221) ... ## Summary Replaces all 234 bare `@skip` occurrences across 82 Behave feature files with the correct TDD issue-capture tagging system described in CONTRIBUTING.md § Bug Fix Workflow. Previously, the noxfile ran Behave with `--tags=not @skip`, silently excluding all `@skip`-tagged scenarios from every CI run. These tests never ran, never inverted results via the `@tdd_expected_fail` mechanism, and never contributed to coverage — defeating the purpose of TDD issue-capture testing. Every `@skip` occurrence had a commented-out hint line immediately above it showing the intended proper tags (e.g., `# @tdd_issue @tdd_issue_4272 @tdd_expected_fail @skip`), confirming they were all intended for conversion. ## Changes ### Mechanical conversion (234 replacements across 82 files) - Extracted the proper TDD tags from the comment hint above each `@skip` line, removed `@skip` from the tag set, and replaced the `@skip` line with those tags. - Removed the now-redundant comment hint lines alongside each replacement. ### Bug-fixed scenarios — `@tdd_expected_fail` removed (84 scenarios) - After conversion, ran `nox -s unit_tests` to identify which newly-enabled `@tdd_expected_fail` scenarios now **pass** (their referenced bugs have already been fixed). Removed `@tdd_expected_fail` from those 84 scenarios and their corresponding feature-level tags, leaving only the permanent `@tdd_issue @tdd_issue_<N>` regression-guard tags. - Affected features include: `tdd_tool_runner_env_precedence`, `tdd_automation_profile_session_leak`, `tls_certificate_check`, `project_create_persist`, `resource_type_bootstrap_*`, and 18 others. ### Noxfile cleanup - Removed all four `--tags=not @skip` arguments from `noxfile.py` (unit_tests and coverage sessions). With zero `@skip` tags remaining in the codebase, this filter was dead code and its presence would mislead future maintainers into thinking `@skip` is still a supported escape mechanism. ### Regression guard files - Split the regression guards into two focused files: - `tdd_regression_guards_exec_env.feature` for bug #4281 (exec-env precedence) - `tdd_regression_guards_session_list.feature` for bug #4271 (session list summary) - Each file carries only its own `@tdd_issue` tags at the feature level, avoiding cross-contamination via Behave tag inheritance. The `Background` step (`session-list-summary mock`) only appears in the session-list file where it is actually needed. ### Duplicate tag cleanup - Removed duplicate `@tdd_issue @tdd_issue_4287` tag lines in `tdd_skill_add_regression.feature` (lines 20 and 29). ### Inline comment for retained `@tdd_expected_fail` - Added inline comment in `ci_workflow_validation.feature:134` explaining why this specific #4227 scenario retains `@tdd_expected_fail` despite #4227 being closed (CI YAML does not encode threshold as a machine-readable value). ### Known edge cases — `@tdd_expected_fail` retained (closed issues, fix on master, scenarios still fail) The following issues are **closed** and their fixes **are on master**, but the specific test assertions still fail because the fixes address other aspects of the bugs. The `@tdd_expected_fail` tags are functionally correct and must remain until the specific scenario assertions pass: - `tdd_exec_env_resolution_precedence.feature` — bug #1080 (closed 2026-03-31). The precedence-level-2-vs-4 scenario still fails. - `session_list_summary_dedup.feature` — bug #3046 (closed 2026-04-05). The dedup-consistency scenarios still fail. - `actor_add_update_enforcement.feature` — bug #2609 (closed 2026-04-05). The enforcement scenarios still fail. - `ci_workflow_validation.feature:134` — #4227 (closed 2026-04-08). The CI YAML threshold assertion still fails. ## Verification - `grep -r "@skip" features/ --include="*.feature"` → **zero results** ✓ - `grep -n "tags=not @skip" noxfile.py` → **zero results** ✓ - `nox -s unit_tests` → **629 features passed, 0 failed** ✓ (up from ~545 before this PR) - CI all green (coverage ≥ 97%) ✓ - Integration tests (Robot Framework) do not use `@skip` — confirmed no action needed ✓ - E2E tests (Robot Framework) do not use `@skip` — confirmed no action needed ✓ - `CHANGELOG.md` updated with entry for this change ✓ - `CONTRIBUTORS.md` — Rui Hu already listed ✓ ## Issues Addressed Closes #7025 Co-authored-by: CleverThis <hal9000@cleverthis.com> Reviewed-on: #7221 Reviewed-by: HAL 9000 <HAL9000@cleverthis.com> Reviewed-by: HAL9001 <hal9001@cleverthis.com> Co-authored-by: Rui Hu <rui.hu@cleverthis.com> Co-committed-by: Rui Hu <rui.hu@cleverthis.com>	2026-04-13 04:56:01 +00:00
HAL9000	c08187f336	docs(changelog): move ACMS fix to [Fixed] section and add sandbox root wiring ... Reclassify the ACMS context tier hydration entry as a bug fix and add the sandbox root wiring item so the changelog matches the behavior shipped in PR #4219 while preserving newer [Unreleased] additions. ISSUES CLOSED: #7628	2026-04-12 16:20:21 +00:00
HAL9000	251759c9b1	chore: add changelog entry and contributor for #7508 validation gate fix ... - Add CHANGELOG.md entry under [Unreleased] ### Fixed for the empty-run guard added to ApplyValidationSummary.all_required_passed - Add HAL 9000 to CONTRIBUTORS.md per CONTRIBUTING.md §PR Process Rule 8	2026-04-12 08:15:49 +00:00
HAL9000	c76433f756	docs(tracking): document automation-tracking-manager centralization	2026-04-11 00:40:19 +00:00
CoreRasurae	527c5903a0	fix(cli): display full ULIDs in plan tree output for CLI usability ... Modified the agents plan tree command to display full 26-character ULIDs instead of truncating them to 8 characters. This enables users to copy decision IDs directly from the tree output and use them in follow-up CLI commands without manual ID reconstruction. Key changes: - Removed [:8] truncation from all decision ID displays (table, tree) - Updated table column width from 8 to 26 characters for full ULID display - Removed [...] truncation from plan ID in tree title - Added 'Decision IDs (for correction)' section listing all decision ULIDs with human-readable labels for easy reference - Supports both rich (with panel) and plain text formatting - Helper function _get_decision_label() generates appropriate labels based on decision type - Updated CHANGELOG.md per CONTRIBUTING.md requirements ISSUES CLOSED: #5825	2026-04-10 18:57:41 +01:00
HAL9000	79359baff3	docs: update CHANGELOG and automation-tracking for recent agent changes ... ISSUES CLOSED: #7116	2026-04-10 10:32:00 +00:00
hamza.khyari	06428a5db6	feat(plan): implement git worktree sandbox for execute and merge-based apply ... Replace flat shutil.copy2 apply with spec-aligned git worktree flow (specification.md §13225-13276): Execute phase: creates an isolated git worktree via GitWorktreeSandbox for the plan's linked git-checkout resource. LLM file output is written to the worktree and committed on branch cleveragents/plan-<plan_id> — no merge yet. Apply phase: merges the worktree branch into the project's current branch via git merge. Prints spec-aligned panels: - Apply Summary: Plan ID, artifacts count, insertions/deletions, project name, applied-at timestamp - Sandbox Cleanup: worktree removed, branch merged to main - Footer: ✓ OK Changes applied Non-git projects (fs-directory resources) fall back to the original flat directory sandbox with shutil.copy2. Also fixes: - context_tier_hydrator metadata types (int/float → string) that caused Pydantic validation errors during context assembly - A2A facade duplicate execute dispatch (idempotent handler) - Logs actual error from context assembly failures ISSUES CLOSED: #4454	2026-04-09 14:17:50 +00:00
hamza.khyari	5d0e739e43	fix(acms): wire ACMS indexing pipeline into CLI so ContextTierService is populated during plan execution ... ContextTierService started empty on every CLI invocation, so the LLM received zero file context during plan execution (bug #1028). - Add context_tier_hydrator.py: reads files from linked project resources (via git ls-files or os.walk) and stores them as TieredFragment objects in the tier service. Respects max file size (256 KB), total budget (10 MB), binary exclusion, and .git/node_modules/__pycache__ skipping. - Wire hydration into LLMExecuteActor.execute() via lazy import (avoids M1 E2E regression from top-level import). - Inject tier_service, project_repository, resource_registry into LLMExecuteActor from the DI container in _get_plan_executor(). - Add tier_service property to ExecutePhaseContextAssembler. - Suppress exc_info traceback rendering in context warnings to prevent false-positive crash detection in M1 E2E tests. - Add sandbox file-writing support in plan apply (path traversal guards, protected directory skipping). - Add 6 Behave scenarios for context tier hydration. Closes #1028	2026-04-09 13:00:47 +00:00
freemo	89bef73f89	docs(changelog): add entries for automation tracking and label management ... Document recent agent infrastructure improvements: - Automation tracking system with individual per-agent tracking issues - Automated health monitoring and recovery via system-watchdog - Centralized org-level label management via forgejo-label-manager - PR label synchronization with associated issues ISSUES CLOSED: #4940	2026-04-08 23:42:11 +00:00
freemo	98994e8b84	docs(lsp): document LspLifecycleManager restart_server deadlock fix ... Reviewed and APPROVED. Documentation-only PR.	2026-04-05 21:08:33 +00:00
freemo	cdc93dc3cd	fix(resources): support multiple named devcontainer configurations ... Reviewed and APPROVED. Closes #2615.	2026-04-05 21:07:42 +00:00
freemo	f1ab5d90dc	docs: update documentation for v3.8.0 unreleased features ... - Promote [Unreleased] CHANGELOG entries to [3.8.0] (2026-04-05) - Add Shell Danger Detection section to docs/api/tui.md covering ShellDangerLevel, DangerousPattern, ShellSafetyService, and SafetyCheckResult with full API reference and usage examples - Add InvariantService section to docs/api/core.md documenting the new DI-registered singleton, its methods, and emitted events - Update docs/architecture.md Plan Lifecycle section to document invariant reconciliation as a phase transition gate - Update README.md Highlights with shell danger detection, inline permission questions, invariant reconciliation, UKO provenance tracking, and JSON-RPC 2.0 A2A wire format - Create docs/modules/shell-safety.md with full module guide covering purpose, key classes, built-in patterns, custom pattern registration, TUI integration, and testing guidance ISSUES CLOSED: #1003 #997 #1391 #1004 #891 #1501 #1577 #1941 #2334	2026-04-05 19:33:19 +00:00
freemo	a8f26cb691	docs(lsp): document LspLifecycleManager restart_server lock pattern fix (#3165)	2026-04-05 18:09:32 +00:00
freemo	a05f4c69a7	fix(resources): support multiple named devcontainer configurations in auto-discovery ... Extend DevcontainerDiscoveryResult and discover_devcontainers() to scan .devcontainer/<name>/devcontainer.json patterns (one subdirectory level) in addition to the existing fixed paths. Each named configuration produces a distinct result with config_name set to the subdirectory name (e.g. 'api', 'frontend'). Root-level configs retain config_name=None. - Replace _SCAN_PATHS with _FIXED_SCAN_PATHS for root-level configs - Add glob-based scan of .devcontainer/<name>/devcontainer.json - Add config_name: str | None attribute to DevcontainerDiscoveryResult - Validate config_name (must be non-empty str or None) - Add 8 new Behave scenarios covering named, multiple, mixed, empty cases - Add 4 new Robot Framework integration tests for named config discovery - All existing tests continue to pass (no regression) ISSUES CLOSED: #2615	2026-04-05 18:08:56 +00:00
Luis Mendes	a0c7f5188e	feat(plan): wire invariant reconciliation actor auto-invocation ... Wire the InvariantReconciliationActor into PlanLifecycleService phase transitions so that invariant reconciliation runs automatically at each lifecycle boundary. This ensures plan invariants are verified before processing can proceed. Changes: - Add InvariantService as a new optional dependency on PlanLifecycleService (injected via the DI container as a Singleton provider) - Add _run_invariant_reconciliation() method that creates and invokes the reconciliation actor, emits INVARIANT_RECONCILED events on success, and raises ReconciliationBlockedError (with INVARIANT_VIOLATED event) on failure to block the phase transition - Invoke reconciliation at three phase transition points: 1. start_strategize() - after preflight guardrails, before PROCESSING 2. execute_plan() - after estimation/error patterns, before Execute 3. apply_plan() - after state validation, before Apply transition - Subscribe to CORRECTION_APPLIED events for post-correction reconciliation (best-effort, failures logged but not re-raised) - Per-plan disable: reconciliation is skipped when plan.invariant_actor is None or "__optional__", following the established estimation actor pattern - Decision recording: the reconciliation actor already records invariant_enforced decisions via DecisionService Tests: - Behave: 10 scenarios in invariant_reconciliation_autowire.feature covering auto-invocation, skip-when-disabled, transition blocking, decision recording, and post-correction reconciliation - Robot: 5 integration tests in invariant_reconciliation_autowire.robot - All nox sessions pass (lint, typecheck, unit_tests, integration_tests, coverage_report at 97%) ISSUES CLOSED: #829	2026-04-05 05:46:05 +00:00
freemo	6e94e1d321	fix(persistence): close session in AutomationProfileRepository auto_commit finally block ... Add missing `finally: if self._auto_commit: session.close()` blocks to all four public session-creating methods in AutomationProfileRepository: get_by_name(), list_all(), upsert(), and delete(). Closes #987	2026-04-04 19:58:54 +00:00
freemo	5c0016c79d	docs: add DomainBaseModel API reference and CI template DB changelog entry ... Add DomainBaseModel section to docs/api/core.md documenting the shared Pydantic base class from PR #2014 (issue #1941), and add CHANGELOG entry for the CI template DB extension from PR #2399 (issue #2334). ISSUES CLOSED: #1941 Co-authored-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com> Co-committed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com>	2026-04-03 20:41:23 +00:00
Luis Mendes	9e93ea5fc6	fix(persistence): close session in AutomationProfileRepository auto_commit finally block ... Add missing `finally: if self._auto_commit: session.close()` blocks to all four public session-creating methods in `AutomationProfileRepository`: `get_by_name()`, `list_all()`, `upsert()`, and `delete()`. Without these blocks, sessions were never closed when the repository operated in auto_commit mode, causing a slow session leak that could exhaust the connection pool over time. The fix mirrors the pattern already used by `SessionRepository`, which correctly closes its session in a `finally` block for every public method. Removed the `@tdd_expected_fail` tag from the TDD test (`tdd_automation_profile_session_leak.feature`) so the six scenarios now run as normal regression tests (four original plus two new scenarios for `get_by_name` and `list_all`). ISSUES CLOSED: #987	2026-04-03 19:00:22 +00:00
freemo	d66887766f	docs(tui): document PermissionQuestionWidget and add CHANGELOG entry ... Add PermissionQuestionWidget API documentation to docs/api/tui.md including method table, key bindings, PermissionDecisionEvent dataclass, and render_permission_question() helper reference. Add corresponding CHANGELOG entry under [Unreleased] Added section. Refs: #997	2026-04-03 06:39:51 +00:00
freemo	2770f6afdd	docs: restructure [Unreleased] CHANGELOG and add entries for recent merged PRs ... Consolidate duplicate Added/Fixed headings in [Unreleased] section into single canonical sections per Keep a Changelog format. Add new entries for DomainBaseModel (#1941) and TDD bug-capture test (#1094). Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me> Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>	2026-04-03 04:16:19 +00:00
freemo	108d87e1bb	docs: update CHANGELOG and A2A API docs for recent merged PRs ... Add CHANGELOG [Unreleased] entries for 6 recently merged commits: - feat(tui): shell danger detection patterns (#1003) - fix(a2a): JSON-RPC 2.0 wire format compliance — BREAKING field rename (#1501) - fix(cli): disallow mixing legacy and v3 plan workflows (#1577) - fix(cli): actor add rich output missing panels - fix(infra): E2E suite centralized database initialization (#1023) - ci(pipeline): parallelized static analysis jobs Update docs/api/a2a.md to reflect JSON-RPC 2.0 field name changes: A2aRequest.operation → method, A2aResponse.data → result, etc.	2026-04-03 02:43:00 +00:00
freemo	0382b2f722	docs: update changelog and CLI reference docs for 2026-04-02 merged PRs ... - CHANGELOG: add Fixed entries for PRs #1574, #1570, #1569, #1547, #1548, #1522, #1524, #1525, #1520, #1553 covering rich output panels for session, actor, and plan commands, plus version commit SHA and provider fix - docs/reference/session_cli.md: document new rich output panels for session create (Settings, Actor Details), session list (Name column, Summary panel), session show (Automation field), session delete (Deletion Summary, Cleanup panels); update export to document --format md - docs/reference/actor_cli.md: document new rich output panels for actor remove (Actor Removed, Impact, Cleanup) and actor list (Summary panel) - docs/reference/plan_cli.md: document new rich output for plan list (Elapsed column, Filters panel, Summary panel) - docs/reference/cli_system_commands.md: document commit SHA resolution order (CLEVERAGENTS_COMMIT env var → git rev-parse → 'unknown') ISSUES CLOSED: #1574 #1570 #1569 #1547 #1548 #1522 #1524 #1525 #1520 #1553	2026-04-02 23:06:12 +00:00
freemo	7f5a330f23	docs(changelog): add Fixed entries for PRs #1498, #1481, #1479 ... - tool add: handle tool: wrapper key (#1471) - session export: sha256: prefix checksum (#1450) - ThoughtBlockWidget: correct background color (#1448) ISSUES CLOSED: #1471 #1450 #1448	2026-04-02 20:21:43 +00:00
freemo	71177c6e1a	docs: update changelog, API docs, and architecture for 2026-04-02 merged PRs ... - CHANGELOG: add [Unreleased] entries for TUI first-run experience (#1391), session Markdown export (#1004), and UKO provenance/temporal versioning (#891) - README: add first-run experience and Markdown transcript export bullets - docs/api/tui.md: new TUI API reference covering first-run, persona system, input routing, slash commands, session export/import, and widgets - docs/api/index.md: add TUI entry to module index - docs/api/resource.md: document DatabaseResourceHandler and DevcontainerHandler full protocol implementations with method tables and examples - docs/architecture.md: expand UKO section with provenance/temporal versioning details; update TUI design decision summary - mkdocs.yml: add TUI page to API Reference nav ISSUES CLOSED: #1391 #1004 #891	2026-04-02 19:30:53 +00:00
freemo	0d4c5b6ff1	docs: add v3.7.0 cycle-2 documentation for UKO runtime, TUI permissions, database handler, and thought blocks ... - CHANGELOG.md: extend [3.7.0] section with 15 new entries covering PermissionsScreen, ThoughtBlock, UKO runtime services, ACMS Phase 2 protocol aliases, DevcontainerHandler protocol completion, DatabaseResourceHandler CRUD/checkpoint, estimation lifecycle hook, user_identity domain events, PLAN_APPLIED/PLAN_CANCELLED enrichment, server serve subcommand, async audit refactor, and CLI flag fixes - README.md: extend Highlights with permissions screen, thought blocks, UKO runtime, database handler, and estimation lifecycle - docs/reference/uko_runtime.md: new reference for UKOQueryInterface, UKOInferenceEngine, and UKOGraphPersistence (issue #891) - docs/reference/tui_permissions.md: new reference for PermissionsScreen, PermissionRequestService, and all domain models (issue #996) - docs/reference/tui_thought_block.md: new reference for ThoughtBlock domain model and ThoughtBlockWidget (issue #1001) - docs/reference/database_handler.md: new reference for DatabaseResourceHandler CRUD and checkpoint methods (issue #1241) - docs/reference/devcontainer_resources.md: add DevcontainerHandler protocol methods section (delete, list_children, diff, create_sandbox) (issue #1242) - docs/reference/tui.md: extend architecture table and add Permissions Screen and Actor Thought Blocks sections ISSUES CLOSED: #1393	2026-04-02 17:35:41 +00:00
freemo	dd3770f930	refactor(correction): eliminate redundant fields in CorrectionDryRunReport (#1278) ... Remove three top-level fields from CorrectionDryRunReport that duplicated data already present in the embedded CorrectionImpact object: - excluded_decisions → now accessed via report.impact.excluded_decisions - rollback_tier_depth → now accessed via report.impact.rollback_tier_depth - child_plans_to_rollback → now accessed via report.impact.affected_child_plans The redundant fields created a divergence risk: both models are frozen=True Pydantic models, so post-construction mutation is impossible, but nothing prevented constructing an instance where the top-level copies disagreed with the impact sub-object. Approach: Option B (nest-only) — remove the duplicated top-level fields and update all consumers to use the impact object's fields instead. Closes #1087 Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me> Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>	2026-04-02 16:59:40 +00:00
freemo	b772a43ac6	docs: add TUI reference, persona docs, and v3.7.0 changelog ... - docs/reference/tui.md: new TUI reference covering launch, layout, key bindings, input modes, help panel (F1), persona bar, full slash command catalog (67 commands / 14 groups), persona YAML schema, and module architecture table - docs/reference/persona.md: new persona system reference covering storage layout, YAML schema, validation rules, argument presets, PersonaRegistry and PersonaState Python APIs, and TUI slash commands - CHANGELOG.md: add [3.7.0] section summarising TUI, persona system, session management, server mode, A2A integration, and key fixes - README.md: extend Highlights with TUI, persona, session, server mode, and A2A; add TUI quick-start, session management, and server mode usage examples	2026-04-02 16:52:59 +00:00
hamza.khyari	c200fe0f86	feat(lsp): implement get_hover and get_definitions for LSP runtime (#1240) ... Add hover and definition support to LspClient and LspRuntime. - LspClient.get_hover(): sends textDocument/hover, returns Hover dict or None - LspClient.get_definitions(): sends textDocument/definition, handles Location, Location[], and LocationLink[] responses - LspRuntime wrappers: input validation, file reading, language detection, 1-based to 0-based line/column conversion - try/finally for did_close() safety on both new methods - Tool adapter: HOVER and DEFINITIONS dispatch to runtime instead of raising LspNotAvailableError - Updated lsp_tool_adapter_coverage test (HOVER -> REFERENCES) - 21 Behave BDD scenarios with full path coverage Closes #1243 Co-authored-by: Hamza Khyari <hamza.khyari@cleverthis.com> Co-committed-by: Hamza Khyari <hamza.khyari@cleverthis.com>	2026-04-02 16:52:33 +00:00
CoreRasurae	b21e0fedea	test(bdd): add direct test for _fast_init_or_upgrade early-return behavior ... Add 8 BDD scenarios in features/fast_init_upgrade.feature that directly exercise the _fast_init_or_upgrade closure installed by _install_template_db_patch in features/environment.py. Scenarios cover all code paths: - Non-empty DB with matching prefix → early return (original NOT invoked) - Non-existent DB with matching prefix → template copied (original NOT invoked) - Existing empty DB with matching prefix → template copied (original NOT invoked) - Non-matching prefix → delegates to original init_or_upgrade - In-memory SQLite → delegates to original init_or_upgrade - Non-SQLite URL → delegates to original init_or_upgrade - Bare sqlite:// URL → delegates to original init_or_upgrade - Delegation forwards runner instance and keyword arguments correctly Test infrastructure: - features/mocks/fast_init_test_helpers.py provides a context manager (patch_original_init_or_upgrade) that replaces the _original_init_or_upgrade reference inside the closure via cell_contents manipulation, enabling precise call-tracking without recreating the function under test. - All scenarios tagged @mock_only to skip unnecessary DB setup. - Cleanup registered via context._cleanup_handlers for temp file removal. - Works in both sequential and parallel execution modes. Review fix round: - Added bare sqlite:// URL scenario covering the second branch of the in-memory disjunction (L1). - Added scenario verifying runner instance and keyword argument forwarding through the delegation path (L2, L3). - Replaced hardcoded test credentials with clearly synthetic pattern (I4). - Fixed CHANGELOG wording that incorrectly claimed mktemp replacement (L5). ISSUES CLOSED: #733	2026-04-01 23:52:20 +01:00
brent.edwards	0ae733d01f	feat(tui): implement help panel (F1) with context-sensitive help ... Add a dedicated TUI help overlay toggled by F1 and resolve its content from the current prompt mode for main-screen, slash-command, reference, and shell contexts. Extend Behave and Robot coverage for the new help-panel widget, app wiring, context switching, and toggle behavior. ISSUES CLOSED: #1013	2026-04-01 21:51:14 +00:00
brent.edwards	dc1359fc07	feat(tui): enumerate full slash command set (60+ commands, 14 groups) ... Add a specification-aligned slash command catalog and wire it into TUI overlay initialization so command discovery reflects the complete command surface. Cover command and group cardinality plus representative command presence in Behave tests. ISSUES CLOSED: #1002	2026-04-01 09:23:21 +00:00
aditya	137d040c4d	feat(acms): implement DepthReductionCompressor for skeleton compression ... Add a production skeleton compressor that re-renders inherited fragments to overview depths via the UKO detail-level map chain, fits the result within the configured skeleton budget, and wires the pipeline default to the new compressor. Address prior review feedback by extracting the render visitors into a dedicated module, restoring projected metadata to native runtime types, constraining builtin component resolution with an allowlist, and keeping child-context inheritance compatible with CRP context fragments for the Robot integration path. Reproduced the Forgejo lint job in a clean python:3.13-slim container with the CI commands All checks passed! and 1740 files already formatted; both passed, so the earlier lint failure appears to have been transient runner behavior rather than a source-level defect. ISSUES CLOSED: #919	2026-04-01 06:16:41 +00:00
brent.edwards	81c141716b	test(integration): workflow example 2 — automated test generation for a module (trusted profile) (#1176) ... ## Summary - Refactors WF02 integration helper into focused modules to satisfy maintainability guidelines and keep command responsibilities isolated. - Moves WF02 artifact assertions onto lifecycle-produced change artifacts and verifies user-facing `plan artifacts` flow with mocked providers. - Reworks WF02 coverage-gate assertions to run through validation registration/attachment/execution lifecycle and apply-gate outcomes. ## What changed in this fix round (cycle-6) - **CI must-fix — trusted profile lifecycle integration failure:** - Fixed failing integration test `WF02 Trusted Profile Auto Runs Strategize And Execute` caused by legacy AutomationProfile fields that no longer exist. - Updated WF02 trusted-profile assertions from removed legacy fields (`auto_strategize`, `auto_execute`, `auto_apply`) to current spec-aligned fields (`decompose_task`, `create_tool`, `select_tool`). - Key module: `robot/wf02_test_generation_commands.py` (`wf02_trusted_lifecycle`). ## Prior fix rounds retained - **P1 must-fix — validation payload assertions strengthened:** - Added explicit assertions for validation payload correctness in both failing and passing branches. - Assertions now verify: - validation identity (`local/auth-coverage` on `local/api-service-repo`) - required-mode semantics (`mode=required`, required pass/fail counters, `all_required_passed`) - `passed` boolean for each branch - measured-vs-target semantics (`measured_coverage` compared against `target`). - Key module: `robot/wf02_test_generation_validation.py`. - **P2 should-fix — artifact membership assertions tightened:** - Artifact assertions now enforce exact expected membership and count instead of permissive subset checks. - Persisted changeset assertions were aligned to the same strict set/count checks. - Key module: `robot/wf02_test_generation_artifacts.py`. - **P2 should-fix — removed unused helper:** - Deleted unused `_bind_changeset_to_plan` helper to eliminate dead code. - Key module: `robot/wf02_test_generation_artifacts.py`. - **P2 should-fix — concrete typing:** - Replaced `_setup_validation_db` return type from `tuple[Any, Any]` to concrete typed return (`Callable[[], _NoCloseSession]`, `Session`). - Key module: `robot/wf02_test_generation_validation.py`. ## Quality gates - `nox -e lint` ✅ - `nox -e typecheck` ✅ - `nox -e unit_tests` ✅ - `nox -e integration_tests` ✅ - `nox -e e2e_tests` ✅ - `nox -e coverage_report` ✅ (coverage: **98.74%**) ## Scope / limitations - No deferred items identified in cycle-6. Closes #766 Reviewed-on: #1176 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com> Co-authored-by: Brent Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent Edwards <brent.edwards@cleverthis.com>	2026-04-01 03:30:00 +00:00
brent.edwards	91cc0b1446	test: add TDD bug-capture test for #1025 — plan correct auto-resolve (#1172) ... ## Summary - add Behave `@tdd_expected_fail` bug-capture scenarios for `plan correct` auto-resolve without `--plan` - add shared mock fixtures and Robot integration coverage for isolated-container divergence reproducing bug #1025 - add ASV benchmark coverage for active-plan filtering and document the new TDD capture in changelog ## Testing - nox -s unit_tests -- features/tdd_plan_correct_auto_resolve.feature - nox -s integration_tests -- --include tdd_bug_1025 - nox -s lint - nox -s typecheck - nox -s coverage_report - nox Closes #1035 Reviewed-on: #1172 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com> Co-authored-by: Brent Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent Edwards <brent.edwards@cleverthis.com>	2026-04-01 00:40:46 +00:00
hamza.khyari	5e96b4bf80	feat(resource): implement 6-level execution environment precedence chain ... Implement the spec's 6-level execution environment precedence chain (spec lines 19324-19386): 1. Plan override (priority=override) — always wins 2. Project override (priority=override) — wins over devcontainer 3. Nearest-ancestor devcontainer — auto-discovered 4. Plan fallback (priority=fallback) — defers to devcontainer 5. Project fallback (priority=fallback) — defers to closer scopes 6. Host default — final fallback - New resolve_with_precedence() API on ExecutionEnvironmentResolver - Added execution_env_priority field to ContextConfig (project model) - has_devcontainer() helper for devcontainer-instance detection - Legacy 4-level resolve() preserved for backward compatibility - _parse_priority() defaults missing priority to FALLBACK - 13 new Behave scenarios testing all 6 levels + edge cases - Updated CHANGELOG ISSUES CLOSED: #877	2026-03-31 16:01:58 +00:00
hamza.khyari	cd9cb9e889	fix(cli): honour project-level execution-env-priority in resolution ... Thread plan_env and project_env through the tool execution chain so the ExecutionEnvironmentResolver receives project-level execution environment values stored in ContextConfig.execution_environment. The resolver's precedence logic (tool > plan > project > default) was already correct, but callers never passed project_env — tools always fell through to the global HOST default, ignoring project-level overrides entirely. Changes: - PlanExecutionContext: add plan_env and project_env fields + properties - ToolCallRouter: accept plan_env/project_env in constructor, pass to runner.execute() in route() and route_streaming() - ToolCallingRuntime: accept plan_env/project_env, pass to runner.execute() in the direct-runner fallback path - Update monkey-patched execute stubs in tool_router_steps.py to accept explicit plan_env/project_env keyword arguments - Add 4 BDD scenarios proving plan_env/project_env reach the resolver via ToolCallRouter (project-only, plan-only, both, neither) Dependency: requires PR #1135 to be merged first (adds CLI flag and persistence for project-level execution-env-priority). Closes #1080 ISSUES CLOSED: #1080	2026-03-31 11:31:00 +00:00
hamza.khyari	3f66221938	test(integration): workflow example 5 — database schema migration with safety nets (review profile) ... Robot Framework integration test suite for Specification Workflow Example 5: Database Schema Migration with Safety Nets. Exercises the review automation profile with custom resource types, custom skills with database tools, phased child plan execution, checkpointing, and rollback. - 7 test cases covering: custom resource type registration, review profile behavior, custom skill with 3 database tools, action creation with review profile, checkpoint/rollback via managers, 5-phase sequential SubplanService.spawn with fail-fast, and plan lifecycle through strategize-to-execute - Uses mocked LLM providers (CLEVERAGENTS_TESTING_USE_MOCK_AI=true) - All Run Process calls have timeout=60s on_timeout=kill - Fix environment-dependent test failures: mock shutil.disk_usage in disk space and diagnostics --check Behave steps so tests pass regardless of CI runner disk space; Robot diagnostics test tolerates disk-space errors ISSUES CLOSED: #769	2026-03-31 11:03:20 +00:00
CoreRasurae	a4a6b061a6	fix(db): align v3_plans schema with specification DDL ... Aligned v3_plans table with specification DDL: 1. Added effective_profile_snapshot column (TEXT NOT NULL) for storing frozen JSON snapshot of automation profile at plan creation time. Added Pydantic field_validator ensuring the value is well-formed JSON. Validator catches RecursionError for deeply nested JSON, consistent with automation_profile deserialization hardening. Validator error message uses length-only to avoid potential information disclosure. Documented that the default "{}" exists for backward compatibility; new plans should explicitly set the snapshot. 2. Made root_plan_id NOT NULL — root plans self-reference their own plan_id, child plans reference the root ancestor. Added explicit ondelete="RESTRICT" FK policy for consistency with other FKs in the model. Documented known FK policy drift between ORM model (RESTRICT) and migrated databases (retained SET NULL) in the migration; data integrity is preserved by the NOT NULL constraint regardless. Moved root_plan_id self-reference resolution into a PlanIdentity model_validator so the domain model is consistent with the DB NOT NULL constraint before and after persistence (previously the resolution only happened in from_domain(), creating an asymmetry where root_plan_id was None in-memory but non-null after round-tripping through the database). 3. Made automation_profile NOT NULL with default "balanced". 4. Documented intentional deviation: phase default is "action" (code) vs "strategize" (spec) because the Action phase was added as a pre-Strategize setup step. 5. Created Alembic migration with backfill logic for existing rows. Root-ancestor backfill uses level-by-level propagation with a parent-readiness guard to correctly resolve plans at arbitrary hierarchy depth (3+ levels). Added safety bound (max 100 iterations) with logged error on exhaustion to guard against cycles in parent_plan_id. Merged batch_alter_table operations to avoid redundant full-table copies in SQLite batch mode. Migration backfill also handles empty-string automation_profile values. Documented downgrade limitation (backfill is not reversible). Orphan-row fallback now logs affected row count at WARNING level. Migration cycle-detection now logs affected plan_id values before the orphan fallback overwrites them. All migration SQL uses sa.text() for consistency with SQLAlchemy best practices. 6. Hardened automation_profile deserialization in to_domain() to catch ValueError (invalid StrEnum provenance), Pydantic ValidationError, and RecursionError (deeply nested JSON) in addition to JSONDecodeError and KeyError, preventing unreadable plans from corrupted DB rows. Applied the same defensive deserialization pattern to effective_profile_snapshot in to_domain(): corrupted JSON falls back to '{}' with a WARNING log instead of crashing the read path. Added TypeError to the effective_profile_snapshot exception list in to_domain() for consistency with the Pydantic validator. Logging of unparseable values uses length only to avoid potential information disclosure. 7. Used explicit None check (is not None) instead of truthiness for root_plan_id resolution in from_domain(), for effective_profile_snapshot in to_domain(), and in _serialize_automation_profile() for consistency. 8. Documented intentional column naming conventions vs spec DDL (e.g. automation_profile vs automation_profile_name, *_actor vs *_actor_name, processing_state vs state, v3_plans vs plans). Documented the semantic difference: automation_profile stores either a bare name or structured JSON with provenance, whereas the spec automation_profile_name stores a plain name. 9. Fixed benchmark plan constructors (plan_phase_migration_bench.py) that were missing the now- required root_plan_id and effective_profile_snapshot fields. 10. Replaced defensive getattr() with direct attribute access for effective_profile_snapshot in from_domain() and update(), since the field is now defined on the Plan domain model. 11. Fixed Any type annotation in test helper _make_plan() to use AutomationProfileRef | None for proper type safety. 12. Added BDD scenarios for PlanIdentity self-reference resolution, NULL effective_profile_snapshot constraint enforcement, valid-JSON-missing-profile_name-key deserialization, invalid-JSON and empty-string snapshot rejection by Pydantic validator, and corrupted effective_profile_snapshot DB fallback in to_domain(). 13. Extracted default automation profile name to a module-level constant (DEFAULT_AUTOMATION_PROFILE) to reduce sentinel duplication across models.py and repositories.py. 14. Centralised automation-profile serialisation into LifecyclePlanModel._serialize_automation_profile() to eliminate duplication between from_domain() and LifecyclePlanRepository.update(). 15. Fixed to_domain() root_plan_id type cast from str | None to str, reflecting the NOT NULL column constraint. 16. Added PlanIdentity model_validator that resolves None root_plan_id to plan_id at domain construction time, ensuring the domain model honours the spec DDL NOT NULL constraint regardless of persistence state. Simplified from_domain() root resolution accordingly. ISSUES CLOSED: #921	2026-03-30 23:40:36 +01:00
hamza.khyari	49015c6bee	fix(cli): implement --execution-env-priority on project context set ... Add --execution-env-priority flag to 'project context set' command, enabling project-level execution environment priority per spec WF17. - Add execution_env_priority field to ContextConfig domain model - Validate flag value against ExecutionEnvPriority enum (fallback/override) - Persist in context_policy_json, preserving existing execution_environment - Display in 'project context show' Execution Environment section - Merge with existing blob to avoid overwriting previously set fields Tests: 9 Behave scenarios, 26 steps. ISSUES CLOSED: #1079	2026-03-30 14:33:28 +00:00
CoreRasurae	007af498b8	refactor(autonomy): rename automation profile task flags to spec names ... Renamed all 11 task-type confidence threshold fields in AutomationProfile from phase-transition semantics to spec-defined task-type semantics. Updated all 8 built-in profiles, CLI formatting, YAML schema, services, and all Behave/Robot tests referencing the old field names. Post-review fixes: - Fixed 24 stale old field names in M6 fixture files (automation_profiles.json, autonomy_guardrails.json) - Added model_validator(mode='before') to detect legacy field names and raise actionable ValueError with rename mapping - Added semantic bridge comments in PlanLifecycleService mapping task-type thresholds to phase-transition gates - Added threshold_field to structured log messages for observability - Restored categorised CLI automation-profile show output to match spec (Phase Transitions / Decision Automation / Self-Repair / Execution Controls) instead of flat list - Added missing access_network field to spec show output examples (Rich, Plain, JSON, YAML variants) - Aligned ADR-017 profile fields table to all 11 fields with descriptions matching spec Automatable Tasks table - Aligned automation_profiles.md threshold descriptions with spec - Added spec section references in phase_reversion.md, error_recovery.md, and plan_execute.md for field naming context - Extended repository roundtrip test to assert all 11 threshold fields - Fixed benchmark _make_profile() passing safety fields as top-level kwargs instead of via SafetyProfile sub-model (incompatible with extra="forbid") - Aligned CLI JSON/YAML output structure for automation-profile show with the specification grouped format (phase_transitions, decision_automation, self_repair, execution_controls) - Moved safety boolean fields into the Execution Controls section of Rich output per spec examples - Reverted auto profile description to "Fully automatic except apply" per specification (line 16703, line 28406) - Improved bridge comments in test steps with semantic context for threshold-to-gate mappings ISSUES CLOSED: #902	2026-03-30 13:18:07 +01:00
hamza.khyari	c97ec273a9	feat(lsp): add missing LspServerConfig model fields ... Add specification-required fields to LspServerConfig: - description: str (max_length=1000, default='') - transport: LspTransport enum (stdio/tcp/pipe, default=stdio) - initialization: dict[str, Any] (LSP initializationOptions, default={}) - workspace_settings: dict[str, Any] (workspace/didChangeConfiguration, default={}) All fields have defaults for backward compatibility with existing configs. LspTransport enum exported from lsp package. Tests: 17 Behave scenarios, 5 Robot integration tests. Existing LSP tests: 250/250 pass unchanged. ISSUES CLOSED: #835	2026-03-30 11:51:27 +00:00
freemo	9cace15d6e	test(e2e): workflow example 18 — container with remote repo clone (trusted profile) ... E2E test for Specification Workflow Example 18: Container with Remote Repo Clone using the trusted automation profile. Exercises the full container-instance workflow per the spec: - Registers a container-instance resource with --clone-into flag (new CLI flag added to resource add for REPO_URL:CONTAINER_PATH). - Two-step project creation: project create + project link-resource. - Dynamic LLM actor selection (Anthropic/OpenAI) matching available API keys. - Plan use with --execution-environment container, --execution-env-priority fallback, and --automation-profile trusted. - Full plan lifecycle: strategize, execute, diff, apply, status. - Positive assertions: non-empty output, plan ID presence, terminal state verification, container/clone evidence logging. - Negative assertions: Traceback and INTERNAL error checks. - ULID regex uses Crockford base32 character set. - Unique suffix for resource/project names (parallel CI safe). - Skip If No LLM Keys guard for graceful degradation. - CHANGELOG.md updated. ISSUES CLOSED: #764	2026-03-30 19:17:41 +08:00
hurui200320	b6c3169634	test(e2e): workflow example 16 — devcontainer-driven development (supervised profile) ... Implements E2E test for devcontainer-driven development workflow. Tests project setup with .devcontainer config, resource registration, and full plan lifecycle with supervised automation profile. Changes from Cycle 5 review: 1. Replaced custom WF16_ALLOW_XFAIL_SKIP escape hatch with the project standard tdd_expected_fail tag system. Test is now tagged [Tags] tdd_expected_fail tdd_bug tdd_bug_762 and the listener inverts failures in CI until devcontainer features are fully wired. 2. Added diagnostic WF16 Test Teardown keyword that captures plan status JSON on failure, mirroring the WF05 teardown pattern. 3. Added stderr checks to all Traceback/INTERNAL guard assertions so tracebacks appearing only in stderr are also detected. 4. Rebased branch onto latest master (e4c01492). 5. Documented timeout budget: added comment explaining theoretical worst-case (~46min) vs realistic execution under the 35min limit. 6. Added fail-fast warning in AC-3 check noting that AC-4, AC-5, and AC-6 are dependent on AC-3 and are likely to also fail. 7. Reordered plan apply arguments to --yes --format json <plan_id> for spec consistency. 8. Decomposed long ready_for_apply Evaluate expression into three intermediate booleans (is_apply_phase, is_execute_complete, is_already_applied) for readability. 9. Added shared_session.close() calls in resource_dag.robot before each final print() to ensure explicit session cleanup. 10. Cleaned up stale xfail/skip classification references in log messages. Changes from earlier cycles (3-4) retained in this commit: - Terminal state validation, AC output combination, JSON format flags, suite-level init, Force Tags, automation profile fallback, ULID regex IGNORECASE, AC-5 Evaluate decomposition, defensive re-check pattern. ISSUES CLOSED: #762	2026-03-30 18:45:10 +08:00
aditya	4e64544aae	feat(acms): projects with 10,000+ files index without timeout ... Add explicit indexing timeout bounds and propagate timeout_seconds through the repo indexing service, utility walker, and CLI entrypoint so large repositories fail predictably instead of hanging. Add 10K-scale Behave/Robot verification and a dedicated benchmark path to validate that large-project indexing completes, persists status correctly, and remains measurable for regressions. Address review feedback by splitting oversized Behave and Robot support files into focused modules, trimming repo_indexing_service.py back under the 500-line limit, and rebasing the branch onto current master. ISSUES CLOSED: #851 # Conflicts: # CHANGELOG.md # robot/helper_m5_e2e_verification.py	2026-03-30 10:18:19 +00:00
aditya	ef8f9640fa	feat(acms): context analysis produces meaningful summaries ... Add phase-wise context analysis summaries for strategize, execute, and apply, and integrate them into `agents project context inspect` and `agents project context simulate` with per-phase resource counts, size and token utilization, and narrowing diagnostics.\n\nAdd Behave and Robot coverage for empty, single-resource, multi-resource, and budget-constrained context analysis, and tighten the M5 smoke coverage after review feedback with exact summary assertions and a missing-path regression scenario for `agents context add`.\n\nISSUES CLOSED: #849	2026-03-30 08:42:48 +00:00
hurui200320	5ddc04bcc7	test(e2e): workflow example 17 — explicit container with directory mount (trusted profile) ... Implements E2E test for Specification WF17: Explicit Container with Directory Mount. The test exercises the full workflow from the spec: - Registers git-checkout resource and container-instance resource (with --image flag; --mount not yet available on CLI) - Creates project, links both resources via project link-resource - Sets execution environment to container via project context set - Uses --execution-env-priority override on plan use (per ADR-043) - Creates action with dynamically selected actor (Anthropic or OpenAI) - Runs full plan lifecycle: use → strategize → execute → diff → apply → status - Uses trusted automation profile for auto-execution of tool invocations Quality improvements over initial implementation: - Custom suite setup with workspace init (agents init --force --yes) - UUID-based unique suffix for resource/project names (CI parallelism) - Dynamic actor selection matching available API keys (M6 pattern) - Skip If No LLM Keys guard for graceful degradation - Crockford Base32 ULID regex ([0-9A-HJ-NP-Z]{26}) - Checked return codes on all git subprocess calls - INTERNAL error checks alongside Traceback checks - --format json on all CLI commands for deterministic output - Domain-specific assertions for plan output verification - Diff output non-empty assertion - Security note documenting trusted profile auto-execution decision - CHANGELOG entry added ISSUES CLOSED: #763	2026-03-30 08:05:41 +00:00