Files
HAL9000 460e99cb70
CI / lint (pull_request) Successful in 1m7s
CI / build (pull_request) Successful in 59s
CI / helm (pull_request) Successful in 45s
CI / quality (pull_request) Successful in 1m24s
CI / typecheck (pull_request) Successful in 1m35s
CI / security (pull_request) Successful in 1m37s
CI / benchmark-publish (pull_request) Has been skipped
CI / push-validation (pull_request) Successful in 40s
CI / integration_tests (pull_request) Successful in 3m17s
CI / benchmark-regression (pull_request) Failing after 1m16s
CI / e2e_tests (pull_request) Failing after 4m8s
CI / unit_tests (pull_request) Failing after 5m11s
CI / coverage (pull_request) Has been skipped
CI / docker (pull_request) Has been skipped
CI / status-check (pull_request) Failing after 3s
fix(data-integrity): remove silent argument swap in ValidationAttachmentRepository.attach
Fixes a critical data integrity bug where validation_name and resource_id
arguments were being silently swapped based on a fragile heuristic when
resource_id contained '/'. This caused silent data corruption without any
error being raised.

The 3-line conditional swap block has been removed from
ValidationAttachmentRepository.attach(), ensuring arguments flow directly
from caller to the persistence layer in the correct order.

A comprehensive BDD test suite (11 scenarios) verifies:
- Arguments are preserved in correct order across all boundary conditions
- Slash-containing IDs and namespacing work correctly
- Optional parameters (project_name, plan_id, mode, args) work properly
- Duplicate rejection works as expected (#7492)

ISSUES CLOSED: #7492
2026-05-08 06:25:19 +00:00
..