cleveragents/cleveragents-core

Fork 3

TDD: SlashCommandOverlay missing keyboard navigation (up/down/Enter/Tab/Escape) #10442

New issue

Closed

opened 2026-04-18 09:38:57 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-18 09:38:57 +00:00

Owner

Summary

TDD counterpart: SlashCommandOverlay must support keyboard navigation.

Tests to Write

def test_slash_overlay_has_keyboard_navigation():
    from cleveragents.tui.widgets.slash_command_overlay import SlashCommandOverlay
    overlay = SlashCommandOverlay()
    assert hasattr(overlay, "navigate_up"), "Must have navigate_up"
    assert hasattr(overlay, "navigate_down"), "Must have navigate_down"
    assert hasattr(overlay, "select_current"), "Must have select_current (Enter)"
    assert hasattr(overlay, "dismiss"), "Must have dismiss (Escape)"

def test_slash_overlay_navigation_changes_selection():
    from cleveragents.tui.widgets.slash_command_overlay import SlashCommandOverlay
    from cleveragents.tui.slash_catalog import slash_command_specs
    overlay = SlashCommandOverlay()
    overlay.set_commands("", slash_command_specs())
    initial_index = overlay.selected_index
    overlay.navigate_down()
    assert overlay.selected_index == initial_index + 1

Subtasks

Write failing BDD scenarios for keyboard navigation
Verify tests fail with current implementation
Implement navigation
Verify tests pass

Definition of Done

BDD scenarios exist and pass
All navigation keys work

Automated by CleverAgents Bot
Supervisor: UAT Test Pool | Agent: uat-test-pool-supervisor

## Summary TDD counterpart: `SlashCommandOverlay` must support keyboard navigation. ## Tests to Write ```python def test_slash_overlay_has_keyboard_navigation(): from cleveragents.tui.widgets.slash_command_overlay import SlashCommandOverlay overlay = SlashCommandOverlay() assert hasattr(overlay, "navigate_up"), "Must have navigate_up" assert hasattr(overlay, "navigate_down"), "Must have navigate_down" assert hasattr(overlay, "select_current"), "Must have select_current (Enter)" assert hasattr(overlay, "dismiss"), "Must have dismiss (Escape)" def test_slash_overlay_navigation_changes_selection(): from cleveragents.tui.widgets.slash_command_overlay import SlashCommandOverlay from cleveragents.tui.slash_catalog import slash_command_specs overlay = SlashCommandOverlay() overlay.set_commands("", slash_command_specs()) initial_index = overlay.selected_index overlay.navigate_down() assert overlay.selected_index == initial_index + 1 ``` ## Subtasks - [x] Write failing BDD scenarios for keyboard navigation - [x] Verify tests fail with current implementation - [x] Implement navigation - [x] Verify tests pass ## Definition of Done - [x] BDD scenarios exist and pass - [x] All navigation keys work --- **Automated by CleverAgents Bot** Supervisor: UAT Test Pool | Agent: uat-test-pool-supervisor

HAL9000 added the

labels

2026-04-18 09:41:40 +00:00

HAL9000 referenced this issue from a commit

2026-04-19 09:42:30 +00:00

test(tui): add BDD keyboard navigation for SlashCommandOverlay (#10442)

HAL9000 referenced this issue from a pull request that will close it,

2026-04-19 10:07:48 +00:00

test(tui): add BDD keyboard navigation for SlashCommandOverlay (#10442) #10741

HAL9000 added

and removed

labels

2026-04-19 10:13:36 +00:00

HAL9000 commented

2026-04-19 10:13:37 +00:00

Author

Owner

Implementation Attempt — Tier 1: haiku — Success

Implemented keyboard navigation for SlashCommandOverlay (#10442).

Changes made:

Added navigate_up(): moves selection up, clamped to index 0
Added navigate_down(): moves selection down, clamped to last command
Added select_current(): returns the currently highlighted SlashCommandSpec
Added dismiss(): clears overlay and resets state (Escape key action)
Added selected_index attribute to track current highlighted position
Updated set_commands() to store filtered commands and reset selected_index
Added BDD feature file with 10 scenarios covering all navigation cases

Quality gates:

lint: all checks passed
typecheck: 0 errors
unit_tests: 10 scenarios passed, 0 failed

PR: #10741

Automated by CleverAgents Bot
Supervisor: Implementation Pool | Agent: implementation-worker

**Implementation Attempt** — Tier 1: haiku — Success Implemented keyboard navigation for `SlashCommandOverlay` (#10442). **Changes made:** - Added `navigate_up()`: moves selection up, clamped to index 0 - Added `navigate_down()`: moves selection down, clamped to last command - Added `select_current()`: returns the currently highlighted `SlashCommandSpec` - Added `dismiss()`: clears overlay and resets state (Escape key action) - Added `selected_index` attribute to track current highlighted position - Updated `set_commands()` to store filtered commands and reset `selected_index` - Added BDD feature file with 10 scenarios covering all navigation cases **Quality gates:** - lint: all checks passed - typecheck: 0 errors - unit_tests: 10 scenarios passed, 0 failed **PR:** https://git.cleverthis.com/cleveragents/cleveragents-core/pulls/10741 --- **Automated by CleverAgents Bot** Supervisor: Implementation Pool | Agent: implementation-worker

HAL9000 referenced this issue from a commit

2026-04-23 15:43:09 +00:00

test(tui): add BDD keyboard navigation for SlashCommandOverlay (#10442)

HAL9000 referenced this issue from a commit

2026-04-23 18:29:12 +00:00

test(tui): add BDD keyboard navigation for SlashCommandOverlay (#10442)

HAL9000 referenced this issue from a commit

2026-04-23 22:28:00 +00:00

chore(ci): trigger CI re-run for stale CI failures

HAL9000 closed this issue

2026-04-23 22:42:25 +00:00