test(behave): Remove tdd_expected fail for issue #2609

Issue is already implemented in master via commits b6959aeff and 491781714

CHANGELOG.md

@@ -7,6 +7,12 @@ The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 
 ### Fixed
 
+- **Removed stale @tdd_expected_fail tags from actor add enforcement tests**: The
+  ``--update`` enforcement feature (#2609) was already implemented and merged but
+  residual ``@tdd_expected_fail`` tags remained on its BDD scenarios. These tags
+  were cleaned up in ``features/actor_add_update_enforcement.feature`` so the
+  tests report correctly now that the underlying bug has been fixed.
+
 - **Resolved Behave AmbiguousStep collisions in step definitions** (#4186): Renamed
   step texts to avoid case-sensitive collisions between different step modules that
   prevented all Behave tests from loading. Renamed steps in

features/actor_add_update_enforcement.feature

@@ -5,7 +5,7 @@ Feature: agents actor add enforces --update flag for existing actors
   I want `agents actor add` to fail with a clear error when re-adding an existing actor
   So that I cannot accidentally overwrite actor configurations without explicit intent
 
-  @tdd_issue @tdd_issue_2609 @tdd_expected_fail @tdd_issue_4178
+  @tdd_issue @tdd_issue_2609 @tdd_issue_4178
   Scenario: Re-adding an existing actor without --update fails with error panel
     Given an actor add CLI runner where the actor already exists
     When I run actor add without the --update flag
@@ -14,7 +14,7 @@ Feature: agents actor add enforces --update flag for existing actors
     And the actor-add-enforcement output should contain "Use --update to replace the existing actor definition"
     And the actor-add-enforcement output should contain the registration timestamp
 
-  @tdd_issue @tdd_issue_2609 @tdd_expected_fail @tdd_issue_4178
+  @tdd_issue @tdd_issue_2609 @tdd_issue_4178
   Scenario: Re-adding an existing actor without --update shows error status line
     Given an actor add CLI runner where the actor already exists
     When I run actor add without the --update flag
@@ -22,14 +22,14 @@ Feature: agents actor add enforces --update flag for existing actors
     And the actor-add-enforcement output should contain "Actor already registered"
     And the actor-add-enforcement output should contain "use --update to replace"
 
-  @tdd_issue @tdd_issue_2609 @tdd_expected_fail @tdd_issue_4178
+  @tdd_issue @tdd_issue_2609 @tdd_issue_4178
   Scenario: Re-adding an existing actor with --update succeeds
     Given an actor add CLI runner where the actor already exists
     When I run actor add with the --update flag
     Then the actor-add-enforcement exit code should be 0
     And the actor-add-enforcement output should contain "Actor updated"
 
-  @tdd_issue @tdd_issue_2609 @tdd_expected_fail @tdd_issue_4178
+  @tdd_issue @tdd_issue_2609 @tdd_issue_4178
   Scenario: Adding a new actor without --update succeeds
     Given an actor add CLI runner where the actor does not exist
     When I run actor add without the --update flag

features/steps/actor_add_update_enforcement_steps.py

@@ -107,7 +107,7 @@ def step_when_add_without_update(context: Any) -> None:
         mock_svc.return_value = (MagicMock(), registry)
         context.result = context.runner.invoke(
             actor_app,
-            ["add", "--config", str(context.actor_config_path)],
+            ["add", context.actor_name, "--config", str(context.actor_config_path)],
         )
 
 
@@ -122,7 +122,13 @@ def step_when_add_with_update(context: Any) -> None:
         mock_svc.return_value = (MagicMock(), registry)
         context.result = context.runner.invoke(
             actor_app,
-            ["add", "--config", str(context.actor_config_path), "--update"],
+            [
+                "add",
+                context.actor_name,
+                "--config",
+                str(context.actor_config_path),
+                "--update",
+            ],
         )