2648 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
HAL9000	f8946e1147	test(cli): assert container-instance stop mock invocation ... Extend the devcontainer cleanup Behave scenario for container-instance resources to assert that the stop command delegates to the lifecycle stop mock, providing regression coverage that both container-instance and devcontainer-instance remain stoppable. ISSUES CLOSED: #6457	2026-05-31 19:27:43 -04:00
HAL9000	d785397da4	fix(cli): fix JSON/YAML envelope messages[].text to show actual content (#6457)	2026-05-31 19:27:43 -04:00
HAL9000	5543e66b62	Merge pull request 'fix(cli): add --url flag to resource add for git resource type' (#6621) from fix/issue-6322-resource-add-url-flag into master	2026-05-31 22:59:24 +00:00
HAL9000	fcc780bf1b	fix(cli): align --url validation error message with test expectations ... The Behave test expected the error message to contain '--url is only valid for git resources' but the code was producing '--url only for git resources'. Updated the validation error message to match the test assertion. Also updated the Robot Framework integration test to expect the corrected message, ensuring consistency across both test suites. Fixes the failing Behave scenario: 'Using --url with a non-git resource type is rejected' by correcting the error message text output from the CLI. ISSUES CLOSED: #6322	2026-05-31 17:10:35 -04:00
HAL9000	ca55d565b6	test: add Robot Framework integration test for --url flag	2026-05-31 15:39:36 -04:00
HAL9000	d95873b446	docs: update CHANGELOG for --url flag support	2026-05-31 15:39:36 -04:00
HAL9000	e43305198d	fix: apply ruff formatting	2026-05-31 15:39:36 -04:00
HAL9000	60b728c385	fix: shorten error message to pass lint	2026-05-31 15:39:36 -04:00
HAL9000	b598a70c41	fix(cli): resolve lint errors in resource.py ... - Break line 702 to fit 88-character limit - Remove double blank line between validation blocks - Improves error message clarity by naming 'git' type explicitly	2026-05-31 15:39:36 -04:00
HAL9000	9dcb446641	fix(cli): add --url flag to resource add for git resource type (#6322) ... Ensure git resources accept a remote URL flag and persist the value via CLI validation and properties. ISSUES CLOSED: #6322	2026-05-31 15:39:36 -04:00
HAL9000	2769d13c8e	Merge pull request 'fix(cli): fix plan explain to accept decision_id argument' (#6618) from fix/issue-6325-plan-explain-decision-id into master	2026-05-31 19:26:45 +00:00
HAL9000	4d04b2e4ad	test(tdd): restore tdd_plan_explain_plan_id regression tests for fixed behaviour ... The TDD regression files for bug #968 were incorrectly deleted instead of updated to assert the spec-compliant fixed behaviour from issue #6325. Per CONTRIBUTING.md the regression guard must be kept and updated — not removed — once the bug is fixed. Restore and update all three files to assert the new expected behaviour: - plan explain rejects a non-decision-id argument with rc=1 - error output contains "not found" - decision data fields are absent from output Also pair the orphaned robot/helper_tdd_plan_explain_plan_id.py with a restored robot test file and update it to verify rc=1 rejection behaviour. ISSUES CLOSED: #6325	2026-05-31 15:00:33 -04:00
HAL9000	a117445f6d	fix(cli): fix lint and unit test failures in plan explain error path ... - Shorten error message in explain_decision_cmd to fit 88-char limit (E501) - Add `from None` to raise typer.Exit(1) inside except block (B904) - Fix step definition mock to raise DecisionNotFoundError instead of returning None, so the exception handler fires and output contains "not found" as the scenario asserts ISSUES CLOSED: #6325	2026-05-31 15:00:33 -04:00
HAL9000	c16d90058d	fix(cli): only accept decision_id in plan explain (Closes #6325)	2026-05-31 15:00:33 -04:00
HAL9000	289b2cea10	Merge pull request 'Fix resource removal guard to respect linked children' (#7004) from fix/resource-removal-children-check-6886 into master	2026-05-31 18:52:40 +00:00
HAL9000	e884dce240	Add CHANGELOG entry for resource removal guard fix (bug #6886) ... The PR was missing the required changelog documentation under [Unreleased] ### Fixed Signed-off-by: CleverThis <hal9000@cleverthis.com>	2026-05-31 13:33:31 -04:00
HAL9000	9b0cf52a4e	Merge pull request 'fix(cli): fix automation-profile add JSON/YAML output format' (#6598) from fix/issue-6345-automation-profile-add-output into master	2026-05-31 17:29:07 +00:00
HAL9000	5eafb6911a	fix(cli): fix --update title and guards display in automation-profile add ... - When `--update` is passed but the profile does not exist, use title "Profile Added" instead of "Profile Registered" so the Behave step asserting "Profile Added" in output passes. - Add guards panel rendering in `_render_profile_add_rich` so that profiles with guards config display Guard fields (max_tool_calls_per_step, tool_allowlist, tool_denylist, etc.) in rich add output. ISSUES CLOSED: #6345	2026-05-31 11:52:57 -04:00
HAL9000	64298f901a	fix(cli): fix automation-profile add JSON/YAML output format (#6345) ... Align the automation-profile add command's machine-readable output with the specification by emitting the flat thresholds/flags schema and created timestamp, and add coverage that locks the expected structure. ISSUES CLOSED: #6345	2026-05-31 10:55:18 -04:00
HAL9000	422fa4d587	Merge pull request 'docs: document 2026-04-06 to 2026-04-08 agent system improvements' (#4830) from docs/2026-04-08-unreleased-changelog into master	2026-05-31 14:14:23 +00:00
HAL9000	518c40be21	docs: document 2026-04-06 to 2026-04-08 improvements ... - add changelog entries summarizing watchdog supervision and documentation updates\n- add ci-log-fetcher module guide detailing interface contract and usage\n- refresh system-watchdog doc with CI-blocker escalation and struggling PR detection\n- normalize coverage threshold robot test by dropping temporary tdd_expected_fail tags\n\nISSUES CLOSED: #7987	2026-05-31 09:38:17 -04:00
HAL9000	b03ec60f06	Merge pull request 'docs: architecture — clarify TUI session export formats and persona schema fields' (#4979) from spec/tui-clarifications-session-export-persona into master	2026-05-31 13:37:36 +00:00
freemo	1fd4918be8	docs(spec): clarify TUI session export formats and persona schema fields ... Accept implementation extensions as spec updates based on UAT findings: 1. `/session:export` now officially supports three formats: - `json` (default, canonical, importable) - `md` (Markdown transcript, lossy) - `txt` (plain-text transcript, lossy) Updated ADR-046 command table and spec Conversation Export section. 2. Persona data model now includes two optional display fields: - `icon`: emoji or single character for tab labels and lists - `greeting`: message shown when persona is activated Updated ADR-045 data model YAML example and Decision section. These changes accept positive implementation extensions discovered by UAT testing (issues #4871, #4858) rather than reverting them. Refs: #4940	2026-05-31 08:35:06 -04:00
HAL9000	e2c12b2120	Merge pull request 'docs: add showcase example for tool and validation management' (#4212) from docs/add-example-tool-and-validation-management into master	2026-05-30 21:47:57 +00:00
HAL9000	bc64074036	docs: add tool and validation management showcase ... - document the CLI workflow for registering tools, wrapping validations, and querying registry metadata - index the new example in docs/showcase/examples.json - re-enable coverage threshold regression checks by removing obsolete tdd_expected_fail tags ISSUES CLOSED: #4565 Refs: #4305 Refs: #4227	2026-05-30 17:21:55 -04:00
freemo	e201aa07c9	fix(resource): add overlay to ResourceTypeConfigSchema._VALID_STRATEGIES ... Implemented test coverage and documentation updates to ensure overlay is properly recognized and communicated across the sandbox strategy validation surface. - Verification: Confirmed that overlay already exists in the _VALID_STRATEGIES frozenset within src/cleveragents/resource/schema.py (introduced in a prior commit that closed issue #2827). - Comprehensive audit: Audited strategy validation points to ensure consistency: - _VALID_STRATEGIES in schema.py - _IMPLEMENTED_STRATEGIES and _SUPPORTED_STRATEGIES in factory.py - SandboxStrategy enum definitions in both resource.py and resource_type.py All include overlay as an allowed strategy. - Tests: Added a new BDD scenario titled: "Invalid sandbox_strategy error message lists overlay as allowed" to features/consolidated_resource.feature. This asserts that validation errors explicitly list overlay among the allowed values when an invalid strategy is used. - Documentation: Updated docstring in src/cleveragents/infrastructure/sandbox/strategy_registry.py to reflect that the built-in SandboxFactory handles six strategies, including snapshot and overlay. - Design considerations: The fix itself was already applied in a previous commit (dbf3b8d7) addressing #2827. Issue #3614, raised by the UAT bot, required additional test coverage and accurate documentation of the available strategies. - Impact: No behavioral changes beyond ensuring test coverage and documentation are aligned with the existing implementation. The added test guarantees that error messages remain accurate and comprehensive as strategies evolve. - Affected areas: resource/schema.py, factory.py, resource.py, resource_type.py, features/consolidated_resource.feature, strategy_registry.py. ISSUES CLOSED: #3614	2026-05-30 16:14:46 -04:00
HAL9000	2506b4925c	Merge pull request 'fix(resources): remove unsupported executable resource type' (#3248) from fix/remove-executable-resource-type into master	2026-05-30 20:11:56 +00:00
HAL9000	b8eab7c032	fix(resources): delete executable.yaml, fix resource list columns, update docs ... - Delete examples/resource-types/executable.yaml (orphaned artifact referencing non-existent ExecutableHandler; flagged in 4 prior reviews as blocking) - Update agents resource list CLI columns from [ID, Name, Type, Status, Kind, Location, Description] to spec-required [Name, ID, Type, Phys/Virt, Children, Projects] per specification line 11051 - Lifecycle state for container resources now shown as a note below the table - Update resource_list_lifecycle_state.feature to remove Status column header assertions; add spec-column header scenario - Add BDD scenario in resource_cli.feature verifying new column headers - Update CHANGELOG.md and CONTRIBUTORS.md ISSUES CLOSED: #3077	2026-05-30 15:43:56 -04:00
freemo	497c78219a	fix(resources): remove unsupported executable resource type ... The executable resource type was not defined in the specification (docs/specification.md lines 10567-10575). The supported resource types are: git-checkout, git, fs-mount, fs-directory, fs-file, container-instance, and devcontainer-instance. Additionally, the agents resource list output included a Location column that is not part of the spec-defined columns (Name, ID, Type, Phys/Virt, Children, Projects per line 11051). Changes: - Remove executable type registration from _resource_registry_lsp.py - Remove executable from BUILTIN_TYPE_NAMES in _resource_type_validation.py - Update resource list table columns to match spec (Name, ID, Type, Phys/Virt, Children, Projects) removing Location and Description - Remove all executable-related test scenarios from features/resource_type_lsp.feature - Update robot/helper_resource_type_lsp.py to reflect 3 LSP types (not 4) and add assertions that executable is absent ISSUES CLOSED: #3077	2026-05-30 15:43:56 -04:00
HAL9000	a8cca4e02a	Merge pull request 'fix(cli): add spec-required 'Profile Removed' panel to agents automation-profile remove rich output' (#3293) from fix/automation-profile-remove-rich-output-panel into master	2026-05-30 18:35:41 +00:00
freemo	c59a76cdb7	fix(cli): add spec-required 'Profile Removed' panel to agents automation-profile remove rich output ... The automation-profile remove command was only printing a plain checkmark message after deletion. The spec requires a Rich Panel titled 'Profile Removed' containing the profile name, followed by the success message. Changes: - Replace plain console.print checkmark with Panel render + success message - Panel displays 'Name: <profile-name>' under 'Profile Removed' title - Success message updated to '✓ OK Profile removed' per spec - Behave feature: add panel assertions to existing remove scenario - Behave feature: add new 'Remove custom profile shows Profile Removed panel' scenario - Robot Framework helper: update test_remove_profile() to assert panel presence ISSUES CLOSED: #2966	2026-05-30 13:59:48 -04:00
HAL9000	9fff09b4fb	Merge pull request 'fix(resource): implement missing container handler module for container infrastructure resource types' (#3245) from fix/container-handler-module-missing into master	2026-05-30 17:38:41 +00:00
HAL9000	62c11edb4a	fix(resource): add create_sandbox/project_access stubs and fix ambiguous step ... - Add create_sandbox() override to _ContainerBaseHandler raising NotImplementedError, matching CloudResourceHandler pattern (issue #836) - Add project_access() override to _ContainerBaseHandler raising NotImplementedError, consistent with all other stub methods - Rename @then("the import should succeed without errors") step to @then("the container handler module import should succeed without errors") to resolve AmbiguousStep collision with tdd_a2a_sdk_dependency_steps.py - Update container_handler.feature to use renamed step - Apply ruff format to container.py ISSUES CLOSED: #2907	2026-05-30 13:08:44 -04:00
freemo	4288fcb9c1	fix(resource): implement missing container handler module for container infrastructure resource types ... Implements the missing cleveragents.resource.handlers.container module that is referenced by all seven container infrastructure resource types registered in _resource_registry_container.py. Previously, any attempt to use container-runtime, container-image, container-mount, container-exec-env, container-port, container-volume, or container-network resources raised HandlerResolutionError with ModuleNotFoundError at runtime. Changes: - Add src/cleveragents/resource/handlers/container.py with five handler classes: ContainerRuntimeHandler, ContainerImageHandler, ContainerChildHandler (shared by mount/exec-env/port), ContainerVolumeHandler, ContainerNetworkHandler - All handlers extend _ContainerBaseHandler which extends BaseResourceHandler and satisfies the ResourceHandler protocol - resolve() raises NotImplementedError (container sandbox provisioning is pending, mirrors CloudResourceHandler pattern) - content_hash() returns identity hash based on resource type + location - All CRUD and lifecycle stubs raise NotImplementedError - Update handlers/__init__.py to export the five new handler classes - Add features/container_handler.feature with 72 BDD scenarios covering module importability, protocol conformance, handler resolution, type labels, CRUD stubs, lifecycle stubs, and registry integration - Add features/steps/container_handler_steps.py with step definitions All nox sessions pass: lint, typecheck, unit_tests (72/72 scenarios). ISSUES CLOSED: #2907	2026-05-30 13:08:44 -04:00
HAL9000	9f440625ab	Merge pull request 'fix(cli): fix format_output() to use rich and color renderers instead of JSON fallback' (#3227) from fix/format-output-rich-color-renderers into master	2026-05-30 17:06:22 +00:00
HAL9000	d0fd9319d3	fix(tests): add BDD scenarios for rich/color formats with list data to restore coverage ... Cover the list branches in _format_rich() and _format_color() that were left untested, causing the coverage gate to drop below the 97% threshold. Add two new @when steps (list+rich, list+color), two @then steps for list panel assertions, and two new feature scenarios exercising those paths. ISSUES CLOSED: #2921	2026-05-30 11:45:16 -04:00
HAL9000	353451263e	fix(tests): remove @tdd_expected_fail from format_output dict scenario ... Issue #4364 is now resolved by the envelope pattern introduced on master. The scenario "Format output handles all format types for dict" passes correctly — the TDD inversion was flipping it to a failure. ISSUES CLOSED: #4364	2026-05-30 11:09:06 -04:00
HAL9000	a726b96d26	fix(cli): address reviewer feedback on format_output rich/color fix ... - Move function-level imports to module top level in formatting.py: * Remove redundant OutputSession import inside _format_rich() * Remove redundant OutputSession import inside _format_color() * Move `import sys` from inside format_output() to module level - Fix robot/helper_cli_formats.py: * Remove redundant `import json as _json` inside format_output_rich(); use the top-level `json` module directly * Replace non-deterministic datetime.now() calls in _mock_action() and _mock_plan() with fixed datetime(2025, 1, 15, 10, 0, 0) - Split cli_output_formats_steps.py to comply with 500-line limit: * Extract all @then step definitions into new file features/steps/cli_output_format_validation_steps.py * Behave auto-discovers steps from any .py file in steps/ ISSUES CLOSED: #2921	2026-05-30 11:09:06 -04:00
freemo	6e47abbd63	fix(cli): fix format_output() to use rich and color renderers instead of JSON fallback ... The format_output() function in src/cleveragents/cli/formatting.py had two routing bugs that caused incorrect output for the 'rich' and 'color' formats: 1. The 'rich' format had no explicit dispatch branch and silently fell through to the final JSON fallback, returning raw JSON instead of styled terminal output. Since 'rich' is the default CLI format (per ADR-021), this meant all commands using format_output() (version, info, diagnostics) produced JSON by default. 2. The 'color' format was incorrectly routed to _format_plain() instead of a color-aware renderer, producing plain text with no ANSI color codes. Fix: - Added _format_rich() helper that delegates to RichMaterializer via OutputSession, producing ANSI-styled terminal output consistent with format_output_session(). - Added _format_color() helper that delegates to ColorMaterializer via OutputSession, producing ANSI-colored terminal output. - Added explicit OutputFormat.RICH dispatch in format_output() routing. - Fixed OutputFormat.COLOR dispatch to use _format_color() instead of _format_plain(). Tests: - Updated existing BDD scenario that was validating the buggy behavior (expected JSON for rich format) to now assert correct styled output. - Added new BDD scenarios: 'rich format produces styled terminal output not JSON' and 'color format produces ANSI-colored output not plain text'. - Added Robot Framework integration tests in cli_formats.robot and helper_cli_formats.py verifying end-to-end styled output for both formats. All nox sessions pass: lint, typecheck, unit_tests, security_scan. ISSUES CLOSED: #2921	2026-05-30 11:09:06 -04:00
HAL9000	9b70b11992	Merge pull request 'fix(database): replace type: ignore with assert for type narrowing in LegacyDataMigrator' (#3241) from fix/type-safety-legacy-migrator-type-ignore into master	2026-05-30 15:02:32 +00:00
HAL9000	1970fae07b	style: apply ruff format to legacy_migrator_steps.py ... Fix formatting to satisfy ruff format --check CI gate.	2026-05-30 10:38:39 -04:00
freemo	1d18aa80ca	fix(database): replace type: ignore with assert for type narrowing in LegacyDataMigrator ... Remove the unsafe `# type: ignore` suppression on line 111 of `legacy_migrator.py` and replace it with an explicit `assert existing_plan.id is not None` statement. This provides proper type narrowing to the type checker while preserving the logical correctness guaranteed by the preceding `if existing_plan:` guard. Also adds a new BDD scenario in `legacy_migrator_coverage.feature` that explicitly exercises the code path where an existing plan with a non-None id is found during migration, verifying the assert-based type narrowing works correctly end-to-end. ISSUES CLOSED: #3051	2026-05-30 10:38:39 -04:00
HAL9000	1b6dc2796d	Merge pull request 'docs: update specification — fix SSE streaming event example method name' (#2557) from spec/update-sse-streaming-event-example into master	2026-05-30 14:01:26 +00:00
HAL9000	fc0366d05a	fix(docs): correct SDK link from a2aprojects to a2aproject ... The SDK URL was incorrectly changed to a2aprojects/a2a-python (404 broken link). Revert to the correct a2aproject/a2a-python which is the official A2A Python SDK org. Fixes blocker from PR review.	2026-05-30 09:33:19 -04:00
freemo	9b64297eff	docs(a2a): fix SSE streaming event example method name ... Corrects the Example Streaming Event in docs/reference/a2a.md to use the correct JSON-RPC 2.0 notification method name `task/statusUpdate` instead of the incorrect `message/stream`. `message/stream` is the client→server REQUEST method that initiates streaming. The actual SSE data payloads are JSON-RPC 2.0 notifications (no `id` field) with method names `task/statusUpdate` or `task/artifactUpdate`, as implemented in SseEventFormatter. Closes #2519	2026-05-30 09:33:19 -04:00
HAL9000	3831632391	Merge pull request 'fix(acms): align SkeletonCompressorService.compress() with SkeletonCompressor protocol' (#3057) from fix/acms-skeleton-compressor-signature into master	2026-05-30 13:08:55 +00:00
freemo	f2232eec09	fix(acms): align SkeletonCompressorService.compress() with SkeletonCompressor protocol ... - Updated SkeletonCompressorService.compress() to accept (fragments: tuple[ContextFragment, ...], skeleton_budget: int) -> tuple[ContextFragment, ...], matching the SkeletonCompressor protocol - Removed skeleton_ratio and CompressionResult from the public API - Added @runtime_checkable to SkeletonCompressor protocol in acms_service.py - Added structural subtype assertion at module level to prevent future protocol drift - Rewrote all Behave feature scenarios and step definitions to use skeleton_budget - Updated benchmarks and robot helpers to use absolute token budgets - Removed CompressionResult export from services __init__.py and vulture_whitelist.py - The depth_breadth_projection.py call site already correctly computed and passed skeleton_budget ISSUES CLOSED: #2925	2026-05-30 08:29:22 -04:00
HAL9000	08eb69b71b	Merge pull request 'fix(cli): handle skill: wrapper key in agents skill add YAML config #1472' (#1506) from fix/skill-add-yaml-wrapper-key into master	2026-05-30 08:32:21 +00:00
controller-ci-rerun	c008804f05	chore: re-trigger CI [controller]	2026-05-30 04:04:21 -04:00
HAL9000	e21fc197d3	fix(skills): fix robot integration test YAML creation for skill: wrapper key test	2026-05-30 04:04:21 -04:00