UAT: TUI `Persona` schema has undocumented `icon` and `greeting` fields not defined in spec ADR-045 #4858

New issue

Open

opened 2026-04-08 20:09:55 +00:00 by HAL9000 · 0 comments

HAL9000 commented

2026-04-08 20:09:55 +00:00

Owner

Bug Report

Feature Area: TUI Interface — Persona System (ADR-045)

What Was Tested

Persona datamodel in src/cleveragents/tui/persona/schema.py

Expected Behavior (from spec ADR-045)

The spec ADR-045 defines the Persona data model with these fields:

name: str
description: str
actor: str
color: str | None
base_arguments: dict
scoped_projects: list[str]
scoped_plans: list[str]
argument_presets: list[PersonaPreset]
cycle_order: int

Actual Behavior

The Persona Pydantic model in schema.py has two additional fields not in the spec:

icon: str = Field(default="")
greeting: str = Field(default="")

These fields:

Are not documented in ADR-045
Are not part of the YAML format example in the spec
Have no defined behavior or usage in the codebase
Will be serialized to YAML when personas are saved, creating spec-divergent files

Code Location

src/cleveragents/tui/persona/schema.py — Persona class, lines with icon and greeting fields

Impact

Persona YAML files will contain undocumented fields (icon, greeting)
These fields may cause confusion when users inspect their persona files
If the spec is later updated to define these fields differently, there may be conflicts

This is a minor spec deviation — the extra fields don't break functionality but represent undocumented behavior that should either be added to the spec or removed from the implementation.

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report **Feature Area:** TUI Interface — Persona System (ADR-045) ### What Was Tested `Persona` datamodel in `src/cleveragents/tui/persona/schema.py` ### Expected Behavior (from spec ADR-045) The spec ADR-045 defines the Persona data model with these fields: ```yaml name: str description: str actor: str color: str | None base_arguments: dict scoped_projects: list[str] scoped_plans: list[str] argument_presets: list[PersonaPreset] cycle_order: int ``` ### Actual Behavior The `Persona` Pydantic model in `schema.py` has two additional fields not in the spec: ```python icon: str = Field(default="") greeting: str = Field(default="") ``` These fields: 1. Are not documented in ADR-045 2. Are not part of the YAML format example in the spec 3. Have no defined behavior or usage in the codebase 4. Will be serialized to YAML when personas are saved, creating spec-divergent files ### Code Location `src/cleveragents/tui/persona/schema.py` — `Persona` class, lines with `icon` and `greeting` fields ### Impact - Persona YAML files will contain undocumented fields (`icon`, `greeting`) - These fields may cause confusion when users inspect their persona files - If the spec is later updated to define these fields differently, there may be conflicts This is a minor spec deviation — the extra fields don't break functionality but represent undocumented behavior that should either be added to the spec or removed from the implementation. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

Rows
Columns

UAT: TUI Persona schema has undocumented icon and greeting fields not defined in spec ADR-045 #4858