cleveragents/cleveragents-core

Fork 3

BUG-HUNT: [type-safety] Unsafe `type: ignore` in LegacyDataMigrator #3051

New issue

Closed

opened 2026-04-05 04:18:13 +00:00 by freemo · 3 comments

freemo commented

2026-04-05 04:18:13 +00:00

Owner

Metadata

Branch: fix/type-safety-legacy-migrator-type-ignore
Commit Message: fix(database): replace type: ignore with assert for type narrowing in LegacyDataMigrator
Milestone: v3.6.0
Parent Epic: #400

Bug Report: [type-safety] — Unsafe `type: ignore` in LegacyDataMigrator

Severity Assessment

Impact: Reduced code clarity and maintainability.
Likelihood: High. This is a code quality issue that is present in the current codebase.
Priority: Low

Location

File: src/cleveragents/infrastructure/database/legacy_migrator.py
Function/Class: LegacyDataMigrator.migrate_project_data
Lines: 111

Description

The migrate_project_data method uses # type: ignore to suppress a potential type error. While the code is logically correct due to the preceding if existing_plan: check, the use of type: ignore is a code smell and should be avoided in favor of more explicit type narrowing. Per project standards, # type: ignore is strictly forbidden.

Evidence

                        if existing_plan:
                            plan_id_map[plan_name] = existing_plan.id  # type: ignore
                            continue

Expected Behavior

The code should be written in a way that does not require type: ignore. An assert statement should be used to provide explicit type narrowing to the type checker.

Actual Behavior

type: ignore is used to suppress a type error, violating the project's no-type-ignore policy.

Suggested Fix

Use an assert statement to provide a type hint to the type checker:

                        if existing_plan:
                            assert existing_plan.id is not None
                            plan_id_map[plan_name] = existing_plan.id
                            continue

Subtasks

Remove the # type: ignore comment from line 111 of src/cleveragents/infrastructure/database/legacy_migrator.py
Add assert existing_plan.id is not None before the assignment to provide explicit type narrowing
Verify no other # type: ignore suppressions exist in legacy_migrator.py
Add / update BDD unit-test scenario in features/ covering the migrate_project_data method with a plan that has a non-None id
Verify nox -e typecheck passes with no new errors
Verify nox -e unit_tests passes
Verify nox -e coverage_report reports coverage ≥ 97%

Definition of Done

# type: ignore removed from LegacyDataMigrator.migrate_project_data in legacy_migrator.py
Explicit assert existing_plan.id is not None type narrowing added in its place
No new # type: ignore suppressions introduced anywhere
BDD scenario(s) added/updated in features/ covering the corrected code path
All nox stages pass (lint, typecheck, unit_tests, integration_tests, coverage_report)
Coverage >= 97%
PR merged to the correct branch with the commit message above, closing this issue

Automated by CleverAgents Bot
Supervisor: Bug Hunting | Agent: ca-new-issue-creator

## Metadata - **Branch**: `fix/type-safety-legacy-migrator-type-ignore` - **Commit Message**: `fix(database): replace type: ignore with assert for type narrowing in LegacyDataMigrator` - **Milestone**: v3.6.0 - **Parent Epic**: #400 ## Bug Report: [type-safety] — Unsafe `type: ignore` in LegacyDataMigrator ### Severity Assessment - **Impact**: Reduced code clarity and maintainability. - **Likelihood**: High. This is a code quality issue that is present in the current codebase. - **Priority**: Low ### Location - **File**: `src/cleveragents/infrastructure/database/legacy_migrator.py` - **Function/Class**: `LegacyDataMigrator.migrate_project_data` - **Lines**: 111 ### Description The `migrate_project_data` method uses `# type: ignore` to suppress a potential type error. While the code is logically correct due to the preceding `if existing_plan:` check, the use of `type: ignore` is a code smell and should be avoided in favor of more explicit type narrowing. Per project standards, `# type: ignore` is strictly forbidden. ### Evidence ```python if existing_plan: plan_id_map[plan_name] = existing_plan.id # type: ignore continue ``` ### Expected Behavior The code should be written in a way that does not require `type: ignore`. An `assert` statement should be used to provide explicit type narrowing to the type checker. ### Actual Behavior `type: ignore` is used to suppress a type error, violating the project's no-type-ignore policy. ### Suggested Fix Use an `assert` statement to provide a type hint to the type checker: ```python if existing_plan: assert existing_plan.id is not None plan_id_map[plan_name] = existing_plan.id continue ``` ### Category type-safety ## Subtasks - [ ] Remove the `# type: ignore` comment from line 111 of `src/cleveragents/infrastructure/database/legacy_migrator.py` - [ ] Add `assert existing_plan.id is not None` before the assignment to provide explicit type narrowing - [ ] Verify no other `# type: ignore` suppressions exist in `legacy_migrator.py` - [ ] Add / update BDD unit-test scenario in `features/` covering the `migrate_project_data` method with a plan that has a non-None `id` - [ ] Verify `nox -e typecheck` passes with no new errors - [ ] Verify `nox -e unit_tests` passes - [ ] Verify `nox -e coverage_report` reports coverage ≥ 97% ## Definition of Done - [ ] `# type: ignore` removed from `LegacyDataMigrator.migrate_project_data` in `legacy_migrator.py` - [ ] Explicit `assert existing_plan.id is not None` type narrowing added in its place - [ ] No new `# type: ignore` suppressions introduced anywhere - [ ] BDD scenario(s) added/updated in `features/` covering the corrected code path - [ ] All nox stages pass (`lint`, `typecheck`, `unit_tests`, `integration_tests`, `coverage_report`) - [ ] Coverage >= 97% - [ ] PR merged to the correct branch with the commit message above, closing this issue --- **Automated by CleverAgents Bot** Supervisor: Bug Hunting | Agent: ca-new-issue-creator

freemo added this to the v3.6.0 milestone

2026-04-05 04:18:28 +00:00

freemo added a new dependency

2026-04-05 04:18:34 +00:00

#400 Epic: Post-MVP Security

freemo referenced this issue

2026-04-05 04:19:08 +00:00

Task: Autonomous build progress report — 2026-04-05 #2874

freemo commented

2026-04-05 04:22:45 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: Confirmed
MoSCoW: Should Have

Valid finding verified during batch triage.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Confirmed - **MoSCoW**: Should Have Valid finding verified during batch triage. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner

freemo referenced this issue

2026-04-05 04:23:12 +00:00

Task: Autonomous build progress report — 2026-04-05 #2874

freemo referenced this issue

2026-04-05 06:15:23 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.2.0–v3.7.0 — Session Tracker #3094

freemo referenced this issue

2026-04-05 07:21:47 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.2.0–v3.7.0 — Session Tracker #3094

freemo commented

2026-04-05 07:28:17 +00:00

Author

Owner

Starting implementation on branch fix/type-safety-legacy-migrator-type-ignore.

Fix identified: Line 111 of legacy_migrator.py uses # type: ignore to suppress a type error on existing_plan.id. The fix is to add assert existing_plan.id is not None before the assignment, providing explicit type narrowing to the type checker.

Difficulty assessment: Low → starting at sonnet tier.

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-worker

Starting implementation on branch `fix/type-safety-legacy-migrator-type-ignore`. **Fix identified:** Line 111 of `legacy_migrator.py` uses `# type: ignore` to suppress a type error on `existing_plan.id`. The fix is to add `assert existing_plan.id is not None` before the assignment, providing explicit type narrowing to the type checker. **Difficulty assessment:** Low → starting at sonnet tier. --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-issue-worker

freemo referenced this issue from a commit

2026-04-05 08:22:38 +00:00

fix(database): replace type: ignore with assert for type narrowing in LegacyDataMigrator

freemo referenced this issue from a pull request that will close it,

2026-04-05 08:24:23 +00:00

fix(database): replace type: ignore with assert for type narrowing in LegacyDataMigrator #3241

freemo commented

2026-04-05 08:27:36 +00:00

Author

Owner

All subtasks complete. Quality gates passed. PR #3241 created on branch fix/type-safety-legacy-migrator-type-ignore. PR review and merge handled by continuous review stream.

Implementation summary:

Removed # type: ignore from legacy_migrator.py line 111
Added assert existing_plan.id is not None for explicit type narrowing
Added BDD scenario covering the assert-based type narrowing path
nox -e lint ✅ | nox -e typecheck ✅ (0 errors) | nox -e unit_tests ✅ (26 scenarios passed)

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-worker

All subtasks complete. Quality gates passed. PR #3241 created on branch `fix/type-safety-legacy-migrator-type-ignore`. PR review and merge handled by continuous review stream. **Implementation summary:** - Removed `# type: ignore` from `legacy_migrator.py` line 111 - Added `assert existing_plan.id is not None` for explicit type narrowing - Added BDD scenario covering the assert-based type narrowing path - `nox -e lint` ✅ | `nox -e typecheck` ✅ (0 errors) | `nox -e unit_tests` ✅ (26 scenarios passed) --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-issue-worker

freemo referenced this issue

2026-04-06 06:23:42 +00:00

fix(database): replace type: ignore with assert for type narrowing in LegacyDataMigrator #3241

freemo referenced this issue

2026-04-06 06:57:35 +00:00

fix(database): replace type: ignore with assert for type narrowing in LegacyDataMigrator #3241