UAT: agents skill add fails when YAML config uses spec-required skill: wrapper key #1472

Closed
opened 2026-04-02 19:15:34 +00:00 by freemo · 18 comments
Owner

Background

The specification (docs/specification.md, Skill Configuration section) defines skill YAML files using a cleveragents: metadata block and a skill: wrapper key:

cleveragents:
  version: "3.0"

skill:
  name: local/devops-toolkit
  description: "Full-stack development tools"
  tools:
    - name: local/run-migrations

However, the CLI implementation in src/cleveragents/cli/commands/skill.py calls SkillConfigSchema.from_yaml_file(config), and SkillConfigSchema.from_yaml() in src/cleveragents/skills/schema.py uses model_config = ConfigDict(extra="forbid"). This means when the user provides a spec-compliant YAML with cleveragents: and skill: wrapper keys, Pydantic validation fails immediately.

Current Behavior

Running agents skill add with a spec-compliant YAML file raises:

3 validation errors for SkillConfigSchema
name
  Field required [type=missing, ...]
cleveragents
  Extra inputs are not permitted [type=extra_forbidden, ...]
skill
  Extra inputs are not permitted [type=extra_forbidden, ...]

Verified with Python:

from cleveragents.skills.schema import SkillConfigSchema

spec_yaml = '''
cleveragents:
  version: "3.0"
skill:
  name: local/devops-toolkit
  description: Full-stack development tools
  tools:
    - name: local/run-migrations
'''
SkillConfigSchema.from_yaml(spec_yaml)  # Raises ValidationError

Expected Behavior

SkillConfigSchema.from_yaml() should detect and unwrap the skill: key (and silently ignore the cleveragents: metadata block) before passing the data to Pydantic validation, so that spec-compliant YAML files are accepted without error.

Acceptance Criteria

  • agents skill add <path> succeeds when the YAML file uses the spec-required skill: wrapper key and cleveragents: metadata block.
  • SkillConfigSchema.from_yaml() correctly unwraps the skill: key before validation.
  • SkillConfigSchema.from_yaml() silently ignores the cleveragents: metadata block.
  • Flat YAML (no wrapper keys) continues to work as before (no regression).
  • All existing and new Behave scenarios pass.
  • All nox stages pass.

Supporting Information

  • Code location: src/cleveragents/skills/schema.pyfrom_yaml() method
  • Specification reference: docs/specification.md — Skill Configuration section
  • Discovered during: UAT testing of the agents skill add command

Metadata

  • Branch: fix/skill-yaml-wrapper-key-unwrap
  • Commit Message: fix(skills): unwrap spec-required skill: key in SkillConfigSchema.from_yaml()
  • Milestone: v3.7.0
  • Parent Epic: #374

Subtasks

  • Investigate SkillConfigSchema.from_yaml() in src/cleveragents/skills/schema.py and confirm root cause
  • Update from_yaml() to detect and unwrap the skill: top-level key before Pydantic validation
  • Update from_yaml() to silently ignore the cleveragents: metadata block
  • Ensure flat YAML (no wrapper keys) continues to work without regression
  • Tests (Behave): Add scenario — agents skill add with spec-compliant skill: wrapper YAML succeeds
  • Tests (Behave): Add scenario — agents skill add with flat YAML (no wrapper) still succeeds (regression guard)
  • Tests (Behave): Add scenario — SkillConfigSchema.from_yaml() raises a clear error for invalid/malformed YAML
  • Tests (Robot): Add integration test for agents skill add with spec-compliant YAML file
  • Verify coverage >= 97% via nox -s coverage_report
  • Run nox (all default sessions), fix any errors

Definition of Done

This issue is complete when:

  • All subtasks above are completed and checked off.
  • A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly (fix(skills): unwrap spec-required skill: key in SkillConfigSchema.from_yaml()), followed by a blank line, then additional lines providing relevant details about the implementation.
  • The commit footer includes ISSUES CLOSED: #<this issue number>.
  • The commit is pushed to the remote on the branch matching the Branch in Metadata exactly (fix/skill-yaml-wrapper-key-unwrap).
  • The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.
  • All nox stages pass.
  • Coverage >= 97%.

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: ca-uat-tester

## Background The specification (`docs/specification.md`, Skill Configuration section) defines skill YAML files using a `cleveragents:` metadata block and a `skill:` wrapper key: ```yaml cleveragents: version: "3.0" skill: name: local/devops-toolkit description: "Full-stack development tools" tools: - name: local/run-migrations ``` However, the CLI implementation in `src/cleveragents/cli/commands/skill.py` calls `SkillConfigSchema.from_yaml_file(config)`, and `SkillConfigSchema.from_yaml()` in `src/cleveragents/skills/schema.py` uses `model_config = ConfigDict(extra="forbid")`. This means when the user provides a spec-compliant YAML with `cleveragents:` and `skill:` wrapper keys, Pydantic validation fails immediately. ## Current Behavior Running `agents skill add` with a spec-compliant YAML file raises: ``` 3 validation errors for SkillConfigSchema name Field required [type=missing, ...] cleveragents Extra inputs are not permitted [type=extra_forbidden, ...] skill Extra inputs are not permitted [type=extra_forbidden, ...] ``` Verified with Python: ```python from cleveragents.skills.schema import SkillConfigSchema spec_yaml = ''' cleveragents: version: "3.0" skill: name: local/devops-toolkit description: Full-stack development tools tools: - name: local/run-migrations ''' SkillConfigSchema.from_yaml(spec_yaml) # Raises ValidationError ``` ## Expected Behavior `SkillConfigSchema.from_yaml()` should detect and unwrap the `skill:` key (and silently ignore the `cleveragents:` metadata block) before passing the data to Pydantic validation, so that spec-compliant YAML files are accepted without error. ## Acceptance Criteria - `agents skill add <path>` succeeds when the YAML file uses the spec-required `skill:` wrapper key and `cleveragents:` metadata block. - `SkillConfigSchema.from_yaml()` correctly unwraps the `skill:` key before validation. - `SkillConfigSchema.from_yaml()` silently ignores the `cleveragents:` metadata block. - Flat YAML (no wrapper keys) continues to work as before (no regression). - All existing and new Behave scenarios pass. - All nox stages pass. ## Supporting Information - **Code location**: `src/cleveragents/skills/schema.py` — `from_yaml()` method - **Specification reference**: `docs/specification.md` — Skill Configuration section - **Discovered during**: UAT testing of the `agents skill add` command --- ## Metadata - **Branch**: `fix/skill-yaml-wrapper-key-unwrap` - **Commit Message**: `fix(skills): unwrap spec-required skill: key in SkillConfigSchema.from_yaml()` - **Milestone**: v3.7.0 - **Parent Epic**: #374 --- ## Subtasks - [ ] Investigate `SkillConfigSchema.from_yaml()` in `src/cleveragents/skills/schema.py` and confirm root cause - [ ] Update `from_yaml()` to detect and unwrap the `skill:` top-level key before Pydantic validation - [ ] Update `from_yaml()` to silently ignore the `cleveragents:` metadata block - [ ] Ensure flat YAML (no wrapper keys) continues to work without regression - [ ] Tests (Behave): Add scenario — `agents skill add` with spec-compliant `skill:` wrapper YAML succeeds - [ ] Tests (Behave): Add scenario — `agents skill add` with flat YAML (no wrapper) still succeeds (regression guard) - [ ] Tests (Behave): Add scenario — `SkillConfigSchema.from_yaml()` raises a clear error for invalid/malformed YAML - [ ] Tests (Robot): Add integration test for `agents skill add` with spec-compliant YAML file - [ ] Verify coverage >= 97% via `nox -s coverage_report` - [ ] Run `nox` (all default sessions), fix any errors --- ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly (`fix(skills): unwrap spec-required skill: key in SkillConfigSchema.from_yaml()`), followed by a blank line, then additional lines providing relevant details about the implementation. - The commit footer includes `ISSUES CLOSED: #<this issue number>`. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly (`fix/skill-yaml-wrapper-key-unwrap`). - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done. - All nox stages pass. - Coverage >= 97%. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: ca-uat-tester
freemo added this to the v3.7.0 milestone 2026-04-02 19:15:39 +00:00
freemo self-assigned this 2026-04-02 19:25:11 +00:00
Author
Owner

Issue triaged by project owner:

  • State: Verified
  • Priority: High — Command completely fails when using spec-compliant YAML format. This is a functional regression that prevents users from following the specification.
  • Milestone: v3.7.0 (already assigned)
  • MoSCoW: Must Have (already assigned) — The spec defines skill: wrapper key as the required YAML format. A command that rejects spec-compliant input is a blocking defect.
  • Parent Epic: #374

This is a valid, well-documented UAT bug. The root cause is clear: SkillConfigSchema.from_yaml() does not unwrap the skill: top-level key before Pydantic validation. The fix is straightforward — detect and unwrap the wrapper key, similar to how other config schemas handle this pattern.


Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: High — Command completely fails when using spec-compliant YAML format. This is a functional regression that prevents users from following the specification. - **Milestone**: v3.7.0 (already assigned) - **MoSCoW**: Must Have (already assigned) — The spec defines `skill:` wrapper key as the required YAML format. A command that rejects spec-compliant input is a blocking defect. - **Parent Epic**: #374 This is a valid, well-documented UAT bug. The root cause is clear: `SkillConfigSchema.from_yaml()` does not unwrap the `skill:` top-level key before Pydantic validation. The fix is straightforward — detect and unwrap the wrapper key, similar to how other config schemas handle this pattern. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner
Author
Owner

PR #1506 Review Outcome: Changes Requested

PR #1506 was reviewed and changes were requested. The PR contains zero code changes — the branch was created from the merge commit of PR #1498 (which fixed the tool wrapper key issue #1471) with no additional commits for the skill wrapper key fix required by this issue.

Key issues:

  • No modifications to src/cleveragents/skills/schema.py — the from_yaml() method still lacks skill: wrapper key and cleveragents: metadata handling
  • No Behave tests or Robot integration tests added
  • PR missing Type/Bug label and v3.7.0 milestone
  • Branch name and commit message don't match issue metadata

The PR needs to be completely reworked with the actual implementation. See the detailed review comment on PR #1506.


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## PR #1506 Review Outcome: Changes Requested PR #1506 was reviewed and **changes were requested**. The PR contains **zero code changes** — the branch was created from the merge commit of PR #1498 (which fixed the *tool* wrapper key issue #1471) with no additional commits for the *skill* wrapper key fix required by this issue. **Key issues:** - No modifications to `src/cleveragents/skills/schema.py` — the `from_yaml()` method still lacks `skill:` wrapper key and `cleveragents:` metadata handling - No Behave tests or Robot integration tests added - PR missing `Type/Bug` label and `v3.7.0` milestone - Branch name and commit message don't match issue metadata The PR needs to be completely reworked with the actual implementation. See the detailed review comment on PR #1506. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

MoSCoW classification: MoSCoW/Should Have

Priority classification: Priority/High

Rationale: The specification explicitly defines the skill: wrapper key format for skill YAML configuration files. The current implementation rejects spec-compliant YAML files, which is a specification-implementation gap. Per CONTRIBUTING.md, the specification is the authoritative source of truth — if the code conflicts with the spec, the code must be updated. This is a clear spec compliance issue that should be fixed, but it has a workaround (using the flat format). Should Have because it's important for spec compliance but doesn't block core functionality.


Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

MoSCoW classification: **MoSCoW/Should Have** Priority classification: **Priority/High** Rationale: The specification explicitly defines the `skill:` wrapper key format for skill YAML configuration files. The current implementation rejects spec-compliant YAML files, which is a specification-implementation gap. Per CONTRIBUTING.md, the specification is the authoritative source of truth — if the code conflicts with the spec, the code must be updated. This is a clear spec compliance issue that should be fixed, but it has a workaround (using the flat format). Should Have because it's important for spec compliance but doesn't block core functionality. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner
Author
Owner

PR #1506 Review Outcome: REQUEST CHANGES

PR #1506 (fix/skill-add-yaml-wrapper-key) was reviewed and found to contain zero code changes. The branch head (0022c9c) is identical to the merge base — the only commit on the branch is from PR #1498 which fixed the analogous tool: wrapper key issue (#1471), not the skill: wrapper key issue.

The implementation for this issue has not been started. The PR needs to be reworked with:

  1. Actual implementation of skill: wrapper key unwrapping in SkillConfigSchema.from_yaml()
  2. Behave scenarios and Robot integration tests per the acceptance criteria
  3. Correct commit message per issue metadata
  4. All nox stages passing with coverage ≥ 97%

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## PR #1506 Review Outcome: REQUEST CHANGES PR #1506 (`fix/skill-add-yaml-wrapper-key`) was reviewed and found to contain **zero code changes**. The branch head (`0022c9c`) is identical to the merge base — the only commit on the branch is from PR #1498 which fixed the analogous `tool:` wrapper key issue (#1471), not the `skill:` wrapper key issue. The implementation for this issue has not been started. The PR needs to be reworked with: 1. Actual implementation of `skill:` wrapper key unwrapping in `SkillConfigSchema.from_yaml()` 2. Behave scenarios and Robot integration tests per the acceptance criteria 3. Correct commit message per issue metadata 4. All nox stages passing with coverage ≥ 97% --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

Label compliance fix applied:

  • Removed conflicting label: Priority/Medium (repo-level duplicate)
  • Kept: Priority/High (org-level canonical label)
  • Reason: Issue had two conflicting Priority/* labels. Per CONTRIBUTING.md, each issue must have exactly one Priority/* label. Priority/High is consistent with the MoSCoW/Should have classification for a skill add failure bug.

Automated by CleverAgents Bot
Supervisor: Backlog Grooming | Agent: ca-backlog-groomer

Label compliance fix applied: - Removed conflicting label: `Priority/Medium` (repo-level duplicate) - Kept: `Priority/High` (org-level canonical label) - Reason: Issue had two conflicting `Priority/*` labels. Per CONTRIBUTING.md, each issue must have exactly one `Priority/*` label. `Priority/High` is consistent with the `MoSCoW/Should have` classification for a skill add failure bug. --- **Automated by CleverAgents Bot** Supervisor: Backlog Grooming | Agent: ca-backlog-groomer
Author
Owner

Label compliance fix applied:

  • Added missing label: Type/Bug
  • Added missing label: Priority/Medium
  • Reason: Per CONTRIBUTING.md, every issue must have exactly one Type/* and one Priority/* label. This UAT bug issue was inferred as Type/Bug and Priority/Medium based on its content.

Automated by CleverAgents Bot
Supervisor: Backlog Grooming | Agent: ca-backlog-groomer

Label compliance fix applied: - Added missing label: `Type/Bug` - Added missing label: `Priority/Medium` - Reason: Per CONTRIBUTING.md, every issue must have exactly one `Type/*` and one `Priority/*` label. This UAT bug issue was inferred as `Type/Bug` and `Priority/Medium` based on its content. --- **Automated by CleverAgents Bot** Supervisor: Backlog Grooming | Agent: ca-backlog-groomer
Author
Owner

PR #1506 Review Outcome: Changes Requested (3rd Review)

PR #1506 has been reviewed for the third time and changes are still requested. The PR branch fix/skill-add-yaml-wrapper-key contains zero code changes — it is 0 commits ahead of master and 61 commits behind. The branch was created from the merge point of PR #1498 (which fixed the analogous tool: wrapper key issue #1471) but no implementation work for this issue (#1472) was ever committed.

The PR needs:

  1. Rebase onto current master
  2. Implementation of skill: wrapper key unwrapping in SkillConfigSchema.from_yaml()
  3. Behave unit tests and Robot integration tests
  4. Correct commit message per issue metadata
  5. All nox stages passing with ≥ 97% coverage

See the detailed review comment on PR #1506 for the full breakdown.


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## PR #1506 Review Outcome: Changes Requested (3rd Review) PR #1506 has been reviewed for the third time and **changes are still requested**. The PR branch `fix/skill-add-yaml-wrapper-key` contains **zero code changes** — it is 0 commits ahead of master and 61 commits behind. The branch was created from the merge point of PR #1498 (which fixed the analogous `tool:` wrapper key issue #1471) but no implementation work for this issue (#1472) was ever committed. The PR needs: 1. Rebase onto current `master` 2. Implementation of `skill:` wrapper key unwrapping in `SkillConfigSchema.from_yaml()` 3. Behave unit tests and Robot integration tests 4. Correct commit message per issue metadata 5. All nox stages passing with ≥ 97% coverage See the detailed review comment on PR #1506 for the full breakdown. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

PR #1506 Review Update — Changes Still Not Implemented

PR #1506 has been reviewed for the 4th time. The branch fix/skill-add-yaml-wrapper-key still contains zero commits ahead of master and an empty diff. None of the requested changes from the previous three reviews have been addressed.

The branch head (0022c9c) is the merge commit from PR #1498 (which fixed the analogous tool: wrapper key issue #1471). No implementation work for the skill: wrapper key unwrapping has been committed.

Status: REQUEST CHANGES — PR cannot be approved or merged until the implementation is actually committed to the branch.


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## PR #1506 Review Update — Changes Still Not Implemented PR #1506 has been reviewed for the 4th time. The branch `fix/skill-add-yaml-wrapper-key` still contains **zero commits ahead of master** and an **empty diff**. None of the requested changes from the previous three reviews have been addressed. The branch head (`0022c9c`) is the merge commit from PR #1498 (which fixed the analogous `tool:` wrapper key issue #1471). No implementation work for the `skill:` wrapper key unwrapping has been committed. **Status**: REQUEST CHANGES — PR cannot be approved or merged until the implementation is actually committed to the branch. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

PR #1506 Review Outcome: REQUEST CHANGES (5th Review)

PR #1506 has been reviewed for the 5th time and still contains zero implementation. The branch fix/skill-add-yaml-wrapper-key is 66 commits behind master and 0 commits ahead — the diff is completely empty.

The branch was created from the merge point of PR #1498 (which fixed the analogous tool: wrapper key issue #1471) but no additional implementation work was ever committed for this issue.

Required to close this issue:

  1. Rebase the branch onto current master
  2. Implement the skill: wrapper key unwrapping in SkillConfigSchema.from_yaml() in src/cleveragents/skills/schema.py
  3. Add all required Behave scenarios and Robot integration tests
  4. Use the correct commit message: fix(skills): unwrap spec-required skill: key in SkillConfigSchema.from_yaml()
  5. Ensure all nox stages pass and coverage ≥ 97%

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## PR #1506 Review Outcome: REQUEST CHANGES (5th Review) PR #1506 has been reviewed for the 5th time and still contains **zero implementation**. The branch `fix/skill-add-yaml-wrapper-key` is 66 commits behind master and 0 commits ahead — the diff is completely empty. The branch was created from the merge point of PR #1498 (which fixed the analogous `tool:` wrapper key issue #1471) but no additional implementation work was ever committed for this issue. ### Required to close this issue: 1. Rebase the branch onto current `master` 2. Implement the `skill:` wrapper key unwrapping in `SkillConfigSchema.from_yaml()` in `src/cleveragents/skills/schema.py` 3. Add all required Behave scenarios and Robot integration tests 4. Use the correct commit message: `fix(skills): unwrap spec-required skill: key in SkillConfigSchema.from_yaml()` 5. Ensure all nox stages pass and coverage ≥ 97% --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

PR #1506 Review Update — 6th Review: Still No Implementation

PR #1506 has been reviewed again and changes requested for the sixth time. The branch fix/skill-add-yaml-wrapper-key still contains zero commits ahead of master and the diff is completely empty. No implementation work has been committed for this issue.

The branch is now 67 commits behind master and needs to be rebased before any work can begin. All previous review feedback remains unaddressed.

See PR #1506 review for full details.


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## PR #1506 Review Update — 6th Review: Still No Implementation PR #1506 has been reviewed again and **changes requested** for the sixth time. The branch `fix/skill-add-yaml-wrapper-key` still contains **zero commits ahead of master** and the diff is completely empty. No implementation work has been committed for this issue. The branch is now 67 commits behind master and needs to be rebased before any work can begin. All previous review feedback remains unaddressed. See [PR #1506 review](https://git.cleverthis.com/cleveragents/cleveragents-core/pulls/1506) for full details. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

PR #1506 reviewed (7th review) — changes requested. The PR branch fix/skill-add-yaml-wrapper-key still contains zero implementation commits (0 commits ahead of master, 67 behind). The diff is completely empty. No progress has been made since the previous 6 reviews all requested the same changes.

The implementation for SkillConfigSchema.from_yaml() wrapper key unwrapping, along with Behave and Robot tests, still needs to be written and committed to the branch.


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

PR #1506 reviewed (7th review) — **changes requested**. The PR branch `fix/skill-add-yaml-wrapper-key` still contains zero implementation commits (0 commits ahead of master, 67 behind). The diff is completely empty. No progress has been made since the previous 6 reviews all requested the same changes. The implementation for `SkillConfigSchema.from_yaml()` wrapper key unwrapping, along with Behave and Robot tests, still needs to be written and committed to the branch. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

PR #1506 reviewed (8th review). Changes still requested — the branch fix/skill-add-yaml-wrapper-key contains zero commits ahead of master and the diff is empty. No implementation has been committed for this issue. The branch needs to be rebased onto current master and the skill: wrapper key unwrapping must be implemented in SkillConfigSchema.from_yaml() with all required tests.


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

PR #1506 reviewed (8th review). **Changes still requested** — the branch `fix/skill-add-yaml-wrapper-key` contains zero commits ahead of master and the diff is empty. No implementation has been committed for this issue. The branch needs to be rebased onto current master and the `skill:` wrapper key unwrapping must be implemented in `SkillConfigSchema.from_yaml()` with all required tests. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

PR #1506 Review Outcome: Changes Requested

PR #1506 (fix/skill-add-yaml-wrapper-key) was reviewed and changes were requested. The PR branch contains zero commits ahead of master — the diff is completely empty. No implementation work has been committed for this issue.

The branch was created from the merge point of PR #1498 (which fixed the analogous tool: wrapper key issue #1471) but no additional code was ever added for the skill: wrapper key fix.

Required before this PR can be approved:

  1. Rebase onto current master (currently 80 commits behind)
  2. Implement skill: wrapper key unwrapping in SkillConfigSchema.from_yaml() in src/cleveragents/skills/schema.py
  3. Add all required Behave and Robot tests per the issue subtasks
  4. Use the correct commit message format per issue metadata
  5. Ensure all nox stages pass and coverage ≥ 97%

This is the 9th review identifying this issue. The PR remains in State/In Review pending implementation.


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## PR #1506 Review Outcome: Changes Requested PR #1506 (`fix/skill-add-yaml-wrapper-key`) was reviewed and **changes were requested**. The PR branch contains **zero commits ahead of master** — the diff is completely empty. No implementation work has been committed for this issue. The branch was created from the merge point of PR #1498 (which fixed the analogous `tool:` wrapper key issue #1471) but no additional code was ever added for the `skill:` wrapper key fix. **Required before this PR can be approved:** 1. Rebase onto current `master` (currently 80 commits behind) 2. Implement `skill:` wrapper key unwrapping in `SkillConfigSchema.from_yaml()` in `src/cleveragents/skills/schema.py` 3. Add all required Behave and Robot tests per the issue subtasks 4. Use the correct commit message format per issue metadata 5. Ensure all nox stages pass and coverage ≥ 97% This is the 9th review identifying this issue. The PR remains in `State/In Review` pending implementation. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

PR #1506 has been reviewed for the 10th time and still contains no implementation — the branch has zero commits ahead of master and an empty diff. The PR should be closed and a new one opened when the implementation is ready. The required changes are well-documented in the issue description and in the 10 review comments on the PR.


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

PR #1506 has been reviewed for the 10th time and still contains **no implementation** — the branch has zero commits ahead of master and an empty diff. The PR should be closed and a new one opened when the implementation is ready. The required changes are well-documented in the issue description and in the 10 review comments on the PR. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

PR #1506 Review Outcome: REQUEST CHANGES — No Implementation

PR #1506 (fix/skill-add-yaml-wrapper-key) was reviewed for the 11th time and remains empty — zero commits ahead of master, empty diff. The branch was created from the merge point of PR #1498 (the tool: wrapper fix for issue #1471) but no implementation work for this issue (#1472, the skill: wrapper fix) was ever committed.

Recommendation: PR #1506 should be closed. A new PR should be opened on the correct branch (fix/skill-yaml-wrapper-key-unwrap per issue metadata) when the implementation is ready.

This issue remains in State/Verified and the implementation has not been started.


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## PR #1506 Review Outcome: REQUEST CHANGES — No Implementation PR #1506 (`fix/skill-add-yaml-wrapper-key`) was reviewed for the 11th time and remains **empty** — zero commits ahead of master, empty diff. The branch was created from the merge point of PR #1498 (the `tool:` wrapper fix for issue #1471) but no implementation work for this issue (#1472, the `skill:` wrapper fix) was ever committed. **Recommendation**: PR #1506 should be closed. A new PR should be opened on the correct branch (`fix/skill-yaml-wrapper-key-unwrap` per issue metadata) when the implementation is ready. This issue remains in `State/Verified` and the implementation has not been started. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

PR #1506 Review Outcome: Changes Requested (Empty PR)

PR #1506 was reviewed and found to contain zero implementation. The branch fix/skill-add-yaml-wrapper-key has no commits ahead of master — the branch tip (0022c9c) is a commit already on master from PR #1498 (which fixed the tool: wrapper key for issue #1471, not the skill: wrapper key for this issue).

This issue (#1472) remains unresolved. A new implementation branch and PR are needed to address the skill: wrapper key handling in SkillConfigSchema.from_yaml().


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## PR #1506 Review Outcome: Changes Requested (Empty PR) PR #1506 was reviewed and found to contain **zero implementation**. The branch `fix/skill-add-yaml-wrapper-key` has no commits ahead of master — the branch tip (`0022c9c`) is a commit already on master from PR #1498 (which fixed the *tool:* wrapper key for issue #1471, not the *skill:* wrapper key for this issue). This issue (#1472) remains **unresolved**. A new implementation branch and PR are needed to address the `skill:` wrapper key handling in `SkillConfigSchema.from_yaml()`. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

PR #1506 Review Status: No Implementation

PR #1506 (fix/skill-add-yaml-wrapper-key) has been reviewed and found to contain zero commits ahead of master — the diff is empty. The branch head is the merge commit from PR #1498 (which fixed the analogous tool: wrapper key issue #1471), not a fix for this issue.

Current code state: SkillConfigSchema.from_yaml() in src/cleveragents/skills/schema.py does not handle the skill: wrapper key or cleveragents: metadata block. This issue remains unfixed.

Action needed: The implementation must be pushed to the PR branch (after rebasing on master), or PR #1506 should be closed and a new PR created with the actual fix.

This is the 12th review flagging the PR as empty.


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## PR #1506 Review Status: No Implementation PR #1506 (`fix/skill-add-yaml-wrapper-key`) has been reviewed and found to contain **zero commits ahead of master** — the diff is empty. The branch head is the merge commit from PR #1498 (which fixed the analogous `tool:` wrapper key issue #1471), not a fix for this issue. **Current code state**: `SkillConfigSchema.from_yaml()` in `src/cleveragents/skills/schema.py` does not handle the `skill:` wrapper key or `cleveragents:` metadata block. This issue remains unfixed. **Action needed**: The implementation must be pushed to the PR branch (after rebasing on master), or PR #1506 should be closed and a new PR created with the actual fix. This is the 12th review flagging the PR as empty. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

PR #1506 Review Status: Changes Requested (No Implementation)

PR #1506 (fix/skill-add-yaml-wrapper-key) was reviewed and found to contain zero code changes. The branch has no commits ahead of master — the diff is completely empty. A formal REQUEST_CHANGES review has been submitted.

The PR has been in this state for 3+ days with 12+ prior reviews all confirming the same finding. I recommend closing PR #1506 and creating a fresh PR with the actual implementation when ready.

This issue remains open and unresolved. The required changes per the acceptance criteria have not been implemented:

  • SkillConfigSchema.from_yaml() still does not unwrap the skill: wrapper key
  • No Behave scenarios or Robot integration tests have been added
  • The agents skill add command still fails with spec-compliant YAML

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## PR #1506 Review Status: Changes Requested (No Implementation) PR #1506 (`fix/skill-add-yaml-wrapper-key`) was reviewed and found to contain **zero code changes**. The branch has no commits ahead of master — the diff is completely empty. A formal `REQUEST_CHANGES` review has been submitted. The PR has been in this state for 3+ days with 12+ prior reviews all confirming the same finding. I recommend closing PR #1506 and creating a fresh PR with the actual implementation when ready. This issue remains **open** and unresolved. The required changes per the acceptance criteria have not been implemented: - `SkillConfigSchema.from_yaml()` still does not unwrap the `skill:` wrapper key - No Behave scenarios or Robot integration tests have been added - The `agents skill add` command still fails with spec-compliant YAML --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
freemo removed this from the v3.7.0 milestone 2026-04-07 02:11:53 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
cleveragents/cleveragents-core#1472
No description provided.