716 Commits

Author	SHA1	Message	Date
freemo	6e47abbd63	fix(cli): fix format_output() to use rich and color renderers instead of JSON fallback ... The format_output() function in src/cleveragents/cli/formatting.py had two routing bugs that caused incorrect output for the 'rich' and 'color' formats: 1. The 'rich' format had no explicit dispatch branch and silently fell through to the final JSON fallback, returning raw JSON instead of styled terminal output. Since 'rich' is the default CLI format (per ADR-021), this meant all commands using format_output() (version, info, diagnostics) produced JSON by default. 2. The 'color' format was incorrectly routed to _format_plain() instead of a color-aware renderer, producing plain text with no ANSI color codes. Fix: - Added _format_rich() helper that delegates to RichMaterializer via OutputSession, producing ANSI-styled terminal output consistent with format_output_session(). - Added _format_color() helper that delegates to ColorMaterializer via OutputSession, producing ANSI-colored terminal output. - Added explicit OutputFormat.RICH dispatch in format_output() routing. - Fixed OutputFormat.COLOR dispatch to use _format_color() instead of _format_plain(). Tests: - Updated existing BDD scenario that was validating the buggy behavior (expected JSON for rich format) to now assert correct styled output. - Added new BDD scenarios: 'rich format produces styled terminal output not JSON' and 'color format produces ANSI-colored output not plain text'. - Added Robot Framework integration tests in cli_formats.robot and helper_cli_formats.py verifying end-to-end styled output for both formats. All nox sessions pass: lint, typecheck, unit_tests, security_scan. ISSUES CLOSED: #2921	2026-05-30 11:09:06 -04:00
freemo	f2232eec09	fix(acms): align SkeletonCompressorService.compress() with SkeletonCompressor protocol ... - Updated SkeletonCompressorService.compress() to accept (fragments: tuple[ContextFragment, ...], skeleton_budget: int) -> tuple[ContextFragment, ...], matching the SkeletonCompressor protocol - Removed skeleton_ratio and CompressionResult from the public API - Added @runtime_checkable to SkeletonCompressor protocol in acms_service.py - Added structural subtype assertion at module level to prevent future protocol drift - Rewrote all Behave feature scenarios and step definitions to use skeleton_budget - Updated benchmarks and robot helpers to use absolute token budgets - Removed CompressionResult export from services __init__.py and vulture_whitelist.py - The depth_breadth_projection.py call site already correctly computed and passed skeleton_budget ISSUES CLOSED: #2925	2026-05-30 08:29:22 -04:00
HAL9000	e21fc197d3	fix(skills): fix robot integration test YAML creation for skill: wrapper key test	2026-05-30 04:04:21 -04:00
HAL9000	387b640249	fix(skills): fix CI gate failures blocking PR #1506 merge ... Fix pre-existing lint, typecheck, and security failures that were blocking the PR from passing CI: - Fix E501 line-too-long in session_service.py (remove erroneous "sha256:" string prefix from dict comprehension on line 268) - Fix W293 trailing whitespace in tool.py line 249 - Fix typecheck error in session_service.py: data.get("checksum") can return None, remove invalid string concatenation - Fix typecheck error in schema.py: add explicit dict[str, Any] type annotation for wrapper variable to resolve str|None issue - Fix vulture false positive: add "destination" Protocol parameter to vulture_whitelist.py - Fix @tdd_issue/@tdd_issue_1472 tag placement in skill_schema.feature (remove blank line between tags and scenario) - Add @tdd_issue/@tdd_issue_1472 tags to all new wrapper key scenarios - Add Robot integration test for spec-compliant skill: wrapper YAML	2026-05-30 04:04:21 -04:00
HAL9000	2c2b4e8813	test(actor): add @tdd_issue_1429 regression tests for actor_ref field reading ... Add Behave feature file and Robot Framework integration tests covering the two compiler functions fixed in issue #1429: - _map_node(): SUBGRAPH node's NodeConfig.subgraph is now populated from node.actor_ref instead of config.get("actor_ref") which always returned None - compile_actor(): metadata.subgraph_refs is now populated from node_def.actor_ref instead of node_def.config.get("actor_ref", "") which always returned an empty string Three Behave scenarios tagged @tdd_issue @tdd_issue_1429 covering: 1. NodeConfig.subgraph field populated from actor_ref (_map_node fix) 2. metadata.subgraph_refs populated from actor_ref (compile_actor fix) 3. Both fields correct together with a realistic actor ref Two Robot Framework integration tests in tdd_actor_compiler_actor_ref_1429.robot with a self-contained Python helper that exercises both code paths in isolation. ISSUES CLOSED: #1429	2026-05-30 02:07:41 -04:00
HAL9000	02e51b9298	fix(actor): fix lint errors and add regression tests for lsp_binding field (#1432) ... - Remove trailing whitespace from blank lines in _extract_lsp_bindings() (W293 at lines 160, 164, 167, 172, 183, 188, 203) - Simplify over-long line 180 (E501): auto_detect=node.lsp_binding.auto - Add Behave scenario verifying NodeLspBinding typed field populates CompilationMetadata.lsp_bindings (features/actor_lsp_binding_field.feature) - Add corresponding @given step using NodeLspBinding in actor_compiler_steps.py - Add Robot Framework regression test case and lsp-binding-field helper command confirming node.lsp_binding is read by compile_actor() - Update CHANGELOG.md and CONTRIBUTORS.md ISSUES CLOSED: #1432	2026-05-30 00:36:20 -04:00
brent.edwards	92e2585358	fix: add missing validations/unit-tests.yaml example ... Add the missing workflow validation example and keep the #1039 TDD regression active by removing the expected-fail tag and updating scenario narrative.\n\nTo satisfy the required full quality gates, stabilize flaky integration behavior encountered during this issue run: use a shared SQLAlchemy session in resource DAG scripts, isolate RxPY validation temp paths per test run, extend transient subprocess timeouts/retry behavior, and clear stale pabot worker artifacts before integration runs so repeated nox executions are reliable.\n\nISSUES CLOSED: #1039	2026-05-30 00:09:20 -04:00
HAL9000	8ed8750160	fix(audit): forward DomainEvent.timestamp to AuditService.record() ... AuditService.record() was generating its own timestamp internally, discarding the original DomainEvent.timestamp. This means audit entries recorded when an event was audited, not when the domain event actually occurred, breaking forensic accuracy per §Audit Logging (SEC7). Changes: - Add `timestamp: datetime | None = None` keyword parameter to AuditService.record(). When provided, uses it as created_at; falls back to datetime.now(tz=UTC) for backward compatibility. Applied to both the async queue path and the synchronous DB path. - AuditEventSubscriber._handle_event() now passes timestamp=event.timestamp so the original event creation time is preserved in audit entries. - Add 3 Behave BDD scenarios covering: full pipeline timestamp preservation, direct record() with explicit timestamp, and backward compatibility (record() without timestamp auto-generates created_at). - Add preserve_event_timestamp Robot integration test and helper subcommand. - Add static source check in security_audit.robot verifying the timestamp parameter signature exists. ISSUES CLOSED: #719	2026-05-29 16:36:39 -04:00
HAL9000	6a76ea894d	test(cli): add TDD regression tests for automation_profile._get_service() DI bypass ... Three BDD scenarios and two Robot Framework integration tests verifying that _get_service() in automation_profile.py resolves AutomationProfileService through the DI container rather than manually calling create_engine or sessionmaker (bug #990). Bug #990 was fixed by PR #1181 before this TDD test PR merged; the @tdd_expected_fail tag is therefore absent and these tests serve as permanent regression guards confirming the fix remains in place. ISSUES CLOSED: #1031	2026-05-29 15:26:47 -04:00
cleveragents-auto	ee1ec2b56d	chore: worker ruff auto-fix (pre-push lint gate)	2026-05-29 07:21:08 -04:00
HAL9000	5ede1c018a	fix(server,sync): use A2aRequest.method not .operation in tests and helpers ... The new entity-sync feature introduced A2aRequest with a `method` field (JSON-RPC 2.0 wire format), but several test/helper files used the wrong field name `operation` when constructing requests or logging, and checked non-existent `.status`/`.data` attributes on A2aResponse instead of `.result`/`.error`. Fixes: - asgi_app.py: log `a2a_request.method`, not `.operation` (typecheck error) - server_lifecycle_steps.py: send `method` key in JSON-RPC payload; look up status in `result` dict, not top-level response body - server_lifecycle.feature: expect "healthy" (what the handler returns), not "ok" - entity_sync_steps.py: construct A2aRequest(method=...) not (operation=...); assert on .result/.error instead of .status/.data - robot/helper_entity_sync.py: same method= and result/error fixes across sync_pull, sync_push, sync_status, sync_facade_no_service helpers - robot/helper_server_lifecycle.py: same method= and result path fixes ISSUES CLOSED: #1125	2026-05-29 07:21:08 -04:00
freemo	ff9c6540a2	feat(server): entity sync (_cleveragents/sync/*) ... Implement entity synchronization between client and server using the _cleveragents/sync/* A2A extension methods per the specification. Sync models (src/cleveragents/a2a/sync_models.py): - Pydantic v2 models for pull/push/status requests and responses - VectorClock with increment, merge, happens-before, and concurrency detection for distributed conflict detection - SyncEntitySnapshot, SyncConflict, SyncState, SyncQueueEntry models - SyncEntityType enum: actor, skill, action, plan, session - ConflictResolution enum: last_writer_wins, manual, server_wins, client_wins SyncService (src/cleveragents/application/services/sync_service.py): - pull(): download server namespace entities to local cache with incremental sync (since timestamps) and force-overwrite option - push(): push local entity definitions to server namespace with configurable conflict resolution strategy - status(): compare local and server entity versions, detect drift, report local-ahead, server-ahead, and concurrent conflicts - resolve_conflict(): manually resolve detected conflicts with winner selection (local or server) - Offline queue: enqueue_offline() and process_offline_queue() for retry on reconnect, with max-retries enforcement - The local/ namespace is never synced per specification A2A facade (src/cleveragents/a2a/facade.py): - Replaced sync stub handlers with real _handle_sync_pull, _handle_sync_push, _handle_sync_status routing to SyncService - Added sync_service property and TYPE_CHECKING import - Facade returns stubs when no SyncService is registered Tests: - Behave BDD: features/entity_sync.feature (65 scenarios, 247 steps) covering models, vector clocks, pull/push/status, conflict resolution, offline queue, facade integration, constructor validation, edge cases - Robot Framework: robot/entity_sync.robot (8 integration tests) ISSUES CLOSED: #866	2026-05-29 07:21:08 -04:00
freemo	b5f56a6fb8	feat(server): team collaboration features ... Implemented multi-user connection handling with user identity tracking (TeamMember with owner/admin/member/viewer roles), role-based access control (TeamPermission with read/write/admin/manage_members), concurrent session support (SessionRegistry with thread-safe locking and per-user/ per-project queries), and optimistic-locking conflict resolution (VersionStamp with last-writer-wins, reject, and merge strategies). Added TeamCollaborationService as the central orchestrator for all collaboration operations: team membership management, permission enforcement, session lifecycle, and version-stamp conflict detection/ resolution. The service cleans up user sessions when members are removed. Domain models follow existing patterns: Pydantic BaseModel with ConfigDict, StrEnum enums, ULID identifiers, and an error hierarchy rooted in TeamCollaborationError. Includes 48 Behave BDD scenarios (178 steps) covering all models, service operations, and edge cases, plus 15 Robot Framework integration tests for end-to-end workflow validation. ISSUES CLOSED: #863	2026-05-29 05:08:08 -04:00
freemo	c6ccb85bb8	feat(server): ASGI endpoint via uvicorn ... Implement FastAPI-based ASGI application served by uvicorn for the CleverAgents server mode. Add health check endpoint, A2A JSON-RPC routing, configurable host:port binding, and graceful shutdown handling. Server launches via `agents server start`. - Add FastAPI ASGI app factory at infrastructure/server/asgi_app.py with /.well-known/agent.json (Agent Card), /health (liveness), and /a2a (A2A JSON-RPC 2.0 dispatch via A2aLocalFacade) - Add ServerLifecycle class at infrastructure/server/server_lifecycle.py wrapping uvicorn.Server with SIGTERM/SIGINT graceful shutdown - Add `agents server start` CLI command with --host, --port, --log-level options, resolving defaults from Settings - Add fastapi>=0.115.0 dependency to pyproject.toml (uvicorn already present) - Add Behave BDD tests (features/server_lifecycle.feature, 20 scenarios) - Add Robot Framework integration tests (robot/server_lifecycle.robot) - Update CHANGELOG.md and vulture_whitelist.py ISSUES CLOSED: #862	2026-05-29 05:08:08 -04:00
HAL9000	8dde6c81ef	feat(server): implement PostgreSQL storage backend for server mode ... Add PostgreSQL support as the server-mode storage backend alongside existing SQLite for local mode. Verify all ORM models are dialect- agnostic, configure connection pooling for multi-user access, add Docker Compose for local PG development, and wire database URL selection based on deployment mode. Changes: - Add psycopg2-binary dependency to pyproject.toml - Add server_mode, db_pool_size, db_max_overflow, db_pool_recycle settings to Settings with environment variable support - Add resolve_database_url() and is_postgresql() to Settings for mode-aware database URL resolution - Configure UnitOfWork engine creation with pool_size, max_overflow, pool_recycle, and pool_pre_ping for PostgreSQL connections - Update MigrationRunner to handle both SQLite and PostgreSQL backends - Add compare_type=True to Alembic env.py for dialect-aware migrations - Add docker-compose.yml with PostgreSQL 16-alpine for local development - Add Behave BDD feature (14 scenarios) covering settings, pool config, engine creation, ORM dialect compatibility, and migration runner - Add Robot Framework integration tests (12 test cases) for the abstraction layer with requires_postgresql tag for live PG tests Fixes: - Restore require_confirmation parameter to UnitOfWork.__init__ - Add argument validation to UnitOfWork.__init__ (fail-fast) - Add explicit PostgreSQL isolation_level (READ COMMITTED) - Add dispose() method and context manager support to UnitOfWork - Fix MigrationRunner.get_current_revision() to dispose engine - Fix Settings.is_postgresql() to handle ValueError gracefully ISSUES CLOSED: #878	2026-05-29 01:04:59 -04:00
freemo	6aaf69e0a4	feat(server): implement PostgreSQL storage backend for server mode ... Add PostgreSQL support as the server-mode storage backend alongside existing SQLite for local mode. Verify all ORM models are dialect- agnostic, configure connection pooling for multi-user access, add Docker Compose for local PG development, and wire database URL selection based on deployment mode. Changes: - Add psycopg2-binary dependency to pyproject.toml - Add server_mode, db_pool_size, db_max_overflow, db_pool_recycle settings to Settings with environment variable support - Add resolve_database_url() and is_postgresql() to Settings for mode-aware database URL resolution - Configure UnitOfWork engine creation with pool_size, max_overflow, pool_recycle, and pool_pre_ping for PostgreSQL connections - Update MigrationRunner to handle both SQLite and PostgreSQL backends - Add compare_type=True to Alembic env.py for dialect-aware migrations - Add docker-compose.yml with PostgreSQL 16-alpine for local development - Add Behave BDD feature (14 scenarios) covering settings, pool config, engine creation, ORM dialect compatibility, and migration runner - Add Robot Framework integration tests (12 test cases) for the abstraction layer with requires_postgresql tag for live PG tests ISSUES CLOSED: #878	2026-05-29 01:00:08 -04:00
HAL9000	2dd920078a	fix(tests): add resolve_actor_options to mock lifecycle helpers ... The PR added resolve_actor_options() to StrategyActor, LLMStrategizeActor, and LLMExecuteActor, but the three mock lifecycle SimpleNamespace objects used by tests did not include this method, causing AttributeError at runtime: - features/mocks/mock_strategy_llm.py: make_mock_lifecycle() used by robot/helper_strategy_actor.py (strategy_actor.robot llm-json test) and features/steps/strategy_actor_llm_steps.py - features/steps/llm_actors_coverage_steps.py: _make_mock_lifecycle() used by llm_actors_coverage.feature scenarios - robot/helper_m5_e2e_context.py: inline lifecycle SimpleNamespace used by m5_e2e_verification.robot Execute Phase LLM Uses ACMS Context All three now include resolve_actor_options=MagicMock(return_value=None) matching the None-return contract the actors use when no custom backend is configured. ISSUES CLOSED: #11256	2026-05-28 17:35:08 -04:00
CoreRasurae	3e13411fcf	fix(actors): distinguish namespace/name from provider/model in actor name parsing ... When action YAML references actors using namespace/name format (e.g. `strategy_actor: local/my-strategist`), `_parse_actor_name()` incorrectly treated the namespace prefix as a provider name, causing `ValueError: Unknown provider type: local`. Changes: - `_is_known_provider()`: New utility function (strategy_resolution.py) that checks whether a slash-separated first segment matches a known `ProviderType` value (openai, anthropic, etc.). Consolidated into a single implementation; llm_actors.py now imports from strategy_resolution.py. - `_parse_actor_name()`: When the first segment IS a known provider, preserves existing behaviour (provider/model). When it is NOT a known provider, treats the input as namespace/name and returns the full name as the model identifier with the default provider. Callers SHOULD pre-resolve namespace/name references via the actor registry before calling this function. Both implementations (strategy_resolution.py and llm_actors.py) updated; ProviderType import moved to top level. - `PlanLifecycleService.resolve_actor_provider_model()`: New method that resolves a namespaced actor name (e.g. local/my-strategist) to provider/model format by looking up the actor record and extracting its provider and model fields. - `LifecycleService` Protocol (strategy_resolution.py): Added `resolve_actor_provider_model` to the protocol, eliminating the need for `# type: ignore[union-attr]` at call sites. - `PlanLifecycleProtocol` (llm_actors.py): Added `resolve_actor_provider_model` to the protocol. - Caller pre-resolution: StrategyActor, LLMStrategizeActor, LLMExecuteActor, SessionWorkflow._resolve_llm(), and CLI session commands now pre-resolve actor names through the lifecycle service or via injected actor_resolver callables before calling `_parse_actor_name()`, ensuring namespace/name references are correctly mapped to their underlying LLM providers. - `_build_actor_resolver()` (cli/commands/session.py) and `_build_actor_resolver_for_session_workflow()` (a2a/facade.py): Moved `_is_known_provider` imports to top level; removed redundant `except (NotFoundError, Exception)`; added warning logging for outer exception handlers. - `make_mock_lifecycle()` (mock_strategy_llm.py) and `_make_mock_lifecycle()` (llm_actors_coverage_steps.py): Added `resolve_actor_provider_model` to mock lifecycle services for test compatibility. - Added `@tdd_issue @tdd_issue_11254` tags to all new BDD scenarios related to namespace/name disambiguation in llm_actors_coverage, strategy_actor_llm, and plan_lifecycle_service_coverage_boost_r4 feature files. - Updated docs/CHANGELOG.md with the fix entry. ISSUES CLOSED: #11254	2026-05-22 20:42:25 +01:00
hamza.khyari	652769c46c	feat(tui): wire normal text input to LLM via A2A facade ... Wires the TUI normal text input path to the LLM via A2aLocalFacade, closing the gap where typing a message produced no LLM call. All infrastructure (facade, SessionWorkflow, ProviderRegistry) already existed in the CLI; this PR adds the TUI wiring on top. Key changes: - _run_llm_dispatch(): module-level, Textual-free dispatch function covering all domain exception paths with user-friendly messages - _format_worker_outcome(): testable worker result/error translator - _create_tui_session(): DB-backed session with persona actor binding - _build_tui_facade(): wired A2aLocalFacade + SessionWorkflow singleton - run_worker(thread=True, exclusive=True): non-blocking, serialised - _dispatch_gen counter: prevents cancelled worker callbacks from corrupting the multi-turn transcript - SessionView.transcript: accumulated conversation history, pre-escaped - Markup escaping: _escape() applied before transcript storage - on_mount focus: prompt.focus() so keyboard input is received Tests: 18 BDD scenarios + 6 Robot Framework integration tests with FakeListLLM (no real API keys required). ISSUES CLOSED: #11230	2026-05-22 15:12:04 +00:00
brent.edwards	eb46f0ff54	fix(plan): add tier hydration and improve architecture review output (#10938) ... ## Summary This PR fixes issue #10878 where architecture reviews were truncated because the regex pattern for parsing file output would stop at the first ``` encountered in the Markdown report. ## Changes - Change file delimiters from ``` to >>>>>>>/<<<<<<< to avoid Markdown conflicts - Add tier hydration before strategize phase in plan_executor.py - Increase max_tokens to 16384 in llm_actors.py for longer outputs - Increase context_max_tokens_hot from 16000 to 32000 in settings.py - Fix get_hot_view → get_hot_fragments in strategy_actor.py and plan_executor.py - Add opencode to skip directories in context_tier_hydrator.py - Change sandbox output location to plan-output/ directory in plan.py - Add get_context_summary stub method to acms_service.py ## Testing Run architecture review action and verify the output report is complete with all sections. Reviewed-on: #10938	2026-05-19 12:43:34 +00:00
hurui200320	0c5724c2f6	feat(actor-run): wire ToolCallingRuntime into actor run for skill-based tool calling ... Implements the full tool-calling path for `agents actor run --skill` so that LLM actors can actually invoke tools through the ToolCallingRuntime loop when a skill is attached. Core changes: - reactive/tool_caller.py (new): ToolCallingLLMCaller implements the LLMCaller protocol; binds tool schemas via bind_tools(), threads SystemMessage+HumanMessage on first call and AIMessage+ToolMessages on subsequent calls, extracts tool calls from LangChain responses following the LangChainSessionCaller pattern. - reactive/tool_caller.py: bidirectional tool name encoding via uppercase sentinels (_encode_tool_name / _decode_tool_name) to make CleverAgents namespaced tool names ("builtin/file-read", "server:local/tool") compatible with Anthropic's tool name pattern ^[a-zA-Z0-9_-]{1,128}$. Uses _C_ for ":" and _S_ for "/" — uppercase sentinels are safe because valid CleverAgents tool names forbid uppercase letters. Encoding applied in _resolve_llm() before bind_tools(); decoding applied in invoke() when extracting tool calls from the LLM response. - reactive/tool_agent.py (new): ToolCallingAgent builds a per-run local ToolRegistry from resolved skill tool entries by looking up names in the shared builtin_registry; drives ToolCallingRuntime.run_tool_loop(); exposes last_result for tool_calls surfacing. - reactive/application.py: (ST-1) _make_agent_instance() now always merges skill tools instead of silently dropping them when actor has no base tools list; routes tools+llm→ToolCallingAgent, tools+non-llm→SimpleToolAgent, no-tools+llm→SimpleLLMAgent; (ST-4) _builtin_registry created at startup with register_file_tools/git/subplan; (ST-6) _tally_tool_calls() + last_run_tool_calls property. - reactive/graph_executor.py: (ST-5) ToolCallingAgent added to isinstance check in _invoke_agent() so context dict is forwarded for Jinja2 rendering. - cli/commands/actor_run.py: prints "Tool Calls: {n}" when > 0. Test fixes: - features/steps/actor_cli_run_steps.py: _make_app() sets last_run_tool_calls=0 to avoid MagicMock>int TypeError in Python 3.13. - features/steps/actor_run_signature_resolve_steps.py: same fix. - robot/helper_actor_run_signature.py: same fix. - features/reactive_application_coverage_boost.feature: updated scenario to verify new correct behavior (LLM+skills → ToolCallingAgent, not silently kept as SimpleLLMAgent). BDD coverage: 34 scenarios in features/actor_run_tool_calling.feature covering tool call success, multi-turn loop, no-skill regression, silent-drop fix, LLMCaller internals, _build_tool_registry edge cases, last_run_tool_calls tallying, tool name encoding/decoding, and LLM response decoding. ISSUES CLOSED: #11211	2026-05-18 06:05:54 +00:00
HAL9000	f4cea72248	fix(ci): update all merge_invariants callers to use 4-param signature ... The PR #11143 adds action_invariants as a 4th parameter to merge_invariants() and InvariantSet.merge(), but two call sites were not updated: - benchmarks/invariant_merge_bench.py: 5 calls with 3 positional args - robot/helper_m3_e2e_verification.py: 2 calls using keyword args All call sites now pass action_invariants=[] for backward-compatible empty-action behavior.	2026-05-16 04:14:17 +00:00
CoreRasurae	97c1007bb5	feat(events): wire domain services to emit missing EventBus events ... Add TokenAuthMiddleware to emit AUTH_SUCCESS/AUTH_FAILURE with spec-aligned audit details and wire it through the DI container using server.token resolution. Add Behave and Robot coverage for auth event emission and end-to-end audit persistence, and update audit subscriber producer notes and changelog. ISSUES CLOSED: #714	2026-05-15 22:19:57 +01:00
CoreRasurae	b41f536da6	fix(automation): respect automation profile gates in lifecycle service and async jobs ... Add BDD regression tests for issue #4328 automation profile gates Tests verify that complete_strategize() and complete_execute() respect automation profile thresholds and do NOT unconditionally call auto_progress(). Covers 8 built-in profiles: manual, full-auto, supervised, auto, review_before_apply, ci, trusted ISSUES CLOSED: #4328	2026-05-14 22:57:11 +00:00
hurui200320	cc8e013f9b	fix(actor): handle nested actor type and combined config.actor field in v3 YAML ... Two defects in ActorConfiguration._extract_v3_actor() prevented YAML files using the spec-canonical nested actors map format from being registered: Defect A: The method looked for the 'type' field inside the 'config:' block (config_block.get('type')) instead of at the actor-entry level (first_entry.get('type')). Because the spec places 'type' at actors.<name>.type — a sibling of 'config:', not a child of it — the v3 detection branch never fired for nested-actors-map YAMLs, causing _extract_v3_actor() to return (None, None, None, False) immediately. Defect B: Even if the type was found, the method only consulted separate config.provider and config.model keys; it never parsed the combined config.actor: 'provider/model' shorthand. Without the combined-field fallback, provider and model remained None for all spec-canonical YAMLs that use the shorthand, causing from_blob() to raise 'BadParameter: provider is required'. Both defects had to be fixed together because Defect A blocked the code from ever reaching the path where Defect B would otherwise have been encountered. The combined-format parser (config.actor split on first '/') is inserted after the explicit config.provider / config.model lookups so that explicit separate fields always take precedence over the shorthand when both are present. Parsing logic extracted into _parse_combined_actor_field() helper to eliminate DRY violation. Both provider and model halves validated consistently (empty provider half was previously silently inferred). Adds Behave scenarios covering: nested actors map + combined config.actor (success), explicit config.provider precedence over config.actor, explicit config.model precedence over config.actor, genuinely missing provider/model raising validation error, and malformed combined values (empty model half, empty provider half, missing delimiter). Adds a Robot integration test for the combined-actor YAML path with provider/model assertions via show. Restores accidentally deleted TOOL and GRAPH Robot integration tests. Mirrors provider/model extraction in step_run_actor_update for assertion step compatibility. ISSUES CLOSED: #11189	2026-05-14 08:10:58 +00:00
brent.edwards	d31d9226f9	test(wf10_batch.robot): request that LLM not create files (#11133) ... Closes: #11007 ## Description Asks LLM to not create files. ## Type of Change - [ X ] Bug fix (non-breaking change which fixes an issue) - [ X ] Test improvements ## Quality Checklist - [ ] Code follows the project's coding standards (see CONTRIBUTING.md) - [ ] All public/protected methods have argument validation - [ ] Static typing is complete (no `Any` unless justified) - [ ] `nox -s typecheck` passes with no errors - [ ] `nox -s lint` passes with no errors - [ ] Unit tests written/updated (Behave scenarios in `features/`) - [ ] Integration tests written/updated (Robot suites in `robot/`) if applicable - [ ] Coverage remains above 85% (`nox -s coverage_report`) - [ ] No security issues introduced (`nox -s security_scan`) - [ ] No dead code introduced (`nox -s dead_code`) - [ ] Documentation updated if behavior changed ## Testing Running in git.cleverthis.com is the only real test possible. ### Test Commands Run ```bash nox -s unit_tests # Behave tests nox -s typecheck # Type checking nox -s lint # Linting nox -s coverage_report # Coverage ``` ## Related Issues Closes #11007 Reviewed-on: #11133 Reviewed-by: Hamza Khyari <hamza.khyari@cleverthis.com>	2026-05-13 23:39:15 +00:00
hurui200320	9fe69c468c	test(plan): add tdd issue-capture test for cleanup_stale destroying execute output before apply ... Add two Behave scenarios tagged @tdd_issue, @tdd_issue_11121, and @tdd_expected_fail that capture bug #11121: _create_sandbox_for_plan() calls GitWorktreeSandbox.cleanup_stale() unconditionally on every execute invocation, including when the plan is already in execute/complete state awaiting apply. Scenario 1 asserts that the cleveragents/plan-<id> branch survives a second call to _create_sandbox_for_plan() on an execute/complete plan. This assertion fails because cleanup_stale deletes the branch regardless of plan state. Scenario 2 asserts that plan apply would find at least one artifact after a re-invoked execute on an execute/complete plan. This assertion fails because the branch (holding execute output) was destroyed by cleanup_stale. Both scenarios use @tdd_expected_fail so CI passes while the bug is unfixed. The @mock_only tag ensures no database is created for these git-only tests. The companion fix is tracked in issue #11121. Additional CI fixes bundled in this commit: - Fixed PlanGenerationGraph recursion bug: _should_retry() was mutating state in-place but LangGraph conditional edge functions cannot persist state mutations. Replaced with a proper _handle_retry() node that increments retry_count via state returns, resolving the GraphRecursionError that was crashing the integration tests. Updated the graph to include handle_retry as the 5th node, routing validate→should_retry→handle_retry→analyze. - Fixed TDD quality gate (scripts/tdd_quality_gate.py): Renamed @tdd_bug_N tags to @tdd_issue_N to match the CONTRIBUTING.md specification. Added _diff_is_tdd_issue_capture() detection so that TDD issue-capture PRs (which add @tdd_expected_fail rather than remove it) pass the quality gate correctly. Updated all related tests (Behave unit tests, Robot integration tests, and test helpers) to use the new tag naming. ISSUES CLOSED: #11120	2026-05-12 16:57:50 +08:00
hurui200320	d25a060c58	Revert "feat(ci): implement TDD bug tag quality gate for bug fix PRs" ... This reverts commit e8d2f76466.	2026-05-12 08:30:24 +00:00
hurui200320	b4a514e0f4	fix(cli): add spec-required --data-dir, --config-path, and -v global options to main_callback ... Implements ADR-021 §Global CLI Flags and ADR-024 §Resolution Chain. All three global options were missing from main_callback(), causing any invocation with these flags to crash with 'No such option'. Changes: - src/cleveragents/cli/main.py * Add _VERBOSITY_LOG_LEVELS tuple mapping verbose count to log levels (0=CRITICAL/silent, 1=ERROR, 2=WARNING, 3=INFO, 4=DEBUG, 5+=DEBUG) * Add --data-dir PATH option: validates path is a directory if it exists, sets CLEVERAGENTS_DATA_DIR env var, resets Settings singleton * Add --config-path PATH option: validates file exists and is a file, sets CLEVERAGENTS_CONFIG_PATH env var for ConfigService to pick up * Add -v (count=True) option: wires verbose count to configure_structlog * Store all three values in ctx.obj for subcommand access * Update _print_basic_help() to include the three new global options so 'cleveragents --help' (fast path) also lists them * In the catch-all Exception handler, print the original exception type+message directly to err_console so actionable details remain visible even when log level is CRITICAL (e.g. 'No such option') - src/cleveragents/application/services/config_service.py * ConfigService.__init__ now checks CLEVERAGENTS_CONFIG_PATH env var when no explicit config_path is passed, completing the resolution chain for --config-path CLI override Tests (all passing): - features/cli_global_options.feature (21 Behave scenarios) - features/steps/cli_global_options_steps.py - robot/cli_global_options.robot (8 Robot Framework integration tests) - robot/helper_cli_global_options.py Quality gates: lint ✓ typecheck ✓ unit_tests ✓ integration_tests ✓ Coverage: 96.52% (threshold 96.5% ✓) ISSUES CLOSED: #6785	2026-05-12 01:05:10 +00:00
CoreRasurae	e8d2f76466	feat(ci): implement TDD bug tag quality gate for bug fix PRs ... Add an automated quality gate that enforces TDD bug fix workflow rules on pull requests. The gate parses PR descriptions for bug-closing keywords (Closes/Fixes/Resolves #N, ISSUES CLOSED: #N), searches the codebase for corresponding TDD tests tagged @tdd_bug_N, and verifies that @tdd_expected_fail tags have been removed. Key components: - scripts/tdd_quality_gate.py: Main quality gate script with PR description parsing, TDD test discovery, and tag removal verification. All public functions validate arguments fail-fast and are statically typed. - noxfile.py: New tdd_quality_gate session that reads PR_DESCRIPTION from the environment and runs the quality gate script. - .forgejo/workflows/ci.yml: New tdd_quality_gate CI job that runs only on pull_request events, passing the PR body as PR_DESCRIPTION. - features/tdd_quality_gate.feature: 46 Behave scenarios covering PR parsing, TDD test search, tag removal verification, full gate logic, robot diff handling, edge cases, argument validation, bool guards, co-located bug false-positive guard, and main() CLI entry point. - features/steps/tdd_quality_gate_steps.py: Step definitions for all Behave scenarios using temporary directories for isolation. - robot/tdd_quality_gate.robot: 15 Robot Framework integration tests exercising the gate end-to-end via a helper subprocess. - robot/helper_tdd_quality_gate.py: Helper script for Robot tests with sentinel-based sub-commands. Review-round fixes applied: - check_expected_fail_removed now uses _contains_tag_token for word-boundary matching (avoids false positives on partial tag names) - Diff expected-fail removal detection tracks flags at file level instead of per-hunk (fixes false negatives when tags span hunks) - parse_bug_refs filters out issue number zero - Redundant double error reporting eliminated (file-level check short-circuits the diff-level check) - run_quality_gate returns (errors, bug_refs) tuple to avoid redundant re-parsing in main() - Regex compilation cached via functools.lru_cache - Nox session no longer installs the full project (stdlib only) - CI checkout uses fetch-depth: 0 for reliable merge-base resolution Review-round 2 fixes applied: - _diff_has_expected_fail_removal_for_bug now requires the removed line to contain both the expected-fail tag and the specific bug tag (fixes false positives when two bugs share the same test file) - check_expected_fail_removed error messages use the correct tag prefix per file type (@tdd_bug_N for .feature, tdd_bug_N for .robot) - bool values rejected by bug-number validation guards in find_tdd_tests, check_expected_fail_removed, and _diff_has_expected_fail_removal_for_bug - File-read error handling catches UnicodeDecodeError alongside OSError (root-safe unreadable-file handling via invalid-UTF-8 test fixture) - Temp directory cleanup added to after_scenario hook in environment.py - 8 new Behave scenarios: bool type guards (2), co-located bug false-positive regression (1), run_quality_gate argument validation (3), and main() CLI entry point exit codes (2) Review-round 3 fixes applied: - Synthetic PR diff helper (_default_pr_diff_for_bug_refs) now auto-detects .robot vs .feature file type from the temp search tree and generates the matching diff format (fixes under-tested robot-format diff code path in multi-bug integration scenarios) - check_expected_fail_removed test step now filters files by bug tag via find_tdd_tests before checking (matches production path in run_quality_gate) - after_scenario temp directory cleanup no longer sets context.temp_dir = None (fixes cleanup conflict with cli_init_yes_flag_steps.py cleanup functions that run after hooks) - 2 new Behave scenarios: multi-line PR description parsing, and non-string pr_diff type guard for run_quality_gate ISSUES CLOSED: #629	2026-05-12 00:22:49 +01:00
hurui200320	87a7ce35d7	feat(session): implement real LLM actor invocation in session tell ... Replace the M3 stub in `agents session tell` with real orchestrator actor invocation via `SessionWorkflow.tell()`. The stub echoed a canned `Acknowledged: ...` response without calling any LLM or actor; this commit wires up the full pipeline: Architecture: - New `SessionWorkflow` (Application layer) orchestrates LLM invocation for session tell. Accepts a `ProviderRegistry` and `ToolRegistry`; falls back to `FakeListLLM` when no provider is configured. - `LangChainSessionCaller` implements the `LLMCaller` protocol, building history-aware LangChain message lists from the session conversation and invoking the LLM via `ToolCallingRuntime.run_tool_loop()`. - `TellResult` (Pydantic BaseModel) carries the assistant response plus token usage (input_tokens, output_tokens, cost_usd, duration_ms). Domain / service layer: - `SessionActorNotConfiguredError` added to the session domain model; raised when tell is invoked with no actor on the session and no `--actor` override. Clear message; CLI exits with code 1. - `SessionService.get_messages()` abstract method added (+ implementation in `PersistentSessionService`) to load ordered message history. A2A facade: - `A2aLocalFacade` gains `message/send` and `message/stream` standard A2A operation handlers that route to `SessionWorkflow.tell()`. Total supported operations count: 42 → 44. CLI: - `session tell` command delegates to `_build_session_workflow()` (patchable factory) instead of directly calling `SessionService`. - Non-streaming: `SessionWorkflow.tell()` returns `TellResult`; output includes a Usage panel (Rich/Plain) or a `usage` object (JSON/YAML). - Streaming: `SessionWorkflow.tell_stream()` yields tokens; CLI prints them via `console.print` (not raw `sys.stdout.write`). - Token usage recorded via `SessionService.update_token_usage()` in both paths. Tests: - New Behave feature `session_tell_llm.feature` (4 scenarios): real LLM response persisted; streaming yields tokens; no-actor exits code 1; `--actor` override resolves correctly. - New Robot suite `session_tell_llm.robot` (4 tests): end-to-end with stub LLM injected via monkey-patching `_resolve_llm`. - Updated all existing `session tell` test steps to patch `_build_session_workflow` returning a mock `TellResult` so tests remain isolated from the LLM layer. - Updated operation-count assertions (42 → 44) in `a2a_cli_facade_integration`, `consolidated_misc`, `m6_autonomy_acceptance` feature files and steps. Cycle 7 (Review ID 8088) fixes: - Blocker 4: Split `session_workflow.py` (was 801 lines) into two files: `session_workflow.py` (467 lines) and `session_caller.py` (318 lines). Extracted: `LangChainSessionCaller`, `extract_content`, `extract_token_usage`, `estimate_cost`, `estimate_tokens`, `history_to_langchain_messages`, and stub classes. - Blocker 5: Route CLI streaming path through `_facade_dispatch("message/stream", ...)` instead of directly calling `workflow.tell_stream()`. The facade's `_handle_message_stream` falls back to non-streaming with `streamed: false` (acceptable for this milestone per the spec). - Updated streaming test assertion to validate full response presence (no longer checks token-by-token word positions, since the facade fallback returns a complete message). ISSUES CLOSED: #5784	2026-05-11 04:39:29 +00:00
CoreRasurae	78be08870c	fix(cli): validate actor provider field at correct config nesting level ... - Actor configuration in V3 is now obtained from the nested configuration parameter, according to the specification. - Removed the legacy V2 fallback support and the tests affected by that removal. Mocked existing steps to allow remaining V2 features to be covered/tested. - Fix add() to pass unsafe flag to add_v3() for proper unsafe actor handling - Add _extract_nested_v3_config() to extract provider/model from nested actors.<name>.config block before v3 schema validation - Remove v2 extraction test scenarios from consolidated_actor.feature that call removed _extract_v2_actor() and _extract_v2_options() methods - Update test YAML in actor_registry_spec_yaml_steps.py to exercise nested type detection (no top-level type field) - Add @tdd_issue_4300 regression test tag to existing spec-compliant actors map scenario ISSUES CLOSED: #4300	2026-05-09 23:13:33 +01:00
HAL9000	6e1646d565	fix(plan): wrap plan tree JSON/YAML output in spec-required command envelope.\n\nISSUES CLOSED: #9163 ... # Conflicts: # CONTRIBUTORS.md	2026-05-09 12:23:24 +00:00
HAL9000	b588de18d6	fix(tui): rebase onto master and add CHANGELOG entry for prompt symbol fix (#6431) ... Rebases the TUI prompt symbol fix onto the latest master, resolving conflicts with the TextArea→Input refactor and the dollar-prefix shell mode addition. Adds the missing CHANGELOG.md entry for #6431 and removes the now-obsolete tui_prompt_textarea feature/steps that tested the old TextArea-based implementation. ISSUES CLOSED: #6431	2026-05-08 11:15:36 +00:00
Luis Mendes	15e72b8407	fix(events): log full exception details in ReactiveEventBus.emit() error handler ... Add exc_info=True to the _logger.warning() call in the per-handler exception block of ReactiveEventBus.emit(). The handler already logged error=str(exc) (the exception message text), but omitted the traceback. With exc_info=True structlog now forwards the full traceback to the configured log output, giving developers the diagnostic detail needed to debug subscriber failures in production. Remove the @tdd_expected_fail tag from the traceback scenario in features/tdd_event_bus_exception_swallow.feature so that both TDD scenarios (#988) run as normal regression guards. Fix TDD tags in robot/tdd_e2e_implicit_init.robot: replace incorrect tdd_bug/tdd_bug_1023 tags with the canonical tdd_issue/tdd_issue_1023/ tdd_expected_fail tags so the tdd_expected_fail_listener properly inverts results while bug #1023 remains open. ISSUES CLOSED: #988	2026-05-07 23:39:08 +01:00
hurui200320	bef7f3175b	fix(tests): resolve integration test failures in behave parallel log filtering ... Fix the integration test helper so that it can load scripts/run_behave_parallel.py outside of nox sessions. The helper imports the runner module via importlib, which triggers the top-level from behave_pass_suppress_formatter import PassSuppressFormatter. When invoked from integration tests (or any non-nox context), neither behave_pass_suppress_formatter nor the behave_parallel package (created by noxfile.py for unit_tests) is on sys.path, causing a ModuleNotFoundError and all 6 Robot tests to fail with exit code 1. The fix adds scripts/ to sys.path before loading the runner module so that from behave_pass_suppress_formatter import PassSuppressFormatter resolves correctly. This mirrors the approach already used in noxfile.py's unit_tests session for the behave-parallel package. Also addresses review feedback: - Removes one blank line from scripts/run_behave_parallel.py to bring it to 499 lines, satisfying the project's <500-line code style rule. - Moves in-function behave imports (Configuration, StreamOpener) in features/steps/behave_parallel_log_filtering_steps.py to the top-level import block alongside the existing behave imports, complying with the project's rule that all imports must be at the top of the file. Refs: #10987	2026-05-07 18:09:26 +08:00
HAL9000	5db663cb63	fix(actor): read actor_ref from NodeDefinition field in _detect_subgraph_cycles ... Fix cross-actor subgraph cycle detection in the actor compiler by reading actor_ref from the top-level NodeDefinition field instead of the config dict. The _detect_subgraph_cycles(), _map_node(), and compile_actor() functions were all reading node.config.get("actor_ref", "") instead of node.actor_ref. Because actor_ref is a typed, validated Pydantic field on NodeDefinition (not a key inside the untyped config dict), the old code always returned an empty string, causing cross-actor cycle detection to silently fail and leaving the system vulnerable to infinite recursion at runtime. Changes: - Fix all three call sites in src/cleveragents/actor/compiler.py - Add Behave regression tests (features/actor_subgraph_cycle_detection.feature) with @tdd_issue and @tdd_issue_1431 tags on all scenarios - Add Robot Framework integration test (robot/actor_compiler.robot) - Fix existing test helpers to use actor_ref as top-level field - Add CHANGELOG entry ISSUES CLOSED: #1431	2026-05-06 04:08:25 +00:00
HAL9000	ad31e75af6	fix(cli): address reviewer feedback on actor remove --format option ... - Validate --format argument before any side effects; raise typer.BadParameter with a clear message for unsupported format values (fail-fast principle) - Pass normalised fmt_value (lowercased) to format_output instead of raw fmt to ensure consistent behaviour regardless of input casing - Rewrite robot/helper_actor_remove_cli.py to exercise the real CLI end-to-end via subprocess (no mocking); seeds a test actor via agents actor add, then removes it with --format json and validates the JSON envelope ISSUES CLOSED: #6491	2026-05-06 01:07:15 +00:00
HAL9000	8384f53e28	test(cli): cover actor remove format regression (#6491) ... Add Robot regression coverage for `actor remove --format json`, document the flag in the CLI synopsis, and record the fix in the changelog.\n\nISSUES CLOSED: #6491	2026-05-06 01:07:15 +00:00
HAL9000	988a169831	docs: add InvariantReconciliationActor API docs, devcontainer discovery module guide, and mkdocs nav ... - docs/api/actor.md: Add InvariantReconciliationActor section documenting the built-in reconciliation actor introduced in v3.8.0, including the reconciliation algorithm, ReconciliationResult/ConflictRecord/ScopeInvariants data classes, standalone reconcile_invariants() function, DI registration, and failure behaviour. - docs/modules/devcontainer-discovery.md: New module guide for the devcontainer auto-discovery system (v3.8.0 fix #2615), covering DevcontainerDiscoveryResult, discover_devcontainers(), is_trigger_type(), monorepo named-config support, and gotchas. - mkdocs.yml: Add 'Devcontainer Auto-Discovery' to the Modules nav section, alongside shell-safety, uko-provenance, invariant-reconciliation, context-hydration, and git-worktree-sandbox module docs. - robot/coverage_threshold.robot: Add tdd_issue and tdd_issue_4305 tags to the Noxfile Contains Coverage Threshold Constant test case. ISSUES CLOSED: #4485	2026-05-05 06:15:57 +00:00
CoreRasurae	cecca72b8e	test(behave): Reduce the coverage level to 96.5%	2026-05-05 02:01:49 +00:00
CoreRasurae	cc24d8c8ac	fix(cli): remove legacy plan commands from help output ... Completely removed all legacy plan commands from the CLI: - Removed tell, build, new, current, cd, continue CLI commands - Removed programmatic wrapper functions (tell_command, build_command, etc.) - Removed legacy deprecation message - Updated help text to indicate V3 Plan Lifecycle exclusively - Removed stale references to tell/build in help output and command validation Removes the legacy 'tell' and 'build' CLI shortcuts from main.py: - Removed echo lines advertising tell/build commands - Removed tell/build from valid_cmds list - Removed tell/build from _LIGHTWEIGHT_COMMANDS frozenset - These dead entries were preventing helpful error messages Test infrastructure improvements: - Event bus exception test: Patch the module-level logger during emit() so that structlog.testing.capture_logs() can capture the logs. Without patching, the module-level logger created at import time is not captured by the context manager. - Session create/list commands: Suppress cleveragents.mcp logger to CRITICAL level during JSON/YAML output formatting to prevent health check warnings with ANSI codes from being written to stdout before JSON output, which breaks JSON parsing. - Extended plan_cli_coverage_boost with scenarios for estimation_result, invariants, execution_environment, validation_summary, and checkpoint coverage in _plan_spec_dict Documentation: - Created docs/Legacy_to_V3_Guide.md with comprehensive migration instructions - Updated CONTRIBUTING.md to document removal of legacy workflow - Updated CHANGELOG.md to reference issue #4181 instead of PR #10800 ISSUES CLOSED: #4181	2026-05-05 02:01:49 +00:00
brent.edwards	57930c9fb3	fix(wf10): fixing more of the add/add problems ... Closes #10861	2026-05-05 00:38:44 +00:00
brent.edwards	e249afa30e	fix(wf10_batch): fix add/add conflict ... Closes: #10861	2026-05-04 15:54:22 -07:00
HAL9000	e6878c2c30	fix(audit): protect AuditService._ensure_session() with threading.Lock	2026-05-02 21:54:17 +00:00
HAL9000	3e85ff797d	chore(deps): remove duplicate langchain-anthropic dependency and clean up stale backup file ... - Remove duplicate langchain-anthropic>=0.2.0 from pyproject.toml dependencies - Remove stale robot/core_cli_commands.robot.backup file (not covered by gitignore) This cleanup eliminates a duplicate dependency declaration and removes an untracked backup file from the testing directory. ISSUES CLOSED: #0	2026-05-02 21:21:01 +00:00
HAL9000	9b9bb80e05	fix(container): remove devcontainer-file from CONTAINER_RESOURCE_TYPES ... devcontainer-file is a read-only config file resource, not a running container. Including it in CONTAINER_RESOURCE_TYPES causes validate_container_available() to return True when only a config file is linked, even though no actual container is available. Closes #10598	2026-05-02 01:36:45 +00:00
HAL9000	80bc9c552d	test: restore and enhance e2e test coverage ... Fix malformed imports in helper_m1_e2e_verification.py and helper_m4_e2e_cli.py where 'from helpers_common import reset_global_state' was incorrectly inserted inside a parenthesized import block, causing Python syntax errors and breaking the lint and unit_tests CI gates. Also fix import ordering in helper_m2_e2e_verification.py, helper_m5_e2e_context.py, helper_m5_e2e_support.py, and helper_m5_e2e_verification.py to satisfy ruff I001 import-sort rules by placing helpers_common imports in the correct group alongside other local robot/ helper imports. ISSUES CLOSED: #8459	2026-05-01 00:59:02 +00:00
HAL9000	7aa50ac489	fix(e2e): restore M5/WF14 tests broken by JSON envelope and stale config ... - Add NO_COLOR=1 to E2E Suite Setup and Test Environment to prevent Rich from injecting ANSI escape codes into JSON output, which breaks Extract JSON From Stdout and JSON assertions in M5/WF14 acceptance tests. - Add reset_global_state() calls to all M1/M2/M4/M5 E2E verification helpers to clear Settings singleton, DI container, provider registry, and SQLAlchemy engine cache between parallel pabot worker runs. - Propagate NO_COLOR=1 at suite-setup level in E2E and integration test resource files so all Run Process subprocesses inherit clean terminal output mode. Root causes: 1. Missing NO_COLOR=1 caused Rich ANSI codes in CLI JSON output, making json.loads() failures in robot Extract JSON From Stdout 2. Stale Settings singleton carried provider keys and DB paths between pabot workers, causing UNIQUE constraint violations and stale config lookups in context policy and server mode E2E tests. Related: PR #9912	2026-05-01 00:59:02 +00:00
HAL9000	90b6b2a43f	fix(tui): fix Throbber Rejects Invalid Styles test indentation and add CHANGELOG entry ... Use Fix Python Indentation + temp file in robot/tui_throbber.robot to correctly reconstruct indentation stripped by Robot Framework's Catenate keyword in the Throbber Rejects Invalid Styles test case. Add indentation_library.py to the suite's Library imports. Add CHANGELOG.md fix entry for #6357. ISSUES CLOSED: #6357	2026-04-30 20:52:27 +00:00