1131 Commits

Author	SHA1	Message	Date
HAL9000	62c11edb4a	fix(resource): add create_sandbox/project_access stubs and fix ambiguous step ... - Add create_sandbox() override to _ContainerBaseHandler raising NotImplementedError, matching CloudResourceHandler pattern (issue #836) - Add project_access() override to _ContainerBaseHandler raising NotImplementedError, consistent with all other stub methods - Rename @then("the import should succeed without errors") step to @then("the container handler module import should succeed without errors") to resolve AmbiguousStep collision with tdd_a2a_sdk_dependency_steps.py - Update container_handler.feature to use renamed step - Apply ruff format to container.py ISSUES CLOSED: #2907	2026-05-30 13:08:44 -04:00
freemo	4288fcb9c1	fix(resource): implement missing container handler module for container infrastructure resource types ... Implements the missing cleveragents.resource.handlers.container module that is referenced by all seven container infrastructure resource types registered in _resource_registry_container.py. Previously, any attempt to use container-runtime, container-image, container-mount, container-exec-env, container-port, container-volume, or container-network resources raised HandlerResolutionError with ModuleNotFoundError at runtime. Changes: - Add src/cleveragents/resource/handlers/container.py with five handler classes: ContainerRuntimeHandler, ContainerImageHandler, ContainerChildHandler (shared by mount/exec-env/port), ContainerVolumeHandler, ContainerNetworkHandler - All handlers extend _ContainerBaseHandler which extends BaseResourceHandler and satisfies the ResourceHandler protocol - resolve() raises NotImplementedError (container sandbox provisioning is pending, mirrors CloudResourceHandler pattern) - content_hash() returns identity hash based on resource type + location - All CRUD and lifecycle stubs raise NotImplementedError - Update handlers/__init__.py to export the five new handler classes - Add features/container_handler.feature with 72 BDD scenarios covering module importability, protocol conformance, handler resolution, type labels, CRUD stubs, lifecycle stubs, and registry integration - Add features/steps/container_handler_steps.py with step definitions All nox sessions pass: lint, typecheck, unit_tests (72/72 scenarios). ISSUES CLOSED: #2907	2026-05-30 13:08:44 -04:00
HAL9000	d0fd9319d3	fix(tests): add BDD scenarios for rich/color formats with list data to restore coverage ... Cover the list branches in _format_rich() and _format_color() that were left untested, causing the coverage gate to drop below the 97% threshold. Add two new @when steps (list+rich, list+color), two @then steps for list panel assertions, and two new feature scenarios exercising those paths. ISSUES CLOSED: #2921	2026-05-30 11:45:16 -04:00
HAL9000	a726b96d26	fix(cli): address reviewer feedback on format_output rich/color fix ... - Move function-level imports to module top level in formatting.py: * Remove redundant OutputSession import inside _format_rich() * Remove redundant OutputSession import inside _format_color() * Move `import sys` from inside format_output() to module level - Fix robot/helper_cli_formats.py: * Remove redundant `import json as _json` inside format_output_rich(); use the top-level `json` module directly * Replace non-deterministic datetime.now() calls in _mock_action() and _mock_plan() with fixed datetime(2025, 1, 15, 10, 0, 0) - Split cli_output_formats_steps.py to comply with 500-line limit: * Extract all @then step definitions into new file features/steps/cli_output_format_validation_steps.py * Behave auto-discovers steps from any .py file in steps/ ISSUES CLOSED: #2921	2026-05-30 11:09:06 -04:00
freemo	6e47abbd63	fix(cli): fix format_output() to use rich and color renderers instead of JSON fallback ... The format_output() function in src/cleveragents/cli/formatting.py had two routing bugs that caused incorrect output for the 'rich' and 'color' formats: 1. The 'rich' format had no explicit dispatch branch and silently fell through to the final JSON fallback, returning raw JSON instead of styled terminal output. Since 'rich' is the default CLI format (per ADR-021), this meant all commands using format_output() (version, info, diagnostics) produced JSON by default. 2. The 'color' format was incorrectly routed to _format_plain() instead of a color-aware renderer, producing plain text with no ANSI color codes. Fix: - Added _format_rich() helper that delegates to RichMaterializer via OutputSession, producing ANSI-styled terminal output consistent with format_output_session(). - Added _format_color() helper that delegates to ColorMaterializer via OutputSession, producing ANSI-colored terminal output. - Added explicit OutputFormat.RICH dispatch in format_output() routing. - Fixed OutputFormat.COLOR dispatch to use _format_color() instead of _format_plain(). Tests: - Updated existing BDD scenario that was validating the buggy behavior (expected JSON for rich format) to now assert correct styled output. - Added new BDD scenarios: 'rich format produces styled terminal output not JSON' and 'color format produces ANSI-colored output not plain text'. - Added Robot Framework integration tests in cli_formats.robot and helper_cli_formats.py verifying end-to-end styled output for both formats. All nox sessions pass: lint, typecheck, unit_tests, security_scan. ISSUES CLOSED: #2921	2026-05-30 11:09:06 -04:00
HAL9000	1970fae07b	style: apply ruff format to legacy_migrator_steps.py ... Fix formatting to satisfy ruff format --check CI gate.	2026-05-30 10:38:39 -04:00
freemo	1d18aa80ca	fix(database): replace type: ignore with assert for type narrowing in LegacyDataMigrator ... Remove the unsafe `# type: ignore` suppression on line 111 of `legacy_migrator.py` and replace it with an explicit `assert existing_plan.id is not None` statement. This provides proper type narrowing to the type checker while preserving the logical correctness guaranteed by the preceding `if existing_plan:` guard. Also adds a new BDD scenario in `legacy_migrator_coverage.feature` that explicitly exercises the code path where an existing plan with a non-None id is found during migration, verifying the assert-based type narrowing works correctly end-to-end. ISSUES CLOSED: #3051	2026-05-30 10:38:39 -04:00
freemo	f2232eec09	fix(acms): align SkeletonCompressorService.compress() with SkeletonCompressor protocol ... - Updated SkeletonCompressorService.compress() to accept (fragments: tuple[ContextFragment, ...], skeleton_budget: int) -> tuple[ContextFragment, ...], matching the SkeletonCompressor protocol - Removed skeleton_ratio and CompressionResult from the public API - Added @runtime_checkable to SkeletonCompressor protocol in acms_service.py - Added structural subtype assertion at module level to prevent future protocol drift - Rewrote all Behave feature scenarios and step definitions to use skeleton_budget - Updated benchmarks and robot helpers to use absolute token budgets - Removed CompressionResult export from services __init__.py and vulture_whitelist.py - The depth_breadth_projection.py call site already correctly computed and passed skeleton_budget ISSUES CLOSED: #2925	2026-05-30 08:29:22 -04:00
HAL9000	cce6cfb119	fix(skill): handle skill: wrapper key in agents skill add YAML config ... Implement skill: wrapper key unwrapping in SkillConfigSchema.from_yaml() to support the spec-required YAML format with cleveragents: metadata header. - Strip cleveragents: metadata block from raw YAML before validation - Unwrap skill: wrapper key if present, with descriptive errors for invalid values - Maintain backward compatibility with flat YAML format (no wrapper) - Add Behave scenarios tagged @tdd_issue and @tdd_issue_1472 covering: * Spec-compliant YAML with skill: wrapper key * Spec-compliant YAML with cleveragents: header * skill: with None, string, and list values (error cases) * Backward compatibility with flat YAML * cleveragents: header without skill: wrapper Closes #1472	2026-05-30 04:04:21 -04:00
HAL9000	b65f0db8d0	fix(cli): add Read-Only and Writes columns to tool list output ... - Apply ruff format to tool.py (flatten single-line namespaces.add call) - Add Behave BDD tests verifying 5-column table, capability rendering (checkmark/dash), and Summary panel presence - Add CHANGELOG.md entry ISSUES CLOSED: #1476	2026-05-30 03:33:08 -04:00
HAL9000	1295dea0ac	fix(tui): PermissionsScreen diff mode cycle uses split/auto per spec #1449 ... Changed DiffDisplayMode enum values from side_by_side/context to split/auto as required by specification §29570, §30139, §30391. - Renamed SIDE_BY_SIDE="side_by_side" → SPLIT="split" in models.py - Renamed CONTEXT="context" → AUTO="auto" in models.py - Renamed side_by_side_diff() → split_diff() in models.py - Renamed context_diff() → auto_diff() in models.py - Updated _DIFF_MODE_CYCLE in screen.py to use SPLIT and AUTO - Updated all BDD feature scenarios and step definitions - Fixed broken Behave step parameter renames (restored standard 'context' param) Closes #1449 --- Automated by CleverAgents Bot Supervisor: Implementation | Agent: task-implementor	2026-05-30 02:34:32 -04:00
HAL9000	9f4f4e063e	fix(tui): PermissionsScreen diff mode cycle uses split/auto per spec #1449 ... Updated step definitions to match the corrected enum values (SPLIT and AUTO instead of SIDE_BY_SIDE and CONTEXT) and updated method names (split_diff instead of side_by_side_diff). ISSUES CLOSED: #1449	2026-05-30 02:34:32 -04:00
HAL9000	02e51b9298	fix(actor): fix lint errors and add regression tests for lsp_binding field (#1432) ... - Remove trailing whitespace from blank lines in _extract_lsp_bindings() (W293 at lines 160, 164, 167, 172, 183, 188, 203) - Simplify over-long line 180 (E501): auto_detect=node.lsp_binding.auto - Add Behave scenario verifying NodeLspBinding typed field populates CompilationMetadata.lsp_bindings (features/actor_lsp_binding_field.feature) - Add corresponding @given step using NodeLspBinding in actor_compiler_steps.py - Add Robot Framework regression test case and lsp-binding-field helper command confirming node.lsp_binding is read by compile_actor() - Update CHANGELOG.md and CONTRIBUTORS.md ISSUES CLOSED: #1432	2026-05-30 00:36:20 -04:00
HAL9000	8ed8750160	fix(audit): forward DomainEvent.timestamp to AuditService.record() ... AuditService.record() was generating its own timestamp internally, discarding the original DomainEvent.timestamp. This means audit entries recorded when an event was audited, not when the domain event actually occurred, breaking forensic accuracy per §Audit Logging (SEC7). Changes: - Add `timestamp: datetime | None = None` keyword parameter to AuditService.record(). When provided, uses it as created_at; falls back to datetime.now(tz=UTC) for backward compatibility. Applied to both the async queue path and the synchronous DB path. - AuditEventSubscriber._handle_event() now passes timestamp=event.timestamp so the original event creation time is preserved in audit entries. - Add 3 Behave BDD scenarios covering: full pipeline timestamp preservation, direct record() with explicit timestamp, and backward compatibility (record() without timestamp auto-generates created_at). - Add preserve_event_timestamp Robot integration test and helper subcommand. - Add static source check in security_audit.robot verifying the timestamp parameter signature exists. ISSUES CLOSED: #719	2026-05-29 16:36:39 -04:00
HAL9000	6a76ea894d	test(cli): add TDD regression tests for automation_profile._get_service() DI bypass ... Three BDD scenarios and two Robot Framework integration tests verifying that _get_service() in automation_profile.py resolves AutomationProfileService through the DI container rather than manually calling create_engine or sessionmaker (bug #990). Bug #990 was fixed by PR #1181 before this TDD test PR merged; the @tdd_expected_fail tag is therefore absent and these tests serve as permanent regression guards confirming the fix remains in place. ISSUES CLOSED: #1031	2026-05-29 15:26:47 -04:00
HAL9000	6c684d920f	test(a2a): cover facade DI fallbacks and message/send validation ... Add 5 BDD scenarios to features/a2a_facade_coverage_boost.feature that exercise previously uncovered paths in src/cleveragents/a2a/facade.py: - _handle_message_send raises ValueError on empty session_id (line 469) - _handle_message_send raises ValueError on empty message (line 471) - _build_actor_resolver_for_session_workflow exception fallback (411-425) - _build_actor_options_resolver_for_session_workflow exception fallback (434-452) - _provider_registry property read (line 160) Pushes overall coverage past the 96.5% slipcover --fail-under threshold that the CI / coverage gate enforces; the prior run was 96.4%.	2026-05-29 08:41:06 -04:00
HAL9000	c77f90b4ff	fix(sync): add missing coverage scenarios and remove dead _iso_now from sync_models ... - Remove unused _iso_now() from sync_models.py (dead code: called nowhere in the module; sync_service.py has its own _iso_now()) - Remove now-unused `from datetime import UTC, datetime` import - Add 5 new BDD scenarios covering previously uncovered code paths: - VectorClock.happens_before() TypeError guard (sync_models.py:134-135) - VectorClock.is_concurrent() TypeError guard (sync_models.py:159-160) - process_offline_queue() PULL direction branch (sync_service.py:468-475) - resolve_conflict() last_writer_wins when server entity is newer (sync_service.py:549 else) - SyncService.push() with CLIENT_WINS resolution (_resolve_conflict lines 663-665) - Add corresponding step implementations for the new scenarios ISSUES CLOSED: #1125	2026-05-29 07:21:08 -04:00
cleveragents-auto	ee1ec2b56d	chore: worker ruff auto-fix (pre-push lint gate)	2026-05-29 07:21:08 -04:00
HAL9000	5ede1c018a	fix(server,sync): use A2aRequest.method not .operation in tests and helpers ... The new entity-sync feature introduced A2aRequest with a `method` field (JSON-RPC 2.0 wire format), but several test/helper files used the wrong field name `operation` when constructing requests or logging, and checked non-existent `.status`/`.data` attributes on A2aResponse instead of `.result`/`.error`. Fixes: - asgi_app.py: log `a2a_request.method`, not `.operation` (typecheck error) - server_lifecycle_steps.py: send `method` key in JSON-RPC payload; look up status in `result` dict, not top-level response body - server_lifecycle.feature: expect "healthy" (what the handler returns), not "ok" - entity_sync_steps.py: construct A2aRequest(method=...) not (operation=...); assert on .result/.error instead of .status/.data - robot/helper_entity_sync.py: same method= and result/error fixes across sync_pull, sync_push, sync_status, sync_facade_no_service helpers - robot/helper_server_lifecycle.py: same method= and result path fixes ISSUES CLOSED: #1125	2026-05-29 07:21:08 -04:00
freemo	ff9c6540a2	feat(server): entity sync (_cleveragents/sync/*) ... Implement entity synchronization between client and server using the _cleveragents/sync/* A2A extension methods per the specification. Sync models (src/cleveragents/a2a/sync_models.py): - Pydantic v2 models for pull/push/status requests and responses - VectorClock with increment, merge, happens-before, and concurrency detection for distributed conflict detection - SyncEntitySnapshot, SyncConflict, SyncState, SyncQueueEntry models - SyncEntityType enum: actor, skill, action, plan, session - ConflictResolution enum: last_writer_wins, manual, server_wins, client_wins SyncService (src/cleveragents/application/services/sync_service.py): - pull(): download server namespace entities to local cache with incremental sync (since timestamps) and force-overwrite option - push(): push local entity definitions to server namespace with configurable conflict resolution strategy - status(): compare local and server entity versions, detect drift, report local-ahead, server-ahead, and concurrent conflicts - resolve_conflict(): manually resolve detected conflicts with winner selection (local or server) - Offline queue: enqueue_offline() and process_offline_queue() for retry on reconnect, with max-retries enforcement - The local/ namespace is never synced per specification A2A facade (src/cleveragents/a2a/facade.py): - Replaced sync stub handlers with real _handle_sync_pull, _handle_sync_push, _handle_sync_status routing to SyncService - Added sync_service property and TYPE_CHECKING import - Facade returns stubs when no SyncService is registered Tests: - Behave BDD: features/entity_sync.feature (65 scenarios, 247 steps) covering models, vector clocks, pull/push/status, conflict resolution, offline queue, facade integration, constructor validation, edge cases - Robot Framework: robot/entity_sync.robot (8 integration tests) ISSUES CLOSED: #866	2026-05-29 07:21:08 -04:00
HAL9000	c690ae12ad	fix(server): return JSON-RPC -32700 on non-JSON request body ... Wrap `await request.json()` in its own try-except for `json.JSONDecodeError` so malformed/non-JSON request bodies yield HTTP 400 with JSON-RPC error code -32700 (Parse error) instead of propagating unhandled to FastAPI's ServerErrorMiddleware and returning HTTP 500. Update the BDD step `step_post_a2a_malformed` to send actual raw non-JSON bytes (`content=b"not-valid-json"`) so the scenario exercises the JSON parse failure path rather than the existing A2aRequest validation path (-32600). ISSUES CLOSED: #863	2026-05-29 05:08:08 -04:00
freemo	08868e1e55	test: boost coverage for server lifecycle and team collaboration ... Add Behave BDD scenarios covering: - ServerLifecycle.start() with mocked uvicorn (full lifecycle) - run_server() convenience function with Settings defaults and overrides - Signal handler installation and non-main-thread edge case - TeamCollaborationService validation edge cases (empty args) - SessionRegistry validation edge cases and get_active_sessions - VersionConflictError negative version validation - Untracked resource version stamp creation path These tests cover previously uncovered validation branches and the server lifecycle start/shutdown paths to maintain >=97% coverage.	2026-05-29 05:08:08 -04:00
freemo	32b9e43cc3	fix: rename cls to klass in _validate_protocol staticmethod for pyright compliance	2026-05-29 05:08:08 -04:00
freemo	b5f56a6fb8	feat(server): team collaboration features ... Implemented multi-user connection handling with user identity tracking (TeamMember with owner/admin/member/viewer roles), role-based access control (TeamPermission with read/write/admin/manage_members), concurrent session support (SessionRegistry with thread-safe locking and per-user/ per-project queries), and optimistic-locking conflict resolution (VersionStamp with last-writer-wins, reject, and merge strategies). Added TeamCollaborationService as the central orchestrator for all collaboration operations: team membership management, permission enforcement, session lifecycle, and version-stamp conflict detection/ resolution. The service cleans up user sessions when members are removed. Domain models follow existing patterns: Pydantic BaseModel with ConfigDict, StrEnum enums, ULID identifiers, and an error hierarchy rooted in TeamCollaborationError. Includes 48 Behave BDD scenarios (178 steps) covering all models, service operations, and edge cases, plus 15 Robot Framework integration tests for end-to-end workflow validation. ISSUES CLOSED: #863	2026-05-29 05:08:08 -04:00
freemo	c6ccb85bb8	feat(server): ASGI endpoint via uvicorn ... Implement FastAPI-based ASGI application served by uvicorn for the CleverAgents server mode. Add health check endpoint, A2A JSON-RPC routing, configurable host:port binding, and graceful shutdown handling. Server launches via `agents server start`. - Add FastAPI ASGI app factory at infrastructure/server/asgi_app.py with /.well-known/agent.json (Agent Card), /health (liveness), and /a2a (A2A JSON-RPC 2.0 dispatch via A2aLocalFacade) - Add ServerLifecycle class at infrastructure/server/server_lifecycle.py wrapping uvicorn.Server with SIGTERM/SIGINT graceful shutdown - Add `agents server start` CLI command with --host, --port, --log-level options, resolving defaults from Settings - Add fastapi>=0.115.0 dependency to pyproject.toml (uvicorn already present) - Add Behave BDD tests (features/server_lifecycle.feature, 20 scenarios) - Add Robot Framework integration tests (robot/server_lifecycle.robot) - Update CHANGELOG.md and vulture_whitelist.py ISSUES CLOSED: #862	2026-05-29 05:08:08 -04:00
HAL9000	4a8ede3fb4	fix(tests): resolve ambiguous Behave step by using context.last_error ... Remove duplicate @then step from uow_coverage_boost_steps.py that conflicted with actor_config_steps.py:168. Both patterns matched 'a ValueError should be raised containing "{...}"' but used different capture-variable names, triggering AmbiguousStep at import time. Update the four When steps to store the caught exception in context.last_error so the existing actor_config_steps assertion handles the Then clause. ISSUES CLOSED: #878	2026-05-29 04:24:27 -04:00
HAL9000	7536830f85	test(postgresql): add BDD coverage for UoW validation, dispose, context manager and is_postgresql ValueError ... Cover previously-uncovered code paths added in the PostgreSQL backend PR: - UnitOfWork argument validation (empty URL, pool_size=0, max_overflow=-1, pool_recycle=-2) - dispose() with active engine (True branch) and without engine (False branch) - __enter__/__exit__ context manager protocol - psycopg2 ImportError path when psycopg2 is unavailable - settings.is_postgresql() except ValueError branch (server_mode + SQLite URL) ISSUES CLOSED: #1118	2026-05-29 03:59:05 -04:00
HAL9000	8dde6c81ef	feat(server): implement PostgreSQL storage backend for server mode ... Add PostgreSQL support as the server-mode storage backend alongside existing SQLite for local mode. Verify all ORM models are dialect- agnostic, configure connection pooling for multi-user access, add Docker Compose for local PG development, and wire database URL selection based on deployment mode. Changes: - Add psycopg2-binary dependency to pyproject.toml - Add server_mode, db_pool_size, db_max_overflow, db_pool_recycle settings to Settings with environment variable support - Add resolve_database_url() and is_postgresql() to Settings for mode-aware database URL resolution - Configure UnitOfWork engine creation with pool_size, max_overflow, pool_recycle, and pool_pre_ping for PostgreSQL connections - Update MigrationRunner to handle both SQLite and PostgreSQL backends - Add compare_type=True to Alembic env.py for dialect-aware migrations - Add docker-compose.yml with PostgreSQL 16-alpine for local development - Add Behave BDD feature (14 scenarios) covering settings, pool config, engine creation, ORM dialect compatibility, and migration runner - Add Robot Framework integration tests (12 test cases) for the abstraction layer with requires_postgresql tag for live PG tests Fixes: - Restore require_confirmation parameter to UnitOfWork.__init__ - Add argument validation to UnitOfWork.__init__ (fail-fast) - Add explicit PostgreSQL isolation_level (READ COMMITTED) - Add dispose() method and context manager support to UnitOfWork - Fix MigrationRunner.get_current_revision() to dispose engine - Fix Settings.is_postgresql() to handle ValueError gracefully ISSUES CLOSED: #878	2026-05-29 01:04:59 -04:00
freemo	6aaf69e0a4	feat(server): implement PostgreSQL storage backend for server mode ... Add PostgreSQL support as the server-mode storage backend alongside existing SQLite for local mode. Verify all ORM models are dialect- agnostic, configure connection pooling for multi-user access, add Docker Compose for local PG development, and wire database URL selection based on deployment mode. Changes: - Add psycopg2-binary dependency to pyproject.toml - Add server_mode, db_pool_size, db_max_overflow, db_pool_recycle settings to Settings with environment variable support - Add resolve_database_url() and is_postgresql() to Settings for mode-aware database URL resolution - Configure UnitOfWork engine creation with pool_size, max_overflow, pool_recycle, and pool_pre_ping for PostgreSQL connections - Update MigrationRunner to handle both SQLite and PostgreSQL backends - Add compare_type=True to Alembic env.py for dialect-aware migrations - Add docker-compose.yml with PostgreSQL 16-alpine for local development - Add Behave BDD feature (14 scenarios) covering settings, pool config, engine creation, ORM dialect compatibility, and migration runner - Add Robot Framework integration tests (12 test cases) for the abstraction layer with requires_postgresql tag for live PG tests ISSUES CLOSED: #878	2026-05-29 01:00:08 -04:00
HAL9000	aecbaa00f6	fix(actor): resolve CI failures for config-actor format PR ... Lint (ruff): - schema.py: import `cast`, replace non-breaking hyphens, inline SIM103 return, wrap long is_nested_v3 line - config.py: replace `if k in d: del d[k]` with `pop`, collapse nested ifs (SIM102) - format both reformatted-only files (ruff format) Typecheck (pyright): - config.py: guard `actor_type.lower()` calls with isinstance checks so the None branch is type-safe Unit tests (behave): - Remove duplicate `@then('v3actor the command ...')` and `@then('the actor should be registered with type ...')` registrations that crashed step-registry with AmbiguousStep — shared versions live in actor_add_v3_schema_validation_steps.py - Add missing Actor import; drop unused ActorConfiguration / is_v3_yaml imports and unused provider/model locals - Populate `context.registered_actor_type` from the upsert call args so the shared assertion step works for combined-format scenarios - Add a `@when("I run the actor add command without a name argument")` step that exercises the CLI's "Actor name is required" validation path (the previously-active step always supplied a name, masking the scenario's intent) ISSUES CLOSED: #11189	2026-05-28 20:47:07 -04:00
freemo	7b91b66b28	Fix actor add --config crash with combined-format config.actor (#11189) ... When users register actors via `agents actor add --config` using the spec-compliant combined config.actor YAML format — either as a compact string (config:\n actor: "<provider>/<model>") or as a nested dict (config:\n actor:\n type: llm\n provider: aws) — the CLI crashed with click.BadParameter: "Invalid value: 'provider' is required" because the parser did not detect or flatten the nested structure. Added: - _detect_nested_config_actor() in schema.py to recognise both compact-string and nested-dict forms of config-actor format. - _flatten_config_actor() in schema.py to merge config["actor"] fields into the dict top-level (removing the wrapper). - Flattening logic in ActorConfiguration.from_blob() to handle both string ("<provider>/<model>") and nested-dict forms of config.actor. - CLI flattening step at the start of `agents actor add` command. - New BDD scenarios for combined-format registration. - Unit tests for detection, flattening, schema-v3 detection, and full from_blob() flow. ISSUES CLOSED: #11189	2026-05-28 20:25:17 -04:00
HAL9000	2dd920078a	fix(tests): add resolve_actor_options to mock lifecycle helpers ... The PR added resolve_actor_options() to StrategyActor, LLMStrategizeActor, and LLMExecuteActor, but the three mock lifecycle SimpleNamespace objects used by tests did not include this method, causing AttributeError at runtime: - features/mocks/mock_strategy_llm.py: make_mock_lifecycle() used by robot/helper_strategy_actor.py (strategy_actor.robot llm-json test) and features/steps/strategy_actor_llm_steps.py - features/steps/llm_actors_coverage_steps.py: _make_mock_lifecycle() used by llm_actors_coverage.feature scenarios - robot/helper_m5_e2e_context.py: inline lifecycle SimpleNamespace used by m5_e2e_verification.robot Execute Phase LLM Uses ACMS Context All three now include resolve_actor_options=MagicMock(return_value=None) matching the None-return contract the actors use when no custom backend is configured. ISSUES CLOSED: #11256	2026-05-28 17:35:08 -04:00
CoreRasurae	d5fd6b1765	fix(strategize): propagate actor options.openai_api_base and options.openai_api_key to LLM client creation in Strategize/Execute paths ... Extract shared build_llm_kwargs_from_options() utility in actor/config.py that converts actor-level YAML options (openai_api_base, openai_api_key, temperature, max_tokens, etc.) into kwargs for ProviderRegistry.create_llm(). Add options field to ActorConfigSchema so it survives Pydantic validation instead of being silently dropped by extra='ignore' default. Add resolve_actor_options() to PlanLifecycleService and both LifecycleService and PlanLifecycleProtocol protocols so every call site can retrieve the actor's config_blob.options dict. Fix the four call sites that previously called create_llm() with zero extra kwargs, preventing local/custom LLM backends from working: - StrategyActor._execute_with_llm() in strategy_actor.py - LLMStrategizeActor.execute() in llm_actors.py - LLMExecuteActor.execute() in llm_actors.py - SessionWorkflow._resolve_llm() in session_workflow.py Refactor reactive path (stream_router.py, tool_caller.py) to use the shared build_llm_kwargs_from_options() utility instead of inline copies. Wire actor_options_resolver through CLI session builder and A2A facade. ISSUES CLOSED: #11256	2026-05-28 17:35:08 -04:00
HAL9000	cb27538a73	test(planconfig): add BDD coverage for ThreeWayMergeConflictDetector ... Add feature file and Behave steps covering all reachable code paths in merge_conflict.py: MODIFY_MODIFY/DELETE/ADD_ADD conflict types, auto- resolution for MODIFY_DELETE/DELETE_MODIFY/convergent ADD_ADD, DELETE_DELETE absence, detect_diff_text formatting, describe_all status types, and direct _analyse_field call for the unreachable ADD_ADD branch. Restores coverage above the 96.5% threshold after the merge_conflict module was added with zero test coverage. ISSUES CLOSED: #11000	2026-05-28 12:52:19 -04:00
HAL9000	22831e4f50	fix(lsp): make post-spawn logger.info mock selective and remove tdd_expected_fail ... The _info_raises side_effect previously raised RuntimeError on every logger.info call, which caused the pre-Popen "lsp.transport.starting" call (transport.py:109) to raise before subprocess.Popen was ever reached. This meant the cleanup guard at lines 160-186 was never exercised, making the scenario a permanent no-op TDD stub rather than a genuine regression guard. Fix: make _info_raises conditional on the first positional argument being "lsp.transport.started" (the post-Popen message). The pre-Popen "lsp.transport.starting" call now passes through normally, Popen succeeds (mocked), and the RuntimeError is raised inside the guarded try/except block, triggering terminate() + wait() cleanup. Remove @tdd_expected_fail from the scenario since the cleanup code at transport.py:160-186 is in place and the scenario now passes. Closes #7044	2026-05-28 11:36:14 -04:00
HAL9000	c2459772eb	fix(lsp): restore missing else branch for stderr in _make_mock_process ... The `else: proc.stderr = stderr` clause was dropped when the helper was extracted into `_ltcov_helpers.py`. `stdin` and `stdout` both have the corresponding else branches; this restores parity so that callers passing a non-"auto" stderr value have it honoured.	2026-05-28 11:03:11 -04:00
HAL9000	a61d132ac0	fix(lsp): fix relative imports and remove unused imports in BDD step files ... - features/steps/lsp_transport_coverage_steps.py: change relative import `from ._ltcov_helpers import build_lsp_frame, ...` to absolute `from _ltcov_helpers import make_mock_process ...`, removing unused `build_lsp_frame` - features/steps/lsp_transport_post_spawn_cleanup_steps.py: remove unused `subprocess` and `MagicMock` imports; fix relative import to absolute; collapse short assert messages to single lines; remove trailing blank line Behave's exec_file loader does not set __name__ in globals, causing relative imports to raise KeyError at step-module load time. Absolute imports work because Behave adds features/steps/ to sys.path. ISSUES CLOSED: #11237	2026-05-28 10:50:24 -04:00
HAL9000	daf90ba764	fix(lsp): wrap post-Popen init in cleanup guard to prevent orphaned processes ... Closes #7044 The StdioTransport.start() method had an unprotected logger.info() call after successful Popen(). If that call raised, the subprocess would leak as an orphaned process. Wrap all post-spawn initialization in a try/except guard: on any exception after spawn, terminate and wait for the process (with kill fallback), reset state to None, then re-raise so callers still get proper error semantics. The existing stop() method cleanup pattern (terminate → wait → kill) is mirrored here for consistency across the transport lifecycle. Tests added: - TDD scenario with @tdd_issue_7044 verifying subprocess cleanup on post-Popen exception and state reset to None - Explicit is_alive() scenarios covering both alive and not-alive states Refactoring: - Extracted _make_mock_process and _build_lsp_frame helpers into a shared _ltcov_helpers module to keep step files under the 500-line CONTRIBUTING.md limit. ISSUES CLOSED: #7044	2026-05-28 10:50:24 -04:00
CoreRasurae	b98c99d93e	test(integration): add BDD scenarios for full hierarchical plan 4-phase lifecycle execution ... Adds BDD integration tests (Forgejo #10270) verifying that child plans independently complete all four lifecycle phases: Strategize, Decompose, Execute, and Validate. Scenarios covered: - Happy path: 2-level parent-child hierarchy with full phase execution - Checkpoint: on_subplan_spawn checkpoint creation verification - Max-child-depth: decomposition respects depth limits - Aggregation: parent plan aggregates child results - Failure handling: parent captures child plan failures - Nested: 3-level grandchild hierarchy cascading Uses real (non-mocked) service implementations in in-memory mode. ISSUES CLOSED: #10270	2026-05-28 00:05:08 -04:00
hamza.khyari	6bda792d2b	fix(tui): subclass Input to override _watch_value and eliminate layout=True per keystroke ... Input._watch_value sets self.virtual_size (Reactive layout=True) on every keystroke, keeping Textual's WriterThread write queue permanently non-empty. The queue never reaches qsize()==0 so flush() is never called and typed characters are invisible until Enter drains the queue. Two fixes applied: 1. _PromptTextInput subclasses textual.widgets.Input and overrides virtual_size with Reactive(layout=False). Setting virtual_size in _watch_value no longer triggers refresh(layout=True). Zero type:ignore suppressions — uses proper Textual reactive types. 2. CSS #prompt and #prompt > Input changed from height:auto to fixed heights (3 and 1). This prevents the auto_dimensions guard in _watch_value from adding a second refresh(layout=True) per keystroke. 3 BDD regression scenarios added covering: virtual_size layout=False, _PromptInputBase usage in _TextualPromptInput, and fixed CSS height. ISSUES CLOSED: #11249	2026-05-27 23:17:15 -04:00
hurui200320	91691750ed	fix(reactive): forward actor options block in ToolCallingLLMCaller._resolve_llm ... Port the options-block merging logic from SimpleLLMAgent._resolve_llm() (stream_router.py, added in PR #11225 / commit b3851693) to the parallel resolution path ToolCallingLLMCaller._resolve_llm() in tool_caller.py. Without this fix, running an actor with --skill would ignore the options block in the actor YAML, causing openai_api_base and openai_api_key to be silently dropped. The provider registry then fell back to OPENAI_API_KEY from the environment, routing requests to api.openai.com instead of the configured local llama-swap/llama.cpp backend (HTTP 401). Changes: - tool_caller.ToolCallingLLMCaller._resolve_llm: read actor_config.options; extract openai_api_key -> __api_key_sentinel; forward allowed keys (openai_api_base, timeout, top_p, frequency_penalty, presence_penalty); reject reserved keys (provider_type, model_id) and unknown keys with logger.warning, matching SimpleLLMAgent behaviour exactly. - features/actor_run_tool_calling.feature: add five BDD regression scenarios (section V, tagged @tdd_issue @tdd_issue_11243) covering api_base+key forwarding, allowed extra keys, reserved key rejection, unknown key rejection, and top-level precedence over options. - features/steps/actor_run_tool_calling_steps.py: add corresponding step definitions for all five scenarios. All nox quality gates pass (lint, typecheck, unit_tests 15822/0 fail, integration_tests 1999/0 fail, coverage_report 97%). ISSUES CLOSED: #11243	2026-05-27 12:14:04 -04:00
drew	0bde46f0ff	fix(tui): update tests for renamed Anthropic model names and fix typer.Exit propagation	2026-05-27 00:46:19 -04:00
HAL9000	190606d7e6	fix(memory): handle langchain-community SQLChatMessageHistory API rename ... langchain-community >= 0.3 renamed connection_string to connection in SQLChatMessageHistory.__init__(). Use the new 'connection' kwarg first and fall back to 'connection_string' for older versions. Also updates the test assertion in memory_service_coverage_steps.py to accept either parameter name. Fixes CI errors in: - plan_service_coverage.feature:128,141 - consolidated_misc.feature:1531	2026-05-23 12:22:51 +00:00
CoreRasurae	cdbe504b2c	fix(test): use shared in-memory SQLite URI in _ensure_memory_database_url ... Replace sqlite:///:memory: with sqlite:///file::memory:?cache=shared to ensure all SQLAlchemy connections within the same process share a single in-memory database. This prevents isolation issues where SQLChatMessageHistory and EntityStore would each create separate in-memory databases, avoiding unexpected errors in CI parallel execution.	2026-05-23 12:20:11 +01:00
CoreRasurae	3e13411fcf	fix(actors): distinguish namespace/name from provider/model in actor name parsing ... When action YAML references actors using namespace/name format (e.g. `strategy_actor: local/my-strategist`), `_parse_actor_name()` incorrectly treated the namespace prefix as a provider name, causing `ValueError: Unknown provider type: local`. Changes: - `_is_known_provider()`: New utility function (strategy_resolution.py) that checks whether a slash-separated first segment matches a known `ProviderType` value (openai, anthropic, etc.). Consolidated into a single implementation; llm_actors.py now imports from strategy_resolution.py. - `_parse_actor_name()`: When the first segment IS a known provider, preserves existing behaviour (provider/model). When it is NOT a known provider, treats the input as namespace/name and returns the full name as the model identifier with the default provider. Callers SHOULD pre-resolve namespace/name references via the actor registry before calling this function. Both implementations (strategy_resolution.py and llm_actors.py) updated; ProviderType import moved to top level. - `PlanLifecycleService.resolve_actor_provider_model()`: New method that resolves a namespaced actor name (e.g. local/my-strategist) to provider/model format by looking up the actor record and extracting its provider and model fields. - `LifecycleService` Protocol (strategy_resolution.py): Added `resolve_actor_provider_model` to the protocol, eliminating the need for `# type: ignore[union-attr]` at call sites. - `PlanLifecycleProtocol` (llm_actors.py): Added `resolve_actor_provider_model` to the protocol. - Caller pre-resolution: StrategyActor, LLMStrategizeActor, LLMExecuteActor, SessionWorkflow._resolve_llm(), and CLI session commands now pre-resolve actor names through the lifecycle service or via injected actor_resolver callables before calling `_parse_actor_name()`, ensuring namespace/name references are correctly mapped to their underlying LLM providers. - `_build_actor_resolver()` (cli/commands/session.py) and `_build_actor_resolver_for_session_workflow()` (a2a/facade.py): Moved `_is_known_provider` imports to top level; removed redundant `except (NotFoundError, Exception)`; added warning logging for outer exception handlers. - `make_mock_lifecycle()` (mock_strategy_llm.py) and `_make_mock_lifecycle()` (llm_actors_coverage_steps.py): Added `resolve_actor_provider_model` to mock lifecycle services for test compatibility. - Added `@tdd_issue @tdd_issue_11254` tags to all new BDD scenarios related to namespace/name disambiguation in llm_actors_coverage, strategy_actor_llm, and plan_lifecycle_service_coverage_boost_r4 feature files. - Updated docs/CHANGELOG.md with the fix entry. ISSUES CLOSED: #11254	2026-05-22 20:42:25 +01:00
hamza.khyari	652769c46c	feat(tui): wire normal text input to LLM via A2A facade ... Wires the TUI normal text input path to the LLM via A2aLocalFacade, closing the gap where typing a message produced no LLM call. All infrastructure (facade, SessionWorkflow, ProviderRegistry) already existed in the CLI; this PR adds the TUI wiring on top. Key changes: - _run_llm_dispatch(): module-level, Textual-free dispatch function covering all domain exception paths with user-friendly messages - _format_worker_outcome(): testable worker result/error translator - _create_tui_session(): DB-backed session with persona actor binding - _build_tui_facade(): wired A2aLocalFacade + SessionWorkflow singleton - run_worker(thread=True, exclusive=True): non-blocking, serialised - _dispatch_gen counter: prevents cancelled worker callbacks from corrupting the multi-turn transcript - SessionView.transcript: accumulated conversation history, pre-escaped - Markup escaping: _escape() applied before transcript storage - on_mount focus: prompt.focus() so keyboard input is received Tests: 18 BDD scenarios + 6 Robot Framework integration tests with FakeListLLM (no real API keys required). ISSUES CLOSED: #11230	2026-05-22 15:12:04 +00:00
CoreRasurae	3a95701d9a	fix(decomposition): enforce plan.max-child-depth recursion limit to prevent unbounded hierarchy growth ... Add max_child_depth field to DecompositionConfig (default: 5, matching plan.max-child-depth config) with validation in __post_init__. Update _build_hierarchy() in DecompositionService to stop recursion and emit a warning when the depth limit is reached. BDD tests verify: max_child_depth guards trigger before max_depth when more restrictive, warnings are logged, default config value is correct, and invalid values are rejected. ISSUES CLOSED: #10269	2026-05-19 21:56:28 +01:00
CoreRasurae	8548644819	fix(cli): wire SubplanExecutionService in _get_plan_executor() to enable child plan execution ... Wire subplan_service from the DI container into _get_plan_executor() so PlanExecutor can spawn child plans during the Execute phase. When SubplanService is available but SubplanExecutionService is not explicitly injected, _execute_subplans() now lazily creates a SubplanExecutionService on-the-fly using the parent plan's subplan_config and the new _execute_child_plan callback. - _get_plan_executor(): retrieve subplan_service from container, pass to PlanExecutor constructor - _execute_subplans(): lazily build SubplanExecutionService when only SubplanService is wired (Forgejo #10268) - _execute_child_plan(): new PlanExecutor method that runs a child plan's strategize + execute phases, registered as executor_fn callback ISSUES CLOSED: #10268	2026-05-19 19:28:35 +01:00
brent.edwards	eb46f0ff54	fix(plan): add tier hydration and improve architecture review output (#10938) ... ## Summary This PR fixes issue #10878 where architecture reviews were truncated because the regex pattern for parsing file output would stop at the first ``` encountered in the Markdown report. ## Changes - Change file delimiters from ``` to >>>>>>>/<<<<<<< to avoid Markdown conflicts - Add tier hydration before strategize phase in plan_executor.py - Increase max_tokens to 16384 in llm_actors.py for longer outputs - Increase context_max_tokens_hot from 16000 to 32000 in settings.py - Fix get_hot_view → get_hot_fragments in strategy_actor.py and plan_executor.py - Add opencode to skip directories in context_tier_hydrator.py - Change sandbox output location to plan-output/ directory in plan.py - Add get_context_summary stub method to acms_service.py ## Testing Run architecture review action and verify the output report is complete with all sections. Reviewed-on: #10938	2026-05-19 12:43:34 +00:00
hurui200320	0c5724c2f6	feat(actor-run): wire ToolCallingRuntime into actor run for skill-based tool calling ... Implements the full tool-calling path for `agents actor run --skill` so that LLM actors can actually invoke tools through the ToolCallingRuntime loop when a skill is attached. Core changes: - reactive/tool_caller.py (new): ToolCallingLLMCaller implements the LLMCaller protocol; binds tool schemas via bind_tools(), threads SystemMessage+HumanMessage on first call and AIMessage+ToolMessages on subsequent calls, extracts tool calls from LangChain responses following the LangChainSessionCaller pattern. - reactive/tool_caller.py: bidirectional tool name encoding via uppercase sentinels (_encode_tool_name / _decode_tool_name) to make CleverAgents namespaced tool names ("builtin/file-read", "server:local/tool") compatible with Anthropic's tool name pattern ^[a-zA-Z0-9_-]{1,128}$. Uses _C_ for ":" and _S_ for "/" — uppercase sentinels are safe because valid CleverAgents tool names forbid uppercase letters. Encoding applied in _resolve_llm() before bind_tools(); decoding applied in invoke() when extracting tool calls from the LLM response. - reactive/tool_agent.py (new): ToolCallingAgent builds a per-run local ToolRegistry from resolved skill tool entries by looking up names in the shared builtin_registry; drives ToolCallingRuntime.run_tool_loop(); exposes last_result for tool_calls surfacing. - reactive/application.py: (ST-1) _make_agent_instance() now always merges skill tools instead of silently dropping them when actor has no base tools list; routes tools+llm→ToolCallingAgent, tools+non-llm→SimpleToolAgent, no-tools+llm→SimpleLLMAgent; (ST-4) _builtin_registry created at startup with register_file_tools/git/subplan; (ST-6) _tally_tool_calls() + last_run_tool_calls property. - reactive/graph_executor.py: (ST-5) ToolCallingAgent added to isinstance check in _invoke_agent() so context dict is forwarded for Jinja2 rendering. - cli/commands/actor_run.py: prints "Tool Calls: {n}" when > 0. Test fixes: - features/steps/actor_cli_run_steps.py: _make_app() sets last_run_tool_calls=0 to avoid MagicMock>int TypeError in Python 3.13. - features/steps/actor_run_signature_resolve_steps.py: same fix. - robot/helper_actor_run_signature.py: same fix. - features/reactive_application_coverage_boost.feature: updated scenario to verify new correct behavior (LLM+skills → ToolCallingAgent, not silently kept as SimpleLLMAgent). BDD coverage: 34 scenarios in features/actor_run_tool_calling.feature covering tool call success, multi-turn loop, no-skill regression, silent-drop fix, LLMCaller internals, _build_tool_registry edge cases, last_run_tool_calls tallying, tool name encoding/decoding, and LLM response decoding. ISSUES CLOSED: #11211	2026-05-18 06:05:54 +00:00