1928 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
brent.edwards	7b86008cfc	Merge branch 'master' into feature/m3-test-resource-bootstrap-git	2026-03-04 22:48:56 +00:00
khyari hamza	ad53a659de	feat(uko): add UKO ontology scaffolding ... Add UKO Layer 0-3 ontology skeleton (RDF/TTL) with base URI, version IRI, and prefix conventions. Python loaders handle URI parsing, inheritance resolution, versioning metadata, and validation of undefined prefixes and missing rdf:type. Includes Behave BDD scenarios, Robot Framework integration tests, ASV benchmarks, and reference documentation. - Resolve rdfs:domain and rdfs:range values to full URIs in parser - Fix type: ignore in Robot helper with proper Callable typing - Export UKO models from core/__init__.py - Add parent-URI existence validation in validate() - Rename scenario to clarify parser-skips vs validation-rejects - Add scenario testing validation with injected typeless node - Add Scenario Outline for multi-layer node count assertions - TTL: Layer 0 classes (InformationUnit, Container, Atom, Annotation, Boundary) with contains/references/dependsOn properties. Layer 1 uko-code: classes (Module, Callable, TypeDefinition, TestCase, Import) with hasReturnType/hasParameters/testsCallable. Layer 2 uko-oo: classes (Class, Interface, Method, Attribute) with inheritsFrom/implements and rdfs:subPropertyOf. New URI scheme cleveragents.ai/ontology/uko#. - TTL: uko-oo:Class has dual rdfs:subClassOf (TypeDefinition + Container), uko-oo:Interface has dual rdfs:subClassOf (TypeDefinition + Boundary). - Model: UKONode.parent_uri replaced with parent_uris: tuple[str, ...] to support multi-parent rdfs:subClassOf. - Loader: prefix regex supports hyphenated names (uko-code, uko-oo). Semantic domain prefix maps (_LAYER_PREFIXES, _LAYER_IRI_PREFIXES). Comma-separated rdfs:subClassOf parsing. rdfs:domain/range/subPropertyOf URI resolution. BFS DAG traversal with DFS cycle detection for resolve_inheritance. HTTP URI skip in validation (D-1 fix). Duplicate error guard (B-1 fix). Consistent quoting (M-1 fix). - Services __init__: export UKOLoader and UKOValidationError. - Tests: 24 Behave scenarios (multi-parent, domain/range resolution, non-existent parent validation). 4 Robot smoke tests. Consolidated context attributes (T-3 fix). - Docs: uko.md written for spec-aligned structure. - Namespace prefix match in parent-URI validation includes a delimiter guard (# or /) preventing false positives on URIs that share the UKO prefix string (e.g. ukobogus:, ukoo:). ISSUES CLOSED: #189	2026-03-04 22:40:34 +00:00
brent.edwards	5a9995716b	fix(test): address self-review findings on git-checkout bootstrap tests ... - Add @tdd @bug524 tags to both feature scenarios for selective execution - Move module-level CliRunner singleton to per-step instantiation for consistency with PR #566 pattern Refs: #553	2026-03-04 22:40:09 +00:00
freemo	4ca4874c4d	feat(correction): implement cross-plan correction cascading with child plan state handling ... Add CrossPlanCorrectionService that implements the four child-plan-state- dependent behaviours from the specification when a correction's affected subtree includes child plans: - Not yet started → cancel the child plan - In progress → cancel + rollback sandbox to pre-child-plan state - Completed but not applied → cancel + rollback sandbox - Already applied → reject the correction (CorrectionRejection) Key additions: - ChildPlanState enum classifying child plans into 4 states - CorrectionRejection result type with reason and affected applied plan IDs - CascadeAction/CascadeResult models for cascade operation tracking - CorrectionStatus.REJECTED for rejected corrections - Atomic cascade-or-rollback: all child plan actions succeed or the entire cascade is rolled back - Protocol-based dependency injection (ChildPlanLookup, ChildPlanCanceller, SandboxRollbacker) for testability - execute_correction_with_cascade() integrates with CorrectionService flow Testing: - 24 Behave BDD scenarios in cross_plan_correction.feature - 8 Robot Framework end-to-end smoke tests - ASV benchmarks for cascade performance with varying child plan counts ISSUES CLOSED: #547	2026-03-04 21:20:47 +00:00
freemo	abd4c6de49	feat(actor): implement built-in invariant reconciliation actor ... Add InvariantReconciliationActor that runs at the start of the Strategize phase to reconcile invariants from four scopes (global, project, action, plan). The actor detects conflicts, resolves them using specificity-based precedence (plan > action > project > global), honours non_overridable global invariants, records invariant_enforced decisions, and produces a reconciled InvariantSet. Changes: - New: src/cleveragents/actor/reconciliation.py - InvariantReconciliationActor class with collect_invariants() and run() - reconcile_invariants() pure function - ScopeInvariants, ConflictRecord, ReconciliationResult dataclasses - Modified: src/cleveragents/domain/models/core/invariant.py - Added non_overridable: bool field to Invariant model - New: features/invariant_reconciliation_actor.feature (26 BDD scenarios) - New: features/steps/invariant_reconciliation_actor_steps.py - New: robot/invariant_reconciliation_actor.robot - New: robot/helper_invariant_reconciliation.py - New: benchmarks/invariant_reconciliation_bench.py Closes #549	2026-03-04 20:26:42 +00:00
brent.edwards	26ee1d632d	docs(changelog): add entry for git-checkout bootstrap test scaffolding ... ISSUES CLOSED: #553	2026-03-04 20:19:27 +00:00
brent.edwards	34a65ee9d0	test(resource): add failing tests for built-in git-checkout type bootstrap ... Add TDD-style failing tests that verify the built-in git-checkout resource type is available after initialization. Tests assert the correct expected behavior: after agents init, the git-checkout type should exist in the registry and 'agents resource add git-checkout' should succeed. Tests are expected to fail until bug #524 is fixed, because bootstrap_builtin_types() is never called during initialization. The fix branch should be based on this branch so the fix commit inherits these tests. Files added: - features/resource_type_bootstrap_git.feature (2 Behave scenarios) - features/steps/resource_type_bootstrap_git_steps.py (step definitions) - robot/resource_type_bootstrap_git.robot (Robot Framework smoke test) ISSUES CLOSED: #553	2026-03-04 20:13:36 +00:00
freemo	93e3893d69	feat(validation): implement tool wrapping runtime (wraps + transform delegation) ... Implement the runtime execution engine for validation tool wrapping, as specified in docs/specification.md § Tool Wrapping. WrappedToolExecutor resolves wraps references and delegates execution to wrapped tools, supporting composable wrapping chains with cycle detection and depth limiting (max 10 levels). ArgumentMapper translates arguments between wrapper and wrapped tool schemas using the argument_mapping configuration. Supports both forwarded parameter names and literal fixed values. TransformExecutor runs user-supplied transform functions in a sandboxed Python environment with restricted builtins (no imports, no filesystem, no network access). Validates that transforms return proper validation-format dicts with a passed boolean. Wired into the tool package public API via tool/__init__.py exports. All new error types (WrappedToolNotFoundError, WrappingCycleError, WrappingDepthExceededError, TransformExecutionError) provide clear diagnostic messages. Tests: 20 Behave scenarios covering argument mapping, transform execution, simple/chained delegation, error handling, and sandbox restrictions. 8 Robot Framework integration smoke tests. ASV benchmarks for delegation overhead measurement. ISSUES CLOSED: #543	2026-03-04 18:21:19 +00:00
freemo	db5e5c974f	feat(autonomy): implement semantic escalation with confidence scoring and threshold comparison	2026-03-04 12:18:51 -05:00
freemo	296431cfd6	Docs: Fixed another formatting issue with the documentation	2026-03-04 12:17:24 -05:00
freemo	5935940276	feat(sandbox): implement sandbox boundary algebra and domain computation ... Implement sandbox_boundary(r) function that walks up containment edges in the resource DAG to the nearest sandboxable ancestor, enabling resources sharing a boundary to share one sandbox instance. Changes: - Add boundary.py: is_sandbox_boundary(), sandbox_boundary(), compute_sandbox_domains(), BoundaryCache (thread-safe, per-execution) - Update SandboxManager: resolve_sandbox_key() and get_or_create_sandbox_for_resource() key by (plan_id, boundary_id) instead of (plan_id, resource_id); boundary cache lifecycle methods - Define "sandboxable" via ResourceCapabilities.sandboxable + non-none sandbox_strategy as per specification section 24659-24674 - Export new symbols from sandbox __init__.py - Add vulture whitelist entries for new public API Tests: - 26 Behave BDD scenarios (features/sandbox_boundary_algebra.feature) - 5 Robot Framework integration tests (robot/sandbox_boundary_algebra.robot) - ASV benchmarks for boundary walk, domain grouping, and cache performance ISSUES CLOSED: #548	2026-03-04 15:59:15 +00:00
freemo	8e6642e8c9	feat(decision): implement influence DAG traversal in correction affected subtree computation ... Extended _compute_affected_subtree() to BFS over both the structural tree (parent-child plan relationships) and decision_dependencies edges (influence DAG). The algorithm performs a single O(V+E) BFS pass that unions neighbors from both edge sources, using a visited set for cycle detection to guard against data corruption. Decision creation now supports dependency_decision_ids parameter in record_decision() which populates the in-memory influence DAG store. get_influence_edges() returns the adjacency list format consumed by CorrectionService. All public CorrectionService methods (analyze_impact, execute_revert, execute_correction, generate_dry_run_report) accept an optional influence_edges parameter while remaining backward-compatible (defaults to None, preserving structural-only traversal when not provided). Key design decisions: - Single BFS pass over union of structural + influence edges rather than separate traversals, ensuring O(V+E) complexity and consistent visit order - Cycle detection via visited set with warning log (not an error) since cycles indicate data corruption, not a programming error - Influence edge logging: traversal emits count of influence edges processed for observability - Backward-compatible API: existing callers that only pass decision_tree continue to work identically ISSUES CLOSED: #542	2026-03-04 15:36:34 +00:00
freemo	10d5d9839d	Updated small inconsistency in section titles	2026-03-03 22:27:21 -05:00
freemo	5aa9e7789b	Doc: fixed documentation warnings	2026-03-03 22:05:30 -05:00
freemo	1249f3c8cc	Docs: small clarification about labels	2026-03-03 20:59:08 -05:00
freemo	8a02512572	Docs: daily update to timeline	2026-03-03 20:53:38 -05:00
Luis Mendes	ff42d59d6d	feat(cli): wire project context CLI stubs to ACMS pipeline ... Wire all four project context CLI commands (inspect, simulate, set, show) to live ACMS pipeline services via ContextTierService and CRP models. - context inspect: queries ContextTierService for tier metrics and per-project fragments with filtering by strategy/focus/breadth/depth - context simulate: dry-run context assembly using CRP models with configurable token budget and assembly strategies - context set: 12 new ACMS pipeline options (hot_max_tokens, warm_max_decisions, cold_max_decisions, summary_max_tokens, temporal_scope, auto_refresh, focus_area, breadth, depth, assembly_strategy, retrieval_strategy, summary_strategy) - context show: displays ACMS pipeline configuration alongside policy - `context inspect` displayed global tier fragment counts (hot/warm/cold) across all projects instead of counts for the target project only. Add `ContextTierService.get_scoped_metrics(project_names)` which uses `ScopedBackendView` to filter fragment counts to the specified projects while keeping hit/miss counters as global service-level cache metrics. Update `context_inspect()` to call `get_scoped_metrics([project])` instead of `get_metrics()`. - `context simulate --focus` accepted focus URIs and passed them to the `ContextRequest` model but never used them to filter the fragment list, making the `--focus` flag a no-op. Add focus URI filtering in `_simulate_context_assembly()` after `get_scoped_view()` — filters `project_fragments` by matching each fragment's `resource_id` against the supplied focus URIs. Also fixes redaction false positives for hot_max_tokens and summary_max_tokens keys, and Rich Console line-wrapping in test output that caused JSON parse failures. Includes 28 new Behave BDD scenarios for wiring coverage, updated Robot Framework integration tests, and reference documentation. ISSUES CLOSED: #499	2026-03-03 23:36:15 +00:00
freemo	a60cda1f02	Docs: Fixed CONTRIBUTING.md error in stating dependency link direction	2026-03-03 17:55:52 -05:00
Luis Mendes	b4b96d213c	feat(security): add safety profile enforcement ... Implement safety profile resolution and enforcement in the tool execution pipeline, replacing the NotImplementedError stub with working precedence logic and runtime safety checks. Core changes: - resolve_safety_profile() now resolves plan > action > project > global precedence, returning the highest-priority non-None profile (or DEFAULT_SAFETY_PROFILE with GLOBAL provenance when all None) - ToolExecutionContext gains an optional safety_profile field - ToolRuntime._enforce_capabilities() extended with three new checks: * Unsafe tool gating: blocks tools with unsafe=True when profile has allow_unsafe_tools=False (ToolSafetyViolationError) * Skill category allow-list: blocks tools whose skill category is not in allowed_skill_categories (ToolSafetyViolationError) * Checkpoint requirement: OR-combines ctx.require_checkpoints with safety_profile.require_checkpoints - New ToolSafetyViolationError in tool error hierarchy Test coverage: - 30 updated BDD scenarios in safety_profile.feature (resolve precedence replaces NotImplementedError stub test) - 24 new BDD scenarios in safety_profile_enforcement.feature - 9 Robot Framework integration smoke tests - 4 ASV benchmark suites (construction, serialization, resolution, provenance enum) All nox sessions pass (typecheck 0 errors, unit_tests 7735 scenarios 0 failures, coverage 97%, integration_tests 9/9 passed, benchmarks complete). ISSUES CLOSED: #345	2026-03-03 22:21:14 +00:00
freemo	3f14cbbf7e	feat(observability): add LLMTrace model and operational metrics ... Add LLMTrace Pydantic v2 domain model with all required fields (trace_id, plan_id, decision_id, actor, provider, model, prompt_tokens, completion_tokens, cost_usd, latency_ms, tool_calls, context_hash, streaming, retry_count, error). Define 14 OperationalMetricKey values (PLAN_DURATION_MS, PLAN_TOTAL_COST_USD, PLAN_DECISION_COUNT, ACTOR_INVOCATION_COUNT, ACTOR_LATENCY_MS, TOOL_INVOCATION_COUNT, TOOL_ERROR_RATE, CONTEXT_BUILD_TIME_MS, CONTEXT_TOKEN_COUNT, LLM_CALL_COUNT, LLM_TOTAL_TOKENS, LLM_TOTAL_COST_USD, LLM_AVG_LATENCY_MS, SUBPLAN_COUNT) with MetricEntry model and MetricCollector. Add llm_traces database table (LLMTraceModel) with LLMTraceRepository for persistence. TraceService provides recording, querying, metric computation, plan lifecycle hooks, and optional LangSmith forwarding when LANGCHAIN_TRACING_V2=true. Wired into DI container as trace_service. Includes 28 Behave BDD scenarios, 6 Robot Framework smoke tests, 3 ASV benchmark suites, and reference documentation. Fix pre-existing cli_core server_mode test flake by mocking resolve_server_mode in test steps to avoid stale config file interference. Closes #500	2026-03-03 17:04:17 -05:00
freemo	4232907ab9	feat(plan): add large-project decomposition and dependency closure ... Add hierarchical decomposition with 4+ levels and bounded context per subplan. Implement decomposition heuristics (max_files_per_subplan, max_tokens_per_subplan, language/dir clustering). Add dependency closure computation for large graphs and DAG execution ordering. Add bounded dependency closure with cutoff thresholds and memoization for 10K+ files. Record decomposition decisions in DecisionService (strategy_choice + subplan_spawn entries). New modules: - decomposition_models.py: DecompositionConfig, DecompositionNode, DecompositionResult, DependencyEdge, DependencyGraph - decomposition_clustering.py: ClusteringStrategy with directory, language, and size clustering plus deterministic sort - decomposition_graph.py: DependencyClosureComputer with bounded closure, topological sort, cycle detection, and memoization - decomposition_service.py: DecompositionService orchestrating hierarchy building and decision recording Settings: planner_max_depth, planner_max_files_per_subplan, planner_max_tokens_per_subplan, planner_min_files_per_subplan Closes #205	2026-03-03 21:44:20 +00:00
freemo	738c3b5eda	feat(plan): add multi-project subplan support ... Add domain models, application service, CLI integration, and full test coverage for multi-project subplan orchestration. New components: - MultiProjectMetadata, ProjectScope, ProjectDependency domain models - MultiProjectService for creating/managing multi-project plans - CLI display of multi-project metadata in plan commands - Behave BDD tests (20 scenarios), Robot Framework integration tests, ASV benchmarks, and reference documentation Also fixes pre-existing test flakiness in cli_core, core_cli_commands, cli_plan_context_commands, and helper_server_stubs caused by environment leakage and path-with-spaces issues. ISSUES CLOSED: #199	2026-03-03 14:55:58 -05:00
freemo	ad5f737721	feat(execution): add execution environment routing ... Add ExecutionEnvironment enum (host/container) to domain models, implement execution environment resolution with priority chain (tool > plan > project > default), wire the tool runner to check execution_environment before execution, and add CLI flags to plan use/execute and project context set. When container is selected but no container resource is available, a clear ContainerUnavailableError is raised with an actionable message. Closes #512	2026-03-03 14:48:55 -05:00
freemo	6519f140a9	feat(context): add hot/warm/cold tiers and actor views ... Implement hot/warm/cold context tiers with ContextTier, ActorRole, TieredFragment, TierBudget, ActorContextView, TierMetrics, and ScopedBackendView models. ContextTierService provides store/get, promotion/demotion with cold-tier summarisation hook, LRU eviction, per-actor filtered views (strategist/executor/reviewer), and project-scoped isolation via ScopedBackendView. Settings: context_max_tokens_hot, context_max_decisions_warm, context_max_decisions_cold. DI-wired as singleton context_tier_service. Includes Behave BDD scenarios (30), Robot Framework integration tests (7), ASV benchmarks (5 suites), and docs/reference/context_tiers.md. Closes #208	2026-03-03 17:01:57 +00:00
aditya	7348ca1911	fix(events): update tests for DecisionService.record_decision API change ... - Update event_bus_steps.py to call record_decision() with individual parameters (plan_id, decision_type, question, chosen_option, rationale) instead of passing a Decision object, matching the master branch API - Remove ctx.test_decision construction from DecisionService setup steps as it is no longer needed with the new signature - Update robot/helper_event_bus.py decision_service_emits_event() to use the new record_decision() parameter signature - All 9 Robot Framework event bus tests passing - Behave scenarios at lines 125 and 131 now passing Fixes event bus test failures after master merge.	2026-03-03 15:42:53 +00:00
aditya	5bd7a507b8	Merge branch 'master' into feature/m6plus-event-bus	2026-03-03 15:20:19 +00:00
aditya	89bc776381	refactor(events): address PR-509 review comments ... - Fix CHANGELOG EventType count from 40 to 38 and add missing domains (invariant, context) for accurate documentation - Document correlation_id field as spec extension for request traceability in DomainEvent model - Add thread safety documentation to ReactiveEventBus and LoggingEventBus noting single-threaded design and external sync requirements - Document _persist_audit deferral in ReactiveEventBus.emit() explaining audit logging via handler subscription or LoggingEventBus following single-responsibility principle - Replace bare MagicMock() with create_autospec(Settings, instance=True) at 5 locations for type-safe test mocking - Replace nested bare MagicMock for UnitOfWork with create_autospec at 3 locations to prevent silent breakage on API changes All changes maintain backward compatibility. No linter errors.	2026-03-03 15:15:55 +00:00
aditya	5f0bc97d46	Merge branch 'master' into feature/m5-subplan-actor ... # Conflicts: # CHANGELOG.md	2026-03-03 14:55:28 +00:00
aditya	c4cda5d6d8	fix(actor): address second round code review on plan_subplan tool ... - Fix rationale test to assert goal text appears in rationale rather than only checking non-empty (P1-1) - Align side_effects value to specification: use ["spawn_subplan"] instead of ["emit_decision"] per docs/specification.md §18259 (P2-1) - Remove dead TYPE_CHECKING import guard that contained only pass (P2-2) - Replace frozenset with tuple for _VALID_CONTEXT_VIEWS to ensure deterministic JSON schema enum ordering and eliminate CI noise (P2-3) - Simplify validation error message and schema unpacking now that context_view values are in a pre-sorted tuple	2026-03-03 14:40:37 +00:00
hamza.khyari	8249c73aed	Merge pull request 'feat(service): add decision recording and snapshot store' (#433) from feature/m4-decision-service into master ... Reviewed-on: #433 Reviewed-by: Aditya Chhabra <aditya.chhabra@cleverthis.com>	2026-03-03 12:58:16 +00:00
khyari hamza	0e36755db9	fix(service): address review findings for decision service ... - Rehydrate sequence counter from DB on restart (BUG-1) - Add uniqueness guard raising SequenceConflictError (BUG-2) - Fix delete_decision consistency between persisted/in-memory (BUG-3) - Validate new_decision_id exists in mark_superseded (BUG-4) - Include orphaned subtrees in get_tree output (BUG-5) - Remove dead _decision_seq/_next_seq from plan_lifecycle (BUG-7) - Export SequenceConflictError from services __init__ (SPEC-2) - Replace list[Any] with list[ArtifactRef] typing (SPEC-4) - Add actor_reasoning max_length validation (SEC-1) - Use SELECT COUNT(*) in count_decisions (PERF-1) - Replace MagicMock with create_autospec(Settings) (TEST-3) - Eliminate UnitOfWork.__new__() anti-pattern (TEST-4) - Use exact assertion counts in DI tests (TEST-5) - Add restart rehydration, BFS order, invalid type, and confidence boundary test scenarios (TEST-1/2/6/7) - Fix decision_service_coverage.feature to match actual API ISSUES CLOSED: #172	2026-03-03 12:53:28 +00:00
khyari hamza	67c63f4c58	fix(service): align test and doc refs with DecisionService API ... Behave steps, benchmarks, vulture whitelist, and docs referenced renamed methods (get_decisions_for_plan, get_decision_tree). Updated to use the actual API names (list_decisions, get_tree) and the kwargs record_decision signature. ISSUES CLOSED: #172	2026-03-03 12:18:27 +00:00
khyari hamza	cebf71ad8e	fix(service): use list_decisions in robot helper ... The Robot helper called the non-existent get_decisions_for_plan method on DecisionService. The correct method is list_decisions. ISSUES CLOSED: #172	2026-03-03 12:18:27 +00:00
khyari hamza	d5802a4878	fix(service): use DecisionService kwargs API in plan lifecycle caller ... Align _record_decision_safe() to call record_decision() with keyword arguments directly instead of manually constructing a Decision model. The service now handles sequence numbering and model construction internally. ISSUES CLOSED: #172	2026-03-03 12:18:27 +00:00
khyari hamza	4cbf985a17	style(service): use contextlib.suppress per ruff SIM105 ... ISSUES CLOSED: #172	2026-03-03 12:18:27 +00:00
khyari hamza	e179f34266	test(service): add persisted-mode integration scenarios for coverage ... Add 9 Behave scenarios exercising all database-backed code paths in DecisionService: record, get, list, list_by_type, get_path_to_root, get_superseded, mark_superseded, delete, and duplicate detection. File-level coverage rises from 81% to 96%. ISSUES CLOSED: #172	2026-03-03 12:18:27 +00:00
khyari hamza	db81c4cfd6	test(service): add edge-case scenarios for coverage ... Add 11 new Behave scenarios covering SnapshotStore hash-less storage, hash-index cleanup on remove, multi-entry removal, list_for_plan with missing snapshots, whitespace-only validation, no-root tree traversal, and list-by-type string coercion. Brings scenario count from 37 to 48. ISSUES CLOSED: #172	2026-03-03 12:18:27 +00:00
freemo	4e871e70af	docs: add CHANGELOG entry for decision recording and snapshot store	2026-03-03 12:18:27 +00:00
khyari hamza	878bad4848	feat(service): add decision recording and snapshot store	2026-03-03 12:18:27 +00:00
hamza.khyari	f434f96a76	Merge pull request 'feat(cli): add plan explain and decision tree outputs' (#464) from feature/m4-decision-cli into master ... Reviewed-on: #464 Reviewed-by: Aditya Chhabra <aditya.chhabra@cleverthis.com>	2026-03-03 12:16:04 +00:00
khyari hamza	f66cb8d68e	fix(cli): address review findings for plan explain and tree commands ... - Remove global _PLAN_ID; generate per-step plan IDs on context (#8) - Fix sham orphan test; build children_map from all decisions (#1) - Delete dead constants; use _PATCH_RESUME_SVC_MOD in resume steps (#2) - Remove dead _resolve_active_plan_id mock from _invoke_correct (#5) - Make --mode/--guidance required Typer options (#3) - Show alternatives by default; remove --show-alternatives flag (#4) - Strengthen weak assertions on depth-limit and show-superseded (#6) - Add negative assertions for error type conflation (#7) ISSUES CLOSED: #174	2026-03-03 12:10:25 +00:00
khyari hamza	1524f8d25f	test(cli): add 32 behave scenarios to close plan.py diff-coverage gap ... Cover CLI-level code paths for plan explain, tree, correct, resume, revert, and read-only guards that were unreached by existing unit tests. Raises plan.py diff-coverage from 69% to 99.7% (1 line remaining).	2026-03-03 12:10:25 +00:00
khyari hamza	9deae36f73	fix(cli): address review findings for plan explain and tree commands ... - Add justification to type: ignore comments in build_decision_tree - Remove Any from step file signatures, use object instead - Strengthen non-existent decision test to verify ID exclusion - Fix O(n²×d) depth computation in table view with dict lookup - Fix orphan root detection in rich-view to match BFS logic - Add type annotations to Robot helper dispatch dict - Deduplicate import json in explain_decision_cmd ISSUES CLOSED: #174	2026-03-03 12:10:25 +00:00
khyari hamza	3e25b41a3a	feat(cli): add plan explain and decision tree outputs ... Add `plan explain` and `plan tree` CLI commands that format decision trees in json/yaml/table/rich formats. Flags control views for superseded decisions, context snapshots, and reasoning details. - plan explain <decision_id>: renders a single decision with optional --show-context, --show-reasoning, --show-alternatives flags - plan tree <plan_id>: renders full decision tree with optional --show-superseded and --depth flags - BFS tree building uses collections.deque (no list.pop(0)) - Behave BDD scenarios (14 scenarios, 54 steps) - Robot Framework smoke tests with helper script - ASV benchmarks for explain formatting and tree operations - Updated docs/reference/plan_cli.md and CHANGELOG.md ISSUES CLOSED: #174	2026-03-03 12:10:25 +00:00
freemo	4b9df961f0	feat(acp): wire ACP local facade handlers to live services ... Wire all AcpLocalFacade operation handlers to their corresponding application services via constructor-injected service dependencies: - session.create/close delegate to SessionService - plan.create/execute/status/diff/apply delegate to PlanLifecycleService - registry.list_tools delegates to ToolRegistry - registry.list_resources delegates to ResourceRegistryService - event.subscribe delegates to AcpEventQueue - context.get returns stub pending ACMS ContextAssemblyPipeline Add domain-to-ACP error code mapping via map_domain_error() translating ResourceNotFoundError to NOT_FOUND, ValidationError to VALIDATION_ERROR, PlanError to PLAN_ERROR, BusinessRuleViolation to INVALID_STATE, and other domain exceptions to their corresponding ACP error codes. Handlers gracefully fall back to stub responses when services are absent. Includes 21 Behave scenarios (features/acp_facade_wiring.feature) and 9 Robot Framework integration tests (robot/acp_facade_wiring.robot). Updated docs/reference/acp.md with wired operation details, service key table, and error code taxonomy. ISSUES CLOSED: #501	2026-03-02 22:45:55 -05:00
freemo	711e867112	feat(acms): add skeleton compressor ... Implemented SkeletonCompressorService for ACMS context inheritance, producing compressed context representations for propagation from parent plans to child plans. Key design decisions and implementation details: - SkeletonMetadata (frozen Pydantic model): records ratio, original_tokens, compressed_tokens, and source_decision_ids for full auditability of each compression pass. Persisted on Plan.skeleton_metadata. - SkeletonCompressorService: stateless service accepting a list of ContextFragment objects and a skeleton_ratio in [0.0, 1.0]. Fragments are sorted by relevance descending with a stable secondary sort on fragment_id to guarantee deterministic output. Token budget is original_tokens*(1-ratio); fragments are greedily selected until budget is exhausted. - Ratio semantics: 0.0 = no compression (pass-through), 1.0 = maximum compression (single top fragment only), None = default 0.3. - Integration: Plan model gains optional skeleton_metadata field exposed in as_cli_dict() under the 'skeleton' key. Service registered in DI container as skeleton_compressor_service (Singleton, stateless). - Tests: 22 BDD scenarios (features/skeleton_compressor.feature) covering ratio validation, stable ordering, metadata correctness, edge cases, and plan model integration. 6 Robot Framework smoke tests. ASV benchmark suites at 10/100/1000 fragment scales. - Documentation: docs/reference/skeleton_compressor.md with ratio table, algorithm description, metadata schema, and multi-decision plan example. ISSUES CLOSED: #194	2026-03-03 03:36:33 +00:00
freemo	025d379946	feat(acms): add text, vector, and graph backend protocol implementations ... Implemented the Backend Abstraction Layer (BAL) for the Advanced Context Management System, following the specification in docs/specification.md Section ACMS > Backend Abstraction Layer and ADR-014. Key additions: - TextBackend protocol with search(query, scope, max_results) returning list[TextResult], and TextResult frozen dataclass (uko_uri, content, score, metadata fields) - VectorBackend protocol with similarity_search(embedding, scope, top_k) returning list[VectorResult], and VectorResult frozen dataclass - GraphBackend protocol with sparql_query(query, scope), get_triples(subject), and traverse(start, depth) methods returning GraphResult frozen dataclass (triples, metadata fields) - In-memory stub backends (InMemoryTextBackend, InMemoryVectorBackend, InMemoryGraphBackend) that validate arguments and return empty results, serving as development placeholders and test doubles - DI container registration as configurable Singletons with provider selection via override_providers() - Behave BDD feature (35 scenarios / 83 steps) covering protocol compliance, argument validation, result immutability, and DI resolution - Robot Framework smoke tests (6 tests) for integration verification - ASV benchmarks for stub query overhead and instantiation time - Reference documentation at docs/reference/acms_backends.md Design decisions: - Used @runtime_checkable Protocol for structural subtyping, consistent with existing ResourceHandler pattern - Used frozen dataclasses (not Pydantic) for result types to minimize overhead in the hot path of context assembly - scope parameter typed as frozenset[str] for immutability and hashability - Stubs registered as default Singletons; production backends swap via DI ISSUES CLOSED: #498	2026-03-03 03:29:31 +00:00
freemo	279c6112ae	feat(resource): add devcontainer resource type and auto-discovery handler ... Added three new built-in resource types: container-instance, devcontainer-instance, and devcontainer-file. The devcontainer-instance type inherits from container-instance per ADR-042 and is auto-discovered when git-checkout or fs-directory resources contain .devcontainer/ directories per ADR-043. Implementation includes: - DevcontainerHandler extending BaseResourceHandler with snapshot strategy - Auto-discovery module scanning .devcontainer/devcontainer.json and root .devcontainer.json with JSON validation - CLI support for devcontainer-instance and container-instance via agents resource add with --path and --image flags - Behave feature with 22 scenarios covering manual registration, auto-discovery, invalid JSON handling, and protocol conformance - Robot integration tests with 10 test cases for CLI round-trip and DAG hierarchy validation - ASV benchmarks measuring discovery throughput with varying subdirectory counts, handler resolver cache performance, and result construction - Reference documentation at docs/reference/devcontainer_resources.md ISSUES CLOSED: #511	2026-03-02 22:09:37 -05:00
CoreRasurae	7e6f6fae37	test(validation): add semantic validation suites ... Add comprehensive semantic validation test suites covering five new fixture categories: language porting mismatches, dependency graph violations, API surface changes, cross-file symbols, and circular import detection. New BDD scenarios (38) exercise all six built-in rules against fixture-driven inputs. Robot Framework integration tests (11) validate end-to-end rule execution via the SemanticValidationService. ASV benchmarks (6 suites) establish performance baselines for batch validation throughput and per-rule latency. Files added: - features/fixtures/validation/{language_porting_mismatches, dependency_graph_violations, api_surface_changes, cross_file_symbols, circular_import_detection}.json - features/semantic_validation_suite.feature - features/steps/semantic_validation_suite_steps.py - robot/semantic_validation_suite.robot - robot/helper_semantic_validation_suite.py - benchmarks/semantic_validation_suite_bench.py - docs/reference/semantic_validation_coverage.md All 11 nox sessions pass (lint, format, typecheck, security_scan, dead_code, unit_tests, integration_tests, docs, build, benchmark, coverage_report). Coverage remains at 97%. ISSUES CLOSED: #316	2026-03-02 22:05:53 +00:00
freemo	c150bf24a0	Docs: Fixed nacbar in docs	2026-03-02 16:28:40 -05:00