cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

feat(cli): add plan explain and decision tree outputs #464

Merged
hamza.khyari merged 4 commits from feature/m4-decision-cli into master 2026-03-03 12:16:04 +00:00
Conversation 2 Commits 4 Files changed 10 +2278 -7
hamza.khyari commented 2026-02-27 11:47:35 +00:00
Member
Copy link

Summary

  • Add plan explain <decision_id> CLI command with --format (json/yaml/table/rich), --show-context, --show-reasoning, --show-alternatives flags for inspecting individual decisions
  • Add plan tree <plan_id> CLI command with --format, --show-superseded, --depth flags for rendering the full decision tree
  • BFS tree building uses collections.deque (no list.pop(0))

Testing

  • 14 Behave BDD scenarios / 54 steps (all pass)
  • Robot Framework smoke tests (robot/plan_explain.robot)
  • ASV benchmarks (benchmarks/plan_explain_bench.py)
  • Lint clean (ruff)

Files Changed

  • src/cleveragents/cli/commands/plan.py — Added plan explain and plan tree commands (+317 lines)
  • features/plan_explain.feature + features/steps/plan_explain_steps.py — BDD tests
  • robot/plan_explain.robot + robot/helper_plan_explain.py — Integration tests
  • benchmarks/plan_explain_bench.py — ASV benchmarks
  • docs/reference/plan_cli.md — Updated with explain/tree docs
  • CHANGELOG.md — Updated

Closes #174

## Summary - Add `plan explain <decision_id>` CLI command with `--format` (json/yaml/table/rich), `--show-context`, `--show-reasoning`, `--show-alternatives` flags for inspecting individual decisions - Add `plan tree <plan_id>` CLI command with `--format`, `--show-superseded`, `--depth` flags for rendering the full decision tree - BFS tree building uses `collections.deque` (no `list.pop(0)`) ## Testing - 14 Behave BDD scenarios / 54 steps (all pass) - Robot Framework smoke tests (`robot/plan_explain.robot`) - ASV benchmarks (`benchmarks/plan_explain_bench.py`) - Lint clean (ruff) ## Files Changed - `src/cleveragents/cli/commands/plan.py` — Added `plan explain` and `plan tree` commands (+317 lines) - `features/plan_explain.feature` + `features/steps/plan_explain_steps.py` — BDD tests - `robot/plan_explain.robot` + `robot/helper_plan_explain.py` — Integration tests - `benchmarks/plan_explain_bench.py` — ASV benchmarks - `docs/reference/plan_cli.md` — Updated with explain/tree docs - `CHANGELOG.md` — Updated Closes #174
hamza.khyari added this to the v3.2.0 milestone 2026-02-27 11:47:35 +00:00
hamza.khyari force-pushed feature/m4-decision-cli from 4e5df4cc63
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Failing after 13s
Details
CI / build (pull_request) Successful in 15s
Details
CI / quality (pull_request) Successful in 16s
Details
CI / typecheck (pull_request) Successful in 34s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Has been skipped
Details
CI / security (pull_request) Successful in 52s
Details
CI / integration_tests (pull_request) Successful in 2m38s
Details
CI / unit_tests (pull_request) Has been cancelled
Details
CI / docker (pull_request) Has been cancelled
Details
to f50bd80686
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 14s
Details
CI / build (pull_request) Successful in 16s
Details
CI / quality (pull_request) Successful in 16s
Details
CI / typecheck (pull_request) Successful in 31s
Details
CI / security (pull_request) Successful in 34s
Details
CI / integration_tests (pull_request) Successful in 5m16s
Details
CI / unit_tests (pull_request) Successful in 11m57s
Details
CI / docker (pull_request) Successful in 1m0s
Details
CI / benchmark-regression (pull_request) Successful in 23m50s
Details
CI / coverage (pull_request) Successful in 39m32s
Details
2026-02-27 14:41:28 +00:00 Compare
CoreRasurae requested changes 2026-02-27 18:05:13 +00:00
CoreRasurae left a comment
Copy link

Code Review — Commit f50bd80: test(cli): add 32 behave scenarios to close plan.py diff-coverage gap

Review scope: test coverage, test flaws, performance, bug detection, security, and spec compliance against issue #174 and docs/specification.md.

All 32 scenarios pass (126 steps, 0.4s). No security or performance issues found. However, the following findings should be addressed before merge.

1. HIGH — Sham Test: Orphan Scenario Does Not Exercise the Claimed Code Path

File: features/steps/plan_explain_cli_coverage_steps.py lines 240–249

Scenario 16, "Tree builder skips orphan child references gracefully", does not actually trigger the orphan branch at plan.py:2724-2726:

for child_id in children_map.get(did, []):
    if child_id not in by_id:   # <-- NEVER REACHED
        continue

The step definition contains an explicit comment admitting this:

"We test this by providing only a root decision (no children), which exercises the tree-building logic without triggering the orphan branch."

Since only a root decision with no children is provided, children_map.get(did, []) returns an empty list and the defensive guard is never evaluated. The scenario name and assertion give the illusion of coverage without actually hitting the branch.

Fix: Construct a decision list where children_map contains a reference to a decision_id that is absent from by_id. For example, manually craft a parent_decision_id in the child that points at the root, then include a second child whose decision_id does not match any entry in the filtered set (e.g., add a superseded child with show_superseded=False).

2. MEDIUM — Dead Code: Two Module-Level Constants Are Defined but Never Used

File: features/steps/plan_explain_cli_coverage_steps.py lines 40–44

_PATCH_CORRECTION_SVC = "cleveragents.cli.commands.plan.correct_decision"
_PATCH_RESUME_SVC_MOD = (
    "cleveragents.application.services.plan_resume_service.PlanResumeService"
)

Neither constant is referenced anywhere in the file. The actual patch targets are hardcoded inline in _invoke_correct and the resume when steps. A reader assumes these named constants are the canonical patch targets, but they are not used.

Fix: Either use the constants in the when steps, or remove them.

3. MEDIUM — Spec Deviation: --mode and --guidance Are Required in Spec but Optional in Implementation

Spec ref: docs/specification.md line 321

The specification defines (parentheses = required, brackets = optional):

agents plan correct --mode (revert|append) (--guidance|-g) <GUIDANCE> [--dry-run] [--yes|-y] <DECISION_ID>

The implementation gives both flags defaults (mode="revert", guidance=""), making them optional at the Typer level. The function body catches empty guidance with a manual check, but --mode silently defaults to "revert".

No test validates the behavior when --mode or --guidance is omitted. Tests always supply both.

4. MEDIUM — Spec Deviation: --show-alternatives Flag Absent from Specification

Spec ref: docs/specification.md line 320

The specification defines:

agents plan explain [--show-context] [--show-reasoning] <DECISION_ID>

The implementation and tests add --show-alternatives, which is documented in docs/reference/plan_cli.md but not present in the canonical spec. Either update the spec or mark this as an intentional extension.

5. MEDIUM — Unnecessary Mock: _resolve_active_plan_id Patched but Never Called in Correction Tests

File: features/steps/plan_explain_cli_coverage_steps.py lines 615–628

In _invoke_correct, _resolve_active_plan_id is patched via patch.multiple, but the test always explicitly passes --plan context.pec_plan_id. Since plan_id is always non-None in the production code path (resolved_plan_id = plan_id or _resolve_active_plan_id()), the mock is never triggered. This is dead mock setup that creates a false sense of thoroughness.

6. LOW — Weak Assertions: Two Scenarios Lack Output Content Verification

Scenario Gap
Tree CLI rich format with depth limit (feature line 87) Checks only exit code 0 — no output content assertion
Tree CLI with show-superseded flag (feature line 91) Checks only exit code 0 — does not verify superseded decisions appear in output

For the superseded scenario, the --show-superseded flag should cause superseded decisions to appear. Without asserting their presence, the test passes even if the flag is silently ignored.

7. LOW — typer.Abort() Conflates Distinct Error Types to Same Exit Behavior

The correct_decision command wraps ResourceNotFoundError, ValidationError, and CleverAgentsError all in typer.Abort(). Tests check exit code should be nonzero (not specific codes) plus different output strings. If someone reorders or removes a handler, the broader CleverAgentsError catch would absorb the specific ones, and the tests would still partially pass.

Suggestion: Add negative assertions (e.g., when ResourceNotFoundError is raised, assert "Validation Error" is NOT in the output).

8. LOW — Global _PLAN_ID Creates Hidden Coupling Between Steps

File: features/steps/plan_explain_cli_coverage_steps.py line 38

_PLAN_ID = str(ULID()) is generated once at import time and implicitly shared between the given step (step_pec_lifecycle_active) and the then step (step_pec_resolved_matches). This hidden coupling makes refactoring fragile. Prefer storing the expected ID on context in the given step and reading it back in the then step.

9. INFO — Coverage Claim May Be Off by 1 Line

The commit message states "Raises plan.py diff-coverage from 69% to 99.7% (1 line remaining)". Given finding #1 (the orphan guard at plan.py:2726 is never reached), the actual uncovered lines may be 2 rather than 1.

Summary

# Category Severity Issue
1 Test Flaw High Orphan scenario is sham coverage — never exercises the orphan branch
2 Code Quality Medium Two unused constants (_PATCH_CORRECTION_SVC, _PATCH_RESUME_SVC_MOD)
3 Spec Compliance Medium --mode / --guidance optional in code, required in spec
4 Spec Compliance Medium --show-alternatives flag not in specification
5 Test Flaw Medium _resolve_active_plan_id patched but never triggered
6 Test Quality Low Weak/missing output assertions on 2 scenarios
7 Test Quality Low typer.Abort() conflates distinct error types to same exit behavior
8 Maintainability Low Global _PLAN_ID creates hidden coupling between steps
9 Info Info Coverage claim may be off by 1 line due to orphan gap

Recommendation: Address at minimum findings #1 (sham coverage) and #2 (dead constants) before merge. Findings #3 and #4 (spec deviations) should be reconciled — either update the spec or adjust the implementation.

## Code Review — Commit `f50bd80`: `test(cli): add 32 behave scenarios to close plan.py diff-coverage gap` Review scope: test coverage, test flaws, performance, bug detection, security, and spec compliance against **issue #174** and `docs/specification.md`. All 32 scenarios pass (126 steps, 0.4s). No security or performance issues found. However, the following findings should be addressed before merge. --- ### 1. HIGH — Sham Test: Orphan Scenario Does Not Exercise the Claimed Code Path **File:** `features/steps/plan_explain_cli_coverage_steps.py` lines 240–249 Scenario 16, *"Tree builder skips orphan child references gracefully"*, **does not actually trigger the orphan branch** at `plan.py:2724-2726`: ```python for child_id in children_map.get(did, []): if child_id not in by_id: # <-- NEVER REACHED continue ``` The step definition contains an explicit comment admitting this: > *"We test this by providing only a root decision (no children), which exercises the tree-building logic without triggering the orphan branch."* Since only a root decision with **no children** is provided, `children_map.get(did, [])` returns an empty list and the defensive guard is never evaluated. The scenario name and assertion give the illusion of coverage without actually hitting the branch. **Fix:** Construct a decision list where `children_map` contains a reference to a `decision_id` that is absent from `by_id`. For example, manually craft a `parent_decision_id` in the child that points at the root, then include a second child whose `decision_id` does not match any entry in the filtered set (e.g., add a superseded child with `show_superseded=False`). --- ### 2. MEDIUM — Dead Code: Two Module-Level Constants Are Defined but Never Used **File:** `features/steps/plan_explain_cli_coverage_steps.py` lines 40–44 ```python _PATCH_CORRECTION_SVC = "cleveragents.cli.commands.plan.correct_decision" _PATCH_RESUME_SVC_MOD = ( "cleveragents.application.services.plan_resume_service.PlanResumeService" ) ``` Neither constant is referenced anywhere in the file. The actual patch targets are hardcoded inline in `_invoke_correct` and the resume `when` steps. A reader assumes these named constants are the canonical patch targets, but they are not used. **Fix:** Either use the constants in the `when` steps, or remove them. --- ### 3. MEDIUM — Spec Deviation: `--mode` and `--guidance` Are Required in Spec but Optional in Implementation **Spec ref:** `docs/specification.md` line 321 The specification defines (parentheses = required, brackets = optional): ``` agents plan correct --mode (revert|append) (--guidance|-g) <GUIDANCE> [--dry-run] [--yes|-y] <DECISION_ID> ``` The implementation gives both flags defaults (`mode="revert"`, `guidance=""`), making them optional at the Typer level. The function body catches empty guidance with a manual check, but `--mode` silently defaults to `"revert"`. No test validates the behavior when `--mode` or `--guidance` is omitted. Tests always supply both. --- ### 4. MEDIUM — Spec Deviation: `--show-alternatives` Flag Absent from Specification **Spec ref:** `docs/specification.md` line 320 The specification defines: ``` agents plan explain [--show-context] [--show-reasoning] <DECISION_ID> ``` The implementation and tests add `--show-alternatives`, which is documented in `docs/reference/plan_cli.md` but **not present in the canonical spec**. Either update the spec or mark this as an intentional extension. --- ### 5. MEDIUM — Unnecessary Mock: `_resolve_active_plan_id` Patched but Never Called in Correction Tests **File:** `features/steps/plan_explain_cli_coverage_steps.py` lines 615–628 In `_invoke_correct`, `_resolve_active_plan_id` is patched via `patch.multiple`, but the test always explicitly passes `--plan context.pec_plan_id`. Since `plan_id` is always non-None in the production code path (`resolved_plan_id = plan_id or _resolve_active_plan_id()`), the mock is never triggered. This is dead mock setup that creates a false sense of thoroughness. --- ### 6. LOW — Weak Assertions: Two Scenarios Lack Output Content Verification | Scenario | Gap | |---|---| | *Tree CLI rich format with depth limit* (feature line 87) | Checks only exit code 0 — no output content assertion | | *Tree CLI with show-superseded flag* (feature line 91) | Checks only exit code 0 — does not verify superseded decisions appear in output | For the superseded scenario, the `--show-superseded` flag should cause superseded decisions to appear. Without asserting their presence, the test passes even if the flag is silently ignored. --- ### 7. LOW — `typer.Abort()` Conflates Distinct Error Types to Same Exit Behavior The `correct_decision` command wraps `ResourceNotFoundError`, `ValidationError`, and `CleverAgentsError` all in `typer.Abort()`. Tests check `exit code should be nonzero` (not specific codes) plus different output strings. If someone reorders or removes a handler, the broader `CleverAgentsError` catch would absorb the specific ones, and the tests would still partially pass. **Suggestion:** Add negative assertions (e.g., when `ResourceNotFoundError` is raised, assert "Validation Error" is NOT in the output). --- ### 8. LOW — Global `_PLAN_ID` Creates Hidden Coupling Between Steps **File:** `features/steps/plan_explain_cli_coverage_steps.py` line 38 `_PLAN_ID = str(ULID())` is generated once at import time and implicitly shared between the `given` step (`step_pec_lifecycle_active`) and the `then` step (`step_pec_resolved_matches`). This hidden coupling makes refactoring fragile. Prefer storing the expected ID on `context` in the `given` step and reading it back in the `then` step. --- ### 9. INFO — Coverage Claim May Be Off by 1 Line The commit message states *"Raises plan.py diff-coverage from 69% to 99.7% (1 line remaining)"*. Given finding #1 (the orphan guard at `plan.py:2726` is never reached), the actual uncovered lines may be 2 rather than 1. --- ### Summary | # | Category | Severity | Issue | |---|---|---|---| | 1 | Test Flaw | **High** | Orphan scenario is sham coverage — never exercises the orphan branch | | 2 | Code Quality | Medium | Two unused constants (`_PATCH_CORRECTION_SVC`, `_PATCH_RESUME_SVC_MOD`) | | 3 | Spec Compliance | Medium | `--mode` / `--guidance` optional in code, required in spec | | 4 | Spec Compliance | Medium | `--show-alternatives` flag not in specification | | 5 | Test Flaw | Medium | `_resolve_active_plan_id` patched but never triggered | | 6 | Test Quality | Low | Weak/missing output assertions on 2 scenarios | | 7 | Test Quality | Low | `typer.Abort()` conflates distinct error types to same exit behavior | | 8 | Maintainability | Low | Global `_PLAN_ID` creates hidden coupling between steps | | 9 | Info | Info | Coverage claim may be off by 1 line due to orphan gap | **Recommendation:** Address at minimum findings #1 (sham coverage) and #2 (dead constants) before merge. Findings #3 and #4 (spec deviations) should be reconciled — either update the spec or adjust the implementation.
features/steps/plan_explain_cli_coverage_steps.py Outdated
@ -0,0 +37,4 @@
_PATCH_CONTAINER = "cleveragents.application.container.get_container"
_PATCH_LIFECYCLE = "cleveragents.cli.commands.plan._get_lifecycle_service"
_PATCH_RESOLVE = "cleveragents.cli.commands.plan._resolve_active_plan_id"
_PATCH_CORRECTION_SVC = "cleveragents.cli.commands.plan.correct_decision"
CoreRasurae commented 2026-02-27 18:05:13 +00:00
Member
Copy link

MEDIUM — Dead code. _PATCH_CORRECTION_SVC and _PATCH_RESUME_SVC_MOD are defined here but never referenced anywhere in this file. The actual patch targets are hardcoded inline in _invoke_correct (line 620) and the resume when steps (lines 665, 677, 691). Either use these constants or remove them.

**MEDIUM — Dead code.** `_PATCH_CORRECTION_SVC` and `_PATCH_RESUME_SVC_MOD` are defined here but never referenced anywhere in this file. The actual patch targets are hardcoded inline in `_invoke_correct` (line 620) and the resume `when` steps (lines 665, 677, 691). Either use these constants or remove them.
features/steps/plan_explain_cli_coverage_steps.py Outdated
@ -0,0 +237,4 @@
context.pec_plan_id = _PLAN_ID
root_id = str(ULID())
old_id = str(ULID())
new_id = str(ULID())
CoreRasurae commented 2026-02-27 18:05:13 +00:00
Member
Copy link

HIGH — Sham test. This step provides only a root decision with no children, so children_map.get(did, []) returns [] and the orphan guard at plan.py:2726 (if child_id not in by_id: continue) is never reached. The comment in the code acknowledges this explicitly.

To actually cover the orphan branch, construct a scenario where children_map contains a child_id that is absent from by_id. For example, include a superseded child decision (so it gets filtered out of by_id when show_superseded=False) while the parent still references it in children_map.

**HIGH — Sham test.** This step provides only a root decision with no children, so `children_map.get(did, [])` returns `[]` and the orphan guard at `plan.py:2726` (`if child_id not in by_id: continue`) is never reached. The comment in the code acknowledges this explicitly. To actually cover the orphan branch, construct a scenario where `children_map` contains a `child_id` that is absent from `by_id`. For example, include a superseded child decision (so it gets filtered out of `by_id` when `show_superseded=False`) while the parent still references it in `children_map`.
features/steps/plan_explain_cli_coverage_steps.py Outdated
@ -0,0 +617,4 @@
"correct",
context.pec_decision_id,
"--mode",
"revert",
CoreRasurae commented 2026-02-27 18:05:13 +00:00
Member
Copy link

MEDIUM — Unnecessary mock. Since --plan is always passed in _invoke_correct (line 630), the production code path resolved_plan_id = plan_id or _resolve_active_plan_id() never calls _resolve_active_plan_id(). This patch.multiple is dead mock setup.

**MEDIUM — Unnecessary mock.** Since `--plan` is always passed in `_invoke_correct` (line 630), the production code path `resolved_plan_id = plan_id or _resolve_active_plan_id()` never calls `_resolve_active_plan_id()`. This `patch.multiple` is dead mock setup.
hamza.khyari force-pushed feature/m4-decision-cli from f50bd80686
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 14s
Details
CI / build (pull_request) Successful in 16s
Details
CI / quality (pull_request) Successful in 16s
Details
CI / typecheck (pull_request) Successful in 31s
Details
CI / security (pull_request) Successful in 34s
Details
CI / integration_tests (pull_request) Successful in 5m16s
Details
CI / unit_tests (pull_request) Successful in 11m57s
Details
CI / docker (pull_request) Successful in 1m0s
Details
CI / benchmark-regression (pull_request) Successful in 23m50s
Details
CI / coverage (pull_request) Successful in 39m32s
Details
to f0e924c1a1
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 14s
Details
CI / quality (pull_request) Successful in 22s
Details
CI / typecheck (pull_request) Successful in 38s
Details
CI / build (pull_request) Successful in 35s
Details
CI / security (pull_request) Successful in 1m41s
Details
CI / unit_tests (pull_request) Successful in 2m10s
Details
CI / docker (pull_request) Successful in 44s
Details
CI / integration_tests (pull_request) Successful in 3m2s
Details
CI / coverage (pull_request) Successful in 4m4s
Details
CI / benchmark-regression (pull_request) Successful in 23m36s
Details
2026-03-02 15:39:30 +00:00 Compare
hamza.khyari force-pushed feature/m4-decision-cli from c4c6e71e20
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 15s
Details
CI / build (pull_request) Successful in 16s
Details
CI / quality (pull_request) Successful in 19s
Details
CI / security (pull_request) Successful in 33s
Details
CI / typecheck (pull_request) Failing after 34s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Has been skipped
Details
CI / unit_tests (pull_request) Successful in 1m48s
Details
CI / docker (pull_request) Has been skipped
Details
CI / integration_tests (pull_request) Failing after 2m47s
Details
to dc8dd9b57d
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 16s
Details
CI / build (pull_request) Successful in 16s
Details
CI / quality (pull_request) Successful in 20s
Details
CI / security (pull_request) Successful in 32s
Details
CI / typecheck (pull_request) Successful in 35s
Details
CI / unit_tests (pull_request) Successful in 3m7s
Details
CI / docker (pull_request) Successful in 43s
Details
CI / integration_tests (pull_request) Failing after 3m53s
Details
CI / coverage (pull_request) Successful in 3m44s
Details
CI / benchmark-regression (pull_request) Successful in 23m26s
Details
2026-03-02 16:45:36 +00:00 Compare
hamza.khyari force-pushed feature/m4-decision-cli from dc8dd9b57d
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 16s
Details
CI / build (pull_request) Successful in 16s
Details
CI / quality (pull_request) Successful in 20s
Details
CI / security (pull_request) Successful in 32s
Details
CI / typecheck (pull_request) Successful in 35s
Details
CI / unit_tests (pull_request) Successful in 3m7s
Details
CI / docker (pull_request) Successful in 43s
Details
CI / integration_tests (pull_request) Failing after 3m53s
Details
CI / coverage (pull_request) Successful in 3m44s
Details
CI / benchmark-regression (pull_request) Successful in 23m26s
Details
to 21e7aecbe7
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 15s
Details
CI / build (pull_request) Successful in 15s
Details
CI / quality (pull_request) Successful in 17s
Details
CI / security (pull_request) Successful in 31s
Details
CI / typecheck (pull_request) Successful in 47s
Details
CI / unit_tests (pull_request) Successful in 1m47s
Details
CI / docker (pull_request) Successful in 43s
Details
CI / integration_tests (pull_request) Successful in 2m52s
Details
CI / coverage (pull_request) Successful in 3m37s
Details
CI / benchmark-regression (pull_request) Successful in 23m41s
Details
2026-03-02 17:31:45 +00:00 Compare
aditya approved these changes 2026-03-03 08:41:46 +00:00
Dismissed
hamza.khyari force-pushed feature/m4-decision-cli from 21e7aecbe7
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 15s
Details
CI / build (pull_request) Successful in 15s
Details
CI / quality (pull_request) Successful in 17s
Details
CI / security (pull_request) Successful in 31s
Details
CI / typecheck (pull_request) Successful in 47s
Details
CI / unit_tests (pull_request) Successful in 1m47s
Details
CI / docker (pull_request) Successful in 43s
Details
CI / integration_tests (pull_request) Successful in 2m52s
Details
CI / coverage (pull_request) Successful in 3m37s
Details
CI / benchmark-regression (pull_request) Successful in 23m41s
Details
to f66cb8d68e
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 16s
Details
CI / build (pull_request) Successful in 16s
Details
CI / quality (pull_request) Successful in 18s
Details
CI / security (pull_request) Successful in 31s
Details
CI / typecheck (pull_request) Successful in 33s
Details
CI / unit_tests (pull_request) Successful in 1m44s
Details
CI / docker (pull_request) Successful in 44s
Details
CI / integration_tests (pull_request) Successful in 2m53s
Details
CI / coverage (pull_request) Successful in 3m51s
Details
CI / benchmark-regression (pull_request) Successful in 24m19s
Details
2026-03-03 12:11:36 +00:00 Compare
hamza.khyari dismissed aditya's review 2026-03-03 12:11:36 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

hamza.khyari scheduled this pull request to auto merge when all checks succeed 2026-03-03 12:12:49 +00:00
hamza.khyari deleted branch feature/m4-decision-cli 2026-03-03 12:16:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
CoreRasurae
brent.edwards
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
v3.2.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
hamza.khyari
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#174 feat(cli): add plan explain and decision tree outputs
cleveragents/cleveragents-core
Reference
cleveragents/cleveragents-core!464
No description provided.