feat(acp): wire ACP local facade handlers to live services #501

New issue

Closed

opened 2026-03-02 04:27:38 +00:00 by freemo · 3 comments

freemo commented

2026-03-02 04:27:38 +00:00

Owner

Metadata

Commit Message: feat(acp): wire ACP local facade handlers to live services
Branch: feature/m6-acp-facade-wiring

Background

The AcpLocalFacade currently has 11 operation handlers that return static placeholder data (e.g., {"tools": []}, {"context": {}}). These handlers need to be wired to the actual application services so that ACP operations route through real plan, session, registry, context, and event services. This is the integration point between the ACP protocol layer and the domain/application layer.

Acceptance Criteria

Wire session.create and session.close to SessionService.
Wire plan.create, plan.execute, plan.status, plan.diff, plan.apply to PlanService and PlanLifecycleService.
Wire registry.list_tools and registry.list_resources to ToolRegistry and resource services.
Wire context.get to the ACMS ContextAssemblyPipeline (or return stub until pipeline is ready).
Wire event.subscribe to AcpEventQueue for live event streaming.
Add error mapping from domain exceptions to ACP error codes (NOT_FOUND, INVALID_STATE, etc.).

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

Subtasks

Wire session operations to SessionService.
Wire plan operations to PlanService / PlanLifecycleService.
Wire registry operations to ToolRegistry and resource services.
Wire context operations to ACMS pipeline (or guarded stub).
Wire event subscription to AcpEventQueue.
Add domain-exception-to-ACP-error-code mapping.
Update docs/reference/acp.md with wired operation details.
Tests (Behave): Add features/acp_facade_wiring.feature for live operation routing.
Tests (Robot): Add robot/acp_facade_wiring.robot integration tests.
Verify coverage >=97% via nox -s coverage_report.
Run nox (all default sessions), fix any errors.

## Metadata - **Commit Message**: `feat(acp): wire ACP local facade handlers to live services` - **Branch**: `feature/m6-acp-facade-wiring` ## Background The `AcpLocalFacade` currently has 11 operation handlers that return static placeholder data (e.g., `{"tools": []}`, `{"context": {}}`). These handlers need to be wired to the actual application services so that ACP operations route through real plan, session, registry, context, and event services. This is the integration point between the ACP protocol layer and the domain/application layer. ## Acceptance Criteria - [ ] Wire `session.create` and `session.close` to `SessionService`. - [ ] Wire `plan.create`, `plan.execute`, `plan.status`, `plan.diff`, `plan.apply` to `PlanService` and `PlanLifecycleService`. - [ ] Wire `registry.list_tools` and `registry.list_resources` to `ToolRegistry` and resource services. - [ ] Wire `context.get` to the ACMS `ContextAssemblyPipeline` (or return stub until pipeline is ready). - [ ] Wire `event.subscribe` to `AcpEventQueue` for live event streaming. - [ ] Add error mapping from domain exceptions to ACP error codes (NOT_FOUND, INVALID_STATE, etc.). ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done. ## Subtasks - [ ] Wire session operations to `SessionService`. - [ ] Wire plan operations to `PlanService` / `PlanLifecycleService`. - [ ] Wire registry operations to `ToolRegistry` and resource services. - [ ] Wire context operations to ACMS pipeline (or guarded stub). - [ ] Wire event subscription to `AcpEventQueue`. - [ ] Add domain-exception-to-ACP-error-code mapping. - [ ] Update `docs/reference/acp.md` with wired operation details. - [ ] Tests (Behave): Add `features/acp_facade_wiring.feature` for live operation routing. - [ ] Tests (Robot): Add `robot/acp_facade_wiring.robot` integration tests. - [ ] Verify coverage >=97% via `nox -s coverage_report`. - [ ] Run `nox` (all default sessions), fix any errors.

freemo added the

ACP Operation	Target Service
session.create/close	SessionService
plan.create/execute/status/diff/apply	PlanLifecycleService
registry.list_tools	ToolRegistry
registry.list_resources	ResourceRegistryService
event.subscribe	AcpEventQueue
context.get	Stub (pending ACMS pipeline)

Rows
Columns

feat(acp): wire ACP local facade handlers to live services #501

Metadata

Background

Acceptance Criteria

Definition of Done

Subtasks

Implementation Notes

Design Decisions

Key Module Locations

Service Wiring Map

Test Results