test: consolidated Brent QA batch — issues #179, #180, #404, #405, #187 #442

Merged

brent.edwards merged 25 commits from develop-brent-5 into master 2026-02-26 16:54:22 +00:00

Conversation 1 Commits 25 Files changed 27 +7025 -23

brent.edwards commented 2026-02-25 22:14:58 +00:00

Member

Copy link

Summary

Consolidated QA test batch covering M3 and M4 milestones.

Issues Included

Issue	Title	Branch	Individual PR
#179	test(e2e): add M3 decision + validation suites	feature/m3-decision-validation-smoke	#437
#180	test(persistence): add decision persistence suites	feature/m4-decision-tests	#438
#404	test(e2e): verify M3 success criteria	test/m3-e2e-verification	#439
#405	test(e2e): verify M4 success criteria	test/m4-e2e-verification	#440
#187	test(e2e): add M4 correction + subplan suites	feature/m4-correction-subplan-smoke	#441

New Test Artifacts

Behave Scenarios: 62 new scenarios across 3 feature files

• m3_decision_validation_smoke.feature (21 scenarios)
• decision_persistence.feature (21 scenarios)
• m4_correction_subplan_smoke.feature (20 scenarios)

Robot Framework Integration Tests: 33 new test cases across 5 suites

• m3_decision_validation_smoke.robot (8 cases)
• m3_e2e_verification.robot (10 cases)
• m4_e2e_verification.robot (7 cases)
• decision_persistence.robot (7 cases)
• m4_correction_subplan_smoke.robot (8 cases)

ASV Benchmarks: 3 new benchmark files

• m3_smoke_bench.py (5 suites)
• decision_persistence_bench.py (4 suites)
• m4_smoke_bench.py (4 suites)

Bug Fixes Applied

• Fixed CorrectionService patch target in M3/M4 helpers (lazy import in plan.py)
• Fixed invalid ULID strings in M4 smoke helper (Pydantic pattern validation)
• Fixed dry-run assertion checking for text not in plain format output
• Added missing --guidance flag to correction dry-run CLI invocation

Closes #179 #180 #404 #405 #187

## Summary Consolidated QA test batch covering M3 and M4 milestones. ### Issues Included | Issue | Title | Branch | Individual PR | |-------|-------|--------|---------------| | #179 | test(e2e): add M3 decision + validation suites | `feature/m3-decision-validation-smoke` | #437 | | #180 | test(persistence): add decision persistence suites | `feature/m4-decision-tests` | #438 | | #404 | test(e2e): verify M3 success criteria | `test/m3-e2e-verification` | #439 | | #405 | test(e2e): verify M4 success criteria | `test/m4-e2e-verification` | #440 | | #187 | test(e2e): add M4 correction + subplan suites | `feature/m4-correction-subplan-smoke` | #441 | ### New Test Artifacts **Behave Scenarios**: 62 new scenarios across 3 feature files - `m3_decision_validation_smoke.feature` (21 scenarios) - `decision_persistence.feature` (21 scenarios) - `m4_correction_subplan_smoke.feature` (20 scenarios) **Robot Framework Integration Tests**: 33 new test cases across 5 suites - `m3_decision_validation_smoke.robot` (8 cases) - `m3_e2e_verification.robot` (10 cases) - `m4_e2e_verification.robot` (7 cases) - `decision_persistence.robot` (7 cases) - `m4_correction_subplan_smoke.robot` (8 cases) **ASV Benchmarks**: 3 new benchmark files - `m3_smoke_bench.py` (5 suites) - `decision_persistence_bench.py` (4 suites) - `m4_smoke_bench.py` (4 suites) ### Bug Fixes Applied - Fixed CorrectionService patch target in M3/M4 helpers (lazy import in plan.py) - Fixed invalid ULID strings in M4 smoke helper (Pydantic pattern validation) - Fixed dry-run assertion checking for text not in plain format output - Added missing --guidance flag to correction dry-run CLI invocation Closes #179 #180 #404 #405 #187

brent.edwards added the

Type

Testing

label 2026-02-25 22:14:58 +00:00

brent.edwards added 12 commits 2026-02-25 22:14:58 +00:00

test(e2e): verify M3 success criteria — decision tree and correction ... aeb5cc5110

Robot Framework E2E test suite for M3 milestone verification covering:
- Plan execution generating decisions during Strategize phase
- Decision tree viewing with parent-child relationships and BFS traversal
- Decision explanation with full context snapshot verification
- Invariant add/list via CLI and InvariantService with scope filtering
- Dry-run correction via CorrectionService with impact analysis
- Live revert correction execution with decision re-creation
- Context snapshot round-trip serialisation assertions
- Decision tree persistence via model_dump/model_validate
- Correction revert re-execution from decision point
- Invariant enforcement during strategize with merge precedence

ISSUES CLOSED: #404

test(persistence): add decision persistence suites ... f4c4884d03

Add comprehensive persistence test suites for the Decision domain model
covering serialization round-trips (model_dump/model_validate, JSON),
context-snapshot persistence, correction-chain reconstruction, and
decision-tree reconstruction from serialized data.

Deliverables:
- Behave: 21 scenarios in features/decision_persistence.feature
- Robot Framework: 7 integration tests in robot/decision_persistence.robot
- ASV benchmarks: 4 suites (17 benchmarks) in benchmarks/decision_persistence_bench.py
- Documentation: Updated docs/development/testing.md

ISSUES CLOSED: #180

test(e2e): add M3 decision + validation suites ace7311de4

test(e2e): verify M4 success criteria — subplans and parallel execution cfc319ad27

test(e2e): add M4 correction + subplan suites 917c2bc546

fix(test): correct patch target for CorrectionService in M3 e2e helper ... 2e53caaef1

The CorrectionService import in plan.py is a lazy import inside the
correct() function body, so it does not exist as a module-level attribute.
Patch the class at its definition site instead:
  cleveragents.application.services.correction_service.CorrectionService

Fixes CI integration_tests failure for PR #439.

fix(test): correct patch targets and ULID validation in M4 smoke helper ... 55df1915f1

- Patch CorrectionService at its definition site instead of the lazy
  import location in plan.py (same fix as M3 helper)
- Replace hardcoded fake subplan/correction IDs with real ULIDs
  generated via ulid.ULID() to satisfy Pydantic pattern validation
- Add missing --guidance flag to correction dry-run CLI invocation
- Fix subplan-status-sequential assertion to check for plan_id
  (subplan_count is not part of the status JSON output)

fix(test): correct dry-run assertion in M3 decision validation smoke ... 22986aaaf9

The CLI plain format output does not include the literal text "Dry Run"
(that string only appears in the Rich panel title). Assert against
"risk_level" which is present in the dry-run impact output instead.

Merge branch 'feature/m4-decision-tests' into develop-brent-5 5a212481e1

Merge branch 'test/m3-e2e-verification' into develop-brent-5 49f097472a

Merge branch 'test/m4-e2e-verification' into develop-brent-5 a2b0611722

Merge feature/m4-correction-subplan-smoke into develop-brent-5 c80cda2590

brent.edwards referenced this pull request 2026-02-25 22:15:07 +00:00

test(e2e): add M3 decision + validation suites #437

brent.edwards referenced this pull request 2026-02-25 22:15:07 +00:00

test(persistence): add decision persistence suites #438

brent.edwards referenced this pull request 2026-02-25 22:15:08 +00:00

test(e2e): verify M3 success criteria — decision tree and correction #439

brent.edwards referenced this pull request 2026-02-25 22:15:08 +00:00

test(e2e): verify M4 success criteria — subplans and parallel execution #440

brent.edwards referenced this pull request 2026-02-25 22:15:08 +00:00

test(e2e): add M4 correction + subplan suites #441

brent.edwards added 10 commits 2026-02-26 02:15:42 +00:00

fix(test): harden retry_patterns feature against flaky CI failures ... ef58883f7a

The jitter-spread scenario used millisecond-bucketed wall-clock
timestamps to assert that retried operations did not cluster.  On busy
CI runners — especially when a preceding scenario's time.sleep patch
leaked through a late cleanup — tenacity's retry waits became no-ops
and all five operations landed in the same millisecond bucket, tripping
the max_in_bucket <= 3 assertion.

Three hardening changes:

1. Jitter test: switch from time.time() to time.monotonic_ns() and
   replace the fragile bucket assertion with a unique-timestamp count
   (>= 2 distinct readings among 5 sequential operations).
2. Timeout test: eagerly restore time.sleep in a try/finally block so
   subsequent scenarios never observe the patched no-op, regardless of
   behave's cleanup ordering.
3. Async circuit breaker: lower recovery_timeout from 0.2 s to 0.1 s
   (the sleep step already waits 0.2 s) to give a wider safety margin
   on slow CI machines.

fix(test): address review findings in M3 smoke tests ... 93730067a2

- Replace dead after_scenario() hook with context.add_cleanup() calls
  so patchers are properly stopped (Behave only runs hooks from
  environment.py)
- Fix invalid ULID constants: pad DECISION/CORRECTION to 26 chars,
  replace invalid 'I' with 'J' in INVARIANT_ULID
- Add temp file cleanup for NamedTemporaryFile(delete=False) via
  context.add_cleanup() in behave steps and try/finally in robot helper
- Remove decision-persistence doc sections from testing.md that belong
  in PR #438, not this PR

fix(test): derive decision type count from enum instead of hard-coding 11 ... b99510d016

Replace hard-coded '11 decision types' with dynamic len(DecisionType) in
the assertion and remove the literal from scenario names, step patterns,
docstrings, and docs so the tests stay correct when new DecisionType
values are added.

fix(test): route M3 E2E subcommands through CLI rendering path ... 4f079c20ea

- decision-tree-view, decision-explain, and decision-tree-persistence
  now invoke 'plan status --format plain' via mocked lifecycle service
  so regressions in CLI rendering/serialization are caught
- plan-generates-decisions now asserts use_action was called by the CLI
  and verifies plan status renders the strategize phase after creation
- Updated robot test case documentation to reflect CLI integration

fix(test): correct mock targets, method names, ULIDs, and CLI args in M4 smoke suite ... 3c9a3efdf1

- Patch CorrectionService at its module path, not the local-import site
- Use request_correction/execute_correction/analyze_impact (real API)
- Replace invalid 27-char subplan_id values with valid 26-char ULIDs
- Add required --guidance flag to dry-run CLI invocation
- Fix feature file assertions to match actual CLI output

Resolves CI failures in unit_tests (job 4) and coverage (job 6) for
run 645 on PR #441.

Merge feature/m3-decision-validation-smoke into develop-brent-5 b3f126b147

Merge feature/m4-decision-tests into develop-brent-5 3d3c8fda33

Merge test/m3-e2e-verification into develop-brent-5 2e2ae3b9b8

Merge test/m4-e2e-verification into develop-brent-5 a00c33c4c6

Merge feature/m4-correction-subplan-smoke into develop-brent-5 cf59f285fd

brent.edwards added 1 commit 2026-02-26 03:44:20 +00:00

Merge branch 'master' into develop-brent-5 c53b880a5e

freemo approved these changes 2026-02-26 15:31:18 +00:00

Dismissed

brent.edwards added 2 commits 2026-02-26 16:14:40 +00:00

refactor(test): rename decision persistence files to avoid conflict with master ... 32b81793a2

Rename our serialization-focused decision persistence suites to
*_serialization to avoid add/add conflicts with the repository-based
decision persistence suites that landed on master independently:

- decision_persistence.feature -> decision_persistence_serialization.feature
- decision_persistence_steps.py -> decision_persistence_serialization_steps.py
- decision_persistence_bench.py -> decision_persistence_serialization_bench.py
- decision_persistence.robot -> decision_persistence_serialization.robot
- helper_decision_persistence.py -> helper_decision_persistence_serialization.py

Updated robot helper path, step docstring, and testing.md references.

Merge branch 'master' into develop-brent-5 ffdd2f2b19

brent.edwards dismissed freemo's review 2026-02-26 16:14:40 +00:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

brent.edwards scheduled this pull request to auto merge when all checks succeed 2026-02-26 16:15:32 +00:00

brent.edwards merged commit 93f2d396a1 into master 2026-02-26 16:54:22 +00:00

brent.edwards deleted branch develop-brent-5 2026-02-26 16:54:22 +00:00

brent.edwards referenced this pull request from a commit 2026-02-26 16:54:23 +00:00

Merge pull request 'test: consolidated Brent QA batch — issues #179, #180, #404, #405, #187' (#442) from develop-brent-5 into master

freemo referenced this pull request 2026-02-26 19:24:23 +00:00

test(integration): verify M4 success criteria — subplans and parallel execution #405

freemo referenced this pull request 2026-02-26 19:24:25 +00:00

test(e2e): add M4 correction + subplan suites #187

freemo added the

State

Completed

label 2026-03-04 00:58:37 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

auto/needs-reevaluation

Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  

controller-managed

Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  

auto/claimed-implementer

Currently being processed by an implementer worker.

  

auto/claimed-merge

Currently being processed by the merge driver.

  

auto/claimed-reviewer

Currently being processed by a reviewer worker.

  

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

  

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

  

auto/needs-implementer

Failing CI needs implementer attention.

  

auto/postmortem

Documenting a driver incident or rollback.

  

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

  

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

  

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

  

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  

Points

1

1 man-hours worth of work for an expert with no learning curve.

  

Points

13

13 man-hours worth of work for an expert with no learning curve.

  

Points

2

2 man-hours worth of work for an expert with no learning curve.

  

Points

21

21 man-hours worth of work for an expert with no learning curve.

  

Points

3

3 man-hours worth of work for an expert with no learning curve.

  

Points

34

34 man-hours worth of work for an expert with no learning curve.

  

Points

5

5 man-hours worth of work for an expert with no learning curve.

  

Points

55

55 man-hours worth of work for an expert with no learning curve.

  

Points

8

8 man-hours worth of work for an expert with no learning curve.

  

Points

88

88 man-hours worth of work for an expert with no learning curve.

  

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

  

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  

State

Duplicate

A ticket that represents the same content as an existing ticket.

  

State

In Progress

A ticket that is actively being developed.

  

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  

Type

Automation

Any edits or discussion about the AI automated coding system.

  

Type

Bug

Something that doesnt work as intended.

  

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  

Type

Documentation

An error or improvement needed in the documentation.

  

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  

Type

Feature

Some new functionality not present.

  

Type

Legendary

A type of Epic which will contain other Epics.

  

Type

Refactor

A code change that restructures existing code without changing its external behavior.

  

Type

Support

Someone needs help using the project.

  

Type

Task

A generic task that doesnt fit into the other type categories.

  

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No labels

auto/needs-reevaluation

controller-managed

auto/blocked-by-deps

auto/ci-timeout

auto/claimed-implementer

auto/claimed-merge

auto/claimed-reviewer

auto/driver-down

auto/invariant-violation

auto/last-attempt-tier-0

auto/last-attempt-tier-1

auto/last-attempt-tier-2

auto/last-attempt-tier-min

Automation Tracking

auto/needs-conflict-resolution

auto/needs-implementer

auto/postmortem

auto/ready-to-merge

auto/restart-throttled

auto/revert

auto/sentinel

auto/stale-inactivity

auto/unstable

Blocked

Bounty

$100

Bounty

$1000

Bounty

$10000

Bounty

$20

Bounty

$2000

Bounty

$250

Bounty

$50

Bounty

$500

Bounty

$5000

Bounty

$750

MoSCoW

Could have

MoSCoW

Must have

MoSCoW

Should have

Needs Feedback

Points

1

Points

13

Points

2

Points

21

Points

3

Points

34

Points

5

Points

55

Points

8

Points

88

Priority

Backlog

Priority

CI Blocker

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Signed-off: Owner

Signed-off: Scrum Master

Signed-off: Tech Lead

Spike

State

Completed

State

Duplicate

State

In Progress

State

In Review

State

Paused

State

Unverified

State

Verified

State

Wont Do

Type

Automation

Type

Bug

Type

Discussion

Type

Documentation

Type

Epic

Type

Feature

Type

Legendary

Type

Refactor

Type

Support

Type

Task

Type

Testing

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cleveragents/cleveragents-core!442

No description provided.