test(persistence): add decision persistence suites #180

New issue

Closed

opened 2026-02-22 23:39:52 +00:00 by freemo · 1 comment

freemo commented

2026-02-22 23:39:52 +00:00

Owner

Metadata

Commit Message: test(persistence): add decision persistence suites
Branch: feature/m4-decision-tests

Background

Persistence test suites cover decision and context snapshot storage, retrieval, tree queries, and superseded flag handling. Tests validate data integrity across create/read/update cycles.

Acceptance Criteria

Add comprehensive persistence test suites for decision models and snapshots.
Update docs/development/testing.md with decision test patterns.

Definition of Done

This issue is complete when:

All subtasks below are completed and checked off.
A Git commit is created where the first line of the commit message matches
the Commit Message in Metadata exactly, followed by a blank line, then
additional lines providing relevant details about the implementation. The
commit body should be appropriate in size for a commit message and relatively
complete in describing what was done.
The commit is pushed to the remote on the branch matching the Branch in
Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and
merged before this issue is marked done.

Subtasks

Add comprehensive persistence test suites for decision models and snapshots.
Update docs/development/testing.md with decision test patterns.
Tests (Behave): Add decision persistence scenarios covering CRUD, snapshots, and edge cases.
Tests (Robot): Add Robot integration tests for decision persistence.
Tests (ASV): Add benchmarks/decision_persistence_bench.py for persistence overhead.
Verify coverage >=97% via nox -s coverage_report. If coverage is <97% then review the current unit test coverage report at build/coverage.xml and use it to write new Behave based unit tests to improve code coverage. Specifically, write Behave style unit tests that are descriptively named and specifically improves coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun nox -s coverage_report to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Run nox (all default sessions, including benchmark), fix any errors if needed ensuring nox passes across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Section: #### M3: Decisions + Validations + Invariants (Day 18)
Status: Open

## Metadata - **Commit Message**: `test(persistence): add decision persistence suites` - **Branch**: `feature/m4-decision-tests` ## Background Persistence test suites cover decision and context snapshot storage, retrieval, tree queries, and superseded flag handling. Tests validate data integrity across create/read/update cycles. ## Acceptance Criteria - [ ] Add comprehensive persistence test suites for decision models and snapshots. - [ ] Update `docs/development/testing.md` with decision test patterns. ## Definition of Done This issue is complete when: - All subtasks below are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. The commit body should be appropriate in size for a commit message and relatively complete in describing what was done. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done. ## Subtasks - [ ] Add comprehensive persistence test suites for decision models and snapshots. - [ ] Update `docs/development/testing.md` with decision test patterns. - [ ] Tests (Behave): Add decision persistence scenarios covering CRUD, snapshots, and edge cases. - [ ] Tests (Robot): Add Robot integration tests for decision persistence. - [ ] Tests (ASV): Add `benchmarks/decision_persistence_bench.py` for persistence overhead. - [ ] Verify coverage >=97% via `nox -s coverage_report`. If coverage is <97% then review the current unit test coverage report at `build/coverage.xml` and use it to write new Behave based unit tests to improve code coverage. Specifically, write Behave style unit tests that are descriptively named and specifically improves coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `nox -s coverage_report` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Run `nox` (all default sessions, including benchmark), fix any errors if needed ensuring nox passes across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. **Section**: #### M3: Decisions + Validations + Invariants (Day 18) **Status**: Open

Rows
Columns