cleveragents/cleveragents-core

Fork 3

test(e2e): add M4 correction + subplan suites #187

New issue

Closed

opened 2026-02-22 23:39:57 +00:00 by freemo · 3 comments

freemo commented

2026-02-22 23:39:57 +00:00

Owner

Metadata

Commit Message: test(e2e): add M4 correction + subplan suites
Branch: feature/m4-correction-subplan-smoke

Background

E2E fixtures cover correction flows, subplan execution, and conflict simulations. The suite exercises corrections (revert/append), subplan scheduling, and merge conflict handling in integrated scenarios.

Acceptance Criteria

Add fixtures for correction flows, subplan execution, and conflict simulations.
Update docs/development/testing.md with M4 suite usage.

Definition of Done

This issue is complete when:

All subtasks below are completed and checked off.
A Git commit is created where the first line of the commit message matches
the Commit Message in Metadata exactly, followed by a blank line, then
additional lines providing relevant details about the implementation. The
commit body should be appropriate in size for a commit message and relatively
complete in describing what was done.
The commit is pushed to the remote on the branch matching the Branch in
Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and
merged before this issue is marked done.

Subtasks

Add fixtures for correction flows, subplan execution, and conflict simulations.
Update docs/development/testing.md with M4 suite usage.
Tests (Behave): Add features/m4_correction_subplan_smoke.feature covering correction flows and subplan merges.
Tests (Robot): Add Robot integration suite for correction + subplan CLI flows.
Tests (ASV): Add benchmarks/m4_smoke_bench.py for suite runtime.
Verify coverage >=97% via nox -s coverage_report. If coverage is <97% then review the current unit test coverage report at build/coverage.xml and use it to write new Behave based unit tests to improve code coverage. Specifically, write Behave style unit tests that are descriptively named and specifically improves coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun nox -s coverage_report to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Run nox (all default sessions, including benchmark), fix any errors if needed ensuring nox passes across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Section: #### M4: Corrections + Subplans + Checkpoints (Day 22)
Status: Open

## Metadata - **Commit Message**: `test(e2e): add M4 correction + subplan suites` - **Branch**: `feature/m4-correction-subplan-smoke` ## Background E2E fixtures cover correction flows, subplan execution, and conflict simulations. The suite exercises corrections (revert/append), subplan scheduling, and merge conflict handling in integrated scenarios. ## Acceptance Criteria - [ ] Add fixtures for correction flows, subplan execution, and conflict simulations. - [ ] Update `docs/development/testing.md` with M4 suite usage. ## Definition of Done This issue is complete when: - All subtasks below are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. The commit body should be appropriate in size for a commit message and relatively complete in describing what was done. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done. ## Subtasks - [ ] Add fixtures for correction flows, subplan execution, and conflict simulations. - [ ] Update `docs/development/testing.md` with M4 suite usage. - [ ] Tests (Behave): Add `features/m4_correction_subplan_smoke.feature` covering correction flows and subplan merges. - [ ] Tests (Robot): Add Robot integration suite for correction + subplan CLI flows. - [ ] Tests (ASV): Add `benchmarks/m4_smoke_bench.py` for suite runtime. - [ ] Verify coverage >=97% via `nox -s coverage_report`. If coverage is <97% then review the current unit test coverage report at `build/coverage.xml` and use it to write new Behave based unit tests to improve code coverage. Specifically, write Behave style unit tests that are descriptively named and specifically improves coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `nox -s coverage_report` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Run `nox` (all default sessions, including benchmark), fix any errors if needed ensuring nox passes across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. **Section**: #### M4: Corrections + Subplans + Checkpoints (Day 22) **Status**: Open

freemo added this to the v3.3.0 milestone

2026-02-22 23:39:57 +00:00

freemo added the

labels

2026-02-22 23:39:57 +00:00

brent.edwards was assigned by freemo

2026-02-22 23:39:57 +00:00

freemo added a new dependency

2026-02-22 23:54:05 +00:00

#358 Epic: Corrections + Subplans + Checkpoints (M4)

freemo commented

2026-02-23 18:31:40 +00:00

Author

Owner

Expected completion updated (Day 15 rebaseline): Day 33 / 2026-03-13 (previously Day 25 / 2026-03-05)

**Expected completion updated (Day 15 rebaseline):** Day 33 / 2026-03-13 (previously Day 25 / 2026-03-05)

freemo added the due date 2026-03-04

2026-02-23 18:41:38 +00:00

freemo removed a dependency

2026-02-23 20:33:19 +00:00

#358 Epic: Corrections + Subplans + Checkpoints (M4)

freemo added a new dependency

2026-02-23 20:35:29 +00:00

#401 Epic: Milestone Acceptance and Workflow Example Integration Tests

freemo added a new dependency

2026-02-23 20:35:54 +00:00

#368 Epic: Subplans & Parallelism

~~freemo referenced this issue 2026-02-23 22:17:26 +00:00~~

test(integration): verify M4 success criteria — subplans and parallel execution #405

freemo referenced this issue

2026-02-24 03:42:32 +00:00

Epic: Subplans & Parallelism #368

brent.edwards referenced this issue from a pull request that will close it,

2026-02-25 22:07:06 +00:00

test(e2e): add M4 correction + subplan suites #441

brent.edwards referenced this issue

2026-02-25 22:14:58 +00:00

test: consolidated Brent QA batch — issues #179, #180, #404, #405, #187 #442

brent.edwards added

and removed

labels

2026-02-25 22:15:21 +00:00

brent.edwards commented

2026-02-26 02:02:08 +00:00

Member

CI fix pushed in PR #441 (commit 3c9a3ef). All five bugs in the M4 correction + subplan smoke test suite have been resolved — wrong patch targets, incorrect mock method names, invalid ULID strings, missing CLI flags, and wrong feature-file assertions. All nox stages (lint, typecheck, unit_tests, integration_tests, coverage_report at 97.1%) pass locally.

CI fix pushed in PR #441 (commit `3c9a3ef`). All five bugs in the M4 correction + subplan smoke test suite have been resolved — wrong patch targets, incorrect mock method names, invalid ULID strings, missing CLI flags, and wrong feature-file assertions. All nox stages (lint, typecheck, unit_tests, integration_tests, coverage_report at 97.1%) pass locally.

brent.edwards referenced this issue from a commit

2026-02-26 16:54:23 +00:00

Merge pull request 'test: consolidated Brent QA batch — issues #179, #180, #404, #405, #187' (#442) from develop-brent-5 into master

freemo closed this issue

2026-02-26 19:24:24 +00:00

freemo commented

2026-02-26 19:24:24 +00:00

Author

Owner

Closing: M4 correction + subplan E2E suites merged via Brent QA batch PR #442 on 2026-02-26.

brent.edwards added

State