fix(cli): remove extra --mode flag from validation attach #1305

Merged
freemo merged 1 commits from fix/validation-attach-remove-mode-flag into master 2026-04-02 17:07:26 +00:00

1 Commits

Author SHA1 Message Date
brent.edwards 9f83786ca4 fix(cli): remove extra --mode flag from validation attach
CI / security (pull_request) Failing after 2s
CI / unit_tests (pull_request) Failing after 2s
CI / integration_tests (pull_request) Failing after 2s
CI / e2e_tests (pull_request) Failing after 1s
CI / build (pull_request) Failing after 2s
CI / helm (pull_request) Failing after 1s
CI / lint (pull_request) Successful in 3m20s
CI / quality (pull_request) Successful in 3m52s
CI / typecheck (pull_request) Successful in 3m57s
CI / docker (pull_request) Has been skipped
CI / coverage (pull_request) Failing after 1s
CI / status-check (pull_request) Failing after 1s
CI / benchmark-publish (pull_request) Has been skipped
CI / benchmark-regression (pull_request) Successful in 55m4s
Remove the --mode/-m CLI flag from the validation attach command to align
with the specification, which defines validation mode as an inherent
property of the validation definition set at registration time via
validation add, not as a per-attachment override.

The service layer (ToolRegistryService.attach_validation) no longer
accepts mode as a parameter; instead it reads the mode from the
validation's registered definition. The ToolRegistryRepository
_to_legacy_domain now exposes the mode field so the service can access it.

All tests that passed --mode to the CLI or service have been updated or
removed. The invalid-mode validation scenarios were removed since the
mode is no longer caller-supplied. Coverage remains at 98.7%.

ISSUES CLOSED: #913
2026-04-02 09:43:45 +00:00