cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(cli): remove extra --mode flag from validation attach #1305

Merged
freemo merged 1 commits from fix/validation-attach-remove-mode-flag into master 2026-04-02 17:07:26 +00:00
Conversation 2 Commits 1 Files Changed 13
+25 -70
freemo commented 2026-04-02 09:36:13 +00:00
Owner
Copy Link
Copy Source

Summary

Remove the --mode/-m CLI flag from validation attach to align with the specification. The validation mode is an inherent property of the validation definition, set at registration time via validation add, not a per-attachment override.

Changes

CLI Layer (src/cleveragents/cli/commands/validation.py)

  • Removed the --mode/-m Typer option from the attach() command
  • Updated docstring to clarify mode comes from the validation definition
  • Removed mode=mode from the service.attach_validation() call

Service Layer (src/cleveragents/application/services/tool_registry_service.py)

  • Removed mode parameter from attach_validation() signature
  • The method now reads mode from the validation's registered definition via self._tool_repo.get_by_name()
  • Removed unused ValidationError import (no longer needed without mode validation)

Repository Layer (src/cleveragents/infrastructure/database/repositories.py)

  • Added mode to ToolRegistryRepository._to_legacy_domain() so the mode field is available from tool lookups

Test Updates

  • Removed "Attach validation with mode informational" scenario from features/tool_cli.feature
  • Removed step_run_validation_attach_mode step from features/steps/tool_cli_steps.py
  • Removed 3 "invalid mode" service-layer scenarios from features/consolidated_tool.feature
  • Updated service-layer attach step definitions to not pass mode
  • Updated mock sentinel to include mode field
  • Updated Robot Framework helpers to not pass mode to attach_validation()

Quality Gates

All 11 nox sessions pass:

  • lint ✅ | format ✅ | typecheck ✅ | security_scan ✅ | dead_code ✅
  • unit_tests ✅ | integration_tests ✅ | e2e_tests ✅
  • docs ✅ | build ✅ | benchmark ✅
  • coverage_report ✅ (98.7% >= 97%)

Closes #913

## Summary Remove the `--mode/-m` CLI flag from `validation attach` to align with the specification. The validation mode is an inherent property of the validation definition, set at registration time via `validation add`, not a per-attachment override. ## Changes ### CLI Layer (`src/cleveragents/cli/commands/validation.py`) - Removed the `--mode/-m` Typer option from the `attach()` command - Updated docstring to clarify mode comes from the validation definition - Removed `mode=mode` from the `service.attach_validation()` call ### Service Layer (`src/cleveragents/application/services/tool_registry_service.py`) - Removed `mode` parameter from `attach_validation()` signature - The method now reads mode from the validation's registered definition via `self._tool_repo.get_by_name()` - Removed unused `ValidationError` import (no longer needed without mode validation) ### Repository Layer (`src/cleveragents/infrastructure/database/repositories.py`) - Added `mode` to `ToolRegistryRepository._to_legacy_domain()` so the mode field is available from tool lookups ### Test Updates - Removed "Attach validation with mode informational" scenario from `features/tool_cli.feature` - Removed `step_run_validation_attach_mode` step from `features/steps/tool_cli_steps.py` - Removed 3 "invalid mode" service-layer scenarios from `features/consolidated_tool.feature` - Updated service-layer attach step definitions to not pass `mode` - Updated mock sentinel to include `mode` field - Updated Robot Framework helpers to not pass `mode` to `attach_validation()` ## Quality Gates All 11 nox sessions pass: - lint ✅ | format ✅ | typecheck ✅ | security_scan ✅ | dead_code ✅ - unit_tests ✅ | integration_tests ✅ | e2e_tests ✅ - docs ✅ | build ✅ | benchmark ✅ - coverage_report ✅ (98.7% >= 97%) Closes #913
brent.edwards force-pushed fix/validation-attach-remove-mode-flag from a856f52b0b to 9f83786ca4 2026-04-02 09:44:06 +00:00 Compare
brent.edwards added this to the v3.4.0 milestone 2026-04-02 09:44:28 +00:00
brent.edwards added the
Type
Task
 label 2026-04-02 09:44:32 +00:00
freemo commented 2026-04-02 17:03:40 +00:00
Author
Owner
Copy Link
Copy Source

Review claimed by reviewer pool instance reviewer-pool-1. Dispatching independent code review.

Review claimed by reviewer pool instance reviewer-pool-1. Dispatching independent code review.
freemo commented 2026-04-02 17:07:16 +00:00
Author
Owner
Copy Link
Copy Source

Code Review — PR #1305: fix(cli): remove extra --mode flag from validation attach

✅ APPROVED

I've reviewed the complete diff across all changed files against the specification and project standards. This is a clean, well-scoped fix.

Specification Alignment ✅

The spec defines validation attach as:

agents validation attach [--project <PROJECT>|--plan <PLAN_ID>]
                         <RESOURCE> <VALIDATION> [<ARGS>...]

The --mode flag was not part of the spec signature. Validation mode is an inherent property of the validation definition, set at registration time via validation add. This PR correctly removes the non-spec --mode/-m flag from the CLI and service layer.

Changes Reviewed

CLI Layer (validation.py): --mode/-m Typer option correctly removed from attach() command. Docstring updated. ✅

Service Layer (tool_registry_service.py): mode parameter removed from attach_validation() signature. Mode now correctly read from the validation's registered definition via self._tool_repo.get_by_name(). Handles both dict and object return types. Type safety maintained with mode_str: str. Unused ValidationError import removed. ✅

Repository Layer (repositories.py): mode field added to _to_legacy_domain() so the service can access it from tool lookups. ✅

Test Updates: CLI scenario for --mode removed. Step definition removed. 3 "invalid mode" service-layer scenarios removed. Service-layer attach steps updated. Mock sentinel updated. Robot Framework helpers updated. ✅

Commit Quality ✅

  • Single atomic commit with Conventional Changelog format
  • ISSUES CLOSED: #913 footer present
  • Branch name follows convention

PR Metadata ✅

  • Closes #913 in PR body
  • Type/Task label present
  • Milestone v3.4.0 matches linked issue
  • Coverage reported at 98.7% (≥ 97% threshold)

No Issues Found

  • No # type: ignore suppressions
  • No secrets or credentials
  • Error handling follows fail-fast principles

Proceeding to merge.

## Code Review — PR #1305: fix(cli): remove extra --mode flag from validation attach ### ✅ APPROVED I've reviewed the complete diff across all changed files against the specification and project standards. This is a clean, well-scoped fix. --- ### Specification Alignment ✅ The spec defines `validation attach` as: ``` agents validation attach [--project <PROJECT>|--plan <PLAN_ID>] <RESOURCE> <VALIDATION> [<ARGS>...] ``` The `--mode` flag was **not** part of the spec signature. Validation mode is an inherent property of the validation definition, set at registration time via `validation add`. This PR correctly removes the non-spec `--mode/-m` flag from the CLI and service layer. ### Changes Reviewed **CLI Layer (`validation.py`)**: `--mode/-m` Typer option correctly removed from `attach()` command. Docstring updated. ✅ **Service Layer (`tool_registry_service.py`)**: `mode` parameter removed from `attach_validation()` signature. Mode now correctly read from the validation's registered definition via `self._tool_repo.get_by_name()`. Handles both dict and object return types. Type safety maintained with `mode_str: str`. Unused `ValidationError` import removed. ✅ **Repository Layer (`repositories.py`)**: `mode` field added to `_to_legacy_domain()` so the service can access it from tool lookups. ✅ **Test Updates**: CLI scenario for `--mode` removed. Step definition removed. 3 "invalid mode" service-layer scenarios removed. Service-layer attach steps updated. Mock sentinel updated. Robot Framework helpers updated. ✅ ### Commit Quality ✅ - Single atomic commit with Conventional Changelog format - `ISSUES CLOSED: #913` footer present - Branch name follows convention ### PR Metadata ✅ - `Closes #913` in PR body - `Type/Task` label present - Milestone v3.4.0 matches linked issue - Coverage reported at 98.7% (≥ 97% threshold) ### No Issues Found - No `# type: ignore` suppressions - No secrets or credentials - Error handling follows fail-fast principles **Proceeding to merge.**
freemo merged commit 1d36449a98 into master 2026-04-02 17:07:26 +00:00
freemo deleted branch fix/validation-attach-remove-mode-flag 2026-04-02 17:07:27 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Type
Task
Milestone
No items
No Milestone v3.4.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cleveragents/cleveragents-core#1305
Delete Branch "fix/validation-attach-remove-mode-flag"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?