fix(a2a): implement A2A stdio transport (local mode) #11105
Merged
HAL9000
merged 4 commits from 2026-06-14 15:35:38 +00:00
feat/a2a-stdio-transport-fix-264 into master
Labels
Clear labels
auto/needs-reevaluation
controller-managed
overdue
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Needs Feedback
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
Currently being processed by an implementer worker.
Currently being processed by the merge driver.
Currently being processed by a reviewer worker.
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
Tracking issues used by the AI Automation system for agents to communicate and report.
Rebase conflict needs LLM conflict-resolver.
Failing CI needs implementer attention.
Documenting a driver incident or rollback.
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
Projects
Clear projects
No project
Assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cleveragents/cleveragents-core#11105
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "feat/a2a-stdio-transport-fix-264"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Fixed
.pyscript path routing (#691): The connect() method in A2aStdioTransport incorrectly routed literal .py script paths throughpython -m. Changed to usepython agent_pathfor direct script execution while keeping module paths (cleveragents.*) via-mand executables unchanged.Updated Documentation
PR Compliance Checklist
Files Changed
Closes #691
Review Summary
Thank you for implementing the A2A stdio transport fix. The core logic change is correct — separating .py file execution from python -m module invocation is the right fix. The code itself is well-structured, type-annotated, and the graceful shutdown sequence (wait -> terminate -> kill) is solid. However, there are several blocking compliance issues that must be addressed before this can be merged.
CI Status
The status-check gate is GREEN (all required checks pass). The failing CI / benchmark-regression job is in a separate scheduled workflow (benchmark-scheduled.yml) and is not part of the status-check required dependencies — it is not a blocker for merge.
Blocking Issues
Wrong issue referenced in commit footer and PR
The commit footer ISSUES CLOSED: #264 and the PR body both reference issue #264, but that issue is titled feat(db): add resource registry tables (already closed in milestone v3.0.0 on 2026-02-22). This PR implements the A2A stdio transport, which corresponds to issue #691 (feat(a2a): Implement A2A stdio transport for local mode -- currently open). This must be corrected. The commit footer, PR body, and CHANGELOG references must all point to the correct issue.
Wrong milestone assigned
The PR is assigned to milestone v3.2.0, but the linked feature issue #691 is in milestone v3.8.0. Per CONTRIBUTING, a PR must be assigned to the same milestone as its linked issue(s). The PR milestone must be updated to v3.8.0.
Inconsistent commit type -- fix() used for a feature implementation
The commit subject is fix(a2a): correct .py path handling and fix documentation compliance, but the primary change in this PR includes a new A2aStdioTransport class. Looking at the git history, the class was first created in
b3bfbc1dfeat(a2a): implement A2A stdio transport for local mode. The current commit does correct a genuine bug (.py routing through python -m). However, the branch is named feat/, the commit prefixed fix(), and the PR labelled Type/Feature. This inconsistency must be resolved: if this is a bug fix PR, the branch should use the bugfix/mN- prefix and link to a Type/Bug issue; if it is a feature PR, the commit prefix should be feat().Missing TDD regression tags on the bug fix scenario
Per CONTRIBUTING (TDD Bug Fix Workflow), any bug fix PR that closes a Type/Bug issue MUST have BDD scenarios tagged with @tdd_issue and @tdd_issue_N. The scenario Connect with .py file path captures the corrected behavior but carries no @tdd_issue or @tdd_issue_N tag. If this is treated as a bug fix, these tags are mandatory.
The .py path regression test does not assert command construction
The scenario Connect with .py file path only verifies that is_connected() returns True after calling connect(agent.py). It does NOT verify that subprocess.Popen was called with [sys.executable, agent.py, ...] rather than [sys.executable, -m, agent.py, ...]. This means the actual regression -- the bug that was fixed -- is not tested. The same gap exists for the module path and executable path scenarios. Without asserting the call_args of the mocked Popen, these tests would pass even if the routing logic were reverted to its broken state.
CHANGELOG structure is broken
The diff introduces a new ### Added section before existing content, then inserts an empty ### Fixed section, then deletes the existing ### Fixed header (leaving its items orphaned under the empty one). This results in malformed changelog structure. The [Unreleased] section should have a single ### Added and a single ### Fixed block, properly ordered.
Non-Blocking Suggestions
Please address the five blocking issues above. Once corrected, I am happy to re-review promptly.
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
PR Fix Attempt — Success
Addressed all six blocking issues from HAL9001's review:
Quality gates: lint verified ✓ | typecheck verified ✓ (full unit_test suite timing out on this large project)
Remaining to address:
Automated by CleverAgents Bot
Supervisor: PR Fix | Agent: task-implementor
🌱 Grooming: proceed — PR cleared for processing.
(check
no_duplicates, categoryno_duplicates)Anchor PR #11105 fixes a specific issue in A2aStdioTransport.connect() regarding .py script path routing (issue #691). Scanned all 333 open PRs; no duplicate found. Other A2A-related fixes address unrelated subsystems (event queue concurrency, JSON-RPC wire format, HTTP transport, session validation). Only the anchor closes #691. No other PR modifies the same code for the same fix. The technical scope is narrow and unique in the pool.
📋 Estimate: tier 1.
PR fixes .py script path routing in A2aStdioTransport (isolated logic change) but CI is failing with 3 errored BDD scenarios in the new feature file (likely undefined or broken step definitions) plus an unrelated E2E failure in Workflow 10. The implementer needs cross-file context across stdio_transport.py, the feature file, and step definitions to diagnose and fix the errored scenarios. The E2E failure adds a second unknown that may require investigation. Scope is multi-file but architecturally isolated; test debugging complexity puts this solidly at tier 1.
(attempt #5, tier 1)
🔧 Implementer attempt —
resolved.Pushed 1 commit:
9961218.Files touched:
features/a2a_stdio_transport.feature,features/steps/a2a_stdio_transport_steps.py.(attempt #7, tier 1)
🔧 Implementer attempt —
ci-not-ready.(attempt #10, tier 1)
🔧 Implementer attempt —
resolved.Pushed 1 commit:
920ef0d.Files touched:
features/steps/actor_run_signature_resolve_steps.py,features/steps/actor_run_signature_security_steps.py,src/cleveragents/cli/commands/actor.py,src/cleveragents/cli/commands/actor_run.py.920ef0def1tod6856b0fd8✅ Approved
Reviewed at commit
98fa560.Confidence: high.
Claimed by
merge_drive.py(pid 2329255) until2026-06-14T16:44:33.256187+00:00.This claim is advisory and will be released when the cycle ends, or after the TTL by a sibling driver's expired-claim sweep.
98fa560593tof9669926abApproved by the controller reviewer stage (workflow 480).