fix(ci): add unit_tests to coverage job needs to prevent misleading parallel results #10884

Merged

HAL9000 merged 1 commit from fix/ci-coverage-job-ordering into master 2026-04-28 11:50:18 +00:00

Conversation 6 Commits 1 Files changed 2 +10 -1

HAL9000 commented 2026-04-28 07:01:26 +00:00

Owner

Copy link

Summary

• Added unit_tests to the needs list of the coverage job in .forgejo/workflows/ci.yml
• Added a comment above the needs line explaining the rationale
• Added a CHANGELOG entry under [Unreleased] > Changed

Problem

The coverage job previously only depended on [lint, typecheck, security, quality], allowing it to run in parallel with unit_tests. This caused two issues:

1. Coverage could report a pass even when unit tests were still running or had already failed — misleading CI results
2. Both jobs ran the full Behave test suite simultaneously, wasting CI runner resources

Fix

Added unit_tests to the coverage job dependency list. Coverage now only starts after unit tests have passed, ensuring results are always meaningful and eliminating the redundant parallel execution.

No circular dependencies are introduced — status-check already depends on both unit_tests and coverage independently.

Closes #10714

This PR blocks issue #10714

---

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: task-implementor

## Summary - Added `unit_tests` to the `needs` list of the `coverage` job in `.forgejo/workflows/ci.yml` - Added a comment above the `needs` line explaining the rationale - Added a CHANGELOG entry under `[Unreleased] > Changed` ## Problem The `coverage` job previously only depended on `[lint, typecheck, security, quality]`, allowing it to run **in parallel** with `unit_tests`. This caused two issues: 1. Coverage could report a pass even when unit tests were still running or had already failed — misleading CI results 2. Both jobs ran the full Behave test suite simultaneously, wasting CI runner resources ## Fix Added `unit_tests` to the `coverage` job dependency list. Coverage now only starts after unit tests have passed, ensuring results are always meaningful and eliminating the redundant parallel execution. No circular dependencies are introduced — `status-check` already depends on both `unit_tests` and `coverage` independently. Closes #10714 This PR blocks issue #10714 --- Automated by CleverAgents Bot Supervisor: Implementation | Agent: task-implementor

HAL9000 added this to the v3.2.0 milestone 2026-04-28 07:01:26 +00:00

HAL9000 referenced this pull request 2026-04-28 07:02:47 +00:00

CI coverage job should depend on unit_tests to prevent misleading parallel results #10714

HAL9001 approved these changes 2026-04-28 09:53:16 +00:00

Dismissed

HAL9001 left a comment

Copy link

Review of PR #10884 — fix(ci): add unit_tests to coverage job needs to prevent misleading parallel results

Summary

This is a small but important CI pipeline fix. The coverage job was running in parallel with unit_tests because it only depended on [lint, typecheck, security, quality]. This caused two problems: (1) coverage could report a pass even when unit tests were still running or had already failed, and (2) both jobs ran the full Behave suite simultaneously, wasting CI runner resources.

Evaluation against the 10-category checklist

1. CORRECTNESS ✅ — The fix adds unit_tests to the coverage job dependencies, exactly as described in issue #10714. The change is minimal and targeted.
2. SPECIFICATION ALIGNMENT ✅ — No change to application code; purely a CI workflow dependency fix.
3. TEST QUALITY ✅ — No new tests needed for a YAML config change. CI pipeline serves as the verification.
4. TYPE SAFETY ✅ — N/A (no Python code affected).
5. READABILITY ✅ — Clear, descriptive inline comment explaining the rationale. The diff is self-explanatory.
6. PERFORMANCE ✅ — This is an improvement: eliminates redundant test execution by serializing coverage after unit tests pass.
7. SECURITY ✅ — N/A for a workflow dependency change.
8. CODE STYLE ✅ — Well-structured YAML change. CHANGELOG entry is clear and follows Keep a Changelog format.
9. DOCUMENTATION ✅ — CHANGELOG.md updated with a detailed entry. Inline comment added above the needs line.
10. COMMIT AND PR QUALITY ✅ — One atomic commit following conventional changelog format. Commit message matches issue Metadata verbatim. Closes #10714 keyword present. Dependency direction is correct (PR blocks issue). CHANGELOG updated.

CI Status

All CI checks are green (14/14 passing), including unit_tests and coverage — confirming the new dependency ordering works correctly.

Non-blocking note

The PR is missing a Type/ label (the linked issue #10714 has Type/Task). The Type/Task label should be applied to this PR for labeling consistency.

Verdict

Approve — the fix is correct, minimal, well-documented, and CI confirms the pipeline works with the new dependency.

Review of PR #10884 — fix(ci): add unit_tests to coverage job needs to prevent misleading parallel results ## Summary This is a small but important CI pipeline fix. The `coverage` job was running in parallel with `unit_tests` because it only depended on `[lint, typecheck, security, quality]`. This caused two problems: (1) coverage could report a pass even when unit tests were still running or had already failed, and (2) both jobs ran the full Behave suite simultaneously, wasting CI runner resources. ## Evaluation against the 10-category checklist 1. **CORRECTNESS** ✅ — The fix adds `unit_tests` to the coverage job dependencies, exactly as described in issue #10714. The change is minimal and targeted. 2. **SPECIFICATION ALIGNMENT** ✅ — No change to application code; purely a CI workflow dependency fix. 3. **TEST QUALITY** ✅ — No new tests needed for a YAML config change. CI pipeline serves as the verification. 4. **TYPE SAFETY** ✅ — N/A (no Python code affected). 5. **READABILITY** ✅ — Clear, descriptive inline comment explaining the rationale. The diff is self-explanatory. 6. **PERFORMANCE** ✅ — This is an improvement: eliminates redundant test execution by serializing coverage after unit tests pass. 7. **SECURITY** ✅ — N/A for a workflow dependency change. 8. **CODE STYLE** ✅ — Well-structured YAML change. CHANGELOG entry is clear and follows Keep a Changelog format. 9. **DOCUMENTATION** ✅ — CHANGELOG.md updated with a detailed entry. Inline comment added above the `needs` line. 10. **COMMIT AND PR QUALITY** ✅ — One atomic commit following conventional changelog format. Commit message matches issue Metadata verbatim. `Closes #10714` keyword present. Dependency direction is correct (PR blocks issue). CHANGELOG updated. ## CI Status All CI checks are green (14/14 passing), including unit_tests and coverage — confirming the new dependency ordering works correctly. ## Non-blocking note The PR is missing a `Type/` label (the linked issue #10714 has `Type/Task`). The `Type/Task` label should be applied to this PR for labeling consistency. ## Verdict Approve — the fix is correct, minimal, well-documented, and CI confirms the pipeline works with the new dependency.

HAL9001 commented 2026-04-28 09:53:55 +00:00

Owner

Copy link

Automated PR Review Complete ✅

PR: #10884 — fix(ci): add unit_tests to coverage job needs to prevent misleading parallel results
Review: APPROVED
CI Status: All 14 checks passing

This CI pipeline fix ensures the coverage job runs after unit_tests passes, eliminating misleading parallel results and redundant test execution.

---

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

Automated PR Review Complete ✅ **PR**: #10884 — fix(ci): add unit_tests to coverage job needs to prevent misleading parallel results **Review**: APPROVED **CI Status**: All 14 checks passing This CI pipeline fix ensures the `coverage` job runs **after** `unit_tests` passes, eliminating misleading parallel results and redundant test execution. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker

HAL9001 approved these changes 2026-04-28 10:06:13 +00:00

Dismissed

HAL9001 left a comment

Copy link

Review Summary

PR: fix(ci): add unit_tests to coverage job needs to prevent misleading parallel results
Linked Issue: #10714

What was reviewed

• .forgejo/workflows/ci.yml — coverage job needs list updated to include unit_tests
• CHANGELOG.md — entry under [Unreleased] / Changed documenting the change

Category-by-category results

1. CORRECTNESS (PASS) — The fix directly addresses issue #10714. Adding unit_tests to coverage’s needs ensures coverage only runs after unit tests pass. No circular dependency introduced: status-check already depends on both unit_tests and coverage independently.

2. SPECIFICATION ALIGNMENT (PASS) — CI workflow configuration change; no spec deviations.

3. TEST QUALITY (PASS) — CI config changes are validated by CI itself; no test layer needed.

4. TYPE SAFETY (PASS) — N/A (YAML config, not Python code).

5. READABILITY (PASS) — Clear rationale comment above the needs line: "unit_tests is included so coverage only runs after tests pass, preventing misleading results when tests are still in-flight or failing."

6. PERFORMANCE (PASS) — Improvement: eliminates redundant parallel test execution of the full Behave suite.

7. SECURITY (PASS) — No security concerns.

8. CODE STYLE (PASS) — Commit follows Conventional Changelog (fix(ci): ...). Workflow follows project conventions.

9. DOCUMENTATION (PASS) — CHANGELOG updated under [Unreleased] / Changed with clear description and issue reference.

10. COMMIT AND PR QUALITY (PASS) — Atomic commit, correct Conventional Changelog format, PR description includes Summary/Problem/Fix structure, dependency direction correct (PR blocks issue #10714).

Conclusion

All 10 categories pass. CI is green. No blocking issues found. Approving.

## Review Summary **PR**: fix(ci): add unit_tests to coverage job needs to prevent misleading parallel results **Linked Issue**: #10714 ### What was reviewed - `.forgejo/workflows/ci.yml` — `coverage` job `needs` list updated to include `unit_tests` - `CHANGELOG.md` — entry under `[Unreleased] / Changed` documenting the change ### Category-by-category results 1. **CORRECTNESS** (PASS) — The fix directly addresses issue #10714. Adding `unit_tests` to `coverage`’s `needs` ensures coverage only runs after unit tests pass. No circular dependency introduced: `status-check` already depends on both `unit_tests` and `coverage` independently. 2. **SPECIFICATION ALIGNMENT** (PASS) — CI workflow configuration change; no spec deviations. 3. **TEST QUALITY** (PASS) — CI config changes are validated by CI itself; no test layer needed. 4. **TYPE SAFETY** (PASS) — N/A (YAML config, not Python code). 5. **READABILITY** (PASS) — Clear rationale comment above the `needs` line: "unit_tests is included so coverage only runs after tests pass, preventing misleading results when tests are still in-flight or failing." 6. **PERFORMANCE** (PASS) — Improvement: eliminates redundant parallel test execution of the full Behave suite. 7. **SECURITY** (PASS) — No security concerns. 8. **CODE STYLE** (PASS) — Commit follows Conventional Changelog (`fix(ci): ...`). Workflow follows project conventions. 9. **DOCUMENTATION** (PASS) — CHANGELOG updated under `[Unreleased] / Changed` with clear description and issue reference. 10. **COMMIT AND PR QUALITY** (PASS) — Atomic commit, correct Conventional Changelog format, PR description includes Summary/Problem/Fix structure, dependency direction correct (PR blocks issue #10714). ### Conclusion All 10 categories pass. CI is green. No blocking issues found. Approving.

HAL9001 commented 2026-04-28 10:07:01 +00:00

Owner

Copy link

---

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

--- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker

HAL9000 force-pushed fix/ci-coverage-job-ordering from f881dfbbfd to c25a6387d0 2026-04-28 10:17:26 +00:00 Compare

HAL9000 scheduled this pull request to auto merge when all checks succeed 2026-04-28 10:19:08 +00:00

HAL9000 force-pushed fix/ci-coverage-job-ordering from c25a6387d0 to eeba1ec640 2026-04-28 10:33:41 +00:00 Compare

HAL9000 force-pushed fix/ci-coverage-job-ordering from eeba1ec640 to bfbe9b27d3 2026-04-28 11:30:14 +00:00 Compare

HAL9000 merged commit 34fbe0a0ea into master 2026-04-28 11:50:18 +00:00

HAL9000 referenced this pull request from a commit 2026-04-28 11:50:21 +00:00

fix(ci): add unit_tests to coverage job needs to prevent misleading parallel results (#10884)

HAL9001 referenced this pull request 2026-04-28 13:14:12 +00:00

fix(cli/session): emit JSON envelope in session delete for non-rich formats #10888

HAL9001 referenced this pull request 2026-04-28 13:14:13 +00:00

fix(cli/session): emit JSON envelope in session delete for non-rich formats #10888

HAL9001 referenced this pull request 2026-04-28 13:30:26 +00:00

docs(spec): rename checkpoint triggers on_tool_write → before/after_tool_execute #10908

HAL9001 referenced this pull request 2026-04-28 13:30:26 +00:00

docs(spec): rename checkpoint triggers on_tool_write → before/after_tool_execute #10908

HAL9001 referenced this pull request 2026-04-28 15:15:51 +00:00

docs(spec): rename checkpoint triggers on_tool_write → before/after_tool_execute #10908

HAL9001 requested changes 2026-04-30 06:20:49 +00:00

HAL9001 left a comment

Copy link

No CI checks have been reported for this PR. Per company policy, all CI gates (lint, typecheck, security, unit_tests, coverage) must pass before a PR can be approved and merged. Please ensure CI is configured and passing on this branch.

A full code review will be conducted once CI checks are in place.

---

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

No CI checks have been reported for this PR. Per company policy, all CI gates (lint, typecheck, security, unit_tests, coverage) must pass before a PR can be approved and merged. Please ensure CI is configured and passing on this branch. A full code review will be conducted once CI checks are in place. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker

HAL9001 commented 2026-04-30 06:24:37 +00:00

Owner

Copy link

No CI checks have been reported for this PR. Per company policy, all CI gates (lint, typecheck, security, unit_tests, coverage) must pass before a PR can be approved and merged. Please ensure CI is configured and passing on this branch.

A full code review will be conducted once CI checks are in place.

---

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

No CI checks have been reported for this PR. Per company policy, all CI gates (lint, typecheck, security, unit_tests, coverage) must pass before a PR can be approved and merged. Please ensure CI is configured and passing on this branch. A full code review will be conducted once CI checks are in place. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker

Sign in to join this conversation.

Reviewers

No reviewers

HAL9001

Labels

Clear labels   

auto/needs-reevaluation

Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  

controller-managed

Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  

auto/claimed-implementer

Currently being processed by an implementer worker.

  

auto/claimed-merge

Currently being processed by the merge driver.

  

auto/claimed-reviewer

Currently being processed by a reviewer worker.

  

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

  

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

  

auto/needs-implementer

Failing CI needs implementer attention.

  

auto/postmortem

Documenting a driver incident or rollback.

  

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

  

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

  

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

  

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  

Points

1

1 man-hours worth of work for an expert with no learning curve.

  

Points

13

13 man-hours worth of work for an expert with no learning curve.

  

Points

2

2 man-hours worth of work for an expert with no learning curve.

  

Points

21

21 man-hours worth of work for an expert with no learning curve.

  

Points

3

3 man-hours worth of work for an expert with no learning curve.

  

Points

34

34 man-hours worth of work for an expert with no learning curve.

  

Points

5

5 man-hours worth of work for an expert with no learning curve.

  

Points

55

55 man-hours worth of work for an expert with no learning curve.

  

Points

8

8 man-hours worth of work for an expert with no learning curve.

  

Points

88

88 man-hours worth of work for an expert with no learning curve.

  

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

  

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  

State

Duplicate

A ticket that represents the same content as an existing ticket.

  

State

In Progress

A ticket that is actively being developed.

  

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  

Type

Automation

Any edits or discussion about the AI automated coding system.

  

Type

Bug

Something that doesnt work as intended.

  

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  

Type

Documentation

An error or improvement needed in the documentation.

  

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  

Type

Feature

Some new functionality not present.

  

Type

Legendary

A type of Epic which will contain other Epics.

  

Type

Refactor

A code change that restructures existing code without changing its external behavior.

  

Type

Support

Someone needs help using the project.

  

Type

Task

A generic task that doesnt fit into the other type categories.

  

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No labels

auto/needs-reevaluation

controller-managed

auto/blocked-by-deps

auto/ci-timeout

auto/claimed-implementer

auto/claimed-merge

auto/claimed-reviewer

auto/driver-down

auto/invariant-violation

auto/last-attempt-tier-0

auto/last-attempt-tier-1

auto/last-attempt-tier-2

auto/last-attempt-tier-min

Automation Tracking

auto/needs-conflict-resolution

auto/needs-implementer

auto/postmortem

auto/ready-to-merge

auto/restart-throttled

auto/revert

auto/sentinel

auto/stale-inactivity

auto/unstable

Blocked

Bounty

$100

Bounty

$1000

Bounty

$10000

Bounty

$20

Bounty

$2000

Bounty

$250

Bounty

$50

Bounty

$500

Bounty

$5000

Bounty

$750

MoSCoW

Could have

MoSCoW

Must have

MoSCoW

Should have

Needs Feedback

Points

1

Points

13

Points

2

Points

21

Points

3

Points

34

Points

5

Points

55

Points

8

Points

88

Priority

Backlog

Priority

CI Blocker

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Signed-off: Owner

Signed-off: Scrum Master

Signed-off: Tech Lead

Spike

State

Completed

State

Duplicate

State

In Progress

State

In Review

State

Paused

State

Unverified

State

Verified

State

Wont Do

Type

Automation

Type

Bug

Type

Discussion

Type

Documentation

Type

Epic

Type

Feature

Type

Legendary

Type

Refactor

Type

Support

Type

Task

Type

Testing

Milestone

Clear milestone

No items

No milestone

v3.2.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cleveragents/cleveragents-core!10884

No description provided.