fix(ci): add unit_tests to coverage job needs to prevent misleading parallel results (#10884)
CI / benchmark-publish (push) Failing after 41s
CI / build (push) Successful in 53s
CI / lint (push) Successful in 58s
CI / helm (push) Successful in 29s
CI / push-validation (push) Successful in 33s
CI / quality (push) Successful in 1m21s
CI / security (push) Successful in 1m42s
CI / typecheck (push) Successful in 1m52s
CI / integration_tests (push) Successful in 3m31s
CI / e2e_tests (push) Successful in 3m47s
CI / unit_tests (push) Successful in 4m50s
CI / docker (push) Successful in 1m30s
CI / coverage (push) Successful in 12m55s
CI / status-check (push) Successful in 14s
CI / benchmark-publish (pull_request) Has been skipped
CI / coverage (pull_request) Successful in 11m38s
CI / push-validation (pull_request) Successful in 21s
CI / lint (pull_request) Successful in 1m2s
CI / build (pull_request) Successful in 44s
CI / typecheck (pull_request) Successful in 1m36s
CI / quality (pull_request) Successful in 1m37s
CI / helm (pull_request) Successful in 28s
CI / security (pull_request) Successful in 1m44s
CI / integration_tests (pull_request) Successful in 3m37s
CI / e2e_tests (pull_request) Successful in 4m17s
CI / unit_tests (pull_request) Successful in 4m49s
CI / docker (pull_request) Successful in 1m35s
CI / status-check (pull_request) Successful in 4s
CI / benchmark-publish (push) Failing after 41s
CI / build (push) Successful in 53s
CI / lint (push) Successful in 58s
CI / helm (push) Successful in 29s
CI / push-validation (push) Successful in 33s
CI / quality (push) Successful in 1m21s
CI / security (push) Successful in 1m42s
CI / typecheck (push) Successful in 1m52s
CI / integration_tests (push) Successful in 3m31s
CI / e2e_tests (push) Successful in 3m47s
CI / unit_tests (push) Successful in 4m50s
CI / docker (push) Successful in 1m30s
CI / coverage (push) Successful in 12m55s
CI / status-check (push) Successful in 14s
CI / benchmark-publish (pull_request) Has been skipped
CI / coverage (pull_request) Successful in 11m38s
CI / push-validation (pull_request) Successful in 21s
CI / lint (pull_request) Successful in 1m2s
CI / build (pull_request) Successful in 44s
CI / typecheck (pull_request) Successful in 1m36s
CI / quality (pull_request) Successful in 1m37s
CI / helm (pull_request) Successful in 28s
CI / security (pull_request) Successful in 1m44s
CI / integration_tests (pull_request) Successful in 3m37s
CI / e2e_tests (pull_request) Successful in 4m17s
CI / unit_tests (pull_request) Successful in 4m49s
CI / docker (pull_request) Successful in 1m35s
CI / status-check (pull_request) Successful in 4s
This commit was merged in pull request #10884.
This commit is contained in:
@@ -338,7 +338,9 @@ jobs:
|
||||
runs-on: docker
|
||||
container:
|
||||
image: ${{vars.docker_prefix}}python:3.13-slim
|
||||
needs: [lint, typecheck, security, quality]
|
||||
# unit_tests is included so coverage only runs after tests pass,
|
||||
# preventing misleading results when tests are still in-flight or failing.
|
||||
needs: [lint, typecheck, security, quality, unit_tests]
|
||||
steps:
|
||||
- name: Install system dependencies (nodejs for checkout, git for merge tests)
|
||||
run: |
|
||||
|
||||
@@ -7,6 +7,13 @@ The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
|
||||
|
||||
### Changed
|
||||
|
||||
- **CI coverage job now waits for unit_tests** (#10714): Added `unit_tests` to the
|
||||
`needs` list of the `coverage` job in `ci.yml`. Previously the coverage job ran
|
||||
in parallel with unit tests, which could produce misleading pass results when
|
||||
tests were still in-flight or had already failed. Coverage now only starts after
|
||||
unit tests succeed, eliminating redundant parallel test execution and ensuring
|
||||
coverage results are always meaningful.
|
||||
|
||||
- **Diagnostics spec examples expanded to all 9 providers** (#5320): Updated the
|
||||
`agents diagnostics` command examples in the specification to show all 9 supported
|
||||
providers (OpenAI, Anthropic, Google, Gemini, Azure, OpenRouter, Cohere, Groq,
|
||||
|
||||
Reference in New Issue
Block a user