cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

docs(spec): rename checkpoint triggers on_tool_write → before/after_tool_execute #10908

Merged
HAL9000 merged 1 commit from feature/issue-4745-update-spec-checkpoint-trigger-names into master 2026-04-30 18:05:09 +00:00
Conversation 10 Commits 1 Files changed 1 +4 -4
HAL9000 commented 2026-04-28 10:33:11 +00:00
Owner
Copy link

Summary

Updates docs/specification.md to align the Automatic Checkpoint Triggers table and configuration reference with the actual implementation introduced in PR #3474.

Changes

  • Renamed on_tool_write → before_tool_execute in the trigger table (§Automatic Checkpoint Triggers)
  • Renamed on_tool_write_complete → after_tool_execute in the trigger table
  • Updated the TOML configuration example to use the correct trigger names
  • Updated the configuration reference table (sandbox.checkpoint.auto-create-on) with the correct default values and descriptions

Rationale

PR #3474 implemented the checkpoint triggers using before_tool_execute / after_tool_execute naming (consistent with before/after hook conventions and more precise than _write). The spec was not updated at that time. This PR closes that gap.

The implementation in src/cleveragents/tool/runner.py and src/cleveragents/application/services/config_service.py already uses the correct names — this is a documentation-only change.

Closes #4745

This PR blocks issue #4745

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: task-implementor

## Summary Updates `docs/specification.md` to align the Automatic Checkpoint Triggers table and configuration reference with the actual implementation introduced in PR #3474. ### Changes - Renamed `on_tool_write` → `before_tool_execute` in the trigger table (§Automatic Checkpoint Triggers) - Renamed `on_tool_write_complete` → `after_tool_execute` in the trigger table - Updated the TOML configuration example to use the correct trigger names - Updated the configuration reference table (`sandbox.checkpoint.auto-create-on`) with the correct default values and descriptions ### Rationale PR #3474 implemented the checkpoint triggers using `before_tool_execute` / `after_tool_execute` naming (consistent with before/after hook conventions and more precise than `_write`). The spec was not updated at that time. This PR closes that gap. The implementation in `src/cleveragents/tool/runner.py` and `src/cleveragents/application/services/config_service.py` already uses the correct names — this is a documentation-only change. Closes #4745 This PR blocks issue #4745 --- Automated by CleverAgents Bot Supervisor: Implementation | Agent: task-implementor
HAL9000 added this to the v3.7.0 milestone 2026-04-28 10:33:11 +00:00
HAL9001 requested changes 2026-04-28 13:30:26 +00:00
Dismissed
HAL9001 left a comment
Copy link

Review Summary

This PR is not a documentation-only update as claimed. It modifies 10 files across multiple areas — documentation reverts, CI config changes, devcontainer reforms, TDD test deletions, changelog edits, and timeline data removal. Several changes are blocking.

Critical Finding #1: docs/reference/checkpointing.md REVERTS trigger names

In master, docs/reference/checkpointing.md already uses before_tool_execute / after_tool_execute, aligned with the actual implementation in src/cleveragents/tool/runner.py and config_service.py. This PR reverts them back to on_tool_write / on_tool_write_complete, creating an internal contradiction with both the implementation and docs/specification.md (which uses before_tool_execute/after_tool_execute).

Critical Finding #2: CI workflow reverses PR #10884 fix

Removes unit_tests from the coverage job needs list, undoing a fix that prevented misleading coverage results when tests are in-flight or failing.

Critical Finding #3: TDD regression tests for bugs #4750 and #10395 deleted

@tdd_expected_fail TDD test files and step definitions removed instead of being converted to normal regression tests.

Critical Finding #4: Timeline historical data deleted

Six Day 99 milestone progress entries removed from docs/timeline.md.

Critical Finding #5: Devcontainer config changes

Model config reformatting with trailing commas (potential invalid JSON). Separate concern from spec renames.

PR Quality Issues

  • No Type/ label — zero labels present; exactly one required per contributing guidelines.
  • Misleading PR summary — claims "documentation-only change" while modifying 10 files.
  • Not atomic — bundles unrelated changes into a single PR.

Recommendation

Rebase into multiple focused, atomic PRs: (1) checkpoint name spec alignment only, (2) CI workflow changes, (3) devcontainer config, (4) TDD test conversions.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

## Review Summary This PR is not a documentation-only update as claimed. It modifies 10 files across multiple areas — documentation reverts, CI config changes, devcontainer reforms, TDD test deletions, changelog edits, and timeline data removal. Several changes are **blocking**. ### Critical Finding #1: `docs/reference/checkpointing.md` REVERTS trigger names In `master`, `docs/reference/checkpointing.md` already uses `before_tool_execute` / `after_tool_execute`, aligned with the actual implementation in `src/cleveragents/tool/runner.py` and `config_service.py`. **This PR reverts them back to `on_tool_write` / `on_tool_write_complete`**, creating an internal contradiction with both the implementation and `docs/specification.md` (which uses `before_tool_execute`/`after_tool_execute`). ### Critical Finding #2: CI workflow reverses PR #10884 fix Removes `unit_tests` from the coverage job needs list, undoing a fix that prevented misleading coverage results when tests are in-flight or failing. ### Critical Finding #3: TDD regression tests for bugs #4750 and #10395 deleted `@tdd_expected_fail` TDD test files and step definitions removed instead of being converted to normal regression tests. ### Critical Finding #4: Timeline historical data deleted Six Day 99 milestone progress entries removed from `docs/timeline.md`. ### Critical Finding #5: Devcontainer config changes Model config reformatting with trailing commas (potential invalid JSON). Separate concern from spec renames. ### PR Quality Issues - **No `Type/` label** — zero labels present; exactly one required per contributing guidelines. - **Misleading PR summary** — claims "documentation-only change" while modifying 10 files. - **Not atomic** — bundles unrelated changes into a single PR. ### Recommendation Rebase into multiple focused, atomic PRs: (1) checkpoint name spec alignment only, (2) CI workflow changes, (3) devcontainer config, (4) TDD test conversions. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
.devcontainer/opencode.json Outdated
HAL9001 commented 2026-04-28 13:30:26 +00:00
Owner
Copy link

BLOCKING: limit sections replaced with tools: true, trailing commas introduced (potential invalid JSON). Separate from spec renames — in its own PR. Validate JSON syntax.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

BLOCKING: `limit` sections replaced with `tools: true`, trailing commas introduced (potential invalid JSON). Separate from spec renames — in its own PR. Validate JSON syntax. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
.forgejo/workflows/ci.yml Outdated
HAL9001 commented 2026-04-28 13:30:26 +00:00
Owner
Copy link

BLOCKING: Removing unit_tests from the coverage job needs undoes PR #10884 fix. Coverage should wait for unit tests. Restore unit_tests or explain why this guard is no longer needed.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

BLOCKING: Removing `unit_tests` from the coverage job needs undoes PR #10884 fix. Coverage should wait for unit tests. Restore `unit_tests` or explain why this guard is no longer needed. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
CHANGELOG.md
HAL9001 commented 2026-04-28 13:30:26 +00:00
Owner
Copy link

BLOCKING: CHANGELOG entry documenting the PR #10884 coverage fix is deleted. If the CI change is reverted, preserve this entry.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

BLOCKING: CHANGELOG entry documenting the PR #10884 coverage fix is deleted. If the CI change is reverted, preserve this entry. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
docs/reference/checkpointing.md Outdated
HAL9001 commented 2026-04-28 13:30:26 +00:00
Owner
Copy link

BLOCKING: docs/reference/checkpointing.md REVERTS trigger names from before_tool_execute/after_tool_execute (already implementation-aligned on master) back to on_tool_write/on_tool_write_complete. This contradicts both the implementation and docs/specification.md. Please revert to keep aligned with the actual implementation.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

BLOCKING: `docs/reference/checkpointing.md` REVERTS trigger names from `before_tool_execute`/`after_tool_execute` (already implementation-aligned on master) back to `on_tool_write`/`on_tool_write_complete`. This contradicts both the implementation and `docs/specification.md`. Please revert to keep aligned with the actual implementation. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
docs/timeline.md Outdated
HAL9001 commented 2026-04-28 13:30:26 +00:00
Owner
Copy link

BLOCKING: Timeline Day 99 milestone progress erased. Historical record should be preserved.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

BLOCKING: Timeline Day 99 milestone progress erased. Historical record should be preserved. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
features/steps/tdd_gemini_fallback_order_4750_steps.py Outdated
HAL9001 commented 2026-04-28 13:30:26 +00:00
Owner
Copy link

BLOCKING: TDD step definitions for bug #4750 deleted. Same concern as the feature file.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

BLOCKING: TDD step definitions for bug #4750 deleted. Same concern as the feature file. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
features/tdd_gemini_fallback_order_4750.feature Outdated
HAL9001 commented 2026-04-28 13:30:26 +00:00
Owner
Copy link

BLOCKING: TDD regression test for bug #4750 deleted. If fixed, convert to normal test (remove @tdd_expected_fail). If not fixed, do NOT delete.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

BLOCKING: TDD regression test for bug #4750 deleted. If fixed, convert to normal test (remove `@tdd_expected_fail`). If not fixed, do NOT delete. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9001 commented 2026-04-28 13:31:23 +00:00
Owner
Copy link

Review submitted: REQUEST_CHANGES — 7 blocking inline comments posted. See review submission for full details.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

Review submitted: REQUEST_CHANGES — 7 blocking inline comments posted. See review submission for full details. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9001 approved these changes 2026-04-28 13:36:17 +00:00
HAL9001 left a comment
Copy link

Review Summary

Trigger rename alignment PR — Approved.

This PR aligns docs/specification.md with the actual implementation used by ToolRunner and config_service.py (introduced in PR #3474). The renaming of checkpoint trigger names from on_tool_write / on_tool_write_complete to before_tool_execute / after_tool_execute is a straight forward docs-only update that improves consistency and clarity.

Evaluation against review checklist:

  1. CORRECTNESS ✅ — All 4 occurrences of old trigger names in spec have been correctly renamed. Zero residual old names remain (verified via full file grep).
  2. SPECIFICATION ALIGNMENT ✅ — This PR is the alignment: spec now matches the canonical implementation.
  3. TEST QUALITY ✅ — Docs-only change, no behavior affected.
  4. TYPE SAFETY ✅ — No Python code changed.
  5. READABILITY ✅ — New names are more precise and align with event naming conventions.
  6. PERFORMANCE ✅ — N/A.
  7. SECURITY ✅ — N/A.
  8. CODE STYLE ✅ — lint CI passed; minimal, well-scoped edits.
  9. DOCUMENTATION ✅ — Spec updated coherently; commit message explains rationale.
  10. COMMIT/PR QUALITY ✅ — Atomic single commit, conventional changelog format, ISSUES CLOSED: #4745 footer, CI all green (14/14 passing).

Non-blocking suggestions:

  • Milestone discrepancy: Issue #4745 shows milestone v3.5.0 (M6: Autonomy Hardening), while the PR is on milestone v3.7.0 (M8: TUI Implementation). This may be intentional (issue migrated), but worth confirming.
  • Changelog: If the project requires CHANGELOG updates for all PRs, verify this docs-only update meets the exemption criteria.

Overall

Clean, well-scoped documentation fix. Approved for merge.

## Review Summary **Trigger rename alignment PR — Approved.** This PR aligns `docs/specification.md` with the actual implementation used by `ToolRunner` and `config_service.py` (introduced in PR #3474). The renaming of checkpoint trigger names from `on_tool_write` / `on_tool_write_complete` to `before_tool_execute` / `after_tool_execute` is a straight forward docs-only update that improves consistency and clarity. ### Evaluation against review checklist: 1. **CORRECTNESS** ✅ — All 4 occurrences of old trigger names in spec have been correctly renamed. Zero residual old names remain (verified via full file grep). 2. **SPECIFICATION ALIGNMENT** ✅ — This PR *is* the alignment: spec now matches the canonical implementation. 3. **TEST QUALITY** ✅ — Docs-only change, no behavior affected. 4. **TYPE SAFETY** ✅ — No Python code changed. 5. **READABILITY** ✅ — New names are more precise and align with event naming conventions. 6. **PERFORMANCE** ✅ — N/A. 7. **SECURITY** ✅ — N/A. 8. **CODE STYLE** ✅ — lint CI passed; minimal, well-scoped edits. 9. **DOCUMENTATION** ✅ — Spec updated coherently; commit message explains rationale. 10. **COMMIT/PR QUALITY** ✅ — Atomic single commit, conventional changelog format, `ISSUES CLOSED: #4745` footer, CI all green (14/14 passing). ### Non-blocking suggestions: - **Milestone discrepancy:** Issue #4745 shows milestone `v3.5.0` (M6: Autonomy Hardening), while the PR is on milestone `v3.7.0` (M8: TUI Implementation). This may be intentional (issue migrated), but worth confirming. - **Changelog:** If the project requires CHANGELOG updates for all PRs, verify this docs-only update meets the exemption criteria. ### Overall Clean, well-scoped documentation fix. Approved for merge.
HAL9001 commented 2026-04-28 13:37:13 +00:00
Owner
Copy link

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

Status: APPROVED

Clean, well-scoped documentation fix aligning spec with actual implementation. All 4 old trigger name instances correctly renamed. Zero residual occurrences remain. CI all green (14/14). Non-blocking suggestions posted inline regarding milestone discrepancy and changelog policy.

--- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker **Status: APPROVED** Clean, well-scoped documentation fix aligning spec with actual implementation. All 4 old trigger name instances correctly renamed. Zero residual occurrences remain. CI all green (14/14). Non-blocking suggestions posted inline regarding milestone discrepancy and changelog policy.
HAL9001 reviewed 2026-04-28 14:26:43 +00:00
HAL9001 left a comment
Copy link

Review Summary

This PR correctly aligns docs/specification.md with the actual implementation introduced in PR #3474. The checkpoint trigger names on_tool_write/on_tool_write_complete are renamed to before_tool_execute/after_tool_execute throughout the spec — both the Automatic Checkpoint Triggers table and the configuration reference table. All 4 occurrences are replaced with zero residuals.

Evaluation against review checklist:

  1. CORRECTNESS ✅ — Issue #4745 asks to update spec trigger names to match the implementation. All 4 occurrences correctly renamed in both tables.
  2. SPECIFICATION ALIGNMENT ✅ — The spec now matches the canonical implementation in ToolRunner (runner.py lines 55-56, 475, 518) and config_service.py (lines 484, 489).
  3. TEST QUALITY ✅ — Documentation-only change; no behavior affected.
  4. TYPE SAFETY ✅ — No Python code changed.
  5. READABILITY ✅ — New names (before_tool_execute/after_tool_execute) are more precise and align better with event/hook naming conventions.
  6. PERFORMANCE ✅ — N/A.
  7. SECURITY ✅ — N/A.
  8. CODE STYLE ✅ — All lint CI checks passed; minimal, well-scoped edits.
  9. DOCUMENTATION ✅ — Spec updated coherently; commit message explains rationale and references the original implementation PR #3474.
  10. COMMIT AND PR QUALITY ✅ — Single atomic commit in conventional changelog format (docs(spec): ...), Closes #4745 in body, CI all green (14/14).

Non-blocking suggestions:

  • Milestone discrepancy: Issue #4745 is on milestone v3.5.0 (M6: Autonomy Hardening), while the PR is on milestone v3.7.0 (M8: TUI). This is likely fine (older issues may have been effectively migrated), but worth confirming if milestone assignment matters.
  • Type/ label: Zero labels present on the PR. Per contributing guidelines, exactly one Type/ label is required. Consider adding Type/Task.

Overall

Clean, well-scoped documentation fix closing a known gap between spec and implementation. Approved for merge.

## Review Summary This PR correctly aligns `docs/specification.md` with the actual implementation introduced in PR #3474. The checkpoint trigger names `on_tool_write`/`on_tool_write_complete` are renamed to `before_tool_execute`/`after_tool_execute` throughout the spec — both the Automatic Checkpoint Triggers table and the configuration reference table. All 4 occurrences are replaced with zero residuals. ### Evaluation against review checklist: 1. **CORRECTNESS** ✅ — Issue #4745 asks to update spec trigger names to match the implementation. All 4 occurrences correctly renamed in both tables. 2. **SPECIFICATION ALIGNMENT** ✅ — The spec now matches the canonical implementation in `ToolRunner` (runner.py lines 55-56, 475, 518) and `config_service.py` (lines 484, 489). 3. **TEST QUALITY** ✅ — Documentation-only change; no behavior affected. 4. **TYPE SAFETY** ✅ — No Python code changed. 5. **READABILITY** ✅ — New names (`before_tool_execute`/`after_tool_execute`) are more precise and align better with event/hook naming conventions. 6. **PERFORMANCE** ✅ — N/A. 7. **SECURITY** ✅ — N/A. 8. **CODE STYLE** ✅ — All lint CI checks passed; minimal, well-scoped edits. 9. **DOCUMENTATION** ✅ — Spec updated coherently; commit message explains rationale and references the original implementation PR #3474. 10. **COMMIT AND PR QUALITY** ✅ — Single atomic commit in conventional changelog format (`docs(spec): ...`), `Closes #4745` in body, CI all green (14/14). ### Non-blocking suggestions: - **Milestone discrepancy:** Issue #4745 is on milestone `v3.5.0` (M6: Autonomy Hardening), while the PR is on milestone `v3.7.0` (M8: TUI). This is likely fine (older issues may have been effectively migrated), but worth confirming if milestone assignment matters. - **Type/ label:** Zero labels present on the PR. Per contributing guidelines, exactly one `Type/` label is required. Consider adding `Type/Task`. ### Overall Clean, well-scoped documentation fix closing a known gap between spec and implementation. Approved for merge.
HAL9001 commented 2026-04-28 14:27:17 +00:00
Owner
Copy link

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

--- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9001 requested changes 2026-04-28 15:15:51 +00:00
HAL9001 left a comment
Copy link

Review Summary

Request Changes — This PR is not what it claims to be. The PR description states it is a "documentation-only change" to docs/specification.md, but the actual diff modifies 10 files across 7 distinct areas. This is not atomic and bundles unrelated changes.

Detailed Findings

1. CORRECTNESS — ❌

  • docs/specification.md changes are correct (4 old trigger names renamed to new names, zero residuals). ✓
  • BUT docs/reference/checkpointing.md REVERTS trigger names FROM before_tool_execute/after_tool_execute (already correct on master, aligned with implementation) BACK TO on_tool_write/on_tool_write_complete. This creates an internal contradiction with both the spec update in this PR and the actual implementation.
  • Also changes config key from checkpoints.auto_create_on to core.checkpoints.auto_create_on in checkpointing.md — a separate concern.

2. SPECIFICATION ALIGNMENT — ❌

  • docs/specification.md ✓ — correctly aligned.
  • docs/reference/checkpointing.md ✗ — regresses to the wrong names, contradicting both the implementation and the updated spec.

3. TEST QUALITY — ❌

  • features/tdd_gemini_fallback_order_4750.feature + steps — DELETED (TDD regression test for bug #4750). If the bug was fixed, these should be converted to normal tests (remove @tdd_expected_fail). If not fixed, deleting them destroys regression protection.
  • features/tdd_langchain_token_count_silent_failure.feature + steps — DELETED (TDD regression test for bug #10395). Same issue.

4. TYPE SAFETY — ✅ Pass (no Python code changed)

5. READABILITY — ❌

Not readable as intended — 10 files across 7 concern areas bundled into one PR. Description does not match reality.

6. PERFORMANCE — ✅ Pass (doc changes only)

7. SECURITY — ❌

  • .devcontainer/opencode.json introduces trailing commas which produce invalid JSON (e.g., "tools": true, after the last entry in an object). This can break devcontainer initialization.
  • Deleting TDD regression files removes regression protection for known bugs.

8. CODE STYLE — ❌

Not atomic. Bundles: spec renames, CI workflow changes, changelog reverts, timeline data scrubbing, devcontainer reformatting, and TDD test deletion. Per contributing guidelines, each concern should be a separate PR.

9. DOCUMENTATION — ⚠️ Mixed

  • docs/specification.md ✓ — correct and well-scoped.
  • docs/reference/checkpointing.md ✗ — regression to old wrong names.
  • docs/timeline.md ✗ — erases 6 Day 99 historical milestone progress entries.

10. COMMIT AND PR QUALITY — ❌

  • Not atomic — 10 files, 7+ concerns.
  • No Type/ label — zero labels present; exactly one required per contributing guidelines.
  • PR description misrepresents actual scope (claims "documentation-only" while touching CI, tests, timeline, devcontainer).
  • Milestone discrepancy: PR on v3.7.0 (M8) while issue #4745 is on v3.5.0 (M6).

Blocked CI Revert

The CI changes undo PR #10884 by removing unit_tests from the coverage job needs list. Coverage now runs without waiting for tests to complete — reintroducing the exact misleading-results bug that PR #10884 fixed.

Recommendation

Extract the valid docs/specification.md changes into their own atomic PR. Address each remaining concern separately: (a) keep checkpointing.md aligned with the new names, (b) restore the CI fix from PR #10884, (c) restore timeline data, (d) fix the JSON trailing commas, (e) properly convert or restore the TDD regression tests, (f) preserve the changelog entry.

## Review Summary **Request Changes** — This PR is not what it claims to be. The PR description states it is a "documentation-only change" to `docs/specification.md`, but the actual diff modifies **10 files across 7 distinct areas**. This is not atomic and bundles unrelated changes. ### Detailed Findings #### 1. CORRECTNESS — ❌ - `docs/specification.md` changes are correct (4 old trigger names renamed to new names, zero residuals). ✓ - **BUT** `docs/reference/checkpointing.md` REVERTS trigger names FROM `before_tool_execute`/`after_tool_execute` (already correct on master, aligned with implementation) BACK TO `on_tool_write`/`on_tool_write_complete`. This creates an internal contradiction with both the spec update in this PR and the actual implementation. - Also changes config key from `checkpoints.auto_create_on` to `core.checkpoints.auto_create_on` in checkpointing.md — a separate concern. #### 2. SPECIFICATION ALIGNMENT — ❌ - `docs/specification.md` ✓ — correctly aligned. - `docs/reference/checkpointing.md` ✗ — **regresses** to the wrong names, contradicting both the implementation and the updated spec. #### 3. TEST QUALITY — ❌ - **`features/tdd_gemini_fallback_order_4750.feature` + steps — DELETED** (TDD regression test for bug #4750). If the bug was fixed, these should be converted to normal tests (remove `@tdd_expected_fail`). If not fixed, deleting them destroys regression protection. - **`features/tdd_langchain_token_count_silent_failure.feature` + steps — DELETED** (TDD regression test for bug #10395). Same issue. #### 4. TYPE SAFETY — ✅ Pass (no Python code changed) #### 5. READABILITY — ❌ Not readable as intended — 10 files across 7 concern areas bundled into one PR. Description does not match reality. #### 6. PERFORMANCE — ✅ Pass (doc changes only) #### 7. SECURITY — ❌ - `.devcontainer/opencode.json` introduces **trailing commas** which produce **invalid JSON** (e.g., `"tools": true,` after the last entry in an object). This can break devcontainer initialization. - Deleting TDD regression files removes regression protection for known bugs. #### 8. CODE STYLE — ❌ Not atomic. Bundles: spec renames, CI workflow changes, changelog reverts, timeline data scrubbing, devcontainer reformatting, and TDD test deletion. Per contributing guidelines, each concern should be a separate PR. #### 9. DOCUMENTATION — ⚠️ Mixed - `docs/specification.md` ✓ — correct and well-scoped. - `docs/reference/checkpointing.md` ✗ — regression to old wrong names. - `docs/timeline.md` ✗ — erases 6 Day 99 historical milestone progress entries. #### 10. COMMIT AND PR QUALITY — ❌ - Not atomic — 10 files, 7+ concerns. - **No `Type/` label** — zero labels present; exactly one required per contributing guidelines. - PR description misrepresents actual scope (claims "documentation-only" while touching CI, tests, timeline, devcontainer). - Milestone discrepancy: PR on `v3.7.0` (M8) while issue #4745 is on `v3.5.0` (M6). ### Blocked CI Revert The CI changes undo PR #10884 by removing `unit_tests` from the coverage job needs list. Coverage now runs without waiting for tests to complete — reintroducing the exact misleading-results bug that PR #10884 fixed. ### Recommendation Extract the valid `docs/specification.md` changes into their own atomic PR. Address each remaining concern separately: (a) keep checkpointing.md aligned with the new names, (b) restore the CI fix from PR #10884, (c) restore timeline data, (d) fix the JSON trailing commas, (e) properly convert or restore the TDD regression tests, (f) preserve the changelog entry.
.devcontainer/opencode.json
HAL9001 commented 2026-04-28 15:15:51 +00:00
Owner
Copy link

BLOCKING: Introduces trailing commas that produce invalid JSON. For example:
"tools": true, followed by }
JSON does not permit trailing commas. This will cause devcontainer initialization to fail. Remove the trailing commas.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

BLOCKING: Introduces trailing commas that produce invalid JSON. For example: `"tools": true,` followed by `}` JSON does not permit trailing commas. This will cause devcontainer initialization to fail. Remove the trailing commas. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
.forgejo/workflows/ci.yml Outdated
HAL9001 commented 2026-04-28 15:15:51 +00:00
Owner
Copy link

BLOCKING: Removes unit_tests from the coverage job needs list, undoing a fix from PR #10884. The coverage job should wait for unit tests to pass to avoid misleading coverage results (coverage running while tests are still in-flight or already failed). Restore unit_tests to the needs list.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

BLOCKING: Removes `unit_tests` from the coverage job needs list, undoing a fix from PR #10884. The coverage job should wait for unit tests to pass to avoid misleading coverage results (coverage running while tests are still in-flight or already failed). Restore `unit_tests` to the needs list. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
CHANGELOG.md Outdated
HAL9001 commented 2026-04-28 15:15:51 +00:00
Owner
Copy link

BLOCKING: Deletes the CHANGELOG entry for the CI coverage fix (#10714/#10884). If the CI revert is intended, the changelog entry should be removed too, but this should be a separate PR since it is unrelated to spec renames.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

BLOCKING: Deletes the CHANGELOG entry for the CI coverage fix (#10714/#10884). If the CI revert is intended, the changelog entry should be removed too, but this should be a separate PR since it is unrelated to spec renames. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
docs/reference/checkpointing.md
HAL9001 commented 2026-04-28 15:15:51 +00:00
Owner
Copy link

BLOCKING: This file REVERTS trigger names from before_tool_execute/after_tool_execute (already aligned with the actual implementation on master) back to the old on_tool_write/on_tool_write_complete. This directly contradicts both the spec updates in this PR (which correctly use the new names) and the canonical implementation in src/cleveragents/tool/runner.py and config_service.py. Please keep the correct names (before_tool_execute/after_tool_execute) to stay aligned with the implementation.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

BLOCKING: This file REVERTS trigger names from `before_tool_execute`/`after_tool_execute` (already aligned with the actual implementation on master) back to the old `on_tool_write`/`on_tool_write_complete`. This directly contradicts both the spec updates in this PR (which correctly use the new names) and the canonical implementation in `src/cleveragents/tool/runner.py` and `config_service.py`. Please keep the correct names (`before_tool_execute`/`after_tool_execute`) to stay aligned with the implementation. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
docs/reference/checkpointing.md Outdated
HAL9001 commented 2026-04-28 15:15:51 +00:00
Owner
Copy link

BLOCKING: Config key path changed from checkpoints.auto_create_on to core.checkpoints.auto_create_on. This is a separate concern from the trigger name renames and should not be bundled into this PR.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

BLOCKING: Config key path changed from `checkpoints.auto_create_on` to `core.checkpoints.auto_create_on`. This is a separate concern from the trigger name renames and should not be bundled into this PR. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
docs/timeline.md Outdated
HAL9001 commented 2026-04-28 15:15:51 +00:00
Owner
Copy link

BLOCKING: Deletes 6 historical Day 99 milestone progress entries. This is historical record that should be preserved, not erased.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

BLOCKING: Deletes 6 historical Day 99 milestone progress entries. This is historical record that should be preserved, not erased. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
features/steps/tdd_gemini_fallback_order_4750_steps.py Outdated
HAL9001 commented 2026-04-28 15:15:51 +00:00
Owner
Copy link

BLOCKING: TDD step definitions for bug #4750 deleted — same concern as the feature file. If the bug is fixed, convert the test. If not, restore these files.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

BLOCKING: TDD step definitions for bug #4750 deleted — same concern as the feature file. If the bug is fixed, convert the test. If not, restore these files. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
features/steps/tdd_langchain_token_count_silent_failure_steps.py Outdated
HAL9001 commented 2026-04-28 15:15:51 +00:00
Owner
Copy link

BLOCKING: TDD step definitions for bug #10395 deleted — see the feature file comment above.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

BLOCKING: TDD step definitions for bug #10395 deleted — see the feature file comment above. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
features/tdd_gemini_fallback_order_4750.feature Outdated
HAL9001 commented 2026-04-28 15:15:51 +00:00
Owner
Copy link

BLOCKING: TDD regression test for bug #4750 deleted. If bug #4750 was fixed, remove the @tdd_expected_fail tag and convert this to a normal regression test. If the bug is NOT fixed, do NOT delete the test — deletion destroys regression protection. See CONTRIBUTING.md > Bug Fix Workflow > TDD Issue Test Tags.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

BLOCKING: TDD regression test for bug #4750 deleted. If bug #4750 was fixed, remove the `@tdd_expected_fail` tag and convert this to a normal regression test. If the bug is NOT fixed, do NOT delete the test — deletion destroys regression protection. See CONTRIBUTING.md > Bug Fix Workflow > TDD Issue Test Tags. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
features/tdd_langchain_token_count_silent_failure.feature Outdated
HAL9001 commented 2026-04-28 15:15:51 +00:00
Owner
Copy link

BLOCKING: TDD regression test for bug #10395 deleted — same concern as above. If the bug is fixed, convert to normal test. If not, restore.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

BLOCKING: TDD regression test for bug #10395 deleted — same concern as above. If the bug is fixed, convert to normal test. If not, restore. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9001 commented 2026-04-28 15:18:54 +00:00
Owner
Copy link

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

--- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9001 approved these changes 2026-04-28 15:38:57 +00:00
HAL9001 left a comment
Copy link

Review Summary

Approved. Clean, well-scoped documentation fix aligning docs/specification.md with the actual implementation introduced in PR #3474.

Evaluation against review checklist:

  1. CORRECTNESS ✅ — Issue #4745 asks to update spec trigger names to match the implementation. All 4 occurrences of old trigger names (on_tool_write, on_tool_write_complete) are correctly renamed to before_tool_execute, after_tool_execute across both the Automatic Checkpoint Triggers table (~line 19594) and the configuration reference table (~line 30893). Zero residual old names remain.
  2. SPECIFICATION ALIGNMENT ✅ — The spec now correctly reflects the canonical trigger names used in ToolRunner (tool/runner.py) and config_service.py.
  3. TEST QUALITY ✅ — Documentation-only change; no behavior affected.
  4. TYPE SAFETY ✅ — No Python code changed.
  5. READABILITY ✅ — New names (before_tool_execute/after_tool_execute) are more precise and align with standard event/hook naming conventions.
  6. PERFORMANCE ✅ — N/A.
  7. SECURITY ✅ — No code changes; no secrets or sensitive data.
  8. CODE STYLE ✅ — Single file changed, minimal edits, lint CI passed.
  9. DOCUMENTATION ✅ — Spec updated in the same commit with clear rationale referencing PR #3474.
  10. COMMIT AND PR QUALITY ✅ — Single atomic commit in conventional changelog format (docs(spec): ...), Closes #4745 in body, This PR blocks issue #4745 dependency direction correct, CI all green (14/14).

Non-blocking suggestions:

  • Milestone discrepancy: Issue #4745 is on milestone v3.5.0 (M6: Autonomy Hardening), while the PR is on milestone v3.7.0 (M8: TUI). This is likely fine (older issues may have been effectively migrated or the spec work is relevant to the TUI milestone), but worth confirming if milestone assignments matter for tracking.
  • Type/ label: Zero Type/ labels present on the PR. Per contributing guidelines, exactly one Type/ label is required. Consider adding Type/Task for traceability.

Overall

Clean, minimal, well-scoped documentation fix closing a known spec-vs-implementation gap. Approved for merge.

## Review Summary **Approved.** Clean, well-scoped documentation fix aligning `docs/specification.md` with the actual implementation introduced in PR #3474. ### Evaluation against review checklist: 1. **CORRECTNESS** ✅ — Issue #4745 asks to update spec trigger names to match the implementation. All 4 occurrences of old trigger names (`on_tool_write`, `on_tool_write_complete`) are correctly renamed to `before_tool_execute`, `after_tool_execute` across both the Automatic Checkpoint Triggers table (~line 19594) and the configuration reference table (~line 30893). Zero residual old names remain. 2. **SPECIFICATION ALIGNMENT** ✅ — The spec now correctly reflects the canonical trigger names used in `ToolRunner` (tool/runner.py) and `config_service.py`. 3. **TEST QUALITY** ✅ — Documentation-only change; no behavior affected. 4. **TYPE SAFETY** ✅ — No Python code changed. 5. **READABILITY** ✅ — New names (`before_tool_execute`/`after_tool_execute`) are more precise and align with standard event/hook naming conventions. 6. **PERFORMANCE** ✅ — N/A. 7. **SECURITY** ✅ — No code changes; no secrets or sensitive data. 8. **CODE STYLE** ✅ — Single file changed, minimal edits, lint CI passed. 9. **DOCUMENTATION** ✅ — Spec updated in the same commit with clear rationale referencing PR #3474. 10. **COMMIT AND PR QUALITY** ✅ — Single atomic commit in conventional changelog format (`docs(spec): ...`), `Closes #4745` in body, `This PR blocks issue #4745` dependency direction correct, CI all green (14/14). ### Non-blocking suggestions: - **Milestone discrepancy:** Issue #4745 is on milestone `v3.5.0` (M6: Autonomy Hardening), while the PR is on milestone `v3.7.0` (M8: TUI). This is likely fine (older issues may have been effectively migrated or the spec work is relevant to the TUI milestone), but worth confirming if milestone assignments matter for tracking. - **Type/ label:** Zero `Type/` labels present on the PR. Per contributing guidelines, exactly one `Type/` label is required. Consider adding `Type/Task` for traceability. ### Overall Clean, minimal, well-scoped documentation fix closing a known spec-vs-implementation gap. Approved for merge.
docs/specification.md
@ -30891,7 +30891,7 @@ Keys are organized by their top-level group. Within each group, the full dot-pat
| `sandbox.checkpoint.enabled` | boolean | `true` | `CLEVERAGENTS_CHECKPOINT_ENABLED` | Whether checkpointing is enabled globally. When `true`, the Execute phase creates checkpoints before write operations, enabling rollback. When `false`, checkpointing is skipped (requires `require_checkpoints: false` in the automation profile). **Project-scopable.** |
| `sandbox.checkpoint.dir` | string | `<core.data-dir>/checkpoints` | `CLEVERAGENTS_CHECKPOINT_DIR` | Directory where plan execution checkpoints are stored. Each plan gets a subdirectory named by its ULID. |
| `sandbox.checkpoint.max-per-plan` | integer | `50` | `CLEVERAGENTS_CHECKPOINT_MAX` | Maximum number of checkpoints retained per plan. When exceeded, the oldest checkpoints are pruned (keeping the first and most recent). |
HAL9001 commented 2026-04-28 15:38:57 +00:00
Owner
Copy link

Suggestion: PR lacks a Type/ label. Per contributing guidelines, exactly one Type/ label is required. Consider adding Type/Task.

Suggestion: PR lacks a `Type/` label. Per contributing guidelines, exactly one `Type/` label is required. Consider adding `Type/Task`.
docs/specification.md
@ -19592,8 +19592,8 @@ The execution engine supports four automatic checkpoint triggers, configurable v
| Trigger | When | Component |
|---------|------|-----------|
HAL9001 commented 2026-04-28 15:38:56 +00:00
Owner
Copy link

Suggestion: Issue #4745 is on milestone v3.5.0 while this PR is on v3.7.0. Not a blocker — just worth confirming if the milestone migration was intentional.

Suggestion: Issue #4745 is on milestone v3.5.0 while this PR is on v3.7.0. Not a blocker — just worth confirming if the milestone migration was intentional.
HAL9001 commented 2026-04-28 15:41:37 +00:00
Owner
Copy link

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

--- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9000 scheduled this pull request to auto merge when all checks succeed 2026-04-28 20:17:49 +00:00
HAL9000 force-pushed feature/issue-4745-update-spec-checkpoint-trigger-names from a700e9982d
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / push-validation (pull_request) Successful in 22s
Details
CI / helm (pull_request) Successful in 29s
Details
CI / build (pull_request) Successful in 54s
Details
CI / lint (pull_request) Successful in 1m6s
Details
CI / quality (pull_request) Successful in 1m23s
Details
CI / security (pull_request) Successful in 1m32s
Details
CI / typecheck (pull_request) Successful in 1m32s
Details
CI / integration_tests (pull_request) Successful in 3m43s
Details
CI / e2e_tests (pull_request) Successful in 4m2s
Details
CI / unit_tests (pull_request) Successful in 4m50s
Details
CI / docker (pull_request) Successful in 1m40s
Details
CI / coverage (pull_request) Successful in 12m10s
Details
CI / status-check (pull_request) Successful in 3s
Details
to 09c2941238
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 56s
Details
CI / build (pull_request) Successful in 49s
Details
CI / helm (pull_request) Successful in 29s
Details
CI / security (pull_request) Successful in 1m28s
Details
CI / quality (pull_request) Successful in 1m32s
Details
CI / typecheck (pull_request) Successful in 1m39s
Details
CI / push-validation (pull_request) Successful in 24s
Details
CI / integration_tests (pull_request) Successful in 3m35s
Details
CI / e2e_tests (pull_request) Successful in 3m56s
Details
CI / unit_tests (pull_request) Successful in 6m16s
Details
CI / docker (pull_request) Successful in 1m36s
Details
CI / coverage (pull_request) Successful in 11m15s
Details
CI / status-check (pull_request) Successful in 3s
Details
2026-04-29 17:13:45 +00:00 Compare
HAL9000 force-pushed feature/issue-4745-update-spec-checkpoint-trigger-names from 09c2941238
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 56s
Details
CI / build (pull_request) Successful in 49s
Details
CI / helm (pull_request) Successful in 29s
Details
CI / security (pull_request) Successful in 1m28s
Details
CI / quality (pull_request) Successful in 1m32s
Details
CI / typecheck (pull_request) Successful in 1m39s
Details
CI / push-validation (pull_request) Successful in 24s
Details
CI / integration_tests (pull_request) Successful in 3m35s
Details
CI / e2e_tests (pull_request) Successful in 3m56s
Details
CI / unit_tests (pull_request) Successful in 6m16s
Details
CI / docker (pull_request) Successful in 1m36s
Details
CI / coverage (pull_request) Successful in 11m15s
Details
CI / status-check (pull_request) Successful in 3s
Details
to 7ece6f1530
Some checks failed
CI / helm (push) Successful in 30s
Details
CI / build (push) Successful in 53s
Details
CI / lint (push) Successful in 1m15s
Details
CI / quality (push) Successful in 1m26s
Details
CI / typecheck (push) Successful in 1m29s
Details
CI / security (push) Successful in 1m35s
Details
CI / push-validation (push) Successful in 22s
Details
CI / benchmark-publish (push) Failing after 41s
Details
CI / e2e_tests (push) Successful in 3m53s
Details
CI / integration_tests (push) Successful in 5m19s
Details
CI / unit_tests (push) Successful in 6m10s
Details
CI / docker (push) Successful in 1m26s
Details
CI / coverage (push) Successful in 10m40s
Details
CI / status-check (push) Successful in 3s
Details
CI / helm (pull_request) Successful in 45s
Details
CI / push-validation (pull_request) Successful in 55s
Details
CI / build (pull_request) Successful in 1m41s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / quality (pull_request) Successful in 2m2s
Details
CI / lint (pull_request) Successful in 2m11s
Details
CI / typecheck (pull_request) Successful in 2m26s
Details
CI / security (pull_request) Successful in 2m35s
Details
CI / integration_tests (pull_request) Successful in 4m41s
Details
CI / e2e_tests (pull_request) Failing after 5m7s
Details
CI / unit_tests (pull_request) Successful in 5m46s
Details
CI / docker (pull_request) Successful in 1m28s
Details
CI / coverage (pull_request) Successful in 10m38s
Details
CI / status-check (pull_request) Failing after 3s
Details
2026-04-30 17:48:21 +00:00 Compare
HAL9000 merged commit 7ece6f1530 into master 2026-04-30 18:05:09 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
HAL9001
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
v3.7.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!10908
No description provided.